Re: [Development] Status of QTimeZone

2013-04-15 Thread Thiago Macieira
On segunda-feira, 15 de abril de 2013 13.11.25, Mitch Curtis wrote: > On 03/25/2013 10:43 PM, John Layt wrote: > > 4) The QDateTime QDataStream was changed in 5.0 to write all times as UTC, > > but I think this is wrong. Qt::LocalTime is clearly documented as being > > the same local time (i.e. ym

Re: [Development] Status of QTimeZone

2013-04-15 Thread Jake Thomas Petroules
I completely agree with that reasoning. Is it too late to restore the original behavior? I imagine the 5.0.x will be rather short lived with 5.1 coming out so soon so it seems like such a change wouldn't be all that terrible. -- Jake Petroules Chief Technology Officer Petroules Corporation · ww

Re: [Development] Status of QTimeZone

2013-04-15 Thread Mitch Curtis
On 03/25/2013 10:43 PM, John Layt wrote: > 4) The QDateTime QDataStream was changed in 5.0 to write all times as UTC, but > I think this is wrong. Qt::LocalTime is clearly documented as being the same > local time (i.e. ymd hms) regardless of the underlying system time or time > zone or any change

Re: [Development] Status of QTimeZone

2013-03-28 Thread John Layt
On 27 March 2013 20:11, John Layt wrote: > On 26 March 2013 18:15, Thiago Macieira wrote: >> On terça-feira, 26 de março de 2013 14.07.56, Sergio Ahumada wrote: >>> As far as I understand, the CI is all in Finland, so GMT +2. >> >> In other words, the tests are effectively disabled. > > Yeap, and

Re: [Development] Status of QTimeZone

2013-03-27 Thread John Layt
On 26 March 2013 18:15, Thiago Macieira wrote: > On terça-feira, 26 de março de 2013 14.07.56, Sergio Ahumada wrote: >> As far as I understand, the CI is all in Finland, so GMT +2. > > In other words, the tests are effectively disabled. Yeap, and on all platforms too. I assume changing the CI ma

Re: [Development] Status of QTimeZone

2013-03-26 Thread Thiago Macieira
On terça-feira, 26 de março de 2013 14.07.56, Sergio Ahumada wrote: > As far as I understand, the CI is all in Finland, so GMT +2. In other words, the tests are effectively disabled. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center si

Re: [Development] Status of QTimeZone

2013-03-26 Thread shane.kearns
> > It fails for me, too; the tests are off by 1 hour, it seems. > > This is indeed a mystery. Is the CI in a "European" timezone? > > > > the CI log shows: > > -- > Testing tst_QDateTime > Totals: 350 passed, 0 failed, 34 skipped > -

Re: [Development] Status of QTimeZone

2013-03-26 Thread Sergio Ahumada
On 03/26/2013 01:48 PM, Friedemann Kleint wrote: > Hi, > > > tst_qdatetime on Windows with a European time zone throws up 8 > failures for > > me on a clean build without my changes. Does this happen for anyone > else? Is > > this test disabled in CI, because I don't see how anything could

Re: [Development] Status of QTimeZone

2013-03-26 Thread Friedemann Kleint
Hi, > tst_qdatetime on Windows with a European time zone throws up 8 failures for > me on a clean build without my changes. Does this happen for anyone else? Is > this test disabled in CI, because I don't see how anything could be passing > otherwise? It fails for me, too; the tests are

[Development] Status of QTimeZone

2013-03-25 Thread John Layt
Hi, I've just pushed another set of patches for the QTimeZone and QDateTime changes. The current status is I think the code is now stable enough for a final review and decision on whether to include in 5.1 or not. The QDateTime changes for OffsetFromUTC and the formatter improvements can cert