[Development] Nominating Ahmad Samir for approver

2023-09-11 Thread Volker Hilsheimer via Development
Hello all, I would like to nominate Ahmad Samir for approver rights in the Qt project. For many months, Ahmad has produced a consistent flow of good contributions and reviews to Qt: Changes owned: * https://codereview.qt-project.org/q/owner:a.samirh78%2540gmail.com Changes commented/voted on:

Re: [Development] Copying a struct the easy (perhaps too easy) way

2023-09-16 Thread Volker Hilsheimer via Development
> On 16 Sep 2023, at 02:05, Henry Skoglund wrote: > > On 2023-09-16 01:55, Giuseppe D'Angelo via Development wrote: >> Wrong mailing list? >> >> Il 16/09/23 01:41, Henry Skoglund ha scritto: >>> S a; >>> S b = a.clone(); >>> >>> it seems to work like a charm (6.5.2 on Linux and the Mac.

Re: [Development] BC/SC in patch releases

2023-08-24 Thread Volker Hilsheimer via Development
> On 24 Aug 2023, at 14:43, Lars Knoll via Development > wrote: > > >> On 24 Aug 2023, at 14:30, Giuseppe D'Angelo via Development >> wrote: >> >> On 22/08/2023 23:27, Marc Mutz via Development wrote: >>> We have >>>

Re: [Development] On the use of the inline keyword

2023-08-24 Thread Volker Hilsheimer via Development
Thanks for the background info, Cristian! It’s fine to agree that, for new code, the inline goes only on the declaration, and must not be on the definition. For existing code: throwing the somewhat but not totally (I think) naive regexp

Re: [Development] BC/SC in patch releases

2023-09-01 Thread Volker Hilsheimer via Development
> On 31 Aug 2023, at 19:15, Thiago Macieira wrote: > > On Thursday, 31 August 2023 09:54:37 PDT Lisandro Damián Nicanor Pérez Meyer > wrote: >>> It seems very unlikely that one would end up building for Qt x.y.z and >>> then have their users on Qt x.y.(w> >> With my Debian hat on: I really

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-13 Thread Volker Hilsheimer via Development
On 13 Sep 2023, at 13:23, Ahmad Samir wrote: On 13/9/23 11:06, Ivan Solovev via Development wrote: I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format tool installed on my system, because it usually breaks the formatting of

[Development] codereview now supports mentions in comments

2023-09-07 Thread Volker Hilsheimer via Development
During the recent maintenance window we have enabled the “mentions” feature of gerrit: https://www.gerritcodereview.com/3.7.html#mention-user-support It’s not the pinnacle of usability in that you need to know the exact username/email address of the user you want to mention (so you have to

Re: [Development] Proposal: (re)move qt5.git/_clang-format

2023-09-21 Thread Volker Hilsheimer via Development
On 13 Sep 2023, at 16:25, Volker Hilsheimer via Development wrote: On 13 Sep 2023, at 13:23, Ahmad Samir wrote: On 13/9/23 11:06, Ivan Solovev via Development wrote: I would therefore propose to remove the file from qt5.git: +1 from my side. I believe I simply do not have the clang-format

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-20 Thread Volker Hilsheimer via Development
On 19 Sep 2023, at 15:49, Marc Mutz via Development wrote: So I ask: Please let us roll out the framework with one of equal/eq/order/ordering/cmp (your choice, but quickly!), to set a status quo against which to benchmark any potentially-superior solutions, and then the ML can finish

Re: [Development] C++20 comparisons @ Qt (was: Re: C++20 @ Qt)

2023-09-19 Thread Volker Hilsheimer via Development
> On 18 Sep 2023, at 14:46, Marc Mutz via Development > wrote: > > TL;DR: "a" must not be a name of an existing function in Qt. > > On 18.09.23 10:15, Ivan Solovev via Development wrote: >> Hi, >> >>> 1. an ADL-able calling convention: `using std::swap; swap(lhs, rhs);` >>> 2. an

Re: [Development] Removal of Non-deprecated API Elements in v6.6.0

2023-10-19 Thread Volker Hilsheimer via Development
> On 19 Oct 2023, at 13:07, Giuseppe D'Angelo via Development > wrote: > > On 19/10/2023 12:07, Phil Thompson via Development wrote: >> Up until v6.6 upgrading to a new version was relatively low risk but this >> will just encourage people to stay on older versions. Is this a mistake or a >>

Re: [Development] Removal of Non-deprecated API Elements in v6.6.0

2023-10-19 Thread Volker Hilsheimer via Development
> On 19 Oct 2023, at 15:55, Phil Thompson via Development > wrote: > > On 19/10/2023 12:07, Giuseppe D'Angelo via Development wrote: >> On 19/10/2023 12:07, Phil Thompson via Development wrote: >>> Up until v6.6 upgrading to a new version was relatively low risk but this >>> will just

Re: [Development] Lots of qdoc-related warning messages when building 'docs' target in Qt-6.6.0?

2023-10-21 Thread Volker Hilsheimer via Development
On 21 Oct 2023, at 10:02, Haowei Hsu wrote: Hello, Qt Development Team. Recently, I successfully built docs of Qt-6.6.0 in MSYS/MINGW64 shell with the following commands: 1. cd /c/Test/qt-everywhere-src-6.6.0 2. mkdir build && cd build 3. mkdir mingw-release && cd mingw-release

Re: [Development] QtFluentMQ

2023-08-23 Thread Volker Hilsheimer via Development
Hello QtFluentMQ Team, The project as you have described it sounds very cool and could be interesting for many Qt users building distributed systems. So thanks for the work so far and for reaching out! As for providing a repository on our gerrit server for your project, and perhaps moving it

Re: [Development] BC/SC in patch releases (particularly enum additions)

2023-08-23 Thread Volker Hilsheimer via Development
> On 23 Aug 2023, at 15:09, Edward Welbourne via Development > wrote: > > Lars Knoll (23 August 2023 13:32) wrote >> We have been adding new enum values in certain cases. The operating >> system versions needing to be amended to support a new version of >> macOS is one example. That has

Re: [Development] How to use `init-repository` properly to clean up the working tree after checking out?

2023-08-23 Thread Volker Hilsheimer via Development
On 23 Aug 2023, at 08:35, Haowei Hsu wrote: Hello, Thiago. No, I mean, why do you want to get Qt 6.2.4 in the first place? I didn't say that it had to be 6.2.4. In fact, I've also tried to build other Qt6 releases, such as: 6.1, 6.3, 6.5... etc. However, I found during the process that when

Re: [Development] Nominating Kwanghyo Park as approver

2023-08-15 Thread Volker Hilsheimer via Development
+1 Disclaimer: Kwanghyo reports (indirectly) to me. Volker On 14 Aug 2023, at 08:54, Tomi Korpipää via Development wrote: Hi, I'd like to nominate Kwanghyo Park for approver status. He is the main developer for Surface3D graphs for the QtGraphs module, and has been contributing to

[Development] Nominating for approver: commentby vs reviewedby vs reviewer search operators

2023-08-15 Thread Volker Hilsheimer via Development
Hi, Emails in which we nominate contributors for Approver status usually have two queries: the list of changes owned [1], and the list of changes that the nominee reviewed [2]. [1] https://codereview.qt-project.org/q/owner:volker.hilsheimer%2540qt.io [2]

Re: [Development] On the use of the inline keyword

2023-08-26 Thread Volker Hilsheimer via Development
> On 25 Aug 2023, at 14:20, Ahmad Samir wrote: > > On 25/8/23 14:11, Cristian Adam via Development wrote: >> The other way of fixing this is by using ... macros. The article at c++ - >> Importing inline functions in MinGW - Stack >>

Re: [Development] QtFluentMQ

2023-08-26 Thread Volker Hilsheimer via Development
> On 26 Aug 2023, at 10:09, Ulf Hermann via Development > wrote: > > Hi, > > The usual way to request a repository, playground or not, is a mail like this: > > https://lists.qt-project.org/pipermail/development/2022-August/042900.html > > If the request is not totally outlandish it's usually

Re: [Development] QtFluentMQ

2023-08-29 Thread Volker Hilsheimer via Development
+1 in general. However, gerrit users should be individual contributors rather than a team user that is shared by multiple people, and the responsible person needs to have a gerrit user account. So, if nobody objects within a few days, please create a QTQAINFRA task in JIRA with the necessary

Re: [Development] Security-relevant 3rd party components bundled with Qt

2022-10-12 Thread Volker Hilsheimer via Development
> On 7 Oct 2022, at 22:08, Robert Löhning via Development > wrote: > > Am 20.09.22 um 14:47 schrieb Volker Hilsheimer: >> Hi, >> Some of the 3rd party components we bundle in Qt are directly involved in >> code paths that are designed to process untrusted data. Following up on the >>

Re: [Development] Using '#pragma once' instead of include guards?

2022-10-12 Thread Volker Hilsheimer via Development
> On 11 Oct 2022, at 22:11, Thiago Macieira wrote: > > On Tuesday, 11 October 2022 12:25:13 PDT Kyle Edwards via Development wrote: >> Speaking as co-maintainer of CMake, we have effectively required #pragma >> once to build CMake itself since August 2017, we officially codified >> this as

Re: [Development] Request for new module, qt/qtgrpc

2022-10-06 Thread Volker Hilsheimer via Development
+1 FWIW, searching for “qtgrpc” hits https://semlanik.github.io/qtprotobuf/group__QtGrpc.html, which is generated from the sources in https://github.com/semlanik/qtprotobuf - which the readme file documents as “on hold”. Volker > On 5 Oct 2022, at 12:51, Mårten Nordheim via Development >

Re: [Development] Nominating Christian Ehrlicher and Andy Shaw as Qt SQL co-maintainers

2022-10-12 Thread Volker Hilsheimer via Development
> On 26 Sep 2022, at 09:11, Volker Hilsheimer wrote: > > Hi, > > > I would like to nominate Christian and Andy as co-maintainers for Qt SQL. > > Mark Brand, who is currently listed as the maintainer of Qt SQL, hasn’t > responded to any of my emails, including one from two weeks ago where I

[Development] Using '#pragma once' instead of include guards?

2022-10-10 Thread Volker Hilsheimer via Development
Hi, We are using `#pragma once` in a number of examples and tests in the Qt source tree, but I don’t think we have officially endorsed it in favour of explicit include guards. #pragma once is “non-standard but widely supported” [1], with some caveats, e.g. when there are multiple header

Re: [Development] Using '#pragma once' instead of include guards?

2022-10-14 Thread Volker Hilsheimer via Development
> On 14 Oct 2022, at 15:47, Kyle Edwards via Development > wrote: > > On 10/14/22 03:15, Eike Ziller wrote: >>> However, there are ways to enforce the use of unique header guards. >>> clang-tidy has an extensible header guard check that can be customized >>> per-project, and plugin loading

Re: [Development] Using '#pragma once' instead of include guards?

2022-11-02 Thread Volker Hilsheimer via Development
> On 2 Nov 2022, at 15:25, Marc Mutz via Development > wrote: > > Hi Volker, > > On 14.10.22 17:12, Volker Hilsheimer via Development wrote: >> Anyway, I’ve added the respective text to the coding convention wiki >> page. >> https://wiki.qt.io/Coding_Con

Re: [Development] Requesting feature freeze exception for QTBUG-105968

2023-01-04 Thread Volker Hilsheimer via Development
Hi Hatem, Based on state of the patch and the the pending code review comments, I think this feature needs more discussion and work. So let’s keep this out of Qt 6.5 and continue working on that for Qt 6.6. Volker > On 4 Jan 2023, at 10:05, Hatem ElKharashy via Development > wrote: > >

Re: [Development] Nominating Shyamnath Premnadh as approver

2022-12-06 Thread Volker Hilsheimer via Development
> On 5 Dec 2022, at 16:46, Alex Blasche via Development > wrote: > > Hi, > > > I’d like to nominate Shyamnath Premnadh as an approver for the Qt project. +1! Volker ___ Development mailing list Development@qt-project.org

[Development] What's New in Qt 6.5

2022-11-30 Thread Volker Hilsheimer via Development
Hi, With the module and platform freeze behind us (even if some work is still ongoing), and the feature freeze just a few days out, now is perhaps a good time to start documenting all the new goodness in Qt 6.5. Since we’ll all modify the same file, each of us adding separated patches will

Re: [Development] Proposal: let's change the release schedules a bit

2022-12-08 Thread Volker Hilsheimer via Development
For me, the argument that Eddy makes is very strong: a milestone or deadline right after holidays has the potential of ruining those holidays, without giving any meaningful extra time to get features done. Releases of operating systems have some relevance: new macOS and Windows versions have

Re: [Development] HEADS-UP: Qt 6.5 Feature Freeze

2022-12-10 Thread Volker Hilsheimer via Development
> On 10 Dec 2022, at 06:58, Jani Heikkinen via Development > wrote: > > Hi! > > Qt 6.5 Feature Freeze is now in effect. But if your change(s) are ready & > approved and failed to integrate due to CI flakiness etc. you can still > continue staging those in 'dev' during the weekend; we are

[Development] Nominating Axel Spoerl as approver

2022-12-05 Thread Volker Hilsheimer via Development
Hi, I’d like to nominate Axel Spoerl as an approver for the Qt project. Axel has been working in The Qt Company since January, writing tests, analysing and fixing bugs, participating in the port of Qt Speech to Qt 6, investigating and stabilising flaky tests across all platforms, and most

Re: [Development] Requesting Feature Freeze exception for a new API addition into QCryptographicHash

2022-12-13 Thread Volker Hilsheimer via Development
> On 12 Dec 2022, at 13:56, Thiago Macieira wrote: > > On Monday, 12 December 2022 09:28:55 -03 Jan Grulich wrote: >> Hi, >> >> I would like to request a freeze exception for a new method in >> QCryptographicHash that allows querying OpenSSL for allowed/built-in >> algorithms. We agreed on

Re: [Development] Requesting Feature Freeze exception for CTF tracing backend

2022-12-13 Thread Volker Hilsheimer via Development
Agree. There are a couple of open design questions in the comments, but this functionality will enable better profiling support on top of Qt 6.5, and should otherwise not be in the way. We should be able iterate over the implementation without any unpredictable side effects. The general

Re: [Development] Nominating Mikołaj Boć as approver

2022-12-21 Thread Volker Hilsheimer via Development
> On 21 Dec 2022, at 15:21, Morten Sørvig via Development > wrote: > > Hi, > > > I’d like to nominate Mikołaj Boć as an approver for the Qt project. > > Mikołaj joined the Qt Company earlier this year and hit the ground running. > He has contributed features and many bug fixes for the Qt

Re: [Development] Nominating Mårten Nordheim and Timur Pocheptsov as new co-maintainers of Qt WebSocket

2022-12-13 Thread Volker Hilsheimer via Development
Maintainers page updated accordingly. Congrats, Mårten and Timur, and thank you! Volker > On 29 Nov 2022, at 14:55, Volker Hilsheimer via Development > wrote: > > Hi, > > > Kurt Pattyn is currently listed as the Maintainer fo Qt WebSocket. However, > he has not re

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-16 Thread Volker Hilsheimer via Development
> On 16 Nov 2022, at 09:54, Marc Mutz via Development > wrote: […] >>> But UTF-16 is sacrosanct in Qt. It's a cult. Irregardless of how many >>> deep copies it takes to convert to and from UTF-16 from native >>> encodings, people still worship it as god-given. It's not. […] > If CoW is

[Development] Nominating Mårten Nordheim and Timur Pocheptsov as new co-maintainers of Qt WebSocket

2022-11-29 Thread Volker Hilsheimer via Development
Hi, Kurt Pattyn is currently listed as the Maintainer fo Qt WebSocket. However, he has not responded to emails I sent him over the last few months. In the middle of October I informed him that I will remove him as maintainer and nominate someone else unless I get a response. I cc’ed Mårten

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-17 Thread Volker Hilsheimer via Development
> On 17 Nov 2022, at 18:45, Thiago Macieira wrote: > > On Thursday, 17 November 2022 02:04:54 PST Marc Mutz via Development wrote: >>> Also, sometimes I wonder if all the work you and I do to optimise these >>> things matter, in the end. We may save 0.5% of the CPU time, only for >>> that to

Re: [Development] Security-relevant 3rd party components bundled with Qt

2023-01-20 Thread Volker Hilsheimer via Development
On 1 Nov 2022, at 09:55, Volker Hilsheimer via Development wrote: On 20 Sep 2022, at 14:47, Volker Hilsheimer wrote: […] Those components should then be watched closer, and always get updated to the latest version, perhaps even for patch releases. To that end, I’ve started to collect a list

[Development] Qt TextToSpeech: Adding dependency to Qt Multimedia - ok?

2023-01-23 Thread Volker Hilsheimer via Development
Hi, I recently prototyped a few frequently requested features for Qt TextToSpeech, in particular the ability to capture the generated audio data as a QByteArray with the PCM bits. However, a QByteArray with PCM bits isn’t very usable unless we also inform the client code which format those PCM

[Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-01-30 Thread Volker Hilsheimer via Development
Hi, TL;DR: I’d like to change QAudioSink::resume() to always change the sink to Active state, no matter how the sink was start()’ed. QAudioSink provides low-level access to an audio device, allowing applications to provide PCM data. The class operates in one of two modes: in pull mode, the

Re: [Development] Qt TextToSpeech: Adding dependency to Qt Multimedia - ok?

2023-01-30 Thread Volker Hilsheimer via Development
> On 23 Jan 2023, at 16:07, Kai Köhne wrote: > > Hi, > >> -Original Message- >> From: Development On Behalf Of >> [...] >> This is a binary compatibility breakage of sorts. Applications that were >> linked >> against Qt 6.4 or Qt 6.5, and want to run against Qt 6.6 won’t work unless

Re: [Development] CMake UNITY_BUILD ( QTBUG-109394 )

2023-01-17 Thread Volker Hilsheimer via Development
On 17 Jan 2023, at 13:35, Edward Welbourne via Development wrote: On Monday, 16 January 2023 04:49:23 PST Friedemann Kleint via Development wrote: Summmarising: we stand to gain a speed-up of compilation; particularly for clean builds like in COIN; but it requires some work. We might do a

Re: [Development] New Qt example development guideline and revamping examples

2023-01-20 Thread Volker Hilsheimer via Development
On 20 Jan 2023, at 10:45, Tor Arne Vestbø via Development wrote: On 20 Jan 2023, at 09:49, Eike Ziller wrote: Am 19/01/2023 um 13:33 schrieb Giuseppe D'Angelo via Development : Il 19/01/23 10:27, Tor Arne Vestbø ha scritto: All the contrary, do NOT do that, as it results in 200+ lines

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-09 Thread Volker Hilsheimer via Development
Hi, > On 8 Nov 2022, at 22:20, Marc Mutz via Development > wrote: > To summarize: > - I will not accept responsibility for any container rewrites in any of > the Qt major version changes. I was not involved in any of these > decisions, and where I was involved in the discussion, my

Re: [Development] Getting "REMOTE HOST IDENTIFICATION HAS CHANGED" when pushing a commit to gerrit

2022-11-10 Thread Volker Hilsheimer via Development
Good! https://lists.qt-project.org/pipermail/development/2022-November/043229.html Volker > On 10 Nov 2022, at 16:29, Fusion Future wrote: > > Hi Qt people, > > I am getting this error "REMOTE HOST IDENTIFICATION HAS CHANGED" when trying > to push a commit to Qt gerrit. Not sure what

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-07 Thread Volker Hilsheimer via Development
> On 4 Nov 2022, at 16:00, Marc Mutz via Development > wrote: > > Hi, > > After getting my head washed by Volker, lemme provide background on > these two functions. Thanks for the context, Marc! > TL;DR: we created real maintenance and porting problems by not removing > stop-gap

Re: [Development] Security-relevant 3rd party components bundled with Qt

2022-11-01 Thread Volker Hilsheimer via Development
> On 20 Sep 2022, at 14:47, Volker Hilsheimer wrote: […] > Those components should then be watched closer, and always get updated to the > latest version, perhaps even for patch releases. To that end, I’ve started to > collect a list of such components on > >

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-09 Thread Volker Hilsheimer via Development
> On 9 Nov 2022, at 12:49, Marc Mutz via Development > wrote: > > Hi Volker, > > On 09.11.22 10:15, Volker Hilsheimer wrote: >> But I do believe that we can add APIs that are iterator and ranges friendly >> to Qt without tossing out the baby with the bathwater and without breaking >> tons

[Development] I ❤️ Qt containers! :) (was: How qAsConst and qExchange lead to qNN)

2022-11-08 Thread Volker Hilsheimer via Development
> On 7 Nov 2022, at 21:15, Marc Mutz via Development > wrote: […] > Anyway; to all those who disagree when I say Qt should concentrate on > its core competencies and stop meddling with container classes, shared > pointers, etc, I say this: which of the two universes above would you > rather

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-14 Thread Volker Hilsheimer via Development
> On 12 Nov 2022, at 14:41, A. Pönitz wrote: > > On Fri, Nov 11, 2022 at 09:35:27AM +0100, Ulf Hermann via Development wrote: >> There is an undeniable benefit of _offering_ QSpan, QStringView, and >> generator APIs in a few relevant cases: > > This is true, but my problem with this is that

Re: [Development] How qAsConst and qExchange lead to qNN

2022-11-14 Thread Volker Hilsheimer via Development
> On 14 Nov 2022, at 18:30, Marc Mutz via Development > wrote: > > Hi Ulf, > > On 14.11.22 17:37, Ulf Hermann via Development wrote: >> Hi Marc, >> >>> On 11.11.22 09:35, Ulf Hermann via Development wrote: There is an undeniable benefit of _offering_ QSpan, QStringView, and

Re: [Development] RFC: Defaulting to or enforcing UTF-8 locales on Unix systems

2023-03-22 Thread Volker Hilsheimer via Development
> On 22 Mar 2023, at 12:07, Alvin Wong via Development > wrote: > On 22/3/2023 17:58, Lars Knoll wrote: >> Hi, >> >> >>> On 21 Mar 2023, at 17:46, Alvin Wong via Development >>> wrote: >>> >>> Hi, >>> >>> Yes, embedding the manifest with activeCodePage set to UTF-8 is the only >>> thing

Re: [Development] RFC: Defaulting to or enforcing UTF-8 locales on Unix systems

2023-03-22 Thread Volker Hilsheimer via Development
> On 22 Mar 2023, at 18:58, Christian Ehrlicher wrote: > > Am 22.03.2023 um 17:35 schrieb Volker Hilsheimer via Development: >> But we use toLocal8Bit in plenty of cases as well. For instance in our Qt >> SQL APIs. > > The only plugin which really uses toLocal8

Re: [Development] Security-relevant 3rd party components bundled with Qt

2023-02-24 Thread Volker Hilsheimer via Development
modules. What’s missing is the ‘process untrusted content’ flag, which is easy to add: https://codereview.qt-project.org/c/meta/quips/+/461983 Tell me what you think. Regards kai From: Development mailto:development-boun...@qt-project.org>> On Behalf Of Volker Hilsheimer via Developmen

[Development] Examples to be removed for Qt 6.5? Now is not too early!

2023-03-01 Thread Volker Hilsheimer via Development
Hi, As part of the ongoing example revamping activity [1], we are also merging or removing some examples. Qt 6.4 shipped with close to 650 examples. That’s a lot of examples for users to navigate and grep through, and a lot of code for us to maintain and keep relevant. Some of those were

[Development] API style guide: scoped enum or not?

2023-05-02 Thread Volker Hilsheimer via Development
During the header review, but also in API discussions leading up to it, we had a few cases where it would have helped if we had clearer guidelines about when to use scoped enums, and when not. Scoped enums have some clear technical advantages (such as better type safety, thanks to no implicit

[Development] Thread anchor: Discussion of header review improvements

2023-05-02 Thread Volker Hilsheimer via Development
Hi, With Qt 6.5 out for a while already, and roughly a month to go until Qt 6.6 feature freeze and the start of the various activities that lead up to the release, it’s perhaps not too early to review some of the pain points we experienced with 6.5, and discuss how we can improve. In

[Development] Header review process: follow-up on comments

2023-05-02 Thread Volker Hilsheimer via Development
With Qt 6.5, it’s been a struggle to get people to respond and follow-up to comments made during the header review process. Gerrit doesn’t really care about @user-style mentioning in comments, even though is seems that some people assume that it does. Creating JIRA tickets is the official way

[Development] Template-meta-programming do's and don'ts

2023-05-02 Thread Volker Hilsheimer via Development
During header review we identified a few cases where e.g. using std::conjunction/disjunction wasn’t used, or not used optimally. Using suboptimal constructs can result in significant compile-time penalties. We generally don’t have a lot of guidelines for template-meta-programming. Should we

[Development] Changes to QObject::connect and other functor-taking API implementations

2023-05-02 Thread Volker Hilsheimer via Development
Hi, What started as an attempt to provide a few building blocks for making it easier to build asynchronous APIs taking any kind of callable (like QTimer::singleShot or QHostInfo::lookupHost) [1] has turned into a bit of a longer journey to the core. [1]

Re: [Development] Patch to fix qt-multimedia compilation with ALSA

2023-04-06 Thread Volker Hilsheimer via Development
Hi, Thanks, but please push patches to our code review system for discussing and eventually merging changes: * https://wiki.qt.io/Qt_Contribution_Guidelines * https://wiki.qt.io/Setting_up_Gerrit Regards, Volker > On 6 Apr 2023, at 14:16, shengfeng zhou wrote: > >

[Development] Check your cherry-picks to 6.5 branches

2023-02-03 Thread Volker Hilsheimer via Development
Hi, A few days ago we had a lot of cherry-picks into 6.5 branches that hadn't merged, for various reasons. Thanks to some copious stage-button-mashing during the last days, that list is now rather short. Nevertheless, please have a look at the unmerged cherry-picks anyway:

Re: [Development] Qt Multimedia: proposing behavior change to QAudioSink::resume

2023-02-06 Thread Volker Hilsheimer via Development
modeled under the assumption the buffers were empty at the time of suspend(). I would expect the state to return back to the same state the sink had when calling suspend(). Cheers, Tor Arne On 30 Jan 2023, at 16:38, Volker Hilsheimer via Development wrote: Hi, TL;DR: I’d like to change

Re: [Development] Proposal: let's change the release schedules a bit

2023-02-13 Thread Volker Hilsheimer via Development
. Yours, Tuukka From: Development on behalf of Volker Hilsheimer via Development Date: Thursday, 8. December 2022 at 14.03 To: Jani Heikkinen Cc: development@qt-project.org Subject: Re: [Development] Proposal: let's change the release schedules a bit For me, the argument

Re: [Development] Requesting a repository for Qt Graphs

2023-02-13 Thread Volker Hilsheimer via Development
Hi, the work has been happening in the wip/NG branch: https://codereview.qt-project.org/gitweb?p=qt/qtdatavis3d.git;a=shortlog;h=refs/heads/wip/NG Note that we want to (ultimately and over time) cover the functionality of Qt Charts in this new implementation as well. Volker > On 13 Feb

Re: [Development] Execute a function in the specified existing thread

2023-06-09 Thread Volker Hilsheimer via Development
On 9 Jun 2023, at 02:00, Thiago Macieira wrote: On Wednesday, 7 June 2023 19:18:02 PDT JiDe Zhang wrote: please make sure your contribution uses QMetaCallEvent. Why uses QMetaCallEvent? I don't know how to make the function arguments to void** for QMetaCallEvent constructor. Maybe I can use

Re: [Development] API style guide: scoped enum or not?

2023-06-14 Thread Volker Hilsheimer via Development
+1 to A and C. > On 14 Jun 2023, at 21:49, Allan Sandfeld Jensen wrote: > > On Mittwoch, 14. Juni 2023 17:48:27 CEST Thiago Macieira wrote: >> On Wednesday, 14 June 2023 08:35:16 PDT Marc Mutz via Development wrote: >> B) new enums MUST be scoped, also when nested in classes¹² > >

Re: [Development] Module maintainers: QT_NO_CONTEXTLESS_CONNECT in your modules

2023-07-12 Thread Volker Hilsheimer via Development
> Am 10.07.2023 um 18:02 schrieb Giuseppe D'Angelo via Development: >> Hi, >> >> https://codereview.qt-project.org/c/qt/qtbase/+/487560 introduces >> QT_NO_CONTEXTLESS_CONNECT , a macro that disables the 3-arguments connect -- >> in other words, it disables the >> >>>

Re: [Development] Behavior-changing bugfixes in patch-level releases

2023-07-12 Thread Volker Hilsheimer via Development
> On 12 Jul 2023, at 09:52, EXT Mitch Curtis via Development > wrote: > > Hi Arno, >> >> Hey everyone, >> >> what is the policy for adding behavior-changing bugfixes to patch-level >> releases? Is this something to expect? >> At the moment we operate under the assumption that bumping the

Re: [Development] Nominating Edward Welbourne as QLocale / date/time maintainer

2023-05-24 Thread Volker Hilsheimer via Development
> On 4 May 2023, at 12:10, Marc Mutz via Development > wrote: > > Hi, > > I'd like to nominate Eddy as the maintainer for the QLocale and > src/corelib/time QtCore subsystems. Eddy is filling that role de-facto > already; making it de-jure sounds only logical. > > I asked, and he'd be on

Re: [Development] Requesting feature freeze exception to container-assign epic

2023-06-05 Thread Volker Hilsheimer via Development
> On 3 Jun 2023, at 16:54, Thiago Macieira wrote: > > On Saturday, 3 June 2023 02:54:49 PDT Marc Mutz via Development wrote: >> The container-assign epic is partially merged. What's left is >> QString::assign(), and there only the assign(it, it) part. If we release >> as-is (with step 1, cf.

Re: [Development] Continue staging restrictions in qt/qt5 dev branch?

2023-06-05 Thread Volker Hilsheimer via Development
On 5 Jun 2023, at 09:11, Jukka Jokiniva via Development wrote: Hi, There are quite many changes trying make it to the qt/qt5 dev branch: https://codereview.qt-project.org/q/project:qt/qt5+branch:dev+is:open If everyone starts to stage these individually, I am afraid that nothing will get

Re: [Development] Requesting Feature Freeze Exception for C++20 comparison

2023-06-05 Thread Volker Hilsheimer via Development
> On 4 Jun 2023, at 23:26, Thiago Macieira wrote: > > On Sunday, 4 June 2023 11:51:54 PDT Marc Mutz via Development wrote: >>> The other problem is I want to take a second, thorough look at your >>> #ifdefs >>> for C++20. I have a feeling some of the changing return types are a recipe >>> for

Re: [Development] Execute a function in the specified existing thread

2023-06-08 Thread Volker Hilsheimer via Development
> On 7 Jun 2023, at 17:20, Thiago Macieira wrote: > > On Wednesday, 7 June 2023 01:53:47 PDT JiDe Zhang wrote: >> I am writing a tool to allowed call a function in the specified existing >> thread, I want to contribution it to Qt project, are you like? > > We do this internally, but don't

Re: [Development] Nominating Artem Dyomin as Approver

2023-05-27 Thread Volker Hilsheimer via Development
+1, he’s doing great. Disclaimer: Artem sits across the hall from me in the office, works down the street from me in home office, and reports to me indirectly. Volker From: Development on behalf of Lars Knoll Sent: Saturday, May 27, 2023 5:41:42 PM To: Qt

Re: [Development] std::optional for Q_PROPERTY

2023-07-21 Thread Volker Hilsheimer via Development
> On 20 Jul 2023, at 16:17, Fabian Kosmale via Development > wrote: >> Hi everyone, >> >> something that came up during this year’s KDE Akademy was that we >> believe Q_PROPERTY should be able to handle std::optional, such that you >> get a null QVariant out of it if it has no value. The main

Re: [Development] C++20 ctor-level [[nodiscard]] (was: Re: C++20 @ Qt)

2023-06-18 Thread Volker Hilsheimer via Development
> On 16 Jun 2023, at 20:25, Thiago Macieira wrote: > > On Friday, 16 June 2023 11:05:30 PDT Giuseppe D'Angelo via Development wrote: >> On 16/06/2023 18:00, Thiago Macieira wrote: >>> On Friday, 16 June 2023 01:06:33 PDT Stephen Kelly wrote: Make sure you're not hitting

Re: [Development] Recommended way to take in strings

2023-06-20 Thread Volker Hilsheimer via Development
On 31 May 2023, at 16:05, Thiago Macieira wrote: On Wednesday, 31 May 2023 00:17:21 PDT Marc Mutz via Development wrote: I doubt there's an accepted project-wide standard, yet, but as a rule of thumb that everyone might be able to agree on: If the function doesn't store the string as-is (=parses

Re: [Development] Unity Build on CI for Qt Base for 3 Platforms

2023-06-26 Thread Volker Hilsheimer via Development
On 26 Jun 2023, at 09:39, EXT Amir Abdol via Development wrote: Hi, Unity Build is now enabled on CI for Qt Base, on dev branch, for the following platforms: INTEGRITY, Windows 10 MinGW, Windows 11 MinGW, which are among the slowest platforms on our CI. Here is a brief note about the unity

Re: [Development] API style guide: scoped enum or not?

2023-06-20 Thread Volker Hilsheimer via Development
> On 14 Jun 2023, at 14:59, Marc Mutz via Development > wrote: […] > C) scoped enums SHOULD NOT repeat (part of) an enum's type name in the > enumerators² […] > I have been told today that QML allows scoped C++ enums to be used > without the scope. If this is true, it should be fixed to

Re: [Development] Meeting minutes from Qt Release Team meeting 20.06.2023

2023-06-20 Thread Volker Hilsheimer via Development
On 20 Jun 2023, at 16:24, Arno Rehn wrote: On 20.06.2023 16:12, Jani Heikkinen via Development wrote: Qt 6.5 status: - Branching from '6.5' to '6.5.2' done - Qt 6.5.2 content is not frozen yet. The target is to freeze the Qt 6.5.2 content later this week - The target is to release Qt 6.5.2

Re: [Development] Proposing changes to https://wiki.qt.io/Qt_Coding_Style

2023-05-10 Thread Volker Hilsheimer via Development
> On 10 May 2023, at 07:39, Marc Mutz via Development > wrote: >> >> >> That said. I find discussing style-guides in general a waste of time, and >> will >> agree to anything that make us stop wasting time on this. > > I tend to agree, but the choice is either to define it centrally, or you

[Development] Qt TextToSpeech API review for Qt 6.6

2023-05-13 Thread Volker Hilsheimer via Development
Hi, I’d be happy for comments and feedback to the C++ and QML APIs we added to the Qt TextToSpeech module for Qt 6.6. https://doc-snapshots.qt.io/qt6-dev/whatsnew66.html#qt-texttospeech-module https://doc-snapshots.qt.io/qt6-dev/newclasses66.html (new member function in the QTextToSpeech

Re: [Development] Qt TextToSpeech API review for Qt 6.6

2023-05-13 Thread Volker Hilsheimer via Development
I suppose it would have been useful to include date and time information as well: Monday, May 22nd, 16:00 CEST. Volker > On 13 May 2023, at 14:08, Volker Hilsheimer via Development > wrote: > > Hi, > > > I’d be happy for comments and feedback to the C++ and QML APIs

Re: [Development] Nominating Jere Tuliniemi for approver

2023-05-15 Thread Volker Hilsheimer via Development
> On 12 May 2023, at 09:12, Tomi Korpipää via Development > wrote: > > Hi, > > I'd like to nominate Jere Tuliniemi for approver status. He has been working > with Qt for several years, contributing to Qt 3D Studio, ogl-runtime, > QtQuick3D, Qt 3D, and QtGraphs to name a few. You can see his

Re: [Development] API style guide: scoped enum or not?

2023-05-04 Thread Volker Hilsheimer via Development
> On 3 May 2023, at 18:40, Giuseppe D'Angelo via Development > wrote: >> But sometimes it’s also creating too much verbosity to use a scoped enum >> (ie. Qt::Orientation::Horizontal would perhaps not be an improvement). > > I wouldn't consider this tiny bit of extra verbosity a huge

Re: [Development] About the timeline and phases to support C++20 with and in Qt

2023-05-04 Thread Volker Hilsheimer via Development
> On 3 May 2023, at 19:20, Thiago Macieira wrote: > On Wednesday, 3 May 2023 08:56:07 PDT Volker Hilsheimer via Development wrote: >> However, C++23 adds a bunch of improvements, and perhaps it’s a much smaller >> challenge for compiler vendors to support after

Re: [Development] Nominating Edward Welbourne as QLocale / date/time maintainer

2023-05-04 Thread Volker Hilsheimer via Development
> On 4 May 2023, at 12:10, Marc Mutz via Development > wrote: > > Hi, > > I'd like to nominate Eddy as the maintainer for the QLocale and > src/corelib/time QtCore subsystems. Eddy is filling that role de-facto > already; making it de-jure sounds only logical. > > I asked, and he'd be on

Re: [Development] Changes to QObject::connect and other functor-taking API implementations

2023-05-04 Thread Volker Hilsheimer via Development
On 3 May 2023, at 19:32, A. Pönitz wrote: On Wed, May 03, 2023 at 03:21:40PM +0200, Giuseppe D'Angelo via Development wrote: Il 02/05/23 12:34, Volker Hilsheimer via Development ha scritto: What started as an attempt to provide a few building blocks for making it easier to build asynchronous

Re: [Development] About the timeline and phases to support C++20 with and in Qt

2023-05-03 Thread Volker Hilsheimer via Development
Bumping this thread up in your inboxes as it includes the links to the JIRA tickets where the journey towards C++20 has been planned and discussed so far. Let's try to build on what we already know. The standing proposal is to move to C++20 with Qt 6.9, after the next LTS release. I see no

Re: [Development] API style guide: scoped enum or not?

2023-05-04 Thread Volker Hilsheimer via Development
> On 4 May 2023, at 17:34, Marc Mutz via Development > wrote: > > On 04.05.23 15:38, Volker Hilsheimer via Development wrote: >> Should we have Qt::TextLayout::Horizontal and Qt::Layout::Horizontal? Or >> QSlider::Orientation::Horizontal? > > Without loo

Re: [Development] Changes to QObject::connect and other functor-taking API implementations

2023-05-03 Thread Volker Hilsheimer via Development
On 3 May 2023, at 15:21, Giuseppe D'Angelo via Development wrote: Il 02/05/23 12:34, Volker Hilsheimer via Development ha scritto: What started as an attempt to provide a few building blocks for making it easier to build asynchronous APIs taking any kind of callable (like QTimer::singleShot

Re: [Development] (To what extent) Should we start the API change review earlier ?

2023-05-09 Thread Volker Hilsheimer via Development
> On 2 May 2023, at 11:36, Edward Welbourne wrote: >> This email is the anchor for various topics. I’ll start with a few >> threads with things that I remember and feel could be improved. If you >> have something new, please start a new thread in reply to this email, ... > > OK, then (see

Re: [Development] Nominating Piotr Wierciński for approval status

2024-02-08 Thread Volker Hilsheimer via Development
+1! Volker On 8 Feb 2024, at 09:48, Eskil Abrahamsen Blomfeldt via Development wrote: +1  Although I think 2013 should be 2023. Eskil Abrahamsen Blomfeldt Senior Manager, Graphics The Qt Company Sandakerveien 116 0484 Oslo, Norway

Re: [Development] About the timeline and phases to support C++20 with and in Qt

2024-02-05 Thread Volker Hilsheimer via Development
From what I see, the open questions from the thread in May are still: - (paraphrasing Ville) which C++ 20 features are worth breaking (primarily embedded) users who want new Qt version but don’t yet have the compilers that can give them these facilities?

Re: [Development] Raising the minimum to C++20

2024-02-09 Thread Volker Hilsheimer via Development
I haven’t heard any convincing argument for us raising the minimum to C++ 20 in the foreseeable future. Not for building Qt, and not for using Qt. At most we get some convenience constructs for ourselves. There’s value in that, of course. But unless I miss something huge, then that value is

  1   2   >