Re: [Development] moc 4.8.6 macros

2014-09-17 Thread Thiago Macieira
On Tuesday 16 September 2014 23:00:06 Samuel Gaist wrote: Good question, I'll have to check. If that where not the case, what should I write to give additional include paths to moc ? Replace QT_DEPRECATED_SINCE with the actual contents of the macro. Also expand QT_VERSION_CHECK. Qt 4 moc

Re: [Development] moc 4.8.6 macros

2014-09-17 Thread Olivier Goffart
On Tuesday 16 September 2014 23:52:36 Thiago Macieira wrote: On Tuesday 16 September 2014 23:00:06 Samuel Gaist wrote: Good question, I'll have to check. If that where not the case, what should I write to give additional include paths to moc ? Replace QT_DEPRECATED_SINCE with the actual

Re: [Development] moc 4.8.6 macros

2014-09-17 Thread Samuel Gaist
On 17 sept. 2014, at 17:20, Olivier Goffart oliv...@woboq.com wrote: On Tuesday 16 September 2014 23:52:36 Thiago Macieira wrote: On Tuesday 16 September 2014 23:00:06 Samuel Gaist wrote: Good question, I'll have to check. If that where not the case, what should I write to give additional

Re: [Development] moc 4.8.6 macros

2014-09-17 Thread Thiago Macieira
On Wednesday 17 September 2014 17:42:40 Samuel Gaist wrote: On 17 sept. 2014, at 17:20, Olivier Goffart oliv...@woboq.com wrote: On Tuesday 16 September 2014 23:52:36 Thiago Macieira wrote: On Tuesday 16 September 2014 23:00:06 Samuel Gaist wrote: Good question, I'll have to check. If

Re: [Development] moc 4.8.6 macros

2014-09-16 Thread Samuel Gaist
On 12 sept. 2014, at 11:14, Olivier Goffart oliv...@woboq.com wrote: On Thursday 11 September 2014 22:03:03 Samuel Gaist wrote: On 11 sept. 2014, at 21:49, Thiago Macieira thiago.macie...@intel.com wrote: On Thursday 11 September 2014 21:44:15 Samuel Gaist wrote: What would be the correct

Re: [Development] moc 4.8.6 macros

2014-09-12 Thread Olivier Goffart
On Thursday 11 September 2014 22:03:03 Samuel Gaist wrote: On 11 sept. 2014, at 21:49, Thiago Macieira thiago.macie...@intel.com wrote: On Thursday 11 September 2014 21:44:15 Samuel Gaist wrote: What would be the correct procedure to handle QT_DEPRECATED_SINCE ? Removing it from around the

[Development] moc 4.8.6 macros

2014-09-11 Thread Samuel Gaist
Hi, I've stumbled on https://bugreports.qt-project.org/browse/QTBUG-41190 which states that QtSerialPort cannot be built with Qt 4.8.6. From a quick look and build, it's the use of the QT_DEPRECATED_SINCE macro around the signals that makes moc miss them and thus the compilation fails. Is

Re: [Development] moc 4.8.6 macros

2014-09-11 Thread Thiago Macieira
On Thursday 11 September 2014 18:28:58 Samuel Gaist wrote: Hi, I've stumbled on https://bugreports.qt-project.org/browse/QTBUG-41190 which states that QtSerialPort cannot be built with Qt 4.8.6. From a quick look and build, it's the use of the QT_DEPRECATED_SINCE macro around the signals

Re: [Development] moc 4.8.6 macros

2014-09-11 Thread Samuel Gaist
On 11 sept. 2014, at 20:50, Thiago Macieira thiago.macie...@intel.com wrote: On Thursday 11 September 2014 18:28:58 Samuel Gaist wrote: Hi, I've stumbled on https://bugreports.qt-project.org/browse/QTBUG-41190 which states that QtSerialPort cannot be built with Qt 4.8.6. From a quick look

Re: [Development] moc 4.8.6 macros

2014-09-11 Thread Thiago Macieira
On Thursday 11 September 2014 21:44:15 Samuel Gaist wrote: What would be the correct procedure to handle QT_DEPRECATED_SINCE ? Removing it from around the signal declaration would make the code a bit inconsistent. By the way, how is it handled in Qt 5 since building goes without any problem

Re: [Development] moc 4.8.6 macros

2014-09-11 Thread Samuel Gaist
On 11 sept. 2014, at 21:49, Thiago Macieira thiago.macie...@intel.com wrote: On Thursday 11 September 2014 21:44:15 Samuel Gaist wrote: What would be the correct procedure to handle QT_DEPRECATED_SINCE ? Removing it from around the signal declaration would make the code a bit inconsistent.

Re: [Development] moc 4.8.6 macros

2014-09-11 Thread Thiago Macieira
On Thursday 11 September 2014 22:03:03 Samuel Gaist wrote: I thought I've read somewhere that moc got better at this job :-) It seems that the new moc doesn't use much of the Qt 5 only classes, would it be useful to backport it to Qt 4 to avoid having to break the code style for modules