Re: Voting for std.experimental.allocator
Final stats: Yes - 25 No - 0 Quite a definitive approval. http://wiki.dlang.org/Review_Queue log has been updated. With this formal review of std.experimental.allocator is considered finished.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Code: https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Criteria you are expected to evaluate as part of "Yes": - is this functionality needed in Phobos - is basic design sound (some breaking changes are OK for std.experimental but not full redesign) As usual, anyone can vote, but opinions of Phobos developers hold more value. Voting ends in 2 weeks, on July 22. Yes.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Voting ends in 2 weeks, on July 22. Voting ends tomorrow. At this point it is almost impossible to fail so it is up to Phobos team how to proceed with the PR.
Re: Voting for std.experimental.allocator
On Thursday, 16 July 2015 at 10:02:17 UTC, Dicebot wrote: On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Voting ends in 2 weeks, on July 22. ~1 week remains Yes. It's time to have this functionality in standart library.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Voting ends in 2 weeks, on July 22. ~1 week remains
Re: Voting for std.experimental.allocator
On Wed, 08 Jul 2015 11:33:01 + Dicebot via Digitalmars-d-announce wrote: > Andrei is back online and thus it is time to make a decision > about adding his allocator package > (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos > std.experimental > > Docs: > http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html > Code: > https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator > > Please respond to this post with a comment starting with a single > "Yes"/"No" and optional explanation after that. Criteria you are > expected to evaluate as part of "Yes": > > - is this functionality needed in Phobos > - is basic design sound (some breaking changes are OK for > std.experimental but not full redesign) > > As usual, anyone can vote, but opinions of Phobos developers hold > more value. > > Voting ends in 2 weeks, on July 22. Yes
Re: Voting for std.experimental.allocator
On 11-Jul-2015 01:51, Andrei Alexandrescu wrote: On 7/10/15 4:29 PM, Alex Parrill wrote: On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu wrote: On 7/9/15 5:44 PM, Alex Parrill wrote: Yes, but the mmap allocator on Windows needs to be fixed. What is the issue with it? I recall I pulled something recently. -- Andrei It leaks. http://forum.dlang.org/post/itmcarskypkuospvf...@forum.dlang.org I see. Could you or someone with Windows expertise create a PR for my branch? -- Andrei This one? :) https://github.com/andralex/phobos/pull/17 -- Dmitry Olshansky
Re: Voting for std.experimental.allocator
On 7/10/15 4:29 PM, Alex Parrill wrote: On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu wrote: On 7/9/15 5:44 PM, Alex Parrill wrote: Yes, but the mmap allocator on Windows needs to be fixed. What is the issue with it? I recall I pulled something recently. -- Andrei It leaks. http://forum.dlang.org/post/itmcarskypkuospvf...@forum.dlang.org I see. Could you or someone with Windows expertise create a PR for my branch? -- Andrei
Re: Voting for std.experimental.allocator
On Friday, 10 July 2015 at 18:32:04 UTC, Andrei Alexandrescu wrote: On 7/9/15 5:44 PM, Alex Parrill wrote: Yes, but the mmap allocator on Windows needs to be fixed. What is the issue with it? I recall I pulled something recently. -- Andrei It leaks. http://forum.dlang.org/post/itmcarskypkuospvf...@forum.dlang.org
Re: Voting for std.experimental.allocator
On 7/9/15 5:44 PM, Alex Parrill wrote: Yes, but the mmap allocator on Windows needs to be fixed. What is the issue with it? I recall I pulled something recently. -- Andrei
Re: Voting for std.experimental.allocator
Yes!
Re: Voting for std.experimental.allocator
Yes, but the mmap allocator on Windows needs to be fixed.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes.
Re: Voting for std.experimental.allocator
Yes.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Yes.
Re: Voting for std.experimental.allocator
Yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Please respond to this post with a comment starting with a single "Yes"/"No" Yes
Re: Voting for std.experimental.allocator
yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes Having an official set of allocators - breaking changes or no - is a great step.
Re: Voting for std.experimental.allocator
yes
Re: Voting for std.experimental.allocator
Yes.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes
Re: Voting for std.experimental.allocator
yeah
Re: Voting for std.experimental.allocator
Yes -- Dmitry Olshansky
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Criteria you are expected to evaluate as part of "Yes": Yes.
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Please respond to this post with a comment starting with a single "Yes"/"No" Yes
Re: Voting for std.experimental.allocator
On Wednesday, 8 July 2015 at 11:33:03 UTC, Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental [...] Yes. I think getting it into std.experimental is important to get more people to test it for sound design.
Re: Voting for std.experimental.allocator
Yes
Re: Voting for std.experimental.allocator
On 8/07/2015 11:33 p.m., Dicebot wrote: Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Code: https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Criteria you are expected to evaluate as part of "Yes": - is this functionality needed in Phobos - is basic design sound (some breaking changes are OK for std.experimental but not full redesign) As usual, anyone can vote, but opinions of Phobos developers hold more value. Voting ends in 2 weeks, on July 22. Yes. I do have opinions about it, i.e. it doesn't feel 100% right especially from work with std.experimental.image. However it is needed and I do not believe that it has any major issues. It's just smallish things that I cannot quite put my finger on.
Voting for std.experimental.allocator
Andrei is back online and thus it is time to make a decision about adding his allocator package (http://forum.dlang.org/post/vfipmwojmvseqxoiw...@forum.dlang.org) to Phobos std.experimental Docs: http://erdani.com/d/phobos-prerelease/std_experimental_allocator.html Code: https://github.com/andralex/phobos/tree/allocator/std/experimental/allocator Please respond to this post with a comment starting with a single "Yes"/"No" and optional explanation after that. Criteria you are expected to evaluate as part of "Yes": - is this functionality needed in Phobos - is basic design sound (some breaking changes are OK for std.experimental but not full redesign) As usual, anyone can vote, but opinions of Phobos developers hold more value. Voting ends in 2 weeks, on July 22.