Re: Test runner with search

2012-06-14 Thread Carl Meyer
On 06/14/2012 07:25 AM, Jannis Leidel wrote: > On 14.06.2012, at 12:35, Chris Wilson wrote: >> Hi all, >> >> I've made some improvements (in my view) to the >> DjangoTestSuiteRunner. I got tired of having to remember my test >> class names and of typing so much: >> >> ./manage.py test binder.Bi

Re: Test runner with search

2012-06-14 Thread Daniel Moisset
On Thu, Jun 14, 2012 at 7:35 AM, Chris Wilson wrote: > Hi all, > > I've made some improvements (in my view) to the DjangoTestSuiteRunner. I > got tired of having to remember my test class names and of typing so much: > >  ./manage.py test binder.BinderTest.test_can_create_users > In this same lin

Re: Test runner with search

2012-06-14 Thread Chris Wilson
Hi Andrew, On Thu, 14 Jun 2012, Andrew Godwin wrote: > +1 from me as well - the test runner you linked to looks reasonably > sane, only a few small things that I'm questioning (like why types is > imported inside the for loop). I prefer to keep the imports as close to the code that uses them a

Re: Test runner with search

2012-06-14 Thread Jannis Leidel
On 14.06.2012, at 12:35, Chris Wilson wrote: > Hi all, > > I've made some improvements (in my view) to the DjangoTestSuiteRunner. I > got tired of having to remember my test class names and of typing so much: > > ./manage.py test binder.BinderTest.test_can_create_users > > This new version se

Re: Test runner with search

2012-06-14 Thread Andrew Godwin
On 14/06/12 11:51, Anssi Kääriäinen wrote: > On 14 kesä, 13:35, Chris Wilson wrote: >> I've made some improvements (in my view) to the DjangoTestSuiteRunner. I >> got tired of having to remember my test class names and of typing so much: >> >> ./manage.py test binder.BinderTest.test_can_create_u

Re: Test runner with search

2012-06-14 Thread Anssi Kääriäinen
On 14 kesä, 13:35, Chris Wilson wrote: > I've made some improvements (in my view) to the DjangoTestSuiteRunner. I > got tired of having to remember my test class names and of typing so much: > >   ./manage.py test binder.BinderTest.test_can_create_users > > This new version searches for tests with

Test runner with search

2012-06-14 Thread Chris Wilson
Hi all, I've made some improvements (in my view) to the DjangoTestSuiteRunner. I got tired of having to remember my test class names and of typing so much: ./manage.py test binder.BinderTest.test_can_create_users This new version searches for tests with the given name in all INSTALLED_APPS,

Re: QuerySet refactoring

2012-06-14 Thread Anssi Kääriäinen
On 14 kesä, 10:59, Aymeric Augustin wrote: > Hello Anssi, > > I'm familiar with the topic since I tried to review some of your > refactoring patches (before you gained the ability to commit them > yourself). > > I'm convinced that this refactoring is useful, because it is likely to > fix some bugs

Re: ModelForms and the Rails input handling vulnerability

2012-06-14 Thread Anssi Kääriäinen
On 14 kesä, 09:03, Alex Ogier wrote: > Right, the Django situation is already considerably more secure than the > Rails status quo. They have a whitelist or blacklist of attributes that > they have declared "accessible", independent of forms, making it easy to > misunderstand  that any form can up

Re: QuerySet refactoring

2012-06-14 Thread Aymeric Augustin
Hello Anssi, I'm familiar with the topic since I tried to review some of your refactoring patches (before you gained the ability to commit them yourself). I'm convinced that this refactoring is useful, because it is likely to fix some bugs, especially in features that were added to the ORM long a