Re: Revisiting multiline tags

On Thursday, April 17, 2014 5:47:10 AM UTC+7, Josh Smeaton wrote: > > And for the last month or so a patch has existed and feedback has been > requested. Performance was one of the concerns mentioned, so download > Curtis' patch, and test that it works for your use case. He has asked for >

Re: Proposal: Write unit tests for JavaScript

On Thu, Apr 17, 2014 at 5:57 AM, Trey Hunner wrote: > I saw a previous discussion about JavaScript testing in Django but it > looks like there hasn't been any progress in a few years. > > Some of my thoughts on this issue: > > This would require choosing a JavaScript testing

Re: Proposal: document and enforce style of all files (including JS, CSS, HTML)

Hi Trey, Sounds like a reasonable proposal to me. Our JavaScript code has… evolved, shall we say… over the years. We've recently started enforcing Flake8 compliance on our Python codebase; adopting similar rigour for our JavaScript code would seem appropriate. The only open question I can see is

Re: Revisiting multiline tags

And for the last month or so a patch has existed and feedback has been requested. Performance was one of the concerns mentioned, so download Curtis' patch, and test that it works for your use case. He has asked for feedback a number of times. Unless you try it out, I fear that you won't be

Proposal: Write unit tests for JavaScript

I saw a previous discussion about JavaScript testing in Django but it looks like there hasn't been any progress in a few years. Some of my thoughts on this issue: This would require choosing a JavaScript testing framework. There are many good ones out there. A popular one should probably used

Re: Revisiting multiline tags

On Wed, Apr 16, 2014 at 12:46 PM, imfletcher wrote: > to say this shouldn't be supported because its not aesthetically pleasing > is beyond bizarre, IMO. If you don't like it, keep it on one line. If you > are so offended by it that you cannot stand seeing it, ask your team

Proposal: document and enforce style of all files (including JS, CSS, HTML)

The JavaScript files use 4 spaces, 2 spaces, or tabs (depending on the file). The CSS files use mostly 4 spaces, and the HTML files use mostly 2 spaces and sometimes 4 spaces. The JavaScript code is unlinted and the general code style is neither documented nor enforced. I think jshint should be

Re: condition decorator: if-unmodified-since support and updated etags

thank you. It's submitted https://github.com/django/django/pull/2573 On 16.04.14 18:24, Tim Graham wrote: > The mailing list is typically only required for "major" features. I'm > not entirely sure the extent of what you are proposing, but I don't > think it'll need a mailing list discussion -- a

Re: condition decorator: if-unmodified-since support and updated etags

The mailing list is typically only required for "major" features. I'm not entirely sure the extent of what you are proposing, but I don't think it'll need a mailing list discussion -- a Trac ticket is sufficient. On Wednesday, April 16, 2014 12:06:27 PM UTC-4, Thomas Tanner wrote: > > Hi Tim,

Re: Revisiting multiline tags

Judging by some of the comments here, you would think that the request is: "everyone MUST break their tags into multiple lines in all cases" this is a request to support the *optional* ability to break tags across lines *in some cases* where it makes sense. the use cases are clear. the

Re: condition decorator: if-unmodified-since support and updated etags

Hi Tim, I'm a bit confused by: On 16.04.14 16:51, Tim Graham wrote: > https://docs.djangoproject.com/en/dev/internals/contributing/ Requesting features: First request the feature on the django-developers list, not in the ticket tracker. It’ll get read more closely if it’s on the mailing list.

Re: condition decorator: if-unmodified-since support and updated etags

Hi Thomas, You can read about our contributing process here: https://docs.djangoproject.com/en/dev/internals/contributing/ In particular, there's a section entitled "Submitting patches". Tim On Wednesday, April 16, 2014 9:56:57 AM UTC-4, Thomas Tanner wrote: > > Hello, > I have implemented

condition decorator: if-unmodified-since support and updated etags

Hello, I have implemented support for the If-Unmodified-Since header http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.28 in the condition decorator and added an parameter to support updating of the etags for write operations

Re: Revisiting multiline tags

Curtis, I added a thumbnail example to the DEP (pull request in github). On Wed, Apr 16, 2014 at 9:31 AM, Loic Bistuer wrote: > Curtis' branch is now a PR: > > https://github.com/django/deps/pull/3 > > Feedback is welcome. > > -- > Loic > > > On Wednesday, April 16,

Re: Revisiting multiline tags

Curtis' branch is now a PR: https://github.com/django/deps/pull/3 Feedback is welcome. -- Loic On Wednesday, April 16, 2014 11:17:58 AM UTC+7, Curtis Maloney wrote: > > Now taking input and feedback: > > https://github.com/funkybob/deps/blob/master/drafts/multiline_tags.rst > -- You