Re: {GSoC 2008}Django-Newcomments : A preview

2008-06-03 Thread Zhiwu Xie
I wonder if it would be a good idea to put the comment config (e.g., threaded or not, maximum length, pre-/post-moderation, etc) into a separate model, then let all models needing a comment have a foreign key to the comment config model. Zhiwu Thejaswi Puthraya wrote: > Hello folks, > My

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-25 Thread Thejaswi Puthraya
On May 23, 7:08 am, arthur debert <[EMAIL PROTECTED]> wrote: > Hi Thejaswi. > > A couple of suggestions: > > Any reasons for having CommentFlag.flag being a string, and not a > foreign key to a FlagType model ? Having them as strings makes it > easier to end up with bad data (misspelling and so

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-25 Thread Thejaswi Puthraya
On May 23, 5:00 pm, akaihola <[EMAIL PROTECTED]> wrote: > So it would be great to have the flexibility to make both approaches > possible. Now it is possible to do both. -- Cheers Thejaswi Puthraya http://thejaswi.info/ --~--~-~--~~~---~--~~ You received this

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-25 Thread Thejaswi Puthraya
Sorry for getting back to you so late. Was unwell. On May 22, 8:47 pm, "Nicolas Lara" <[EMAIL PROTECTED]> wrote: > Hello, > I was checking out the project.. So far it looks very good =) > > A question though: > I noticed the comments retreived by {% get_comment_list ... %} are > ordered by pk.

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-23 Thread akaihola
On 22 touko, 18:47, "Nicolas Lara" <[EMAIL PROTECTED]> wrote: > objet it refers since I dont see any case in which it would make sense > to have the replies away from the objects being replied upon. I've experimented with both approaches on a couple of websites, and the "correct" solution

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-22 Thread Will Hardy
> Any reasons for having CommentFlag.flag being a string, and not a > foreign key to a FlagType model ? Having them as strings makes it > easier to end up with bad data (misspelling and so forth). Of course > there is always the performance penalty, but it seems worth it. You can do both :-)

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-22 Thread arthur debert
Hi Thejaswi. A couple of suggestions: Any reasons for having CommentFlag.flag being a string, and not a foreign key to a FlagType model ? Having them as strings makes it easier to end up with bad data (misspelling and so forth). Of course there is always the performance penalty, but it seems

Re: {GSoC 2008}Django-Newcomments : A preview

2008-05-22 Thread Nicolas Lara
Hello, I was checking out the project.. So far it looks very good =) A question though: I noticed the comments retreived by {% get_comment_list ... %} are ordered by pk. Is there any plan to include custom ordering? I believe the default ordering should include replies to old comments after the

{GSoC 2008}Django-Newcomments : A preview

2008-05-22 Thread Thejaswi Puthraya
Hello folks, My exams got done in the first week of May. I was feeling quite bored and so started working on the project. I completed a few items from the Todo list but need to complete the documentation and write more tests. The code for my project is at