Re: Adding Support for PyMySQL (for Python 3)

2011-12-13 Thread Ian Clelland
On Thu, Dec 8, 2011 at 7:46 AM, Ian Clelland wrote: > > > On Thursday, December 8, 2011, Jens Diemer > wrote: > > Am 07.12.2011 21:38, schrieb Ian Clelland: > >> > >> PyMySQL is a pure python implementation of PEP 249 for MySQL, and > supports > >> Python 2.4 - 3.2, and MySQL 4.1 and higher. > >

Re: Adding Support for PyMySQL (for Python 3)

2011-12-08 Thread Ian Clelland
On Thursday, December 8, 2011, Jens Diemer wrote: > Am 07.12.2011 21:38, schrieb Ian Clelland: >> >> PyMySQL is a pure python implementation of PEP 249 for MySQL, and supports >> Python 2.4 - 3.2, and MySQL 4.1 and higher. > > Another goal of PyMySQL would be to use Django + MySQL with PyPy, isn't

Re: Adding Support for PyMySQL (for Python 3)

2011-12-08 Thread Jens Diemer
Am 07.12.2011 21:38, schrieb Ian Clelland: PyMySQL is a pure python implementation of PEP 249 for MySQL, and supports Python 2.4 - 3.2, and MySQL 4.1 and higher. Another goal of PyMySQL would be to use Django + MySQL with PyPy, isn't it? See also: https://groups.google.com/group/django-users/

Re: Adding Support for PyMySQL (for Python 3)

2011-12-08 Thread Tom Evans
On Wed, Dec 7, 2011 at 8:38 PM, Ian Clelland wrote: > Hi, all --- > > This is a proposal to add support in Django for PyMySQL[1] as an optional > replacement for MySQLdb. > > … > > PyMySQL is a pure python implementation of PEP 249 for MySQL, and supports > Python 2.4 - 3.2, and MySQL 4.1 and high

Re: Adding Support for PyMySQL (for Python 3)

2011-12-08 Thread Karen Tracey
On Thu, Dec 8, 2011 at 2:40 AM, Vinay Sajip wrote: > On Dec 8, 6:46 am, Ian Clelland wrote: > > > > There also seem to be a number of unicode-related errors there (mixed > > collations; unrecognized characters) -- Could that be related to the > lines > > I'm also getting the same errors on 2.x w

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
On Wed, Dec 7, 2011 at 11:40 PM, Vinay Sajip wrote: > > On Dec 8, 6:46 am, Ian Clelland wrote: > > > > There also seem to be a number of unicode-related errors there (mixed > > collations; unrecognized characters) -- Could that be related to the > lines > > I'm also getting the same errors on 2.x

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 8, 6:46 am, Ian Clelland wrote: > > There also seem to be a number of unicode-related errors there (mixed > collations; unrecognized characters) -- Could that be related to the lines I'm also getting the same errors on 2.x with the 2.x adapter on unpatched Django - so it might well be to

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 8, 6:46 am, Ian Clelland wrote: > > use_unicode used to be unconditional on the database connection; now you've > removed it, but just for Python 3. > I looked into it a little further - the use_unicode flag is just used in the 2.x constructor to set default converters to return unicode i

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 8, 6:46 am, Ian Clelland wrote: > There also seem to be a number of unicode-related errors there (mixed > collations; unrecognized characters) -- Could that be related to the lines > in your patched mysql/base.py: > >             if not PY3: >                 kwargs['use_unicode'] = True

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
On Wed, Dec 7, 2011 at 9:59 PM, Vinay Sajip wrote: > On Dec 7, 8:38 pm, Ian Clelland wrote: > > > Thoughts? > > A further update: of my 24 failures, 17 are in multiple_database, as > are 3 failures. But I get the same errors with unpatched Django 2.x > running with the standard 2.x MySQLdb adapt

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 7, 8:38 pm, Ian Clelland wrote: > Thoughts? A further update: of my 24 failures, 17 are in multiple_database, as are 3 failures. But I get the same errors with unpatched Django 2.x running with the standard 2.x MySQLdb adapter, so it might be something to do with my MySQL configuration.

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 7, 8:38 pm, Ian Clelland wrote: > Thoughts? The Django test run using MySQLdb at https://github.com/vsajip/MySQL-for-Python-3 completed with 24 failures, 9 errors, so your PyMySQL results are better at 5 failures, 2 errors. I will dig in a little further into these issues. Details at h

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Alex Gaynor
On Wed, Dec 7, 2011 at 5:17 PM, Ian Clelland wrote: > On Wed, Dec 7, 2011 at 1:07 PM, Alex Gaynor wrote: > >> I'm saying database backends need badly to me refactored to split up >> these two seperate concerns. >> > > Agreed, then. Is there a ticket for this already? (I don't see anything in > t

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
On Wed, Dec 7, 2011 at 1:07 PM, Alex Gaynor wrote: > I'm saying database backends need badly to me refactored to split up these > two seperate concerns. > Agreed, then. Is there a ticket for this already? (I don't see anything in the DB component, looking for 'backend' anywhere in the summary/ke

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Vinay Sajip
On Dec 7, 8:38 pm, Ian Clelland wrote: > > 3. Code speaks, I know -- what's the best way to share this? I've sent > Vinay a patch, but that's for his Py3k branch, and might not get the > audience that something like this needs. I'm doing it for Py3k support, but > ideally it would work just as wel

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
On Wed, Dec 7, 2011 at 12:56 PM, Jannis Leidel wrote: > > Ian, > > > This is a proposal to add support in Django for PyMySQL[1] as an > optional replacement for MySQLdb. > > > > I've been working with Vinay Sajip's Python 3-compatible branch; trying > to get MySQL support working, and I have had

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Alex Gaynor
On Wed, Dec 7, 2011 at 4:03 PM, Ian Clelland wrote: > > > On Wed, Dec 7, 2011 at 12:48 PM, Alex Gaynor wrote: > >> It's a fine goal, though I'm not convinced this should necessarily ship >> with Django given PyMySQL has relatively few users. > > > Agreed; I just don't know of another way to suppo

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
On Wed, Dec 7, 2011 at 12:48 PM, Alex Gaynor wrote: > It's a fine goal, though I'm not convinced this should necessarily ship > with Django given PyMySQL has relatively few users. Agreed; I just don't know of another way to support Python 3 and MySQL, without pushing the MySQLdb developers to a

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Jannis Leidel
Ian, > This is a proposal to add support in Django for PyMySQL[1] as an optional > replacement for MySQLdb. > > I've been working with Vinay Sajip's Python 3-compatible branch; trying to > get MySQL support working, and I have had a great deal of success, using > PyMySQL as a back end, rather

Re: Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Alex Gaynor
On Wed, Dec 7, 2011 at 3:38 PM, Ian Clelland wrote: > Hi, all --- > > This is a proposal to add support in Django for PyMySQL[1] as an optional > replacement for MySQLdb. > > I've been working with Vinay Sajip's Python 3-compatible branch; trying to > get MySQL support working, and I have had a g

Adding Support for PyMySQL (for Python 3)

2011-12-07 Thread Ian Clelland
Hi, all --- This is a proposal to add support in Django for PyMySQL[1] as an optional replacement for MySQLdb. I've been working with Vinay Sajip's Python 3-compatible branch; trying to get MySQL support working, and I have had a great deal of success, using PyMySQL as a back end, rather than MyS