Re: Cleaning up broken pipe errors in runserver

2014-11-07 Thread Tim Graham
An opinion from Emil Stenström posted on the pull request (I'm inclined to agree with it unless there are objections or if someone can propose another solution): I agree that we should use the latest version of handle() from CPython to make sure we are as protected as we can be, even when

Re: Cleaning up broken pipe errors in runserver

2014-11-04 Thread Steve Jalim
Naive / over-obvious suggestion: if there's a genuine stalemate, bundling the changes into a third-party app that supplants core runserver (similar to how django-devserver does it) would avoid the need for individuals to monkey-patch while also making it possible to release versions with more

Re: Cleaning up broken pipe errors in runserver

2014-11-03 Thread Tim Graham
I had a look at the patch. As I mentioned on the ticket, "I am not really happy with that patch which copies the simple_server.WSGIRequestHandler.handle() method from Python's version in order to override it. The copied version is not in sync with the latest Python and I'd prefer not to be in

Re: Cleaning up broken pipe errors in runserver

2014-08-27 Thread Richard Eames
I'm +1 for this, for the same reasons; I have a monkey patch for my selenium tests which does the same thing as this PR. On Saturday, 2 August 2014 18:20:18 UTC-6, Matthew Somerville wrote: > > Hi, > > I have created a branch at > https://github.com/dracos/django/compare/pipe-cleaning that

Cleaning up broken pipe errors in runserver

2014-08-02 Thread Matthew Somerville
Hi, I have created a branch at https://github.com/dracos/django/compare/pipe-cleaning that builds upon a previous patch posted to this list and outputs "Broken pipe" instead of a traceback for such an error. As the history below shows, practically speaking all reports of broken pipe