Well, it might not be the most valuable thing to work on, but if it helps
you get comfortable with the code base and the changes are low to zero
risk, it’s not so bad. I think there might be a smaller set of changes that
reduces the risk.
On Mon, 18 Mar 2019 at 23:08, Alexey Tsivunin wrote:
>
Thanks for your feedback! I'll make a PR in the coming days. I just needed
to know does anyone else think this code needs refactoring or I'm doing
useless work.
--
You received this message because you are subscribed to the Google Groups
"Django developers (Contributions to Django itself)"
Hi
I appreciate the enthusiasm! Making Django's code more readable is
certainly a good goal, but refactoring must be done very carefully as we
don't want to avoid subtle bugs, especially in a function that's directly
used by users.
This mailing list is generally not for low level code
https://github.com/django/django/blob/418263c457636d3301f2068c47f09a0f42e15c52/django/middleware/cache.py#L127
I have an idea how to improve readability of this method. I've already
implemented
it but before creating an issue and PR I decided to discuss it with
community. Maybe
all of this
