Re: Message level API awkwardness

2010-01-10 Thread SmileyChris
On Jan 11, 2:12 pm, Russell Keith-Magee wrote: > I concur. get_level()/set_level() sounds like a reasonable change to > me. Can I have that in the form of a ticket and patch? :-) http://code.djangoproject.com/ticket/12575 -- You received this message because you are

Re: Message level API awkwardness

2010-01-10 Thread Russell Keith-Magee
On Fri, Jan 8, 2010 at 7:10 AM, SmileyChris wrote: > > > On Jan 6, 11:09 pm, Jeremy Dunck wrote: >> I realize I'm very late giving feedback on the API, sorry and feel >> free to ignore if I'm too late. >> >> That said, from the docs, the API to set the

Re: Message level API awkwardness

2010-01-07 Thread SmileyChris
On Jan 6, 11:09 pm, Jeremy Dunck wrote: > I realize I'm very late giving feedback on the API, sorry and feel > free to ignore if I'm too late. > > That said, from the docs, the API to set the effective messaging level > is awkward: > > == > # Change the messages level to

Re: Message level API awkwardness

2010-01-06 Thread Tobias McNulty
That sounds like a pretty simple addition that won't affect (m)any folks, so I'm fine with adding such a wrapper. I'd prefer the methods be called 'get_level' and 'set_level', however, so they're shorter and match the naming of 'get_messages'. Others? On Wed, Jan 6, 2010 at 6:09 PM, Jeremy

Message level API awkwardness

2010-01-06 Thread Jeremy Dunck
I realize I'm very late giving feedback on the API, sorry and feel free to ignore if I'm too late. That said, from the docs, the API to set the effective messaging level is awkward: == # Change the messages level to ensure the debug message is added. messages.get_messages(request).level =