Re: Preparing Django code for the Black stable release

2022-01-30 Thread Mariusz Felisiak
Thanks. We will work on it later this week. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to

Re: Preparing Django code for the Black stable release

2022-01-29 Thread Markus Holtermann
That's wonderful news. Thanks for the info, Paolo! Cheers, Markus On Sat, Jan 29, 2022, at 10:24 PM, Paolo Melchiorre wrote: > Hi all, > > Black 22.1.0 has just been released > https://github.com/psf/black/releases/tag/22.1.0 > > It seems the time has come to put DEP 0008 into practice and "run

Re: Preparing Django code for the Black stable release

2022-01-29 Thread Paolo Melchiorre
Hi all, Black 22.1.0 has just been released https://github.com/psf/black/releases/tag/22.1.0 It seems the time has come to put DEP 0008 into practice and "run Black on the entire Django code repository and make a single commit". Ciao, Paolo On Wed, Oct 20, 2021 at 10:52 PM Paolo Melchiorre

Re: Preparing Django code for the Black stable release

2021-10-20 Thread Paolo Melchiorre
On Wed, Oct 20, 2021, 21:51 Mariusz Felisiak wrote: > > I was thinking we can start right now using black in a branch and see >> which issue will show up and start fixing them. >> > > We don't want to merge multiple commits related to black. According to the > "Implementation" section in DEP

Re: Preparing Django code for the Black stable release

2021-10-20 Thread Mariusz Felisiak
> I was thinking we can start right now using black in a branch and see > which issue will show up and start fixing them. > We don't want to merge multiple commits related to black. According to the "Implementation" section in DEP 0008, we're going to run Black on the entire Django code

Re: Preparing Django code for the Black stable release

2021-10-20 Thread Markus Holtermann
There is https://github.com/MarkusH/django-migrations-formatter which I think holds everything that's necessary to make the migration writer create black-formatted output. Cheers, Markus On Wed, Oct 20, 2021, at 11:11 AM, 'Adam Johnson' via Django developers (Contributions to Django itself)

Re: Preparing Django code for the Black stable release

2021-10-20 Thread Paolo Melchiorre
On Wed, Oct 20, 2021, 11:37 Mariusz Felisiak wrote: > > I think we can start prepare this great migrations of the Django code so >> we will be ready when Black 22.0 will be released and we can finally >> benefit from this change. >> > > Do you have any specific steps in mind? I'm not sot sure

Re: Preparing Django code for the Black stable release

2021-10-20 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
The extension I added to the DEP may be a bit involved: > All code Django generates will also be Black-formatted (startproject, > migrations, inspectdb, etc.), at least if the user has Black installed. > But then again it may only need a few calls to black.format_str() in the right places. On

Re: Preparing Django code for the Black stable release

2021-10-20 Thread Mariusz Felisiak
> As you can see from this pull request in the Black code the first stable > release is expected for January 2022: > https://github.com/psf/black/pull/2529 > > I think we can start prepare this great migrations of the Django code so > we will be ready when Black 22.0 will be released and we

Preparing Django code for the Black stable release

2021-10-20 Thread Paolo Melchiorre
Hi all, More than two years ago the 'DEP 0008: Formatting using Black' was accepted with the constraint to wait until Black got to a stable release: https://github.com/django/deps/blob/main/accepted/0008-black.rst As you can see from this pull request in the Black code the first stable release