Re: proposing max line length of 119 + enforcing it with flake8

2015-09-03 Thread Dražen Odobašić
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi, I've created a PR [0] that applies max. line length of 119 chars to the master branch. Personally, on Firefox-Linux, not all 119 chars are visible on GH, as it's highly dependant of the environment, fonts, dpi, ... With the limit of 113

Re: proposing max line length of 119 + enforcing it with flake8

2015-09-03 Thread anjul.ten
I think we should consider the minimum character limit i.e. 113 characters for Chromium, Ubuntu based on the link shared by *Zach Borboa *into consideration as well. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-04 Thread Collin Anderson
we say 119 because it's 120 minus one, just like PEP8 recommends 79 because it's 80 minus one. It allows for one character at the beginning of the line for a plus or minus sign in a diff. -- You received this message because you are subscribed to the Google Groups "Django developers" group.

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-04 Thread Zach Borboa
Screenshot for comparison. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving

Re: proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Carl Meyer
On 09/03/2014 01:47 PM, Tim Graham wrote: > Ticket #23395 raised the > issue that our contributing guidelines is not exactly clear regarding > long lines. Currently it says, > > "One big exception to PEP 8 is our preference of longer line lengths. >

proposing max line length of 119 + enforcing it with flake8

2014-09-03 Thread Tim Graham
Ticket #23395 raised the issue that our contributing guidelines is not exactly clear regarding long lines. Currently it says, "One big exception to PEP 8 is our preference of longer line lengths. We’re well into the 21st Century, and we have