Re: Yak shaving the test framework on the way to pluggable user models (#3011)

2012-08-25 Thread Julien Phalip
On Aug 25, 2012, at 1:15 AM, Russell Keith-Magee wrote: > Hi all, > > So, I've been working on a Django branch [1] to implement the approach > to pluggable user models that was decided upon earlier this year [2] > > [1] https://github.com/freakboy3742/django/tree/t3011 > [2]

Re: Yak shaving the test framework on the way to pluggable user models (#3011)

2012-08-25 Thread Russell Keith-Magee
On Sat, Aug 25, 2012 at 4:24 PM, Aymeric Augustin wrote: > On 25 août 2012, at 10:15, Russell Keith-Magee wrote: > >> We *could* just mark the affected tests that require auth.User as >> "skipUnless(user model == auth.User)", but that would mean some >>

Re: Streaming HttpResponse revisted. Any core devs, please take a look if you can :)

2012-08-25 Thread Anssi Kääriäinen
On 25 elo, 23:22, Aymeric Augustin wrote: > In my opinion, option 2 is reasonable. I'm -0 on a stream_content keyword > argument for HttpResponse. I +1 on adding a separate HttpStreamingResponse > class, because it better reflects the difference in behavior,

Re: Streaming HttpResponse revisted. Any core devs, please take a look if you can :)

2012-08-25 Thread Aymeric Augustin
Hi Tai, Thanks for your work and sorry for the late answer. I just had the time to review the discussion. In my opinion, option 2 is reasonable. I'm -0 on a stream_content keyword argument for HttpResponse. I +1 on adding a separate HttpStreamingResponse class, because it better reflects the

Re: ORM refactoring, part 2

2012-08-25 Thread Alex Gaynor
On Sat, Aug 25, 2012 at 12:35 PM, Anssi Kääriäinen wrote: > I have done some more ORM refactoring work. I thought it would be a > good idea to post a summary of what is going on. > > First, I haven't committed the utils.tree refactoring patch I was > planning to commit

ORM refactoring, part 2

2012-08-25 Thread Anssi Kääriäinen
I have done some more ORM refactoring work. I thought it would be a good idea to post a summary of what is going on. First, I haven't committed the utils.tree refactoring patch I was planning to commit [https://github.com/akaariai/django/commits/ refactor_utils_tree]. The reason is that I now

Re: Ticket #18855: persist socket in runserver

2012-08-25 Thread Anssi Kääriäinen
On 25 elo, 19:10, Dan LaMotte wrote: > First time contributing to Django, but I've used it for a few years now. >  I'd like to enhance to the dev runserver to persist a socket through > autoreloads.  I've submitted a ticket and a pull request on Github is > linked in the

Ticket #18855: persist socket in runserver

2012-08-25 Thread Dan LaMotte
First time contributing to Django, but I've used it for a few years now. I'd like to enhance to the dev runserver to persist a socket through autoreloads. I've submitted a ticket and a pull request on Github is linked in the ticket. If someone wouldn't mind reviewing the code and giving me