Fellow Report - July 2, 2016

2016-07-02 Thread Tim Graham
Triaged --- https://code.djangoproject.com/ticket/26807 - Document how to replicate SubfieldBase behavior of calling to_python on assignment (accepted) https://code.djangoproject.com/ticket/26813 - ModelForm RadioSelect widget for foreign keys should not present a blank option if

Re: Form field labels change proposal

2016-07-02 Thread Sergei Maertens
I've talked with some other core developers at the sprint, and the proposed flow is more in line with the initial proposal again: * The deprecation cycle would include a settings (let's call it CAPFIRST_MODELFORM_LABEL), defaulting to False (the new behaviour). Users who wish to keep the old

Re: Form field labels change proposal

2016-07-02 Thread Sergei Maertens
https://github.com/sergei-maertens/django/tree/capfirst-deprecation contains a simple POC with the warning filtering. On a fairly large project with a lot of ModelForms and explicit verbose_name's, I see the warning three times on startup. On Saturday, July 2, 2016 at 4:03:14 PM UTC+2, Sergei

Re: Form field labels change proposal

2016-07-02 Thread Sergei Maertens
I am experimenting with warnings.filterwarnings('once', ...), which reduces the total warning output to 4 warnings, while there are about 10-15 calls. I haven't been able to completely silence it, probably because there are certain imports happening before a custom filter comes into pla Opting

Re: Form field labels change proposal

2016-07-02 Thread Tim Graham
How would projects opt-in to the new behavior and silence the deprecation warning? On Saturday, July 2, 2016 at 8:04:23 AM UTC-4, Sergei Maertens wrote: > > So, this is the follow up from the discussion with Markus. > > Implementation wise, we would only apply the capfirst on ModelForm fields >

Re: Form field labels change proposal

2016-07-02 Thread Sergei Maertens
This is the reworked patch assuming the deprecation process was completed: https://github.com/django/django/compare/master...sergei-maertens:modelform-capfirst?expand=1 On Wednesday, November 11, 2015 at 4:59:46 PM UTC+1, Sergei Maertens wrote: > > This is a proposal to change how Django

Re: Form field labels change proposal

2016-07-02 Thread Sergei Maertens
So, this is the follow up from the discussion with Markus. Implementation wise, we would only apply the capfirst on ModelForm fields if the model field has no explicit verbose_name set. That way, you can control the capitalization on the model level without having to specify it on the form

Re: [Feature Request] Orderable ArrayAgg and StringAgg in contrib.postgres.aggregates

2016-07-02 Thread Floris den Hengst
@Josh, thanks for pointing out the Expressions API I will look into it and see if I can come up with a solution that looks reasonable (including an investigation into requirements on contributing to the GROUP BY) and report here / in Trac. On Monday, March 7, 2016 at 1:14:06 PM UTC+1, Tim