Re: About #8500 and #27728

2018-01-21 Thread Raffaele Salmaso
Hi Carlton, On Sat, Jan 20, 2018 at 9:13 AM, Carlton Gibson wrote: > Hi Raffaele, > > Thanks for both your effort and your patience. > > There are around 60 patches needing review (or just reviewed or being > improved or...) at the moment, so it can take a while to get

Re: ManytoMany Field save_form_data has not support for through table

2018-01-21 Thread Andrew Standley
Hey Collin, I posted a new PR: https://github.com/django/django/pull/9609 Let me know what your thoughts are. I also updated the ticket. Cheers, Andrew On Thursday, January 18, 2018 at 6:57:06 AM UTC-8, Collin Anderson wrote: > > Hi Andrew, > > Sure, do you want propose some tests? You

Re: django-sekizai, django-classy-tags unmaintained

2018-01-21 Thread Iacopo Spalletti
On 21/01/2018 02:47, Jonas Obrist wrote: > Hi everyone, > > Two dependencies of django > CMS, https://github.com/ojii/django-classy-tags > and https://github.com/ojii/django-sekizai (both mine) are unmaintained, > because I no longer do Django work. Both are "done" from my point of > view and

Re: Ticket #29015

2018-01-21 Thread Adam Johnson
Please keep the conversation just on the pull request, and don't bug for review after a day. There are many patches to review, and half the work is done by volunteers in their spare time (I am one). Beware that there are 11,195 people subscribed to this mailing list. On 21 January 2018 at 07:56,

Re: Ticket #29015

2018-01-21 Thread Florian Apolloner
You could use ``` if settings_dict.get('NAME') and len(settings_dict['NAME']) ``` if you wanted to prevent a KeyError too. On Sunday, January 21, 2018 at 8:56:40 AM UTC+1, askpr...@gmail.com wrote: > > Hello ! > > I have updated the PR as per Adam's review. However, I have not changed > L155 in