Re: Fellow Reports - December 2018

2018-12-29 Thread Tim Graham
Week ending December 29, 2018 Triaged --- https://code.djangoproject.com/ticket/30052 - QuerySet.only() doesn't support annotations (invalid) https://code.djangoproject.com/ticket/30049 - GIS widgets don't initialize properly after clicking "Add another" in admin inlines (accepted) htt

Re: CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

2018-12-29 Thread Florian Apolloner
Hi Adam, On Saturday, December 29, 2018 at 7:59:44 PM UTC+1, Adam Johnson wrote: > > since request.META is always there whilst attributes might not be if the > middleware aren't set up properly? > request.META is always there, but the keys inside there might not be. In that sense you have to do

Re: CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

2018-12-29 Thread Adam Johnson
It looks like it dates back to the Django 1.1 refactor and extension in https://github.com/django/django/commit/8e70cef9b67433edd70935dcc30c621d1e7fc0a0 ticket #9977, for which the referred wiki page ( https://code.djangoproject.com/wiki/CsrfProtection) is still up too with rationales about the des

Re: New Developer

2018-12-29 Thread charettes
Hello there, You should find all you need from the contributing guide[0] but since you just started using Django it might be hard to contribute until you get more familiar with the framework. This mailing list is dedicated to development of Django itself such as getting feedback for new featur

New Developer

2018-12-29 Thread Surajeet Das
I am a newbie to Django . I recently used it to create a website .But I am interested in contributing to Django . How do I start helping ? -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe fro

CSRF Middlware and usage of request attributes (META, csrf_cookie_needs_reset)

2018-12-29 Thread Florian Apolloner
Hi there, I am considering rewriting and (hopefully) simplifying the CSRF middleware. While looking through the code I realized that we put stuff into request.META as well as attributes on the request object itself (csrf_cookie_needs_reset) for instance. Is there any reason why we do not stick