Re: MFA (2FA)

2022-04-09 Thread Carlton Gibson
> I do agree that a simple, opinionated solution in django itself could > push 2FA adaption and therefore general security on the web, which is > clearly a good thing. But I still think this works better in a third > party app such as django-mfa3. I'd very much like us to have **some** story in

Re: Revisiting MSSQL and Azure SQL Support in Django

2022-04-02 Thread Carlton Gibson
Hey Tim. FWIW I have directly asked people at Oracle if they would take up a corporate sponsorship of the DSF in order to help support the ongoing maintenance of the backend. Again, it was almost like I hadn't said anything. Rather than a Yes or a No, they did instead offer some cloud hosting, whi

Re: Revisiting MSSQL and Azure SQL Support in Django

2022-04-01 Thread Carlton Gibson
> Then there is also the question on how to ensure continued commitment from Microsoft -- what happens when Microsoft (or the current PM/PO or whatever) looses interest? IMO. This is the biggest one. What I'd expect to see here is MS taking up a long-term corporate sponsorship of the DSF, demonst

Re: feature request: admin dark theme as an option in settings.py

2022-03-02 Thread Carlton Gibson
Hi Michael. The easiest thing to do here is override the CSS file at: django/contrib/admin/static/admin/css/dark_mode.css So, most often, put a `admin/css/dark_mode.css` in a project level folder defined by `STATICFILES_DIRS`. https://docs.djangoproject.com/en/4.0/howto/static-files/#configuring-

Django bugfix release: 4.0.3

2022-03-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2022/mar/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: DATABASES setting for async usage

2022-02-01 Thread Carlton Gibson
Hey Andrew. Thanks for pushing this work. It's very cool! So... Andrew (Godwin)'s current PR blocks out the async interface for QuerySet. For now, it's a light-weight wrapper around the existing sync code, using sync_to_async to hand-off the DB o

Django security releases issued: 4.0.1, 3.2.11, and 2.2.26

2022-01-04 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2022/jan/04/security-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and st

Re: select_for_update and transactions (bad dev UX in a feature)

2021-11-20 Thread Carlton Gibson
On Sat, 20 Nov 2021 at 14:21, Florian Apolloner wrote: > I even have a possible fix for that, but it requires us to rewrite > middlewares again :/ > This is the third time this has come up (the middleware rewrite I mean) Rule of Threes. We need a DjangoCon, so we can draft a DEP. :) > -- You

Re: Proposed change in ORM model save logic

2021-10-18 Thread Carlton Gibson
OK, thanks all, let's reopen. These kind of wontfix+MailingList issues is more about getting more eyes on it than anything else, and the explanation you've given is super Barry. C. On Sunday, 17 October 2021 at 09:59:18 UTC+2 Aymeric Augustin wrote: > Hello, > > On 15 Oct 2021, at 08:49, Barr

Re: (Circa end of 2021) Localization issues with input type=date?

2021-10-12 Thread Carlton Gibson
Thank you all, yes — there's some good points there. (Some others raised on the PR and the ticket too.) It's looks like there are still some caveats, and describing those succinctly remains to do. 👍 Kind Regards, Carlton On Wednesday, 29 September 2021 at 21:13:51 UTC+2 Tobias Bengfort wro

Django bugfix release: 3.2.8

2021-10-05 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/oct/05/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contribution

Re: Postgresql testing question

2021-10-03 Thread Carlton Gibson
Hey Sarah, no problem! If you can’t work out why you’re seeing a failure locally, perhaps post on the forum and I’ll see if I can help out (or Ken will be me to it 😃) Kind regards, Carlton On Sun, 3 Oct 2021 at 19:38, Sarah A wrote: > Thanks Carlton ! > > Yes, it's not related, it's tests abou

Re: Postgresql testing question

2021-10-03 Thread Carlton Gibson
Hi Sarah. 👋 If the failures are unrelated, you can ignore them for the purposes of your ticket: if you open a PR the CI will run against all configurations, so an issue should show up there. Maybe it’s a local config issue, but if it doesn't look that way, you can open a ticket on Trac (with the

(Circa end of 2021) Localization issues with input type=date?

2021-09-28 Thread Carlton Gibson
Hi all. There's a PR to add examples using `` for `forms.DateInput`. https://github.com/django/django/pull/14905 Support for HTML5 input types was added a long time back now in #16630 . Back then there were various issues with localisation when **n

Re: Fellow Reports -- August 2021

2021-09-01 Thread Carlton Gibson
Hi all, Calendar Week 34 -- ending 29 August. Triaged: https://code.djangoproject.com/ticket/33046 -- Fully cached result approach of the QuerySet.count is not documented. (Accepted) https://code.djangoproject.com/ticket/33035 -- Autocomplete and populating Subcategories based on selected C

Fellow Reports -- August 2021

2021-08-22 Thread Carlton Gibson
Hi all. Calendar Week 31 -- ending 08 August. Triaged: https://code.djangoproject.com/ticket/32988 -- The number of test databases should not be greater than number of TestCases. (Accepted) https://code.djangoproject.com/ticket/32980 -- Improve performance of related manager attribute access

Re: Recognising Contributions

2021-08-19 Thread Carlton Gibson
Hey Tim. > As an infrequent contributor these days, I'm not seeking any more recognition > from my contributions, nor would more recognition encourage me to contribute > more. I'd rather the Django team spend their efforts on building software > than on publicity. Recognising contributions, in

Re: Recognising Contributions

2021-08-18 Thread Carlton Gibson
o be useful for > "pulling back the curtain" and making Django's code a bit less magical. Plus > it could help the workflow for current contributors. > > On Mon, 5 Jul 2021 at 16:07, Tom Forbes > wrote: > Perhaps we could do this as part of a Sphinx plugin

Re: RSS access to Google groups?

2021-08-13 Thread Carlton Gibson
Hey Claude. Not sure. (I’m learning it as much as you are.) I’ve asked on the Discourse meta forum. https://meta.discourse.org/t/filter-email-notifications-by-topic/200383?u=carltongibson On Fri, 13 Aug 2021 at 22:53, Claude Paroz wrote: > So I activated mailing list mode, and chose i18n/geodj

Re: RSS access to Google groups?

2021-08-13 Thread Carlton Gibson
Hey Claude. Here: https://forum.djangoproject.com/my/preferences/categories You can set to watch particular categories (or just first posts in a thread or … ) C. > On 13 Aug 2021, at 18:24, Claude Paroz wrote: > > A question received privately: imagine someone wants to follow the > Int

Re: RSS access to Google groups?

2021-08-05 Thread Carlton Gibson
OK, I don't think I have the powers to set that up, so I've asked Andrew, and that you get added to the "staff" there so you can moderate etc. -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscri

Re: RSS access to Google groups?

2021-08-04 Thread Carlton Gibson
Hey Claude. > Maybe we could start by moving django-i18n and geodjango lists? So, rough steps: 0: Update docs to point to Forum rather than Google Groups. 1. Post on django-i18n and geodjango lists that the action is now on the Forum. https://forum.djangoproject.com 2. We can create new sub-

Re: Django bugfix release: 3.2.6

2021-08-03 Thread Carlton Gibson
t.com/weblog/2020/oct/01/django-bugfix-release-312/> > > On Mon, Aug 2, 2021 at 2:37 PM Carlton Gibson <mailto:carlton.gib...@gmail.com>> wrote: > Details are available on the Django project weblog: > > https://www.djangoproject.com/weblog/2021/aug/01/bugfix-release/

Re: Django bugfix release: 3.2.6

2021-08-02 Thread Carlton Gibson
shouldn’t use computers. > On 2 Aug 2021, at 08:37, Carlton Gibson wrote: > > Details are available on the Django project weblog: > > https://www.djangoproject.com/weblog/2021/aug/01/bugfix-release/ > > -- You received this message because you are subscribed to the G

Django bugfix release: 3.2.6

2021-08-01 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/aug/01/bugfix-release/ -- You received this message because you are subscribed to the Google Groups "Django developers (C

Re: Fellow Reports -- July 2021

2021-08-01 Thread Carlton Gibson
Hi all. Calendar Week 29 -- ending 25 July. Triaged: https://code.djangoproject.com/ticket/32954 -- Improve error message with URLValidator and schemes (wontfix) https://code.djangoproject.com/ticket/32949 -- decimal.InvalidOperation error on DecimalField form field (Accepted) Reviewed:

Re: FIleField(null=True) (Was: Guardrails around lack of model validation on blank=True fields)

2021-08-01 Thread Carlton Gibson
Hi Raffaele. Looking at #10244, it looks as if it needs someone to pick up Aymeric's suggestion. Would that be you? 😀 (Since you favour the option 2 there, I'd try that — it's probably OK with a suitable release note, as Aymeric said.) C. On Tuesday, 27 July 2021 at 23:46:33 UTC+2 Raffaele Sal

Re: RSS access to Google groups?

2021-07-30 Thread Carlton Gibson
Upvoted, but I'm not holding out hope. 🤨 There was discussion a while back about moving the discussion here to the Forum. Perhaps it's time to think again about doing that? (Andrew and Tom were discussing migrating the history. I don't think we should block on that.) C. On Thursday, 29 July 2

Re: Guardrails around lack of model validation on blank=True fields

2021-07-27 Thread Carlton Gibson
OK, super. Would you then fancy looking at that docs change? It does come up. It _is_ surprising that `blank` has this effect, and I'm not convinced it says clearly anywhere how you should approach it… Thanks for your efforts digging into this! 👍 C. On Tuesday, 27 July 2021 at 14:22:50 UTC+2

Re: Guardrails around lack of model validation on blank=True fields

2021-07-27 Thread Carlton Gibson
Hi Jacob. Thanks for the follow-up. Good hustle! 😉 I saw your comments on Trac last week, and was preparing a response. The trouble with these 8, 7, and 5 year old tickets is that they're tricky… Let me put the take-home first, I think that in-themselves we should close all three of these t

Re: [TB] Proposal to add Florian Apolloner to Releasers team.

2021-07-23 Thread Carlton Gibson
> Given that I'd mostly serve as fallback I guess it would be fine (assuming we > have a good documented release process :D) We do. I’d not be able to do it otherwise. 🥳 https://docs.djangoproject.com/en/dev/internals/howto-release-django/ -- You received this message because you are subscribed

Re: template API to list templates

2021-07-23 Thread Carlton Gibson
Hey Chris. I'd be interested in something like this. (Recently have found myself needing to generate similar for integration with CSS purge tooling...) C. On Saturday, 3 July 2021 at 16:44:49 UTC+2 chris.j...@gmail.com wrote: > Hi, > > I recently had a need to iterate over all templates in

[TB] Proposal to add Florian Apolloner to Releasers team.

2021-07-21 Thread Carlton Gibson
Hello Technical Board. Mariusz is working on updating the Organisation docs to reflect the DEP 10 governance changes. https://github.com/django/django/pull/14670 Whilst looking at that we realise that we're short an active official Releaser. > The technical board select Releasers as necess

Fellow Reports -- July 2021

2021-07-20 Thread Carlton Gibson
Hi All, Calendar Week 26 -- ending 04 July. Triaged: https://code.djangoproject.com/ticket/32889 -- Use asgiref ThreadSensitiveContext to allow per-request sync threads. (Accepted) Reviewed: https://github.com/django/django/pull/13609 -- Fixed #32144 -- Made makemessages remove tempora

Re: Fellow Reports -- June 2021

2021-07-01 Thread Carlton Gibson
Hi all. Calendar Week 23 -- ending 13 June. Triaged: https://code.djangoproject.com/ticket/32842 -- Refactor out a _check_token() method of CsrfViewMiddleware (Accepted) https://code.djangoproject.com/ticket/32797 -- model_ngettext incorrectly tries to translate already translated words (ne

Re: Recognising Contributions

2021-06-30 Thread Carlton Gibson
Hi David, Thanks for this. Yes. Let's assume the 2020-2021 time filter is in place. Mariusz recently picked up James' PR to add the list of Core Contributors (back) to the website, which is/was part of the DEP 10 governance changes. https://github.com/django/djangoproject.com/pull/1099 The

Re: CTRL-BREAK still make sense on Windows for `runserver`?

2021-06-21 Thread Carlton Gibson
I too realise I don't have a(n obvious) break key but have been happily hitting CTRL-C. On Monday, 21 June 2021 at 23:53:15 UTC+2 Adam Johnson wrote: > Would it be bad to have Django respond to both shortcuts? > I think as a matter of fact it does. At least using PowerShell/Win10/Etc — Lookin

Re: Removal of USE_L10N setting

2021-06-15 Thread Carlton Gibson
Hey Claude, thanks for this. This seems like a win to me... a nice clean-up. I have to say, I never once set `USE_L10N = False` — I don't imagine many people do, but my only concern would be whole swaths of folks that depend on this… — do such exist in numbers? 🤔 This comments seemed pertinent

Re: Accessibility standards & contribution guidelines for Django

2021-06-15 Thread Carlton Gibson
Hi Thibaud. Thanks for this, and for your efforts here generally! 🥇 > ...a long-overdue follow up... This is the only bit I can't agree with 😀 — ticking along, slow-and-steady, is realistic/sustainable/desirable/... 🙂 You mention a lot of things, so that'll take a little while to absorb — li

Re: Upcoming Contributing to the Django Docs Workshops

2021-06-13 Thread Carlton Gibson
We’ll send out a link for the first workshop this Tuesday. On Sun, 13 Jun 2021 at 18:44, moshe nahmias wrote: > Thanks for the reply, when are we supposed to get a link to connect to for > the workshop? > > On Sun, Jun 13, 2021 at 6:17 PM Daniele Procida wrote: > >> moshe nahmias wrote: >> >> >

Upcoming Contributing to the Django Docs Workshops

2021-06-09 Thread Carlton Gibson
Hi all. Daniele Procida will be leading a couple of free workshops on contributing to the Django docs, and learning the Diátaxis framework for documentation. These will be over the next two Wednesdays, the 16th and 23rd of June, at different times to be available as many timezones as possible

Fellow Reports -- June 2021

2021-06-08 Thread Carlton Gibson
Hi all, Calendar Week 22 -- ending 06 June. Mostly at/doing DjangoCon Europe Released Django 3.2.4, 3.1.12, and 2.2.24. Triaged: https://code.djangoproject.com/ticket/32790 -- Django test client redirecting to URLs without a trailing slash redirects instead to the current view (Accepte

Re: Discussion regarding #32628 and #32823

2021-06-07 Thread Carlton Gibson
Hi Sébastien. Sorry you feel hard done by here. I think that's perhaps unfamiliarity with the workflow. As per the triage workflow that Mariusz pointed you to, this is the correct place to discuss tickets that are marked as wontfix. The reality is we have a constant firehose of new tickets and

Re: Do we add versionadded blocks or does the release manager?

2021-06-06 Thread Carlton Gibson
Hi Jared, It’s great if you add them. The eventual merger will review them, but it’s good to have them in place from the beginning. Thanks! Kind Regards, Carlton > On 7 Jun 2021, at 07:11, Jared Chung wrote: > > If I'm contributing a new feature, would it be appropriate for my PR to > inc

Re: What to do about formfield_callback?

2021-06-06 Thread Carlton Gibson
Hey James, Yes, I’ll top-post because I basically agree with all of that. Thanks. +1 C. > On 6 Jun 2021, at 01:34, James Bennett wrote: > > On Fri, Jun 4, 2021 at 11:54 PM Carlton Gibson > wrote: >> I'm sympathetic to the suggestion here, but wary of expanding t

Re: Changing widget rendering templates

2021-06-05 Thread Carlton Gibson
Hi David. Thanks for this. Sorry for the slow pick-up: DjangoCon this week. :) I'd say option 1: It's an accessibility change and we should just opt people into that. IIRC there are some small improvements to the current HTML (aria roles and such) that would improve accessibility even if not

Re: What to do about formfield_callback?

2021-06-04 Thread Carlton Gibson
Hey James. Thanks for this. Good explanation. I'm sympathetic to the suggestion here, but wary of expanding the Forms API, which already has a number of different ways of holding it. > ...to impose uniform custom widget attributes and error messages across a bunch of ModelForms... My initia

Django security releases issued: 3.2.4, 3.1.12, and 2.2.24

2021-06-02 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/jun/02/security-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contr

Re: Fellow Reports -- May 2021

2021-05-30 Thread Carlton Gibson
Hi all. Calendar Week 19 -- ending 16 May. Triaged: https://code.djangoproject.com/ticket/32744 -- Template changes cause dev server to reload (worksforme) https://code.djangoproject.com/ticket/32743 -- Migrations don't alter foreign key data types when referencing primary keys in MTI model

Re: Beginner friendly issues

2021-05-30 Thread Carlton Gibson
Hi. We don’t really have a set of beginner tickets labelled. There’s the “Easy Pickings” label, that’s mentioned in the contributing guide: https://code.djangoproject.com/query?status=assigned&status=new&easy=1&desc=1&order=id There aren’t too many of those, but you’re welcome to take on any of

Re: GSoC Proposal: (Migrations) Adapt schema editors to operate from model states instead of fake rendered models.

2021-05-21 Thread Carlton Gibson
eadline. >> I understand that as the proposal is detailed you will have to sit down >> with it more fully but you don't have time for the same and It's totally >> fine. >> >> Thank You for your suggestions that always help a lot. >> >> >>

Fellow Reports -- May 2021

2021-05-18 Thread Carlton Gibson
Hi all. Calendar Week 18 -- ending 09 May. Released Django 3.2.1, 3.1.9, and 2.2.21 Reviewed: https://github.com/django/django/pull/14358 -- Removed unused TestHashedFiles._max_post_process_passes. https://github.com/django/django/pull/14349 -- Fixed #32713, Fixed CVE-2021-X -- Preven

Re: Best status to start to contribute

2021-05-18 Thread Carlton Gibson
Hi Sarah, Welcome! Beyond the “easy pickings”, another good approach is to filter by component. The framework is so big, no-one can take it all on. Here a filter for the GeoDjango tickets

Re: Hi i'm new on python and django!

2021-05-12 Thread Carlton Gibson
Hi Juan. The #123 will refer to a ticket number on the Django Trac issue tracker instance. So that would be: https://code.djangoproject.com/ticket/123 (which was a while back…) Have a browse around there and get comfortable. Filtering by component is a useful way to break it down. Here’s a filt

Django security releases issued: 3.2.1, 3.1.9 and 2.2.21

2021-05-04 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/may/04/security-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contri

Re: Fellow Reports -- April 2021

2021-05-02 Thread Carlton Gibson
Hi all, Calendar Week 17 -- ending 02 May. Triaged: https://code.djangoproject.com/ticket/32694 -- Colored output detection issue in VS Code on Windows 8.1 (wontfix) Reviewed: https://github.com/django/django/pull/14329 -- Refs #32682 -- Renamed lookup_needs_distinct() to lookup_spawns

Re: Fellow Reports -- April 2021

2021-04-29 Thread Carlton Gibson
Hi all. Calendar Week 16 -- ending 25 April. Triaged: https://code.djangoproject.com/ticket/32671 -- CSS var() causes relative URLs to break in Safari (wontfix) https://code.djangoproject.com/ticket/32668 -- Separate test-collection setup from runtests.py's setup() for use in get_app_test_l

Re: include_block template tag

2021-04-22 Thread Carlton Gibson
code feature-creep is cheaper >>>> than documentation / support effort needed to explain away demands for the >>>> functionality? >>>> >>>> Curtis, you're free to use this in your Sniplates. I'd just warn about >>>> the helper functio

Fellow Reports -- April 2021

2021-04-20 Thread Carlton Gibson
Hi all. Calendar Week 13 -- ending 04 April. Triaged: https://code.djangoproject.com/ticket/32610 -- django.utils.version.get_git_changeset() always returns None. (Accepted) https://code.djangoproject.com/ticket/32604 -- File uploads larger than FILE_UPLOAD_MAX_MEMORY_SIZE get wrong unix g

Re: include_block template tag

2021-04-16 Thread Carlton Gibson
> having to swap an entire page's worth of template. Very easy to do "view > result" vs "view code" in your templates then to give one example. In our > templates we use it to seamlessly switch between various CSS frameworks that > we support. > > L

Django Debug Toolbar security releases issued: 3.2.1, 2.2.1 and 1.11.1.

2021-04-14 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/apr/14/debug-toolbar-security-releases/ -- You received this message because you are subscribed to the Google Group

Re: GSoc proposal : A django pdfs library.

2021-04-11 Thread Carlton Gibson
Hi Anuttam — If you're happy I'd submit. I'm afraid I don't have capacity to pre-review before the deadline here. Good luck. Kind Regards, Carlton On Monday, 12 April 2021 at 08:27:12 UTC+2 anutta...@gmail.com wrote: > Hey , > Can anyone please let me know if I have to include other things

Re: django-amp-tools project improvement

2021-04-11 Thread Carlton Gibson
This might be OK as a third-party package but I don't think it would be something we'd include in Django itself. Nor I think would we accept it as a GSoC project. Sorry. Kind Regards, Carlton On Monday, 12 April 2021 at 08:19:10 UTC+2 parth...@gmail.com wrote: > Can I propose to make an of

Re: GSoC Proposal: (Migrations) Adapt schema editors to operate from model states instead of fake rendered models.

2021-04-07 Thread Carlton Gibson
n the proposal > <https://gist.github.com/manav014/9b0feb734e4d140eef1913340602d2ae>, or > does it seems fine? > > Regards > Manav Agarwal > > On Tue, Apr 6, 2021 at 7:09 PM Carlton Gibson > wrote: > >> Hi Manav. >> >> Sorry for the late

Re: Can't translate strings properly to Hebrew and Arabic (#31937)

2021-04-06 Thread Carlton Gibson
; direction. Maybe it's possible to update things automatically via Transifex? >> >> Thanks, >> Uri. >> אורי >> u...@speedy.net <mailto:u...@speedy.net> >> >> On Tue, Apr 6, 2021 at 4:32 PM Carlton Gibson > <mailto:carlton.gib...@gmail

Re: Can't translate strings properly to Hebrew and Arabic (#31937)

2021-04-06 Thread Carlton Gibson
e if we are in the right > direction. Maybe it's possible to update things automatically via Transifex? > > Thanks, > Uri. > אורי > u...@speedy.net <mailto:u...@speedy.net> > > On Tue, Apr 6, 2021 at 4:32 PM Carlton Gibson <mailto:carlton.gib...@gmail.com&

Re: GSoc proposal : A django pdfs library.

2021-04-06 Thread Carlton Gibson
Hi Anuttam. I’d guess that a PDF library itself would be out of scope for Django itself — but this is a perennial problem. **Quite maybe** a project to modernise the Outputting PDFs with Django docs would be in scope... 🤔 https://docs.djangoproject.com/en/3.1/howto/outputting-pdf/ Questions tha

Re: GSoC Proposal: (Migrations) Adapt schema editors to operate from model states instead of fake rendered models.

2021-04-06 Thread Carlton Gibson
Hi Manav. Sorry for the late reply. Your proposal looks very good, and your previous contributions are noticed. You’ve obviously taken time to look at it in depth. I think just going over it this week as time allows to maximise clarity is worth it. That’s always time well spent. (Generally there

Re: Google season of docs

2021-04-06 Thread Carlton Gibson
Hi. On Sun, 4 Apr 2021 at 12:12, Mhd Ali wrote: > Will Django be participating in Google season of docs this year? > No, we didn’t apply this year. Simply for the lack of spare capacity given the ongoing pandemic, we didn’t feel we had the bandwidth. Kind regards, Carlton > -- You received

Re: Can't translate strings properly to Hebrew and Arabic (#31937)

2021-04-06 Thread Carlton Gibson
Hey Uri. Thanks for bumping this up — Yes, it looks like the plan is to make the adjustments that you suggested on the ticket. I guess I’d just suggest doing a little bit as a proof-of-concept and opening a Draft PR so we can have a look, and confer with Claude to approve the general approach, be

Django 3.2 Released

2021-04-06 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/apr/06/django-32-released/ -- You received this message because you are subscribed to the Google Groups "Django developers (Con

Re: Request for Comment: settings growth configuring Email Backend.

2021-04-03 Thread Carlton Gibson
Hey Tim. I'm not sure if there's anything I might say to persuade you. 🤔 > I don't think there's a big cost to additional... Yes, and that's the same argument from 7 years ago, and at other times in between. I grant that at each point an additional setting (or three) is the least disruptive

Re: Django Benchmark query

2021-04-02 Thread Carlton Gibson
Hi Khushi. Did you see the "Writing new benchmarks" section of the README[0]?. It's suggests the query_delete benchmark[1] as a good one to follow. If you're following David's recent work using ASV, you'll need to read through the issue[2], and look at the repo for that[3], as well as explo

Re: Request for Comment: settings growth configuring Email Backend.

2021-04-01 Thread Carlton Gibson
Hey Tim, Thanks for following up here. Thanks also for the link to the previous discussion, very interesting. So, looking at that, this was first discussed 7 years ago, when there were (just) 6 email related settings. I liked Jannis' initial reaction at the time: "Oh god, YES!!" It didn'

Re: GSOC Proposal: Adding Redis Cache Backend To Django Core.

2021-03-31 Thread Carlton Gibson
> On 31 Mar 2021, at 11:00, Girish Sontakke wrote: > > Now I have doubt that whether I should remove Provides Many Data-Structures > point from the "Why Redis" section or keep it there?. I don’t think it’s vital either way… but it seems a distraction. That Redis has HyperLogLog isn’t somethi

Re: GSOC Proposal: Adding Redis Cache Backend To Django Core.

2021-03-31 Thread Carlton Gibson
Hi Girish, Welcome. Have a search of the history of the mailing list here. There was one, or a couple of (?) threads on adding a Redis backend recently (last year or two). >From the "Why Redis" section of your proposal, I think the answer is simply that lots of users (most in fact according

Re: Fellow Reports -- March 2021

2021-03-30 Thread Carlton Gibson
Hi all, Calendar Week 12 -- ending 28 March. Triaged: https://code.djangoproject.com/ticket/32591 -- Change DiscoverRunner always to run _FailedTest "tests" first (Accepted) https://code.djangoproject.com/ticket/32589 -- Document the need for calling close_old_connections in long-running

Fellow Reports -- March 2021

2021-03-25 Thread Carlton Gibson
Hi all. Calendar Week 9 -- ending 07 March. Triaged: https://code.djangoproject.com/ticket/32504 -- Update admin's jQuery to 3.6.X. (Accepted) https://code.djangoproject.com/ticket/32412 -- User.has_perm should forward **kwargs to allow more flexibility in authentication backends (wontfix)

Re: #17193, Mass Templated Emails and support for mass EmailMessage (s)

2021-03-24 Thread Carlton Gibson
Hi Muskan. Thanks for picking this up. The discussion on the ticket seems reasonable to me: it's probably, on the margin, a common enough case to justify a TemplatedMessage subclass that wraps up the render_to_string() dance there. That seems small enough and addressable. As per https://

Re: Django Project idea query

2021-03-24 Thread Carlton Gibson
Hi Khushi. Thanks for the interest. This is a good topic. Particularly with the async changes it's really important that we can profile changes. See https://github.com/django/django/pull/13651 This adds async signal dispatch, which would allow us a fully-async request-response pathway (assum

Moving rest_framework.status into core?

2021-03-23 Thread Carlton Gibson
Hiya. Maybe my search-foo is down but, surprisingly, I couldn't find a discussion on this. Should we maybe bring the HTTP status code constants that we find in rest_framework.status into core, as django.http.status? I find myself wanting them (not for the first time) in a project that does

Re: Bug in migrations when testing on Django 3.2b1

2021-03-18 Thread Carlton Gibson
which adjusted AppConfigStub, so maybe related. (You could see if reverting that helps.) On Thursday, 18 March 2021 at 15:39:04 UTC+1 Carlton Gibson wrote: > Hi. > > So, first off, thanks for testing! > > Initial thoughts: > > * We might need a bit more to be able to

Re: Bug in migrations when testing on Django 3.2b1

2021-03-18 Thread Carlton Gibson
Hi. So, first off, thanks for testing! Initial thoughts: * We might need a bit more to be able to reproduce — are you able to narrow down the problem? * "Which migration it is varies between runs" — that sounds fun 😀 * "Changing AppConfig.name..." — The AppConfig loading was reworked, it co

Django 3.2 release candidate 1 released.

2021-03-18 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/mar/18/django-32-rc1/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions

Re: Proposal to add attribute 'step' to FloatField and DecimalField

2021-03-17 Thread Carlton Gibson
> On 17 Mar 2021, at 15:34, Jacob Rief wrote: > > But FloatField also offers a min_value and max_value. When rendered as a > widget, they are used as attributes min and max in their input > field. In addition to that, the field value is validated against a value in > that range. To be consist

Re: Proposal to add attribute 'step' to FloatField and DecimalField

2021-03-17 Thread Carlton Gibson
Hiya, DecimalField already sets step based on the number of decimal places def test_decimalfield_widget_attrs(self): f = DecimalField(max_digits=6, decimal_places=2) self.assertEqual(f.widget_attrs(Widget()), {}) self.assertEqual(f.widget_attrs(NumberInput()), {'step

Re: Difference between AdminSite.admin_view and staff_member_required?

2021-03-09 Thread Carlton Gibson
ff=python` in .gitattributes) > > The last commit to admin_view was in 2009. The last commit to > staff_member_required was 2015. It was documented shortly after that. > > So it seems like the documentation is up to date with the code. > > On 09/03/2021 14.50, Carlton Gibson wrote:

Re: Difference between AdminSite.admin_view and staff_member_required?

2021-03-09 Thread Carlton Gibson
Hi. > On 9 Mar 2021, at 14:33, Tobias Bengfort wrote: > > According to [0] ... > > [0] > https://docs.djangoproject.com/en/3.1/ref/contrib/admin/#the-staff-member-required-decorator Those docs are unchanged since they were added 6 years ago. https://github.com/django/django/commit/e8a758e941

Re: Difference between AdminSite.admin_view and staff_member_required?

2021-03-09 Thread Carlton Gibson
Hi Tobias. I’ve always taken it that @staff_member_required is for decorating views that aren’t part of the admin, and so not accessed via AdminSite.get_urls(). I don’t think I’d use AdminSite.admin_view() outside of the context in the example there. I can’t think why one would do that… 🤔 —

Re: Help with ticket #28426

2021-03-04 Thread Carlton Gibson
Hi Bence, welcome! There are already a couple of tests in place to check the remove fetching: https://github.com/django/django/blob/05bbff82638731a6abfed2fe0ae06a4d429cb32f/tests/admin_scripts/tests.py#L2047-L2072 Without changing the command code I'd first add view (in admin_scripts/urls.py

Fellow Reports -- February 2021

2021-02-28 Thread Carlton Gibson
Hi all. Calendar Week 5 -- ending 07 February. Triaged: https://code.djangoproject.com/ticket/32411 -- JSONField filter icontains is case sensitive in mysql (Invalid) https://code.djangoproject.com/ticket/32409 -- TestCase async tests are not transaction-aware (Accepted) https://code.django

Django 3.2 beta 1 released

2021-02-19 Thread Carlton Gibson
Details are available on the Django weblog: https://www.djangoproject.com/weblog/2021/feb/19/django-32-beta-1-released/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and s

Django security releases issued: 3.1.7, 3.0.13 and 2.2.19

2021-02-19 Thread Carlton Gibson
Details are available on the Django project weblog: https://www.djangoproject.com/weblog/2021/feb/19/security-releases/ -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and st

Getting initial parameters of inline admin model formset using URL

2021-02-12 Thread Carlton Gibson
HI Manav. Thanks for your work on the PR! I think with the new get_formset_kwarg() method in place folks could subclass in order to add initial data. This is in contrast to the issue the PR resolves, where there was no real access point to customise the behaviour. I’d say that’s the right balan

Re: First time contributor, requesting permission to work on #32340

2021-02-11 Thread Carlton Gibson
is, but I am keen to contribute and can't wait to get started. > > Thanks, > Surya > > > On Tue, Feb 2, 2021 at 3:32 PM Surya Banerjee > wrote: > >> Hi Carlton, >> >> Thanks for the directions. I have posted my question on the issue tracker. &g

Re: Easy Pickings

2021-02-11 Thread Carlton Gibson
Hi David I think this is a good idea. The contributing guide says to look for easy pickings tickets as a good way to get started, but there are hardy any, so there’s a bit of a disconnect there. I don’t think there’s any harm in a false positive, so don’t be shy. 😃 Thanks! C. On Wed, 10 Feb 20

Re: runserver hangs forever, without log of error in console, in two cases

2021-02-09 Thread Carlton Gibson
Hi Michael. Welcome! I think on both of these a general, "Yes please, if you want to work on it, super!" is appropriate. On 1, there's already a system check warning: System check identified no issues (0 silenced). You have 1 unapplied migration(s). Your project may not work properly until you

Re: @cached_property in admindocs

2021-02-04 Thread Carlton Gibson
Hey Nat, I’d agree, probably yes. On Wed, 3 Feb 2021 at 15:04, Nat Dunn wrote: > From the documentation > : The > models section of the admindocs page describes each model in the system > along with all the fields, properties, a

Re: Deprecating django.utils.functional.cached_property() ?

2021-02-04 Thread Carlton Gibson
Thanks Tim. Trac’s search let me down there. Will review with a mind to accept. On Thu, 4 Feb 2021 at 12:00, Tim Graham wrote: > There's a ticket about it: https://code.djangoproject.com/ticket/30949 > > On Thursday, February 4, 2021 at 5:57:15 AM UTC-5 carlton...@gmail.com > wrote: > >> functoo

Deprecating django.utils.functional.cached_property() ?

2021-02-04 Thread Carlton Gibson
functools.cached_property is available from Python 3.8. https://docs.python.org/3.9/library/functools.html#functools.cached_property Is there any benefit to maintaining our own version, or should we deprecate django.utils.functional.cached_property() with Django 4.0? Thanks. Carlton -- You r

<    1   2   3   4   5   6   7   8   >