Re: Proposal to format Django using black

On Sun, Apr 14, 2019 at 1:06 PM Florian Apolloner wrote: > This is imo not something that scales well. Also it is not something I want > to pay our fellows for, I rather have them use their time on something else. > It is true that it is probably easier and faster to just fix code instead of >

Re: Proposal to format Django using black

On Sun, Apr 14, 2019 at 1:34 AM Carlton Gibson wrote: > > We spend a lot of time spotting small formatting errors and then asking for > those to be fixed and then waiting for an update. This wastes reviewer time > and slows down the feedback cycle. Many pull requests drag out because of it.

Re: Proposal to format Django using black

On Sat, Apr 13, 2019 at 9:19 PM Tobias McNulty wrote: > Overall, the main downside I see is the large, fairly useless changeset this > would create and the impact it would have, such as reduced utility of `git > blame` for some portion of the code for the foreseeable future and > interruption

Re: [feature request] including HttpResponse(status=204) as an HttpResponse subclasses

On Fri, Apr 7, 2017 at 9:54 AM, Adam Johnson wrote: > Personally I'd be in favour of adding such classes. It seems against the > batteries-included philosophy that Django does not provide all of the > standard codes as classes. I can never remember which codes correspond to > which

Looking for feedback on implementation of UserManager.with_perm()

https://github.com/django/django/pull/7153/ implements UserManager.with_perm() [1] as: def with_perm(self, perm): for backend in auth.get_backends(): if hasattr(backend, 'with_perm'): return backend.with_perm(perm) return self.get_queryset().none()

Re: Struggling newbie

On Wed, Aug 24, 2016 at 11:12 PM, wrote: > I am running python3.4 with Django in virtualenv. When I execute python > manage.py runserver I continue to get "sqlite3.NotSupportedError: URIs not > supported", I have looked all around for posts that will point me to the >

Re: UTF-8 name of a staticfiles test is breaking Django installation

On Tue, Aug 2, 2016 at 6:14 PM, Tim Graham wrote: > A similar report was https://code.djangoproject.com/ticket/24761. I'm not > sure if this is a bug in those install tools or if it's something we should > try to fix in Django. You can use `git blame >

Re: should we close in-memory file-like objects (StringIO, BytesIO, etc.)?

On Fri, Jul 3, 2015 at 4:59 PM, Tim Graham wrote: > Andriy proposed a patch to close objects like StringIO and BytesIO in our > test suite [1]. I am not sure how much benefit this gives (frees "a few > bytes of RAM" according to [2]) and it seems to add a lot of verbosity. >

Re: naming of a new test client method for logging in

On Tue, Jun 30, 2015 at 4:38 PM, Tim Graham wrote: > There's a proposal [1] to add a new method to the test client that works > like login(), but skips the authentication (no credentials need to be > provided) and verification (is_active=False can login) steps. The signature

Re: how to deal with inspect.getargspec() deprecation?

On Wed, Jun 10, 2015 at 9:49 PM, Tim Graham wrote: > inspect.getargspec() was deprecated in Python 3.0 and will be removed in 3.6 > (ETA late 2016). It started throwing a deprecation warning in Python 3.5 > which causes some test failures when we check the number of

Re: SSL support for Django-admin runserver‏

On Mon, May 11, 2015 at 4:34 PM, Tim Graham wrote: > Hi Steven, > > I'm in favor of trying to switch runserver to use gunicorn instead of > expanding the functionality of our own homegrown webserver > (https://code.djangoproject.com/ticket/21978). Windows support still

Fellow Report: Jan 18, 2015

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2015-01-12 Code reviews * https://github.com/django/django/pull/3908 -- Fixed #24145 -- Changed POST redirect error to be

Fellow Report: Jan 11, 2015

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2015-01-05 Pull requests = In progress = * https://github.com/django/django/pull/3467 -- Fixed #21429 -- Added

Fellow Report: Jan 4, 2015

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-30 Pull requests = Authored = * https://github.com/django/django/pull/3819 -- Ignored warnings correctly in

Fellow Report: Dec 28, 2014

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-21 Pull requests = Authored = * https://github.com/django/django/pull/3804 -- Converted middleware tests to

Fellow Report: Dec 21, 2014

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-14 Pull requests = Authored = * https://github.com/django/django/pull/3759 = In progress = *

Vendoring XRegexp

While I'm working on #3729 [1], I had to update current regexes to match unicode codepoints. Unfortunately, JavaScript has no proper support for unicode character classes, so writing unicode aware regex is a bit difficult: http://stackoverflow.com/a/280762 I would like to add XRegexp to

Fellow Report: Dec 14, 2014

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-07 Pull requests = Authored = * https://github.com/django/django/pull/3710 -- Fixed #23884 -- Moved

Fellow Report: Dec 7, 2014

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-12-01 Pull requests = Authored = * [Committed] https://github.com/django/django/pull/3671 -- Fixed "no such

Fellow Report: Nov 23, 2014

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-11-17 Pull requests - Authored ^ * [Committed] https://github.com/django/django/pull/3582 -- Fixed #12098

Fellow Report: Week 3

Hi all, Here is this week's report. You can see a more readable version of this report at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag#Weekof2014-11-10 Pull requests - Authored ^ * [Committed] https://github.com/django/django/pull/3495 -- Fixed

Fellow Report: Week 2

Hi all, Here is this week's report. I plan to finish #3461 (Gunicorn integration) and #3467 (logging support for management commands) in the next week: Pull requests - Authored * [Committed] https://github.com/django/django/pull/3460 -- Fixed versionchanged indentation in docs/

Fellow Report: Oct 27-31, 2014

Hi all, Here is a list of what I've worked on in the last week. You can see more detailed version of this report (including my rough TODO list) at https://code.djangoproject.com/wiki/DjangoFellows/BerkerPeksag. Authored * https://github.com/django/django/pull/3432 -- Used more specific asserts