Re: Enabling context access in simple_tag

2010-12-15 Thread Julien Phalip
On Dec 15, 10:52 pm, Russell Keith-Magee wrote: > On Wed, Dec 15, 2010 at 6:41 PM, Julien Phalip wrote: > > On Dec 14, 7:34 pm, Christian Hammond wrote: > >> On Dec 14, 12:02 am, Julien Phalip wrote: > > >> > On

Re: Enabling context access in simple_tag

2010-12-15 Thread Julien Phalip
On Dec 14, 7:34 pm, Christian Hammond wrote: > On Dec 14, 12:02 am, Julien Phalip wrote: > > > > On Dec 13, 10:16 am, Tai Lee wrote: > > > -snip- > > > > One suggestion from #1105 was to split out this functionality into > > >

Re: Enabling context access in simple_tag

2010-12-14 Thread Christian Hammond
On Dec 14, 12:02 am, Julien Phalip wrote: > On Dec 13, 10:16 am, Tai Lee wrote: > > -snip- > > > One suggestion from #1105 was to split out this functionality into > > individual decorators, @takes_context, @takes_block. I'm not sure how > > easy this

Re: Enabling context access in simple_tag

2010-12-14 Thread Julien Phalip
On Dec 13, 10:16 am, Tai Lee wrote: -snip- > One suggestion from #1105 was to split out this functionality into > individual decorators, @takes_context, @takes_block. I'm not sure how > easy this would be technically to implement, but I think it would > solve the

Re: Enabling context access in simple_tag

2010-12-12 Thread Russell Keith-Magee
On Sun, Dec 12, 2010 at 11:07 PM, Brian O'Connor wrote: >> As an example of what I'm talking about -- #14262 is a manifestation >> of a use case that is undeniably simple: "get_function() as var". This >> pattern is used in several places in Django's own codebase. > > >> >>  

Re: Enabling context access in simple_tag

2010-12-12 Thread Tai Lee
I've been using the patch from #1105 in my local branch of Django for a long time now. To be honest, I've hit the need to have access to the existing context in a simple_tag far more frequently than the need to return a single value as a named variable in the context, and I'm definitely +1 on

Re: Enabling context access in simple_tag

2010-12-12 Thread Brian O'Connor
> > As an example of what I'm talking about -- #14262 is a manifestation > of a use case that is undeniably simple: "get_function() as var". This > pattern is used in several places in Django's own codebase. To that end, I'm willing to be practical and concede that adding takes_context >

Re: Enabling context access in simple_tag

2010-12-12 Thread Russell Keith-Magee
On Sat, Dec 11, 2010 at 5:29 PM, Julien Phalip wrote: > Hello, > > I'd like to bring up an itch that I've been desperate to scratch since > my very early days with Django: the inability to access the context > from a simple_tag. > > There are especially two use cases which I

Enabling context access in simple_tag

2010-12-11 Thread Julien Phalip
ince 1.3's focus is on scratching all those annoying little itches). In summary, what do you think about enabling context access in simple_tag (using the takes_context syntax)? If the response is positive, I'm very keen to lead the way and promptly write a patch for it. A side question is: would this mak