Re: PR 9583 - Ticket 28643

2018-01-18 Thread Adam Johnson
+1 for adding Left/Right as plain functions right now. Simon's example for a new future is really nice but outside the scope of the ticket. On 18 January 2018 at 22:30, Josh Smeaton wrote: > I think having Left/Right is the right way to go. If there are > opportunities to use slicing syntax, th

Re: PR 9583 - Ticket 28643

2018-01-18 Thread Josh Smeaton
I think having Left/Right is the right way to go. If there are opportunities to use slicing syntax, then they would resolve internally to those Expressions I would think. But that can be done separately, and have greater scope such as ArrayField in Simons example. On Friday, 19 January 2018 08:

Re: PR 9583 - Ticket 28643

2018-01-18 Thread charettes
Hey Matthew, I could see adding support for F('field')[0:5] being useful and more intuitive than using Left/Right/Substr. You should be able to assert the field is sliceable (e.g. an instance of CharField/TextField) in the expression returned by F.__getitem__ (e.g. Left/Right/Substr) resolve_exp

PR 9583 - Ticket 28643

2018-01-18 Thread Matthew Pava
Hi everyone, I've been working on ticket 28643 specifically adding Ord, Chr, Left, and Right to Django's built-in database functions. I've done the PR #9583. I am a new contributor, and I've never really contributed code to any project through pull requests ever before. I appreciate your guid