Re: request for API review of streaming responses additions

Hi, sorry for the delay, On Monday, 7 September 2015 16:05:35 UTC+2, Aymeric Augustin wrote: > > Hello, > > 2015-09-07 10:00 GMT+02:00 Yann Fouillat > : > >> First I will say that most of this pull request is a port of >> https://github.com/django/django/pull/1037 which I

Re: request for API review of streaming responses additions

On Monday, 7 September 2015 15:05:35 UTC+1, Aymeric Augustin wrote: > 2015-09-07 10:00 GMT+02:00 Yann Fouillat > : > >> First I will say that most of this pull request is a port of >> https://github.com/django/django/pull/1037 which I ported more or less >> blindly. >> > >

Re: request for API review of streaming responses additions

On Mon, Sep 7, 2015 at 3:04 PM, Aymeric Augustin wrote: > 2015-09-07 10:00 GMT+02:00 Yann Fouillat : >> I agree, do you know what tools could I use to emulate 3G ? > > As far as I know, the canonical tools are: > > - on Linux, netem: >

Re: request for API review of streaming responses additions

Hello, 2015-09-07 10:00 GMT+02:00 Yann Fouillat : > First I will say that most of this pull request is a port of > https://github.com/django/django/pull/1037 which I ported more or less > blindly. > As far as I can tell, this previous PR was never discussed on

Re: request for API review of streaming responses additions

Hello and thanks for the review, First I will say that most of this pull request is a port of https://github.com/django/django/pull/1037 which I ported more or less blindly. On Sunday, 23 August 2015 19:18:20 UTC+2, Aymeric Augustin wrote: > > > 1) About the general API design > > This patch

Re: request for API review of streaming responses additions

Hello and thanks for the review, On Monday, 24 August 2015 15:25:11 UTC+2, Tom Christie wrote: > > Potential there to treat these as separately reviewable pull requests. > > For example - needing streaming template generation doesn't *necessarily* > imply needing streaming responses. The

Re: request for API review of streaming responses additions

Potential there to treat these as separately reviewable pull requests. For example - needing streaming template generation doesn't *necessarily* imply needing streaming responses. The node-by-node rendering might mean imply that less memory is used during the template rendering, even if the

Re: request for API review of streaming responses additions

Hello, I have three main comments on this patch. 1) About the general API design This patch adds 7 new “stream” public APIs that duplicate the current “render” APIs. Adding a stream=False argument to the current APIs would be a more lightweight alternative. Passing stream=True would enable the

request for API review of streaming responses additions

I'd like to ask for a high-level API review of some proposed streaming API additions (I have already given the patch a couple of detailed reviews, but other eyes would be welcome on the details as well). Summary: * django.views.generic.base.StreamingTemplateView to stream a template rather