Re: More user friendly delete confirmation template

2022-08-17 Thread Carlton Gibson
Sounds good. (You mentioned adding an additional template block. You could put that in a commit to look at as well if you think it's of value to you.) On Wed, 17 Aug 2022 at 08:14, Jacob Rief wrote: > On Wednesday, August 17, 2022 at 7:23:35 AM UTC+2 Carlton Gibson wrote: > >> > Can we at

Re: More user friendly delete confirmation template

2022-08-17 Thread Jacob Rief
On Wednesday, August 17, 2022 at 7:23:35 AM UTC+2 Carlton Gibson wrote: > > Can we at least agree to put an id="..." onto the element wrapping > that list. > > That seems pretty minimal.  Do you want to open a PR so we can have a > look? > Okay, will do that. Any suggestions for a name? My

Re: More user friendly delete confirmation template

2022-08-16 Thread Carlton Gibson
> Can we at least agree to put an id="..." onto the element wrapping that list. That seems pretty minimal.  Do you want to open a PR so we can have a look? On Tue, 16 Aug 2022 at 21:58, Jacob Rief wrote: > Can we at least agree to put an id="..." onto the element wrapping > that list. >

Re: More user friendly delete confirmation template

2022-08-16 Thread Jacob Rief
Can we at least agree to put an id="..." onto the element wrapping that list. That would help me to add some JS and CSS to the overwritten delete_selected_confirmation template without having to copy a huge block of HTML code from that template. – Jacob -- You received this message because

Re: More user friendly delete confirmation template

2022-08-16 Thread אורי
אורי u...@speedy.net On Tue, Aug 16, 2022 at 3:55 PM 'Adam Johnson' via Django developers (Contributions to Django itself) wrote: > Collapsing the list of to-be-deleted objects could also lead to cases of > accidental removal of related objects. I think it's better to err on the > side of

Re: More user friendly delete confirmation template

2022-08-16 Thread Jacob Rief
The least intrusive change would be to add an id="..." to the -element wrapping that list. This at least allows me to add such a Javascript snippet into {% block extrahead %}. – Jacob -- You received this message because you are subscribed to the Google Groups "Django developers

Re: More user friendly delete confirmation template

2022-08-16 Thread Jacob Rief
On Tuesday, August 16, 2022 at 4:23:03 PM UTC+2 Carlton Gibson wrote: > > Then as Maxim points out, this is already possible with overriding the > template. > > That's what I did of course in the first place. It however turns out that you have to copy quite a bunch of boilerplate code, the

Re: More user friendly delete confirmation template

2022-08-16 Thread Carlton Gibson
;> >> >> *From:* 'Adam Johnson' via Django developers (Contributions to Django >> itself) [mailto:django-developers@googlegroups.com] >> *Sent:* Tuesday, August 16, 2022 2:55 PM >> *To:* Django developers (Contributions to Django itself) < >> django-develope

Re: More user friendly delete confirmation template

2022-08-16 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
Adam Johnson' via Django developers (Contributions to Django > itself) [mailto:django-developers@googlegroups.com] > *Sent:* Tuesday, August 16, 2022 2:55 PM > *To:* Django developers (Contributions to Django itself) < > django-developers@googlegroups.com> > *Subject:* Re: More user friendl

RE: More user friendly delete confirmation template

2022-08-16 Thread Danilov Maxim
rom: 'Adam Johnson' via Django developers (Contributions to Django itself) [mailto:django-developers@googlegroups.com] Sent: Tuesday, August 16, 2022 2:55 PM To: Django developers (Contributions to Django itself) Subject: Re: More user friendly delete confirmation template If the object to be d

Re: More user friendly delete confirmation template

2022-08-16 Thread 'Adam Johnson' via Django developers (Contributions to Django itself)
> > If the object to be deleted contains many relations, the user > is overwhelmed with a list of other objects to be deleted together with the > current object. Often those objects are just internal relations the user > never heard of, and this may be unsettling. > I would argue that if the list

RE: More user friendly delete confirmation template

2022-08-16 Thread Danilov Maxim
Hi Jacob. On the one side - you can override this delete_confirmation.html and delete_selected_confirmation.html I do it since dj 1.4 On the other side I am agree with Jacob - it can be in Django by default. – We can add “collapsed” div to wrap with every objects list, or we can add