Re: PEP 484 type hinting in Django

2019-10-08 Thread Carlton Gibson
Maxim Kurnikov has begun a draft DEP for adding hints into Django. https://github.com/django/deps/pull/65 Please contribute your thoughts there. Kind Regards, Carlton -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django

Re: PEP 484 type hinting in Django

2019-09-14 Thread Maxim Kurnikov
I actually used MonkeyType to generate first version of `django-stubs` back in the day. Best regards, Maxim Kurnikov. On Thu, Sep 12, 2019 at 11:25 PM Lukas Meier wrote: > I'm writing here with the risk of you guys obviously already knowing about > it > > there is a project called monkeytype w

Re: PEP 484 type hinting in Django

2019-09-12 Thread Lukas Meier
I'm writing here with the risk of you guys obviously already knowing about it there is a project called monkeytype written by instagram that does analysis similar to what @Maxim said they actually have specific answers to django related questions here https://monkeytype.readthedocs.io/en/stabl

Re: PEP 484 type hinting in Django

2019-08-26 Thread Carlton Gibson
On Monday, 26 August 2019 14:05:19 UTC+2, Maxim Kurnikov wrote: > > Carlton, is it possible to move discussion to Github somehow? > Drafting a DEP begins by making a PR against the drafts folder in the DEPs repo. I guess that could be a WIP PR, if felt beneficial/necessary. -- You received thi

Re: PEP 484 type hinting in Django

2019-08-26 Thread Maxim Kurnikov
Hi, I'm the original creator of https://github.com/typeddjango/django-stubs. I guess it's my duty to start writing a DEP, so here is some preliminary thoughts/questions to gather early feedback: Main discussion points: 1. There's two ways to make Django compatible with type hinting and PEP484:

Re: PEP 484 type hinting in Django

2018-12-26 Thread Andreas Galazis
Just stumbled on this blog post: https://www.willmcgugan.com/blog/tech/post/adding-type-hints-to-the-django-orm/. An interesting but too theoretical suggestion: We could even get rid of field/ field configuration. But I guess that's far ahead of what we are trying to achieve xD. On Wednesday,

Re: PEP 484 type hinting in Django

2018-12-12 Thread Carlton Gibson
Hi all. Where are we with this Type Hinting work? I just closed https://code.djangoproject.com/ticket/30019 as needsinfo pointing back to this thread. As far as I can see: * There's keenness for this. * There's a number of people who are prepared to put in the effort. * But we just ne

Re: PEP 484 type hinting in Django

2018-12-02 Thread Maxim Kurnikov
I'm working on stubs / mypy plugin for Django here https://github.com/mkurnikov/django-stubs I'm going to release an alpha version sometime around New Year's. I've integrated machinalis version of stubs. There's also generated stubs from Monkeytype execution over the django testsuite in the repos

Re: PEP 484 type hinting in Django

2018-11-27 Thread 李海珍
Wow, time fly. I had taken part in the promotion activity 2 years ago. while haven't seen any progress on this topic. Is there on any progress on this topic? 在 2016年8月17日星期三 UTC+8下午12:08:48,Alex Hill写道: > > Hi all, > > I like the plan to include PEP 484 type hinting in Django, outlined in the > P

Re: PEP 484 type hinting in Django

2018-04-11 Thread Andreas Galazis
I agree with you, but at some point, we could combine solid annotated core with a cut off for non annotated code? Otherwise, this will end up being a loop. On Wednesday, 11 April 2018 17:16:21 UTC+3, dmoisset wrote: > > > > On 11 April 2018 at 11:21, Andreas Galazis > wrote: > >> To me one appr

Re: PEP 484 type hinting in Django

2018-04-11 Thread Daniel Moisset
On 11 April 2018 at 11:21, Andreas Galazis wrote: > To me one approach would be to put a cut off for any merged code /PR > start inlining type hints/annotations for all new code. This seems to > simple to be a solution but at the end of the day as code gets updated even > bigger part of the codeb

Re: PEP 484 type hinting in Django

2018-04-11 Thread Andreas Galazis
To me one approach would be to put a cut off for any merged code /PR start inlining type hints/annotations for all new code. This seems to simple to be a solution but at the end of the day as code gets updated even bigger part of the codebase will have type hints. The question is whether parti

Re: PEP 484 type hinting in Django

2018-04-10 Thread Daniel Moisset
A long due update on this, given that the question popped up recently: I worked at some time in type annotations and published some for Django 1.10 ; I'm currently not working on them, given that my current work has not been very close to Django development After trying a few things, the best way

Re: PEP 484 type hinting in Django

2018-04-06 Thread Florian Apolloner
To the best of my knowledge JetBrains fundled the money to Django for that specific purpose -- so yes the funding should be here if needed. That said, there is no decission on a) whether we actually want type hints and b) if the should be inline or stubs. Those two points have to be cleared firs

Re: PEP 484 type hinting in Django

2018-04-06 Thread Eddy C
Hi Tim, do you know if JetBrains still willing to fund the project as the upcoming django 2.1 will only support python 3.5+ that pave the way for inline annotations. On Wednesday, August 17, 2016 at 11:41:03 PM UTC+10, Tim Graham wrote: > > The JetBrains announcement that they want to fund the p

Re: PEP 484 type hinting in Django

2016-10-06 Thread Daniel Moisset
Just a small update on this; I've published a first usable (well, I hope) version at https://github.com/machinalis/mypy-django/ . It's stubs only, although I'm basing it on an annotated django fork at https://github.com/ dmoisset/django/tree/typing . I covered some high-visibility APIs only (reques

Re: PEP 484 type hinting in Django

2016-09-20 Thread Daniel Moisset
Hey Graham. mypy has a structure to support multiple python versions as you noticed (and allows it to select them from the command line), but there's no mechanism for selecting library version. For me, supporting "the latest stable version" is a reasonable goal now. Flagging that appriopriately may

Re: PEP 484 type hinting in Django

2016-09-18 Thread Graham Wideman
Just making note of the typeshed project https://github.com/python/typeshed, "Typeshed models function types for the Python standard library and Python builtins, as well as third party packages." Pertaining to my earlier question about how pyi files should tell what version of a library they p

Re: PEP 484 type hinting in Django

2016-09-05 Thread Graham Wideman
Hi Daniel, thanks for replying. My question was less about what version of django you were targeting, and more about how a type-hints library such as this should be annotated to indicate what version(s) it targets. Since a type hints library may well be distributed separately from the code th

Re: PEP 484 type hinting in Django

2016-09-05 Thread Daniel Moisset
Hi Graham, thanks for the support. I'm aiming at Django 1.10 right now, but given that APIs are more stable than implementation, you may have some success with other versions. This is just a guess, I haven't tried Best, D. On Sat, Aug 27, 2016 at 7:29 AM, Graham Wideman wrote: > First -- t

Re: PEP 484 type hinting in Django

2016-08-27 Thread Graham Wideman
First -- three thumbs up for Daniel's initiative and advocacy! Count me in as a random enthusiastic would-be user. Question: I've looked at Daniels repo and the pyi files therein, and one issue is ascertaining which version of Django they apply to. Are there some ideas about how that's to be d

Re: PEP 484 type hinting in Django

2016-08-22 Thread Daniel Moisset
Hi, On Sat, Aug 20, 2016 at 6:44 AM, Josh Smeaton wrote: > Agree. January is not that far out, and then you get to build the > annotations as designed in the PEP. You can begin work earlier of course, > but keeping your patch up to date with all of the work going on may become > annoying. The Ht

Re: PEP 484 type hinting in Django

2016-08-19 Thread Josh Smeaton
Agree. January is not that far out, and then you get to build the annotations as designed in the PEP. You can begin work earlier of course, but keeping your patch up to date with all of the work going on may become annoying. The HttpRequest/Response objects don't really get changed that often s

Re: PEP 484 type hinting in Django

2016-08-17 Thread ludovic coues
Dropping support for python 2.7 has been planned for some time. Django 1.11 will be the last one supporting python 2. The following release will be django 2 and will only support django 3.5+. See https://docs.djangoproject.com/en/dev/releases/1.11/ That's what Tim was talking about. You can target

Re: PEP 484 type hinting in Django

2016-08-17 Thread Daniel Moisset
Thanks for the replies, As I mentioned, I have already started implementation (and I'm willing to go through with it, having even some time from my work allocated to do it); I wasn't aware of the JetBrains plan (it's a nice plus, but I don't depend on it), and I'll probably do it as external files

Re: PEP 484 type hinting in Django

2016-08-17 Thread Tim Graham
The JetBrains announcement that they want to fund the project isn't a guarantee that it'll be implemented. The feature needs to go through the normal feature acceptance process, which as Markus said, might involve a DEP. Assuming the idea is accepted, my sense on timing would be to wait until

Re: PEP 484 type hinting in Django

2016-08-17 Thread Florian Apolloner
On Wednesday, August 17, 2016 at 11:06:47 AM UTC+2, dmoisset wrote: > > @Florian > Would you care to ellaborate? I couldn't find the post you mention > (although requests is one of the few 3rd party projects that have support > at the official typeshed repository, https://github.com/python/type

Re: PEP 484 type hinting in Django

2016-08-17 Thread Daniel Moisset
Hi @Alex, I wasn't aware of the fellowship program, but I've been getting started to work at this and I already have some minimal things up I have a repo with type hints (currently just covering the HttpRequest object and other minor stuff) at https://github.com/machinalis/mypy-django ; I'm curr

Re: PEP 484 type hinting in Django

2016-08-17 Thread Florian Apolloner
I personally do not think that this is something belonging into Django itself -- at least not in the current state. The requests (I think) maintainers have a good blog post iirc on the current issues. On Wednesday, August 17, 2016 at 6:08:48 AM UTC+2, Alex Hill wrote: > > Hi all, > > I like the

Re: PEP 484 type hinting in Django

2016-08-16 Thread Markus Holtermann
Hi Alex, I haven't heard of any discussion on that topic. I'd certainly like to have a DEP before we start implementing it, though. Cheers, Markus On Wed, Aug 17, 2016 at 04:08:29AM +, Alexander Hill wrote: Hi all, I like the plan to include PEP 484 type hinting in Django, outlined in th