I created a ticket and a pull request to add sqlparse as a required
dependency.
https://code.djangoproject.com/ticket/29934
https://github.com/django/django/pull/10622
On Saturday, November 3, 2018 at 4:47:30 PM UTC-4, charettes wrote:
>
> > So you want to add it to Django's install_requires
If you can see a way to improve those docs submit a PR
On Sun, 4 Nov 2018 at 01:51, Dan Davis wrote:
> I just joined as a contributor, but I've shipped an appliance install
> running using rpms, anaconda (the other one), and pungi. Depending on
> sqlparse doesn't seem to me a big deal. It
I just joined as a contributor, but I've shipped an appliance install
running using rpms, anaconda (the other one), and pungi. Depending on
sqlparse doesn't seem to me a big deal. It already gets invoked for me
during migrations. I cannot recall what caused it to be installed. One
thing we
> So you want to add it to Django's install_requires even though it won't
be necessary if SQLite isn't used?
That's my understanding and what I was advocating for.
Simon
Le samedi 3 novembre 2018 10:09:55 UTC-4, Tim Graham a écrit :
>
> So you want to add it to Django's install_requires even
So you want to add it to Django's install_requires even though it won't be
necessary if SQLite isn't used? It seems okay to me. It's an extra 40k or
so of disk space but that's not much compared to all the extra stuff Django
comes with that every Django project doesn't necessarily use. We also
I'm fine with adding it as a dependency, my experience has been that it's a
stable, well-maintained package over the past few years I've used it.
On Sun, 28 Oct 2018 at 05:00, charettes wrote:
> After a bit of work to minimize the cases where sqlparse would be a
> required at runtime for SQLite
After a bit of work to minimize the cases where sqlparse would be a
required at runtime for SQLite to AddConstraint/RemoveConstraint operations
[0] I came to the conclusion that it would make more sense to make sqlparse
an hard dependency of Django 2.2.
The two reasons backing this conclusions
sqlparse is already installed as part of Django's tests. The question is
whether sqlparse should be mandatory for SQLite users (i.e. when getting
started with a new project an error message will say, "You must install
sqlparse to use SQLite" (I don't think there's a way to install it
Adding sqlparse into the introspection code for SQLite specifically means
it's going to be a runtime dependency for anything to do with migrations.
I'm alright having that be the case, but I do think we should make sure the
tests run with SQLite as otherwise a large section of the most
