Re: Vendoring Select2

2017-12-17 Thread Mithlesh Kumar
Thanks a lot, Dylan !. Mithlesh K On Sunday, December 17, 2017 at 8:41:06 AM UTC+5:30, Dylan Reinhold wrote: > > Mithlesh, > The django project web sites has a page about how to contribute : > https://code.djangoproject.com/#Gettinginvolved > > > On Sat, Dec 16, 2017 at 5:35 PM, Mithlesh Kumar

Re: Vendoring Select2

2017-12-16 Thread Dylan Reinhold
Mithlesh, The django project web sites has a page about how to contribute : https://code.djangoproject.com/#Gettinginvolved On Sat, Dec 16, 2017 at 5:35 PM, Mithlesh Kumar < mithlesh.kumar.4...@gmail.com> wrote: > Hi, > > I'm very new to Open Source. I like to contribute to `Django`. How can I

Re: Vendoring Select2

2017-12-16 Thread Mithlesh Kumar
Hi, I'm very new to Open Source. I like to contribute to `Django`. How can I do so ? Thanks Mithlesh K -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop

Re: Vendoring Select2

2017-12-16 Thread Jamesie Pic
Note that jquery-autocomplete could be a backup solution in case select2 looses maintainer traction in the future. ​ https://www.devbridge.com/sourcery/components/jquery-autocomplete/ Best <3 -- You received this message because you are subscribed to the Google Groups "Django developers

Re: Vendoring Select2

2017-06-21 Thread Johannes Hoppe
Hi there,I worked on a fix for form media today. No it will keep the order and we can include our own scripts before calling noConflict.This way we don't have to wrapp all vendored JS libraries.Furthermore it makes the order of your assets more reliable than before and throws a warning if there

Re: Vendoring Select2

2017-06-18 Thread Jamesie Pic
Awesome, hope this will help drag in maintainer activity on select2 <3 Best -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email

Re: Vendoring Select2

2017-06-15 Thread Johannes Hoppe
Hello again!After some consideration, I am against dropping noConflict and will not rely on it in my pull request. I also found a work around. For that workaround to work I will need to fix a bug in django.forms first. I will do that in a separate PR.I hope I can get all this done before the 2.0

Re: Vendoring Select2

2017-06-14 Thread Tim Graham
To learn about some history of noConflict, I'd use this Google search: jquery noConflict site:code.djangoproject.com The first two results are some tickets with discussion: https://code.djangoproject.com/ticket/12882 - jQuery.noConflict() in admin breaks site specific code with jQuery

Re: Vendoring Select2

2017-06-06 Thread Jamesie Pic
I was just thinking that changing the js widget would not require to rewrite the python code, barely the js widget support. I'm not trying to push it, just make sure we are taking the right facts into consideration, but I'm happy with select2 myself. -- You received this message because you are

Re: Vendoring Select2

2017-06-06 Thread Florian Apolloner
On Tuesday, June 6, 2017 at 11:54:16 AM UTC+2, Johannes Hoppe wrote: > > I think we made some good progress in the regarding this issue. The > inclusion of select2 is at a stage where I wouldn't want to jump to a > different library. Especially considering that now one acted at this ticket >

Re: Vendoring Select2

2017-06-06 Thread Jamesie Pic
Thanks for asking, my name is ∞, but you've known my as James Pic / YourLabs. Nice to speak with you again <3 I think it would make sense for a core dev to advocate against this change, because we'd be breaking BC before having enough information to know if this is going to have a generally more

Re: Vendoring Select2

2017-06-06 Thread Johannes Hoppe
Hi! I didn't get your name, but this address the latest post. I think we made some good progress in the regarding this issue. The inclusion of select2 is at a stage where I wouldn't want to jump to a different library. Especially considering that now one acted at this ticket for seven years

Re: Vendoring Select2

2017-06-06 Thread is_null
Hi all, In our experience, it would be worth removing noConflict, but we need Django to have a recent jQuery release, it's wasn't always the case but now it's good. I don't know who relies on that except grappeli, but they would probably be happy to get rid of their double jquery loading

Re: Vendoring Select2

2016-04-25 Thread Sven R. Kunze
Hi Johannes, Am Sonntag, 24. April 2016 10:16:53 UTC+2 schrieb Johannes Hoppe: > > Hi Sven, > > you are right. For this particular case select2 would be an ill advice. > But I didn't initially add support for m2m fields. I just added it later to > my pull-requested, since it was only one line

Re: Vendoring Select2

2016-04-24 Thread Johannes Hoppe
Hi Sven, you are right. For this particular case select2 would be an ill advice. But I didn't initially add support for m2m fields. I just added it later to my pull-requested, since it was only one line of code. And some people would have found a usecase for It. At the end this will be an

Re: Vendoring Select2

2016-04-23 Thread Sven R. Kunze
Hi, I hope I am not too late to the discussion (and I hope it's the right one). :) Am Mittwoch, 6. April 2016 15:42:58 UTC+2 schrieb Collin Anderson: - Why select2? I haven't heard any serious proposals of a different library to use. Internally, we had the same debate of upgrading our widgets

Re: Vendoring Select2

2016-04-06 Thread Johannes Hoppe
I understand that. Select2 used to be horrible before the version 4 release. Selectize was on the table, but dropped because it doesn't allow configuration via `data`-attriburtes. We wanted to keep the JS party as minial as possible. Select2 does a good job since version 4, you can configure

Re: Vendoring Select2

2016-04-06 Thread Andrew Ingram
In previous projects (before moving to rolling my own UI components), I ended up favouring Selectize (http://selectize.github.io/selectize.js/) after getting fed up with Chosen and Select2 - but this was a few years ago and I can't remember my reasons. But if it hasn't been considered, it might be

Re: Vendoring Select2

2016-04-06 Thread Marc Tamlyn
Agreed. I recently was trying to use a fitler horizontal widget on my phone and thought the whole thing was broken because `` looks so wrong. I'd love to see this experience improved, and select2 is a good reliable solution. On 6 April 2016 at 15:11, Aymeric Augustin <

Re: Vendoring Select2

2016-04-06 Thread Aymeric Augustin
I’m OK with this. It's a reasonable solution. -- Aymeric. > On 06 Apr 2016, at 15:25, Johannes Hoppe wrote: > > Hi, > > as promised I started working on an autocomplete field for > `django.contrib.admin` as a more convenient alternative to `row_id_fields`. > > We

Re: Vendoring Select2

2016-04-06 Thread Collin Anderson
Hi All, I'm in favor of this change. This has the potential to replace the raw_id_fields and filter_horizontal which I think would be a huge win. Those widgets are out-dated not only in terms of code, but also from a UI point of view. I'll try to give my answers to some questions before they