Re: [Dnsmasq-discuss] Logging of NXDOMAIN without SOA

2018-12-15 Thread Geert Stappers
On Sat, Dec 15, 2018 at 04:37:06PM +0100, Dominik DL6ER wrote:
> Dear all,
> 
> I observe that dnsmasq does not log the result of a query that was
> replied to with NXDOMAIN when the response does not include an SOA
> record. To my understanding, this is because, without an SOA record, no
> TTL is available and the logging event when adding a domain to the
> internal cache in not triggered.
> 
> Steps to reproduce:
> 
>1. Configure dnsmasq to use the server 9.9.9.9
>2. Query www.isitblocked.org
>3. Observe that the following is logged (extra logging format):
> 
> Dec 15 16:11:32 dnsmasq[14851]: 1853 192.168.3.3/58098 query[A] 
> www.isitblocked.org from 192.168.3.3
> Dec 15 16:11:32 dnsmasq[14851]: 1853 192.168.3.3/58098 forwarded 
> www.isitblocked.org to 9.9.9.9
> 
> As you see, the reply (NXDOMAIN) is missing although the response is
> correctly sent to the requesting client.
> 

|$ host www.isitblocked.org
|www.isitblocked.org has address 74.208.236.124
|www.isitblocked.org has IPv6 address 2607:f1c0:100f:f000::2d1
|stappers@paddy:~
|$ host www.isitblocked.org 9.9.9.9
|Using domain server:
|Name: 9.9.9.9
|Address: 9.9.9.9#53
|Aliases: 
|
|Host www.isitblocked.org not found: 3(NXDOMAIN)
|$ host -t soa www.isitblocked.org
|www.isitblocked.org has no SOA record
|$ host -t soa www.isitblocked.org 9.9.9.9
|Using domain server:
|Name: 9.9.9.9
|Address: 9.9.9.9#53
|Aliases: 
|
|Host www.isitblocked.org not found: 3(NXDOMAIN)
|$ 



Groeten
Geert Stappers
-- 
Leven en laten leven

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss


[Dnsmasq-discuss] Logging of NXDOMAIN without SOA

2018-12-15 Thread Dominik DL6ER
Dear all,

I observe that dnsmasq does not log the result of a query that was
replied to with NXDOMAIN when the response does not include an SOA
record. To my understanding, this is because, without an SOA record, no
TTL is available and the logging event when adding a domain to the
internal cache in not triggered.

Steps to reproduce:

   1. Configure dnsmasq to use the server 9.9.9.9
   2. Query www.isitblocked.org
   3. Observe that the following is logged (extra logging format):

Dec 15 16:11:32 dnsmasq[14851]: 1853 192.168.3.3/58098 query[A] 
www.isitblocked.org from 192.168.3.3
Dec 15 16:11:32 dnsmasq[14851]: 1853 192.168.3.3/58098 forwarded 
www.isitblocked.org to 9.9.9.9

As you see, the reply (NXDOMAIN) is missing although the response is
correctly sent to the requesting client.

Best regards,
Dominik


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss


Re: [Dnsmasq-discuss] [PATCH] Re: dhcp-boot & dhcp-reply-delay optional tag fixes

2018-12-15 Thread Kevin Darbyshire-Bryant


> On 14 Dec 2018, at 16:10, Petr Mensik  wrote:
> 
> Hi Kevin et al,
> 
> sure, your fix is correct one. I just found one more place where tags
> were required. Your pointer handling is not as hopeless as you are
> saying. :)

He he - It’s always good to get a second opinion though :-)  And you spotted 
another place I missed as well.

> 
> Sorry for inconvenience caused by my change. I miss some tests that
> would discover it, have to write them someday soon.
> 
> Petr

It seems the openwrt users have a very wide range of use cases and notice stuff 
;-)

Your more complete fix is in openwrt master - thank you.



Cheers,

Kevin D-B

012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss