Re: [Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Matthias Andree]

Am 13.10.19 um 00:34 schrieb Simon Kelley:
> The patch in the buzilla entry looks good to me. The dnsmasq code is
> wrong and has been for some time. The version-dependent failure is
> probably down to the order in which the data is added to the control
> array, or the relative size of the two datastructures changing.
>
> http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=936bd82755e8f75fc09c1e9a67fb390175b157d4
>
> should fix things. PLs test.

Simon,

I played around with a FreeBSD 11.3-RELEASE jail for amd64.

I could reproduce the original bug as reported,
and can confirm that the patch fixes TFTP service for me.

The FreeBSD port has been updated in the head and quarterly branches,
and package 2.80_4 should fix things.
Thank you.

Regards,
Matthias


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Simon Kelley]

On 05/10/2019 09:44, Matthias Andree wrote:
> Am 05.10.19 um 09:54 schrieb Geert Stappers:
>> Questions:
>> Which version of Dnsmasq did work?  ( git bi-sect  known good)
>> Which version of Dnsmasq doesn't work?  ( git bi-sect  known bad)
>>
>> In case it is stated in
>>> 
>>> 
>> have the curitisy to state it here also ...
> 
> FreeBSD have been shipping 2.80 for a long time (since before
> 2019-07-01), if there's a mismatch in the source code and what they
> quote in the Forums, it'll be easy to spot.
> The thing is not that dnsmasq changed, but that FreeBSD changed and it
> appears that some interface fiddling makes assumptions that were true in
> 11.2 but no longer hold in FreeBSD >= 11.3.
> 
> 


The patch in the buzilla entry looks good to me. The dnsmasq code is
wrong and has been for some time. The version-dependent failure is
probably down to the order in which the data is added to the control
array, or the relative size of the two datastructures changing.

http://thekelleys.org.uk/gitweb/?p=dnsmasq.git;a=commit;h=936bd82755e8f75fc09c1e9a67fb390175b157d4

should fix things. PLs test.


Cheers,

Simon.


> ___
> Dnsmasq-discuss mailing list
> Dnsmasq-discuss@lists.thekelleys.org.uk
> http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss
> 


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Matthias Andree]

Am 05.10.19 um 09:54 schrieb Geert Stappers:
> Questions:
> Which version of Dnsmasq did work?  ( git bi-sect  known good)
> Which version of Dnsmasq doesn't work?  ( git bi-sect  known bad)
>
> In case it is stated in
>> 
>> 
> have the curitisy to state it here also ...

FreeBSD have been shipping 2.80 for a long time (since before
2019-07-01), if there's a mismatch in the source code and what they
quote in the Forums, it'll be easy to spot.
The thing is not that dnsmasq changed, but that FreeBSD changed and it
appears that some interface fiddling makes assumptions that were true in
11.2 but no longer hold in FreeBSD >= 11.3.


___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

Re: [Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Geert Stappers]

On Sat, Oct 05, 2019 at 09:00:25AM +0200, Matthias Andree wrote:
> Greetings,
> 
> I have received a bug report where TFTP regresses on newer FreeBSD
> versions and breaks on 11.3 and 12.0 with IPv4 where older FreeBSD
> releases (that are now weeks before EOL) work,
> with some kind of analysis, here:
> 
> 
> 
> 
> Please investigate.
> I don't currently have time to look deeper and/or debug.

Me too.


> It appears that IPv6 works but something about interface enumeration is
> broken with IPv4 and the relevant interface isn't found.
> Might have to do with sizing of structures.
> 
> I can't currently look deeper,
> but should be able to answer questions or try patches tomorrow.

Questions:
Which version of Dnsmasq did work?  ( git bi-sect  known good)
Which version of Dnsmasq doesn't work?  ( git bi-sect  known bad)

In case it is stated in
> 
> 
have the curitisy to state it here also ...


> It seems the minimal reproducer forward would be to install FreeBSD 11.3
> in a VM and test locally with a TFTP client pulling from 127.0.0.1 to
> force IPv4 and ::1 to force IPv6.


Groeten
Geert Stappers
-- 
Leven en laten leven

___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss

[Dnsmasq-discuss] FreeBSD TFTP issue (failure to serve via IPv4) reported against 11.3/12.x

[Matthias Andree]

Greetings,

I have received a bug report where TFTP regresses on newer FreeBSD
versions and breaks on 11.3 and 12.0 with IPv4 where older FreeBSD
releases (that are now weeks before EOL) work,
with some kind of analysis, here:




Please investigate. I don't currently have time to look deeper and/or
debug.
It appears that IPv6 works but something about interface enumeration is
broken with IPv4 and the relevant interface isn't found.
Might have to do with sizing of structures.

I can't currently look deeper, but should be able to answer questions or
try patches tomorrow.
It seems the minimal reproducer forward would be to install FreeBSD 11.3
in a VM and test locally with a TFTP client pulling from 127.0.0.1 to
force IPv4 and ::1 to force IPv6.

Regards,
Matthias



___
Dnsmasq-discuss mailing list
Dnsmasq-discuss@lists.thekelleys.org.uk
http://lists.thekelleys.org.uk/mailman/listinfo/dnsmasq-discuss