Re: [DPP-Devel] FW: What happend to ISarosContext?

, Matthias [1]http://saros-build.imp.fu-berlin.de/gerrit/#/c/3125/4 [2]http://saros-build.imp.fu-berlin.de/gerrit/#/c/3033/ 2017-02-28 10:11 GMT+01:00 Zieris, Franz <franz.zie...@fu-berlin.de>: > (Matthias forgot to hit reply-all.) > > > > *From:* Matthias Bohnstedt [mail

[DPP-Devel] What happend to ISarosContext?

Hi all, I am currently try to finish a long untouched patch[1]. Feel free to have a look at the commit message for more infos. The patch used the ISarosContext that isn't present anymore. The context that was injected as dependency. Please correct me if I am wrong: I figured that there where

Re: [DPP-Devel] IntelliJProjectImpl

Just a quick addition: I would also not worry to much about the HTLM GUI. The (very few) parts that are using IProject or IWorkspace(Root) might actually become easier to use if we would only talk in folder, files and resources. Matthias Ursprüngliche Nachricht Von: "Zieris,

Re: [DPP-Devel] Saros-Eclipse-Gerrit-QA misconfiguration?

Sorry, It's about the SAROS-INTELIJ-GERRIT-QA, not the eclipse one.(c error) Ursprüngliche Nachricht Von: Matthias Bohnstedt <matthias.bohnst...@gmail.com> Datum: 16.09.2016 15:53 (GMT+01:00) An: dpp-devel@lists.sourceforge.net Betreff: Saros-Eclipse-Ger

Re: [DPP-Devel] Eclipse crashes when editing SarosContext.java

ike a JVM crash, could you please post the according error > log (hs_err_pid.log). > > > > Franz > > > > *From:* Matthias Bohnstedt [mailto:matthias.bohnst...@gmail.com] > *Sent:* Thursday, September 15, 2016 10:05 AM > *To:* dpp-devel@lists.sourceforge.net >

Re: [DPP-Devel] Build server migration

Just want to throw a big thanks for your effort to you Franz. I just pushed a new patch to gerrit, it worked the first try and it took only 3 seconds!! (And not half of a minute like it was previously) Awesome :) Best Matthias 2016-08-15 18:29 GMT+02:00 Zieris, Franz

[DPP-Devel] "Submitted, Merge Pending": Actions required? (Gerrit/Jenkins)

Hi all, I tried to submit a few small patches (after positive reviews). I noticed that the status changed to "Submitted, Merge Pending". I never saw this during my Saros time and I don't know what cause it. My question is: Do I (we) have to take any action in order to make this "merge"

Re: [DPP-Devel] Feedback for possible candidates of knowledge base

Hi Dennis, I tried to give some short feedback to a few Reviews I was involved. Feel free to contact my if you have any question there. >From the top of my head common problems are: - Git (Usage, setup, merging, rebase, etc.) - Understanding the life-circle of certain classes and the way

[DPP-Devel] HTML GUI - Error in current master? (Eclipse)

Hi all, I just started the HTML GUI with the newest master version:"[HTML][API] Introduce type-safe browser functions [Commit e22da8a]". While the plugin starts fine, the SarosViewBrowserVersion shows the following error: 'Could not create the view: Plug-in "de.fu_berlin.inf.dpp" was unable to

Re: [DPP-Devel] UI: BrowserManager

/de/fu_berlin/inf/dpp/ui/ide_embedding/BrowserCreator.java 2016-04-08 14:28 GMT+02:00 Matthias Bohnstedt <matthias.bohnst...@gmail.com> : > > > 2016-04-07 19:09 GMT+02:00 Zieris, Franz <franz.zie...@fu-berlin.de>: > >> Hi there, >> >> I started think

Re: [DPP-Devel] UI and Json

Answer below 2016-03-24 19:29 GMT+01:00 Zieris, Franz : > Hi there, > ... > > (2) The second problem still bugs me: Upon deserialization (from JSON back > to > Java objects), GSON naturally needs to create instances for the > non-primitive > fields of the

[DPP-Devel] Fwd: Talkin about design decisions in the HTML UI

Sorry for the spam, but Björn pointed out that I misused a term in my mail (thanks again!). To avoid confusion let me set the record straight: The browserfunctions are *not* bound, but *bind* to the pages right now. Best Matthias -- Forwarded message -- From: Matthias Bohnstedt

Re: [DPP-Devel] Talkin about design decisions in the HTML UI

A downside came up to my mind just after I hit the send button: There might be a performance issue if we add ~40 (just a approximation) Javascirptfunctions to a browser. But I guess this is something we can only find out by trying. 2016-02-24 10:56 GMT+01:00 Matthias Bohnstedt <matthias.boh

[DPP-Devel] Talkin about design decisions in the HTML UI

Hi all, I have an interesting discussion with stefan, about some design decisions in the HTML UI that came in a recent patch[1]. And I would like to bring it up to this discus list. So feel free to join. Besides some pico mysteries, and the general discussion what should be manged by pico, there

Re: [DPP-Devel] What is saros-build2?

I can't wait for it :) ! Today I spent like 20 Minutes trying to push changes to gerrit. I get usually 4-6 timeouts in a row (each taking about 30 secs) before it finally works... Not much fun at all :-/. 2016-02-18 20:11 GMT+01:00 Arsenij E Solovjev : > Seriously, wow @

Re: [DPP-Devel] [HTML] Bug in account view

or.de] > *Sent:* Wednesday, February 17, 2016 7:04 PM > *To:* Matthias Bohnstedt <matthias.bohnst...@gmail.com>; > dpp-devel@lists.sourceforge.net > *Subject:* Re: [DPP-Devel] [HTML] Bug in account view > > > > The account file is switched when running Saros in debug

[DPP-Devel] [HTML] Bug in account view

Hi all, since the HTML UI finally works again on my machine, I started to do some testing to figure out the current state of the development. I notice that the drop down besides "disconnect" don't show me the available accounts, but something different. I don't know where this string comes from,

Re: [DPP-Devel] Jenkins build is still unstable: Saros-Eclipse-STF-Nightly #1639

Hi all, EditWithReadAccessOnlyTest: "Timed out waiting for tree item matching [\Qfoo\E(\Q (shared)\E|\Q (partial share)\E)?+, \Qsrc\E, \Qbar\E, \QHelloWorld.java\E]" Is this the 'usual' false positives or is there really a Problem? Best Matthias 2016-01-25 6:28 GMT+01:00

Re: [DPP-Devel] HTML GUI: Status Quo

15:20 GMT+01:00 Matthias Bohnstedt <matthias.bohnst...@gmail.com> : > I will do this tomorrow, while I am not sure what Stefan means by saying > "Just implement it". If I could "just" implement it, I wouldn't provide a > empty placeholder method on int

Re: [DPP-Devel] HTML GUI: Status Quo

I will do this tomorrow, while I am not sure what Stefan means by saying "Just implement it". If I could "just" implement it, I wouldn't provide a empty placeholder method on intellIJ side. (His quote is referring to the method "getProjects()"). Holger was fine with this solution, until we are

Re: [DPP-Devel] HTML GUI: Status Quo

Hi Franz, I will answer in detail tomorrow, but regarding the error in IntelliJ: As Christian rightful mentioned, the UI crash is caused by a missing IWorkspaceRoot implementaion. There is already a fix: http://saros-build.imp.fu-erlin.de/gerrit/#/c/2981/. I need to include the feedback of Stefan

Re: [DPP-Devel] HTML-GUI: "npm install" works, "npm run build" doesn't

My Settings: Win 10 Powershell npm: '2.10.1', http_parser: '2.3', modules: '14', node: '0.12.4', openssl: '1.0.1m', uv: '1.5.0', v8: '3.28.71.19', zlib: '1.2.8' 2016-01-19 14:25 GMT+01:00 Matthias Bohnstedt <matthias.bohnst...@gmail.com> : > Hi all, > > A

Re: [DPP-Devel] Activating the HTML GUI

Hi Nina, I assume you use Eclipse and you working on the current master version of Saros. After you perform the descripted steps to enable the HTML GUI , there is no obvious difference after you enable the second alternative HTML view (Means it won't show up by itself after startting). If you

Re: [DPP-Devel] ISessionListener projectAdded()/projectRemoved()?

Sorry, was to early in the morning ^^. I misread the Code - the naming of the methods in the interface are fine, don't bother. Best Matthias 2015-08-28 9:12 GMT+02:00 Matthias Bohnstedt matthias.bohnst...@gmail.com: Hi Denis, first of all I really appreciate you efforts to move

Re: [DPP-Devel] ISessionListener projectAdded()/projectRemoved()?

Hi Denis, first of all I really appreciate you efforts to move the SarosSession to the core, as this (besides the Negotiations) are still a bottleneck in the current HTML-UI development. Regarding you proposals, this sounds reasonable to me. I don't know if Stefan just informed you about the

Re: [DPP-Devel] Coding Conventions == Practice

I personalty thought this was more or less finished (as the use of the code-conventions are indeed interesting ;-) but instead of silently agreeing to your suggestion Denis - I vote to keep the @blocking and @nonblocking tags in our conventions and get rid of all others. I personally think, that

Re: [DPP-Devel] HTML UI Plugin performance issues !

with the scrolling see: http://1drv.ms/1L3fRan 2015-07-13 23:31 GMT+02:00 Matthias Bohnstedt matthias.bohnst...@gmail.com : Answers below 2015-07-13 21:00 GMT+02:00 Zieris, Franz franz.zie...@fu-berlin.de: I would report my experience if only I had some. I tried to enable the HTML GUI [1

Re: [DPP-Devel] Gerrit clean-up

Well I admit, my advice was really bad formulated. This was certainly not what I meant. My fault was, that I just assumed she would work on the master branch (like most times) but this was obviously not the case( 440 missing patches should have have alarmed me that this patch is different) So my

[DPP-Devel] Setup JUnit tests in UI project

Hello Sarosianer, As the common HTML UI project is growing I want to write some tests for the it. This are not UI test (as there is no user action, or network needed), but just JUnit test. What I try to do is getting a ProjectListManager instance for my test. This manager needs an IWorkspaceRoot

[DPP-Devel] Help for using CollaborationUtils in HTML UI

Hi Sarosianer, I currently try to implement a IDE independent SessionInvitation, and right now I use an ISarosSessionManager for that.(I am not sure that this works the way it's intended so feel free to review :) [1] Stefan give me the advice to use CollaborationUtils class[2], which already

Re: [DPP-Devel] Add IDE specific tag for commit messages

Hi Franz, thanks for the reminder, this was on my TODO for far to long, but I finally did it :) https://www.saros-project.org/coderules#before_committing It would be nice when some one could have a look if this is fine and understandable. Best Matthias 2015-06-24 15:10 GMT+02:00 Zieris, Franz

[DPP-Devel] Build failure in saros master

Hi Sarosianer, I just checkout the current master, did a little refactor (renaming 2 classes) pushed it, and I get a build failure and -1 from Jenkins. This happened with all of my recent patches(like ~ a week or so). Does anyone know about the this build failure in Saros? I don't think this is

[DPP-Devel] Deprive the magic of PicoContainer

Hello Sarosianer, after month of searching, going thought thousands of thousands of documentation and preying to the only real god of coding I finally revealed the secret about the magic inside our PicoContainer. I was able to take a photo of a PicoContainer in his natural habitat, and I am

Re: [DPP-Devel] JavaScript development workflow

Hi Basti, thanks for the detailed explanation about possible js build solutions. This is tough to answer right away. I personally would go with solution #2, since it's the most efficient workflow in my humble opinion. Every other solution you described sounds like it would lead to a diffuse

[DPP-Devel] [HTML UI] Accountlist and default Account does not load, if the Saros HTML view is already open on Eclipse startup.

Hi Sarosianer, I currently work on the HTML UI and I found a bug where I am not sure if this only occurring on my PC: 1. Start Saros with enabled HTML UI View Hint:In order to do so: Changes in saros.properties line 41: saros.swtbrowser = true and remove the comment symbols in

Re: [DPP-Devel] Gerrit authentication, OpenID

Ya GitHub :) And big thx for the work. 2015-04-21 21:00 GMT+02:00 Holger Schmeisky holge...@fu-berlin.de: Yay github! Nice job! On 21. April 2015 20:44:50 MESZ, Bastian Sieker bsie...@mail.uni-paderborn.de wrote: yay GitHub! In other respects: sounds like quite a struggle, so, nice

Re: [DPP-Devel] Gerrit authentication, OpenID

Hi Franz, I saw it 5 times, I made a Screenshot and then never wrote the Mail...^^. And well I thought if I saw it, other would know this too. Sorry for the laziness. Greetings MatthiasVon: Zieris, Franz Gesendet: ‎15.‎04.‎2015 19:01 An: dpp-devel@lists.sourceforge.net Betreff: [DPP-Devel]

Re: [DPP-Devel] Add IDE specific tag for commit messages

Oh well I didn't saw this on my phone... in this case nevermind ^^ BR Matthias -- Von: Zieris, Franz franz.zie...@fu-berlin.de Gesendet: ‎04.‎03.‎2015 16:26 An: Matthias Bohnstedt matthias.bohnst...@gmail.com Cc: dpp-devel@lists.sourceforge.net Betreff: RE: [DPP-Devel

[DPP-Devel] Add IDE specific tag for commit messages

Hello all, in my last reviews and commits I find that the current [TAG]s as described on the project page [1] are not satisfying our needs anymore. Some commits only effect one IDE and not both (or maybe later more) and we get commit headlines headers like: [NOP] IntelliJ [Internal]

Re: [DPP-Devel] Use SWT in Saros-I?

I did some quick research and found an good post on stackoverflow from 2010. In order to provide SWT for our application on different Plattforms we indeed need to include all the different SWT jars in our product. The good news is: There are not so many (win32/64, linux32/64 and osx32/64) and, as

Re: [DPP-Devel] Saros-E/I: maximize joint code by HTML-based GUI

Thank you very much for the clarification and the advice, this helps me a lot. And soory for writting german in the mailinglist, I just hit the “all reply” button and didn’t look twice. My bad. Greetings Matthias Bohnstedt 2014-09-01 10:09 GMT+02:00 Lutz Prechelt prech...@inf.fu-berlin.de

Re: [DPP-Devel] Saros-E/I: Gemeinsamkeiten maximieren

oder Einstiegspunkt dankbar. Grüße Matthias Bohnstedt Am 28. August 2014 15:49 schrieb Kahlert, Björn bjoern.kahl...@fu-berlin.de : *siehe unten* On 28.08.2014, at 13:23, Stefan Rossbach srossb...@arcor.de wrote: Das ganze Technik hat auch einen Namen: http://de.wikipedia.org/wiki