[DPP-Devel] ProjectNegotiationObservable not observable

2015-04-14 Thread Denis Washington
there is another name that would be more fitting? Regards, Denis Washington -- BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT Develop your own process in accordance with the BPMN 2 standard Learn Process

[DPP-Devel] Notion of project "ownership" obsolete?

2015-04-28 Thread Denis Washington
Hi, As you might know, I am currently working on implementing project sharing by non-hosts. It currently works like this: - Bob (a non-host) initiates a project negotiation with Alice (the host). If Alice accepts it, the negotiation proceeds as normal. - After having received the project, Alic

[DPP-Devel] IProgressMonitor#internalWorked

2015-07-24 Thread Denis Washington
Hi, I am trying to move RemoteProgressManager and friends to the core (it's a dependency of IPN for the SVN progress reporting). As part of that work, I changed RemoteProgressMonitor to a Saros IProgressMonitor and wrapped it in a CoreToEclipeMonitorAdapter to pass it to Subclipse. After I did

[DPP-Devel] Coding Conventions <==> Practice

2015-08-14 Thread Denis Washington
Hi, Over time I have noticed several instances where things recommended in our Coding Conventions [1] are almost nowhere followed, or not followed at all (anymore). The ones I found are: * The conventions say that listeners should always reside in an "events" subpackage of the package they log

[DPP-Devel] Dependency injection in JUnit tests?

2015-08-19 Thread Denis Washington
Hi, I would like to inject the correct IPathFactory into ActivityQueuerTest so that it doesn't depend on Eclipse's Path class anymore. Is there an easy way to do this? I wasn't able to find a test class that does such a thing. Regards, Denis ---

Re: [DPP-Devel] Coding Conventions <==> Practice

2015-08-19 Thread Denis Washington
> Hi, > > thank you Denis for having a look at this! > > Like Stefan I would also rather adopt the guidelines to existing (good) > practice than the other way around. For none of the three points you > mention I would agree with the convention :-) > > Best Regards, > Holger Yes, this is also wha

Re: [DPP-Devel] Coding Conventions <==> Practice

2015-08-19 Thread Denis Washington
Lutz Prechelt wrote: > Dear Denis, > > great message, thank you very much! > > Indeed: Rules that are not being followed > are worse than no rules at all, because they > undermine the value of the remaining rules > (as the result in people getting used to > not following rules). > > What to do i

[DPP-Devel] What is a color ID?

2015-08-19 Thread Denis Washington
Hi, ChangeColorManager, ColorIDSet and others talk about "color ID's" all the time without actually defining what they are. So my question is: what is a color ID? An RGB value? A key that is mapped to a color somewhere? Regards, Denis --

Re: [DPP-Devel] Coding Conventions <==> Practice

2015-08-24 Thread Denis Washington
Denis Washington wrote: > Hi, > > Over time I have noticed several instances where things recommended in our > Coding Conventions [1] are almost nowhere followed, or not followed at all > (anymore). The ones I found are: This discussion has died out now, but do we still agree

[DPP-Devel] Page editing (was: Coding Conventions <==> Practice)

2015-08-24 Thread Denis Washington
> The other issue you currently mention (edits to the documentation / > webpage) was one of the major concerns. > Me and Holger pointed out that it would a good idea just to maintain the > developer documentation (see > http://saros-build.imp.fu-berlin.de/sarosGettingStarted/saros-getting- > starte

Re: [DPP-Devel] Page editing (was: Coding Conventions <==> Practice)

2015-08-24 Thread Denis Washington
Franz Zieris wrote: > Denis wrote: > > > For instance, there is http://jekyllrb.com > > I'm not sure how this plays together with our Drupal setup, but it does not > look like a completely absurd idea, e.g. [2]. Is there any particular reason why Drupal would be needed at all? Jekyll could tak

Re: [DPP-Devel] Coding Conventions <==> Practice

2015-08-26 Thread Denis Washington
en the opportunity to remove the two unfollowed rules we talked about (*Adapter as abstract listener class name, "events" subpackage) from the Coding Conventions page. I didn't change anything in the JavaDoc Tags section yet, though, because I don't think we came to a conclusion abou

[DPP-Devel] ISessionListener projectAdded()/projectRemoved()?

2015-08-26 Thread Denis Washington
Hi, After the move of ChangeColorManager to the core is merged, the only remaining non-core dependency of SarosSession will be SharedResourcesManager. This dependency seems to simply be a hack: SarosSession calls a projectAdded() method of SharedResourcesManager in addProjectMapping(), and projec

[DPP-Devel] IntelliJ 15 for OS X will come with JDK 8

2015-09-09 Thread Denis Washington
Hi, I looked at the changes in the upcoming version 15 of IntelliJ today and came across the following snippet [1]: "OS X users may notice that we don't offer the .dmg installer that requires Java 6 anymore. Now our .dmg installer comes with a patched JDK 8. It means two things: a) you don't n

Re: [DPP-Devel] IntelliJ 15 for OS X will come with JDK 8

2015-09-14 Thread Denis Washington
On 14.09.2015 20:26, Zieris, Franz wrote: > Hi Denis, > > What are the arguments against Java 8? There aren't really any. I mostly proposed Java 7 because it is the conservative choice: it would make the Eclipse plugin work everywhere where a recent Eclipse (>= 4.4) works. For the user, this mig

Re: [DPP-Devel] IntelliJ 15 for OS X will come with JDK 8

2015-09-15 Thread Denis Washington
On 15.09.2015 11:19, Zieris, Franz wrote: > So how about this plan: > - We wait until the segment of up-to-Eclipse-4.3 users drops below 5%. > - Then we evaluate whether we still need the SWTBot (it might be superseded > by the HTML GUI and its testing framework by then) > and if so, whe

Re: [DPP-Devel] IntelliJ 15 for OS X will come with JDK 8

2015-09-17 Thread Denis Washington
On 17.09.2015 11:37, Zieris, Franz wrote: > Sure, thanks, you're right. I forgot about that. > > Corrected plan proposal: > - We wait until the segment of up-to-Eclipse-4.3 users drops below 5%. > - Then we evaluate whether the SWTBot still works and make adjustments when > necessary. > - Th

[DPP-Devel] Server dependencies Ivy-only now

2015-10-31 Thread Denis Washington
Hi, In order to remove duplication, I have just merged a patch which changes the server project to declare all external dependencies only via Ivy [1] and not a second time in the Eclipse project. In order to avoid compilation errors when the server project is open, install the IvyDE plugin [2],

[DPP-Devel] Strange Sonarqube error

2015-11-04 Thread Denis Washington
Hi, I'm still trying to get Sonarqube to generate reports for the Saros Server. Everything seems to be (finally) configured correctly now. However, the Saros-Server-Gerrit-QA-Server job still fails with the following error right after the analysis [1]: ERROR: Caused by: Line must be null

Re: [DPP-Devel] Strange Sonarqube error

2015-11-04 Thread Denis Washington
. 2015-11-04 15:10 GMT+01:00 Denis Washington mailto:de...@denisw.de>>: Hi, I'm still trying to get Sonarqube to generate reports for the Saros Server. Everything seems to be (finally) configured correctly now. However, the Saros-Server-Gerrit-QA-Server job still fails with the

[DPP-Devel] Interesting build failure

2015-11-24 Thread Denis Washington
Hi, After merging a patch changing saros-ci-patches [1], I have a strange build failure on one of my patches [1]: + rsync /var/lib/jenkins/scripts/sonarqube-gerrit-bridge/gitClient/target/scala-2.10/gitclient_2.10-0.0.1-one-jar.jar gitclient.jar rsync: change_dir "/var/lib/jenkins/scr

Re: [DPP-Devel] Interesting build failure

2015-11-24 Thread Denis Washington
> Hi, Nevermind, it works again. Seems as if the CI-Deploy job wasn't done yet. Regards, Denis -- Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XD

[DPP-Devel] "git pull" returns "internal server error"

2015-12-01 Thread Denis Washington
Hi, I just tried to do a "git pull" of the Saros repository, but get the following error: remote: internal server error fatal: protocol error: bad pack header Am I the only one getting this error (I get it both under Ubuntu and Windows within the FU eduroam network)? I can access the o

Re: [DPP-Devel] Login to Gerrit still does not work properly

2016-08-28 Thread Denis Washington
Hi, I just wanted to finally continue with integrating the Saros server patches into master, only to find out that I cannot log into my old Gerrit account anymore (I used GitHub OAuth). Is there a way to somehow migrate this account to use Google OAuth? Otherwise, I don't own my patches anymore ..

[DPP-Devel] Gerrit uses legacy SSH key exchange method

2016-08-28 Thread Denis Washington
Hi, I just wanted to pull from the Saros repository with Git 2.7.4 (the version included with Ubuntu 16.04) and got this error: Fetching origin Unable to negotiate with 140.211.10.43: no matching key exchange method found. Their offer: diffie-hellman-group1-sha1 fatal: Could not r

Re: [DPP-Devel] Login to Gerrit still does not work properly

2016-08-30 Thread Denis Washington
in with your Google account, I was able to merge > your two accounts. > > You should now be your former self again :) > > > > Franz > > > > *From:* Denis Washington [mailto:de...@denisw.de] > *Sent:* Sunday, August 28, 2016 4:32 PM > *To:* Zieris, Franz ; >

Re: [DPP-Devel] SarosSession SmokeTest

2016-09-05 Thread Denis Washington
Hi, This would be the right place to mention where that smoke test is located and how to run it, so that someone can actually look into the problem. Otherwise, it'll happen again. Regards, Denis Stefan Rossbach schrieb am Di., 6. Sep. 2016 um 00:28: > Please be aware that we have such a test.