[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 10:29 PM, Peter Stuge wrote: > Justin P. Mattock wrote: >>> *baffled* Why did you think that would work? transmit_cmd()s signature >>> has 4 parameters. >> >> I have no manual in front of me. Did a quick google, but came up with >> (no hits) info on what that function does. grep

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Jean Delvare
Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: > could be a right solution, could be wrong > here is the warning: > CC drivers/i2c/i2c-core.o > drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': > drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy'

[PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote: > > > Em 14-06-2010 23:26, Justin P. Mattock escreveu: >> not sure if this is correct or not for >> fixing this warning: >>CC [M] drivers/media/common/tuners/tuner-simple.o >> drivers/media/common/tuners/tuner-simple.c: In function

[PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 10:16 PM, Mauro Carvalho Chehab wrote: > > > Em 14-06-2010 23:26, Justin P. Mattock escreveu: >> not sure if this is correct or not for >> fixing this warning: >>CC [M] drivers/media/common/tuners/tuner-simple.o >> drivers/media/common/tuners/tuner-simple.c: In function

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafał Miłecki
2010/6/14 Rafael J. Wysocki : > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 >> > after commit

[PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' set but not used

2010-06-14 Thread Gustavo F. Padovan
Hi Justin, * Justin P. Mattock [2010-06-14 13:26:42 -0700]: > Im getting this while building: > CC [M] drivers/bluetooth/hci_ldisc.o > drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_send_frame': > drivers/bluetooth/hci_ldisc.c:213:21: warning: variable 'tty' set but not used > > the

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafael J. Wysocki
On Monday, June 14, 2010, Alex Deucher wrote: > On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: > > Alex, Dave, > > > > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 > > after commit ce8f53709bf440100cb9d31b1303291551cf517f > > (drm/radeon/kms/pm: rework

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 08:49 PM, Valdis.Kletnieks at vt.edu wrote: > On Mon, 14 Jun 2010 19:12:31 PDT, "Justin P. Mattock" said: > >> what I tried was this: >> >> if (!rc) >> printk("test"\n") >> >> and everything looked good, >> but as a soon as I changed >> >> rc = transmit_cmd(chip,_cmd,

[PATCH ati] Add Gallium (radeong) support via an xorg.conf option, disabled by default.

2010-06-14 Thread Robert Hooker
The r300 gallium driver in mesa is built as radeong_dri.so and the DDX is hardcoded to use r300 as the DRI driver name for that generation. this patch allows radeong to be used if specified in an xorg.conf with this option: Option "Gallium" "True" This only affects DRI2 since the gallium driver

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread valdis.kletni...@vt.edu
e URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20100614/d540ea64/attachment-0001.pgp>

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 05:13 PM, Valdis.Kletnieks at vt.edu wrote: > On Mon, 14 Jun 2010 13:26:44 PDT, "Justin P. Mattock" said: >> Im getting this warning when compiling: >> CC drivers/char/tpm/tpm.o >> drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt': >> drivers/char/tpm/tpm.c:508:10:

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 04:07 PM, Stefan Richter wrote: > On 14 Jun, Justin P. Mattock wrote: >> On 06/14/2010 02:47 PM, Edward Shishkin wrote: >>> Whitespaces should be removed. >>> I recommend quilt package for managing patches: >>> "quilt refresh --strip-trailing-whitespace" is your friend.. >> >> o.k. I

[Bug 28341] Flickering screen in Neverball on drm-radeon-testing

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28341 --- Comment #7 from Andy Furniss 2010-06-14 16:56:56 PDT --- (In reply to comment #6) > possibly also related to bug 28383 and bug 28410. I am currently running with a patch that fixes 28383 but have just noticed that the mesa demo ipers does

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafael J. Wysocki
Alex, Dave, I'm afraid hibernation is broken on all machines using radeon/KMS with r300 after commit ce8f53709bf440100cb9d31b1303291551cf517f (drm/radeon/kms/pm: rework power management). At least, I'm able to reproduce the symptom, which is that the machine hangs hard around the point where an

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Nick Bowler
On 13:26 Mon 14 Jun , Justin P. Mattock wrote: > @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct > cpu_key *key, /* Key to s > > pathrelse(search_path); > > - right_neighbor_of_leaf_node = 0; > - > + This hunk introduces whitespace on the

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Alex Deucher
On Mon, Jun 14, 2010 at 3:03 PM, Rafael J. Wysocki wrote: > On Monday, June 14, 2010, Alex Deucher wrote: >> On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: >> > Alex, Dave, >> > >> > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 >> > after commit

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:47 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> On 06/14/2010 02:05 PM, Edward Shishkin wrote: >>> Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0

[Bug 28538] Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28538 --- Comment #2 from Brian Beardall 2010-06-14 14:54:15 PDT --- The computers are using UMS and so that wouldn't be the case. I could try KMS to see if the bug is exhibited there, but I wanted the kernels be the same. Do you want me to try KMS?

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread David Daney
On 06/14/2010 01:53 PM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: >> could be a right solution, could be wrong >> here is the warning: >>CC drivers/i2c/i2c-core.o >> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': >>

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:05 PM, Edward Shishkin wrote: > Justin P. Mattock wrote: >> Not sure if this is correct or not. >> the below patch gets rid of this warning message >> produced by gcc 4.6.0 >> >> fs/reiserfs/stree.c: In function 'search_by_key': >> fs/reiserfs/stree.c:602:6: warning: variable >>

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:48 PM, Nick Bowler wrote: > On 13:26 Mon 14 Jun , Justin P. Mattock wrote: >> @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct >> cpu_key *key, /* Key to s >> >> pathrelse(search_path); >> >> -right_neighbor_of_leaf_node = 0; >> - >> +

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:53 PM, Jean Delvare wrote: > Hi Justin, > > On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: >> could be a right solution, could be wrong >> here is the warning: >>CC drivers/i2c/i2c-core.o >> drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': >>

[PATCH 8/8]tuners:tuner-simple Fix warning: variable 'tun' set but not used

2010-06-14 Thread Justin P. Mattock
not sure if this is correct or not for fixing this warning: CC [M] drivers/media/common/tuners/tuner-simple.o drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq': drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used

[PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-14 Thread Justin P. Mattock
Temporary fix until something is resolved to fix the below warning: CC [M] drivers/ieee1394/sbp2.o drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory': drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used Signed-off-by: Justin P. Mattock ---

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used Signed-off-by: Justin P. Mattock --- drivers/i2c/i2c-core.c |

[PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' set but not used

2010-06-14 Thread Justin P. Mattock
Probably not even a fix for this warning: CC [M] drivers/gpu/drm/drm_gem.o drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete': drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used Signed-off-by: Justin P. Mattock --- drivers/gpu/drm/drm_gem.c |2 ++ 1

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
Im getting this warning when compiling: CC drivers/char/tpm/tpm.o drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt': drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used The below patch gets rid of the warning, but I'm not sure if it's the best solution.

[PATCH 3/8]char/hpet.c Fix variable 'hpet' set but not used

2010-06-14 Thread Justin P. Mattock
The below fixes this warning: drivers/char/hpet.c: In function 'hpet_ioctl_common': drivers/char/hpet.c:559:23: warning: variable 'hpet' set but not used please have a look. Signed-off-by: Justin P. Mattock --- drivers/char/hpet.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-)

[PATCH 2/8]bluetooth/hci_ldisc.c Fix warning: variable 'tty' set but not used

2010-06-14 Thread Justin P. Mattock
Im getting this while building: CC [M] drivers/bluetooth/hci_ldisc.o drivers/bluetooth/hci_ldisc.c: In function 'hci_uart_send_frame': drivers/bluetooth/hci_ldisc.c:213:21: warning: variable 'tty' set but not used the below fixed it for me, but am not sure if it's correct. Signed-off-by:

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used Signed-off-by: Justin P. Mattock ---

[PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages.

2010-06-14 Thread Justin P. Mattock
First and foremost, I must thank anybody taking the time to even look at these(I know you people have better things to be doing). And secondly here is my try at trying to fix some of the warning messages spammed by gcc 4.6.0 when building the kernel. Some of them I removed, and some of them I

[Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Alex Deucher
On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki wrote: > Alex, Dave, > > I'm afraid hibernation is broken on all machines using radeon/KMS with r300 > after commit ce8f53709bf440100cb9d31b1303291551cf517f > (drm/radeon/kms/pm: rework power management). ?At least, I'm able to reproduce > the

[Bug 28538] Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28538 --- Comment #1 from Alex Deucher 2010-06-14 10:52:26 PDT --- If you are using kms, this was fixed in: http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=cf22f20ade30f8c03955324aaf27b1049e182600 -- Configure bugmail:

[Bug 28538] New: Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28538 Summary: Mesa 7.8.1 for the RV250 or Radeon 9000 is broke Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal

[Bug 28530] New: [r300g] Sins of a Solar Empire crash with libtxc_dxtn.so

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28530 Summary: [r300g] Sins of a Solar Empire crash with libtxc_dxtn.so Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal

[Bug 25198] [R6XX] : System hard hangs on launching OpenGL application

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=25198 samit vats changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

[Bug 28522] power_profile auto consumes more power than power_profile high

2010-06-14 Thread bugzilla-dae...@freedesktop.org
https://bugs.freedesktop.org/show_bug.cgi?id=28522 Alex Deucher changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug 28522] power_profile auto consumes more power than power_profile high

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28522 Alex Deucher ag...@yahoo.com changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 28530] New: [r300g] Sins of a Solar Empire crash with libtxc_dxtn.so

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28530 Summary: [r300g] Sins of a Solar Empire crash with libtxc_dxtn.so Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW Severity: normal

Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Alex Deucher
On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki r...@sisk.pl wrote: Alex, Dave, I'm afraid hibernation is broken on all machines using radeon/KMS with r300 after commit ce8f53709bf440100cb9d31b1303291551cf517f (drm/radeon/kms/pm: rework power management).  At least, I'm able to reproduce

[Bug 28538] New: Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28538 Summary: Mesa 7.8.1 for the RV250 or Radeon 9000 is broke Product: Mesa Version: unspecified Platform: x86 (IA32) OS/Version: Linux (All) Status: NEW Severity: normal

[Bug 28538] Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28538 --- Comment #1 from Alex Deucher ag...@yahoo.com 2010-06-14 10:52:26 PDT --- If you are using kms, this was fixed in: http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=cf22f20ade30f8c03955324aaf27b1049e182600 --

Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafael J. Wysocki
On Monday, June 14, 2010, Alex Deucher wrote: On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki r...@sisk.pl wrote: Alex, Dave, I'm afraid hibernation is broken on all machines using radeon/KMS with r300 after commit ce8f53709bf440100cb9d31b1303291551cf517f (drm/radeon/kms/pm: rework

Re: [Regression, post-2.6.34] Hibernation broken on machines with radeon/KMS and r300

2010-06-14 Thread Rafał Miłecki
2010/6/14 Rafael J. Wysocki r...@sisk.pl: On Monday, June 14, 2010, Alex Deucher wrote: On Mon, Jun 14, 2010 at 10:53 AM, Rafael J. Wysocki r...@sisk.pl wrote: Alex, Dave, I'm afraid hibernation is broken on all machines using radeon/KMS with r300 after commit

[Bug 28538] Mesa 7.8.1 for the RV250 or Radeon 9000 is broke

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28538 --- Comment #2 from Brian Beardall br...@rapsure.net 2010-06-14 14:54:15 PDT --- The computers are using UMS and so that wouldn't be the case. I could try KMS to see if the bug is exhibited there, but I wanted the kernels be the same. Do you

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread David Daney
On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':

[PATCH 0/8] Fix gcc 4.6.0 set but not used warning messages.

2010-06-14 Thread Justin P. Mattock
First and foremost, I must thank anybody taking the time to even look at these(I know you people have better things to be doing). And secondly here is my try at trying to fix some of the warning messages spammed by gcc 4.6.0 when building the kernel. Some of them I removed, and some of them I

[PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used Signed-off-by: Justin P. Mattock

[PATCH 3/8]char/hpet.c Fix variable 'hpet' set but not used

2010-06-14 Thread Justin P. Mattock
The below fixes this warning: drivers/char/hpet.c: In function 'hpet_ioctl_common': drivers/char/hpet.c:559:23: warning: variable 'hpet' set but not used please have a look. Signed-off-by: Justin P. Mattock justinmatt...@gmail.com --- drivers/char/hpet.c |2 -- 1 files changed, 0

[PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
Im getting this warning when compiling: CC drivers/char/tpm/tpm.o drivers/char/tpm/tpm.c: In function 'tpm_gen_interrupt': drivers/char/tpm/tpm.c:508:10: warning: variable 'rc' set but not used The below patch gets rid of the warning, but I'm not sure if it's the best solution.

[PATCH 5/8]drm:drm_gem Fix warning: variable 'dev' set but not used

2010-06-14 Thread Justin P. Mattock
Probably not even a fix for this warning: CC [M] drivers/gpu/drm/drm_gem.o drivers/gpu/drm/drm_gem.c: In function 'drm_gem_handle_delete': drivers/gpu/drm/drm_gem.c:188:21: warning: variable 'dev' set but not used Signed-off-by: Justin P. Mattock justinmatt...@gmail.com ---

[PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but not used Signed-off-by: Justin P. Mattock justinmatt...@gmail.com ---

[PATCH 7/8]ieee1394/sdp2 Fix warning: variable 'unit_characteristics' set but not used

2010-06-14 Thread Justin P. Mattock
Temporary fix until something is resolved to fix the below warning: CC [M] drivers/ieee1394/sbp2.o drivers/ieee1394/sbp2.c: In function 'sbp2_parse_unit_directory': drivers/ieee1394/sbp2.c:1353:6: warning: variable 'unit_characteristics' set but not used Signed-off-by: Justin P. Mattock

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Jean Delvare
Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter': drivers/i2c/i2c-core.c:757:15: warning: variable 'dummy' set but

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Nick Bowler
On 13:26 Mon 14 Jun , Justin P. Mattock wrote: @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key, /* Key to s pathrelse(search_path); - right_neighbor_of_leaf_node = 0; - + This hunk introduces whitespace on the empty

Re: [PATCH 6/8]i2c:i2c_core Fix warning: variable 'dummy' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:53 PM, Jean Delvare wrote: Hi Justin, On Mon, 14 Jun 2010 13:26:46 -0700, Justin P. Mattock wrote: could be a right solution, could be wrong here is the warning: CC drivers/i2c/i2c-core.o drivers/i2c/i2c-core.c: In function 'i2c_register_adapter':

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Edward Shishkin
Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable 'right_neighbor_of_leaf_node' set but not used Signed-off-by:

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 01:48 PM, Nick Bowler wrote: On 13:26 Mon 14 Jun , Justin P. Mattock wrote: @@ -617,8 +616,7 @@ int search_by_key(struct super_block *sb, const struct cpu_key *key,/* Key to s pathrelse(search_path); - right_neighbor_of_leaf_node = 0; - + This

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning: variable

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Edward Shishkin
Justin P. Mattock wrote: On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function 'search_by_key': fs/reiserfs/stree.c:602:6: warning:

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 02:47 PM, Edward Shishkin wrote: Justin P. Mattock wrote: On 06/14/2010 02:05 PM, Edward Shishkin wrote: Justin P. Mattock wrote: Not sure if this is correct or not. the below patch gets rid of this warning message produced by gcc 4.6.0 fs/reiserfs/stree.c: In function

Re: [PATCH 1/8]reiserfs:stree.c Fix variable set but not used.

2010-06-14 Thread Stefan Richter
On 14 Jun, Justin P. Mattock wrote: On 06/14/2010 02:47 PM, Edward Shishkin wrote: Whitespaces should be removed. I recommend quilt package for managing patches: quilt refresh --strip-trailing-whitespace is your friend.. o.k. I resent this.. fixed the whitespace(hopefully) and add your

[Bug 28341] Flickering screen in Neverball on drm-radeon-testing

2010-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=28341 --- Comment #7 from Andy Furniss li...@andyfurniss.entadsl.com 2010-06-14 16:56:56 PDT --- (In reply to comment #6) possibly also related to bug 28383 and bug 28410. I am currently running with a patch that fixes 28383 but have just noticed

[PATCH ati] Add Gallium (radeong) support via an xorg.conf option, disabled by default.

2010-06-14 Thread Robert Hooker
The r300 gallium driver in mesa is built as radeong_dri.so and the DDX is hardcoded to use r300 as the DRI driver name for that generation. this patch allows radeong to be used if specified in an xorg.conf with this option: Option Gallium True This only affects DRI2 since the gallium driver

Re: [PATCH 4/8]drivers:tmp.c Fix warning: variable 'rc' set but not used

2010-06-14 Thread Justin P. Mattock
On 06/14/2010 10:29 PM, Peter Stuge wrote: Justin P. Mattock wrote: *baffled* Why did you think that would work? transmit_cmd()s signature has 4 parameters. I have no manual in front of me. Did a quick google, but came up with (no hits) info on what that function does. grep showed too many