[PATCH] drm/msm: Change nested function to static function

2014-08-29 Thread Rob Clark
On Fri, Aug 29, 2014 at 2:05 PM, Mark Charlebois wrote: > There is currently a nested function in Russel King's tree > for the msm HDMI driver. > > The last nested function was removed from the Linux kernel > when the Thinkpad driver was fixed. > > I believe nested functions are not desired

[Bug 82828] Regression: Crash in 3Dmark2001

2014-08-29 Thread bugzilla-dae...@freedesktop.org
e: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/6b8a7c8b/attachment.html>

[Bug 83461] New: hdmi screen flicker/unusable

2014-08-29 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=83461 Bug ID: 83461 Summary: hdmi screen flicker/unusable Product: Drivers Version: 2.5 Kernel Version: 3.15, 3.16 Hardware: x86-64 OS: Linux Tree: Mainline

[PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Fri, Aug 29, 2014 at 12:09:39PM -0300, Gustavo Padovan wrote: > 2014-08-29 Ville Syrj?l? : > > > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > > From: Gustavo Padovan > > > > > > Due to the upcoming atomic modesetting feature we need to separate > > > some update

[Bug 76761] radeon DPM breaks suspend to disk and resume from RAM in 3.14

2014-08-29 Thread bugzilla-dae...@bugzilla.kernel.org
https://bugzilla.kernel.org/show_bug.cgi?id=76761 StephenH changed: What|Removed |Added CC||hafflys at earthlink.net --- Comment #19 from

[Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Daniel Vetter
ineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/cf4451e0/attachment.html>

[Bug 82828] Regression: Crash in 3Dmark2001

2014-08-29 Thread bugzilla-dae...@freedesktop.org
because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/2e28ec53/attachment.html>

[PATCH] drm: add checking DRM_FORMAT_NV12MT

2014-08-29 Thread Joonyoung Shim
Hi Dave, On 07/29/2014 01:08 AM, Ville Syrj?l? wrote: > On Mon, Jul 28, 2014 at 11:56:59AM -0400, Rob Clark wrote: >> On Mon, Jul 28, 2014 at 12:47 AM, Joonyoung Shim >> wrote: >>> If user NV12MT uses as pixel format, the Addfb2 ioctl is failed because >>> of missing to check DRM_FORMAT_NV12MT.

[PATCH v2 17/17] drm/exynos/ipp: add file checks for ioctls

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: > Process should not have access to ipp nodes created by another > process. The patch adds necessary checks. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 15 ++- > 1 file changed, 10

[PATCH v2 16/17] drm/exynos/ipp: remove file argument from node related functions

2014-08-29 Thread Joonyoung Shim
Hi Andrzej, On 08/28/2014 06:07 PM, Andrzej Hajda wrote: > Since file pointer is preserved in c_node passing it > as argument in node functions is redundant. > > Signed-off-by: Andrzej Hajda > --- > drivers/gpu/drm/exynos/exynos_drm_ipp.c | 14 ++ > 1 file changed, 6 insertions(+),

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 03:03:58PM +0200, David Herrmann wrote: > Hi > > On Fri, Aug 29, 2014 at 2:53 PM, Daniel Vetter wrote: > > On Fri, Aug 29, 2014 at 02:01:00PM +0200, David Herrmann wrote: > >> There is no reason to use a heavy mutex for idr protection. Use a spinlock > >> and make

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 02:57:12PM +0200, David Herrmann wrote: > Hi > > On Fri, Aug 29, 2014 at 2:51 PM, Daniel Vetter wrote: > > On Fri, Aug 29, 2014 at 02:01:01PM +0200, David Herrmann wrote: > >> With MST, we now have connector hotplugging, yey! Pretty easy to use in > >> user-space, but

[PATCH 17/20] drm: add driver->set_busid() callback

2014-08-29 Thread Thierry Reding
.. Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/d8a5166b/attachment.sig>

[PATCH 09/20] drm: merge drm_memory.h into drm_memory.c

2014-08-29 Thread Thierry Reding
change and fixup any compile breakage once it's reported. > If there is any. I'm not objecting to this change since it's merely reorganizing code. This is just more possible future cleanup. Thierry -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/a8010f2d/attachment-0001.sig>

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread Thierry Reding
omehow applied "makes irq-safe" to the "idr_preload()" change without relating it to "lookup". Thierry -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/274ccdbf/attachment.sig>

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread David Herrmann
Hi On Fri, Aug 29, 2014 at 3:10 PM, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 02:01:00PM +0200, David Herrmann wrote: >> There is no reason to use a heavy mutex for idr protection. Use a spinlock >> and make idr-allocation use idr_preload(). >> >> This patch also makes mode-object lookup

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread David Herrmann
Hi On Fri, Aug 29, 2014 at 2:57 PM, David Herrmann wrote: > Hi > > On Fri, Aug 29, 2014 at 2:51 PM, Daniel Vetter wrote: >> On Fri, Aug 29, 2014 at 02:01:01PM +0200, David Herrmann wrote: >>> With MST, we now have connector hotplugging, yey! Pretty easy to use in >>> user-space, but introduces

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread Thierry Reding
Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/f47786d1/attachment.sig>

[PATCH 00/20] DRM: Core Cleanups

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:26PM +0200, David Herrmann wrote: > Hi > > More cleanups of DRM core code. Diffstat says: > 72 files changed, 832 insertions(+), 1038 deletions(-) > > ..which is already nice, but doesn't reflect that a lot of code is now hidden > from main headers. Furthermore,

[PATCH 19/20] drm: merge drm_usb into udl

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:45PM +0200, David Herrmann wrote: > This merges all the remains of drm_usb into its only user, udl. We can > then drop all the drm_usb stuff, including dev->usbdev. > > Signed-off-by: David Herrmann A bit of (seemingly) unecessary code movement (the

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread David Herrmann
Hi On Fri, Aug 29, 2014 at 2:53 PM, Daniel Vetter wrote: > On Fri, Aug 29, 2014 at 02:01:00PM +0200, David Herrmann wrote: >> There is no reason to use a heavy mutex for idr protection. Use a spinlock >> and make idr-allocation use idr_preload(). >> >> This patch also makes mode-object lookup

[PATCH 20/20] drm: move drm-lock API to drm_legacy.h

2014-08-29 Thread Thierry Reding
ment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/a3d2440d/attachment.sig>

[PATCH 18/20] drm: Goody bye, drm_bus!

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:44PM +0200, David Herrmann wrote: > ..we will not miss you.. > > Signed-off-by: David Herrmann Since this is independant of how we'll get rid of bus->set_busid: Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_ioctl.c| 8 +--- >

[PATCH 17/20] drm: add driver->set_busid() callback

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:43PM +0200, David Herrmann wrote: > One step closer to dropping all the drm_bus_* code: > Add a driver->set_busid() callback and make all drivers use the generic > helpers. Nouveau is the only driver that uses two different bus-types with > the same drm_driver. This

[PATCH 19/20] drm: merge drm_usb into udl

2014-08-29 Thread Thierry Reding
p-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/8960541a/attachment.sig>

[PATCH 16/20] drm: drop unused drm_master->unique_size

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:42PM +0200, David Herrmann wrote: > This field is unused and there is really no reason to optimize > unique-allocations. Drop it. > > Signed-off-by: David Herrmann Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_ioctl.c| 1 - >

[PATCH 15/20] drm: simplify drm_*_set_unique()

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 12:12:41PM +0200, David Herrmann wrote: > Lets use kasprintf() to avoid pre-allocating the buffer. This is really > nothing to optimize for speed and the input is trusted, so kasprintf() is > just fine. > > Signed-off-by: David Herrmann Reviewed-by: Daniel Vetter > ---

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread David Herrmann
Hi On Fri, Aug 29, 2014 at 2:51 PM, Daniel Vetter wrote: > On Fri, Aug 29, 2014 at 02:01:01PM +0200, David Herrmann wrote: >> With MST, we now have connector hotplugging, yey! Pretty easy to use in >> user-space, but introduces some nasty races: >> * If a connector is removed and added again

[PATCH 18/20] drm: Goody bye, drm_bus!

2014-08-29 Thread Thierry Reding
cation/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/01ab6fc1/attachment.sig>

[PATCH 17/20] drm: add driver->set_busid() callback

2014-08-29 Thread Thierry Reding
On Fri, Aug 29, 2014 at 12:12:43PM +0200, David Herrmann wrote: > One step closer to dropping all the drm_bus_* code: > Add a driver->set_busid() callback and make all drivers use the generic > helpers. Nouveau is the only driver that uses two different bus-types with > the same drm_driver. This

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 02:01:00PM +0200, David Herrmann wrote: > There is no reason to use a heavy mutex for idr protection. Use a spinlock > and make idr-allocation use idr_preload(). > > This patch also makes mode-object lookup irq-save, in case you ever wanna > lookup modeset objects from

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 02:01:01PM +0200, David Herrmann wrote: > With MST, we now have connector hotplugging, yey! Pretty easy to use in > user-space, but introduces some nasty races: > * If a connector is removed and added again while a compositor is in >background, it will get the same ID

[PATCH 10/20] drm: move __OS_HAS_AGP into drm_agpsupport.h

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 02:03:12PM +0200, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 12:12:36PM +0200, David Herrmann wrote: > > With drm_memory.h gone, there is no header left that uses __OS_HAS_AGP. > > Move it into drm_agpsupport.h (which is itself included from drmP.h) to > > hide it

[PATCH 09/20] drm: merge drm_memory.h into drm_memory.c

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 01:56:23PM +0200, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 12:12:35PM +0200, David Herrmann wrote: > > The drm_memory.h header is only used to define PAGE_AGP, which is only > > used in drm_memory.c. Fold the header into drm_memory.c and drop it. > > > >

[PATCH 16/20] drm: drop unused drm_master->unique_size

2014-08-29 Thread Thierry Reding
ding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/b3e1618a/attachment.sig>

[PATCH 15/20] drm: simplify drm_*_set_unique()

2014-08-29 Thread Thierry Reding
_size is weird. It seems to me like it should always be unique_len + 1. Why drm_platform_bus should be special escapes me. Also, after this patch it seems to be completely unused, so perhaps we should just drop it. All of those comments can either be addressed in a separate patch (or ignored), though, so: Reviewed-by: Thierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/a563d2d5/attachment-0001.sig>

[PATCH 06/20] drm: move AGP definitions harder

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 01:43:10PM +0200, Thierry Reding wrote: > On Fri, Aug 29, 2014 at 12:12:32PM +0200, David Herrmann wrote: > > Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. > > Unfortunately, drivers still heavily access drm_agp_head so we cannot > > move it to

[Intel-gfx] [PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Daniel Vetter
On Fri, Aug 29, 2014 at 10:55:41AM +0300, Ville Syrj?l? wrote: > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Due to the upcoming atomic modesetting feature we need to separate > > some update functions into a check step that can fail and a

[PATCH 14/20] drm: move remaining includes in drmP.h to the top

2014-08-29 Thread Thierry Reding
reedesktop.org/archives/dri-devel/attachments/20140829/2b3362cd/attachment.sig>

[PATCH 13/20] drm: inline "struct drm_sigdata"

2014-08-29 Thread Thierry Reding
e: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/46e5e666/attachment-0001.sig>

[PATCH 12/20] drm: drop DRM_DEBUG_CODE

2014-08-29 Thread Thierry Reding
s clearly never tested with DRM_DEBUG_CODE != 0. I don't see how it could've built given that the header protects the complete function whereas the implementation protects only part of the function. Reviewed-by: Thierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/af04788d/attachment.sig>

[PATCH 11/20] drm: order includes alphabetically in drmP.h

2014-08-29 Thread Thierry Reding
hierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/9456d988/attachment.sig>

[PATCH 10/20] drm: move __OS_HAS_AGP into drm_agpsupport.h

2014-08-29 Thread Thierry Reding
macro and use IS_ENABLED(CONFIG_AGP) directly. Thierry -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/2f70ce4f/attachment.sig>

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread David Herrmann
With MST, we now have connector hotplugging, yey! Pretty easy to use in user-space, but introduces some nasty races: * If a connector is removed and added again while a compositor is in background, it will get the same ID again. If the compositor wakes up, it cannot know whether its the

[PATCH 1/2] drm: make idr_mutex a spinlock

2014-08-29 Thread David Herrmann
There is no reason to use a heavy mutex for idr protection. Use a spinlock and make idr-allocation use idr_preload(). This patch also makes mode-object lookup irq-save, in case you ever wanna lookup modeset objects from interrupts. This is just a side-effect of avoiding a mutex. Signed-off-by:

[PATCH 09/20] drm: merge drm_memory.h into drm_memory.c

2014-08-29 Thread Thierry Reding
signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/e9eb97c8/attachment-0001.sig>

[PATCH 08/20] drm: drop __KERNEL__ protection in drmP.h

2014-08-29 Thread Thierry Reding
ed-by: Thierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/88255ec7/attachment.sig>

[PATCH 07/20] drm: replace weird conditional includes

2014-08-29 Thread Thierry Reding
re Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/0e760bd6/attachment.sig>

[PATCH 06/20] drm: move AGP definitions harder

2014-08-29 Thread Thierry Reding
ks good, so with a better subject this is: Reviewed-by: Thierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/eff4001f/attachment.sig>

[PATCH 05/20] drm: drop unused "struct drm_waitlist"

2014-08-29 Thread Thierry Reding
--- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/98304f92/attachment.sig>

[PATCH 04/20] drm: move "struct drm_magic_entry" to drm_auth.c

2014-08-29 Thread Thierry Reding
; 3 files changed, 6 insertions(+), 13 deletions(-) Reviewed-by: Thierry Reding -- next part -- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/0b579f98/attachment.sig>

[PATCH 03/20] drm: move "struct drm_vma_entry" to drm_vm.c

2014-08-29 Thread Thierry Reding
//lists.freedesktop.org/archives/dri-devel/attachments/20140829/0d982f27/attachment-0001.sig>

[PATCH 02/20] drm: mark drm_buf and drm_map as legacy

2014-08-29 Thread Thierry Reding
lable URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/ec4bff29/attachment.sig>

[PATCH 01/20] drm/radeon: move drm_buffer to drm/radeon/

2014-08-29 Thread Thierry Reding
ication/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/c1861ee1/attachment.sig>

[Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Jani Nikula
On Fri, 29 Aug 2014, Chris Wilson wrote: > On Fri, Aug 29, 2014 at 10:38:43AM +0300, Jani Nikula wrote: >> On Thu, 28 Aug 2014, Gustavo Padovan wrote: >> > From: Gustavo Padovan >> > >> > If the save_encoder_crtcs or save_connector_encoders allocation fail >> > we need to free everything we

[Bug 83234] Opening Steam crashes X session

2014-08-29 Thread bugzilla-dae...@freedesktop.org
: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/e681f085/attachment.html>

[PATCH 20/20] drm: move drm-lock API to drm_legacy.h

2014-08-29 Thread David Herrmann
Same as the other legacy APIs, most of this is internal, so prefix it with drm_legacy_* and move into drm_legacy.h. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_fops.c | 6 +++--- drivers/gpu/drm/drm_ioctl.c | 4 ++-- drivers/gpu/drm/drm_legacy.h| 9

[PATCH 19/20] drm: merge drm_usb into udl

2014-08-29 Thread David Herrmann
This merges all the remains of drm_usb into its only user, udl. We can then drop all the drm_usb stuff, including dev->usbdev. Signed-off-by: David Herrmann --- Documentation/DocBook/drm.tmpl | 3 +- drivers/gpu/drm/Kconfig | 6 --- drivers/gpu/drm/Makefile| 3

[PATCH 18/20] drm: Goody bye, drm_bus!

2014-08-29 Thread David Herrmann
..we will not miss you.. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_ioctl.c| 8 +--- drivers/gpu/drm/drm_pci.c | 6 -- drivers/gpu/drm/drm_platform.c | 5 - drivers/gpu/drm/drm_usb.c | 12 include/drm/drmP.h | 5 - 5 files

[PATCH 17/20] drm: add driver->set_busid() callback

2014-08-29 Thread David Herrmann
One step closer to dropping all the drm_bus_* code: Add a driver->set_busid() callback and make all drivers use the generic helpers. Nouveau is the only driver that uses two different bus-types with the same drm_driver. This is totally broken if both buses are available on the same machine

[PATCH 16/20] drm: drop unused drm_master->unique_size

2014-08-29 Thread David Herrmann
This field is unused and there is really no reason to optimize unique-allocations. Drop it. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_ioctl.c| 1 - drivers/gpu/drm/drm_pci.c | 4 +--- drivers/gpu/drm/drm_platform.c | 1 - include/drm/drmP.h | 2 -- 4 files

[PATCH 15/20] drm: simplify drm_*_set_unique()

2014-08-29 Thread David Herrmann
Lets use kasprintf() to avoid pre-allocating the buffer. This is really nothing to optimize for speed and the input is trusted, so kasprintf() is just fine. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_pci.c | 30 -- drivers/gpu/drm/drm_platform.c | 31

[PATCH 14/20] drm: move remaining includes in drmP.h to the top

2014-08-29 Thread David Herrmann
Including headers somewhere else but at the top is ugly, deprecated and was used in early days only to speed up compile-times. Those days are over. Make headers independent and then move the inclusions to the top. Signed-off-by: David Herrmann --- include/drm/drmP.h | 31

[PATCH 13/20] drm: inline "struct drm_sigdata"

2014-08-29 Thread David Herrmann
The sigdata structure is only used to group two fields in drm_device. Inline it and make it an unnamed object. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_lock.c | 15 --- include/drm/drmP.h | 12 +--- 2 files changed, 13 insertions(+), 14 deletions(-)

[PATCH 12/20] drm: drop DRM_DEBUG_CODE

2014-08-29 Thread David Herrmann
DRM_DEBUG_CODE is currently always set, so distributions enable it. The only reason to keep support in code is if developers wanted to disable debug support. Sounds unlikely. All the DRM_DEBUG() printks are still guarded by a drm_debug read. So if its cacheline is read once, they're discarded

[PATCH 11/20] drm: order includes alphabetically in drmP.h

2014-08-29 Thread David Herrmann
It is hardly possible to review the drmP.h includes, anymore. Order them alphabetically, linux/ first, then asm/ and then local drm/ includes. Since a long time ago, kernel headers have been converted to include required headers themselves. No-one cares whether that means the compiler has to

[PATCH 10/20] drm: move __OS_HAS_AGP into drm_agpsupport.h

2014-08-29 Thread David Herrmann
With drm_memory.h gone, there is no header left that uses __OS_HAS_AGP. Move it into drm_agpsupport.h (which is itself included from drmP.h) to hide it harder from public eyes. Signed-off-by: David Herrmann --- include/drm/drmP.h | 2 -- include/drm/drm_agpsupport.h | 3 +++ 2 files

[PATCH 09/20] drm: merge drm_memory.h into drm_memory.c

2014-08-29 Thread David Herrmann
The drm_memory.h header is only used to define PAGE_AGP, which is only used in drm_memory.c. Fold the header into drm_memory.c and drop it. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_memory.c | 11 + include/drm/drmP.h | 6 ++--- include/drm/drm_memory.h | 59

[PATCH 08/20] drm: drop __KERNEL__ protection in drmP.h

2014-08-29 Thread David Herrmann
drmP.h is internal to the kernel. No need to keep the __KERNEL__ protection. Signed-off-by: David Herrmann --- include/drm/drmP.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 31fb300..d3504c6 100644 --- a/include/drm/drmP.h +++

[PATCH 07/20] drm: replace weird conditional includes

2014-08-29 Thread David Herrmann
pte_wrprotect() is only used by drm_vm.c, so move the include there. Also include it unconditionally, all architectures provide this header! Furthermore, replace asm/current.h with sched.h, which includes asm/current.h unconditionally. This way we get the same effect and avoid direct asm/

[PATCH 06/20] drm: move AGP definitions harder

2014-08-29 Thread David Herrmann
Move drm_agp_head to drm_agpsupport.h and drm_agp_mem into drm_legacy.h. Unfortunately, drivers still heavily access drm_agp_head so we cannot move it to drm_legacy.h. However, at least it's no longer visible in drmP.h now (it's directly included from it, though). Signed-off-by: David Herrmann

[PATCH 05/20] drm: drop unused "struct drm_waitlist"

2014-08-29 Thread David Herrmann
This structure is unused, drop it. Signed-off-by: David Herrmann --- include/drm/drmP.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/include/drm/drmP.h b/include/drm/drmP.h index 0fdd813..0bf66f9 100644 --- a/include/drm/drmP.h +++ b/include/drm/drmP.h @@ -320,17 +320,6 @@

[PATCH 04/20] drm: move "struct drm_magic_entry" to drm_auth.c

2014-08-29 Thread David Herrmann
In drm_release(), we currently call drm_remove_magic() if the drm_file has a drm-magic attached. Therefore, once drm_master_release() is called, the magic-list _must_ be empty. By dropping the no-op cleanup, we can move "struct drm_magic_entry" to drm_auth.c and avoid exposing it to all of DRM.

[PATCH 03/20] drm: move "struct drm_vma_entry" to drm_vm.c

2014-08-29 Thread David Herrmann
Make all the drm_vma_entry handling local to drm_vm.c and hide it from global headers. This requires to extract the inlined legacy drm_vma_entry cleanup into a small helper and also move a weirdly placed drm_vma_info helper into drm_vm.c. Signed-off-by: David Herrmann ---

[PATCH 02/20] drm: mark drm_buf and drm_map as legacy

2014-08-29 Thread David Herrmann
Move internal declarations to drm_legacy.h and add drm_legacy_*() prefix to all legacy functions. Signed-off-by: David Herrmann --- drivers/gpu/drm/drm_bufs.c | 89 ++--- drivers/gpu/drm/drm_drv.c | 4 +- drivers/gpu/drm/drm_ioctl.c |

[PATCH 01/20] drm/radeon: move drm_buffer to drm/radeon/

2014-08-29 Thread David Herrmann
Radeon UMS is the last user of drm_buffer. Move it out of sight so radeon can drop it together with UMS. Signed-off-by: David Herrmann --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_buffer.c | 181 --

[PATCH 00/20] DRM: Core Cleanups

2014-08-29 Thread David Herrmann
Hi More cleanups of DRM core code. Diffstat says: 72 files changed, 832 insertions(+), 1038 deletions(-) ..which is already nice, but doesn't reflect that a lot of code is now hidden from main headers. Furthermore, with this series applied, drmP.h no longer looks as ugly as it is now (widly

[PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Gustavo Padovan
2014-08-29 Ville Syrj?l? : > On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > Due to the upcoming atomic modesetting feature we need to separate > > some update functions into a check step that can fail and a commit > > step that should,

[Bug 83205] GPU lockup when entering settings in Verdun game with HyperZ enabled

2014-08-29 Thread bugzilla-dae...@freedesktop.org
... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/f289dffc/attachment.html>

[PATCH 2/2] drm: don't recycle used modeset IDs

2014-08-29 Thread Rob Clark
On Fri, Aug 29, 2014 at 9:10 AM, David Herrmann wrote: > Hi > > On Fri, Aug 29, 2014 at 2:57 PM, David Herrmann > wrote: >> Hi >> >> On Fri, Aug 29, 2014 at 2:51 PM, Daniel Vetter wrote: >>> On Fri, Aug 29, 2014 at 02:01:01PM +0200, David Herrmann wrote: With MST, we now have connector

[Bug 83205] GPU lockup when entering settings in Verdun game with HyperZ enabled

2014-08-29 Thread bugzilla-dae...@freedesktop.org
are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/98eb1415/attachment.html>

drm: sti: add HDMI driver

2014-08-29 Thread Dan Carpenter
Hello Benjamin Gaignard, The patch 5402626c83a2: "drm: sti: add HDMI driver" from Jul 30, 2014, leads to the following static checker warning: drivers/gpu/drm/sti/sti_hdmi.c:301 hdmi_avi_infoframe_config() error: buffer overflow 'frame' 13 <= 13 drivers/gpu/drm/sti/sti_hdmi.c

[Bug 83205] GPU lockup when entering settings in Verdun game with HyperZ enabled

2014-08-29 Thread bugzilla-dae...@freedesktop.org
). https://github.com/apitrace/apitrace -- You are receiving this mail because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/95be436b/attachment.html>

[Intel-gfx] [PATCH 9/9] drm/i915: split intel_pipe_set_base() into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Thu, Aug 28, 2014 at 02:40:13PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Take out some parts of code that can fail from it and move them to > intel_pipe_check_base(), the only failure point in intel_pipe_set_base() > now is the fb pinning procudure. I'd like to see

[PATCH] drm/msm: Change nested function to static function

2014-08-29 Thread Mark Charlebois
There is currently a nested function in Russel King's tree for the msm HDMI driver. The last nested function was removed from the Linux kernel when the Thinkpad driver was fixed. I believe nested functions are not desired upstream, and it also breaks compilation with clang so here is a patch to

[PATCHv2 0/8] Upstreaming the Android build and misc fixes

2014-08-29 Thread Emil Velikov
Hi Tim, On 29/08/14 10:44, Gore, Tim wrote: > Hi Emil, sorry for the delay. > I still see the same patch error for patch 3/8. The patch diff > for intel/makefile.am has as part of its context: > > #Eric Anholt > > Whereas the source file has > > #Eric Anholt > > So the patch fails.

[Bug 83205] GPU lockup when entering settings in Verdun game with HyperZ enabled

2014-08-29 Thread bugzilla-dae...@freedesktop.org
because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/8bcd1e06/attachment.html>

[Bug 75112] Meta Bug for HyperZ issues on r600g and radeonsi

2014-08-29 Thread bugzilla-dae...@freedesktop.org
because: You are the assignee for the bug. -- next part -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/5497c91b/attachment.html>

[PATCH 4/9] drm/i915: split intel_update_plane into check() and commit()

2014-08-29 Thread Ville Syrjälä
On Thu, Aug 28, 2014 at 02:40:08PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Due to the upcoming atomic modesetting feature we need to separate > some update functions into a check step that can fail and a commit > step that should, ideally, never fail. > > This commit splits

[Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-08-29 Thread Michel Dänzer
On 29.08.2014 00:01, Alex Deucher wrote: > On Thu, Aug 28, 2014 at 4:57 AM, Christian K?nig > wrote: >> Am 28.08.2014 um 08:56 schrieb Michel D?nzer: >> >>> From: Michel D?nzer >>> >>> This flag is a hint that userspace expects the BO to be accessed by the >>> CPU. We can use that hint to

[PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Jani Nikula
On Thu, 28 Aug 2014, Gustavo Padovan wrote: > From: Gustavo Padovan > > If the save_encoder_crtcs or save_connector_encoders allocation fail > we need to free everything we have already allocated. There is no memleak, because the caller of intel_set_config_save_state() checks the return value,

[PATCH 2/9] drm/i915: trivial: remove unneed set to NULL

2014-08-29 Thread Jani Nikula
On Thu, 28 Aug 2014, Gustavo Padovan wrote: > From: Gustavo Padovan > > At this point of the code the obj var is already NULL, so we don't > need to set it again to NULL. Reviewed-by: Jani Nikula > Signed-off-by: Gustavo Padovan > --- > drivers/gpu/drm/i915/intel_display.c | 1 - > 1 file

[Bug 83234] Opening Steam crashes X session

2014-08-29 Thread bugzilla-dae...@freedesktop.org
-- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/95e21296/attachment.html>

[PATCHv2 0/8] Upstreaming the Android build and misc fixes

2014-08-29 Thread Gore, Tim
Hi Emil, sorry for the delay. I still see the same patch error for patch 3/8. The patch diff for intel/makefile.am has as part of its context: #Eric Anholt Whereas the source file has #Eric Anholt So the patch fails. Its trivial of course. Perhaps there is some automatic Substitution

[Bug 83234] Opening Steam crashes X session

2014-08-29 Thread bugzilla-dae...@freedesktop.org
ttp://lists.freedesktop.org/archives/dri-devel/attachments/20140829/e0fb93d8/attachment.html>

[Bug 83234] Opening Steam crashes X session

2014-08-29 Thread bugzilla-dae...@freedesktop.org
art -- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/b58d8c5c/attachment.html>

[Bug 83234] New: Opening Steam crashes X session

2014-08-29 Thread bugzilla-dae...@freedesktop.org
t;http://lists.freedesktop.org/archives/dri-devel/attachments/20140829/1a31fb83/attachment.html>

[Intel-gfx] [PATCH 3/9] drm/i915: fix memleak in intel_set_config_save_state()

2014-08-29 Thread Chris Wilson
On Fri, Aug 29, 2014 at 10:38:43AM +0300, Jani Nikula wrote: > On Thu, 28 Aug 2014, Gustavo Padovan wrote: > > From: Gustavo Padovan > > > > If the save_encoder_crtcs or save_connector_encoders allocation fail > > we need to free everything we have already allocated. > > There is no memleak,

[PATCH 2/2] drm: Resolve shadow warning for s32

2014-08-29 Thread Jeff Kirsher
From: Mark Rustad Resolve a shadow warning produced in a W=2 build by changing the name of a local variable from s32 to ds32. Since s32 clashes with the well-known typedef, any macro expansion that could someday be used that might attempt to use an s32 type would fail to

[PATCH 1/2] drm: Resolve many missing-field-initializers warnings

2014-08-29 Thread Jeff Kirsher
From: Mark Rustad Resolve many missing-field-initializers warnings that appear in W=2 builds by changing nested object initialization syntax. Signed-off-by: Mark Rustad Signed-off-by: Jeff Kirsher --- include/drm/drm_modes.h | 2 +- 1 file changed, 1 insertion(+), 1

  1   2   >