Re: [Outreachy kernel] [PATCH] gpu: drm: rockchip: Replace dev_* with DRM_DEV_*

2017-09-14 Thread Julia Lawall
On Fri, 15 Sep 2017, Haneen Mohammed wrote: > This patch replace instances of dev_info/err/debug with > DRM_DEV_INFO/ERROR/WARN respectively inorder to use a drm-formatted > specific log messages. Issue corrected with the help of the following > Coccinelle script: > > @r@ > @@ > > ( > -dev_info

[PATCH 1/2] drm: armada: Remove custom .dumb_destroy() handler

2017-09-14 Thread Laurent Pinchart
The custom implementation just calls drm_gem_handle_delete(), which is identical to the default implementation used when the operation handler isn't set. Remove it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/armada/armada_drv.c | 1 - drivers/gpu/drm/armada/armada_gem.c | 6 -- driv

[PATCH 2/2] drm: Don't export the drm_gem_dumb_destroy() function

2017-09-14 Thread Laurent Pinchart
The drm_gem_dumb_destroy() isn't used in drivers, don't export it. Signed-off-by: Laurent Pinchart --- drivers/gpu/drm/drm_dumb_buffers.c | 7 --- drivers/gpu/drm/drm_gem.c | 1 - 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/dr

Re: drm: Why shmem?

2017-09-14 Thread Eric Anholt
Noralf Trønnes writes: > Den 30.08.2017 09.40, skrev Daniel Vetter: >> On Tue, Aug 29, 2017 at 10:40:04AM -0700, Eric Anholt wrote: >>> Daniel Vetter writes: >>> On Mon, Aug 28, 2017 at 8:44 PM, Noralf Trønnes wrote: > Hi, > > Currently I'm using the cma library with tinydrm be

Re: drm: Why shmem?

2017-09-14 Thread Noralf Trønnes
Den 30.08.2017 09.40, skrev Daniel Vetter: On Tue, Aug 29, 2017 at 10:40:04AM -0700, Eric Anholt wrote: Daniel Vetter writes: On Mon, Aug 28, 2017 at 8:44 PM, Noralf Trønnes wrote: Hi, Currently I'm using the cma library with tinydrm because it was so simple to use even though I have to w

[PATCH] dma-buf: remove redundant initialization of sg_table

2017-09-14 Thread Colin King
From: Colin Ian King sg_table is being initialized and is never read before it is updated again later on, hence making the initialization redundant. Remove the initialization. Detected by clang scan-build: "warning: Value stored to 'sg_table' during its initialization is never read" Signed-off-

[Bug 101872] [PIGLIT] Corrupted temporal json test file blocks execution resume

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101872 Elizabeth changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail beca

[Bug 100596] [BXT/GLK/KBL/BDW/IVB/HSW/BSW/BYT] gem_userptr_blits/map-fixed-invalidate* showing bad address

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100596 Elizabeth changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #19 from Elizabeth --

[Bug 100305] [BAT][IGT]basic tests in gem_ctx_basic, gem_ctx_exec, gem_ctx_params fail

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100305 --- Comment #2 from Elizabeth --- Does this need to be verified or can we close it? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists

[Bug 99130] [IVB] CONFIG_PROVE_LOCKING=y causes igt/gem_exec/basic-wait-all (and possibly others) to fail

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99130 Elizabeth changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #23 from Elizabeth --- C

[Bug 98361] [BDW /BXT/SKL/SNB] [Regression] drv_hangman subtests parser fail

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98361 Elizabeth changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #4 from Elizabeth ---

Re: [PATCH 0/8] drm/fb-helper: Use drm_file to get a dumb framebuffer

2017-09-14 Thread Laurent Pinchart
Hi Noralf, On Wednesday, 13 September 2017 18:19:22 EEST Noralf Trønnes wrote: > Den 13.09.2017 07.09, skrev Laurent Pinchart: > > On Monday, 11 September 2017 17:31:54 EEST Noralf Trønnes wrote: > >> Hi, > >> > >> I want to start out by saying that this patchset is low priority for me > >> and i

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3 (GOG GOTY)

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 --- Comment #44 from Shmerl --- (In reply to Lukas Jirkovsky from comment #43) > Here are some additional information: Yes, I observed that as well. You can access the box over ssh, but it doens't react to any local input. Also attempts to rebo

[Bug 102009] Blender crashes when compiling OpenCL kernel

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102009 --- Comment #3 from Jan Vesely --- the stacktrace does not say much, and it's not similar to segfault I see on my machine. Can you repost the stacktrace with mesa debug information? thanks -- You are receiving this mail because: You are the a

[Bug 98352] [ctg bat] igt@kms_flip@basic-flip-vs-wf_vblank

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98352 Elizabeth changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail becau

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3 (GOG GOTY)

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 --- Comment #43 from Lukas Jirkovsky --- I'm having the same problem during the initial cutscene in Velen. Here are some additional information: * While the computer seems frozen, it's not frozen completely. I can still connect over ssh and do

Re: [PATCH v2 1/2] drm/gem-fb-helper: Cleanup docs

2017-09-14 Thread Laurent Pinchart
Hi Noralf, On Wednesday, 13 September 2017 16:41:49 EEST Noralf Trønnes wrote: > Den 13.09.2017 04.44, skrev Laurent Pinchart: > > On Monday, 11 September 2017 19:37:44 EEST Noralf Trønnes wrote: > >> Make the docs read a little better. > >> > >> Cc: Laurent Pinchart > >> Signed-off-by: Noralf T

[Bug 97259] Some gem_shrink subcases return fail instead of pass

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=97259 Elizabeth changed: What|Removed |Added Status|RESOLVED|CLOSED -- You are receiving this mail becau

[Bug 100212] Implement vload_* and vstore_* to make Theano/libgpuarray working

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=100212 --- Comment #4 from Jan Vesely --- (In reply to Vedran Miletić from comment #0) > We miss at least vload_half and vstore_half_rtn. vstore_half/vload_half is in libclc. I can't find vstore_half_rtn used in either blender-2.78 or 2.79. -- You a

[Bug 102517] System hang/freeze Helium Rain

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102517 --- Comment #2 from Samuel Pitoiset --- I can confirm the hang with the following environment. OpenGL renderer string: AMD Radeon (TM) RX 480 Graphics (AMD POLARIS10 / DRM 3.19.0 / 4.13.0-rc5-ARCH+, LLVM 4.0.1) OpenGL core profile version strin

[Bug 102276] System randomly freezes, only fixed by power off and boot.

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102276 --- Comment #9 from Mathieu Belanger --- I forgot to mention, while the crash occured, the mouse was working but everything else was hang, including magic keys was doing nothing. After X felt, I tried to login and I got an error about missing O

[Bug 102276] System randomly freezes, only fixed by power off and boot.

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102276 --- Comment #8 from Mathieu Belanger --- (In reply to Michel Dänzer from comment #7) > (In reply to Mathieu Belanger from comment #6) > > I might have the same bug > > > > I does not append with Mesa git from mid august but a version from begin

Re: [PATCH] drm/i915: remove redundant variable hw_check

2017-09-14 Thread Chris Wilson
Quoting Colin King (2017-09-14 17:21:54) > From: Colin Ian King > > hw_check is being assigned and updated but is no longer being read, > hence it is redundant and can be removed. > > Detected by clang scan-build: > "warning: Value stored to 'hw_check' during its initialization > is never read"

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3 (GOG GOTY)

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 Samuel Pitoiset changed: What|Removed |Added Summary|System freeze with AMDGPU |System freeze with AMDGPU

[Bug 102646] Screen flickering under amdgpu-experimental (buffer corruptions?)

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102646 --- Comment #9 from Justin Mitzel --- I went looking for them and noticed that these are all made for ubuntu. Will they still work with Manjaro? -- You are receiving this mail because: You are the assignee for the bug._

Re: [PATCH 0/6 v4] Add ASoC support for AMD Stoney APUs

2017-09-14 Thread Mark Brown
On Wed, Sep 13, 2017 at 02:49:08PM -0400, Alex Deucher wrote: > On Wed, Sep 13, 2017 at 2:12 PM, Mark Brown wrote: > > No, send me a pull request for the dependencies so we can do a cross > > merge. I want to make sure that when this gets reviewed it actually > > gets merged. > I'm not quite su

[Bug 196777] Virtual guest using video device QXL does not reach GDM

2017-09-14 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=196777 Justin M. Forbes (jmfor...@linuxtx.org) changed: What|Removed |Added CC||jmfor...@linuxtx

Re: [PATCH] drm/amdgpu: revert tile table update for oland

2017-09-14 Thread Alex Deucher
On Thu, Sep 14, 2017 at 12:21 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák Applied. thanks. Alex > > Marek > > On Mon, Sep 11, 2017 at 5:43 PM, Jean Delvare wrote: >> Several users have complained that the tile table update broke Oland >> support. Despite several attempts to fix it, the

Re: [PATCH] drm/amdgpu: revert tile table update for oland

2017-09-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Mon, Sep 11, 2017 at 5:43 PM, Jean Delvare wrote: > Several users have complained that the tile table update broke Oland > support. Despite several attempts to fix it, the root cause is still > unknown at this point and no solution is available. As it is not >

[PATCH] drm/i915: remove redundant variable hw_check

2017-09-14 Thread Colin King
From: Colin Ian King hw_check is being assigned and updated but is no longer being read, hence it is redundant and can be removed. Detected by clang scan-build: "warning: Value stored to 'hw_check' during its initialization is never read" Fixes: f6d1973db2d2 ("drm/i915: Move modeset state verif

[Bug 102709] War Thunder crashes after logging in to the game. (GL_INVALID_ENUM)

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102709 --- Comment #1 from Samuel Pitoiset --- Well, War Thunder doesn't check that GL_EXT_texture_compression_s3tc is exposed before using those compressed formats. Though, if you have libtxc_dxtn installed on your system the extension should be enab

[Bug 98324] [DC] amd-staging-4.7: problems with unblanking displays when monitors are switched off

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98324 --- Comment #7 from Darren Salt --- Seems to be working properly with current amd-staging-drm-next (43dd6fde5df4). -- You are receiving this mail because: You are the assignee for the bug.___ dri-deve

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 --- Comment #42 from Samuel Pitoiset --- What's your Steam AppID? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-devel@lists.freedesktop.org h

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91880 --- Comment #176 from Jon Doane --- (In reply to Thomas DEBESSE from comment #175) > (In reply to Alex Deucher from comment #174) > > (In reply to Thomas DEBESSE from comment #173) > > > > > > Their AMDGPU-PRO driver looks to not be affected by

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91880 --- Comment #175 from Thomas DEBESSE --- (In reply to Alex Deucher from comment #174) > (In reply to Thomas DEBESSE from comment #173) > > > > Their AMDGPU-PRO driver looks to not be affected by the bug, so they have a > > fix somewhere. Why thi

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 --- Comment #41 from Shmerl --- (In reply to Samuel Pitoiset from comment #40) > How to load a save game file? Where are they stored? They should be in: "${WINEPREFIX}/drive_c/users/$USER/My Documents/The Witcher 3/gamesaves" I.e. it depends

[Bug 101731] System freeze with AMDGPU when playing The Witcher 3

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101731 --- Comment #40 from Samuel Pitoiset --- How to load a save game file? Where are they stored? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list dri-d

[Bug 102694] Astrokill Beta: LLVM triggered Diagnostic Handler: Illegal instruction detected: VOP* instruction uses the constant bus more than once

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102694 --- Comment #4 from MIka R --- This also seems to affect kwin_x11. Memory leaking and some plasma 5 objects flicker mildly. -- You are receiving this mail because: You are the assignee for the bug.__

[Bug 91880] Radeonsi on Grenada cards (r9 390) exceptionally unstable and poorly performing

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=91880 --- Comment #174 from Alex Deucher --- (In reply to Thomas DEBESSE from comment #173) > > Their AMDGPU-PRO driver looks to not be affected by the bug, so they have a > fix somewhere. Why this fix can't make it's way to the open driver? The pro

[PATCH 2/2] drm/exynos: Fix suspend/resume support

2017-09-14 Thread Marek Szyprowski
Commit 7d902c05b480 ("drm: Nuke drm_atomic_helper_connector_dpms") removed drm_atomic_helper_connector_dpms() helper saying that it was a dead code. It was however indirectly used by Exynos DRM driver for implementing suspend/resume support. To fix this regression (after that patch Exynos DRM suspe

[PATCH 1/2] drm/exynos: Fix locking in the suspend/resume paths

2017-09-14 Thread Marek Szyprowski
Commit 48a92916729b ("drm/exynos: use drm_for_each_connector_iter()") replaced unsafe drm_for_each_connector() with drm_for_each_connector_iter() and removed surrounding drm_modeset_lock calls. However, that lock was there not only to protect unsafe drm_for_each_connector(), but it was also require

[PATCH 0/2] Exynos DRM: fix suspend/resume support

2017-09-14 Thread Marek Szyprowski
Hi! Recently I noticed that suspend/resume support in Exynos DRM driver is broken since v4.13-rc1. After some investigation I found that there are 2 patches causing this problem. First one is specific to v4.13 kernel release (first patch fixes it). The second one is caused by a patch queued to lin

[GIT PULL] fbdev changes for v4.14

2017-09-14 Thread Bartlomiej Zolnierkiewicz
Hi Linus, Please pull fbdev changes for v4.14. There is slightly more changes than usual this time (especially fbcon changes stand out from the rest), please see the signed tag description for details. Test merge revealed a small merge conflict, the resolution is trivial: diff --cc drivers/vide

Re: [Outreachy kernel] [PATCH v3 4/4] drm/agpsupport: Remove extra blank line

2017-09-14 Thread Julia Lawall
On Thu, 14 Sep 2017, Meghana Madhyastha wrote: > Remove extra blank line to adhere to standard coding style. > Found by checkpath.pl.. > > Signed-off-by: Meghana Madhyastha > --- > Changes in v3: > -This was part of another commit in v2 and v1. > Now made this a separate commit > > drivers/

[PATCH libdrm] freedreno/kgsl: fix pointer-to-int cast

2017-09-14 Thread Eric Engestrom
Fixes this warning: freedreno/kgsl/kgsl_ringbuffer.c: In function ‘kgsl_ringbuffer_flush’: freedreno/kgsl/kgsl_ringbuffer.c:149:19: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] req.timestamp = (uint32_t)kgsl_ring->bo->hostptr; ^ Signed-off

Re: [PATCH libdrm v3] etnaviv: prevent deadlock in error path

2017-09-14 Thread Eric Engestrom
On Wednesday, 2017-09-13 16:08:19 +0200, Philipp Zabel wrote: > If drmPrimeFDToHandle fails in etna_bo_from_dmabuf, the function must > not return with the table_lock mutex held. Unlock the mutex in the error > path. > > Based on ceb70a6b1015 ("freedreno: prevent deadlock in error path"). > > Sig

[PATCH v3 4/4] drm/agpsupport: Remove extra blank line

2017-09-14 Thread Meghana Madhyastha
Remove extra blank line to adhere to standard coding style. Found by checkpath.pl.. Signed-off-by: Meghana Madhyastha --- Changes in v3: -This was part of another commit in v2 and v1. Now made this a separate commit drivers/gpu/drm/drm_agpsupport.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH v3 0/4] drm/agpsupport: Code cleanup

2017-09-14 Thread Meghana Madhyastha
Removes checkpath.pl errors and warnings. Changes in v3: -Change commit title prefix from drm to drm/agpsupport -Split the commit "Move EXPORT_SYMBOL so that it immediately follows its function" into two commits. Removing the extra blank line is now a separate commit. -Included mergi

[PATCH v3 2/4] drm/agpsupport: Remove assignment in if condition

2017-09-14 Thread Meghana Madhyastha
Move the assignment so that it happens before the if condition. Merged multiple similar conditionals to a single conditional statement. This results in syntax which is easier to read. Found by checkpath.pl Signed-off-by: Meghana Madhyastha --- Changes in v3: -Added "Merged multiple similar cond

Re: Resizeable PCI BAR support V8

2017-09-14 Thread Bjorn Helgaas
On Mon, Jul 10, 2017 at 04:59:48PM +0200, Christian König wrote: > Hi everyone, > > This is the eighth incarnation of this set of patches. It enables device > drivers to resize and most likely also relocate the PCI BAR of devices > they manage to allow the CPU to access all of the device local me

[PATCH v3 1/4] drm/agpsupport: Replace "foo * bar" with "foo *bar"

2017-09-14 Thread Meghana Madhyastha
This replaces all instances of foo * bar with foo *bar in drm_agpsupport.c. This is so that it adheres to standard C syntax for pointers. Signed-off-by: Meghana Madhyastha --- Changes in v3: -None drivers/gpu/drm/drm_agpsupport.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[PATCH 1/2] drm/fsl-dcu: Fix DCU pixel clock issue in suspend/resume functions

2017-09-14 Thread Alison Wang
As there is not corresponding clk_prepare_enable() for fsl_dev->pix_clk in previous contexts, clk_disable_unprepare() for fsl_dcu->pix_clk in suspend function will fail. This patch will add clk_prepare_enable() for fsl_dev->pix_clk in previous contexts and resume function to fix the issue. This p

[PATCH v3 3/4] drm/agpsupport: Move EXPORT_SYMBOL so that it immediately follows its function

2017-09-14 Thread Meghana Madhyastha
EXPORT_SYMBOL(foo) should immediately follow its function/variable. This coding style is preferred. Found by checkpath.pl. Signed-off-by: Meghana Madhyastha --- Changes in v3: -Split this commit into two commits and made another commit for removing the extra blank line not part of the EXPORT_S

[PATCH 2/2] drm/fsl-dcu: Fix the interrupt issue in suspend/resume functions

2017-09-14 Thread Alison Wang
drm_atomic_helper_suspend()/drm_atomic_helper_resume() are used in suspend/resume functions. Interrupt can not be disabled when calling drm_atomic_helper_resume(). Or else vblank interrupt will not generate and the error about vblank wait timed out will occur. This patch will enable interrupt befo

[Bug 102457] [IGT] igt@kms_frontbuffer_tracking@basic blows up

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102457 --- Comment #7 from Chris Wilson --- (In reply to Martin Peres from comment #4) > (In reply to Daniel Vetter from comment #3) > > Also changing the summary, Martin is wrong here. > > And this is why we always need to trust the actual developers

[Bug 102457] [IGT] igt@kms_frontbuffer_tracking@basic blows up

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102457 Chris Wilson changed: What|Removed |Added Assignee|intel-gfx-bugs@lists.freede |dri-devel@lists.freedesktop

[Bug 101747] Steam-Game Turmoil, Segfault on start

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101747 John changed: What|Removed |Added OS|All |Linux (All) Hardware|Other

[Bug 101747] Steam-Game Turmoil, Segfault on start

2017-09-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101747 --- Comment #2 from John --- Same issue here on mesa dev with a 280X using the amdgpu kernel module on 4.13.1. In dmesg we can see this: [18506.679448] si_shader:2[21842]: segfault at f133abd4 ip 0834e6fc sp e8efcc60 error 7 in

[PATCH 04/10] drivers:mpt: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/message/fusion/mptbase.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index 84eab28..7920b2b 100644 --- a/drivers/message/fusion/mptbase.c +++ b/drivers/me

[PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- arch/powerpc/platforms/cell/spider-pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/cell/spider-pci.c b/arch/powerpc/platforms/cell/spider-pci.c index d1e61e2..82aa3f7 100644 --- a/arch/powerpc/platforms/cell/spide

[PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/net/ethernet/sun/cassini.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 382993c..fc0ea3a 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/et

[PATCH] drivers:gpu:Use ARRAY_SIZE() for the size calculation of the array.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c index 4395a4f..0487936 100644 --- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_

[PATCH v2 3/3] drm: Remove assignment in if condition

2017-09-14 Thread Meghana Madhyastha
Move the assignment so that it happens before the if condition. This results in syntax which is easier to read. Found by checkpath.pl Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/drm_agpsupport.c | 31 ++- 1 file changed, 18 insertions(+), 13 deletions(-) d

Re: [PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure.

2017-09-14 Thread David Sterba
On Wed, Sep 13, 2017 at 01:02:19PM +0530, Allen Pais wrote: > Signed-off-by: Allen Pais > --- > fs/btrfs/check-integrity.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c > index 7d5a9b5..efa4c23 100644 > --- a/fs/b

[PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/crypto/omap-aes-gcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/omap-aes-gcm.c b/drivers/crypto/omap-aes-gcm.c index 7d4f8a4..2542224 100644 --- a/drivers/crypto/omap-aes-gcm.c +++ b/drivers/crypto/omap-aes-gcm.c @@ -1

[PATCH v2 0/3] drm: Code cleanup

2017-09-14 Thread Meghana Madhyastha
These patches fix the checkpath warnings and errors in drm_agpsupport.c changes in v2: -Changed the commit subject prefix to follow the style used in drm. -Combine multiple redundant if conditions to a single condition in patch 3. Meghana Madhyastha (3): drm: Move EXPORT_SYMBOL so that it

[PATCH 09/10] driver:video: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c index f6a0b9a..5cd238d 100644 --- a/drivers/video/fbdev/matrox/matr

Re: [PATCH 01/10] arch:powerpc: return -ENOMEM on failed allocation

2017-09-14 Thread Allen
> I think the changelog for this series of conversions > should show that you've validated the change by > inspecting the return call chain at each modified line. > > Also, it seems you've cc'd the same mailing lists for > all of the patches modified by this series. > > It would be better to indivi

[PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/net/bonding/bond_alb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c index c02cc81..89df377 100644 --- a/drivers/net/bonding/bond_alb.c +++ b/drivers/net/bonding/bond_alb.c

[PATCH] drm/radeon: Fix guard on radeon trace header

2017-09-14 Thread Chuck Ebbert
It's been that way for years... --- a/drivers/gpu/drm/radeon/radeon_trace.h +++ b/drivers/gpu/drm/radeon/radeon_trace.h @@ -1,5 +1,5 @@ #if !defined(_RADEON_TRACE_H) || defined(TRACE_HEADER_MULTI_READ) -#define _RADEON_TRACE_H_ +#define _RADEON_TRACE_H #include #include

[PATCH v2 2/3] drm: Replace "foo * bar" with "foo *bar"

2017-09-14 Thread Meghana Madhyastha
This replaces all instances of foo * bar with foo *bar in drm_agpsupport.c. This is so that it adheres to standard C syntax for pointers. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/drm_agpsupport.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/

Re: [PATCH 05/10] drivers:net: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen
> propagates the -1. That is only called by bond_open() with: > > if (bond_alb_initialize(bond, (BOND_MODE(bond) == BOND_MODE_ALB))) > return -ENOMEM; > > So you might want to also modify this code, to return the return > value, rather than use the hard coded ENOMEM. > I'l

Re: [PATCH 06/10] drivers:ethernet: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen
> > static int cas_alloc_rxds(struct cas *cp) > { > int i; > > for (i = 0; i < N_RX_DESC_RINGS; i++) { > if (cas_alloc_rx_desc(cp, i) < 0) { > cas_free_rxds(cp); > return -1; > } > } > re

[PATCH v2 1/3] drm: Move EXPORT_SYMBOL so that it immediately follows its function

2017-09-14 Thread Meghana Madhyastha
EXPORT_SYMBOL(foo) should immediately follow its function/variable. This coding style is preferred. Found by checkpath.pl. Signed-off-by: Meghana Madhyastha --- drivers/gpu/drm/drm_agpsupport.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_agpsupport.c b/drivers/gpu/

[PATCH 10/10] fs:btrfs: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- fs/btrfs/check-integrity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/check-integrity.c b/fs/btrfs/check-integrity.c index 7d5a9b5..efa4c23 100644 --- a/fs/btrfs/check-integrity.c +++ b/fs/btrfs/check-integrity.c @@ -2913,7 +2913,7 @

[PATCH 07/10] driver:megaraid: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/scsi/megaraid/megaraid_mbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_mbox.c b/drivers/scsi/megaraid/megaraid_mbox.c index ec3c438..b09a0a6 100644 --- a/drivers/scsi/megaraid/megaraid_mbox.c +++

[PATCH 03/10] driver:gpu: return -ENOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/gpu/drm/gma500/mid_bios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/mid_bios.c b/drivers/gpu/drm/gma500/mid_bios.c index d75ecb3..1fa1633 100644 --- a/drivers/gpu/drm/gma500/mid_bios.c +++ b/drivers/gpu/drm/gm

[PATCH 08/10] driver:cxgbit: return -NOMEM on allocation failure.

2017-09-14 Thread Allen Pais
Signed-off-by: Allen Pais --- drivers/target/iscsi/cxgbit/cxgbit_target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/target/iscsi/cxgbit/cxgbit_target.c b/drivers/target/iscsi/cxgbit/cxgbit_target.c index 514986b..47127d6 100644 --- a/drivers/target/iscsi/cxgbit/

Re: [PATCH libdrm 1/4] amdgpu: add sync_file import and export functions

2017-09-14 Thread Emil Velikov
On 12 September 2017 at 21:43, Marek Olšák wrote: > From: Marek Olšák > > --- > amdgpu/amdgpu.h| 30 ++ > amdgpu/amdgpu_cs.c | 20 > 2 files changed, 50 insertions(+) > > diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h > index 238b1aa..b44b9b6

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

2017-09-14 Thread Emil Velikov
On 14 September 2017 at 08:56, Emil Velikov wrote: > Hi Marek, > > On 12 September 2017 at 21:42, Marek Olšák wrote: > >> include/drm/drm_syncobj.h | 4 > Please sync the header as described in > https://cgit.freedesktop.org/mesa/drm/tree/include/drm/README#n72 > > Tl;DR: cd .../linux;

Re: [PATCH 1/3] drm/syncobj: extract two helpers from drm_syncobj_create

2017-09-14 Thread Emil Velikov
Hi Marek, On 12 September 2017 at 21:42, Marek Olšák wrote: > include/drm/drm_syncobj.h | 4 Please sync the header as described in https://cgit.freedesktop.org/mesa/drm/tree/include/drm/README#n72 Tl;DR: cd .../linux; make headers_install; cp ... .../drm/include/drm; cd .../drm; git