[git pull] drm fixes for 4.16 final

2018-03-28 Thread Dave Airlie
Hi Linus, Nothing serious, two amdkfd and two tegra fixes. I'll be submitting -next early, in the next couple of hours. Dave. The following changes since commit 3eb2ce825ea1ad89d20f7a3b5780df850e4be274: Linux 4.16-rc7 (2018-03-25 12:44:30 -1000) are available in the Git repository at:

[Bug 104520] Intermittent X crashes: GPU HANG: ecode 9:0:0x85dffffb, in Xorg [443], reason: Hang on rcs0, action: reset

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104520 --- Comment #19 from Gennady --- Linux p50-debian 4.15.0-1-amd64 #1 SMP Debian 4.15.4-1 (2018-02-18) x86_64 GNU/Linux ii libgl1-mesa-dri:amd64 17.3.7-1 amd64

[Bug 105425] 3D & games produce periodic GPU crashes (Radeon R7 370)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105425 --- Comment #9 from MirceaKitsune --- And we have a verdict. The influential factor is by far the anti-aliasing, at least in the case of Xonotic. The other cvars I previously mentioned have absolutely no

[Bug 104520] Intermittent X crashes: GPU HANG: ecode 9:0:0x85dffffb, in Xorg [443], reason: Hang on rcs0, action: reset

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104520 --- Comment #18 from Gennady --- GPU HANG: ecode 9:0:0x85db, in Xorg [1035], reason: Hang on rcs0, action: reset Kernel: 4.15.0-1-amd64 Time: 1522274173 s 645209 us Boottime: 262 s 812221 us Uptime: 260 s 247539 us

[Bug 104520] Intermittent X crashes: GPU HANG: ecode 9:0:0x85dffffb, in Xorg [443], reason: Hang on rcs0, action: reset

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104520 --- Comment #17 from gennady.kup...@gmail.com --- I can not attach error log, please let me know if it is necessary. Problem is reproducible, if I run certain qt5 app xorg hangs. If I wait for a minute, it restarts. -- You are receiving this

[Bug 104520] Intermittent X crashes: GPU HANG: ecode 9:0:0x85dffffb, in Xorg [443], reason: Hang on rcs0, action: reset

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104520 --- Comment #16 from gennady.kup...@gmail.com --- I have same or very similar problem on Skylake. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

[PATCH v3 10/10] drm/i915/debugfs: Print sink PSR status

2018-03-28 Thread José Roberto de Souza
IGT tests could be improved with sink status, knowing for sure that hardware have activate or exit PSR. Cc: Dhinakaran Pandiyan Cc: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- v3: rebased

[PATCH v3 07/10] drm/i915/psr: Use PSR2 macro for PSR2

2018-03-28 Thread José Roberto de Souza
Cosmetic change. Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- v3: rebased drivers/gpu/drm/i915/i915_reg.h | 3 ++- drivers/gpu/drm/i915/intel_psr.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[PATCH v3 05/10] drm/i915/psr/cnl: Enable Y-coordinate support in source

2018-03-28 Thread José Roberto de Souza
For Geminilake and Cannonlake+ the Y-coordinate support must be enabled in PSR2_CTL too. Spec: 7713 and 7720 Cc: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- v3: rebased

[PATCH v3 08/10] drm/i915/psr: Cache sink synchronization latency

2018-03-28 Thread José Roberto de Souza
This value do not change overtime so better cache it than fetch it every PSR enable. Cc: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- v3: rebased

[PATCH v3 06/10] drm/i915/psr: Do not override PSR2 sink support

2018-03-28 Thread José Roberto de Souza
Sink can support our PSR2 requirements but userspace can request a resolution that PSR2 hardware do not support, in this case it was overwritten the PSR2 sink support. Adding another flag here, this way if requested resolution changed to a value that PSR2 hardware can handle, PSR2 can be enabled.

[PATCH v3 04/10] drm/i915/psr: Tie PSR2 support to Y coordinate requirement

2018-03-28 Thread José Roberto de Souza
Although i915 don't implement aux sync frame through tests was findout that pannels can do selective update when the y-coordinate is also included in SDP, that is why it is required to run PSR2 in i915. So moving to only one place the sink requirements that the actual driver needs to enable PSR2.

[PATCH v3 03/10] drm/i915/psr: Nuke aux frame sync

2018-03-28 Thread José Roberto de Souza
eDP spec states that aux frame is required to do PSR2 selective update but i915 don't fully implement it. It sends the aux frame sync messages but the value is always zero as the GTC is not enabled in driver. Through tests was findout that pannels can do selective update when the y-coordinate is

[PATCH v3 02/10] drm: Add DP last received PSR SDP VSC register and bits

2018-03-28 Thread José Roberto de Souza
This is a register to help debug what is in the last SDP VSC packet revived by sink. Signed-off-by: José Roberto de Souza Reviewed-by: Rodrigo Vivi --- v3: rebased include/drm/drm_dp_helper.h | 9 + 1 file changed, 9 insertions(+) diff

[PATCH v3 09/10] drm/i915/psr: Set DPCD PSR2 enable bit when needed

2018-03-28 Thread José Roberto de Souza
In the 2 eDP1.4a pannels tested set or not set bit have no effect but is better set it and comply with specification. Signed-off-by: José Roberto de Souza Cc: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi --- v3:

[PATCH v3 01/10] drm: Add DP PSR2 sink enable bit

2018-03-28 Thread José Roberto de Souza
To comply with eDP1.4a this bit should be set when enabling PSR2. Signed-off-by: José Roberto de Souza Reviewed-by: Rodrigo Vivi --- v3: rebased include/drm/drm_dp_helper.h | 1 + 1 file changed, 1 insertion(+) diff --git

[Bug 98974] Can't see borders/empires in Stellaris

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=98974 Timothy Arceri changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 103234] KWin crashed when Alt+Tab-ing through open windows

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103234 --- Comment #18 from Marek Olšák --- Possible fix: https://patchwork.freedesktop.org/patch/211876/ -- You are receiving this mail because: You are the assignee for the bug.___

[Bug 105463] [r600g] 3047 piglit failures, 75 crashes, 15 warnings on ppc (PCIe, ppc64, mesa-18.0.0)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105463 --- Comment #9 from erhar...@mailbox.org --- Created attachment 138402 --> https://bugs.freedesktop.org/attachment.cgi?id=138402=edit html summary from 'pigllit run all' (18.0.0) -- You are receiving this mail because: You are the assignee

[radeon-alex:amd-staging-drm-next 1046/1062] drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppatomfwctrl.c:43:2: note: in expansion of macro 'if'

2018-03-28 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 6761ccd944db730dca6f9033781b4645a6eecfd4 commit: 8e62ef009a4bb61d25d391d0384f3314cc6d2059 [1046/1062] drm/amd/pp: Use atombios api directly in powerplay config: i386-randconfig-s1-201812 (attached as .config)

[Bug 105463] [r600g] 3047 piglit failures, 75 crashes, 15 warnings on ppc (PCIe, ppc64, mesa-18.0.0)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105463 erhar...@mailbox.org changed: What|Removed |Added Attachment #138084|0 |1 is obsolete|

[Bug 105463] [r600g] 3047 piglit failures, 75 crashes, 15 warnings on ppc (PCIe, ppc64, mesa-18.0.0)

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105463 erhar...@mailbox.org changed: What|Removed |Added Summary|[r600g] 4210 piglit |[r600g] 3047 piglit

[radeon-alex:amd-staging-drm-next 1046/1062] drivers/gpu/drm/amd/amdgpu/../powerplay/hwmgr/ppatomfwctrl.c:43:2: warning: this 'if' clause does not guard...

2018-03-28 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git amd-staging-drm-next head: 6761ccd944db730dca6f9033781b4645a6eecfd4 commit: 8e62ef009a4bb61d25d391d0384f3314cc6d2059 [1046/1062] drm/amd/pp: Use atombios api directly in powerplay config: x86_64-randconfig-s5-03290316 (attached as .config)

Re: [PATCH 1/1] drm: add parameter explanation for some gem dmabuf_ops

2018-03-28 Thread Alex Deucher
On Mon, Mar 26, 2018 at 3:22 PM, Samuel Li wrote: > To reduce some warnings. > > Signed-off-by: Samuel Li Reviewed-by: Alex Deucher And pushed. Alex > --- > drivers/gpu/drm/drm_prime.c | 13 + > 1 file changed, 13

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-28 Thread Christian König
Am 28.03.2018 um 20:57 schrieb Logan Gunthorpe: On 28/03/18 12:28 PM, Christian König wrote: I'm just using amdgpu as blueprint because I'm the co-maintainer of it and know it mostly inside out. Ah, I see. The resource addresses are translated using dma_map_resource(). As far as I know that

[PULL] drm-misc-next-fixes

2018-03-28 Thread Sean Paul
Hi Dave, Here's a lonely fix for -next, please pull at your convenience. drm-misc-next-fixes-2018-03-28: UABI: - Mask mode type garbage from userspace (Ville) Cc: Ville Syrjälä Cheers, Sean The following changes since commit

[PATCH v2 6/6] drm/msm: Switch to atomic_helper_commit()

2018-03-28 Thread Sean Paul
Now that all of the msm-specific goo is tucked safely away we can switch over to using the atomic helper commit directly. \o/ Changes in v2: - None Cc: Abhinav Kumar Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/msm_atomic.c | 120

[PATCH v2 5/6] drm/msm: Remove msm_commit/worker, use atomic helper commit

2018-03-28 Thread Sean Paul
Moving further towards switching fully to the the atomic helpers, this patch removes the hand-rolled worker nonblock commit code and uses the atomic helpers commit_work model. Changes in v2: - Remove commit_destroy() - Shuffle order of commit_tail calls to further serialize commits - Use stall in

[PATCH v2 4/6] drm/msm: Issue queued events when disabling crtc

2018-03-28 Thread Sean Paul
Ensure that any queued events are issued when disabling the crtc. This avoids timeouts when we come back and wait for dependencies (like the previous frame's flip_done). Changes in v2: - None Signed-off-by: Sean Paul --- drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 9

[PATCH v2 3/6] drm/msm: Mark the crtc->state->event consumed

2018-03-28 Thread Sean Paul
Don't leave the event != NULL once it's consumed, this is used a signal to the atomic helpers that the event will be handled by the driver. Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by: Sean Paul ---

[PATCH v2 2/6] drm/msm: Refactor complete_commit() to look more the helpers

2018-03-28 Thread Sean Paul
Factor out the commit_tail() portions of complete_commit() into a separate function to facilitate moving to the atomic helpers in future patches. Changes in v2: - None Cc: Jeykumar Sankaran Signed-off-by: Sean Paul ---

[PATCH v2 1/6] drm/msm: Use drm_private_obj/state instead of subclassing

2018-03-28 Thread Sean Paul
Now that we have private state handled by the core, we can use those instead of rolling our own swap_state for private data. Originally posted here: https://patchwork.freedesktop.org/patch/211361/ Changes in v2: - Use state->state in disp duplicate_state callback (Jeykumar) Changes in v3: -

[PATCH v2 0/6] drm/msm: Switch to atomic helpers

2018-03-28 Thread Sean Paul
I noticed a couple of rough edges yesterday as I was running some tests, so here's v2 which fixes them. Most notably, I was experiencing issues when the crtc was being disabled with abandoned events and vblank timeouts. Note that I've bundled the private_obj change into this set since it shares

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

2018-03-28 Thread Kieran Bingham
On 28/03/18 13:27, Kieran Bingham wrote: > Hi Laurent, > > Thank you for the patch. > > On 26/02/18 21:45, Laurent Pinchart wrote: >> The entities in the pipeline are all started when the LIF is setup. >> Remove the outdated comment that state otherwise. >> >> Signed-off-by: Laurent Pinchart

Re: [PATCH 08/15] v4l: vsp1: Setup BRU at atomic commit time

2018-03-28 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > To implement fully dynamic plane assignment to pipelines, we need to > reassign the BRU and BRS to the DRM pipelines in the atomic commit > handler. In preparation for this setup factor out the BRU source pad > code and call it both at LIF

[PATCH] drm/nouveau/bios/init: fix spelling mistake: "CONDITON" -> "CONDITION"

2018-03-28 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in warning message text Signed-off-by: Colin Ian King --- drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-28 Thread Christian König
Am 28.03.2018 um 18:25 schrieb Logan Gunthorpe: On 28/03/18 10:02 AM, Christian König wrote: Yeah, that looks very similar to what I picked up from the older patches, going to read up on that after my vacation. Yeah, I was just reading through your patchset and there are a lot of

[Bug 101442] Piglit shaders@ssa@fs-if-def-else-break fails with sb but passes with R600_DEBUG=nosb

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101442 Emil Velikov changed: What|Removed |Added Resolution|--- |FIXED

[PATCH v2] drm/msm: don't deref error pointer in the msm_fbdev_create error path

2018-03-28 Thread Emil Velikov
From: Emil Velikov Currently the error pointer returned by msm_alloc_stolen_fb gets passed to drm_framebuffer_remove. The latter handles only NULL pointers, thus a nasty crash will occur. Drop the unnecessary fail label and the associated checks - both err and fb

Re: [PATCH v2 2/2] drm/tinydrm: Make fb_dirty into a lower level hook

2018-03-28 Thread Ville Syrjälä
On Fri, Mar 23, 2018 at 05:28:03PM +0100, Noralf Trønnes wrote: > > Den 23.03.2018 16.35, skrev Ville Syrjala: > > From: Ville Syrjälä > > > > mipi_dbi_enable_flush() wants to call the fb->dirty() hook from the > > bowels of the .atomic_enable() hook. That prevents

[PATCH] drm/rockchip: fix VOP vblank race

2018-03-28 Thread John Keeping
We have seen a case of a bad reference count for vblanks with the Rockchip VOP: [ cut here ] WARNING: CPU: 1 PID: 383 at drivers/gpu/drm/drm_irq.c:1198 drm_vblank_put+0x40/0xcc Modules linked in: brcmfmac brcmutil CPU: 1 PID: 383 Comm:

Re: [PATCH libdrm 1/2] intel: Do not use libpciaccess on Android

2018-03-28 Thread Emil Velikov
On 27 March 2018 at 00:27, John Stultz wrote: > On Tue, Mar 20, 2018 at 10:36 AM, Emil Velikov > wrote: >> From: Tomasz Figa >> >> This patch makes the code not rely anymore on libpciaccess when compiled >> for Android to

[Bug 105788] Account request for drm-misc

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105788 Daniel Vetter changed: What|Removed |Added Assignee|dri-devel@lists.freedesktop

[Bug 105788] Account request for drm-misc

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105788 --- Comment #3 from Daniel Vetter --- Ack. Also acked by Gustavo and Sean on irc. -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing list

Re: [PATCH] amdkfd: always select MMU_NOTIFIER

2018-03-28 Thread Christian König
Am 28.03.2018 um 17:53 schrieb Arnd Bergmann: Building amdkfd without MMU notifiers is broken: In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type This adds the missing 'select

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-28 Thread Christian König
Am 28.03.2018 um 17:47 schrieb Logan Gunthorpe: On 28/03/18 09:07 AM, Christian König wrote: Am 28.03.2018 um 14:38 schrieb Christoph Hellwig: On Sun, Mar 25, 2018 at 12:59:54PM +0200, Christian König wrote: From: "wda...@nvidia.com" Add an interface to find the first

[PATCH] drm/msm: don't deref error pointer in the msm_fbdev_create error path

2018-03-28 Thread Emil Velikov
From: Emil Velikov Currently the error pointer returned by msm_alloc_stolen_fb gets passed to drm_framebuffer_remove. The latter handles only NULL pointers, thus a nasty crash will occur. Drop the unnecessary fail label and the associated checks - both err and fb

[PATCH] amdkfd: always select MMU_NOTIFIER

2018-03-28 Thread Arnd Bergmann
Building amdkfd without MMU notifiers is broken: In file included from drivers/gpu/drm/amd/amdkfd/kfd_mqd_manager_vi.c:28: drivers/gpu/drm/amd/amdkfd/kfd_priv.h:584:22: error: field 'mmu_notifier' has incomplete type This adds the missing 'select MMU_NOTIFIER' line to make it build cleanly all

[Bug 105788] Account request for drm-misc

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105788 --- Comment #2 from Oleksandr Andrushchenko --- Created attachment 138394 --> https://bugs.freedesktop.org/attachment.cgi?id=138394=edit GPG key -- You are receiving this mail because: You are the assignee for the

[Bug 105788] Account request for drm-misc

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105788 --- Comment #1 from Oleksandr Andrushchenko --- Created attachment 138393 --> https://bugs.freedesktop.org/attachment.cgi?id=138393=edit SSH public key -- You are receiving this mail because: You are the assignee for the

[Bug 105788] Account request for drm-misc

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105788 Bug ID: 105788 Summary: Account request for drm-misc Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-28 Thread Rob Herring
On Wed, Mar 28, 2018 at 10:19 AM, Rob Herring wrote: > On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: >> Hey John, >> >> On Fri, Mar 16, 2018 at 10:48 PM, John Stultz wrote: >>> In trying to integrate the new gralloc_handle.h

[GIT PULL] drm/tegra: Fixes for v4.16

2018-03-28 Thread Thierry Reding
Hi Dave, The following changes since commit 192b4af6cd28cdad9b42fd79c21a90a2aeb0bec7: drm/tegra: Shutdown on driver unbind (2018-03-19 09:57:32 +0100) are available in the Git repository at: git://anongit.freedesktop.org/tegra/linux tags/drm/tegra/for-4.16-fixes for you to fetch changes

[Bug 105733] Amdgpu randomly hangs and only ssh works. Mouse cursor moves sometimes but does nothing. Keyboard stops working.

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105733 --- Comment #5 from Emil Velikov --- Hi Allan, just sharing some ideas - I'm not working on the AMD drivers Make sure you're not using libdrm* 2.4.90 - it has some nasty bugs. Afterwords, try to track down exactly

Re: [RFC][PATCH] libdrm: gralloc_handle.h: Fix build issue with Android

2018-03-28 Thread Rob Herring
On Sat, Mar 17, 2018 at 2:33 PM, Stefan Schake wrote: > Hey John, > > On Fri, Mar 16, 2018 at 10:48 PM, John Stultz wrote: >> In trying to integrate the new gralloc_handle.h with the >> drm_hwcomposer, I started seeing the following compilation >>

[Bug 105786] System freeze, amdgpu 4.17-WIP, 4.16.0-rc1-576e538e5fe6

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105786 Bug ID: 105786 Summary: System freeze, amdgpu 4.17-WIP, 4.16.0-rc1-576e538e5fe6 Product: DRI Version: DRI git Hardware: Other OS: All Status:

Re: [PATCH 1/4] drm/vgem: Fix vgem_init to get drm device avaliable.

2018-03-28 Thread Emil Velikov
On 28 March 2018 at 15:49, Chris Wilson wrote: > Quoting Emil Velikov (2018-03-28 02:24:48) >> From: Deepak Sharma >> >> Modify vgem_init to take platform dev as parent in drm_dev_init. >> This will make drm device available at

Re: [PATCH] drm: Use srcu to protect drm_device.unplugged

2018-03-28 Thread Daniel Vetter
On Wed, Mar 28, 2018 at 10:38:35AM +0300, Oleksandr Andrushchenko wrote: > From: Noralf Trønnes > > Use srcu to protect drm_device.unplugged in a race free manner. > Drivers can use drm_dev_enter()/drm_dev_exit() to protect and mark > sections preventing access to device

Re: [PATCH 1/5] staging/vboxvideo: Use gem_free_object_unlocked

2018-03-28 Thread Daniel Vetter
On Tue, Mar 27, 2018 at 05:25:21PM +0200, Greg Kroah-Hartman wrote: > On Tue, Mar 27, 2018 at 11:18:03AM +0200, Daniel Vetter wrote: > > On Tue, Mar 27, 2018 at 10:34:07AM +0200, Greg Kroah-Hartman wrote: > > > On Tue, Mar 27, 2018 at 10:23:52AM +0200, Daniel Vetter wrote: > > > > vboxvideo

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-28 Thread Christian König
Am 28.03.2018 um 14:38 schrieb Christoph Hellwig: On Sun, Mar 25, 2018 at 12:59:54PM +0200, Christian König wrote: From: "wda...@nvidia.com" Add an interface to find the first device which is upstream of both devices. Please work with Logan and base this on top of the

Re: [PATCH 09/15] v4l: vsp1: Replace manual DRM pipeline input setup in vsp1_du_setup_lif

2018-03-28 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The vsp1_du_setup_lif() function setups the DRM pipeline input manually. s/ setups the / sets up the / > This duplicates the code from the vsp1_du_pipeline_setup_input() > function. Replace the manual implementation by a call to the

Re: [PATCH 1/4] drm/vgem: Fix vgem_init to get drm device avaliable.

2018-03-28 Thread Chris Wilson
Quoting Emil Velikov (2018-03-28 02:24:48) > From: Deepak Sharma > > Modify vgem_init to take platform dev as parent in drm_dev_init. > This will make drm device available at "/sys/devices/platform/vgem" > in x86 chromebook. > > Cc: Daniel Vetter

Re: [PATCH 1/4] drm/vgem: Fix vgem_init to get drm device avaliable.

2018-03-28 Thread Emil Velikov
On 28 March 2018 at 08:16, Daniel Vetter wrote: > On Wed, Mar 28, 2018 at 02:24:48AM +0100, Emil Velikov wrote: >> From: Deepak Sharma >> >> Modify vgem_init to take platform dev as parent in drm_dev_init. >> This will make drm device available at

Re: [PATCH 07/15] v4l: vsp1: Move DRM atomic commit pipeline setup to separate function

2018-03-28 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The DRM pipeline setup code used at atomic commit time is similar to the > setup code used when enabling the pipeline. Move it to a separate > function in order to share it. > > Signed-off-by: Laurent Pinchart

Re: [PATCH 3/4] drm/virtio: remove drm_dev_set_unique workaround

2018-03-28 Thread Emil Velikov
Hi Laszlo, On 28 March 2018 at 11:27, Laszlo Ersek wrote: > On 03/28/18 03:24, Emil Velikov wrote: >> From: Emil Velikov >> >> Ealier commit a325725633c26aa66ab940f762a6b0778edf76c0 did not attribute >> that virtio can be either PCI or a platform

Re: [PATCH] video: fbdev: s3c-fb: remove dead platform code for Exynos and S5PV210 platforms

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Wednesday, February 14, 2018 04:56:53 PM Jingoo Han wrote: > On Wednesday, February 14, 2018 7:01 AM wrote: > > > > Exynos5, Exynos4 and S5PV210 platforms have been converted to > > use Device Tree and Exynos DRM driver long time ago. Remove > > dead platform code for these platforms and

Re: [PATCH 3/3] video: au1100fb: Delete an unnecessary variable initialisation in au1100fb_drv_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 07:01:14 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 27 Nov 2017 18:40:23 +0100 > > The local variable "fbdev" will be reassigned by a following statement. > Thus omit the explicit initialisation at the beginning. >

Re: [PATCH 2/3] video: au1100fb: Improve a size determination in au1100fb_drv_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 06:59:57 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 27 Nov 2017 18:18:34 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH 1/3] video: au1100fb: Delete an error message for a failed memory allocation in au1100fb_drv_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 06:58:22 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 27 Nov 2017 18:14:41 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

Re: [PATCH 06/15] v4l: vsp1: Share duplicated DRM pipeline configuration code

2018-03-28 Thread Kieran Bingham
On 26/02/18 21:45, Laurent Pinchart wrote: > Move the duplicated DRM pipeline configuration code to a function and > call it from vsp1_du_setup_lif() and vsp1_du_atomic_flush(). > > Signed-off-by: Laurent Pinchart LGTM. I thought I had a bit of

Re: [PATCH] video/console/sticore: Delete an error message for a failed memory allocation in sti_try_rom_generic()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 07:00:22 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 5 Dec 2017 18:45:42 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

Re: [PATCH 2/2] video: ARM CLCD: Improve a size determination in clcdfb_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 06:13:33 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 5 Dec 2017 17:53:19 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH 1/2] video: ARM CLCD: Delete an error message for a failed memory allocation in clcdfb_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Tuesday, December 05, 2017 06:12:30 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 5 Dec 2017 17:50:11 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

[Bug 104064] (DC 4.15-rc2) WARNING: CPU: 4 PID: 75 at drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:601 dm_suspend+0x4e/0x60 [amdgpu]

2018-03-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104064 --- Comment #52 from Bjorn --- (In reply to taijian from comment #51) > > OK, I'm not seeing that at all, and I also have a Kaby Lake chip. What > version of Linux-Firmware are you using? 1.169.3. I tried going back to

Re: [PATCH 05/15] v4l: vsp1: Use vsp1_entity.pipe to check if entity belongs to a pipeline

2018-03-28 Thread Kieran Bingham
Hi Laurent, On 26/02/18 21:45, Laurent Pinchart wrote: > The DRM pipeline handling code uses the entity's pipe list head to check > whether the entity is already included in a pipeline. This method is a > bit fragile in the sense that it uses list_empty() on a list_head that > is a list member.

Re: [PATCH] video: matroxfb: Delete an error message for a failed memory allocation in matroxfb_crtc2_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, November 26, 2017 10:32:06 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 26 Nov 2017 22:13:55 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle

Re: [PATCH 2/2] video: s3c-fb: Improve a size determination in s3c_fb_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 01:07:15 PM Jingoo Han wrote: > On Sunday, November 26, 2017 9:18 AM, SF Markus Elfring wrote: > > > > From: Markus Elfring > > Date: Sun, 26 Nov 2017 15:03:03 +0100 > > > > Replace the specification of a data structure by a pointer

Re: [PATCH 1/2] video: s3c-fb: Delete an error message for a failed memory allocation in s3c_fb_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 01:06:30 PM Jingoo Han wrote: > On Sunday, November 26, 2017 9:17 AM, SF Markus Elfring wrote: > > > > From: Markus Elfring > > Date: Sun, 26 Nov 2017 15:00:16 +0100 > > > > Omit an extra message for a memory allocation failure in this

Re: [PATCH 2/5] drm/rockchip: fixup comment for gem_free_object_unlocked

2018-03-28 Thread Sean Paul
On Tue, Mar 27, 2018 at 10:23:53AM +0200, Daniel Vetter wrote: > Just want to clean out all grep hits. gem_free_object is deprecated. > > Signed-off-by: Daniel Vetter Reviewed-by: Sean Paul > Cc: Sandy Huang > Cc: "Heiko

Re: [PATCH] video: fsl-diu-fb: Delete an error message for a failed memory allocation in fsl_diu_init()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Monday, November 27, 2017 11:31:10 AM Timur Tabi wrote: > On 11/27/17 3:00 AM, SF Markus Elfring wrote: > > From: Markus Elfring > > Date: Mon, 27 Nov 2017 09:56:09 +0100 > > > > Omit an extra message for a memory allocation failure in this function. > > > >

Re: [PATCH v2] video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 07:34:44 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 19:27:28 +0100 > > Replace the specification of a data structure by a pointer dereference > as the parameter for the operator "sizeof" to make the

Re: [PATCH v3 3/3] video: smscufx: Delete an error message for a failed memory allocation in ufx_realloc_framebuffer()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 05:06:13 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 16:12:40 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software.

Re: [PATCH v3 2/3] video: smscufx: Return an error code only as a constant in ufx_realloc_framebuffer()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 05:04:04 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 16:07:11 +0100 > > * Return an error code without storing it in an intermediate variable. > > * Delete the label "error" and local variable "retval" >

Re: [PATCH v3 1/3] video: smscufx: Less checks in ufx_usb_probe() after error detection

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 05:02:21 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 15:56:11 +0100 > > Up to four checks could be repeated by the ufx_usb_probe() function > during error handling even if the relevant properties can be

Re: [PATCH 04/15] v4l: vsp1: Store pipeline pointer in vsp1_entity

2018-03-28 Thread Kieran Bingham
Hi Laurent, Thank you for the patch. On 26/02/18 21:45, Laurent Pinchart wrote: > Various types of objects subclassing vsp1_entity currently store a > pointer to the pipeline. Move the pointer to vsp1_entity to simplify the > code and avoid storing the pipeline in more entity subclasses later.

Re: [PATCH v2 1/2] video: udlfb: Return an error code only as a constant in dlfb_realloc_framebuffer()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 02:34:51 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 14:02:36 +0100 > > * Return an error code without storing it in an intermediate variable. > > * Delete the label "error" and local variable "retval" >

Re: [PATCH v2 2/2] video/fbdev/stifb: Delete an error message for a failed memory allocation in stifb_init_fb()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 12:58:47 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 12:34:22 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software.

Re: [PATCH v2 1/2] video/fbdev/stifb: Return -ENOMEM after a failed kzalloc() in stifb_init_fb()

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Sunday, January 07, 2018 12:56:45 PM SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 7 Jan 2018 11:33:59 +0100 > > Replace an error code for the indication of a memory allocation failure > in this function. > > Fixes:

Re: [PATCH] video: fbdev: aty128fb: use true and false for boolean values

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Thursday, March 22, 2018 03:13:32 PM Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Patch queued for 4.17, thanks.

Re: [PATCH] fbdev: aty: fix missing indentation in if statement

2018-03-28 Thread Bartlomiej Zolnierkiewicz
On Thursday, March 15, 2018 06:16:24 PM Colin King wrote: > From: Colin Ian King > > There is a missing indentation following an if statement, fix this. > > Detected by Coccinelle: > drivers/video/fbdev/aty/mach64_ct.c:183:2-15: code aligned with > following code on

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-28 Thread Christoph Hellwig
On Sun, Mar 25, 2018 at 12:59:54PM +0200, Christian König wrote: > From: "wda...@nvidia.com" > > Add an interface to find the first device which is upstream of both > devices. Please work with Logan and base this on top of the outstanding peer to peer patchset.

Re: [PATCH 1/8] lib/scatterlist: add sg_set_dma_addr() helper

2018-03-28 Thread Christoph Hellwig
On Sun, Mar 25, 2018 at 12:59:53PM +0200, Christian König wrote: > Use this function to set an sg entry to point to device resources mapped > using dma_map_resource(). The page pointer is set to NULL and only the DMA > address, length and offset values are valid. NAK. Please provide a higher

Re: [PATCH 03/15] v4l: vsp1: Remove unused field from vsp1_drm_pipeline structure

2018-03-28 Thread Kieran Bingham
Hi Laurent, Thanks for the patch, On 26/02/18 21:45, Laurent Pinchart wrote: > The vsp1_drm_pipeline enabled field is set but never used. Remove it. > Indeed - not used. > Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

2018-03-28 Thread Kieran Bingham
Hi Laurent, Thank you for the patch. On 26/02/18 21:45, Laurent Pinchart wrote: > The entities in the pipeline are all started when the LIF is setup. > Remove the outdated comment that state otherwise. > > Signed-off-by: Laurent Pinchart I'll start

Re: [PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-03-28 Thread Boris Brezillon
On Wed, 28 Mar 2018 14:22:36 +0200 Daniel Vetter wrote: > On Wed, Mar 28, 2018 at 09:34:54AM +0200, Boris Brezillon wrote: > > Hi Peter, > > > > On Mon, 26 Mar 2018 09:35:02 +0200 > > Peter Rosin wrote: > > > > > I have an sama5d31-based system with 64MB of

Re: [PATCH] drm/atmel-hlcdc: add command line option to specify preferred depth

2018-03-28 Thread Daniel Vetter
On Wed, Mar 28, 2018 at 09:34:54AM +0200, Boris Brezillon wrote: > Hi Peter, > > On Mon, 26 Mar 2018 09:35:02 +0200 > Peter Rosin wrote: > > > I have an sama5d31-based system with 64MB of memory and a 1920x1080 > > LVDS display wired for 16-bpp. When I enable legacy fbdev

Re: [PATCH v4 0/6] drm: zpos normalization cleanup and omapdrm to use it

2018-03-28 Thread Tomi Valkeinen
On 28/03/18 15:10, Peter Ujfalusi wrote: >> Thanks. I think this looks fine, I'll push via drm-misc. > > There is v5 on the list. Yep, that's what I pushed. Somehow I managed to reply to this older thread... Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.

Re: [PATCH v4 0/6] drm: zpos normalization cleanup and omapdrm to use it

2018-03-28 Thread Peter Ujfalusi
On 2018-03-28 12:30, Tomi Valkeinen wrote: > Hi, > > On 06/02/18 14:05, Peter Ujfalusi wrote: >> Hi, >> >> Changes since v3: >> - Moved the new normalize_zpos bool to be around another bools >> - Extended the commit message for sti that the drm_atomic_helper_check() is >> going to ask for

[PATCH] drm/omapdrm: Switch to gem_free_object_unlocked

2018-03-28 Thread Daniel Vetter
The only thing that omap_gem_free_object does that might need the magic protection of struct_mutex (of keeping all objects alive if that lock is held, even if the last reference is gone) is the mm_list manipulation. But that is already protected by the separate omapdrm->list_lock, which means

Re: [PATCH 5/5] drm/omapdrm: Switch to gem_free_object_unlocked

2018-03-28 Thread Tomi Valkeinen
On 28/03/18 13:12, Daniel Vetter wrote: >> This triggers WARN_ON(!mutex_is_locked(>struct_mutex)), we have a >> few of those. I need to reverse engineer the omap_gem locking a bit to >> understand what's needed. And I need to figure out what exactly does >> struct_mutext protect =). > > Oops, I

  1   2   >