RE: [Intel-gfx] [RFC 3/3] drm/i915: Set colorspace by enabling Infoframe

2018-09-26 Thread Shankar, Uma
>-Original Message- >From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >Sent: Wednesday, September 26, 2018 2:41 PM >To: Shankar, Uma ; intel-...@lists.freedesktop.org; >dri-devel@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten > >Subject: Re: [Intel-gfx]

RE: [Intel-gfx] [RFC 1/3] drm: Add colorspace property

2018-09-26 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Wednesday, September 26, 2018 3:12 PM >To: Maarten Lankhorst >Cc: Shankar, Uma ; Adam Jackson >; intel-...@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; Syrjala, Ville ; >Lankhorst,

Re: [GIT PULL] drm-hisilicon-next-2018-09-26

2018-09-26 Thread Dave Airlie
On Wed, 26 Sep 2018 at 15:58, Xinliang Liu wrote: > > Hi Dave, > A few changes for 4.20. Please pull. > - A crash fix founded in recent linux-next from John Garry > - One sparse warning fix from Souptick Joarder > - Some xxx_unref cleanup from Thomas Zimmermann > > Thanks, > Xinliang > > > The

[Bug 106164] dal_gpio_open_ex+0x34/0x180 [amdgpu]

2018-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106164 higu...@gmx.net changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 105725] WARNING: CPU: 0 PID: 487 at drivers/gpu/drm/amd/amdgpu/../display /dc/gpio/gpio_base.c:64 dal_gpio_open_ex+0xc/0x30 [amdgpu]

2018-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105725 --- Comment #11 from higu...@gmx.net --- *** Bug 106164 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mailing

Re: [PATCH 2/2] drm/i915: Do not get aux power for disconnected DP ports

2018-09-26 Thread Souza, Jose
On Tue, 2018-09-25 at 11:16 +0300, Jani Nikula wrote: > On Mon, 24 Sep 2018, José Roberto de Souza > wrote: > > For ICL type-c ports there is a aux power restriction, it can only > > be > > enabled while there is sink connected. > > > > BSpec: 21750 > > > > Cc: Maarten Lankhorst > >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Do not get aux power for disconnected DP ports

2018-09-26 Thread Souza, Jose
On Tue, 2018-09-25 at 15:17 +0300, Ville Syrjälä wrote: > On Mon, Sep 24, 2018 at 06:16:49PM -0700, José Roberto de Souza > wrote: > > For ICL type-c ports there is a aux power restriction, it can only > > be > > enabled while there is sink connected. > > That can't be entirely true because it's

[Bug 107333] Display Not Detected If Powered Off When amdgpu.dc=1

2018-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107333 --- Comment #3 from Matias N. Goldberg --- I think I'm having the same problem. I'll first describe my symptoms (all of them happening with DC=1): Case 1: 1. Boot System 2. Monitors must be off by the time GRUB inits the kernel. 3. Wait until

Re: [PATCH v2 5/8] dt-bindings: display: add data-enable polarity property

2018-09-26 Thread Rob Herring
On Wed, 12 Sep 2018 11:32:19 -0700, Stefan Agner wrote: > Allow to specify the data-enable polarity required by a dumb VGA > DAC converting parallel RGB to VGA. > > Signed-off-by: Stefan Agner > --- > .../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 2 ++ > 1 file changed, 2

[PATCH 1/2] drm/fsl-dcu: drop unused drm_crtc_index()

2018-09-26 Thread Stefan Agner
The result of drm_crtc_index() is unused. Remove the call and the unused variable. Signed-off-by: Stefan Agner --- This is a split version of a patch posted a while ago: https://lore.kernel.org/patchwork/patch/903786/ drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 3 +-- 1 file changed, 1

[PATCH 2/2] drm/fsl-dcu: use drm_display_mode_to_videomode to calculate timing parameters

2018-09-26 Thread Stefan Agner
From: Satendra Singh Thakur Use the drm_display_mode_to_videomode function to calculate front/ back porches and sync length. Cc: Madhur Verma Cc: Hemanshu Srivastava Signed-off-by: Satendra Singh Thakur Signed-off-by: Stefan Agner --- drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_crtc.c | 32

Re: [PATCH v3 09/11] drm/fsl-dcu: Use drm_fb_cma_fbdev_init/fini()

2018-09-26 Thread Stefan Agner
On 08.12.2017 20:37, Noralf Trønnes wrote: > Use drm_fb_cma_fbdev_init() and drm_fb_cma_fbdev_fini() which relies on > the fact that drm_device holds a pointer to the drm_fb_helper structure. > This means that the driver doesn't have to keep track of that. > Also use the drm_fb_helper functions

Re: [RESEND PATCH] drm/fsl-dcu: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Stefan Agner
On 26.09.2018 13:43, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. Applied! -- Stefan > > Signed-off-by: Thomas Zimmermann > --- >

Re: [RESEND 0/5] drm/mxsfb: Fix runtime PM for unpowering lcdif block

2018-09-26 Thread Stefan Agner
On 20.09.2018 18:39, Sean Paul wrote: > On Thu, Sep 20, 2018 at 11:59 AM Leonard Crestez > wrote: >> >> On Mon, 2018-09-17 at 16:37 -0700, Stefan Agner wrote: >> > On 17.09.2018 12:16, Sean Paul wrote: >> > > On Mon, Sep 17, 2018 at 04:42:10PM +0300, Leonard Crestez wrote: >> > > > Adding lcdif

[PATCH 15/15] staging: vboxvideo: Use more drm_fb_helper functions

2018-09-26 Thread Hans de Goede
Store fbhelper and afb struct directly in vbox_private and use drm_fb_helper_fbdev_setup to replace vbox_fbdev_init, note we cannot use drm_fb_helper_fbdev_teardown since we use a private framebuffer for the fbdev. And replace vbox_driver_lastclose with drm_fb_helper_lastclose. Signed-off-by:

[PATCH 13/15] staging: vboxvideo: Call drm_atomic_helper_check_plane_state from atomic_check

2018-09-26 Thread Hans de Goede
Extend our planes atomic_check callbacks to be more thorough by calling the drm_atomic_helper_check_plane_state helper. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_mode.c | 30 ++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git

[PATCH 14/15] staging: vboxvideo: Drop unnecessary drm_connector_helper_funcs callbacks

2018-09-26 Thread Hans de Goede
vbox_mode_valid always returns MODE_OK, which is also the default if no mode_valid callback is defined. vbox_best_single_encoder chains to drm_encoder_find, the drm-core will call drm_encoder_find itself if there is no best_encoder call back. Signed-off-by: Hans de Goede ---

[PATCH 09/15] staging: vboxvideo: Atomic phase 3: Switch last bits over to atomic

2018-09-26 Thread Hans de Goede
Now that the state objects are wired up, we can: 1) Move to the final atomic handlers 2) Wire up atomic set_config helper 3) Switch to drm_mode_config_helper_suspend/resume for suspend/resume 4) Enable atomic modesetting ioctl This is all done in one commit because doing this piecemeal leads to

[PATCH 08/15] staging: vboxvideo: Atomic phase 2: Stop using plane->fb and crtc->*

2018-09-26 Thread Hans de Goede
Once we are fully atomic plane->fb will always be NULL and we also should not access things like crtc->enabled and crt->[hw]mode. Now that we've wired up the state object handlers, we always have a plane_state and crtc_state so change the code referencing plane->fb and crtc->* to use the data

[PATCH 12/15] staging: vboxvideo: Replace crtc_helper enable/disable functions

2018-09-26 Thread Hans de Goede
Replace vbox_crtc_commit and vbox_crtc_disable with vbox_crtc_atomic_[en|dis]able which are the preferred callbacks for these for atomic drivers. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_mode.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git

[PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion

2018-09-26 Thread Hans de Goede
Atomic modesetting does not use the traditional dpms call backs, instead we should check crtc_state->active. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_drv.h | 1 - drivers/staging/vboxvideo/vbox_mode.c | 28 ++- 2 files changed, 2 insertions(+),

[PATCH 10/15] staging: vboxvideo: Restore page-flip support

2018-09-26 Thread Hans de Goede
Restore page-flip support now that the atomic conversion is complete. Since the mode parameter to vbox_crtc_set_base_and_mode() now never is NULL call drm_atomic_crtc_needs_modeset() to check if we need to check for input-mapping changes, to avoid doing unnecesarry work on a flip. And hookup the

[PATCH 01/15] staging: vboxvideo: Cleanup vbox_set_up_input_mapping()

2018-09-26 Thread Hans de Goede
This cleanups 2 things: 1) The first time we loop over the crtc-s, to compare framebuffers, fb1 may get set to NULL by the fb1 = CRTC_FB(crtci); statement and then we call to_vbox_framebuffer() on it. The result of this call is only used for an address comparison, so we don't end up dereferencing

[PATCH 07/15] staging: vboxvideo: Atomic phase 2: Wire up state object handlers

2018-09-26 Thread Hans de Goede
Wire up state object handlers for the crtc-s and the planes, call drm_mode_config_reset() after creating all the crtc-s and encoders and remove the legacy drm_helper_disable_unused_functions() call. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_fb.c | 3 ---

[PATCH 06/15] staging: vboxvideo: Atomic phase 1: Use drm_plane_helpers for primary plane

2018-09-26 Thread Hans de Goede
Use drm_plane_helpers for the primary plane and replace our custom mode_set callback with drm_helper_crtc_mode_set. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_mode.c | 116 -- 1 file changed, 90 insertions(+), 26 deletions(-) diff --git

[PATCH 05/15] staging: vboxvideo: Atomic phase 1: convert cursor to universal plane

2018-09-26 Thread Hans de Goede
In preparation for atomic conversion, let's use the transitional atomic helpers drm_plane_helper_update/disable. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_drv.h | 5 - drivers/staging/vboxvideo/vbox_mode.c | 386 +- 2 files changed, 186

[PATCH 02/15] staging: vboxvideo: Remove empty encoder_helper_funcs

2018-09-26 Thread Hans de Goede
All the encoder_helper_funcs are optional, and even setting the drm_encoder_helper_funcs vtable itself is optional and may be left out when not using any of the helper funcs, so lets drop all of this. Signed-off-by: Hans de Goede --- drivers/staging/vboxvideo/vbox_mode.c | 34

[PATCH 04/15] staging: vboxvideo: Cache mode width, height and crtc panning in vbox_crtc

2018-09-26 Thread Hans de Goede
When setting a mode we not only pass the mode to the hypervisor, but also information on how to map / translate input coordinates for the emulated USB tablet. This input-mapping may change when the mode on *another* crtc changes. This means that sometimes we must do a modeset on other crtc-s

[PATCH 03/15] staging: vboxvideo: Temporarily remove page_flip support

2018-09-26 Thread Hans de Goede
drm_mode_page_flip_ioctl() cannot deal with the in between phase of the transitioning to atomic modeset support. Once we start using drm_helper_crtc_mode_set(), we start setting plane->state on the primary plane. But we are not fully atomic yet so then set both plane-state->fb and plane->fb. If

[PATCH 01/15] staging: vboxvideo: Convert to atomic modesetting API

2018-09-26 Thread Hans de Goede
Hi All, This series converts the vboxvideo driver to the modesetting API, once this is merged I will submit a patch to move the driver out of staging and into drivers/gpu/drm. This series consists of 3 parts: 1) More cleanups / prep work for atomic conversion 2) The actual atomic conversion,

[PATCH] drm/imx: fix build failure without CONFIG_DRM_FBDEV_EMULATION

2018-09-26 Thread Arnd Bergmann
The variable is declared in an #ifdef section, but the user is now unconditional, which leads to a build failure: drivers/gpu/drm/imx/imx-drm-core.c: In function 'imx_drm_bind': drivers/gpu/drm/imx/imx-drm-core.c:264:6: error: 'legacyfb_depth' undeclared (first use in this function); did you

[Bug 106940] Black screen on KMS with 4.18.0-rc1 with Kaveri+Topaz, amdgpu, dc=1

2018-09-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106940 --- Comment #42 from SET --- (In reply to Andrey Arapov from comment #41) > Not sure if that helps, but could you try reverting this commit? > https://github.com/torvalds/linux/commit/ > e03fd3f300f6184c1264186a4c815e93bf658abb > Reverted

[PATCH] drm/ttm, drm/vmwgfx: Move the lock- and object functionality to the vmwgfx driver

2018-09-26 Thread Thomas Hellstrom
No other driver is using this functionality so move it out of TTM and into the vmwgfx driver. Update includes and remove exports. Also annotate to remove false static analyzer lock balance warnings. Cc: Christian König Signed-off-by: Thomas Hellstrom --- drivers/gpu/drm/ttm/Makefile

[radeon-alex:drm-next-4.20-wip 53/66] drivers/gpu//drm/etnaviv/etnaviv_sched.c:108:35: error: 'struct drm_sched_job' has no member named 'work_tdr'

2018-09-26 Thread kbuild test robot
tree: git://people.freedesktop.org/~agd5f/linux.git drm-next-4.20-wip head: 1ab9810fb590adf8f5a26271cc639ccfb98cb9eb commit: d730e7e9d36a4a0e7e7c9efbf5c735bf0098358d [53/66] drm/scheduler: remove timeout work_struct from drm_sched_job config: arm-allmodconfig (attached as .config) compiler:

Re: [PATCH] pci: Add a few new IDs for Intel GPU "spurious interrupt" quirk

2018-09-26 Thread Bjorn Helgaas
[+cc Intel DRM maintainers, etc] On Wed, Sep 26, 2018 at 08:14:01AM -0700, Bin Meng wrote: > Add more PCI IDs to the Intel GPU "spurious interrupt" quirk table, > which are known to break. Do you have a reference for this? Any public bug reports, bugzilla, Intel spec reference or errata?

Re: [PATCH] video/fbdev/stifb: Fix spelling mistake in fall-through annotation

2018-09-26 Thread Bartlomiej Zolnierkiewicz
On 09/03/2018 10:07 PM, Gustavo A. R. Silva wrote: > Replace "fall though" with a proper "fall through" annotation. > > This fix is part of the ongoing efforts to enabling > -Wimplicit-fallthrough > > Addresses-Coverity-ID: 402013 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH -next 10/18] drm/ttm: Make the object handles idr-generated

2018-09-26 Thread Christian König
Am 26.09.2018 um 18:46 schrieb Thomas Hellstrom: On 09/26/2018 06:36 PM, Christian König wrote: Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Instead of generating user-space object handles based on a, possibly processed, hash of the kernel address of the object, use idr to generate and

Re: [PATCH -next 12/18] drm/ttm: Export ttm_bo_reference_unless_doomed()

2018-09-26 Thread Christian König
Am 26.09.2018 um 18:43 schrieb Thomas Hellstrom: On 09/26/2018 06:35 PM, Christian König wrote: Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Export ttm_bo_reference_unless_doomed() to be used when looking up buffer objects that are removed from the lookup structure in the destructor. Cc:

Re: [PATCH -next 10/18] drm/ttm: Make the object handles idr-generated

2018-09-26 Thread Thomas Hellstrom
On 09/26/2018 06:36 PM, Christian König wrote: Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Instead of generating user-space object handles based on a, possibly processed, hash of the kernel address of the object, use idr to generate and lookup those handles. This might improve somewhat on

Re: [PATCH -next 12/18] drm/ttm: Export ttm_bo_reference_unless_doomed()

2018-09-26 Thread Thomas Hellstrom
On 09/26/2018 06:35 PM, Christian König wrote: Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Export ttm_bo_reference_unless_doomed() to be used when looking up buffer objects that are removed from the lookup structure in the destructor. Cc: Christian König Signed-off-by: Thomas Hellstrom

Re: [PATCH] DRM: VBLANK: provide valid timestamp for EVENT_FLIP

2018-09-26 Thread Ville Syrjälä
On Wed, Sep 26, 2018 at 05:25:35PM +0300, Eugeniy Paltsev wrote: > If driver/HW doesn't support vblank functionality (for example > UDL driver, ARCPGU driver, ...) we always have vblank->time == 0. > In result we always provide zero timestamp for > DRM_EVENT_FLIP_COMPLETE. This breaks userspace

Re: [PATCH -next 10/18] drm/ttm: Make the object handles idr-generated

2018-09-26 Thread Christian König
Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Instead of generating user-space object handles based on a, possibly processed, hash of the kernel address of the object, use idr to generate and lookup those handles. This might improve somewhat on security since we loose all connections to the

Re: [PATCH -next 12/18] drm/ttm: Export ttm_bo_reference_unless_doomed()

2018-09-26 Thread Christian König
Am 26.09.2018 um 18:18 schrieb Thomas Hellstrom: Export ttm_bo_reference_unless_doomed() to be used when looking up buffer objects that are removed from the lookup structure in the destructor. Cc: Christian König Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh ---

Re: [Freedreno] [PATCH v3 2/3] drm/msm: Replace drm_gem_object_{un/reference} with put, get functions

2018-09-26 Thread Jordan Crouse
On Wed, Sep 26, 2018 at 01:48:58PM +0200, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_gem_object. The resulting code is more aligned with the > rest of the Linux kernel interfaces. Reviewed-by: Jordan Crouse > Signed-off-by:

[PATCH -next 14/18] drm/vmwgfx: Look up user buffer objects without taking a reference

2018-09-26 Thread Thomas Hellstrom
Identically to how we look up ttm base objects witout reference, provide the same functionality to vmw user buffer objects which derive from them. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_bo.c | 41 +

[PATCH -next 18/18] drm/vmwgfx: Make user resource lookups reference-free during validation

2018-09-26 Thread Thomas Hellstrom
Make the process of looking up a user resource and adding it to the validation list reference-free unless when it's actually added to the validation list where a single reference is taken. This saves two locked atomic operations per command stream buffer object handle lookup, unless there is a

[PATCH -next 13/18] drm/vmwgfx: Adapt validation code for reference-free lookups

2018-09-26 Thread Thomas Hellstrom
Adapt the validation code so that vmw_validation_add[res|bo] can be called under an rcu read lock (non-sleeping) and with rcu-only protected resource- or buffer object pointers. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_validation.c | 61

[PATCH -next 15/18] drm/vmwgfx: Make buffer object lookups reference-free during validation

2018-09-26 Thread Thomas Hellstrom
Make the process of looking up a buffer object and adding it to the validation list reference-free unless when it's actually added to the validation list where a single reference is taken. This saves two locked atomic operations per command stream buffer object handle lookup. Signed-off-by:

[PATCH -next 12/18] drm/ttm: Export ttm_bo_reference_unless_doomed()

2018-09-26 Thread Thomas Hellstrom
Export ttm_bo_reference_unless_doomed() to be used when looking up buffer objects that are removed from the lookup structure in the destructor. Cc: Christian König Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 3 +--

[PATCH -next 16/18] drm/vmwgfx: Don't refcount command-buffer managed resource lookups during command buffer validation

2018-09-26 Thread Thomas Hellstrom
The typical pattern of these lookups are -Lookup -Put on validate list if not already there. -Unreference And since we are the exclusive user of the context during lookup time, we can be sure that the resource will stay alive during the sequence. So avoid taking a reference during lookup, and also

[PATCH -next 11/18] drm/ttm: Look up objects without taking a reference

2018-09-26 Thread Thomas Hellstrom
Typically when we look up objects under the rcu lock, we take a reference to make sure the returned object pointer is valid. Now provide a function to look up an object and instead of taking a reference to it, keep the rcu lock held when returning the object pointer. This means that the object

[PATCH -next 17/18] drm/vmwgfx: Don't refcount cotable lookups during command buffer validation

2018-09-26 Thread Thomas Hellstrom
The typical pattern of these lookups are -Lookup -Put on validate list if not already there. -Unreference And since we are the exclusive user of the context during lookup time, we can be sure that the resource will stay alive during the sequence. So avoid taking a reference during lookup, and also

[PATCH -next 07/18] drm/vmwgfx: Replace unconditional mutex unlocked warnings with lockdep counterpart

2018-09-26 Thread Thomas Hellstrom
Replace instances of WARN_ON[_ONCE](!mutex_is_held()) with lockdep_assert_held(). This makes sure the checking process actually holds the mutex and also removes the checks from release builds Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat ---

[PATCH -next 05/18] drm/vmwgfx: Use a validation context allocator for relocations and validations

2018-09-26 Thread Thomas Hellstrom
A common trait of these objects are that they are allocated during the command validation phase and freed after command submission. Furthermore they are accessed by a single thread only. So provide a simple unprotected stack-like allocator from which these objects can be allocated. Their memory is

[PATCH -next 10/18] drm/ttm: Make the object handles idr-generated

2018-09-26 Thread Thomas Hellstrom
Instead of generating user-space object handles based on a, possibly processed, hash of the kernel address of the object, use idr to generate and lookup those handles. This might improve somewhat on security since we loose all connections to the object's kernel address. Also idr is designed to do

[PATCH -next 08/18] drm/vmwgfx: Remove the resource avail field

2018-09-26 Thread Thomas Hellstrom
This field was previously used to prevent a lookup of a resource before its constructor had run to its end. This was mainly intended for an interface that is now removed that allowed looking up a resource by its device id. Currently all affected resources are added to the lookup mechanism (its

[PATCH -next 06/18] drm/vmwgfx: Reduce the size of buffer object relocations

2018-09-26 Thread Thomas Hellstrom
With the new allocator this leads to less consumed memory for each user-space command submission Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat --- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

[PATCH -next 09/18] drm/vmwgfx: Remove the user resource destructor check

2018-09-26 Thread Thomas Hellstrom
We were checking that the resource destructor matched that of the intended object type, to make sure the looked up resource was of the right type. But we already have an object type check in place which makes sure the resource is of the right type. Signed-off-by: Thomas Hellstrom Reviewed-by:

[PATCH -next 04/18] drm/vmwgfx: Use new validation interface for the modesetting code v2

2018-09-26 Thread Thomas Hellstrom
Strip the old KMS helpers and use the new validation interface also in the modesetting code. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat #v1 Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 199 ---

[PATCH -next 03/18] drm/vmwgfx: Adapt execbuf to the new validation api

2018-09-26 Thread Thomas Hellstrom
Strip the old execbuf validation functionality and use the new API instead. Also use the new API for a now removed execbuf function that was called from the kms code. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h | 65 ++-

[PATCH -next 02/18] drm/vmwgfx: Modify the resource validation interface

2018-09-26 Thread Thomas Hellstrom
Allow selecting interruptible or uninterruptible waits to match expectations of callers. Signed-off-by: Thomas Hellstrom Reviewed-by: Deepak Rawat Reviewed-by: Sinclair Yeh --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.h| 2 +- drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c| 2 +-

[PATCH -next 01/18] drm/vmwgfx: Add a validation module v2

2018-09-26 Thread Thomas Hellstrom
Isolate the functionality needed for reservation, validation and fencing of vmwgfx buffer objects and resources and publish an API for this. Signed-off-by: Thomas Hellstrom Reviewed-by: Sinclair Yeh Reviewed-by: Deepak Rawat #v1 --- drivers/gpu/drm/vmwgfx/Makefile| 3 +-

Re: uvesafb: Fix URLs in the documentation

2018-09-26 Thread Bartlomiej Zolnierkiewicz
On 09/22/2018 05:45 AM, Randy Dunlap wrote: > Hi, Hi, > I just noticed that the uvesafb.txt file needs to be updated > and then I found that Adam Jackson sent a patch for it last October. > > patch: > https://marc.info/?l=linux-fbdev=150765722422257=2 I was not on Cc: so I managed to miss it

Re: [PATCH] efifb: BGRT: Add nobgrt option

2018-09-26 Thread Bartlomiej Zolnierkiewicz
On 09/13/2018 08:51 AM, David Herrmann wrote: > Hi > > On Wed, Sep 12, 2018 at 11:12 AM Hans de Goede wrote: >> >> In some setups restoring the BGRT logo is undesirable, allow passing >> video=efifb:nobgrt on the kernel commandline to disable it. >> >> Cc: David Herrmann >> Reported-by: David

Re: [PATCH v2] drm/scheduler: remove timeout work_struct from drm_sched_job

2018-09-26 Thread Nayan Deshmukh
Hi Christian, On Wed, Sep 26, 2018, 10:13 AM Christian König < ckoenig.leichtzumer...@gmail.com> wrote: > Am 26.09.2018 um 09:39 schrieb Lucas Stach: > > Hi Nayan, > > > > Am Mittwoch, den 26.09.2018, 02:09 +0900 schrieb Nayan Deshmukh: > >> having a delayed work item per job is redundant as we

Re: [PATCH] fbdev/omapfb: fix omapfb_memory_read infoleak

2018-09-26 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel@lists.freedesktop.org to Cc: ] On 09/12/2018 09:30 AM, Tomi Valkeinen wrote: > OMAPFB_MEMORY_READ ioctl reads pixels from the LCD's memory and copies > them to a userspace buffer. The code has two issues: > > - The user provided width and height could be large enough to

Re: [PATCH] pxa168fb: prepare the clock

2018-09-26 Thread Bartlomiej Zolnierkiewicz
[ added dri-devel@lists.freedesktop.org to Cc: ] On 09/10/2018 02:03 PM, Lubomir Rintel wrote: Some description (besides kernel warning itself) saying what the patch is actually doing would be nice so I've updated the patch with: Add missing prepare/unprepare operations for fbi->clk,

Re: [PATCH v1] drm/tegra: Detach devices from IOMMU DMA domain on arm32

2018-09-26 Thread Thierry Reding
On Sun, Aug 19, 2018 at 05:24:20PM +0300, Dmitry Osipenko wrote: > All Tegra DRM devices are getting attached to an implicit IOMMU DMA > domain if CONFIG_ARM_DMA_USE_IOMMU=y. Since Tegra DRM driver manages IOMMU > by itself, the devices must be detached from the implicit domain using >

Re: [PATCH v3] gpu: host1x: Detach Host1x from IOMMU DMA domain on arm32

2018-09-26 Thread Thierry Reding
On Thu, Aug 30, 2018 at 03:12:47AM +0300, Dmitry Osipenko wrote: > Host1x is getting attached to an implicit IOMMU DMA domain if > CONFIG_ARM_DMA_USE_IOMMU=y. Since Host1x driver manages IOMMU by > itself, Host1x device must be detached from the implicit domain using > arch-specific IOMMU-API. >

Re: [PATCH v2] drm/tegra: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thierry Reding
On Wed, Sep 26, 2018 at 01:56:40PM +0200, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > v2: > * rebased onto 'drm/tegra: kick out

[PATCH v4 4/4] drm/tinydrm: Switch from CMA to shmem buffers

2018-09-26 Thread Noralf Trønnes
This move makes tinydrm useful for more drivers. tinydrm doesn't need continuous memory, but at the time it was convenient to use the CMA library. The spi core can do dma on is_vmalloc() addresses making this possible. Cc: David Lechner Signed-off-by: Noralf Trønnes Acked-by: David Lechner

[PATCH v4 0/4] drm: Add shmem GEM library

2018-09-26 Thread Noralf Trønnes
This patchset adds a library for shmem backed GEM objects and makes use of it in tinydrm. Thomas gave me some feedback that made me realise that the cachemodes pattern I had picked up from some other drivers didn't apply to shmem buffers in the way I though it did. So it's removed. I recently

[PATCH v4 3/4] drm: Add library for shmem backed GEM objects

2018-09-26 Thread Noralf Trønnes
This adds a library for shmem backed GEM objects. Signed-off-by: Noralf Trønnes --- Changes since version 3: - Drop cache modes (Thomas Hellstrom) - Add a GEM attached vtable Documentation/gpu/drm-kms-helpers.rst | 12 + drivers/gpu/drm/Kconfig| 6 +

[PATCH v4 2/4] drm/gem: Add drm_gem_object_funcs

2018-09-26 Thread Noralf Trønnes
This adds an optional function table on GEM objects. The main benefit is for drivers that support more than one type of memory (shmem,vram,cma) for their buffers depending on the hardware it runs on. With the callbacks attached to the GEM object itself, it is easier to have core helpers for the

[PATCH v4 1/4] drm/driver: Add defaults for .gem_prime_export/import callbacks

2018-09-26 Thread Noralf Trønnes
The majority of drivers use drm_gem_prime_export() and drm_gem_prime_import() for these callbacks so let's make them the default. Signed-off-by: Noralf Trønnes --- Documentation/gpu/todo.rst | 7 +++ drivers/gpu/drm/drm_prime.c | 10 -- include/drm/drm_drv.h | 4 3

Re: [PATCH] drm/syncobj: Don't leak fences when WAIT_FOR_SUBMIT is set

2018-09-26 Thread Sean Paul
On Wed, Sep 26, 2018 at 02:17:03AM -0500, Jason Ekstrand wrote: > We attempt to get fences earlier in the hopes that everything will > already have fences and no callbacks will be needed. If we do succeed > in getting a fence, getting one a second time will result in a duplicate > ref with no

Re: [PATCH] gpu: host1x: Remove redundant of_dma_configure() call

2018-09-26 Thread Robin Murphy
On 26/09/18 15:13, Thierry Reding wrote: On Wed, Sep 26, 2018 at 04:10:54PM +0200, Thierry Reding wrote: On Wed, Sep 12, 2018 at 05:47:54PM +0100, Robin Murphy wrote: Now that the Host1x bus_type implements a .dma_configure callback, subdevices should automatically get configured for DMA as

[PATCH] DRM: VBLANK: provide valid timestamp for EVENT_FLIP

2018-09-26 Thread Eugeniy Paltsev
If driver/HW doesn't support vblank functionality (for example UDL driver, ARCPGU driver, ...) we always have vblank->time == 0. In result we always provide zero timestamp for DRM_EVENT_FLIP_COMPLETE. This breaks userspace apps (for example weston) which relies on timestamp value. Setup time to

Re: [PATCH] MAINTAINERS: Move fsl-dcu driver to drm-misc tree

2018-09-26 Thread Stefan Agner
On 26.09.2018 15:39, Sean Paul wrote: > On Wed, Sep 26, 2018 at 02:50:34PM +0200, Stefan Agner wrote: >> The driver is mostly in maintenance mode. > > Is the status still Supported, then? > Yeah Supported as defined in MAINTAINERS is still accurate. Its just that we do not add features at that

Re: [PATCH] gpu: host1x: Remove redundant of_dma_configure() call

2018-09-26 Thread Thierry Reding
On Wed, Sep 26, 2018 at 04:10:54PM +0200, Thierry Reding wrote: > On Wed, Sep 12, 2018 at 05:47:54PM +0100, Robin Murphy wrote: > > Now that the Host1x bus_type implements a .dma_configure callback, > > subdevices should automatically get configured for DMA as their drivers > > bind, so there's no

Re: [PATCH] gpu: host1x: Remove redundant of_dma_configure() call

2018-09-26 Thread Thierry Reding
On Wed, Sep 12, 2018 at 05:47:54PM +0100, Robin Murphy wrote: > Now that the Host1x bus_type implements a .dma_configure callback, > subdevices should automatically get configured for DMA as their drivers > bind, so there's no need to also force it at device creation time. > > CC: Thierry Reding

Re: [PATCH] MAINTAINERS: Move fsl-dcu driver to drm-misc tree

2018-09-26 Thread Sean Paul
On Wed, Sep 26, 2018 at 02:50:34PM +0200, Stefan Agner wrote: > The driver is mostly in maintenance mode. Is the status still Supported, then? > Using drm-misc is a > good fit and should make maintenance a bit easier. > > Signed-off-by: Stefan Agner Acked-by: Sean Paul > --- > MAINTAINERS

Re: [RESEND PATCH] drm/udl: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Sean Paul
On Wed, Sep 26, 2018 at 02:02:12PM +0200, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann Applied to

Re: [PATCH] drm/omap: fix use of freed memory

2018-09-26 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Wednesday, 26 September 2018 13:05:59 EEST Tomi Valkeinen wrote: > omap_connector_destroy() does: > > kfree(omap_connector); > omapdss_device_put(omap_connector->output); > omapdss_device_put(omap_connector->display); > > Fix this by moving the kfree after

Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Laurent Pinchart
Hi Thomas, On Wednesday, 26 September 2018 15:26:38 EEST Thomas Zimmermann wrote: > Hi, > > thanks for reviewing the patch and the one for rcar-du. Please also add > them to your tree. I took both patches in my tree. Thank you. > Am 26.09.18 um 14:14 schrieb Kieran Bingham: > > On 26/09/18

[PATCH] MAINTAINERS: Move fsl-dcu driver to drm-misc tree

2018-09-26 Thread Stefan Agner
The driver is mostly in maintenance mode. Using drm-misc is a good fit and should make maintenance a bit easier. Signed-off-by: Stefan Agner --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 02a39617ec82..6646a3d098a1 100644 --- a/MAINTAINERS

Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

2018-09-26 Thread Sandy Huang
Hi heiko, nice solution. Reviewed-by: Sandy Huang 在 2018/9/23 20:37, Heiko Stuebner 写道: The hs_start interrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as the dsp_hold_valid irq in checking when the last frame got delivered when going to standby. So

Re: [PATCH] drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent

2018-09-26 Thread Sandy Huang
Hi heiko, nice solution. Reviewed-by: Sandy Huang 在 2018/9/23 20:37, Heiko Stuebner 写道: The hs_start interrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as the dsp_hold_valid irq in checking when the last frame got delivered when going to standby. So

Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
Hi, thanks for reviewing the patch and the one for rcar-du. Please also add them to your tree. Best regards Thomas Am 26.09.18 um 14:14 schrieb Kieran Bingham: > Hi Thomas, > > Thank you for the patch, > > On 26/09/18 12:55, Thomas Zimmermann wrote: >> This patch unifies the naming of DRM

Re: [RESEND PATCH] drm/tve200: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
Hi Am 26.09.18 um 14:14 schrieb Linus Walleij: > On Wed, Sep 26, 2018 at 2:00 PM Thomas Zimmermann wrote: > >> This patch unifies the naming of DRM functions for reference counting >> of struct drm_device. The resulting code is more aligned with the rest >> of the Linux kernel interfaces. >> >>

Re: [RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Kieran Bingham
Hi Thomas, Thank you for the patch, On 26/09/18 12:55, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann

Re: [RESEND PATCH] drm/tve200: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Linus Walleij
On Wed, Sep 26, 2018 at 2:00 PM Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces. > > Signed-off-by: Thomas Zimmermann > Reviewed-by: Linus

Re: [RESEND PATCH] drm/rcar-du: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Kieran Bingham
Hi Thomas, Thank you for the patch, On 26/09/18 12:53, Thomas Zimmermann wrote: > This patch unifies the naming of DRM functions for reference counting > of struct drm_device. The resulting code is more aligned with the rest > of the Linux kernel interfaces.> Signed-off-by: Thomas Zimmermann >

Re: 4096x2160 monitor has EDID reporting 3840x2160

2018-09-26 Thread Ville Syrjälä
On Wed, Sep 26, 2018 at 02:27:54PM +0300, Jani Nikula wrote: > On Mon, 24 Sep 2018, Brian Vincent wrote: > > Thank you for your reply. I took your advice and tried it. None of it > > really surprises me. > > > > The problem seems pretty simple. There is simply nothing in the EDID that > >

[RESEND PATCH] drm/zte: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann Acked-by: Shawn Guo --- drivers/gpu/drm/zte/zx_drm_drv.c | 4 ++-- 1 file changed, 2

[RESEND PATCH] drm/udl: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/udl/udl_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[RESEND PATCH] drm/tve200: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann Reviewed-by: Linus Walleij --- drivers/gpu/drm/tve200/tve200_drv.c | 10 +- 1

[PATCH v2] drm/tegra: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. v2: * rebased onto 'drm/tegra: kick out simplefb' Signed-off-by: Thomas Zimmermann ---

[RESEND PATCH] drm/shmobile: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann Reviewed-by: Simon Horman --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 4 ++-- 1 file

[RESEND PATCH] drm/rcar-du: Replace drm_dev_unref with drm_dev_put

2018-09-26 Thread Thomas Zimmermann
This patch unifies the naming of DRM functions for reference counting of struct drm_device. The resulting code is more aligned with the rest of the Linux kernel interfaces. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/rcar-du/rcar_du_drv.c | 2 +- 1 file changed, 1 insertion(+), 1

  1   2   >