[Bug 108259] No Man's Sky - Shader issues with 2018-10-05 update

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108259 Jordan Patterson changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Bug 108309] Raven Ridge 2700U system lock-up on multiple games

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108309 --- Comment #3 from Samantha McVey --- Created attachment 142001 --> https://bugs.freedesktop.org/attachment.cgi?id=142001=edit dmesg Took some time to respond since I waited until I got more RAM to ensure there was no issue with running out

[Bug 108309] Raven Ridge 2700U system lock-up on multiple games

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108309 --- Comment #2 from Samantha McVey --- Created attachment 142000 --> https://bugs.freedesktop.org/attachment.cgi?id=142000=edit Xorg log -- You are receiving this mail because: You are the assignee for the

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 --- Comment #10 from bmil...@gmail.com --- https://www.phoronix.com/scan.php?page=news_item=AMD-V4-Adaptive-VRR-FreeSync Is this maybe related? -- You are receiving this mail because: You are the assignee for the

[PATCH] drm: Get ref on CRTC commit object when waiting for flip_done

2018-10-11 Thread sunpeng.li
From: Leo Li This fixes a general protection fault, caused by accessing the contents of a flip_done completion object that has already been freed. It occurs due to the preemption of a non-blocking commit worker thread W by another commit thread X. X continues to clear its atomic state at the

[PATCH libdrm] xf86drmHash: remove redundant zero init

2018-10-11 Thread Rob Clark
From: Rob Clark drmMalloc() is already calloc() Signed-off-by: Rob Clark --- Small micro-optimization that I noticed while doing some perf work.. I should probably look at promoting amdgpu's handle_table to core libdrm and replacing a couple of libdrm_freedreno's xf86drmHash tables over to

[Bug 108330] WarThunder game performance killed after Ryzen optimisations

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108330 Bug ID: 108330 Summary: WarThunder game performance killed after Ryzen optimisations Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All)

Re: [PATCH] drm: amd: Use kmemdup instead of duplicating its function

2018-10-11 Thread Felix Kuehling
Hi Zhong Jiang, Sorry for the late response. I just saw this while catching up with my backlog after travelling end of September. I applied your patch to amd-staging-drm-next. I only changed the headline slightly to use the "drm/admkfd: " prefix that we commonly use for KFD changes. Regards,  

Re: [PATCH v10 2/2] dt-bindings: Add Truly NT35597 panel driver bindings

2018-10-11 Thread Rob Herring
On Fri, 5 Oct 2018 17:52:19 -0700, Abhinav Kumar wrote: > Add the device tree bindings for Truly NT35597 panel driver. This panel > driver supports both single DSI and dual DSI. > > However, this patch series supports only dual DSI. > > Changes in v10: > - Remove active high in the

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-11 Thread Giulio Benetti
Hello Dan, Il 11/10/2018 09:16, Dan Carpenter ha scritto: This is an unreleased Smatch test because: 1) Some things return error pointers depending on the config. 2) Pointless IS_ERR() checks are quite common. Look forward for new Smatch, very useful. I haven't looked at the context to see

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #41 from Gregor Münch --- Thx for finally fixing this! Is there a chance a backport appears for LLVM 6 & 7 ? -- You are receiving this mail because: You are the assignee for the bug.___

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 04:56 PM, Kazlauskas, Nicholas wrote: > On 10/11/2018 04:39 PM, Harry Wentland wrote: >> On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: >>> Support for AMDGPU specific FreeSync properties and ioctls are dropped >>> from amdgpu_dm in favor of supporting drm variable refresh rate

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Kazlauskas, Nicholas
On 10/11/2018 04:39 PM, Harry Wentland wrote: On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The drm vrr_capable property is now attached to

[Bug 108111] Civilization VI Artifacts RX480

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108111 --- Comment #4 from Gregor Münch --- Fixed by https://cgit.freedesktop.org/mesa/mesa/commit/?id=0e6cdfd561c63d23e8ff32df4cab2370dc2a53d2 ? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Harry Wentland
On 2018-10-11 12:39 PM, Nicholas Kazlauskas wrote: > Support for AMDGPU specific FreeSync properties and ioctls are dropped > from amdgpu_dm in favor of supporting drm variable refresh rate > properties. > > The drm vrr_capable property is now attached to any DP/HDMI connector. > Its value is

[Bug 108321] rv610: corrupt shader output with SB if_conversion optimization pass

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108321 --- Comment #1 from Nicholas Bishop --- Created attachment 141999 --> https://bugs.freedesktop.org/attachment.cgi?id=141999=edit screenshot of the confetti graphics bug -- You are receiving this mail because: You are the assignee for the

[Bug 108259] No Man's Sky - Shader issues with 2018-10-05 update

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108259 --- Comment #1 from Gregor Münch --- Fixed by https://cgit.freedesktop.org/mesa/mesa/commit/?id=0346ad37741b11d640c1c4970b275c1f0c7f9e75 ? -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v12 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp

2018-10-11 Thread Radhakrishna Sripada
On Thu, Oct 11, 2018 at 12:55:15AM -0700, Lisovskiy, Stanislav wrote: > On Wed, 2018-10-10 at 17:12 -0700, Radhakrishna Sripada wrote: > > Use the newly added "max bpc" connector property to limit pipe bpp. > > > > V3: Use drm_connector_state to access the "max bpc" property > > V4: Initialize

[Bug 96618] include headers that define major/minor/makedev funcs

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=96618 Mike Frysinger changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 105712] intel-gpu-overlay is showing insane power consumption amounts

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105712 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #12 from Lakshmi ---

[Bug 104352] [IGT] gem_spin_batch@spin-each Failed assertion: !"GPU hung"

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=104352 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #15 from Lakshmi ---

[Bug 105190] gem_quiescent_gpu assertion fails on distribution kernels

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=105190 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #9 from Lakshmi ---

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:25 AM, Mike Lothian wrote: > Hi > > I'm curious to know whether this will/could work over PRIME > I don't see why this shouldn't work over PRIME as long as the presenting GPU supports the new variable refresh rate API, but I know very little about prime, so maybe someone else

[Bug 103365] [GLK] gem_fd_exhaustion produces file-max limit 377904 reached

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=103365 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from Lakshmi --- This

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 04:41 AM, Daniel Vetter wrote: > On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >> >> >> On 2018-10-01 03:15 AM, Daniel Vetter wrote: >>> On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas Kazlauskas wrote: These patches are part of a proposed new interface for

[Bug 99923] HITMAN (2016) having lighting and artefacting, and overly light room.

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=99923 --- Comment #40 from Nicolai Hähnle --- Root caused to a compute shader that does an out-of-bounds array access. Tsk tsk ;) Proper fix is at https://reviews.llvm.org/D53160 + related patches. -- You are receiving this mail because: You are

[Bug 102380] intel_gpu_top: Test requirement not met in function drm_open_driver_master, file drmtest.c:391:

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102380 Lakshmi changed: What|Removed |Added Status|RESOLVED|CLOSED --- Comment #2 from Lakshmi --- This

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Harry Wentland
On 2018-10-03 02:35 PM, Manasi Navare wrote: > On Wed, Oct 03, 2018 at 10:41:20AM +0200, Daniel Vetter wrote: >> On Tue, Oct 02, 2018 at 10:49:17AM -0400, Harry Wentland wrote: >>> >>> >>> On 2018-10-01 03:15 AM, Daniel Vetter wrote: On Mon, Sep 24, 2018 at 02:15:34PM -0400, Nicholas

[Bug 108329] [Polaris] amd-staging-drm-next has high pitch audio on 4k60hz HDMI output

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108329 --- Comment #3 from John Galt --- Created attachment 141998 --> https://bugs.freedesktop.org/attachment.cgi?id=141998=edit dmesg after booting, changing to 1080@60, changing to 4k@60, running a game to verify high pitch audio, then changing

[Bug 108329] [Polaris] amd-staging-drm-next has high pitch audio on 4k60hz HDMI output

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108329 --- Comment #2 from John Galt --- Created attachment 141997 --> https://bugs.freedesktop.org/attachment.cgi?id=141997=edit Xorg.0.log after booting, changing to 1080@60, changing to 4k@60, then changing back to 1080@60 -- You are receiving

[Bug 108329] [Polaris] amd-staging-drm-next has high pitch audio on 4k60hz HDMI output

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108329 --- Comment #1 from John Galt --- Created attachment 141996 --> https://bugs.freedesktop.org/attachment.cgi?id=141996=edit glxinfo output -- You are receiving this mail because: You are the assignee for the

[Bug 108329] [Polaris] amd-staging-drm-next has high pitch audio on 4k60hz HDMI output

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108329 Bug ID: 108329 Summary: [Polaris] amd-staging-drm-next has high pitch audio on 4k60hz HDMI output Product: DRI Version: DRI git Hardware: x86-64 (AMD64)

Re: [Freedreno] [DPU PATCH 2/3] drm/msm/dp: add displayPort driver support

2018-10-11 Thread Jordan Crouse
On Wed, Oct 10, 2018 at 10:15:58AM -0700, Chandan Uddaraju wrote: > Add the needed displayPort files to enable DP driver > on msm target. > > "dp_display" module is the main module that calls into > other sub-modules. "dp_drm" file represents the interface > between DRM framework and DP driver. >

Re: Dirty page-tacking with TTM

2018-10-11 Thread Koenig, Christian
Hi Thomas, yeah we had implemented something similar for the close source driver once as well. Just feel free to go ahead with providing the VM ops by the driver. Christian. Am 11.10.2018 um 19:17 schrieb Thomas Hellstrom: > Hi, Christian, > > I'm looking at adding a utility for tracking

[PATCH v2] drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

2018-10-11 Thread Abhinav Kumar
Fix the dsi clock names in the DSI 10nm PLL driver to match the names in the dispcc driver as those are according to the clock plan of the chipset. Changes in v2: - Update the clock diagram with the new clock name Signed-off-by: Abhinav Kumar --- drivers/gpu/drm/msm/dsi/pll/dsi_pll_10nm.c | 8

Dirty page-tacking with TTM

2018-10-11 Thread Thomas Hellstrom
Hi, Christian, I'm looking at adding a utility for tracking dirty pages for TTM. It's usable for non-coherent drivers to emulate coherent memory, for example for fbdev or if vmwgfx were to emulate coherent mappings, like required by Vulkan or by user-space dma-buf mappings. Basically one

Re: [PATCH] intel: Introducing Whiskey Lake platform

2018-10-11 Thread Rodrigo Vivi
On Sat, Oct 06, 2018 at 12:32:14PM +0100, Lionel Landwerlin wrote: > On 05/10/2018 22:29, Rodrigo Vivi wrote: > > Whiskey Lake uses the same gen graphics as Coffe Lake, including some > > ids that were previously marked as reserved on Coffe Lake, but that > > now are moved to WHL page. > > > >

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #11 from george --- (In reply to Shmerl from comment #10) > I just found something. My monitor - Dell U2413 has a setting for toggling > DisplayPort 1.2. It was enabled until now. When I disable that setting, tty > starts working! >

[PATCH v4 4/4] drm/amd/display: Set FreeSync state using drm VRR properties

2018-10-11 Thread Nicholas Kazlauskas
Support for AMDGPU specific FreeSync properties and ioctls are dropped from amdgpu_dm in favor of supporting drm variable refresh rate properties. The drm vrr_capable property is now attached to any DP/HDMI connector. Its value is updated accordingly to the connector's FreeSync capabiltiy. The

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort 1.2 monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 Shmerl changed: What|Removed |Added Summary|[amdgpu] Switching to tty |[amdgpu] Switching to tty

[PATCH v4 3/4] drm: Document variable refresh properties

2018-10-11 Thread Nicholas Kazlauskas
These include the drm_connector 'vrr_capable' and the drm_crtc 'vrr_enabled' properties. Signed-off-by: Nicholas Kazlauskas --- Documentation/gpu/drm-kms.rst | 7 +++ drivers/gpu/drm/drm_connector.c | 22 ++ 2 files changed, 29 insertions(+) diff --git

[PATCH v4 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-11 Thread Nicholas Kazlauskas
This patch introduces the 'vrr_enabled' CRTC property to allow dynamic control over variable refresh rate support for a CRTC. This property should be treated like a content hint to the driver - if the hardware or driver is not capable of driving variable refresh timings then this is not

[PATCH v4 1/4] drm: Add vrr_capable property to the drm connector

2018-10-11 Thread Nicholas Kazlauskas
Modern display hardware is capable of supporting variable refresh rates. This patch introduces the "vrr_capable" property on the connector to allow userspace to query support for variable refresh rates. Atomic drivers should attach this property to connectors that are capable of driving variable

[PATCH v4 0/4] A DRM API for adaptive sync and variable refresh rate support

2018-10-11 Thread Nicholas Kazlauskas
These patches are part of a proposed new interface for supporting variable refresh rate via DRM properties. === Changes from v3 === drm changes: * Docstring and formatting fixes amd/display changes: * Updated commit message and debug statements === Changes from v2 === The interface has

[Bug 107213] [amdgpu/DisplayPort] KDE Wayland session is segfaulting right after login

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107213 --- Comment #22 from Shmerl --- It looks like it's related to https://bugs.freedesktop.org/show_bug.cgi?id=107978 My monitor (Dell U2413) has a setting for toggling DisplayPort 1.2. When I disable it, Wayland Plasma session isn't crashing

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #10 from Shmerl --- I just found something. My monitor - Dell U2413 has a setting for toggling DisplayPort 1.2. It was enabled until now. When I disable that setting, tty starts working! My cable is supposed to support DP 1.2 and

Re: [PATCH v3 04/18] drm/selftest: Add drm damage helper selftest

2018-10-11 Thread Daniel Vetter
On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote: > Selftest for drm damage helper iterator functions. > > Cc: ville.syrj...@linux.intel.com > Cc: Daniel Vetter > Cc: Pekka Paalanen > Cc: Daniel Stone > Cc: intel-...@lists.freedesktop.org > Cc: igt-...@lists.freedesktop.org > Cc:

Re: [PATCH v3 05/18] drm: Add helper to implement legacy dirtyfb

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 06:15:47PM +0200, Daniel Vetter wrote: > On Wed, Oct 10, 2018 at 05:16:44PM -0700, Deepak Rawat wrote: > > From: Rob Clark > > > > Add an atomic helper to implement dirtyfb support. This is needed to > > support DSI command-mode panels with x11 userspace (ie. when we

Re: [PATCH 04/18] drm/selftest: Add drm damage helper selftest

2018-10-11 Thread Daniel Vetter
On Tue, Oct 09, 2018 at 10:43:04PM +, Deepak Singh Rawat wrote: > > drivers/gpu/drm/selftests/drm_damage_helper_selftests.h > > > create mode 100644 drivers/gpu/drm/selftests/test- > > drm_damage_helper.c > > > > > > diff --git a/drivers/gpu/drm/selftests/Makefile > >

Re: [PATCH v3 05/18] drm: Add helper to implement legacy dirtyfb

2018-10-11 Thread Daniel Vetter
On Wed, Oct 10, 2018 at 05:16:44PM -0700, Deepak Rawat wrote: > From: Rob Clark > > Add an atomic helper to implement dirtyfb support. This is needed to > support DSI command-mode panels with x11 userspace (ie. when we can't > rely on pageflips to trigger a flush to the panel). > > v2:

Re: [PATCH] pci: Add a few new IDs for Intel GPU "spurious interrupt" quirk

2018-10-11 Thread Bjorn Helgaas
On Thu, Oct 11, 2018 at 03:11:01PM +0800, Bin Meng wrote: > On Wed, Oct 10, 2018 at 1:02 AM Bjorn Helgaas wrote: > > On Mon, Oct 08, 2018 at 05:44:08PM +0800, Bin Meng wrote: > > > On Thu, Oct 4, 2018 at 4:12 AM Bjorn Helgaas wrote: > > > > On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng

Re: [PATCH v4] drm/msm: validate display and event threads

2018-10-11 Thread Sean Paul
On Wed, Oct 10, 2018 at 02:11:16PM -0700, Jeykumar Sankaran wrote: > While creating display and event threads per crtc, validate > them before setting their priorities. > > changes in v2: > - use dev_warn (Abhinav Kumar) > changes in v3: > - fix compilation error > changes in v4: >

Re: [PATCH] drm/msm/dsi: fix dsi clock names in DSI 10nm PLL driver

2018-10-11 Thread Sean Paul
On Wed, Oct 10, 2018 at 07:06:33PM -0700, Abhinav Kumar wrote: > Fix the dsi clock names in the DSI 10nm PLL driver to > match the names in the dispcc driver as those are > according to the clock plan of the chipset. You should also update the clock diagram names at the top of the file. Sean >

Re: [Freedreno] [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-10-11 Thread Jordan Crouse
On Thu, Oct 11, 2018 at 10:32:16AM +0530, Viresh Kumar wrote: > On 10-10-18, 09:10, Jordan Crouse wrote: > > On Wed, Oct 10, 2018 at 08:21:39PM +0530, Viresh Kumar wrote: > > > On 10-10-18, 08:48, Jordan Crouse wrote: > > > > qcom,level comes straight from: > > > > > > > >

Re: [Freedreno] [PATCH 01/25] drm/msm/dpu: fix hw ctl retrieval for mixer muxing

2018-10-11 Thread Sean Paul
On Wed, Oct 10, 2018 at 11:35:56AM -0700, Jeykumar Sankaran wrote: > On 2018-10-10 07:29, Sean Paul wrote: > > On Tue, Oct 09, 2018 at 10:46:41PM -0700, Jeykumar Sankaran wrote: > > > On 2018-10-09 11:07, Sean Paul wrote: > > > > On Mon, Oct 08, 2018 at 09:27:18PM -0700, Jeykumar Sankaran wrote: >

[Bug 107978] [amdgpu] Switching to tty fails with DisplayPort monitor going to sleep (REG_WAIT timeout / dce110_stream_encoder_dp_blank)

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107978 --- Comment #9 from Shmerl --- By the way, I tested it with this kernel: https://github.com/M-Bab/linux-kernel-amdgpu-binaries/blob/master/linux-image-4.19.0-rc6_18.09.30.amdgpu_amd64.deb Which is built from AMD's tree. This issue is also

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 2:53 PM Liviu Dudau wrote: > On Thu, Oct 11, 2018 at 02:40:10PM +0200, Daniel Vetter wrote: > > On Thu, Oct 11, 2018 at 12:11 PM Liviu Dudau wrote: > > > On Thu, Oct 11, 2018 at 10:58:30AM +0100, Alexandru-Cosmin Gheorghe wrote: > > > > On Thu, Oct 11, 2018 at 10:29:42AM

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Liviu Dudau
On Thu, Oct 11, 2018 at 02:40:10PM +0200, Daniel Vetter wrote: > On Thu, Oct 11, 2018 at 12:11 PM Liviu Dudau wrote: > > On Thu, Oct 11, 2018 at 10:58:30AM +0100, Alexandru-Cosmin Gheorghe wrote: > > > On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > > > > On Mon, Oct 08, 2018 at

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-11 Thread Arnd Bergmann
On 10/11/18, Rob Clark wrote: > On Thu, Oct 11, 2018 at 3:02 AM Arnd Bergmann wrote: >> >> On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: >> > >> > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: >> > > >> > > On 10/10/18, Rob Clark wrote: >> > > > BACKLIGHT_CLASS_DEVICE is already

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 12:11 PM Liviu Dudau wrote: > On Thu, Oct 11, 2018 at 10:58:30AM +0100, Alexandru-Cosmin Gheorghe wrote: > > On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > > > On Mon, Oct 08, 2018 at 09:52:04AM +, Alexandru-Cosmin Gheorghe wrote: > > > > > One

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-11 Thread Rob Clark
On Thu, Oct 11, 2018 at 3:02 AM Arnd Bergmann wrote: > > On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: > > > > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > > > > > On 10/10/18, Rob Clark wrote: > > > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > > > >

[bug report] drm/vmwgfx: Use new validation interface for the modesetting code v2

2018-10-11 Thread Dan Carpenter
Hello Thomas Hellstrom, The patch 2724b2d54cda: "drm/vmwgfx: Use new validation interface for the modesetting code v2" from Sep 26, 2018, leads to the following static checker warning: drivers/gpu/drm/vmwgfx/vmwgfx_kms.c:2606 vmw_kms_helper_validation_finish() error:

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-11 Thread Sam Ravnborg
> > > + if (IS_ERR(s6->supply)) > > > + return PTR_ERR(s6->supply); > > > > This cannot be -EPROBE_DEFER? > > It can and then it bails out here and retries later. > > I don't quite get the question, sorry. > > > > + if (IS_ERR(s6->reset_gpio)) { > > > + ret =

Re: [PATCH 2/2] drm/i915/gen9+: Add support for pipe background color

2018-10-11 Thread Ville Syrjälä
On Wed, Oct 10, 2018 at 04:50:51PM -0700, Matt Roper wrote: > Gen9+ platforms allow CRTC's to be programmed with a background/canvas > color below the programmable planes. Let's expose this for use by > compositors. > > Cc: dri-devel@lists.freedesktop.org > Cc: wei.c...@intel.com > Cc:

Re: [PATCH 1/2] drm: Add CRTC background color property

2018-10-11 Thread Ville Syrjälä
On Wed, Oct 10, 2018 at 04:50:50PM -0700, Matt Roper wrote: > Some display controllers can be programmed to present non-black colors > for pixels not covered by any plane (or pixels covered by the > transparent regions of higher planes). Compositors that want a UI with > a solid color background

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Liviu Dudau
On Thu, Oct 11, 2018 at 10:58:30AM +0100, Alexandru-Cosmin Gheorghe wrote: > On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > > On Mon, Oct 08, 2018 at 09:52:04AM +, Alexandru-Cosmin Gheorghe wrote: > > > Hi Daniel, > > > > > > Thanks for having a look. > > > > > > On Fri,

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 11:58 AM Alexandru-Cosmin Gheorghe wrote: > > On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > > On Mon, Oct 08, 2018 at 09:52:04AM +, Alexandru-Cosmin Gheorghe wrote: > > > Shouldn't that be enough for validating this patches? > > > > I don't think so,

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Alexandru-Cosmin Gheorghe
On Thu, Oct 11, 2018 at 10:29:42AM +0200, Daniel Vetter wrote: > On Mon, Oct 08, 2018 at 09:52:04AM +, Alexandru-Cosmin Gheorghe wrote: > > Hi Daniel, > > > > Thanks for having a look. > > > > On Fri, Oct 05, 2018 at 04:51:48PM +0200, Daniel Vetter wrote: > > > On Fri, Oct 05, 2018 at

Re: [PATCH 12/21] drm/sti: Use drm_atomic_helper_shutdown

2018-10-11 Thread Benjamin Gaignard
Le jeu. 11 oct. 2018 à 10:32, Daniel Vetter a écrit : > > On Mon, Oct 08, 2018 at 10:08:06AM +0200, Benjamin Gaignard wrote: > > Le ven. 5 oct. 2018 à 16:25, Daniel Vetter a écrit > > : > > > > > > On Fri, Oct 5, 2018 at 12:14 PM Benjamin Gaignard > > > wrote: > > > > > > > > From: Daniel

Re: [PATCH 2/2] drm/panel: Add driver for Samsung S6D16D0 panel

2018-10-11 Thread Linus Walleij
Hi Sam, thanks for your review! I fixed most issues. Just some open small questions: On Tue, Oct 9, 2018 at 9:43 PM Sam Ravnborg wrote: > > + dev_err(s6->dev, "failed to turn display off\n"); > > General comment: > dev_err => DRM_DEV_ERROR? > Should error message include the 'ret'

Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0

2018-10-11 Thread Andrzej Hajda
On 11.10.2018 10:48, Linus Walleij wrote: > On Tue, Oct 9, 2018 at 9:26 PM Sam Ravnborg wrote: >> On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote: >>> + - reset-gpios: a GPIO spec for the reset pin (active low) >> That it is active low is part of the GPIO part and should not >> be

Re: [PATCH] drm: Do not call drm_dp_cec_set_edid() while registering DP connectors

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 08:24:55AM +0200, Hans Verkuil wrote: > On 11/10/18 02:44, José Roberto de Souza wrote: > > drm_dp_cec_register_connector() is called when registering each DP > > connector in DRM, while sounds a good idea register CEC adapters as > > earlier as possible, it causes some

Re: [PATCH 1/2] drm/panel: Add DT bindings for Samsung S6D16D0

2018-10-11 Thread Linus Walleij
On Tue, Oct 9, 2018 at 9:26 PM Sam Ravnborg wrote: > On Mon, Oct 08, 2018 at 01:00:05PM +0200, Linus Walleij wrote: > > + - reset-gpios: a GPIO spec for the reset pin (active low) > > That it is active low is part of the GPIO part and should not > be mandated as part of the binding? The fact

Re: [PATCH -next] drm: Use PTR_ERR_OR_ZERO in drm_fb_cma_fbdev_init()

2018-10-11 Thread Daniel Vetter
On Wed, Oct 10, 2018 at 01:02:43PM +, YueHaibing wrote: > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Signed-off-by: YueHaibing Applied, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_fb_cma_helper.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-)

Re: [PATCH] drm/atomic_helper: Allow DPMS On<->Off changes for unregistered connectors

2018-10-11 Thread Daniel Vetter
On Wed, Oct 10, 2018 at 09:32:24PM +0300, Ville Syrjälä wrote: > On Tue, Oct 09, 2018 at 04:44:24PM -0400, Lyude Paul wrote: > > It appears when testing my previous fix for some of the legacy > > modesetting issues with MST, I misattributed some kernel splats that > > started appearing on my

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 Michel Dänzer changed: What|Removed |Added Attachment #141988|0 |1 is obsolete|

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 Michel Dänzer changed: What|Removed |Added Attachment #141985|0 |1 is obsolete|

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 Michel Dänzer changed: What|Removed |Added Attachment #141986|0 |1 is obsolete|

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 Michel Dänzer changed: What|Removed |Added Attachment #141987|0 |1 is obsolete|

[Bug 108322] RX580 Display flickering after waking from suspend

2018-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=108322 Michel Dänzer changed: What|Removed |Added Attachment #141991|text/x-log |text/plain mime type|

Re: [PATCH v7 1/5] drm/atomic_helper: Disallow new modesets on unregistered connectors

2018-10-11 Thread Daniel Vetter
On Tue, Oct 09, 2018 at 08:20:27PM +0300, Ville Syrjälä wrote: > On Mon, Oct 08, 2018 at 07:24:30PM -0400, Lyude Paul wrote: > > With the exception of modesets which would switch the DPMS state of a > > connector from on to off, we want to make sure that we disallow all > > modesets which would

Re: [PATCH] drm/drm_vblank: Change EINVAL by the correct errno

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 01:52:13PM -0300, Rodrigo Siqueira wrote: > On 10/08, Chris Wilson wrote: > > Quoting Rodrigo Siqueira (2018-10-08 15:52:20) > > > For historical reason, the function drm_wait_vblank_ioctl always return > > > -EINVAL if something gets wrong. This scenario limits the

Re: [PATCH 12/21] drm/sti: Use drm_atomic_helper_shutdown

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 10:08:06AM +0200, Benjamin Gaignard wrote: > Le ven. 5 oct. 2018 à 16:25, Daniel Vetter a écrit : > > > > On Fri, Oct 5, 2018 at 12:14 PM Benjamin Gaignard > > wrote: > > > > > > From: Daniel Vetter > > > > > > drm_plane_helper_disable is a non-atomic drivers only

Re: [PATCH v3 1/6] drm/fourcc: Add char_per_block, block_w and block_h in drm_format_info

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 09:52:04AM +, Alexandru-Cosmin Gheorghe wrote: > Hi Daniel, > > Thanks for having a look. > > On Fri, Oct 05, 2018 at 04:51:48PM +0200, Daniel Vetter wrote: > > On Fri, Oct 05, 2018 at 09:26:47AM +, Alexandru-Cosmin Gheorghe wrote: > > > For some pixel formats

Re: [PATCH v4 3/4] drm: Add library for shmem backed GEM objects

2018-10-11 Thread Daniel Vetter
On Wed, Oct 10, 2018 at 09:14:50PM +0200, Noralf Trønnes wrote: > Den 01.10.2018 09.46, skrev Daniel Vetter: > > On Wed, Sep 26, 2018 at 04:59:32PM +0200, Noralf Trønnes wrote: > > > +int drm_gem_shmem_prime_mmap(struct drm_gem_object *obj, struct > > > vm_area_struct *vma) > > > +{ > > > +

Re: [GIT PULL] mediatek drm next for 4.20

2018-10-11 Thread Daniel Vetter
On Thu, Oct 11, 2018 at 02:21:19PM +0800, CK Hu wrote: > Hi, Dave: > > On Thu, 2018-10-11 at 13:56 +1000, Dave Airlie wrote: > > On Thu, 11 Oct 2018 at 12:29, CK Hu wrote: > > > > > > Hi, Dave: > > > > > > On Thu, 2018-10-11 at 11:42 +1000, Dave Airlie wrote: > > > > On Thu, 11 Oct 2018 at

Re: [PATCH] drm/rcar-du: Convert drm_atomic_helper_suspend/resume()

2018-10-11 Thread Daniel Vetter
On Mon, Oct 08, 2018 at 09:57:52PM +0530, Souptick Joarder wrote: > Hi Laurent, > On Mon, Oct 1, 2018 at 6:12 PM Noralf Trønnes wrote: > > > > > > Den 01.10.2018 13.56, skrev Laurent Pinchart: > > > Hi Daniel, > > > > > > On Monday, 1 October 2018 09:52:20 EEST Daniel Vetter wrote: > > >> On Fri,

Re: Access the intel graphic card via libdrm

2018-10-11 Thread Daniel Vetter
On Tue, Oct 9, 2018 at 10:50 AM Horst Balthasar wrote: > > Hallo Herr Vetter, > > > thank you very much for our answer? > > We also don't want to develop a new driver for the graphic card. > > What we want is to access the graphic card via the existing interfaces in > > order to execute various

Re: [PATCH v12 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp

2018-10-11 Thread Lisovskiy, Stanislav
On Wed, 2018-10-10 at 17:12 -0700, Radhakrishna Sripada wrote: > Use the newly added "max bpc" connector property to limit pipe bpp. > > V3: Use drm_connector_state to access the "max bpc" property > V4: Initialize the drm property, add suuport to DP(Ville) > V5: Use the property in the connector

Re: [bug report] drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE checking if panel is used.

2018-10-11 Thread Dan Carpenter
On Tue, Oct 02, 2018 at 03:26:22PM +0200, Giulio Benetti wrote: > Il 01/10/2018 11:36, Dan Carpenter ha scritto: > > Hello Giulio Benetti, > > > > The patch 490cda5a3c82: "drm/sun4i: Handle DRM_BUS_FLAG_PIXDATA_*EDGE > > checking if panel is used." from Jul 18, 2018, leads to the following > >

Re: [PATCH][drm-next] drm/vmwgfx: remove redundant return ret statement

2018-10-11 Thread Dan Carpenter
On Thu, Oct 04, 2018 at 06:49:53PM +0100, Colin King wrote: > From: Colin Ian King > > The return statement is redundant as there is a return statement > immediately before it so we have dead code that can be removed. > Also remove the unused declaration of ret. > > Detected by CoverityScan,

Re: [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-10-11 Thread Viresh Kumar
On 10-10-18, 08:29, Jordan Crouse wrote: > On Wed, Oct 10, 2018 at 03:16:28PM +0530, Viresh Kumar wrote: > > On 27-08-18, 09:11, Jordan Crouse wrote: > > > Add the nodes to describe the Adreno GPU and GMU devices. > > > > > > Signed-off-by: Jordan Crouse > > > --- > > >

Re: [Freedreno] [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-10-11 Thread Viresh Kumar
On 10-10-18, 09:10, Jordan Crouse wrote: > On Wed, Oct 10, 2018 at 08:21:39PM +0530, Viresh Kumar wrote: > > On 10-10-18, 08:48, Jordan Crouse wrote: > > > qcom,level comes straight from: > > > > > > https://lore.kernel.org/lkml/20180627045234.27403-2-rna...@codeaurora.org/ > > > > > > But in

Re: [PATCH 6/9] PM / OPP: dt-bindings: Add opp-interconnect-bw

2018-10-11 Thread Viresh Kumar
On 27-09-18, 11:23, Georgi Djakov wrote: > On 08/27/2018 06:11 PM, Jordan Crouse wrote: > > Add the "opp-interconnect-bw" property to specify the > > average and peak bandwidth for an interconnect path for > > a specific operating power point. A separate bandwidth > > pair can be specified for

Re: [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-10-11 Thread Viresh Kumar
On 27-08-18, 09:11, Jordan Crouse wrote: > Add the nodes to describe the Adreno GPU and GMU devices. > > Signed-off-by: Jordan Crouse > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 121 +++ > 1 file changed, 121 insertions(+) > > diff --git

Re: [PATCH 6/9] PM / OPP: dt-bindings: Add opp-interconnect-bw

2018-10-11 Thread Viresh Kumar
On 10-10-18, 08:27, Jordan Crouse wrote: > I'm not convinced that required-opps would work. I'm worried that the > format is too vague if we need to use it for multiple paths and possibly > other uses too, consider this: > > required-opp = <_path0_opp3, _path1_opp5, _rpmh_opp1>; > > This has

Re: [Intel-gfx] [PATCH] drm/i915: Convert _print_param to a macro

2018-10-11 Thread Nick Desaulniers
On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko wrote: > > On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula > wrote: > > > On Tue, 09 Oct 2018, Nick Desaulniers wrote: > >> On Tue, Oct 9, 2018 at 10:14 AM Nathan Chancellor > >> wrote: > >>> > >>> When building the kernel with Clang with

Re: [Freedreno] [PATCH 5/9] arm64: dts: sdm845: Add gpu and gmu device nodes

2018-10-11 Thread Viresh Kumar
On 10-10-18, 08:48, Jordan Crouse wrote: > qcom,level comes straight from: > > https://lore.kernel.org/lkml/20180627045234.27403-2-rna...@codeaurora.org/ > > But in this case instead of using the CPU to program the RPMh we are passing > the value to a microprocessor (the GMU) and that will do

[PATCH -next] drm: Use PTR_ERR_OR_ZERO in drm_fb_cma_fbdev_init()

2018-10-11 Thread YueHaibing
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Signed-off-by: YueHaibing --- drivers/gpu/drm/drm_fb_cma_helper.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c index fb0dfc6..30741eb

Re: [PATCH] fbdev: make FB_BACKLIGHT a tristate

2018-10-11 Thread Arnd Bergmann
On Thu, Oct 11, 2018 at 3:16 AM Rob Clark wrote: > > On Wed, Oct 10, 2018 at 11:35 AM Arnd Bergmann wrote: > > > > On 10/10/18, Rob Clark wrote: > > > BACKLIGHT_CLASS_DEVICE is already tristate, but a dependency > > > FB_BACKLIGHT prevents it from being built as a module. There > > > doesn't

  1   2   >