From: kbuild test robot
Simplify the code a bit by using kmemdup instead of kzalloc and memcpy.
Generated by: scripts/coccinelle/api/memdup.cocci
Fixes: 76760fe3c00d ("drm/amd/powerplay: add function to store overdrive
information for smu11")
CC: Likun Gao
Signed-off-by: kbuild test robot
Hello,
It looks like line 1204 needs a break rather than a return, like in the
aborts from the other cases.
julia
-- Forwarded message --
Date: Sat, 2 Mar 2019 14:36:31 +0800
From: kbuild test robot
To: kbu...@01.org
Cc: Julia Lawall
Subject: [radeon-alex:drm-next-5.2-wip
> > +static struct lima_fence *lima_fence_create(struct lima_sched_pipe *pipe)
> > +{
> > + struct lima_fence *fence;
> > +
> > + fence = kmem_cache_zalloc(lima_fence_slab, GFP_KERNEL);
>
> Out of curiosity, what is the benefit of using a separate slab here?
> If this is beneficial,
The nomination period is now closed. We'll announce nominees March 7.
Note also that the membership deadline is March 7. If you haven't signed-up to
be a member and would like to do so there's only 6 more days left.
Harry
On 2019-02-14 5:27 p.m., Wentland, Harry wrote:
> Since we haven't seen
The pull request you sent on Fri, 1 Mar 2019 15:40:01 +1000:
> git://anongit.freedesktop.org/drm/drm tags/drm-fixes-2019-03-01
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/6357c8127bea35c52085a0ae0f97e73de2419825
Thank you!
--
Deet-doot-dot, I am a bot.
On 3/1/19 5:54 PM, Alex Deucher wrote:
> On Fri, Mar 1, 2019 at 4:51 PM Gustavo A. R. Silva
> wrote:
>>
>> Add missing break statement in order to prevent the code from falling
>> through to case SMU_Discrete_DpmTable.
>>
>> This bug was found thanks to the ongoing efforts to enable
>>
On Fri, Mar 1, 2019 at 4:51 PM Gustavo A. R. Silva
wrote:
>
> Add missing break statement in order to prevent the code from falling
> through to case SMU_Discrete_DpmTable.
>
> This bug was found thanks to the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Fixes: 34a564eaf528
On Fri, Mar 1, 2019 at 3:58 PM Gustavo A. R. Silva
wrote:
>
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
>
On Fri, Mar 1, 2019 at 3:31 AM Jakub Wilk wrote:
>
> The symbol for binary prefix kibi is "Ki", with uppercase K.
> (In contrast, the symbol for decimal kilo is lowercase "k".)
>
> Signed-off-by: Jakub Wilk
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/ttm/ttm_memory.c | 4 ++--
> 1 file
On Thu, Feb 28, 2019 at 9:21 AM Andrew F. Davis wrote:
>
> On 2/27/19 3:55 PM, John Stultz wrote:
> > On Wed, Feb 27, 2019 at 8:38 AM Andrew F. Davis wrote:
> >>
> >> We can always add back the free op, the alternative is to have the heap
> >> export the fd.
> >>
> >> I'm not sure either is
On Thu, Feb 28, 2019 at 8:12 PM Yang Wei wrote:
>
> From: Yang Wei
>
> Delete superfluous semicolons.
>
> Signed-off-by: Yang Wei
Applied. thanks!
Alex
> ---
> drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8
> drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
On Thu, Feb 28, 2019 at 12:43 PM Chris Wilson wrote:
>
> Quoting Alex Deucher (2019-02-28 17:25:41)
> > On Thu, Feb 28, 2019 at 4:54 AM Chris Wilson
> > wrote:
> > >
> > > Quoting Daniel Vetter (2019-02-28 09:49:51)
> > > > On Thu, Feb 28, 2019 at 5:30 AM Dave Airlie wrote:
> > > > >
> > > > >
On Thu, Feb 28, 2019 at 9:24 PM Stephen Rothwell wrote:
>
> Hi all,
>
> Today's linux-next merge of the drm tree got a conflict in:
>
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
>
> between commit:
>
> d63716658ac1 ("drm/amd/display: Use vrr friendly pageflip throttling in
> DC.")
>
Maarten Lankhorst writes:
> Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding destroy_state(),
> call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Eric Anholt
> ---
>
Maarten Lankhorst writes:
> __drm_atomic_helper_crtc_destroy_state does not free memory, it only
> cleans it up. Fix this by calling the functions own destroy function.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
dri-devel
Signed-off-by: Fritz Koenig
---
tests/modetest/modetest.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/modetest/modetest.c b/tests/modetest/modetest.c
index 975dcbcd..9c85c07b 100644
--- a/tests/modetest/modetest.c
+++ b/tests/modetest/modetest.c
@@ -293,6 +293,8 @@ static const
Hi Guido.
Thanks for addressing review comments in first round.
Just a few nits in this follow-up.
With these nits addressed:
Reviewed-by: Sam Ravnborg
On Fri, Mar 01, 2019 at 02:02:04PM +0100, Guido Günther wrote:
> +#include
This include file is, as far as I could tell, no longer used and
Hi Paul.
On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote:
> The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel.
>
> Signed-off-by: Paul Cercueil
> Tested-by: Artur Rojek
> ---
> drivers/gpu/drm/panel/panel-simple.c | 28
> 1 file
Add missing break statement in order to prevent the code from falling
through to case SMU_Discrete_DpmTable.
This bug was found thanks to the ongoing efforts to enable
-Wimplicit-fallthrough.
Fixes: 34a564eaf528 ("drm/amd/powerplay: implement fw image related smum
interface for Polaris.")
Cc:
https://bugs.freedesktop.org/show_bug.cgi?id=109808
Bug ID: 109808
Summary: ROCm OpenCL segfaults on drm-next-5.1-wip
Product: DRI
Version: XOrg git
Hardware: Other
OS: All
Status: NEW
Severity: normal
Hi Paul.
Driver looks good and is a very nice piece of work.
In the following a number of minor issues.
One area that jumped at me was framedesc and the use of dma_alloc_coherent()
I hope someone that knows the memory handling better can give some advice here.
To me it looks like something drm
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function
‘gfx_v8_0_tiling_mode_table_init’:
./include/linux/device.h:1487:2: warning: this statement may
On Fri, Mar 1, 2019 at 2:39 PM Jordan Crouse wrote:
>
> Add support for per-instance pagetables for 5XX targets. Create a support
> buffer for preemption to hold the SMMU pagetable information for a
> preempted ring, enable TTBR1 to support split pagetables and add the
> necessary PM4 commands to
Hi Paul.
Good to see work migrating fbdev => drm.
Following comments is based on experience while working on migrating
another driver from fbdev => drm.
On Thu, Feb 28, 2019 at 07:07:54PM -0300, Paul Cercueil wrote:
> Add documentation for the devicetree bindings of the DRM driver for the
>
Add support to create a GPU target specific address space for
a context. For those targets that support per-instance
pagetables they will return a new address space set up for
the instance if possible otherwise just use the global
device pagetable.
Signed-off-by: Jordan Crouse
---
Targets that support per-instance pagetable switching will have to keep
track of which pagetable belongs to each instance to be able to recover
for preemption.
Signed-off-by: Jordan Crouse
---
drivers/gpu/drm/msm/msm_ringbuffer.h | 1 +
1 file changed, 1 insertion(+)
diff --git
Add support for per-instance pagetables for a6xx targets. Add support
to handle split pagetables and create a new instance if the needed
IOMMU support exists and insert the necessary PM4 commands to trigger
a pagetable switch at the beginning of a user command.
Signed-off-by: Jordan Crouse
---
Add a helper function to create a GEM address space attached to
an iommu auxiliary domain for a per-instance pagetable.
Signed-off-by: Jordan Crouse
---
drivers/gpu/drm/msm/msm_drv.h | 4 +++
drivers/gpu/drm/msm/msm_gem_vma.c | 53 +++
2 files changed,
Add support for per-instance pagetables for 5XX targets. Create a support
buffer for preemption to hold the SMMU pagetable information for a
preempted ring, enable TTBR1 to support split pagetables and add the
necessary PM4 commands to trigger a pagetable switch at the beginning
of a user command.
When we move to 64 bit addressing for a5xx and a6xx targets we will start
seeing pagefaults at larger addresses so format them appropriately in the
log message for easier debugging.
Signed-off-by: Jordan Crouse
---
drivers/gpu/drm/msm/msm_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1
Add support for creating a auxiliary domain from the IOMMU device to
implement per-instance pagetables. Also add a helper function to
return the pagetable base address (ttbr) and asid to the caller so
that the GPU target code can set up the pagetable switch.
Signed-off-by: Jordan Crouse
---
Move the address space steup code out of the generic msm GPU code to
to the individual GPU targets. This allows us to do target specific
setup such as gpummu for a2xx or split pagetables and per-instance
pagetables for newer a5xx and a6xx targets. All this is at the
expense of duplicated code in
Pass the index of the MMU domain in struct msm_file_private instead
of assuming gpu->id throughout the submit path. This clears the way
to change ctx->aspace to a per-instance pagetable.
Signed-off-by: Jordan Crouse
---
drivers/gpu/drm/msm/msm_drv.c| 2 ++
A5XX and newer GPUs can be run in either 32 or 64 bit mode. The GPU
registers and the microcode use 64 bit virtual addressing in either
case but the upper 32 bits are ignored if the GPU is in 32 bit mode.
There is no performance disadvantage to remaining in 64 bit mode even
if we are only
This is the latest incarnation of per-instance pagetable support for the MSM GPU
driver. Some of these have been seen before, most recently [1].
Per-instance pagetables allow the target GPU driver to create and manage
an individual pagetable for each file descriptor instance and switch
between
On Fri, Mar 01, 2019 at 03:35:35PM -0300, Shayenne Moura wrote:
> Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä
> escreveu:
> >
> > On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote:
> > > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä
> > > escreveu:
> > > >
> > > > On Thu,
Em sex, 1 de mar de 2019 às 12:26, Ville Syrjälä
escreveu:
>
> On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote:
> > Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä
> > escreveu:
> > >
> > > On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote:
> > > > On Mon, Feb 25,
On Tue, Feb 26, 2019 at 04:20:56PM +, Ayan Halder wrote:
> From: Ayan Kumar Halder
>
> We need to define a common list of format modifiers supported by each of
> the Mali display processors.
>
> The following are the constraints with AFBC:-
>
> 1. AFBC is not supported for the formats
Hi Chengguang,
Thanks for doing this. Will include this for vmwgfx-next
Reviewed-by: Deepak Rawat
On Thu, 2019-02-21 at 10:09 +0800, Chengguang Xu wrote:
> unlikely has already included in IS_ERR(), so just
> remove redundant unlikely annotation.
>
> Signed-off-by: Chengguang Xu
> ---
>
On Tue, Feb 26, 2019 at 04:20:54PM +, Ayan Halder wrote:
> From: Ayan Kumar Halder
>
> Added the AFBC decoder registers for DP500 , DP550 and DP650.
> These registers control the processing of AFBC buffers. It controls various
> features like AFBC decoder enable, lossless transformation and
https://bugs.freedesktop.org/show_bug.cgi?id=109329
--- Comment #2 from Fabian Maurer ---
The default scene, I guess.
Sorry, I don't know what exactly you mean - I just run the program without any
parameters, and then it freezes.
I'd test more, but currently luxmark doesn't build on my system.
https://bugs.freedesktop.org/show_bug.cgi?id=109693
--- Comment #1 from Tim Müller ---
Would be great if someone could take a look at this, as it might affect more
users once the next GStreamer stable release is out.
--
You are receiving this mail because:
You are the assignee for the
https://bugzilla.kernel.org/show_bug.cgi?id=202445
--- Comment #22 from Clément Guérin (li...@protonmail.com) ---
Great news. Can you confirm that
https://bugzilla.kernel.org/show_bug.cgi?id=202445#c16 is not related to this
issue?
--
You are receiving this mail because:
You are watching the
https://bugzilla.kernel.org/show_bug.cgi?id=202445
--- Comment #21 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) ---
I'll let you know when it's up so you can try it. It should resolve the issue,
but if it doesn't it will at least help narrow down the cause.
--
You are receiving this
https://bugzilla.kernel.org/show_bug.cgi?id=202445
--- Comment #20 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) ---
That patch certainly helps for the case where the pageflip was submitted during
vblank (the frontporch will no longer timeout, causing flickering).
The video you recorded
https://bugzilla.kernel.org/show_bug.cgi?id=201763
--- Comment #7 from Michel Dänzer (mic...@daenzer.net) ---
(In reply to Rogério Brito from comment #5)
> First of all, sorry for the late reply. I had really a really bad start of
> the year (death in family, complications caused by that, health
On Fri, Mar 01, 2019 at 09:18:13AM +0100, Daniel Vetter wrote:
> On Thu, Feb 28, 2019 at 04:09:30PM -0500, Sean Paul wrote:
> > From: Sean Paul
> >
> > This patch adds a new drm helper library to help drivers implement
> > PSR. Drivers choosing to use it will register connectors with
> >
On Fri, Mar 01, 2019 at 11:55:11AM -0300, Shayenne Moura wrote:
> Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä
> escreveu:
> >
> > On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote:
> > > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote:
> > > > vkms_crc_work_handle
Hi Marteen,
On Fri, Mar 01, 2019 at 03:47:02PM +0100, Maarten Lankhorst wrote:
> Op 01-03-2019 om 15:36 schreef Laurent Pinchart:
> > On Fri, Mar 01, 2019 at 03:08:20PM +0100, Maarten Lankhorst wrote:
> >> Op 01-03-2019 om 14:13 schreef Laurent Pinchart:
> >>> On Fri, Mar 01, 2019 at 01:56:22PM
On Thu, Feb 28, 2019 at 09:03:26PM +0100, Jernej Skrabec wrote:
> DE2 and DE3 VI channels support coarse scaling to overcome VI scaler
> limitations. That is especially useful for downscaling big planes, for
> example 4K to 1080p.
>
> Following patches were tested on H3 and A64 with 4K video
Em qui, 28 de fev de 2019 às 11:03, Ville Syrjälä
escreveu:
>
> On Thu, Feb 28, 2019 at 11:11:07AM +0100, Daniel Vetter wrote:
> > On Mon, Feb 25, 2019 at 11:26:06AM -0300, Shayenne Moura wrote:
> > > vkms_crc_work_handle needs the value of the actual frame to
> > > schedule the workqueue that
Hi,
On 03/01/2019 02:53 AM, Yue Haibing wrote:
> From: YueHaibing
>
> After commit 60d2fa0dad06 ("fbdev: omap2: no need to check
> return value of debugfs_create functions"), there are corner
> code need to be cleaned.
>
> Signed-off-by: YueHaibing
Thanks but I've already applied earlier
Op 01-03-2019 om 15:36 schreef Laurent Pinchart:
> Hi Marteen,
>
> On Fri, Mar 01, 2019 at 03:08:20PM +0100, Maarten Lankhorst wrote:
>> Op 01-03-2019 om 14:13 schreef Laurent Pinchart:
>>> On Fri, Mar 01, 2019 at 01:56:22PM +0100, Maarten Lankhorst wrote:
Convert rcar-du to using
On 02/13/2019 09:47 AM, Anders Roxell wrote:
> Commit 60d2fa0dad06 ("fbdev: omap2: no need to check return value of
> debugfs_create functions") changed the declaration of the return value
> of function dss_debugfs_create_file() and the following two warnings
> appeared:
>
>
Hi Marteen,
On Fri, Mar 01, 2019 at 03:08:20PM +0100, Maarten Lankhorst wrote:
> Op 01-03-2019 om 14:13 schreef Laurent Pinchart:
> > On Fri, Mar 01, 2019 at 01:56:22PM +0100, Maarten Lankhorst wrote:
> >> Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of
> >> writing its own
On Fri, 2019-03-01 at 06:51 +0100, Gerd Hoffmann wrote:
> On Thu, Feb 28, 2019 at 10:47:41AM -0600, Joshua Watt wrote:
> > Reports the size of the virtgpu framebuffer to userspace and
> > installs
> > the deferred I/O handlers so that userspace can mmap() and write to
> > it.
>
> Fixed already,
Op 01-03-2019 om 14:13 schreef Laurent Pinchart:
> Hi Maarten,
>
> Thank you for the patch.
>
> On Fri, Mar 01, 2019 at 01:56:22PM +0100, Maarten Lankhorst wrote:
>> Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of
>> writing its own version. Instead of open coding
Hi Maarten,
On Fri, Mar 01, 2019 at 01:56:15PM +0100, Maarten Lankhorst wrote:
> Convert mali to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding
> malidp_crtc_destroy_state(), call it directly for freeing the old state.
>
> Signed-off-by:
Hi Maarten,
Thank you for the patch.
On Fri, Mar 01, 2019 at 01:56:22PM +0100, Maarten Lankhorst wrote:
> Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding destroy_state(), call
> it directly for freeing the old state.
I
Support Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel. It is a MIPI
DSI video mode panel.
The panel seems to use a Sitronix ST7703 look alike (most of the
commands look similar to the ST7703's data sheet but use a different
number of parameters). The initial version of the DSI init sequence
Add ROCKTECH DISPLAYS LIMITED (https://rocktech.com.hk) LCD panel
supplier.
Signed-off-by: Guido Günther
---
Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt
It's a 5.5" 720x1440 TFT LCD MIPI DSI panel with built in touchscreen and
backlight as found in the Librem 5 devkit.
These patches are against linux next as of 2019-02-08.
Changes from v1
* As per review comments from Sam Ravnborg
* Make SPDX-License-Identifier match MODULE_LICENSE
* Sort
The Rocktec jh057n00900 is a 5.5" MIPI DSI video mode panel with a
720x1440 resolution and a built in backlight.
Signed-off-by: Guido Günther
---
.../display/panel/rocktech,jh057n00900.txt | 18 ++
1 file changed, 18 insertions(+)
create mode 100644
Convert vkms to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding destroy_state(),
call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Rodrigo Siqueira
Cc: Haneen Mohammed
Cc: Daniel Vetter
---
Convert tegra to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding destroy_state(),
call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Thierry Reding
Cc: Jonathan Hunter
Cc: linux-te...@vger.kernel.org
---
Convert vmwgfx to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding destroy_state(),
call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Thomas Hellstrom
---
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 20
__drm_atomic_helper_crtc_destroy_state does not free memory, it only
cleans it up. Fix this by calling the functions own destroy function.
Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time
CRTC state.")
Cc: Eric Anholt
Cc: # v4.6+
Signed-off-by: Maarten Lankhorst
Convert mediatek to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: CK Hu
Cc: Philipp Zabel
Cc: Matthias Brugger
---
Convert mali to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
malidp_crtc_destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Liviu Dudau
Cc: Brian Starkey
---
drivers/gpu/drm/arm/malidp_crtc.c
When we want to start adding default values to crtc_state, it makes
sense fix all drivers to call __drm_atomic_helper_crtc_reset, like
we do for connectors and planes.
Maarten Lankhorst (17):
drm/vc4: Fix memory leak during gpu reset.
drm/atomic: Create __drm_atomic_helper_crtc_reset() for
Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding destroy_state(),
call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Eric Anholt
---
drivers/gpu/drm/vc4/vc4_crtc.c | 9 +
1 file changed, 5
Convert omap to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/omap_crtc.c | 11 +--
1 file
Convert rcar-du to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding destroy_state(), call
it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Laurent Pinchart
Cc: Kieran Bingham
Cc: linux-renesas-...@vger.kernel.org
---
Convert msm to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Rob Clark
Cc: Sean Paul
---
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 6 ++---
Convert rockchip to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Sandy Huang
Cc: "Heiko Stübner"
Cc: linux-rockc...@lists.infradead.org
---
Signed-off-by: Maarten Lankhorst
---
drivers/gpu/drm/drm_atomic_state_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c
b/drivers/gpu/drm/drm_atomic_state_helper.c
index bc5ee66f75b3..172c8c698a46 100644
---
i915 has its own hw readout and doesn't use the reset helpers directly.
Still it has 2 places where it initialises the crtc_state. Fix those
by calling __drm_atomic_helper_crtc_reset().
Signed-off-by: Maarten Lankhorst
Cc: Jani Nikula
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
---
Convert atmel-hlcdc to using __drm_atomic_helper_crtc_reset(), instead
of writing its own version. Instead of open coding destroy_state(),
call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Boris Brezillon
---
.../gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c| 29
We already have __drm_atomic_helper_connector_reset() and
__drm_atomic_helper_plane_reset(), extend this to crtc as well.
This will allow us to set default values in the crtc_state, without
having to do it in each driver separately.
Of all drivers that need conversion, only nouveau is done in
Convert imx to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version. Instead of open coding
destroy_state(), call it directly for freeing the old state.
Signed-off-by: Maarten Lankhorst
Cc: Philipp Zabel
---
drivers/gpu/drm/imx/ipuv3-crtc.c | 30
Convert amd to using __drm_atomic_helper_crtc_reset(), instead of
writing its own version.
Signed-off-by: Maarten Lankhorst
Cc: Harry Wentland
Cc: Leo Li
Cc: Alex Deucher
Cc: "Christian König"
Cc: "David (ChunMing) Zhou"
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 ++
GSCALERs in Exynos5433 have local path to DECON and DECON_TV.
They can be used as extra planes with support for non-RGB formats and scaling.
To enable it on DECON update_plane and disable_plane callback should
be modified. Moreover DSD mux should be set accordingly, and finally
atomic_check
Since crtc maps 1:1 to the device there is no point in allocating it
separately, another benefit is possibility of direct initialisation
of its fields which is more readable and allows further expansion.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 60
GSCALER does not support BGRX, instead it supports XBGR.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
b/drivers/gpu/drm/exynos/exynos_drm_gsc.c
Since crtc maps 1:1 to the device there is no point in allocating it
separately, another benefit is possibility of direct initialisation
of its fields which is more readable and allows further expansion.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 26
This bit will indicate the plane is provided by GSCALER.
Tests shows that GSCALER does not like to convert from/to too small
buffers. Since exact constraints are not provided by documentation
rough estimate of 64 pixel has been applied.
Signed-off-by: Andrzej Hajda
---
YVU420 requires swapping addresses of U and V planes.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_gsc.c | 52 ++---
1 file changed, 37 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_gsc.c
To support local paths both DECON and GSCALER should enable respective
Smart Deck clocks DSD and GSD.
Signed-off-by: Andrzej Hajda
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 25 +-
1 file changed, 15 insertions(+), 10 deletions(-)
diff --git
exynos_drm_crtc_init has all information necessary to discover primary
and cursor planes. Let's move logic for setting these planes into this
function.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 3 ---
drivers/gpu/drm/exynos/exynos7_drm_decon.c| 1 -
Since crtc maps 1:1 to the device there is no point in allocating it
separately, another benefit is possibility of direct initialisation
of its fields which is more readable and allows further expansion.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_mixer.c | 39
Since all Exynos CRTCs uses the first plane as primary plane and the last
one as cursor plane we can drop custom assignments per CRTC and replace it
with common code.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 7 +--
Since exynos_drm_crtc is a struct which maps 1:1 to underlying device it
is better to put it directly into device's context instead of allocating
it separately. Another benefit is possibility of initialisation of
its fields directly, without expanding exynos_drm_crtc_create which is
already
MAX_CRTC macro is not used at all.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h
b/drivers/gpu/drm/exynos/exynos_drm_drv.h
index 6e38d0dc4457..1f6bb5516170 100644
---
Hi Inki,
GSCALERs in Exynos SoCs support conversion between wide range of image formats,
plus scaling and rotation.
Driver already supports mem2mem mode - via ExynosDRM IPP framework.
This patchset adds support for mem to display mode - framebuffers can
be converted, scaled and send directly to
DECON should wait for previous update before starting new one. Otherwise
internal registers can be updated in non-atomic, error prone way.
This patch fixes occasional occurrences of vblank timeouts on tm2 platform:
[ 3167.968742] [CRTC:55:crtc-0] vblank wait timed out
[ 3167.987440] WARNING: CPU:
The header contains only declaration of one function, the rest of exynos
plane declaration is in exynos_drm_drv.h.
Let's merge it together.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 1 -
drivers/gpu/drm/exynos/exynos7_drm_decon.c| 1 -
It can be replaced by recently introduced to_vidi helper.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_vidi.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_vidi.c
b/drivers/gpu/drm/exynos/exynos_drm_vidi.c
GSCALER should be feed with clock at certain rates.
Signed-off-by: Andrzej Hajda
---
arch/arm64/boot/dts/exynos/exynos5433-tm2-common.dtsi | 6 ++
arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 6 --
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git
Since crtc maps 1:1 to the device there is no point in allocating it
separately, another benefit is possibility of direct initialisation
of its fields which is more readable and allows further expansion.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 52
Display controllers in Exynos beside native planes/windows can use external
planes provided by other IPs - GSCALER, FIMD, VPP. To add support to them
we will need plane specific callbacks.
Signed-off-by: Andrzej Hajda
---
drivers/gpu/drm/exynos/exynos_drm_drv.h | 7 +++
1 file changed, 7
1 - 100 of 148 matches
Mail list logo
