[Bug 107990] Got Dying Light working in Arch by changing Mesa's compile steps, how to get it working Out Of the Box?

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=107990 --- Comment #12 from Timothy Arceri --- A bunch of EXT_direct_state_access function have now been implemented in mesa master, it's likely that Dying Light now works. Would be good if someone can give it a test. -- You are receiving this mail

Re: [PATCH v5 5/7] drm/panel: simple: Use display_timing for AUO b101ean01

2019-06-28 Thread Thierry Reding
On Mon, Apr 01, 2019 at 10:17:22AM -0700, Douglas Anderson wrote: > Convert the AUO b101ean01 from using a fixed mode to specifying a > display timing with min/typ/max values. > > The AUO b101ean01's datasheet says: > * Vertical blanking min is 12 > * Horizontal blanking min is 60 > * Pixel clock

Re: [PATCH v5 4/7] drm/panel: simple: Use display_timing for Innolux n116bge

2019-06-28 Thread Thierry Reding
On Mon, Apr 01, 2019 at 10:17:21AM -0700, Douglas Anderson wrote: > Convert the Innolux n116bge from using a fixed mode to specifying a > display timing with min/typ/max values. > > Note that the n116bge's datasheet doesn't fit too well into DRM's way > of specifying things. Specifically the

Re: [PATCH v5 2/7] drm/panel: simple: Add ability to override typical timing

2019-06-28 Thread Thierry Reding
On Mon, Apr 01, 2019 at 10:17:19AM -0700, Douglas Anderson wrote: > From: Sean Paul > > This patch adds the ability to override the typical display timing for a > given panel. This is useful for devices which have timing constraints > that do not apply across the entire display driver (eg: to

Re: [RFC] Exposing plane type mask and handling 'all' planes

2019-06-28 Thread Matt Roper
On Fri, Jun 28, 2019 at 07:54:06PM +0100, Emil Velikov wrote: > On 2019/06/28, Matt Roper wrote: > > On Fri, Jun 28, 2019 at 05:14:51PM +0100, Emil Velikov wrote: > > > Hi Matt, > > > > > > Thanks for the enlightening input :-) > > > > > > On 2019/06/25, Matt Roper wrote: > > > > > > >

[Bug 111021] [amdgpu][CIK] cp queue preemption time out, BUG: kernel NULL pointer dereference, address: 0000000000000038

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 --- Comment #2 from erhar...@mailbox.org --- Created attachment 144680 --> https://bugs.freedesktop.org/attachment.cgi?id=144680=edit shaders -- You are receiving this mail because: You are the assignee for the

[Bug 111021] [amdgpu][CIK] cp queue preemption time out, BUG: kernel NULL pointer dereference, address: 0000000000000038

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 --- Comment #1 from erhar...@mailbox.org --- Created attachment 144679 --> https://bugs.freedesktop.org/attachment.cgi?id=144679=edit kernel .config (5.2-rc6) -- You are receiving this mail because: You are the assignee for the

[Bug 111021] [amdgpu][CIK] cp queue preemption time out, BUG: kernel NULL pointer dereference, address: 0000000000000038

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111021 Bug ID: 111021 Summary: [amdgpu][CIK] cp queue preemption time out, BUG: kernel NULL pointer dereference, address: 0038 Product: DRI Version:

Re: [PATCH] drm/panfrost: Fix a double-free error

2019-06-28 Thread Rob Herring
On Thu, Jun 27, 2019 at 11:24 AM Boris Brezillon wrote: > > drm_gem_shmem_create_with_handle() returns a GEM object and attach a > handle to it. When the user closes the DRM FD, the core releases all > GEM handles along with their backing GEM objs, which can lead to a > double-free issue if

[Bug 110702] segfault in radeonsi HEVC hardware decoding with yuv420p10le

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110702 --- Comment #15 from Pierre-Eric Pelloux-Prayer --- The fix has been merged today (https://gitlab.freedesktop.org/mesa/mesa/commit/c81c784a4a05f8a957a649d73c8194247de47b56). -- You are receiving this mail because: You are the assignee for

Re: [PATCH v5 17/18] kernel/sysctl-test: Add null pointer test for sysctl.c:proc_dointvec()

2019-06-28 Thread Luis Chamberlain
On Fri, Jun 28, 2019 at 01:01:54AM -0700, Brendan Higgins wrote: > On Wed, Jun 26, 2019 at 11:10 PM Luis Chamberlain wrote: > > > > On Wed, Jun 26, 2019 at 09:07:43PM -0700, Iurii Zaikin wrote: > > > On Tue, Jun 25, 2019 at 7:17 PM Luis Chamberlain > > > wrote: > > > > > +static void

Re: [RFC PATCH v3 09/11] drm, cgroup: Add per cgroup bw measure and control

2019-06-28 Thread Kenny Ho
On Thu, Jun 27, 2019 at 2:11 AM Daniel Vetter wrote: > I feel like a better approach would by to add a cgroup for the various > engines on the gpu, and then also account all the sdma (or whatever the > name of the amd copy engines is again) usage by ttm_bo moves to the right > cgroup. I think

Re: [PATCH] dt-bindings: backlight: lm3630a: correct schema validation

2019-06-28 Thread Rob Herring
On Mon, 20 May 2019 04:58:46 -0400, Brian Masney wrote: > The '#address-cells' and '#size-cells' properties were not defined in > the lm3630a bindings and would cause the following error when > attempting to validate the examples against the schema: > >

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 12:02 PM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 11:59:19AM -0700, Dan Williams wrote: > > It's a bug that the call to put_devmap_managed_page() was gated by > > MEMORY_DEVICE_PUBLIC in release_pages(). That path is also applicable > > to MEMORY_DEVICE_FSDAX

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 11:52 AM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 11:44:35AM -0700, Dan Williams wrote: > > There is a problem with the series in CH's tree. It removes the > > ->page_free() callback from the release_pages() path because it goes > > too far and removes the

Re: [RFC] Exposing plane type mask and handling 'all' planes

2019-06-28 Thread Emil Velikov
On 2019/06/28, Matt Roper wrote: > On Fri, Jun 28, 2019 at 05:14:51PM +0100, Emil Velikov wrote: > > Hi Matt, > > > > Thanks for the enlightening input :-) > > > > On 2019/06/25, Matt Roper wrote: > > > > > PLANE_CURSOR is basically just an indication that that specific plane is > > > the one

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 11:29 AM Jason Gunthorpe wrote: > > On Fri, Jun 28, 2019 at 10:10:12AM -0700, Dan Williams wrote: > > On Fri, Jun 28, 2019 at 10:08 AM Dan Williams > > wrote: > > > > > > On Fri, Jun 28, 2019 at 10:02 AM Jason Gunthorpe > > > wrote: > > > > > > > > On Fri, Jun 28, 2019

Re: [RFC PATCH v3 04/11] drm, cgroup: Add total GEM buffer allocation limit

2019-06-28 Thread Kenny Ho
On Thu, Jun 27, 2019 at 5:24 PM Daniel Vetter wrote: > On Thu, Jun 27, 2019 at 02:42:43PM -0400, Kenny Ho wrote: > > Um... I am going to get a bit philosophical here and suggest that the > > idea of sharing (especially uncontrolled sharing) is inherently at odd > > with containment. It's like,

Re: [RFC] Exposing plane type mask and handling 'all' planes

2019-06-28 Thread Matt Roper
On Fri, Jun 28, 2019 at 05:14:51PM +0100, Emil Velikov wrote: > Hi Matt, > > Thanks for the enlightening input :-) > > On 2019/06/25, Matt Roper wrote: > > > PLANE_CURSOR is basically just an indication that that specific plane is > > the one that's also hooked up to the legacy cursor ioctls;

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 18:40 schrieb Daniel Vetter: > On Fri, Jun 28, 2019 at 5:21 PM Koenig, Christian > wrote: >> Am 28.06.19 um 16:38 schrieb Daniel Vetter: >> [SNIP] >>> - when you submit command buffers, you _dont_ attach fences to all >>> involved buffers >> That's not going to work

Re: [PATCH] drm/kms: Catch mode_object lifetime errors

2019-06-28 Thread Sean Paul
On Fri, Jun 14, 2019 at 08:17:23AM +0200, Daniel Vetter wrote: > Only dynamic mode objects, i.e. those which are refcounted and have a free > callback, can be added while the overall drm_device is visible to > userspace. All others must be added before drm_dev_register and > removed after

Re: [PATCH libdrm 1/9] amdgpu: Pass file descriptor directly to amdgpu_close_kms_handle

2019-06-28 Thread Emil Velikov
On Mon, 24 Jun 2019 at 17:54, Michel Dänzer wrote: > > From: Michel Dänzer > > And propagate drmIoctl's return value. > > This allows replacing all remaining open-coded DRM_IOCTL_GEM_CLOSE > ioctl calls with amdgpu_close_kms_handle calls. > > Signed-off-by: Michel Dänzer > --- >

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 10:08 AM Dan Williams wrote: > > On Fri, Jun 28, 2019 at 10:02 AM Jason Gunthorpe wrote: > > > > On Fri, Jun 28, 2019 at 09:27:44AM -0700, Dan Williams wrote: > > > On Fri, Jun 28, 2019 at 8:39 AM Jason Gunthorpe wrote: > > > > > > > > On Wed, Jun 26, 2019 at 02:27:15PM

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 10:02 AM Jason Gunthorpe wrote: > > On Fri, Jun 28, 2019 at 09:27:44AM -0700, Dan Williams wrote: > > On Fri, Jun 28, 2019 at 8:39 AM Jason Gunthorpe wrote: > > > > > > On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote: > > > > The functionality is

Re: [PATCH] drm/vmwgfx: Don't look at state->allow_modeset

2019-06-28 Thread Daniel Vetter
On Tue, May 21, 2019 at 02:58:36PM +, Deepak Singh Rawat wrote: > Reviewed-by: Deepak Rawat Thanks for your review, I've merged this into drm-misc-next so it won't get lost again. Should land for 5.4. -Daniel > > On Tue, 2019-05-21 at 00:35 +0200, Daniel Vetter wrote: > > That's purely for

Re: [PATCH 3/4] drm/hibmc: Leave struct drm_driver.gem_free_object_unlocked to NULL

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 02:26:58PM +0200, Thomas Zimmermann wrote: > The GEM object's free function is now called through > struct drm_gem_object_funcs.free. > > Signed-off-by: Thomas Zimmermann > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 -- > 1 file changed, 2 deletions(-) >

Re: [PATCH v3 00/18] drm/ttm: make ttm bo a gem bo subclass

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 11:02:45AM +0200, Gerd Hoffmann wrote: > v3: > - comment updates > - rebased on daniels resv series >(https://patchwork.freedesktop.org/series/62735/) Rebase looks correct to me. -Daniel > v2: > - build fixes. > - also drop ttm_buffer_object->resv > > Gerd

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 06:01:14PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls -l

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 5:21 PM Koenig, Christian wrote: > > Am 28.06.19 um 16:38 schrieb Daniel Vetter: > [SNIP] > > - when you submit command buffers, you _dont_ attach fences to all > > involved buffers > That's not going to work because then the memory management then thinks >

[PATCH] drm/msm: Transition console to msm framebuffer

2019-06-28 Thread Jeffrey Hugo
If booting a device using EFI, efifb will likely come up and claim the console. When the msm display stack finally comes up, we want the console to move over to the msm fb, so add support to kick out any firmware based framebuffers to accomplish the console transition. Suggested-by: Rob Clark

Re: [PATCH 16/25] device-dax: use the dev_pagemap internal refcount

2019-06-28 Thread Dan Williams
On Fri, Jun 28, 2019 at 8:39 AM Jason Gunthorpe wrote: > > On Wed, Jun 26, 2019 at 02:27:15PM +0200, Christoph Hellwig wrote: > > The functionality is identical to the one currently open coded in > > device-dax. > > > > Signed-off-by: Christoph Hellwig > > Reviewed-by: Ira Weiny > > --- > >

Re: [RFC] Exposing plane type mask and handling 'all' planes

2019-06-28 Thread Emil Velikov
Hi Matt, Thanks for the enlightening input :-) On 2019/06/25, Matt Roper wrote: > PLANE_CURSOR is basically just an indication that that specific plane is > the one that's also hooked up to the legacy cursor ioctls; like Ville > says, it shouldn't directly indicate that the plane is less >

Re: [PATCH v3 00/22] Associate ddc adapters with connectors

2019-06-28 Thread Laurent Pinchart
Hi Andrzej, Just FYI, I have a patch series that reworks how bridges and connectors are handled, and it will heavily conflict with this. The purpose of the two series isn't the same, so both make sense. I will post the patches this weekend, and will then review this series in that context.

Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree

2019-06-28 Thread Rob Herring
On Fri, Jun 28, 2019 at 9:55 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 26, 2019 at 7:41 AM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Jun 26, 2019 at 6:00 AM Sam Ravnborg wrote: > > > > > > Hi Douglas. > > > > > > On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > >

Re: [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree

2019-06-28 Thread Doug Anderson
Hi, On Wed, Jun 26, 2019 at 7:41 AM Doug Anderson wrote: > > Hi, > > On Wed, Jun 26, 2019 at 6:00 AM Sam Ravnborg wrote: > > > > Hi Douglas. > > > > On Mon, Apr 01, 2019 at 10:17:17AM -0700, Douglas Anderson wrote: > > > I'm reviving Sean Paul's old patchset to get mode support in device > > >

Re: [PATCH][next] drm/amd/powerplay: fix out of memory check on od8_settings

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:13:54 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter;

Re: [PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:05:39 AM To: Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; Xiao, Jack; Zhang, Hawking; amd-...@lists.freedesktop.org;

Re: [PATCH][next] drm/amd/powerplay: remove a less than zero uint32_t check

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 11:28:04 AM To: Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-...@lists.freedesktop.org;

[PATCH][next] drm/amd/powerplay: remove a less than zero uint32_t check

2019-06-28 Thread Colin King
From: Colin Ian King The check to see if the uint32_t variable 'size' is less than zero is redundant as it is unsigned and can never be less than zero. Remove this redundant check. Addresses-Coverity: ("Unsigned compared to zero") Signed-off-by: Colin Ian King ---

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Koenig, Christian
Am 28.06.19 um 16:38 schrieb Daniel Vetter: [SNIP] > - when you submit command buffers, you _dont_ attach fences to all > involved buffers That's not going to work because then the memory management then thinks that the buffer is immediately movable, which it isn't, >>> I guess

Re: [PATCH] drm/amd/powerplay: fix incorrect assignments to mclk_mask and soc_mask

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:45:17 AM To: Wang, Kevin(Yang); Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter;

Re: [PATCH] drm/amd/powerplay: fix off-by-one array bounds check

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:24:02 AM To: Rex Zhu; Quan, Evan; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-...@lists.freedesktop.org;

[PATCH][next] drm/amd/powerplay: fix out of memory check on od8_settings

2019-06-28 Thread Colin King
From: Colin Ian King The null pointer check on od8_settings is currently the opposite of what it is intended to do. Fix this by adding in the missing ! operator. Addressed-Coverity: ("Resource leak") Fixes: 0c83d32c565c ("drm/amd/powerplay: simplified od_settings for each asic") Signed-off-by:

Re: [PATCH][next] drm/amdkfd: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:54:43 AM To: Cox, Philip; Oded Gabbay; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; dri-devel@lists.freedesktop.org;

Re: [PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:08:01 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-...@lists.freedesktop.org;

Re: [PATCH] drm/amdgpu: fix a missing break in a switch statement

2019-06-28 Thread Abramov, Slava
Acked-by: Slava Abramov From: amd-gfx on behalf of Colin King Sent: Friday, June 28, 2019 10:33:20 AM To: Zhang, Hawking; Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing); David Airlie; Daniel Vetter; amd-...@lists.freedesktop.org;

[PATCH][next] drm/amdgpu/mes10.1: fix duplicated assignment to adev->mes.ucode_fw_version

2019-06-28 Thread Colin King
From: Colin Ian King Currently adev->mes.ucode_fw_version is being assigned twice with different values. This looks like a cut-n-paste error and instead the second assignment should be adev->mes.data_fw_version. Fix this. Addresses-Coverity: ("Unused value") Fixes: 298d05460cc4

[PATCH][next] drm/amdkfd: fix a missing break in a switch statement

2019-06-28 Thread Colin King
From: Colin Ian King Currently for the CHIP_RAVEN case there is a missing break causing the code to fall through to the new CHIP_NAVI10 case. Fix this by adding in the missing break statement. Fixes: 14328aa58ce5 ("drm/amdkfd: Add navi10 support to amdkfd. (v3)") Signed-off-by: Colin Ian King

[PATCH] drm/amd/powerplay: fix incorrect assignments to mclk_mask and soc_mask

2019-06-28 Thread Colin King
From: Colin Ian King There are null pointer checks on mlck_mask and soc_mask however the sclk_mask is being used in assignments in what looks to be a cut-n-paste coding error. Fix this by using the correct pointers in the assignments. Addresses-Coverity: ("Dereference after null check") Fixes:

Re: [PATCH 2/2] dma-buf: cleanup shared fence removal

2019-06-28 Thread Daniel Vetter
On Fri, Jun 28, 2019 at 12:24 PM Koenig, Christian wrote: > > Am 28.06.19 um 11:41 schrieb Daniel Vetter: > > On Fri, Jun 28, 2019 at 10:40 AM Christian König > > wrote: > >> Am 28.06.19 um 09:30 schrieb Daniel Vetter: > >>> On Fri, Jun 28, 2019 at 8:32 AM Koenig, Christian > >>> wrote: >

[PATCH] drm/amdgpu: fix a missing break in a switch statement

2019-06-28 Thread Colin King
From: Colin Ian King Currently for the AMDGPU_IRQ_STATE_DISABLE there is a missing break causing the code to fall through to the AMDGPU_IRQ_STATE_ENABLE case. Fix this by adding in the missing break statement. Addresses-Coverity: ("Missing break in switch") Fixes: a644d85a5cd4 ("drm/amdgpu: add

[PATCH] drm/amd/powerplay: fix off-by-one array bounds check

2019-06-28 Thread Colin King
From: Colin Ian King The array bounds check for index is currently off-by-one and should be using >= rather than > on the upper bound. Fix this. Addresses-Coverity: ("Out-of-bounds read") Fixes: b3490673f905 ("drm/amd/powerplay: introduce the navi10 pptable implementation") Signed-off-by:

[PATCH v5 2/2] Revert "drm/vblank: Do not update vblank count if interrupts are already disabled."

2019-06-28 Thread Robert Beckett
If interrupts are already disabled, then the timestamp for the vblank does not get updated, causing a stale timestamp to be reported to userland while disabling crtcs. This reverts commit 68036b08b91bc491ccc308f902616a570a49227c. Signed-off-by: Robert Beckett --- drivers/gpu/drm/drm_vblank.c |

[PATCH v5 1/2] drm/vblank: warn on sending stale event

2019-06-28 Thread Robert Beckett
Warn when about to send stale vblank info and add advice to documentation on how to avoid. Signed-off-by: Robert Beckett Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_vblank.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/drm_vblank.c

[PATCH v5 0/2] handle vblank when disabling ctc with interrupt disabled

2019-06-28 Thread Robert Beckett
Add warning when about to send stale vblank. Revert change that stops vblank info being updated if interrupts already disabled. This fixes a stale vblank timestamp issue seen on drm/imx. Changes since v2: Split up the patch in to smaller pieces. Add warning when about to send bogus vblank event.

[PATCH][next] drm/amdgpu: fix off-by-one comparison on a WARN_ON message

2019-06-28 Thread Colin King
From: Colin Ian King The WARN_ON is currently throwing a warning when i is 65 or higher which is off by one. It should be 64 or higher (64 queues from 0..63 inclusive), so fix this off-by-one comparison. Fixes: 849aca9f9c03 ("drm/amdgpu: Move common code to amdgpu_gfx.c") Signed-off-by: Colin

Re: [PATCH] drm/amdgpu: Don't skip display settings in hwmgr_resume()

2019-06-28 Thread Alex Deucher
On Thu, Jun 20, 2019 at 7:22 PM Lyude Paul wrote: > > I'm not entirely sure why this is, but for some reason: > > 921935dc6404 ("drm/amd/powerplay: enforce display related settings only on > needed") > > Breaks runtime PM resume on the Radeon PRO WX 3100 (Lexa) in one the > pre-production

Re: [PATCH v5 06/12] drm/modes: Support modes names on the command line

2019-06-28 Thread Maxime Ripard
Hi Thierry, On Wed, Jun 26, 2019 at 05:26:59PM +0200, Thierry Reding wrote: > On Mon, Jun 17, 2019 at 04:51:33PM +0200, Maxime Ripard wrote: > > From: Maxime Ripard > > > > The drm subsystem also uses the video= kernel parameter, and in the > > documentation refers to the fbdev documentation for

[Bug 110783] Mesa 19.1 rc crashing MPV with VAAPI

2019-06-28 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=110783 --- Comment #18 from Thomas Capricelli --- Just updated to 19.1.1 here, and the bug is still present, can't play mpv with vdpau driver. -- You are receiving this mail because: You are the assignee for the

Re: [PATCH v2] Adjust analogix chip driver location

2019-06-28 Thread Laurent Pinchart
Hello Xin Ji, Thank you for the patch. On Fri, Jun 28, 2019 at 03:00:05AM +, Xin Ji wrote: > Move analogix chip ANX78XX bridge driver into "analogix" directory. > > Signed-off-by: Xin Ji Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/Kconfig | 10

Re: [PATCH] drm/armada: fix debugfs link error

2019-06-28 Thread Arnd Bergmann
On Fri, Jun 28, 2019 at 2:48 PM Russell King - ARM Linux admin wrote: > > On Fri, Jun 28, 2019 at 12:33:40PM +0200, Arnd Bergmann wrote: > > Debugfs can be disabled at compile time, causing a link error > > with the newly restructured code: > > > > drivers/gpu/drm/armada/armada_crtc.o: In

Re: [PATCH 12/12] fbdev: da8xx: use resource management for dma

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Use managed variants of dma alloc functions in the da8xx fbdev driver. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute

Re: [PATCH 11/12] fbdev: da8xx-fb: drop a redundant if

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > The driver data is always set in probe. The remove() callback won't be > called if probe failed which is the only way for it to be NULL. Remove > the redundant if. > > Signed-off-by: Bartosz Golaszewski Acked-by:

Re: [PATCH 10/12] fbdev: da8xx-fb: use devm_platform_ioremap_resource()

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Shrink the code a bit by using the new helper wrapping the calls to > platform_get_resource() and devm_ioremap_resource() together. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best

Re: [PATCH 09/12] fbdev: da8xx: remove panel_power_ctrl() callback from platform data

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There are no more users of panel_power_ctrl(). Remove it from the > driver. > > Signed-off-by: Bartosz Golaszewski Acked-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej Zolnierkiewicz Samsung R

Re: [PATCH 07/12] fbdev: da8xx: add support for a regulator

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > We want to remove the hacky platform data callback for power control. > Add a regulator to the driver data and enable/disable it next to > the current panel_power_ctrl() calls. We will use it in subsequent > patch on

Re: [PATCH 03/12] backlight: gpio: pull the non-pdata device probing code into probe()

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > There's no good reason to have the generic probing code in a separate > routine. This function is short and is inlined by the compiler anyway. > Move it into probe under the pdata-specific part. > > Signed-off-by:

Re: [PATCH 02/12] backlight: gpio: use a helper variable for >dev

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Instead of dereferencing pdev each time, use a helper variable for > the associated device pointer. > > Signed-off-by: Bartosz Golaszewski Reviewed-by: Bartlomiej Zolnierkiewicz Best regards, -- Bartlomiej

Re: [PATCH 01/12] backlight: gpio: allow to probe non-pdata devices from board files

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/25/19 6:34 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Currently we can only probe devices that either use device tree or pass > platform data to probe(). Rename gpio_backlight_probe_dt() to > gpio_backlight_probe_prop() and use generic device properties instead > of OF

Re: [Freedreno] [PATCH] drm/msm: correct NULL pointer dereference in context_init

2019-06-28 Thread Rob Clark
On Wed, Jun 26, 2019 at 7:05 PM Brian Masney wrote: > > Correct attempted NULL pointer dereference in context_init() when > running without an IOMMU. > > Signed-off-by: Brian Masney > Fixes: 295b22ae596c ("drm/msm: Pass the MMU domain index in struct > msm_file_private") > --- > The no IOMMU

Re: [PATCH 37/39] docs: adds some directories to the main documentation index

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 2:30 PM, Mauro Carvalho Chehab wrote: > The contents of those directories were orphaned at the documentation > body. > > While those directories could likely be moved to be inside some guide, > I'm opting to just adding their indexes to the main one, removing the > :orphan: and

Re: [PATCH 28/39] docs: admin-guide: add a series of orphaned documents

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 2:30 PM, Mauro Carvalho Chehab wrote: > There are lots of documents that belong to the admin-guide but > are on random places (most under Documentation root dir). > > Move them to the admin guide. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Bartlomiej Zolnierkiewicz > ---

Re: [PATCH 11/43] docs: console.txt: convert docs to ReST and rename to *.rst

2019-06-28 Thread Bartlomiej Zolnierkiewicz
On 6/28/19 2:20 PM, Mauro Carvalho Chehab wrote: > Convert this small file to ReST in preparation for adding it to > the driver-api book. > > While this is not part of the driver-api book, mark it as > :orphan:, in order to avoid build warnings. > > Signed-off-by: Mauro Carvalho Chehab >

Re: [PATCH] drm/armada: fix debugfs link error

2019-06-28 Thread Russell King - ARM Linux admin
On Fri, Jun 28, 2019 at 12:33:40PM +0200, Arnd Bergmann wrote: > Debugfs can be disabled at compile time, causing a link error > with the newly restructured code: > > drivers/gpu/drm/armada/armada_crtc.o: In function > `armada_drm_crtc_late_register': > armada_crtc.c:(.text+0x974): undefined

[PATCH 29/39] docs: driver-api: add a series of orphaned documents

2019-06-28 Thread Mauro Carvalho Chehab
There are lots of documents under Documentation/*.txt and a few other orphan documents elsehwere that belong to the driver-API book. Move them to their right place. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/removed/sysfs-class-rfkill | 2 +-

[PATCH 28/39] docs: admin-guide: add a series of orphaned documents

2019-06-28 Thread Mauro Carvalho Chehab
There are lots of documents that belong to the admin-guide but are on random places (most under Documentation root dir). Move them to the admin guide. Signed-off-by: Mauro Carvalho Chehab --- Documentation/ABI/stable/sysfs-devices-node | 2 +- Documentation/ABI/testing/procfs-diskstats

[PATCH 37/39] docs: adds some directories to the main documentation index

2019-06-28 Thread Mauro Carvalho Chehab
The contents of those directories were orphaned at the documentation body. While those directories could likely be moved to be inside some guide, I'm opting to just adding their indexes to the main one, removing the :orphan: and adding the SPDX header. For the drivers, the rationale is that the

[PATCH 2/4] drm/bochs: Remove PRIME helpers from driver structure

2019-06-28 Thread Thomas Zimmermann
VRAM PRIME helpers are now called through GEM object functions. The driver callback functions are obsolete. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/bochs/bochs_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/bochs/bochs_drv.c

[PATCH 1/4] drm/vram: Set GEM object functions for PRIME

2019-06-28 Thread Thomas Zimmermann
PRIME functionality is now provided via the callback functions in struct drm_gem_object_funcs. The driver-structure functions are obsolete. As a side effect of this patch, VRAM-based drivers get basic PRIME support automatically without having to set any flags or additional fields. Signed-off-by:

[PATCH 3/4] drm/hibmc: Leave struct drm_driver.gem_free_object_unlocked to NULL

2019-06-28 Thread Thomas Zimmermann
The GEM object's free function is now called through struct drm_gem_object_funcs.free. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c

[PATCH 0/4] Convert VRAM helpers to GEM object functions

2019-06-28 Thread Thomas Zimmermann
The PRIME callback functions in struct drm_driver are deprecated in favor of their counterparts in struct drm_gem_object_funcs. This patch set introduces GEM object functions for VRAM helpers and converts over the free and PRIME functions. Drivers affected by this change, namely bochs and hibmc,

[PATCH 4/4] drm/vram: Remove driver callback functions for PRIME

2019-06-28 Thread Thomas Zimmermann
PRIME functionality is now provided by GEM object functions. The driver callback functions are obsolete. Signed-off-by: Thomas Zimmermann --- Documentation/gpu/todo.rst| 4 +- drivers/gpu/drm/drm_gem_vram_helper.c | 118 -- include/drm/drm_gem_vram_helper.h

[PATCH 04/43] docs: locking: convert docs to ReST and rename to *.rst

2019-06-28 Thread Mauro Carvalho Chehab
Convert the locking documents to ReST and add them to the kernel development book where it belongs. Most of the stuff here is just to make Sphinx to properly parse the text file, as they're already in good shape, not requiring massive changes in order to be parsed. The conversion is actually:

[PATCH 34/43] docs: ioctl: convert to ReST

2019-06-28 Thread Mauro Carvalho Chehab
Rename the iio documentation files to ReST, add an index for them and adjust in order to produce a nice html output via the Sphinx build system. The cdrom.txt and hdio.txt have their own particular syntax. In order to speedup the conversion, I used a small ancillary perl script: my $d;

[PATCH 11/43] docs: console.txt: convert docs to ReST and rename to *.rst

2019-06-28 Thread Mauro Carvalho Chehab
Convert this small file to ReST in preparation for adding it to the driver-api book. While this is not part of the driver-api book, mark it as :orphan:, in order to avoid build warnings. Signed-off-by: Mauro Carvalho Chehab Acked-by: Greg Kroah-Hartman --- .../console/{console.txt =>

[PATCH] drm/selftests: reduce stack usage

2019-06-28 Thread Arnd Bergmann
Putting a large drm_connector object on the stack can lead to warnings in some configuration, such as: drivers/gpu/drm/selftests/test-drm_cmdline_parser.c:18:12: error: stack frame size of 1040 bytes in function 'drm_cmdline_test_res' [-Werror,-Wframe-larger-than=] static int

[PATCH v5 09/12] drm/virtio: rework virtio_gpu_object_create fencing

2019-06-28 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. v5: fix fencing (Chia-I Wu). v3: Due to using the gem reservation object it is initialized and ready for use before calling ttm_bo_init, so we can also drop the tricky fence logic which checks whenever the command

[PATCH v5 02/12] drm/virtio: switch virtio_gpu_wait_ioctl() to gem helper.

2019-06-28 Thread Gerd Hoffmann
Use drm_gem_reservation_object_wait() in virtio_gpu_wait_ioctl(). This also makes the ioctl run lockless. v5: handle lookup failure. v2: use reservation_object_test_signaled_rcu for VIRTGPU_WAIT_NOWAIT. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter ---

[PATCH v5 01/12] drm/virtio: pass gem reservation object to ttm init

2019-06-28 Thread Gerd Hoffmann
With this gem and ttm will use the same reservation object, so mixing and matching ttm / gem reservation helpers should work fine. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_object.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[PATCH v5 06/12] drm/virtio: remove ttm calls from in virtio_gpu_object_{reserve, unreserve}

2019-06-28 Thread Gerd Hoffmann
Call reservation_object_* directly instead of using ttm_bo_{reserve,unreserve}. v4: check for EINTR only. v3: check for EINTR too. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH v5 04/12] drm/virtio: remove virtio_gpu_object_wait

2019-06-28 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h| 1 - drivers/gpu/drm/virtio/virtgpu_object.c | 13 - 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[PATCH v5 12/12] drm/virtio: remove virtio_gpu_alloc_object

2019-06-28 Thread Gerd Hoffmann
Thin wrapper around virtio_gpu_object_create(), but calling that directly works equally well. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 drivers/gpu/drm/virtio/virtgpu_gem.c | 23 ---

[PATCH v5 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing

2019-06-28 Thread Gerd Hoffmann
Use gem reservation helpers and direct reservation_object_* calls instead of ttm. v5: fix fencing (Chia-I Wu). v3: Also attach the array of gem objects to the virtio command buffer, so we can drop the object references in the completion callback. Needed because ttm fence helpers grab a reference

[PATCH v5 11/12] drm/virtio: switch from ttm to gem shmem helpers

2019-06-28 Thread Gerd Hoffmann
virtio-gpu basically needs a sg_table for the bo, to tell the host where the backing pages for the object are. So the gem shmem helpers are a perfect fit. Some drm_gem_object_funcs need thin wrappers to update the host state, but otherwise the helpers handle everything just fine. Once the

[PATCH v5 05/12] drm/virtio: drop no_wait argument from virtio_gpu_object_reserve

2019-06-28 Thread Gerd Hoffmann
All callers pass no_wait = false. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 5 ++--- drivers/gpu/drm/virtio/virtgpu_gem.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 4 ++-- 3 files changed, 6 insertions(+), 7 deletions(-)

[PATCH v5 03/12] drm/virtio: simplify cursor updates

2019-06-28 Thread Gerd Hoffmann
No need to do the reservation dance, we can just wait on the fence directly. Signed-off-by: Gerd Hoffmann Reviewed-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_plane.c | 13 +++-- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git

[PATCH v5 00/12] drm/virtio: switch from ttm to gem shmem helpers.

2019-06-28 Thread Gerd Hoffmann
ttm increasingly gets into the way while hacking on virtio-gpu memory management. It also overkill for what virtio-gpu needs. Lets get rid of it. v5: - fence bugfixes. - minor optimizations. v4: - make gem array helpers private to virtio. - misc minor fixes. v3: - add gem array helpers. -

[PATCH v5 07/12] drm/virtio: add virtio_gpu_object_array & helpers

2019-06-28 Thread Gerd Hoffmann
Some helper functions to manage an array of gem objects. v5: some small optimizations (Chia-I Wu). v4: make them virtio-private instead of generic helpers. Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/virtio/virtgpu_drv.h | 10 +++ drivers/gpu/drm/virtio/virtgpu_gem.c | 45

[PATCH v5 10/12] drm/virtio: drop virtio_gpu_object_list_validate/virtio_gpu_unref_list

2019-06-28 Thread Gerd Hoffmann
No users left. Signed-off-by: Gerd Hoffmann Acked-by: Daniel Vetter --- drivers/gpu/drm/virtio/virtgpu_drv.h | 3 -- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 39 -- 2 files changed, 42 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

Re: [PATCH v4 2/2] Revert "drm/vblank: Do not update vblank count if interrupts are already disabled."

2019-06-28 Thread Ville Syrjälä
On Fri, Jun 28, 2019 at 01:05:32PM +0100, Robert Beckett wrote: > If interrupts are already disabled, then the timestamp for the vblank > does not get updated, causing a stale timestamp to be reported to > userland while disabling crtcs. > > This reverts commit

  1   2   >