Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-23 Thread Christoph Hellwig
On Mon, Jul 22, 2019 at 09:09:25PM -0700, John Stultz wrote: > On Thu, Jul 18, 2019 at 3:06 AM Christoph Hellwig wrote: > > > > > +void INIT_HEAP_HELPER_BUFFER(struct heap_helper_buffer *buffer, > > > + void (*free)(struct heap_helper_buffer *)) > > > > Please use a lower

Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-23 Thread Christoph Hellwig
On Tue, Jul 23, 2019 at 01:09:55PM -0700, Rob Clark wrote: > On Mon, Jul 22, 2019 at 9:09 PM John Stultz wrote: > > > > On Thu, Jul 18, 2019 at 3:06 AM Christoph Hellwig > > wrote: > > > > > > Is there any exlusion between mmap / vmap and the device accessing > > > the data? Without that you ar

[PATCH v3 0/7] drivers: Add generic device lookup helpers

2019-07-23 Thread Suzuki K Poulose
We have device iterators to find a particular device matching a criteria for a given bus/class/driver. i.e, {bus,class,driver}_find_device() APIs. The matching criteria is a function pointer for the APIs. Often the lookup is based on a generic property of a device (e.g, name, fwnode, of node pointe

Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+79f5f028005a77ecb...@syzkaller.appspotmail.com Tested on: commit: decb705e libbpf: fix using uninitialized ioctl results git tree: bpf kernel config: https:

[PATCH v3 2/7] drivers: Introduce device lookup variants by of_node

2019-07-23 Thread Suzuki K Poulose
Introduce wrappers for {bus/driver/class}_find_device() to locate devices by its of_node. Cc: Maarten Lankhorst Cc: Maxime Ripard Cc: dri-devel@lists.freedesktop.org Cc: David Airlie Cc: Daniel Vetter Cc: devicet...@vger.kernel.org Cc: Florian Fainelli Cc: Frank Rowand Cc: Heiko Stuebner Cc

[PATCH v1] backlight: lm3630a: Switch to use fwnode_property_count_uXX()

2019-07-23 Thread Andy Shevchenko
Use use fwnode_property_count_uXX() directly, that makes code neater. Signed-off-by: Andy Shevchenko --- drivers/video/backlight/lm3630a_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index b

[PATCH] mm/hmm: replace hmm_update with mmu_notifier_range

2019-07-23 Thread Ralph Campbell
The hmm_mirror_ops callback function sync_cpu_device_pagetables() passes a struct hmm_update which is a simplified version of struct mmu_notifier_range. This is unnecessary so replace hmm_update with mmu_notifier_range directly. Signed-off-by: Ralph Campbell Cc: "Jérôme Glisse" Cc: Jason Gunthor

Re: [PATCH v2] drm/tegra: sor: Enable HDA interrupts at plugin

2019-07-23 Thread Viswanath L
Hello Dmitry, I have pushed new patch set v3 (https://patchwork.ozlabs.org/patch/1135605/). Request you to kindly review. Thanks. On 7/23/2019 3:48 PM, Dmitry Osipenko wrote: 23.07.2019 13:11, Viswanath L пишет: Thanks for your comments, Dmitry. Please see my responses inline. On 7/23/2019 6

Re: [PATCH] drm/syncobj: extend syncobj query ability v2

2019-07-23 Thread zhoucm1
On 2019年07月24日 03:20, Lionel Landwerlin wrote: On 23/07/2019 17:21, Chunming Zhou wrote: user space needs a flexiable query ability. So that umd can get last signaled or submitted point. v2: add sanitizer checking. Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea Signed-off-by: Chunming Z

Re: [PATCH] drm/mediatek: make imported PRIME buffers contiguous

2019-07-23 Thread CK Hu
Hi, Alexandre: On Tue, 2019-07-23 at 14:34 +0900, Alexandre Courbot wrote: > This driver requires imported PRIME buffers to appear contiguously in > its IO address space. Make sure this is the case by setting the maximum > DMA segment size to a better value than the default 64K on the DMA > device

[Bug 111206] Book our girls available in Bangalore Escorts

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111206 Bug ID: 111206 Summary: Book our girls available in Bangalore Escorts Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

[Bug 111205] Get your personal models in Jaipur Escorts

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111205 Bug ID: 111205 Summary: Get your personal models in Jaipur Escorts Product: DRI Version: DRI git Hardware: Other OS: All Status: NEW Severity: normal

Re: [PATCH] rpi_touchscreen_probe: check for failure case

2019-07-23 Thread Sam Ravnborg
Hi Navid. Thanks for your patch. On Tue, Jul 23, 2019 at 09:56:43PM -0500, Navid Emamdoost wrote: > of_graph_get_next_endpoint may return NULL, so null check is needed. > > Signed-off-by: Navid Emamdoost The patch looks fine, but could you please audit the other calls in the probe function. For

[PATCH v3 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*() varia

[PATCH v3 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v3 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Hi, I apologize for the extra emails (v2 was sent pretty recently), but I didn't want to leave a known-broken version sitting out there, creating problems. Changes since v2: * Critical bug fix: remove a stray "break;" from the new routine. Changes since v1: * Instead of pr

Re: [PATCH] drm/mediatek: make imported PRIME buffers contiguous

2019-07-23 Thread Tomasz Figa
On Tue, Jul 23, 2019 at 2:34 PM Alexandre Courbot wrote: > > This driver requires imported PRIME buffers to appear contiguously in > its IO address space. Make sure this is the case by setting the maximum > DMA segment size to a better value than the default 64K on the DMA > device, and use said D

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #63 from Mauro Gaspari --- (In reply to Sylvain BERTRAND from comment #62) > unstable power supply lines to the gpu if overheating is excluded? I cannot speak for others. In my case,U would say no. I installed windows10 in a separat

Re: [RFC PATCH] fbcon: fix ypos over boundary issue

2019-07-23 Thread Zenghui Yu
Hi Bartlomiej, On 2019/7/23 23:59, Bartlomiej Zolnierkiewicz wrote: On 7/12/19 5:13 AM, Zenghui Yu wrote: From: Feng Tiantian While using "top" on a CentOS guest's VNC-client, then continuously press "Shift+PgUp", the guest kernel will get panic! Backtrace is attached below. We tested it on

Reminder: 1 open syzbot bug in drm subsystem

2019-07-23 Thread Eric Biggers
[This email was generated by a script. Let me know if you have any suggestions to make it better, or if you want it re-generated with the latest status.] Of the currently open syzbot reports against the upstream kernel, I've manually marked 1 of them as possibly being a bug in the drm subsystem.

[PATCH] rpi_touchscreen_probe: check for failure case

2019-07-23 Thread Navid Emamdoost
of_graph_get_next_endpoint may return NULL, so null check is needed. Signed-off-by: Navid Emamdoost --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/drm/panel/panel

Re: [PATCH -next] drm/mediatek: Remove duplicated include from mtk_drm_drv.c

2019-07-23 Thread CK Hu
Hi, YueHaibing: On Wed, 2019-07-24 at 01:33 +, YueHaibing wrote: > Remove duplicated include. > > Signed-off-by: YueHaibing Reviewed-by: CK Hu > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c >

[PATCH -next] drm/mga: remove set but not used variable 'buf_priv'

2019-07-23 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/mga/mga_state.c: In function 'mga_dma_iload': drivers/gpu/drm/mga/mga_state.c:945:22: warning: variable 'buf_priv' set but not used [-Wunused-but-set-variable] It is never used, so can be removed. Reported-by: Hulk Robot Signed-off

Re: [PATCH v2 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread John Hubbard
On 7/23/19 6:26 PM, john.hubb...@gmail.com wrote: > From: John Hubbard ... > + * 2) This code sees the page as clean, so it calls > + * set_page_dirty(). The page stays dirty, despite being > + * written back, so it gets written back again in the > +

[PATCH -next] drm/mediatek: Remove duplicated include from mtk_drm_drv.c

2019-07-23 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index 2ee809a6f3dc..e3b64a266dcf 100644 --- a/drivers/gpu/drm/mediat

[PATCH v2 0/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Changes since v1: * Instead of providing __put_user_pages(), add an argument to put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following points: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), i

[PATCH v2 1/3] mm/gup: add make_dirty arg to put_user_pages_dirty_lock()

2019-07-23 Thread john . hubbard
From: John Hubbard Provide more capable variation of put_user_pages_dirty_lock(), and delete put_user_pages_dirty(). This is based on the following: 1. Lots of call sites become simpler if a bool is passed into put_user_page*(), instead of making the call site choose which put_user_page*() varia

[PATCH v2 2/3] drivers/gpu/drm/via: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v2 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread john . hubbard
From: John Hubbard For pages that were retained via get_user_pages*(), release those pages via the new put_user_page*() routines, instead of via put_page() or release_pages(). This is part a tree-wide conversion, as described in commit fc1d8e7cca2d ("mm: introduce put_user_page*(), placeholder v

[PATCH v7 5/5] kselftests: Add dma-heap test

2019-07-23 Thread John Stultz
Add very trivial allocation and import test for dma-heaps, utilizing the vgem driver as a test importer. A good chunk of this code taken from: tools/testing/selftests/android/ion/ionmap_test.c Originally by Laura Abbott Cc: Benjamin Gaignard Cc: Sumit Semwal Cc: Liam Mark Cc: Pratik Patel

[PATCH v7 1/5] dma-buf: Add dma-buf heaps framework

2019-07-23 Thread John Stultz
From: "Andrew F. Davis" This framework allows a unified userspace interface for dma-buf exporters, allowing userland to allocate specific types of memory for use in dma-buf sharing. Each heap is given its own device node, which a user can allocate a dma-buf fd from using the DMA_HEAP_IOC_ALLOC.

[PATCH v7 0/5] DMA-BUF Heaps (destaging ION)

2019-07-23 Thread John Stultz
Here is yet another pass at the dma-buf heaps patchset Andrew and I have been working on which tries to destage a fair chunk of ION functionality. The patchset implements per-heap devices which can be opened directly and then an ioctl is used to allocate a dmabuf from the heap. The interface is s

[PATCH v7 4/5] dma-buf: heaps: Add CMA heap to dmabuf heaps

2019-07-23 Thread John Stultz
This adds a CMA heap, which allows userspace to allocate a dma-buf of contiguous memory out of a CMA region. This code is an evolution of the Android ION implementation, so thanks to its original author and maintainters: Benjamin Gaignard, Laura Abbott, and others! Cc: Laura Abbott Cc: Benjami

[PATCH v7 3/5] dma-buf: heaps: Add system heap to dmabuf heaps

2019-07-23 Thread John Stultz
This patch adds system heap to the dma-buf heaps framework. This allows applications to get a page-allocator backed dma-buf for non-contiguous memory. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cr

[PATCH v7 2/5] dma-buf: heaps: Add heap helpers

2019-07-23 Thread John Stultz
Add generic helper dmabuf ops for dma heaps, so we can reduce the amount of duplicative code for the exported dmabufs. This code is an evolution of the Android ION implementation, so thanks to its original authors and maintainters: Rebecca Schultz Zavin, Colin Cross, Laura Abbott, and others! C

[PATCH 6/9 v2] drm/i915: Implement MST Aux device registration

2019-07-23 Thread sunpeng.li
From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Signed-off-by: Leo Li v2 changes: Unwind intel_connector_register on mst late register failure. --- drivers/gpu/drm/i915/displa

[PATCH 8/9] drm/radeon: Implement MST Aux device registration

2019-07-23 Thread sunpeng.li
From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Alex Deucher Cc: Harry Wentland Signed-off-by: Leo Li --- drivers/gpu/drm/radeon/radeon_dp_mst.c | 22

[PATCH 4/9] drm/bridge/analogix-anx78xx: Use connector kdev as aux device parent

2019-07-23 Thread sunpeng.li
From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. To do so, the connector needs to be registered beforehand. Therefore, shift aux registration to be after connector

[PATCH 9/9] drm/amd/display: Implement MST Aux device registration

2019-07-23 Thread sunpeng.li
From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Jerry Zuo Cc: Nicholas Kazlauskas Cc: Harry Wentland Signed-off-by: Leo Li --- .../display/amdgpu_dm/amdgpu_dm_mst_types.

[PATCH 5/9] drm/amd/display: Use connector kdev as aux device parent

2019-07-23 Thread sunpeng.li
From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. For example, the following udev rule: SUBSYSTEM=="drm_dp_aux_dev", SUBSYSTEMS=="drm", ATTRS{edid}=="*", SY

[PATCH 2/9 v3] drm/dp_mst: Enable registration of AUX devices for MST ports

2019-07-23 Thread sunpeng.li
From: Ville Syrjälä All available downstream ports - physical and logical - are exposed for each MST device. They are listed in /dev/, following the same naming scheme as SST devices by appending an incremental ID. Although all downstream ports are exposed, only some will work as expected. Consi

[PATCH 3/9] drm/nouveau: Use connector kdev as aux device parent

2019-07-23 Thread sunpeng.li
From: Leo Li Set the connector's kernel device as the parent for the aux kernel device. This allows udev rules to access connector attributes when creating symlinks to aux devices. Cc: Ben Skeggs Signed-off-by: Leo Li Reviewed-by: Lyude Paul --- drivers/gpu/drm/nouveau/nouveau_connector.c |

[PATCH 7/9] drm/nouveau/kms/nv50: Implement MST Aux device registration

2019-07-23 Thread sunpeng.li
From: Leo Li Implement late_register and early_unregister hooks for MST connectors. Call drm helpers for MST connector registration, which registers the AUX devices. Cc: Ben Skeggs Signed-off-by: Leo Li --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 20 1 file changed, 20

[PATCH 0/9] MST AUX Devices (v3)

2019-07-23 Thread sunpeng.li
From: Leo Li Here's what changed in v3: * Dropped patch to expose the mst-path device attribute, in lieu of ongoing discussion for defining a better connector path property * Change WARN_ON_ONCE -> DRM_ERROR on MST dpcd read errors to avoid tainting the kernel * Unwind intel_connector_regist

[PATCH 1/9] drm/dp: Use non-cyclic idr

2019-07-23 Thread sunpeng.li
From: Leo Li In preparation for adding aux devices for DP MST, make the IDR non-cyclic. That way, hotplug cycling MST devices won't needlessly increment the minor version index. Signed-off-by: Leo Li Reviewed-by: Lyude Paul Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/drm_dp_aux_dev.c | 3

Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread John Hubbard
On 7/23/19 11:06 AM, Ira Weiny wrote: > On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote: >> On 7/22/19 5:25 PM, Ira Weiny wrote: >>> On Mon, Jul 22, 2019 at 03:34:15PM -0700, john.hubb...@gmail.com wrote: ... >> Obviously, this stuff is all subject to a certain amount of opinion, but I

Re: [PATCH 1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread Daniel Vetter
On Tue, Jul 23, 2019 at 7:25 PM Adam Jackson wrote: > > On Tue, 2019-07-23 at 15:37 +0200, Linus Walleij wrote: > > Migrating the TI nspire calculators to use the PL111 driver for > > framebuffer requires grayscale support for the elder panel > > which uses 8bit grayscale only. > > > > DRM does no

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #62 from Sylvain BERTRAND --- unstable power supply lines to the gpu if overheating is excluded? -- You are receiving this mail because: You are the assignee for the bug.___ dri-devel mai

Re: [Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-23 Thread sylvain . bertrand
unstable power supply lines to the gpu if overheating is excluded? ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v4 2/4] drm/via: copy DRM_WAIT_ON as VIA_WAIT_ON and use it

2019-07-23 Thread Sam Ravnborg
VIA_WAIT_ON() is a direct copy of DRM_WAIT_ON() from drm_os_linux.h. The copy is made so we can avoid the dependency on the legacy header. A more involved approach had been to introduce wait_event_* but for this legacy driver the simpler and more safe approach with a copy of the macro was selected.

[PATCH v4 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-23 Thread Sam Ravnborg
The DRM_READ, DRM_WRITE macros comes from the deprecated drm_os_linux.h header file. Remove their use to remove this dependency. Replace the use of the macros with static inline variants. v4: - Use a more standard via_write8_mask() function (Emil) v3: - Use static inline functions, rather than m

[PATCH v4 4/4] drm/via: drop use of drmP.h

2019-07-23 Thread Sam Ravnborg
Drop use of the deprecated drmP.h header. While touching the files divide include files in blocks and sort the files alphabetically. v2: - Replace all uses of DRM_WAIT_ON() with VIA_WAIT_ON() and thus avoiding to pull in drm_os_linux.h v3: - DRM_WAIT_ON replacement moved to earlier patch (Emil)

[PATCH v4 3/4] drm/via: make via_drv.h self-contained

2019-07-23 Thread Sam Ravnborg
Added include of header files to make via_drv.h self-contained. v3: - Reworded changelog a little - to reflect that more than one header files are added Signed-off-by: Sam Ravnborg Reviewed-by: Emil Velikov Cc: Kevin Brace Cc: Thomas Hellstrom Cc: "Gustavo A. R. Silva" Cc: Mike Marshall C

[PATCH v4 0/4] drm/via: drop use of deprecated headers drmP.h + drm_os_linux.h

2019-07-23 Thread Sam Ravnborg
This is some janitorial updates to the via driver that is required to get rid of deprecated headers in the drm subsystem. The first three patches prepare for the removal of drmP.h. The last patch remove use of drmP.h and replace with necessary include files to fix build. Build tested with various

Re: [PATCH v6 2/5] dma-buf: heaps: Add heap helpers

2019-07-23 Thread Rob Clark
On Mon, Jul 22, 2019 at 9:09 PM John Stultz wrote: > > On Thu, Jul 18, 2019 at 3:06 AM Christoph Hellwig wrote: > > > > Is there any exlusion between mmap / vmap and the device accessing > > the data? Without that you are going to run into a lot of coherency > > problems. dma_fence is basically

Re: [PATCH] drm/syncobj: extend syncobj query ability v2

2019-07-23 Thread Lionel Landwerlin
On 23/07/2019 17:21, Chunming Zhou wrote: user space needs a flexiable query ability. So that umd can get last signaled or submitted point. v2: add sanitizer checking. Change-Id: I6512b430524ebabe715e602a2bf5abb0a7e780ea Signed-off-by: Chunming Zhou Cc: Lionel Landwerlin Cc: Christian König

Re: [PATCH v2 1/4] drm/via: drop use of DRM(READ|WRITE) macros

2019-07-23 Thread Sam Ravnborg
Hi Emil. > > > > Like this: > > > > static inline void via_write8_mask_or(struct drm_via_private *dev_priv, > > u32 reg, u32 mask) > > { > > u32 val; > > > > val = readb((void __iomem *)(dev_priv->mmio->handle + reg)); > > writeb(val

Re: [PATCH][next] drm/amd/display: fix a missing null check on a failed kzalloc

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 10:23 AM Colin King wrote: > > From: Colin Ian King > > Currently the allocation of config may fail and a null pointer > dereference on config can occur. Fix this by added a null > check on a failed allocation of config. > > Addresses-Coverity: ("Dereference null return")

Re: [PATCH] drm/radeon: Use dev_get_drvdata where possible

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/radeon/radeon_drv.c | 15 +-- > 1 file changed, 5 inser

Re: [PATCH] drm/amd/display: Use dev_get_drvdata

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- > 1 file changed, 1 inse

Re: [PATCH] drm/amdgpu: Use dev_get_drvdata where possible

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 9:36 AM Chuhong Yuan wrote: > > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Applied. thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 27 + > 1 file ch

Re: [PATCH][next] drm/amdgpu: remove redundant assignment to pointer 'ring'

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 9:41 AM Colin King wrote: > > From: Colin Ian King > > The pointer 'ring' is being assigned a value that is never > read, hence the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/gpu/dr

Re: [PATCH] drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines

2019-07-23 Thread Alex Deucher
On Tue, Jul 23, 2019 at 3:16 AM Nick Desaulniers wrote: > > arch/x86/Makefile disables SSE and SSE2 for the whole kernel. The > AMDGPU drivers modified in this patch re-enable SSE but not SSE2. Turn > on SSE2 to support emitting double precision floating point instructions > rather than calls to

[RFC PATCH 00/11] Simple QoS for exynos-bus driver using interconnect

2019-07-23 Thread Artur Świgoń
The following patchset adds interconnect[1][2] framework support to the exynos-bus devfreq driver. Extending the devfreq driver with interconnect capabilities started as a response to the issue referenced in [3]. The patches can be subdivided into four logical groups: (a) Refactoring the existing

[PATCH] drm/amd/display: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/dr

Re: hmm_range_fault related fixes and legacy API removal v2

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 06:11:04PM -0700, Ralph Campbell wrote: > > On 7/22/19 2:44 AM, Christoph Hellwig wrote: > > Hi Jérôme, Ben and Jason, > > > > below is a series against the hmm tree which fixes up the mmap_sem > > locking in nouveau and while at it also removes leftover legacy HMM APIs >

Re: hmm_range_fault related fixes and legacy API removal v2

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 11:44:20AM +0200, Christoph Hellwig wrote: > Hi Jérôme, Ben and Jason, > > below is a series against the hmm tree which fixes up the mmap_sem > locking in nouveau and while at it also removes leftover legacy HMM APIs > only used by nouveau. > > The first 4 patches are a bu

Re: [PATCH 2/6] mm: move hmm_vma_range_done and hmm_vma_fault to nouveau

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 11:44:22AM +0200, Christoph Hellwig wrote: > These two functions are marked as a legacy APIs to get rid of, but seem > to suit the current nouveau flow. Move it to the only user in > preparation for fixing a locking bug involving caller and callee. > All comments referring

Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread Dmitry Vyukov
On Wed, Jul 17, 2019 at 10:58 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=1398805860 > kernel config: https

Re: [PATCH 1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread Fabian Vogt
Hi, I gave the series a try (virtual CX and TP so far, will do on a real CX later): OOPS with a nullptr deref during probe. This diff which just moves some lines around fixes that and the LCD appears to work properly. Once I verified the 24bit depth and clock speed config on HW as well, I can giv

[PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory.

2019-07-23 Thread Tetsuo Handa
syzbot found that a thread can stall for minutes inside ion_system_heap_allocate() after that thread was killed by SIGKILL [1]. Let's check for SIGKILL before doing memory allocation. [1] https://syzkaller.appspot.com/bug?id=a0e3436829698d5824231251fad9d8e998f94f5e Signed-off-by: Tetsuo Handa R

[PATCH] drm/radeon: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/radeon/radeon_drv.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_drv.c b/drivers/gpu/drm

Re: [PATCH 5/6] nouveau: return -EBUSY when hmm_range_wait_until_valid fails

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 11:44:25AM +0200, Christoph Hellwig wrote: > -EAGAIN has a magic meaning for non-blocking faults, so don't overload > it. Given that the caller doesn't check for specific error codes this > change is purely cosmetic. > > Signed-off-by: Christoph Hellwig > --- > drivers/g

[PATCH -next] drm/amd/display: Make pow_buffer_ptr static

2019-07-23 Thread YueHaibing
Fix sparse warning: drivers/gpu/drm/amd/amdgpu/../display/modules/color/color_gamma.c:62:5: warning: symbol 'pow_buffer_ptr' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: YueHaibing --- drivers/gpu/drm/amd/display/modules/color/color_gamma.c | 2 +- 1 file chan

OLED panel brightness support

2019-07-23 Thread Kai-Heng Feng
Hi, Currently, OLED panel brightness [1] is not supported. We have a similar Dell system that also affect by lack of OLED brightness support. I’ve investigated both kernel and user space but I haven’t found a good general solution yet. Dell systems use EDID descriptor 4 as Dell specific des

Re: Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread John Fastabend
syzbot wrote: > > Dmitry Vyukov wrote: > >> On Wed, Jul 17, 2019 at 10:58 AM syzbot > >> wrote: > >> > > >> > Hello, > >> > > >> > syzbot found the following crash on: > >> > > >> > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > >> > git tree: linux-next > >> > console

Re: [PATCH 4/6] nouveau: unlock mmap_sem on all errors from nouveau_range_fault

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 11:44:24AM +0200, Christoph Hellwig wrote: > Currently nouveau_svm_fault expects nouveau_range_fault to never unlock > mmap_sem, but the latter unlocks it for a random selection of error > codes. Fix this up by always unlocking mmap_sem for non-zero return > values in nouvea

Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread John Fastabend
Dmitry Vyukov wrote: > On Wed, Jul 17, 2019 at 10:58 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > > git tree: linux-next > > console output: https://syzkaller.appspot.com/x/log.txt

Re: [PATCH 1/6] mm: always return EBUSY for invalid ranges in hmm_range_{fault,snapshot}

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 08:07:33PM +0530, Souptick Joarder wrote: > On Mon, Jul 22, 2019 at 3:14 PM Christoph Hellwig wrote: > > > > We should not have two different error codes for the same condition. In > > addition this really complicates the code due to the special handling of > > EAGAIN that

Re: Re: kernel panic: stack is corrupted in pointer

2019-07-23 Thread syzbot
Dmitry Vyukov wrote: On Wed, Jul 17, 2019 at 10:58 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:1438cde7 Add linux-next specific files for 20190716 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=139880586

[PATCH] drm/amdgpu: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 27 + 1 file changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c

[PATCH] drm/vmwgfx: Use dev_get_drvdata

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmw

[PATCH] drm/nouveau: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/nouveau/nouveau_drm.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouvea

[PATCH] drm/gma500: Use dev_get_drvdata where possible

2019-07-23 Thread Chuhong Yuan
Instead of using to_pci_dev + pci_get_drvdata, use dev_get_drvdata to make code simpler. Signed-off-by: Chuhong Yuan --- drivers/gpu/drm/gma500/power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/power.c b/drivers/gpu/drm/gma500/power.c index bea857

Re: [PATCH 3/6] nouveau: remove the block parameter to nouveau_range_fault

2019-07-23 Thread Jason Gunthorpe
On Mon, Jul 22, 2019 at 11:44:23AM +0200, Christoph Hellwig wrote: > The parameter is always false, so remove it as well as the -EAGAIN > handling that can only happen for the non-blocking case. ? Did the EAGAIN handling get removed in this patch? > Signed-off-by: Christoph Hellwig > drivers/gp

Re: [PATCH 4/6] nouveau: unlock mmap_sem on all errors from nouveau_range_fault

2019-07-23 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 07:23:35PM +0200, Christoph Hellwig wrote: > On Tue, Jul 23, 2019 at 02:17:31PM -0300, Jason Gunthorpe wrote: > > That reminds me, this code is also leaking hmm_range_unregister() in > > the success path, right? > > No, that is done by hmm_vma_range_done / nouveau_range_don

Re: [PATCH 4/6] nouveau: unlock mmap_sem on all errors from nouveau_range_fault

2019-07-23 Thread Jason Gunthorpe
On Tue, Jul 23, 2019 at 06:30:48PM +0200, Christoph Hellwig wrote: > On Tue, Jul 23, 2019 at 03:18:28PM +, Jason Gunthorpe wrote: > > Hum.. > > > > The caller does this: > > > > again: > > ret = nouveau_range_fault(&svmm->mirror, &range); > > if (ret == 0) { > >

[PATCH v19 10/15] drm/radeon: untag user pointers in radeon_gem_userptr_ioctl

2019-07-23 Thread Andrey Konovalov
This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In radeon_gem_userptr_ioctl() an MMU notifier is set up with a (tagged) userspace pointer. The untagged address should be u

[PATCH v19 09/15] drm/amdgpu: untag user pointers

2019-07-23 Thread Andrey Konovalov
This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. In amdgpu_gem_userptr_ioctl() and amdgpu_amdkfd_gpuvm.c/init_user_pages() an MMU notifier is set up with a (tagged) userspa

[PATCH v19 12/15] media/v4l2-core: untag user pointers in videobuf_dma_contig_user_get

2019-07-23 Thread Andrey Konovalov
This patch is a part of a series that extends kernel ABI to allow to pass tagged user pointers (with the top byte set to something else other than 0x00) as syscall arguments. videobuf_dma_contig_user_get() uses provided user pointers for vma lookups, which can only by done with untagged pointers.

[PATCH v19 00/15] arm64: untag user pointers passed to the kernel

2019-07-23 Thread Andrey Konovalov
=== Overview arm64 has a feature called Top Byte Ignore, which allows to embed pointer tags into the top byte of each pointer. Userspace programs (such as HWASan, a memory debugging tool [1]) might use this feature and pass tagged user pointers to the kernel through syscalls or other interfaces.

Re: [PATCH 0/3] RFT: PL111 DRM conversion of nspire

2019-07-23 Thread Sam Ravnborg
Hi Linus. On Tue, Jul 23, 2019 at 03:37:52PM +0200, Linus Walleij wrote: > So this is a cold-coded attempt to move the TI nspire over to > using DRM. It is more or less the last user of the old fbdev > driver so it is a noble cause and interesting usecase. Do we need to support arm,pl11x,tft-r0g0

Re: [PATCH 3/3] net/xdp: convert put_page() to put_user_page*()

2019-07-23 Thread Ira Weiny
On Mon, Jul 22, 2019 at 09:41:34PM -0700, John Hubbard wrote: > On 7/22/19 5:25 PM, Ira Weiny wrote: > > On Mon, Jul 22, 2019 at 03:34:15PM -0700, john.hubb...@gmail.com wrote: > > > From: John Hubbard > > > > > > For pages that were retained via get_user_pages*(), release those pages > > > via t

Re: [PATCH 2/3] RTF: drm/panel: simple: Add TI nspire panels

2019-07-23 Thread Sam Ravnborg
Hi Linus Good to see more panels and work on moving from fb to drm. Also good to use media_bus_format to signal this is a greyscale display. On Tue, Jul 23, 2019 at 03:37:54PM +0200, Linus Walleij wrote: > This adds support for the TI nspire panels to the simple panel > roster. This code is base

Re: [PATCH 1/3] RFT: drm/pl111: Support grayscale

2019-07-23 Thread Adam Jackson
On Tue, 2019-07-23 at 15:37 +0200, Linus Walleij wrote: > Migrating the TI nspire calculators to use the PL111 driver for > framebuffer requires grayscale support for the elder panel > which uses 8bit grayscale only. > > DRM does not support 8bit grayscale framebuffers in memory, > but by defining

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #61 from weden...@yandex.ru --- I've tried starting witcher 3 after executing echo manual > /sys/class/drm/card0/device/power_dpm_force_performance_level echo 7 > /sys/class/drm/card0/device/pp_dpm_sclk and it still crashes immediate

Re: [Intel-gfx] [PATCH] drm/i915: Use dev_get_drvdata

2019-07-23 Thread Chris Wilson
Quoting Chris Wilson (2019-07-23 17:25:17) > Quoting Chuhong Yuan (2019-07-23 11:39:16) > > Instead of using to_pci_dev + pci_get_drvdata, > > use dev_get_drvdata to make code simpler. > > > > Signed-off-by: Chuhong Yuan > > That cuts out some circumlocution, > Reviewed-by: Chris Wilson And pu

[PATCH] drm: rcar_lvds: Fix dual link mode operations

2019-07-23 Thread Jacopo Mondi
The R-Car LVDS encoder units support dual-link operations by splitting the pixel output between the primary encoder and the companion one. In order for the primary encoder to succesfully control the companion's operations this should not fail at probe time and register itself its associated drm br

[Bug 109955] amdgpu [RX Vega 64] system freeze while gaming

2019-07-23 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=109955 --- Comment #60 from weden...@yandex.ru --- A couple of relevant log fragments with crashes: https://paste.ee/p/rtDEg -- You are receiving this mail because: You are the assignee for the bug.___ dri-d

  1   2   3   >