Re: [PATCH] drm: pl111: enable render node

2020-04-23 Thread Eric Anholt
On Thu, Apr 23, 2020 at 3:35 PM Peter Collingbourne wrote: > > The render node is required by Android which does not support the legacy > drmAuth authentication process. There's no rendering engine on pl111, so only the control node makes sense for this HW since all this driver does is display.

[git pull] drm fixes for 5.7-rc3

2020-04-23 Thread Dave Airlie
Hey Linus, Weekly regular fixes for drm, The usual rc3 uptick here, but nothing too crazy or notable. Dave. drm-fixes-2020-04-24: drm fixes for 5.7-rc3 core: - mst: zero pbn when releasing vcpi slots amdgpu: - Fix resume issue on renoir - Thermal fix for older CI dGPUs - Fix some fallout from

RE: [PATCH] Revert "drm/dp_mst: Remove single tx msg restriction."

2020-04-23 Thread Lin, Wayne
[AMD Public Use] > -Original Message- > From: Wentland, Harry > Sent: Friday, April 24, 2020 1:53 AM > To: Lyude Paul ; dri-devel@lists.freedesktop.org > Cc: David Airlie ; linux-ker...@vger.kernel.org; Sean Paul > ; Thomas Zimmermann ; > Lin, Wayne ; Lin, Wayne > Subject: Re: [PATCH]

Re: [DPU PATCH v5 4/5] drm/msm/dp: add support for DP PLL driver

2020-04-23 Thread Stephen Boyd
Quoting Tanmay Shah (2020-03-31 17:30:30) > diff --git a/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > new file mode 100644 > index 000..aa845d0 > --- /dev/null > +++ b/drivers/gpu/drm/msm/dp/pll/dp_pll_10nm.c > @@ -0,0 +1,401 @@ > +//

[PATCH] drm: pl111: enable render node

2020-04-23 Thread Peter Collingbourne
The render node is required by Android which does not support the legacy drmAuth authentication process. Signed-off-by: Peter Collingbourne --- drivers/gpu/drm/pl111/pl111_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/pl111/pl111_drv.c

Re: [PATCH v6 03/10] PM / EM: update callback structure and add device pointer

2020-04-23 Thread Lukasz Luba
Hi Daniel, On 4/23/20 2:22 PM, Daniel Lezcano wrote: On Fri, Apr 10, 2020 at 09:42:03AM +0100, Lukasz Luba wrote: The Energy Model framework is going to support devices other that CPUs. In order to make this happen change the callback function and add pointer to a device as an argument.

Re: [PATCH v6 07/10] Documentation: power: update Energy Model description

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:07AM +0100, Lukasz Luba wrote: > The Energy Model framework supports also other devices than CPUs. Update > related information and add description for the new usage. > > Signed-off-by: Lukasz Luba > --- Acked-by: Daniel Lezcano

[PATCH v3 2/9] drm/msm: add internal MSM_BO_MAP_PRIV flag

2020-04-23 Thread Jonathan Marek
This flag sets IOMMU_PRIV, which is required for some a6xx GMU objects. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gem.c | 3 +++ drivers/gpu/drm/msm/msm_gem.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/msm/msm_gem.c

Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model

2020-04-23 Thread Lukasz Luba
On 4/23/20 4:12 PM, Daniel Lezcano wrote: On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: Add support for other devices that CPUs. The registration function does not require a valid cpumask pointer and is ready to handle new devices. Some of the internal structures has been

Re: [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Guru Das Srinagesh
On Thu, Apr 23, 2020 at 12:48:57PM +0100, Lee Jones wrote: > What's the merge plan for this set? I'm not sure what you mean. My assumption is that first all the patches need to get an Acked-by and only then will the series get applied by Thierry... Could Thierry or Uwe weigh in on this point

[PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Dejin Zheng
A call of the function ¡°do_take_over_console¡± can fail here. The corresponding system resources were not released then. Thus add a call of the function ¡°iounmap¡± together with the check of a failure predicate. Fixes: e84de0c6190503 ("MIPS: GIO bus support for SGI IP22/28") CC: Andy Shevchenko

Re: [PATCH v6 02/10] PM / EM: introduce em_dev_register_perf_domain function

2020-04-23 Thread Daniel Lezcano
On 10/04/2020 10:42, Lukasz Luba wrote: > Add now function in the Energy Model framework which is going to support > new devices. This function will help in transition and make it smoother. > For now it still checks if the cpumask is a valid pointer, which will be > removed later when the new

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Tue, Apr 21, 2020 at 06:42:17PM +0200, Philipp Rossak wrote: > Hi, > > On 21.04.20 13:21, Maxime Ripard wrote: > > Hi, > > > > On Tue, Apr 21, 2020 at 11:57:33AM +0200, Philipp Rossak wrote: > > > On 20.04.20 09:38, Maxime Ripard wrote: > > > > Hi, > > > > > > > > On Fri, Apr 17, 2020 at

[PATCH V6 0/4] Add support for WLED5

2020-04-23 Thread Kiran Gunda
Currently, WLED driver supports only WLED4 peripherals that is present on pmi8998 and pm660L. This patch series converts the existing WLED4 bindings from .txt to .yaml format and adds the support for WLED5 peripheral that is present on PM8150L. PM8150L WLED supports the following. - Two

[PATCH v3 9/9] drm/msm/a6xx: update a6xx_hw_init for A640 and A650

2020-04-23 Thread Jonathan Marek
Adreno 640 and 650 GPUs need some registers set differently. Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx.xml.h | 14 +++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 56 ++- 2 files changed, 61 insertions(+), 9 deletions(-) diff --git

Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model

2020-04-23 Thread Lukasz Luba
On 4/23/20 6:15 PM, Daniel Lezcano wrote: On 23/04/2020 18:57, Lukasz Luba wrote: On 4/23/20 4:12 PM, Daniel Lezcano wrote: On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: Add support for other devices that CPUs. The registration function does not require a valid cpumask

Re: WARNING: drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h:178 mdp5_bind

2020-04-23 Thread Naresh Kamboju
On Sun, 12 Apr 2020 at 15:08, Naresh Kamboju wrote: > > While booting stable-rc 4.14 branch kernel this warning was noticed on > Qualcomm APQ 8016 SBC (DT) Dragonboard 410c device. > > [8.459580] clk: failed to reparent byte0_clk_src to dsi0pllbyte: -22 > [8.459724] clk: failed to

[PATCH v3 3/9] drm/msm/a6xx: use msm_gem for GMU memory objects

2020-04-23 Thread Jonathan Marek
This gives more fine-grained control over how memory is allocated over the DMA api. In particular, it allows using an address range or pinning to a fixed address. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 115 ++

[PATCH v3] console: newport_con: fix an issue about leak related system resources

2020-04-23 Thread Dejin Zheng
A call of the function do_take_over_console() can fail here. The corresponding system resources were not released then. Thus add a call of iounmap() and release_mem_region() together with the check of a failure predicate. and also add release_mem_region() on device removal. Fixes: e86bb8acc0fdc

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread H. Nikolaus Schaller
Hi Neil, > Am 23.04.2020 um 17:00 schrieb Neil Armstrong : >> One thing we can learn is that "core" seems to be a de facto standard >> for the core clock-name. An alternative "gpu" is used by nvidia,gk20a.txt. > > Usually IPs needs a few clocks: > - pclk or apb or reg: the clock clocking the

[PATCH V6 4/4] backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs

2020-04-23 Thread Kiran Gunda
From: Subbaraman Narayanamurthy PM8150L WLED supports the following: - Two modulators and each sink can use any of the modulator - Multiple CABC selection options from which one can be selected/enabled - Multiple brightness width selection (12 bits to 15 bits) Signed-off-by:

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Maxime Ripard
On Thu, Apr 23, 2020 at 05:45:55PM +0200, H. Nikolaus Schaller wrote: > > Am 23.04.2020 um 17:00 schrieb Neil Armstrong : > >> One thing we can learn is that "core" seems to be a de facto standard > >> for the core clock-name. An alternative "gpu" is used by nvidia,gk20a.txt. > > > > Usually IPs

Re: [PATCH v6 08/10] OPP: refactor dev_pm_opp_of_register_em() and update related drivers

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:08AM +0100, Lukasz Luba wrote: > The Energy Model framework supports not only CPU devices. Drop the CPU > specific interface with cpumask and add struct device. Add also a return > value, user might use it. This new interface provides easy way to create > a simple

Re: [PATCH v6 09/10] thermal: devfreq_cooling: Refactor code and switch to use Energy Model

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:09AM +0100, Lukasz Luba wrote: > The overhauled Energy Model (EM) framework support also devfreq devices. > The unified API interface of the EM can be used in the thermal subsystem to > not duplicate code. The power table now is taken from EM structure and > there is

Re: console: Complete exception handling in newport_probe()

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote: > >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci > >> > >> How do you think about to extend presented software analysis approaches? > >> > > Sorry, I am not familiar

RE: [PATCH v4] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

2020-04-23 Thread Angelo Ribeiro
Hi Adrian, From: Adrian Ratiu Date: Thu, Apr 23, 2020 at 11:00:58 > This converts the Synopsis MIPI DSI binding documentation to yaml and > should be quite straightforward. I've added a missing ref clk and also > added Philippe as maintainer b/c he's the original txt author following > the

[PATCH v3 5/9] drm/msm/a6xx: HFI v2 for A640 and A650

2020-04-23 Thread Jonathan Marek
Add HFI v2 code paths required by Adreno 640 and 650 GPUs. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 66 --- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 7 ++ drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 6 +-

[PATCH v3 4/9] drm/msm/a6xx: add A640/A650 to gpulist

2020-04-23 Thread Jonathan Marek
Add Adreno 640 and 650 GPU info to the gpulist. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/adreno_device.c | 24 ++ drivers/gpu/drm/msm/adreno/adreno_gpu.c| 2 +- drivers/gpu/drm/msm/adreno/adreno_gpu.h| 10 + 3

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 05:52:09PM +0300, Andy Shevchenko wrote: > On Thu, Apr 23, 2020 at 5:26 PM Dejin Zheng wrote: > > > > A call of the function do_take_over_console() can fail here. > > The corresponding system resources were not released then. > > Thus add a call of the function iounmap()

Re: [PATCH v4 3/3] drm/bridge: chrontel-ch7033: Add a new driver

2020-04-23 Thread Lubomir Rintel
On Tue, Apr 21, 2020 at 02:54:12PM +0200, Daniel Vetter wrote: > On Tue, Mar 24, 2020 at 04:19:31PM +0100, Lubomir Rintel wrote: > > This is a driver for video encoder with VGA and DVI/HDMI outputs. > > > > There is no documentation for the chip -- the operation was guessed from > > what was

Re: console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
> Please note you are responding to someone who many kernel maintainers, > myself included, have on their blacklist You configured your communication filters for some reasons in this way. > as they are totally unhelpful. The development views can vary also around my software contributions. It

Re: [PATCH v6 05/10] PM / EM: remove em_register_perf_domain

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:05AM +0100, Lukasz Luba wrote: > Remove old function em_register_perf_domain which is no longer needed. > There is em_dev_register_perf_domain that covers old use cases and new as > well. > > Signed-off-by: Lukasz Luba Acked-by: Daniel Lezcano

Re: [PATCH v6 06/10] PM / EM: change name of em_pd_energy to em_cpu_energy

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:06AM +0100, Lukasz Luba wrote: > Energy Model framework supports now other devices than CPUs. Refactor some > of the functions in order to prevent wrong usage. The old function > em_pd_energy has to generic name. It must not be used without proper > cpumask pointer,

Re: [PATCH v1] console: fix an issue about ioremap leak.

2020-04-23 Thread Markus Elfring
> if do_take_over_console() return an error in the newport_probe(), > due to the io virtual address is not released, it will cause a leak. How do you think about a wording variant like the following? Subject: [PATCH v2] console: Complete exception handling in newport_probe() Change

[PULL] drm-misc-fixes

2020-04-23 Thread Maxime Ripard
Hi, Here is this week (and the first) drm-misc-fixes PR. Maxime drm-misc-fixes-2020-04-23: A few resources-related fixes (tidss, dp_mst, scheduler), probe fixes and DT bindings adjustments. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 04:55:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > I believe that the patch summary line should be: > > "[PATCH v2] console: newport_con: ..." > OK, thanks! > On 4/23/20 4:26 PM, Dejin Zheng wrote: > > A call of the function ¡°do_take_over_console¡± can fail

Re: [PATCH v1] console: fix an issue about ioremap leak.

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 01:10:14PM +0200, Markus Elfring wrote: > > if do_take_over_console() return an error in the newport_probe(), > > due to the io virtual address is not released, it will cause a leak. > > How do you think about a wording variant like the following? > >Subject: >

[PATCH V6 3/4] backlight: qcom-wled: Add WLED5 bindings

2020-04-23 Thread Kiran Gunda
Add WLED5 specific bindings. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by: Daniel Thompson --- .../bindings/leds/backlight/qcom-wled.yaml | 59 -- 1 file changed, 56 insertions(+), 3 deletions(-) diff --git

[PATCH v3 0/9] Add support for A640 and A650

2020-04-23 Thread Jonathan Marek
This series adds support for A640 and A650 GPUs. Missing bus scaling, hwcg, and UBWC config, but GPU works without those. Changes in V2: Use msm_gem for allocations (first 3 patches are new) Squashed pdc/rscc patches together Removed unnecessary "WARN_ON"s in "HFI v2 for A640 and A650" Changes

[PATCH v3 7/9] drm/msm/a6xx: update pdc/rscc GMU registers for A640/A650

2020-04-23 Thread Jonathan Marek
Update the gmu_pdc registers for A640 and A650. Some of the RSCC registers on A650 are in a separate region. Note this also changes the address of these registers: RSCC_TCS1_DRV0_STATUS RSCC_TCS2_DRV0_STATUS RSCC_TCS3_DRV0_STATUS Based on the values in msm-4.14 and msm-4.19 kernels. v3:

[PATCH v3 8/9] drm/msm/a6xx: enable GMU log

2020-04-23 Thread Jonathan Marek
This is required for a650 to work. Signed-off-by: Jonathan Marek Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + drivers/gpu/drm/msm/adreno/a6xx_gmu.xml.h | 4 3 files changed, 20

Re: [PATCH v1] drm/bochs: fix an issue of ioremap() leak

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 12:14:20PM +0200, Gerd Hoffmann wrote: > Hi, > > > I am a newbie, andy gave me some directions to submit the patch, eg: check > > ioremap leak. At this time, I found that the bochs driver may have similar > > problems, so I submitted this patch, then, Andy said the best

Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: > Add support for other devices that CPUs. The registration function > does not require a valid cpumask pointer and is ready to handle new > devices. Some of the internal structures has been reorganized in order to > keep consistent view

Re: console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci … > Sorry, I do not know how to use the SmPL script. I proposed to take another look at the header of such a file. I imagine that provided information can trigger further development

[PATCH V6 1/4] backlight: qcom-wled: convert the wled bindings to .yaml format

2020-04-23 Thread Kiran Gunda
Convert the qcom-wled bindings from .txt to .yaml format. Also replace PM8941 to WLED3 and PMI8998 to WLED4. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Acked-by: Daniel Thompson --- .../bindings/leds/backlight/qcom-wled.txt | 154 ---

[PATCH V6 2/4] backlight: qcom-wled: Add callback functions

2020-04-23 Thread Kiran Gunda
Add wled_cabc_config, wled_sync_toggle, wled_ovp_fault_status and wled_ovp_delay and wled_auto_detection_required callback functions to prepare the driver for adding WLED5 support. Signed-off-by: Kiran Gunda Signed-off-by: Subbaraman Narayanamurthy Reviewed-by: Daniel Thompson ---

Re: [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model

2020-04-23 Thread Daniel Lezcano
On 23/04/2020 18:57, Lukasz Luba wrote: > > > On 4/23/20 4:12 PM, Daniel Lezcano wrote: >> On Fri, Apr 10, 2020 at 09:42:04AM +0100, Lukasz Luba wrote: >>> Add support for other devices that CPUs. The registration function >>> does not require a valid cpumask pointer and is ready to handle new

Re: [PATCH v6 01/10] PM / EM: change naming convention from 'capacity' to 'performance'

2020-04-23 Thread Daniel Lezcano
On 10/04/2020 10:42, Lukasz Luba wrote: > The Energy Model uses concept of performance domain and capacity states in > order to calculate power used by CPUs. Change naming convention from > capacity to performance state would enable wider usage in future, e.g. > upcoming support for other devices

[PATCH v3 6/9] drm/msm/a6xx: A640/A650 GMU firmware path

2020-04-23 Thread Jonathan Marek
Newer GPUs have different GMU firmware path. v3: updated a6xx_gmu_fw_load based on feedback, including gmu_write_bulk, and removed extra whitespace change Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 138 +++---

Re: [PATCH v6 03/10] PM / EM: update callback structure and add device pointer

2020-04-23 Thread Daniel Lezcano
On Fri, Apr 10, 2020 at 09:42:03AM +0100, Lukasz Luba wrote: > The Energy Model framework is going to support devices other that CPUs. In > order to make this happen change the callback function and add pointer to > a device as an argument. > > Update the related users to use new function and new

stable-rc 4.14: Internal error: Oops: 96000004 - pc : __pi_strcmp+0x18/0x154

2020-04-23 Thread Naresh Kamboju
We still notice kernel warnings while booting stable rc 4.14.177-rc1 kernel on qualcomm dragonboard 410c development board. [7.760140] msm_dsi_host_set_src_pll: can't set parent to byte_clk_src. ret=-22 [7.763963] msm_dsi_manager_register: failed to register mipi dsi host for DSI 0 [

Re: [PATCH v1] fbdev: sm712fb: fix an issue about iounmap for a wrong address

2020-04-23 Thread Markus Elfring
> the sfb->fb->screen_base is not save the value get by iounmap() when > the chip id is 0x720. I suggest to improve this change description. How did you determine relevant differences for the mentioned chip model? > so iounmap() for address sfb->fb->screen_base is not right. Will another

[PATCH v3 1/9] drm/msm: add msm_gem_get_and_pin_iova_range

2020-04-23 Thread Jonathan Marek
This function allows pinning iova to a specific page range (for a6xx GMU). Signed-off-by: Jonathan Marek --- drivers/gpu/drm/msm/msm_drv.h | 6 +- drivers/gpu/drm/msm/msm_gem.c | 28 +--- drivers/gpu/drm/msm/msm_gem_vma.c | 6 -- 3 files changed, 30

Re: console: Complete exception handling in newport_probe()

2020-04-23 Thread Markus Elfring
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci >> >> How do you think about to extend presented software analysis approaches? >> > Sorry, I am not familiar with it, I don't know. Do you find the comments helpful at the beginning of

Re: [PATCH v1] fbdev: sm712fb: fix an issue about iounmap for a wrong address

2020-04-23 Thread Dejin Zheng
On Thu, Apr 23, 2020 at 02:14:48PM +0200, Markus Elfring wrote: > > the sfb->fb->screen_base is not save the value get by iounmap() when > > the chip id is 0x720. > > I suggest to improve this change description. > How did you determine relevant differences for the mentioned chip model? > Read

Re: [PATCH v3] console: newport_con: fix an issue about leak related system resources

2020-04-23 Thread Andy Shevchenko
On Thu, Apr 23, 2020 at 7:42 PM Dejin Zheng wrote: > > A call of the function do_take_over_console() can fail here. > The corresponding system resources were not released then. > Thus add a call of iounmap() and release_mem_region() > together with the check of a failure predicate. and also > add

Re: [PATCH][next] drm/amd/display: remove redundant assignment to variable ret

2020-04-23 Thread Alex Deucher
On Thu, Apr 23, 2020 at 10:18 AM Colin King wrote: > > From: Colin Ian King > > The variable ret is being initialized with a value that is never read > and it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

[PULL] drm-intel-fixes

2020-04-23 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2020-04-23: - Tigerlake Workaround - disabling media recompression (Matt) - Fix RPS interrupts for right GPU frequency (Chris) - HDCP fix prime check (Oliver) - Tigerlake Thunderbolt power well fix (Matt) - Tigerlake DP link training fixes (Jose) -

Re: [Intel-gfx] [PATCH] drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Manasi Navare
On Thu, Apr 23, 2020 at 06:17:43PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > The DispID DTD pixel clock is documented as: > "00 00 00 h → FF FF FF h | Pixel clock ÷ 10,000 0.01 → 167,772.16 Mega Pixels > per Sec" > Which seems to imply that we to add one to the raw value. > >

Re: [PATCH] Revert "drm/dp_mst: Remove single tx msg restriction."

2020-04-23 Thread Harry Wentland
On 2020-04-23 12:42 p.m., Lyude Paul wrote: > This reverts commit 6bb0942e8f46863a745489cce27efe5be2a3885e. > > Unfortunately it would appear that the rumors we've heard of sideband > message interleaving not being very well supported are true. On the > Lenovo ThinkPad Thunderbolt 3 dock that I

RE: [PATCH v2 6/9] drm/msm/a6xx: A640/A650 GMU firmware path

2020-04-23 Thread Ruhl, Michael J
>-Original Message- >From: Jonathan Marek >Sent: Tuesday, April 21, 2020 7:41 PM >To: freedr...@lists.freedesktop.org >Cc: Rob Clark ; Sean Paul ; David >Airlie ; Daniel Vetter ; Jordan Crouse >; Sharat Masetty ; >Ruhl, Michael J ; open list:DRM DRIVER FOR MSM >ADRENO GPU ; open list:DRM

Re: console: Complete exception handling in newport_probe()

2020-04-23 Thread Greg Kroah-Hartman
On Fri, Apr 24, 2020 at 01:02:45AM +0800, Dejin Zheng wrote: > On Thu, Apr 23, 2020 at 05:23:29PM +0200, Markus Elfring wrote: > > >> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/scripts/coccinelle/free/iounmap.cocci > > >> > > >> How do you think about to extend

Re: [PATCH v5 1/3] dt-bindings: phy: qcom,qmp: Convert QMP PHY bindings to yaml

2020-04-23 Thread Matthias Kaehlcke
Hi Sandeep, On Tue, Apr 14, 2020 at 02:21:17PM -0700, Stephen Boyd wrote: > Quoting Sandeep Maheswaram (2020-04-01 23:38:52) > > Convert QMP PHY bindings to DT schema format using json-schema. > > > > Signed-off-by: Sandeep Maheswaram > > --- > > .../devicetree/bindings/phy/qcom,qmp-phy.yaml

Re: [PATCH] Revert "drm/dp_mst: Remove single tx msg restriction."

2020-04-23 Thread Sean Paul
On Thu, Apr 23, 2020 at 12:42 PM Lyude Paul wrote: > > This reverts commit 6bb0942e8f46863a745489cce27efe5be2a3885e. > > Unfortunately it would appear that the rumors we've heard of sideband > message interleaving not being very well supported are true. On the > Lenovo ThinkPad Thunderbolt 3 dock

Re: [PATCH V6 4/4] backlight: qcom-wled: Add support for WLED5 peripheral that is present on PM8150L PMICs

2020-04-23 Thread Daniel Thompson
On Thu, Apr 23, 2020 at 09:03:37PM +0530, Kiran Gunda wrote: > From: Subbaraman Narayanamurthy > > PM8150L WLED supports the following: > - Two modulators and each sink can use any of the modulator > - Multiple CABC selection options from which one can be selected/enabled > -

[PATCH] Revert "drm/dp_mst: Remove single tx msg restriction."

2020-04-23 Thread Lyude Paul
This reverts commit 6bb0942e8f46863a745489cce27efe5be2a3885e. Unfortunately it would appear that the rumors we've heard of sideband message interleaving not being very well supported are true. On the Lenovo ThinkPad Thunderbolt 3 dock that I have, interleaved messages appear to just get dropped:

[PATCH v3 5/6] dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd

2020-04-23 Thread Douglas Anderson
The ti-sn65dsi86 MIPI DSI to eDP bridge chip has a dedicated hardware HPD (Hot Plug Detect) pin on it, but it's mostly useless for eDP because of excessive debouncing in hardware. Specifically there is no way to disable the debouncing and for eDP debouncing hurts you because HPD is just used for

[PATCH v3 2/6] dt-bindings: display: Add hpd-gpios to panel-common bindings

2020-04-23 Thread Douglas Anderson
In the cases where there is no connector in a system there's no great place to put "hpd-gpios". As per discussion [1] the best place to put it is in the panel. Add this to the device tree bindings. [1] https://lore.kernel.org/r/20200417180819.ge5...@pendragon.ideasonboard.com Signed-off-by:

[PATCH v3 6/6] arm64: dts: sdm845: Add "no-hpd" to sn65dsi86 on cheza

2020-04-23 Thread Douglas Anderson
We don't have the HPD line hooked up to the bridge chip. Add it as suggested in the patch ("dt-bindings: drm/bridge: ti-sn65dsi86: Document no-hpd"). NOTE: this patch isn't expected to have any effect but just keeps us cleaner for the future. Currently the driver in Linux just assumes that

[PATCH v3 4/6] dt-bindings: drm/bridge: ti-sn65dsi86: Convert to yaml

2020-04-23 Thread Douglas Anderson
This moves the bindings over, based a lot on toshiba,tc358768.yaml. Unless there's someone known to be better, I've set the maintainer in the yaml as the first person to submit bindings. Signed-off-by: Douglas Anderson --- Changes in v3: None Changes in v2: - specification => specifier. - power

[PATCH v3 3/6] drm/panel-simple: Support hpd-gpios for delaying prepare()

2020-04-23 Thread Douglas Anderson
People use panel-simple when they have panels that are builtin to their device. In these cases the HPD (Hot Plug Detect) signal isn't really used for hotplugging devices but instead is used for power sequencing. Panel timing diagrams (especially for eDP panels) usually have the HPD signal in

[PATCH v3 0/6] drm: Prepare to use a GPIO on ti-sn65dsi86 for Hot Plug Detect

2020-04-23 Thread Douglas Anderson
As talked about in commit c2bfc223882d ("drm/bridge: ti-sn65dsi86: Remove the mystery delay"), the normal HPD pin on ti-sn65dsi86 is kinda useless, at least for embedded DisplayPort (eDP). However, despite the fact that the actual HPD pin on the bridge is mostly useless for eDP, the concept of

[PATCH v3 1/6] drm/bridge: ti-sn65dsi86: Export bridge GPIOs to Linux

2020-04-23 Thread Douglas Anderson
The ti-sn65dsi86 MIPI DSI to eDP bridge chip has 4 pins on it that can be used as GPIOs in a system. Each pin can be configured as input, output, or a special function for the bridge chip. These are: - GPIO1: SUSPEND Input - GPIO2: DSIA VSYNC - GPIO3: DSIA HSYNC or VSYNC - GPIO4: PWM Let's

Re: [PATCH v2 5/9] drm/msm/a6xx: HFI v2 for A640 and A650

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:23PM -0400, Jonathan Marek wrote: > Add HFI v2 code paths required by Adreno 640 and 650 GPUs. I still feel like there is a chance for optimization here but the perfect is the enemy of the good and that would be a good follow on for the future. Reviewed-by: Jordan

Re: [PATCH v2 8/9] drm/msm/a6xx: enable GMU log

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:26PM -0400, Jonathan Marek wrote: > This is required for a650 to work. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 15 +++ > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 1 + >

Re: [PATCH v2 6/9] drm/msm/a6xx: A640/A650 GMU firmware path

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:24PM -0400, Jonathan Marek wrote: > Newer GPUs have different GMU firmware path. > > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 135 +++--- > drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 11 ++ >

Re: [PATCH v2 7/9] drm/msm/a6xx: update pdc/rscc GMU registers for A640/A650

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:25PM -0400, Jonathan Marek wrote: > Update the gmu_pdc registers for A640 and A650. > > Some of the RSCC registers on A650 are in a separate region. > > Note this also changes the address of these registers: > > RSCC_TCS1_DRV0_STATUS > RSCC_TCS2_DRV0_STATUS >

Re: [PATCH v2 4/9] drm/msm/a6xx: add A640/A650 to gpulist

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:22PM -0400, Jonathan Marek wrote: > Add Adreno 640 and 650 GPU info to the gpulist. > Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 24 ++ >

Re: [PATCH v2 3/9] drm/msm/a6xx: use msm_gem for GMU memory objects

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:21PM -0400, Jonathan Marek wrote: > This gives more fine-grained control over how memory is allocated over the > DMA api. In particular, it allows using an address range or pinning to > a fixed address. Reviewed-by: Jordan Crouse > Signed-off-by: Jonathan Marek >

Re: [Freedreno] [PATCH v2 2/9] drm/msm: add internal MSM_BO_MAP_PRIV flag

2020-04-23 Thread Jordan Crouse
On Tue, Apr 21, 2020 at 07:41:20PM -0400, Jonathan Marek wrote: > This flag sets IOMMU_PRIV, which is required for some a6xx GMU objects. The GMU doesn't _need_ privileged surfaces, but it sure is a good idea. As a bonus with the APRIV bit on some a6xx targets we can set all of the global

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Bartlomiej Zolnierkiewicz
On 4/23/20 5:05 PM, Andy Shevchenko wrote: > On Thu, Apr 23, 2020 at 5:55 PM Bartlomiej Zolnierkiewicz > wrote: > >>> + if (err) >>> + iounmap((void *)npregs); >> >> Looks OK but while you are at it, could you please also add missing >> release_mem_region() on error and on

RE: [PATCH][next] drm/amd/display: fix incorrect assignment due to a typo

2020-04-23 Thread Koo, Anthony
Hi Colin, Sorry for any confusion of this code. I think in this case, it seems like the comment is wrong (but original implementation is somewhat wrong as well). Probably the original code implementation makes it unclear. There are three scenarios: 1. Variable refresh active, targeting a fixed

[PATCH] drm/edid: Fix off-by-one in DispID DTD pixel clock

2020-04-23 Thread Ville Syrjala
From: Ville Syrjälä The DispID DTD pixel clock is documented as: "00 00 00 h → FF FF FF h | Pixel clock ÷ 10,000 0.01 → 167,772.16 Mega Pixels per Sec" Which seems to imply that we to add one to the raw value. Reality seems to agree as there are tiled displays in the wild which currently show

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Andy Shevchenko
On Thu, Apr 23, 2020 at 5:55 PM Bartlomiej Zolnierkiewicz wrote: > > + if (err) > > + iounmap((void *)npregs); > > Looks OK but while you are at it, could you please also add missing > release_mem_region() on error and on device removal: > > newport_addr =

Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement

2020-04-23 Thread Christian König
Hi guys, one thing you don't seem to have considered yet is that not setting the top-down flag also won't get you the bottom-up approach, but rather the best fit. Additional to that the top-down allocations have quite a bit more CPU overhead since they don't walk the size tree, but the

Re: Operating KMS UAPI (Re: RFC: Drm-connector properties managed by another driver / privacy screen support)

2020-04-23 Thread Daniel Vetter
On Tue, Apr 21, 2020 at 4:33 PM Pekka Paalanen wrote: > > On Tue, 21 Apr 2020 14:15:52 +0200 > Daniel Vetter wrote: > > > On Mon, Apr 20, 2020 at 01:04:20PM +0300, Pekka Paalanen wrote: > > > On Mon, 20 Apr 2020 11:27:04 +0300 > > > Pekka Paalanen wrote: > > > > > > > On Fri, 17 Apr 2020

Re: [PATCH v6 00/12] ARM/MIPS: DTS: add child nodes describing the PVRSGX GPU present in some OMAP SoC and JZ4780 (and many more)

2020-04-23 Thread Neil Armstrong
On 22/04/2020 18:09, H. Nikolaus Schaller wrote: > Hi Maxime, > >> Am 22.04.2020 um 17:13 schrieb Maxime Ripard : >> >> On Wed, Apr 22, 2020 at 09:10:57AM +0200, H. Nikolaus Schaller wrote: Am 22.04.2020 um 08:58 schrieb Maxime Ripard : > > It also allows to handle different number

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Bartlomiej Zolnierkiewicz
Hi, I believe that the patch summary line should be: "[PATCH v2] console: newport_con: ..." On 4/23/20 4:26 PM, Dejin Zheng wrote: > A call of the function ¡°do_take_over_console¡± can fail here. > The corresponding system resources were not released then. > Thus add a call of the function

Re: [PATCH v2] console: console: Complete exception handling in newport_probe()

2020-04-23 Thread Andy Shevchenko
On Thu, Apr 23, 2020 at 5:26 PM Dejin Zheng wrote: > > A call of the function ¡°do_take_over_console¡± can fail here. > The corresponding system resources were not released then. > Thus add a call of the function ¡°iounmap¡± together with the check > of a failure predicate. ... > CC: Andy

[PATCH][next] drm/amd/display: remove redundant assignment to variable ret

2020-04-23 Thread Colin King
From: Colin Ian King The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King ---

[PATCH][next] drm/amd/display: fix incorrect assignment due to a typo

2020-04-23 Thread Colin King
From: Colin Ian King The assignment to infopacket->sb[7] looks incorrect, the comment states it is the minimum refresh rate yet it is being assigned a value from the maximum refresh rate max_refresh_in_uhz. Fix this by using min_refresh_in_uhz instead. Addresses-Coverity: ("Copy-paste error")

Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement

2020-04-23 Thread Gerd Hoffmann
> > I don't think it is that simple. > > > > First: How will that interact with cursor bo allocations? IIRC the > > strategy for them is to allocate top-down, for similar reasons (avoid > > small cursor bo allocs fragment vram memory). > > In ast, 2 cursor BOs are allocated during driver

Re: [PATCH] drm/arm: cleanup coding style in arm a bit

2020-04-23 Thread Liviu Dudau
Hi Bernard, On Tue, Apr 21, 2020 at 07:10:46PM -0700, Bernard Zhao wrote: > For the code logic, an alarm is thrown after failure, but the > code continues to run and returns successfully, so to the caller > the if check and return branch will never run. > The change is to make the code a bit more

Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement

2020-04-23 Thread Thomas Zimmermann
Hi Gerd, thanks for the feedback. Am 23.04.20 um 13:18 schrieb Gerd Hoffmann: > On Wed, Apr 22, 2020 at 04:40:55PM +0200, Thomas Zimmermann wrote: >> With limited VRAM available, fragmentation can lead to OOM errors. >> Alternating between bottom-up and top-down placement keeps BOs near the >>

Re: [PATCH v7 2/2] drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP bridge driver

2020-04-23 Thread Nicolas Boichat
Hi, Just commenting on the mode_fixup function that was added in v7. On Tue, Feb 25, 2020 at 2:15 PM Xin Ji wrote: > > The ANX7625 is an ultra-low power 4K Mobile HD Transmitter designed > for portable device. It converts MIPI DSI/DPI to DisplayPort 1.3 4K. > > The ANX7625 can support both USB

RE: [PATCH v4] dt-bindings: display: dw_mipi_dsi.txt: convert to yaml

2020-04-23 Thread Adrian Ratiu
Hi Angelo, On Thu, 23 Apr 2020, Angelo Ribeiro wrote: Hi Adrian, From: Adrian Ratiu Date: Thu, Apr 23, 2020 at 11:00:58 This converts the Synopsis MIPI DSI binding documentation to yaml and should be quite straightforward. I've added a missing ref clk and also added Philippe as

Re: [PATCH v13 00/11] Convert PWM period and duty cycle to u64

2020-04-23 Thread Lee Jones
On Tue, 21 Apr 2020, Guru Das Srinagesh wrote: > [REQUEST] > > Would it be possible for the patches that have already received Acked-by's in > this series to be accepted and applied to the tree? I lost an Acked-by (in > intel-panel.c) because it had a merge conflict with a new change that came

Re: [PATCH] dma-buf: Couple of documentation typo fixes

2020-04-23 Thread Daniel Vetter
On Tue, Apr 21, 2020 at 6:32 PM Jonathan Corbet wrote: > > On Tue, 21 Apr 2020 14:38:37 +0200 > Daniel Vetter wrote: > > > On Mon, Apr 20, 2020 at 05:00:59PM -0600, Jonathan Corbet wrote: > > > On Mon, 20 Apr 2020 10:41:15 +0300 > > > Gal Pressman wrote: > > > > > > > Fix a couple of typos:

Re: [PATCH 2/2] drm/vram-helper: Alternate between bottom-up and top-down placement

2020-04-23 Thread Gerd Hoffmann
On Wed, Apr 22, 2020 at 04:40:55PM +0200, Thomas Zimmermann wrote: > With limited VRAM available, fragmentation can lead to OOM errors. > Alternating between bottom-up and top-down placement keeps BOs near the > ends of the VRAM and the available pages consecutively near the middle. > > A

Re: [PATCH 04/29] staging: media: ipu3: use vmap instead of reimplementing it

2020-04-23 Thread Sakari Ailus
On Tue, Apr 14, 2020 at 03:13:23PM +0200, Christoph Hellwig wrote: > Just use vmap instead of messing with vmalloc internals. > > Signed-off-by: Christoph Hellwig > Acked-by: Peter Zijlstra (Intel) Thanks! Acked-by: Sakari Ailus -- Sakari Ailus

  1   2   >