Hi Manasi,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip drm-exynos/exynos-drm-next
linus/master next-20200613]
[cannot apply to tegra-drm/drm/tegra/for-next drm/drm-next v5.7]
[if your
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
head: add78d27d388520cbed6a7bf01d1e0afa183314d
commit: 04dc41776145f539ab6da442cb633e45539bed9a [4/16] drm/i915/gt: Prevent
timeslicing into unpreemptable requests
config: i386-allmodconfig (attached as .config)
compiler:
On 6/16/20 11:10 AM, Rong Chen wrote:
On 6/16/20 4:58 AM, Emil Velikov wrote:
Hi all,
On Thu, 4 Jun 2020 at 08:11, kernel test robot
wrote:
Greeting,
FYI, we noticed a -64.9% regression of
phoronix-test-suite.glmark2.800x600.score due to commit:
On one hand, I'm really happy to see
[AMD Official Use Only - Internal Distribution Only]
Acked-by: Evan Quan
-Original Message-
From: amd-gfx On Behalf Of Aditya Pakki
Sent: Sunday, June 14, 2020 10:21 AM
To: pakki...@umn.edu
Cc: wu000...@umn.edu; David Airlie ; k...@umn.edu;
linux-ker...@vger.kernel.org;
Hi Ricardo,
On Mon, Jun 15, 2020 at 11:38:07AM +0200, Ricardo Cañuelo wrote:
> On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> > On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > > Make the ports node optional, since there are some DTs that don't define
> > > any
Hi Stefan,
On Thu, Jun 11, 2020 at 09:33:11PM +0200, Stefan Agner wrote:
> On 2020-05-30 05:10, Laurent Pinchart wrote:
> > The DRM simple display pipeline helper only supports a single plane. In
> > order to prepare for support of the alpha plane on i.MX6SX and i.MX7,
> > move away from the
Hi Dmitry,
Thank you for the patch.
On Sun, Jun 14, 2020 at 08:22:30PM +0300, Dmitry Osipenko wrote:
> When graph isn't defined in a device-tree, the of_graph_get_remote_node()
> prints a noisy error message, telling that port node is not found. This is
> undesirable behaviour in our case
On Tue, Jun 16, 2020 at 04:21:12AM +0300, Laurent Pinchart wrote:
> Hi Dmitry,
>
> Thank you for the patch.
>
> On Sun, Jun 14, 2020 at 08:22:29PM +0300, Dmitry Osipenko wrote:
> > In some case, like a DRM display code for example, it's useful to silently
> > check whether port node exists at
Hi Dmitry,
Thank you for the patch.
On Sun, Jun 14, 2020 at 08:22:29PM +0300, Dmitry Osipenko wrote:
> In some case, like a DRM display code for example, it's useful to silently
> check whether port node exists at all in a device-tree before proceeding
> with parsing the graph.
>
> This patch
20. 6. 15. 오후 2:49에 Navid Emamdoost 이(가) 쓴 글:
> in mic_pre_enable, pm_runtime_get_sync is called which
> increments the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
>
> Signed-off-by: Navid Emamdoost
> ---
>
Enable DP driver for sc7180.
This change depends-on following series:
https://patchwork.freedesktop.org/series/78247/
and https://patchwork.freedesktop.org/patch/351990/
Signed-off-by: Tanmay Shah
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 58 ++--
1 file changed, 54
On 2020-06-13 15:32, wu000...@umn.edu wrote:
From: Qiushi Wu
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object.
Signed-off-by: Qiushi Wu
Thank you. The patch
On Tue, 9 Jun 2020 13:45:53 +0100, Kieran Bingham wrote:
> I wouldn't normally go through spelling fixes, but I caught sight of
> this typo twice, and then foolishly grepped the tree for it, and saw how
> pervasive it was.
>
> so here I am ... fixing a typo globally... but with an addition in
>
Hi all,
After merging the drm-intel-fixes tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from drivers/gpu/drm/i915/gt/intel_lrc.c:5972:
drivers/gpu/drm/i915/gt/selftest_lrc.c: In function 'live_timeslice_nopreempt':
On 2020-06-15 16:04, Jeffrey Hugo wrote:
On Mon, Jun 15, 2020 at 4:51 PM wrote:
On 2020-06-12 16:26, Stephen Boyd wrote:
Thanks for reviews Stephen.
> Quoting Tanmay Shah (2020-06-11 18:50:25)
>> These patches add support for Display-Port driver on SnapDragon
>> hardware. It adds
>> DP
Hi Linus,
On Sat, 13 Jun 2020 at 23:30, Linus Walleij wrote:
>
> The following bug appeared in the MCDE driver/display
> initialization during the recent merge window.
>
> First the place we call drm_fbdev_generic_setup() in the
> wrong place: this needs to be called AFTER calling
>
Hi Thomas,
On Thu, 11 Jun 2020 at 09:28, Thomas Zimmermann wrote:
> --- a/drivers/gpu/drm/ast/ast_drv.c
> +++ b/drivers/gpu/drm/ast/ast_drv.c
> @@ -59,7 +59,6 @@ static struct drm_driver driver;
> static const struct pci_device_id pciidlist[] = {
> AST_VGA_DEVICE(PCI_CHIP_AST2000,
Use array3_size() helper instead of the open-coded version in scr_memcpyw()
and scr_memsetw(). These sorts of multiplication factors need to be wrapped
in array3_size().
This issue was found with the help of Coccinelle and, audited and fixed
manually.
Addresses-KSPP-ID:
This reverts commit d323bb44e4d23802eb25d13de1f93f2335bd60d0.
Fixes a double-free regression:
[4.357928] drm_gem_shmem_free_object+0xb4/0x100
[4.358983] virtio_gpu_dequeue_ctrl_func+0xd9/0x290
[4.360343] process_one_work+0x1d2/0x3a0
[4.361581] worker_thread+0x45/0x3c0
[
On 2020-06-12 16:26, Stephen Boyd wrote:
Thanks for reviews Stephen.
Quoting Tanmay Shah (2020-06-11 18:50:25)
These patches add support for Display-Port driver on SnapDragon
hardware. It adds
DP driver and DP PLL driver files along with the needed device-tree
bindings.
The block diagram of
Hi Dmitry,
On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote:
>
> Hello!
>
> This series adds 180° display plane rotation support to the NVIDIA Tegra
> DRM driver which is needed for devices that have display panel physically
> mounted upside-down, like Nexus 7 tablet device for example [1].
tree: git://anongit.freedesktop.org/drm-intel for-linux-next-fixes
head: add78d27d388520cbed6a7bf01d1e0afa183314d
commit: 04dc41776145f539ab6da442cb633e45539bed9a [4/16] drm/i915/gt: Prevent
timeslicing into unpreemptable requests
config: x86_64-allyesconfig (attached as .config)
compiler:
On Mon, Jun 15, 2020 at 3:27 AM Aditya Pakki wrote:
>
> On calling pm_runtime_get_sync() the reference count of the device
> is incremented. In case of failure, decrement the
> reference count before returning the error.
Is this required if pm_runtime_get_sync() fails?
Alex
>
> Signed-off-by:
Hi all,
Perhaps a silly question:
On Mon, 15 Jun 2020 at 08:28, Dmitry Osipenko wrote:
>
> Combining horizontal and vertical reflections gives us 180 degrees of
> rotation.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/gpu/drm/tegra/dc.c | 13 -
> 1 file changed, 12
On Mon, Jun 15, 2020 at 10:36:28PM +0100, Emil Velikov wrote:
> Hi Manasi,
>
> On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote:
> >
> > From: Bhanuprakash Modem
> >
> > [Why]
> > It's useful to know the min and max vrr range for IGT testing.
> >
> > [How]
> > Expose the min and max vfreq for
Hi Manasi,
On Sat, 13 Jun 2020 at 00:55, Manasi Navare wrote:
>
> From: Bhanuprakash Modem
>
> [Why]
> It's useful to know the min and max vrr range for IGT testing.
>
> [How]
> Expose the min and max vfreq for the connector via a debugfs file
> on the connector, "vrr_range".
>
> Example usage:
Hi Daniel,
On Fri, 12 Jun 2020 at 17:01, Daniel Vetter wrote:
>
> The atomic helpers try really hard to not lose track of things,
> duplicating enabled tracking in the driver is at best confusing.
> Double-enabling or disabling is a bug in atomic helpers.
>
> In the fb_dirty function we can just
Hi Emil,
On Mon, Jun 15, 2020 at 10:38 PM Emil Velikov wrote:
> On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz
> wrote:
> > On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
> > > These #ifdefs are relics from APUS (Amiga Power-Up System), which
> > > added a PPC board. APUS support was
Hi Matthias,
On Thu, 11 Jun 2020 at 08:54, Matthias Schiffer
wrote:
> On Wed, 2020-06-10 at 16:59 +0200, Sam Ravnborg wrote:
> > On Wed, Jun 10, 2020 at 02:01:30PM +0200, Matthias Schiffer wrote:
> > > + .vrefresh = 60,
> >
> > .vrefresh is no longer present, please drop.
>
> I based my
Hi all,
On Thu, 4 Jun 2020 at 08:11, kernel test robot wrote:
>
> Greeting,
>
> FYI, we noticed a -64.9% regression of
> phoronix-test-suite.glmark2.800x600.score due to commit:
>
On one hand, I'm really happy to see performance testing happening
although this report is missing various crucial
Hi Bartlomiej,
On Tue, 2 Jun 2020 at 11:37, Bartlomiej Zolnierkiewicz
wrote:
>
>
> On 5/14/20 10:21 PM, Geert Uytterhoeven wrote:
>
> > These #ifdefs are relics from APUS (Amiga Power-Up System), which
> > added a PPC board. APUS support was killed off a long time ago,
> > when arch/ppc/ was
i Laurent,
On Sun, 7 Jun 2020 at 00:02, Laurent Pinchart
wrote:
>
> Hi Emil,
>
> On Fri, Jun 05, 2020 at 03:58:53PM +0100, Emil Velikov wrote:
> > Hi Laurent,
> >
> > With the previous disclaimer in mind, the series is:
> > Reviewed-by: Emil Velikov
>
> Sorry, which disclaimer is that ?
>
"I
On Mon, 1 Jun 2020 at 18:42, Liviu Dudau wrote:
>
> Hi Emil,
>
> On Wed, May 20, 2020 at 12:54:17AM +0100, Emil Velikov wrote:
> > On Mon, 18 May 2020 at 12:10, Liviu Dudau wrote:
> > >
> > > On Sun, May 17, 2020 at 08:36:53PM +0100, Emil Velikov wrote:
> > > > Add the COMPILE_TEST conditional,
On Thu, 4 Jun 2020 at 08:30, Daniel Vetter wrote:
>
> On Wed, Jun 03, 2020 at 06:04:34PM +0100, Emil Velikov wrote:
> > Add some information about pre-atomic modeset properties alongside a
> > list of suggestions how to handle the different instances.
> >
> > Signed-off-by: Emil Velikov
> > ---
On Fri, 5 Jun 2020 at 15:07, Emil Velikov wrote:
>
> On Wed, 3 Jun 2020 at 19:37, Roland Scheidegger wrote:
> >
> > Looks like a nice cleanup to me. (No idea if at some point there
> > actually was a reason for a return value...)
> >
> It was required up-to quite recently actually:
>
> commit
On Sun, Jun 14, 2020 at 11:01:21PM +0300, Dmitry Osipenko wrote:
> Combining horizontal and vertical reflections gives us 180 degrees of
> rotation.
>
> Signed-off-by: Dmitry Osipenko
> ---
> drivers/gpu/drm/tegra/dc.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
>
Acked-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Abort early if there isn't enough space to allocate from a subtree.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c| 11 +++
drivers/gpu/drm/selftests/test-drm_mm.c | 11 ---
2
Reviewed-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Skipping just one branch of the tree is not the most
effective approach.
Instead use a macro to define the traversal functions and
sort out both branch sides.
This improves the performance of the unit tests by
a factor of
Reviewed-by: Nirmoy Das
On 6/15/20 4:54 PM, Christian König wrote:
Just some code cleanup.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index
On Fri, Jun 12, 2020 at 12:38:59PM -0700, Manasi Navare wrote:
> On Fri, Jun 12, 2020 at 10:21:31PM +0300, Ville Syrjälä wrote:
> > On Fri, Jun 12, 2020 at 12:12:25PM -0700, Manasi Navare wrote:
> > > On Fri, Jun 12, 2020 at 10:01:19PM +0300, Ville Syrjälä wrote:
> > > > On Fri, Jun 12, 2020 at
On Sun, 14 Jun 2020 15:30:36 +0800, Jitao Shi wrote:
> Convert display/mediatek/mediatek,dpi.txt to
> display/mediatek/mediatek,dpi.yaml
> and remove the old text bindings.
>
> Signed-off-by: Jitao Shi
> ---
> .../display/mediatek/mediatek,dpi.txt | 42
>
On Sun, Jun 14, 2020 at 11:29 PM Linus Walleij wrote:
>
> On Sun, Jun 14, 2020 at 9:44 AM Sam Ravnborg wrote:
>
> > Hi Linus.
> >
> > On Sun, Jun 14, 2020 at 12:30:26AM +0200, Linus Walleij wrote:
> > > The following bug appeared in the MCDE driver/display
> > > initialization during the recent
I broke that in my refactoring:
commit 7d2cd72a9aa3df3604cafd169a2d4a525afb68ca
Author: Daniel Vetter
Date: Fri May 29 16:05:42 2020 +0200
drm/shmem-helpers: Simplify dma-buf importing
Reported-by: Thomas Zimmermann
Fixes: 7d2cd72a9aa3 ("drm/shmem-helpers: Simplify dma-buf importing")
Skipping just one branch of the tree is not the most
effective approach.
Instead use a macro to define the traversal functions and
sort out both branch sides.
This improves the performance of the unit tests by
a factor of more than 4.
Signed-off-by: Christian König
---
Just some code cleanup.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/gpu/drm/drm_mm.c b/drivers/gpu/drm/drm_mm.c
index 82d2888eb7fe..425fcd3590e8 100644
--- a/drivers/gpu/drm/drm_mm.c
+++ b/drivers/gpu/drm/drm_mm.c
Abort early if there isn't enough space to allocate from a subtree.
Signed-off-by: Christian König
---
drivers/gpu/drm/drm_mm.c| 11 +++
drivers/gpu/drm/selftests/test-drm_mm.c | 11 ---
2 files changed, 7 insertions(+), 15 deletions(-)
diff --git
On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam wrote:
>
> On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote:
> >
> > The LogicPD Type28 display used by several Logic PD products has not
> > worked since v5.5.
>
> Maybe you could tell which commit exactly and then put a Fixes tag?
I honestly don't
On Mon, Jun 15, 2020 at 10:19 AM Adam Ford wrote:
>
> The LogicPD Type28 display used by several Logic PD products has not
> worked since v5.5.
Maybe you could tell which commit exactly and then put a Fixes tag?
___
dri-devel mailing list
Hi,
On Fri, Jun 12, 2020 at 12:31 PM Douglas Anderson wrote:
>
> The kernel test robot noted that if "OF" is defined (which is needed
> to select DRM_TI_SN65DSI86 at all) but not OF_GPIO that we'd get
> compile failures because some of the members that we access in "struct
> gpio_chip" are only
Joe Perches 於 2020年6月15日 週一 上午4:41寫道：
>
> On Fri, 2020-06-12 at 20:40 +0800, Bernard Zhao wrote:
> > In function mtk_dsi_clk_hs_state, remove unnecessary conversion
> > to bool return, this change is to make the code a bit readable.
> []
> > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c
> >
The LogicPD Type28 display used by several Logic PD products has not
worked since v5.5.
The connector type for the LogicPD Type 28 display is missing and
drm_panel_bridge_add() requires connector type to be set.
Signed-off-by: Adam Ford
CC: sta...@vger.kernel.org #v5.5+
diff --git
https://bugzilla.kernel.org/show_bug.cgi?id=205497
Sling Shot (sling-s...@gmx.com) changed:
What|Removed |Added
CC||sling-s...@gmx.com
---
On some qualcomm platforms DPU needs to express a performance state
requirement on a power domain depending on the clock rates.
Use OPP table from DT to register with OPP framework and use
dev_pm_opp_set_rate() to set the clk/perf state.
Signed-off-by: Rajendra Nayak
Reviewed-by: Rob Clark
On SDM845 DSI needs to express a perforamnce state
requirement on a power domain depending on the clock rates.
Use OPP table from DT to register with OPP framework and use
dev_pm_opp_set_rate() to set the clk/perf state.
Signed-off-by: Rajendra Nayak
Cc: Rob Clark
Cc: Sean Paul
Cc:
On Mon, Jun 15, 2020 at 01:57:39PM +0200, Mauro Carvalho Chehab wrote:
> Mark Brown escreveu:
> > On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote:
> > > There are some new broken doc links due to yaml renames
> > > at DT. Developers should really run:
> > I also
On Mon, Jun 15, 2020 at 04:54:02PM +0800, Wang Qing wrote:
> Use kobj_to_dev() instead of container_of()
>
> Signed-off-by: Wang Qing
Reviewed-by: Daniel Thompson
> ---
> drivers/video/backlight/lm3533_bl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> mode change 100644 =>
Hi Mark,
Em Mon, 15 Jun 2020 12:19:27 +0100
Mark Brown escreveu:
> On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote:
> > There are some new broken doc links due to yaml renames
> > at DT. Developers should really run:
>
> I also previously acked this one in
The vc4_create_object() needs to return NULL on error, not error
pointers. If it returns an error pointer then that will lead to an
Oops in the callers. Fortunately, in current kernels small allocations
always succed so this will never happen.
Fixes: c826a6e10644 ("drm/vc4: Add a BO cache.")
ttm_bo_vm_fault_reserved() invokes dma_fence_get(), which returns a
reference of the specified dma_fence object to "moving" with increased
refcnt.
When ttm_bo_vm_fault_reserved() returns, local variable "moving" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The
ttm_bo_add_move_fence() invokes dma_fence_get(), which returns a
reference of the specified dma_fence object to "fence" with increased
refcnt.
When ttm_bo_add_move_fence() returns, local variable "fence" becomes
invalid, so the refcount should be decreased to keep refcount balanced.
The
On Mon, Jun 15, 2020 at 08:46:52AM +0200, Mauro Carvalho Chehab wrote:
> There are some new broken doc links due to yaml renames
> at DT. Developers should really run:
I also previously acked this one in 20200504100822.ga5...@sirena.org.uk.
Has anything changed here to cause the ack to be
On Mon, Jun 15, 2020 at 08:46:53AM +0200, Mauro Carvalho Chehab wrote:
> Some files got renamed. Those were all fixed automatically by
>
> ./scripts/documentation-file-ref-check --fix
Acked-by: Mark Brown
signature.asc
Description: PGP signature
Hi Laurent,
Thanks for reviewing the patch
On Thu, 2020-06-11 at 19:08 +0300, Laurent Pinchart wrote:
> Hi Ricardo,
>
> Thank you for the patch.
>
> On Thu, Jun 11, 2020 at 12:23:56PM +0200, Ricardo Cañuelo wrote:
> > Make the ports node optional, since there are some DTs that don't define
> >
Am 13.06.20 um 14:30 schrieb Xiyu Yang:
ttm_bo_add_move_fence() invokes dma_fence_get(), which returns a
reference of the specified dma_fence object to "fence" with increased
refcnt.
When ttm_bo_add_move_fence() returns, local variable "fence" becomes
invalid, so the refcount should be
Hi Daniel
this patch causes a segmentation fault.
Am 11.05.20 um 11:35 schrieb Daniel Vetter:
> - Ditch the ->pages array
> - Make it a private gem bo, which means no shmem object, which means
> fireworks if anyone calls drm_gem_object_get_pages. But we've just
> made sure that's all
https://bugzilla.kernel.org/show_bug.cgi?id=208179
Bug ID: 208179
Summary: [amdgpu] black screen after exiting X
Product: Drivers
Version: 2.5
Kernel Version: 5.7.2
Hardware: All
OS: Linux
Tree: Mainline
The cursor code used to use magic constants, ANDs, ORs, and some macros.
Redefine all this to make some sense.
In particular:
* Drop CUR_DEFAULT, which is CUR_UNDERLINE. CUR_DEFAULT was used only
for cur_default variable initialization, so use CUR_UNDERLINE there to
make obvious what's the
We defined macros for all the magic constants in the previous patch. So
let us use the macro in the code now.
No functional change intended.
Signed-off-by: Jiri Slaby
Cc: Thomas Winischhofer
Cc: Bartlomiej Zolnierkiewicz
Cc: "James E.J. Bottomley"
Cc: Helge Deller
Cc:
On Mon, 2020-06-15 at 08:46 +0200, Mauro Carvalho Chehab wrote:
> Some files got renamed. Those were all fixed automatically by
>
> ./scripts/documentation-file-ref-check --fix
>
> Signed-off-by: Mauro Carvalho Chehab
> ---
> Documentation/devicetree/bindings/arm/freescale/fsl,scu.txt
When graph isn't defined in a device-tree, the of_graph_get_remote_node()
prints a noisy error message, telling that port node is not found. This is
undesirable behaviour in our case because absence of a panel/bridge graph
is a valid case. Let's check presence of the local port in a device-tree
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs,
and etnaviv_gpu_init the call to pm_runtime_get_sync increments the
counter even in case of failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
From: Derek Basehore
This adds a helper function for reading the rotation (panel
orientation) from the device tree.
Signed-off-by: Derek Basehore
Reviewed-by: Sam Ravnborg
Tested-by: Dmitry Osipenko
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/drm_panel.c | 43
nouveau_debugfs_strap_peek() calls pm_runtime_get_sync() that
increments the reference count. In case of failure, decrement the
ref count before returning the error.
Signed-off-by: Aditya Pakki
---
drivers/gpu/drm/nouveau/nouveau_debugfs.c | 4 +++-
1 file changed, 3 insertions(+), 1
in etnaviv_gpu_submit, etnaviv_gpu_recover_hang, etnaviv_gpu_debugfs,
and etnaviv_gpu_init the call to pm_runtime_get_sync increments the
counter even in case of failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
On Sun, Jun 14, 2020 at 4:48 AM Andy Shevchenko
wrote:
>
> On Sun, Jun 14, 2020 at 9:48 AM Navid Emamdoost
> wrote:
>
> ...
>
> > + if (ret < 0) {
>
> > + pm_runtime_put(gpu->dev);
>
> Please, in all your patches fix this to be _put_noidle(). We wouldn't
>
The call to pm_runtime_get_sync increments the counter even in case of
failure, leading to incorrect ref count.
In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 16
1 file changed,
The panel orientation needs to parsed from a device-tree and assigned to
the panel's connector in order to make orientation property available to
userspace. That's what this patch does for the generic LVDS panel.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/panel/panel-lvds.c | 8
in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments
the counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
---
drivers/gpu/drm/vc4/vc4_dsi.c | 10 ++
1 file
The OF node should be put before returning error in tegra_output_probe(),
otherwise node's refcount will be leaked.
Reviewed-by: Laurent Pinchart
Reviewed-by: Sam Ravnborg
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/output.c | 9 -
1 file changed, 4 insertions(+), 5
Add vendor prefix for display manufacturer company EastRising
Technology Co.,Ltd
[1]https://eastrising.en.ec21.com/
Signed-off-by: Kamlesh Gurudasani
---
Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git
On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.
Signed-off-by: Aditya Pakki
---
drivers/video/fbdev/omap2/omapfb/dss/dispc.c | 7 +--
drivers/video/fbdev/omap2/omapfb/dss/dsi.c
Newer Tegra device-trees will specify a video output graph, which involves
LVDS encoder bridge. This patch adds support for the LVDS encoder bridge
to the RGB output, allowing us to model the display hardware properly.
Reviewed-by: Laurent Pinchart
Acked-by: Sam Ravnborg
Signed-off-by: Dmitry
From: Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but
there's no way, as is, to propagate this setting to the connector,
where the property need to be added.
To address this, this patch sets orientation, as well as other fixed
values for the panel, in the
in amdgpu_driver_open_kms the call to pm_runtime_get_sync increments the
counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
---
drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 3 ++-
1 file
Hi Kamal,
> El 13 jun 2020, a las 17:16, Kamal Dasu escribió:
>
> Alvaro,
>
>
> On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas
> wrote:
>>
>> Hi Kamal,
>>
>>> El 12 jun 2020, a las 20:47, Kamal Dasu escribió:
>>>
>>> On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas
>>>
Combining horizontal and vertical reflections gives us 180 degrees of
rotation.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/dc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c
index
On Sun, Jun 14, 2020 at 7:47 PM Inki Dae wrote:
>
> Hi,
>
> 20. 6. 14. 오후 3:23에 Navid Emamdoost 이(가) 쓴 글:
> > in mic_pre_enable, pm_runtime_get_sync is called which
> > increments the counter even in case of failure, leading to incorrect
> > ref count. In case of failure, decrement the ref count
14.06.2020 22:03, Dmitry Osipenko пишет:
> From: Derek Basehore
>
> Devicetree systems can set panel orientation via a panel binding, but
> there's no way, as is, to propagate this setting to the connector,
> where the property need to be added.
> To address this, this patch sets orientation, as
This adds binding for ilitek,ili9488 based display panels
Signed-off-by: Kamlesh Gurudasani
---
.../bindings/display/ilitek,ili9488.yaml | 71 ++
1 file changed, 71 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/ilitek,ili9488.yaml
On calling pm_runtime_get_sync() the reference count of the device
is incremented. In case of failure, decrement the
reference count before returning the error.
Signed-off-by: Aditya Pakki
---
drivers/gpu/drm/bridge/cdns-dsi.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff
> in vc4_dsi_encoder_enable, the call to pm_runtime_get_sync increments
> the counter even in case of failure, leading to incorrect
> ref count. In case of failure, decrement the ref count before returning.
* Can the term “reference count” become relevant also for this commit message
besides
From: Qiushi Wu
kobject_init_and_add() takes reference even when it fails.
If this function returns an error, kobject_put() must be called to
properly clean up the memory associated with the object.
Signed-off-by: Qiushi Wu
---
drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 20
in amdgpu_display_crtc_set_config, the call to pm_runtime_get_sync
increments the counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 5
Support horizontal reflection mode which will allow to support 180°
rotation mode when combined with the vertical reflection.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/dc.c| 24
drivers/gpu/drm/tegra/dc.h| 1 +
drivers/gpu/drm/tegra/plane.c | 1
Support horizontal reflection mode which will allow to support 180°
rotation mode when combined with the vertical reflection.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/dc.c| 24
drivers/gpu/drm/tegra/dc.h| 1 +
drivers/gpu/drm/tegra/plane.c | 1
From: Derek Basehore
This adds a helper function for reading the rotation (panel
orientation) from the device tree.
Signed-off-by: Derek Basehore
Reviewed-by: Sam Ravnborg
Tested-by: Dmitry Osipenko
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/drm_panel.c | 43
In some case, like a DRM display code for example, it's useful to silently
check whether port node exists at all in a device-tree before proceeding
with parsing the graph.
This patch adds of_graph_get_local_port() which returns pointer to a local
port node, or NULL if graph isn't specified in a
This makes the naming consistent with the DRM core.
Signed-off-by: Dmitry Osipenko
---
drivers/gpu/drm/tegra/dc.c| 10 +-
drivers/gpu/drm/tegra/dc.h| 2 +-
drivers/gpu/drm/tegra/plane.c | 2 +-
drivers/gpu/drm/tegra/plane.h | 2 +-
4 files changed, 8 insertions(+), 8
in mic_pre_enable, pm_runtime_get_sync is called which
increments the counter even in case of failure, leading to incorrect
ref count. In case of failure, decrement the ref count before returning.
Signed-off-by: Navid Emamdoost
---
Changes in v2:
- reuse the unlock label and call
Alvaro,
On Sat, Jun 13, 2020 at 5:01 AM Álvaro Fernández Rojas
wrote:
>
> Hi Kamal,
>
> > El 12 jun 2020, a las 20:47, Kamal Dasu escribió:
> >
> > On Fri, Jun 5, 2020 at 1:07 PM Álvaro Fernández Rojas
> > wrote:
> >>
> >> MTD_OPS_AUTO_OOB is writting OOB with ECC enabled, which changes all
1 - 100 of 138 matches
Mail list logo
