[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #86 from mn...@protonmail.com --- Created attachment 290475 --> https://bugzilla.kernel.org/attachment.cgi?id=290475=edit KASAN Use-after-free Good news, I got KASAN to spit out a use-after-free bug report. Here's the KASAN bug

Re: warning in omap_connector

2020-07-22 Thread Dave Airlie
I think I'm still seeing this. Dave. On Wed, 1 Jul 2020 at 01:08, Ville Syrjälä wrote: > > On Tue, Jun 30, 2020 at 05:41:32PM +0300, Laurent Pinchart wrote: > > Hi Ville, > > > > On Tue, Jun 30, 2020 at 05:39:02PM +0300, Ville Syrjälä wrote: > > > On Tue, Jun 30, 2020 at 10:19:23AM -0400, Alex

[pull] amdgpu drm-fixes-5.8

2020-07-22 Thread Alex Deucher
Hi Dave, Daniel, Couple of fixes for 5.8. The following changes since commit adbe8a3cae94a63e9f416795c750237a9b789124: Merge tag 'amd-drm-fixes-5.8-2020-07-15' of git://people.freedesktop.org/~agd5f/linux into drm-fixes (2020-07-17 13:29:00 +1000) are available in the Git repository at:

[Bug 206987] [drm] [amdgpu] Whole system crashes when the driver is in mode_support_and_system_configuration

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=206987 Cyrax (ev...@hotmail.com) changed: What|Removed |Added Status|NEW |RESOLVED

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #85 from mn...@protonmail.com --- (In reply to Christian König from comment #83) > Instead of working around the bug I think we should concentrate on nailing > the root cause. > > I suggest to insert an use after free check into just

[PATCH v2 1/2] drm/dp: Add PHY_TEST_PATTERN CP2520 Pattern 2 and 3

2020-07-22 Thread Khaled Almahallawy
Add the missing CP2520 pattern 2 and 3 phy compliance patterns v2: cosemtic changes Reviewed-by: Manasi Navare (v1) Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/drm_dp_helper.c | 2 +- include/drm/drm_dp_helper.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH v2 2/2] drm/i915/dp: TPS4 PHY test pattern compliance support

2020-07-22 Thread Khaled Almahallawy
Adding support for TPS4 (CP2520 Pattern 3) PHY pattern source tests. v2: uniform bit names TP4a/b/c (Manasi) Signed-off-by: Khaled Almahallawy --- drivers/gpu/drm/i915/display/intel_dp.c | 14 -- drivers/gpu/drm/i915/i915_reg.h | 4 2 files changed, 16 insertions(+),

[Bug 208661] New: Backlight doesn't work with both nv_backlight and acpi_video

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208661 Bug ID: 208661 Summary: Backlight doesn't work with both nv_backlight and acpi_video Product: Drivers Version: 2.5 Kernel Version: 5.7.0-1-amd64 Hardware: All

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 5:47 PM Rob Clark wrote: > > On Tue, Jul 21, 2020 at 10:30 PM Viresh Kumar wrote: > > > > On 21-07-20, 07:28, Rob Clark wrote: > > > With your ack, I can add the patch the dev_pm_opp_set_bw patch to my > > > tree and merge it via msm-next -> drm-next -> linus > > > > I

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-22 Thread daniel
On Wed, Jul 22, 2020 at 05:08:03PM +0200, Philipp Zabel wrote: > Hi Thomas, > > thank you for your comment. > > On Wed, 2020-07-22 at 16:43 +0200, Thomas Zimmermann wrote: > > Hi > > > > Am 22.07.20 um 15:25 schrieb Philipp Zabel: > > > Add a drm_simple_encoder_init() variant that registers > >

Re: [PATCH 5/8] drm/imx: parallel-display: use drm managed resources

2020-07-22 Thread daniel
On Wed, Jul 22, 2020 at 04:01:53PM +0200, Philipp Zabel wrote: > On Wed, 2020-07-22 at 15:30 +0200, Philipp Zabel wrote: > [...] > > and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is > > called before the memory is freed. > [...] > > @@ -259,6 +259,13 @@ static const struct

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 9:27 PM Chia-I Wu wrote: > > On Wed, Jul 22, 2020 at 4:28 AM Daniel Vetter wrote: > > > > On Wed, Jul 22, 2020 at 1:12 PM Christian König > > wrote: > > > > > > Am 22.07.20 um 09:32 schrieb Daniel Vetter: > > > > On Wed, Jul 22, 2020 at 9:19 AM Christian König > > > >

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: > > Hi, > > this series mainly ports existining functionality to older SoCs - most > importantly enables alpha blending for RK3036, RK3066, RK3126 and > RK3188. > Besides that, it also changes the window type from DRM_PLANE_TYPE_CURSOR > to

Re: [PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-07-22 Thread kernel test robot
Hi Swapnil, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on linus/master v5.8-rc6 next-20200722] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Chia-I Wu
On Wed, Jul 22, 2020 at 4:28 AM Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 1:12 PM Christian König > wrote: > > > > Am 22.07.20 um 09:32 schrieb Daniel Vetter: > > > On Wed, Jul 22, 2020 at 9:19 AM Christian König > > > wrote: > > >> Am 22.07.20 um 02:22 schrieb Gurchetan Singh: > > >> >

Re: [PATCH v2] drm/of: Consider the state in which the ep is disabled

2020-07-22 Thread Heiko Stübner
Am Dienstag, 7. Juli 2020, 13:25:26 CEST schrieb Sandy Huang: > don't mask possible_crtcs if remote-point is disabled. > > Signed-off-by: Sandy Huang Reviewed-by: Heiko Stuebner changes in v2: - drop additional of_node_put, as ep will be put with the next iteration of

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Alex Deucher
On Wed, Jul 22, 2020 at 10:25 AM Michel Dänzer wrote: > > On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > >>> > >>> From: Michel Dänzer > >>> > >>> drm_atomic_crtc_check enforces

Re: [PATCH -next] dma-fence: Make symbol 'dma_fence_lockdep_map' static

2020-07-22 Thread Koenig, Christian
Am 22.07.2020 18:04 schrieb Wei Yongjun : The sparse tool complains as follows: drivers/dma-buf/dma-fence.c:249:25: warning: symbol 'dma_fence_lockdep_map' was not declared. Should it be static? This variable is not used outside of dma-fence.c, so this commit marks it static. Fixes:

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-22 Thread Rob Clark
On Tue, Jul 21, 2020 at 10:30 PM Viresh Kumar wrote: > > On 21-07-20, 07:28, Rob Clark wrote: > > With your ack, I can add the patch the dev_pm_opp_set_bw patch to my > > tree and merge it via msm-next -> drm-next -> linus > > I wanted to send it via my tree, but its okay. Pick this patch from >

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 4:25 PM Michel Dänzer wrote: > > On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: > >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > >>> > >>> From: Michel Dänzer > >>> > >>> drm_atomic_crtc_check enforces

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > On 07/22, dan...@ffwll.ch wrote: > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > This patch adds a missing drm_crtc_vblank_put op to the pair > > > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). >

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-22 Thread Philipp Zabel
Hi Thomas, thank you for your comment. On Wed, 2020-07-22 at 16:43 +0200, Thomas Zimmermann wrote: > Hi > > Am 22.07.20 um 15:25 schrieb Philipp Zabel: > > Add a drm_simple_encoder_init() variant that registers > > drm_encoder_cleanup() with drmm_add_action(). > > > > Now drivers can store

Re: [PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-22 Thread Thomas Zimmermann
Hi Am 22.07.20 um 15:25 schrieb Philipp Zabel: > Add a drm_simple_encoder_init() variant that registers > drm_encoder_cleanup() with drmm_add_action(). > > Now drivers can store encoders in memory allocated with drmm_kmalloc() > after the call to drmm_mode_config_init(), without having to

[Bug 208657] protection fault rx580, Video and input freeze, audio keeps working. Related: 207383?

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208657 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC|

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Christian König
Am 22.07.20 um 16:30 schrieb Thomas Hellström (Intel): On 2020-07-22 16:23, Christian König wrote: Am 22.07.20 um 16:07 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 3:12 PM Thomas Hellström (Intel) wrote: On 2020-07-22 14:41, Daniel Vetter wrote: I'm pretty sure there's more bugs, I just

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Intel
On 2020-07-22 16:23, Christian König wrote: Am 22.07.20 um 16:07 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 3:12 PM Thomas Hellström (Intel) wrote: On 2020-07-22 14:41, Daniel Vetter wrote: I'm pretty sure there's more bugs, I just haven't heard from them yet. Also due to the opt-in

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Michel Dänzer
On 2020-07-22 3:10 p.m., Kazlauskas, Nicholas wrote: > On 2020-07-22 8:51 a.m., Daniel Vetter wrote: >> On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: >>> >>> From: Michel Dänzer >>> >>> drm_atomic_crtc_check enforces that ::active can only be true if >>> ::enable is as well. >>> >>>

[Bug 208657] New: protection fault rx580, Video and input freeze, audio keeps working. Related: 207383?

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=208657 Bug ID: 208657 Summary: protection fault rx580, Video and input freeze, audio keeps working. Related: 207383? Product: Drivers Version: 2.5 Kernel Version: 5.7.7, 5.7.8

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Christian König
Am 22.07.20 um 16:07 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 3:12 PM Thomas Hellström (Intel) wrote: On 2020-07-22 14:41, Daniel Vetter wrote: I'm pretty sure there's more bugs, I just haven't heard from them yet. Also due to the opt-in nature of dma-fence we can limit the scope of

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 3:12 PM Thomas Hellström (Intel) wrote: > On 2020-07-22 14:41, Daniel Vetter wrote: > > Ah I think I misunderstood which options you want to compare here. I'm > > not sure how much pain fixing up "dma-fence as memory fence" really > > is. That's kinda why I want a lot more

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Melissa Wen
On 07/22, dan...@ffwll.ch wrote: > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > This patch adds a missing drm_crtc_vblank_put op to the pair > > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). > > > > It clears the execution of the following

Re: [PATCH 5/8] drm/imx: parallel-display: use drm managed resources

2020-07-22 Thread Philipp Zabel
On Wed, 2020-07-22 at 15:30 +0200, Philipp Zabel wrote: [...] > and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is > called before the memory is freed. [...] > @@ -259,6 +259,13 @@ static const struct drm_bridge_funcs imx_pd_bridge_funcs > = { >

[PATCH 2/2] drm/imx: ipuv3-plane: add color encoding and range properties

2020-07-22 Thread Philipp Zabel
Add COLOR_ENCODING and COLOR_RANGE plane properties and use them to control the DP CSC matrix. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 44 +-- 1 file changed, 30 insertions(+), 14 deletions(-) diff --git

[PATCH 1/2] gpu: ipu-v3: Add Rec.709 limited range support to DP

2020-07-22 Thread Philipp Zabel
Add YCbCr encoding and quantization range parameters to ipu_dp_setup_channel() and configure the CSC DP matrix accordingly. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-plane.c | 9 ++--- drivers/gpu/ipu-v3/ipu-dp.c | 25 ++---

[PATCH 3/8] drm/imx: imx-ldb: use drm managed resources

2020-07-22 Thread Philipp Zabel
Use drmm_kzalloc() to align encoder memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is called before the memory is freed. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-ldb.c | 67 +++ 1 file

[PATCH 5/8] drm/imx: parallel-display: use drm managed resources

2020-07-22 Thread Philipp Zabel
Use drmm_kzalloc() to align encoder memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is called before the memory is freed. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/parallel-display.c | 50 +- 1 file

[PATCH 1/8] drm/imx: drop explicit drm_mode_config_cleanup

2020-07-22 Thread Philipp Zabel
Use drmm_mode_config_init() and drop the explicit calls to drm_mode_config_cleanup(). Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-drm-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c

[PATCH 8/8] drm/imx: ipuv3-crtc: use drm managed resources

2020-07-22 Thread Philipp Zabel
Use drmm_kzalloc() to align crtc memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure IPU resources are released and drm_crtc_cleanup() is called before the memory is freed. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-crtc.c | 75

[PATCH 6/8] drm/imx: ipuv3-plane: use drm managed resources

2020-07-22 Thread Philipp Zabel
Use drmm_kzalloc() to align plane memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure drm_plane_cleanup() is called before the memory is freed. Also handle error return values of the plane property creation functions. Signed-off-by: Philipp Zabel ---

[PATCH 4/8] drm/imx: imx-tve: use drm managed resources

2020-07-22 Thread Philipp Zabel
Move devres regmap, clock, and interrupt requests into probe. Use drmm_kzalloc() to align encoder memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is called before the memory is freed. Signed-off-by: Philipp Zabel ---

[PATCH 2/8] drm/imx: dw_hdmi-imx: use drm managed resources, switch to dw_hdmi_probe

2020-07-22 Thread Philipp Zabel
Move bridge creation into probe, during bind only create the encoder and attach the bridge. Use drmm_kzalloc() to align encoder memory lifetime with the drm device, and use drmm_add_action_or_reset() to make sure drm_encoder_cleanup() is called before the memory is freed. Signed-off-by: Philipp

[PATCH 7/8] drm/imx: move call to ipu_plane_get_resources() into ipu_plane_init()

2020-07-22 Thread Philipp Zabel
Use drm managed resources to get and put IPU resources automatically. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/ipuv3-crtc.c | 25 + drivers/gpu/drm/imx/ipuv3-plane.c | 29 - drivers/gpu/drm/imx/ipuv3-plane.h | 3 --- 3 files

[PATCH] drm/simple_kms_helper: add drmm_simple_encoder_init()

2020-07-22 Thread Philipp Zabel
Add a drm_simple_encoder_init() variant that registers drm_encoder_cleanup() with drmm_add_action(). Now drivers can store encoders in memory allocated with drmm_kmalloc() after the call to drmm_mode_config_init(), without having to manually make sure that drm_encoder_cleanup() is called before

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Intel
On 2020-07-22 14:41, Daniel Vetter wrote: Ah I think I misunderstood which options you want to compare here. I'm not sure how much pain fixing up "dma-fence as memory fence" really is. That's kinda why I want a lot more testing on my annotation patches, to figure that out. Not much feedback

Re: [PATCH v5 3/4] drm/bridge: Introduce LT9611 DSI to HDMI bridge

2020-07-22 Thread Laurent Pinchart
Hello, On Sun, Jul 19, 2020 at 07:18:06PM +0200, Sam Ravnborg wrote: > Hi Vinod. > > Three trivial points below. > The rest looks good. > > With these fixed you can add: > Reviewed-by: Sam Ravnborg > > Sam > > On Wed, Jul 08, 2020 at 04:05:58PM +0530, Vinod Koul wrote: > > Lontium

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Kazlauskas, Nicholas
On 2020-07-22 8:51 a.m., Daniel Vetter wrote: On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: From: Michel Dänzer drm_atomic_crtc_check enforces that ::active can only be true if ::enable is as well. Signed-off-by: Michel Dänzer Looks fine to me. The check is sufficiently old

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #84 from Nicholas Kazlauskas (nicholas.kazlaus...@amd.com) --- We don't manually free the dm_state from amdgpu, that should be handled by the DRM core. It should generally only be freed once it's no longer use by the DRM core as well

Re: [PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 2:38 PM Michel Dänzer wrote: > > From: Michel Dänzer > > drm_atomic_crtc_check enforces that ::active can only be true if > ::enable is as well. > > Signed-off-by: Michel Dänzer modeset vs modereset is a bit an inglorious name choice ... since this seems to be glue code

[PATCH 2/2] drm/imx: imx-tve: remove redundant enable tracking

2020-07-22 Thread Philipp Zabel
The DRM core already takes care that encoder enable and disable calls are balanced. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c

[PATCH 1/2] drm/imx: imx-tve: use regmap fast_io spinlock

2020-07-22 Thread Philipp Zabel
Replace the custom spinlock with the fast_io spinlock provided by regmap. Signed-off-by: Philipp Zabel --- drivers/gpu/drm/imx/imx-tve.c | 22 +- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 2:22 PM Thomas Hellström (Intel) wrote: > > > On 2020-07-22 13:39, Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 12:31 PM Thomas Hellström (Intel) > > wrote: > >> > >> On 2020-07-22 11:45, Daniel Vetter wrote: > >>> On Wed, Jul 22, 2020 at 10:05 AM Thomas Hellström

Re: [PATCH v3 06/21] drm/bridge: tc358767: add drm_panel_bridge support

2020-07-22 Thread Laurent Pinchart
Hi Sam, On Sun, Jul 19, 2020 at 03:06:56PM +0200, Sam Ravnborg wrote: > On Sat, Jul 11, 2020 at 01:19:35AM +0300, Laurent Pinchart wrote: > > On Fri, Jul 03, 2020 at 09:24:02PM +0200, Sam Ravnborg wrote: > > > Prepare the bridge driver for use in a chained setup by > > > replacing direct use of

[PATCH] drm/amdgpu/dc: Simplify drm_crtc_state::active checks

2020-07-22 Thread Michel Dänzer
From: Michel Dänzer drm_atomic_crtc_check enforces that ::active can only be true if ::enable is as well. Signed-off-by: Michel Dänzer --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c| 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Intel
On 2020-07-22 13:39, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 12:31 PM Thomas Hellström (Intel) wrote: On 2020-07-22 11:45, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 10:05 AM Thomas Hellström (Intel) wrote: On 2020-07-22 09:11, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 8:45 AM

Re: [PATCH] drm/bridge/adv7511: set the bridge type properly

2020-07-22 Thread Laurent Pinchart
Hi Laurentiu, Thank you for the patch. On Mon, Jul 20, 2020 at 03:42:27PM +0300, Laurentiu Palcu wrote: > From: Laurentiu Palcu > > After the drm_bridge_connector_init() helper function has been added, the ADV > driver has been changed accordingly. However, the 'type' field of the bridge >

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread daniel
On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > This patch adds a missing drm_crtc_vblank_put op to the pair > drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). > > It clears the execution of the following kms_cursor_crc subtests: > 1.

Re: [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 1:50 PM Christian König wrote: > > Am 22.07.20 um 13:42 schrieb Daniel Vetter: > > On Wed, Jul 22, 2020 at 1:13 PM Christian König > > wrote: > >> Am 22.07.20 um 07:34 schrieb Daniel Vetter: > >>> On Tue, Jul 21, 2020 at 4:46 PM Christian König > >>> wrote: > Am

RE: [PATCH v2] io-mapping: Indicate mapping failure

2020-07-22 Thread Ruhl, Michael J
>-Original Message- >From: Andrew Morton >Sent: Tuesday, July 21, 2020 5:24 PM >To: Ruhl, Michael J >Cc: dri-devel@lists.freedesktop.org; Mike Rapoport ; >Andy Shevchenko ; Chris Wilson >; sta...@vger.kernel.org >Subject: Re: [PATCH v2] io-mapping: Indicate mapping failure > >On Tue, 21

Re: [PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-07-22 Thread Laurent Pinchart
Hi Swapnil, Thank you for the patch. On Wed, Jul 22, 2020 at 09:40:39AM +0200, Swapnil Jakhade wrote: > Add a new DRM bridge driver for Cadence MHDP DPTX IP used in TI J721e SoC. > MHDP DPTX IP is the component that complies with VESA DisplayPort (DP) and > embedded Display Port (eDP) standards.

Re: [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-22 Thread Christian König
Am 22.07.20 um 13:42 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 1:13 PM Christian König wrote: Am 22.07.20 um 07:34 schrieb Daniel Vetter: On Tue, Jul 21, 2020 at 4:46 PM Christian König wrote: Am 21.07.20 um 11:24 schrieb dan...@ffwll.ch: On Tue, Jul 21, 2020 at 09:32:40AM +0200,

Re: [PATCH v7 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-07-22 Thread kernel test robot
'--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Swapnil-Jakhade/drm-Add-support-for-Cadence-MHDP-DPI-DP-bridge-and-J721E-wrapper/20200722-154322 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config

Re: [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 1:13 PM Christian König wrote: > > Am 22.07.20 um 07:34 schrieb Daniel Vetter: > > On Tue, Jul 21, 2020 at 4:46 PM Christian König > > wrote: > >> Am 21.07.20 um 11:24 schrieb dan...@ffwll.ch: > >>> On Tue, Jul 21, 2020 at 09:32:40AM +0200, Christian König wrote: >

Re: [PATCH -next] gpu: drm: Fix spinlock vblank_time_lock use error.

2020-07-22 Thread Ville Syrjälä
On Wed, Jul 22, 2020 at 01:05:27AM +, Xu Qiang wrote: > The drm_handle_vblank function is in the interrupt context. > Therefore, the spin lock vblank_time_lock is obtained > from the interrupt context. > > Cc: > Signed-off-by: Xu Qiang > --- > drivers/gpu/drm/drm_vblank.c | 17

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 12:31 PM Thomas Hellström (Intel) wrote: > > > On 2020-07-22 11:45, Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 10:05 AM Thomas Hellström (Intel) > > wrote: > >> > >> On 2020-07-22 09:11, Daniel Vetter wrote: > >>> On Wed, Jul 22, 2020 at 8:45 AM Thomas Hellström

Re: [Intel-gfx] [PATCH v1] drm/i915/dsi: Drop double check for ACPI companion device

2020-07-22 Thread Ville Syrjälä
On Fri, May 29, 2020 at 03:33:17PM +0300, Andy Shevchenko wrote: > acpi_dev_get_resources() does perform the NULL pointer check against > ACPI companion device which is given as function parameter. Thus, > there is no need to duplicate this check in the caller. > > Signed-off-by: Andy Shevchenko

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 1:12 PM Christian König wrote: > > Am 22.07.20 um 09:32 schrieb Daniel Vetter: > > On Wed, Jul 22, 2020 at 9:19 AM Christian König > > wrote: > >> Am 22.07.20 um 02:22 schrieb Gurchetan Singh: > >> > >> +Christian who added DMABUF_MOVE_NOTIFY which added the relevant

Re: [PATCH v1 1/1] drm/bridge: nwl-dsi: Drop DRM_BRIDGE_ATTACH_NO_CONNECTOR check.

2020-07-22 Thread Laurent Pinchart
Hi Guido, Thank you for the patch. On Sat, Jul 18, 2020 at 08:26:37PM +0200, Guido Günther wrote: > We don't create a connector but let panel_bridge handle that so there's > no point in rejecting DRM_BRIDGE_ATTACH_NO_CONNECTOR. > > Signed-off-by: Guido Günther Reviewed-by: Laurent Pinchart

Re: [PATCH 06/11] drm/radeon: stop using TTM_MEMTYPE_FLAG_MAPPABLE

2020-07-22 Thread Christian König
Am 22.07.20 um 07:34 schrieb Daniel Vetter: On Tue, Jul 21, 2020 at 4:46 PM Christian König wrote: Am 21.07.20 um 11:24 schrieb dan...@ffwll.ch: On Tue, Jul 21, 2020 at 09:32:40AM +0200, Christian König wrote: The driver doesn't expose any not-mapable memory resources. Signed-off-by:

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Christian König
Am 22.07.20 um 09:32 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 9:19 AM Christian König wrote: Am 22.07.20 um 02:22 schrieb Gurchetan Singh: +Christian who added DMABUF_MOVE_NOTIFY which added the relevant blurb:

[PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-22 Thread Melissa Wen
This patch adds a missing drm_crtc_vblank_put op to the pair drm_crtc_vblank_get/put (inc/decrement counter to guarantee vblanks). It clears the execution of the following kms_cursor_crc subtests: 1. pipe-A-cursor-[size,alpha-opaque, NxN-(on-screen, off-screen, sliding, random, fast-moving])]

Re: [PATCH 09/20] Documentation: i2c: eliminate duplicated word

2020-07-22 Thread Wolfram Sang
On Tue, Jul 07, 2020 at 11:04:03AM -0700, Randy Dunlap wrote: > Drop doubled word "new". > > Signed-off-by: Randy Dunlap For the record: Acked-by: Wolfram Sang signature.asc Description: PGP signature ___ dri-devel mailing list

[PULL] drm-misc-next

2020-07-22 Thread Maarten Lankhorst
drm-misc-next-2020-07-22: drm-misc-next for v5.9: UAPI Changes: Cross-subsystem Changes: - Convert panel-dsi-cm and ingenic bindings to YAML. - Add lockdep annotations for dma-fence. \o/ - Describe why indefinite fences are a bad idea - Update binding for rocktech jh057n00900. Core Changes: -

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Christian König
Am 22.07.20 um 09:46 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 9:19 AM Christian König wrote: Am 22.07.20 um 02:22 schrieb Gurchetan Singh: Of the desktop GPU drivers, i915's shrinker certainly supports purging to swap. TTM is a bit hard to follow. I can't really tell if amdgpu or

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Intel
On 2020-07-22 11:45, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 10:05 AM Thomas Hellström (Intel) wrote: On 2020-07-22 09:11, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 8:45 AM Thomas Hellström (Intel) wrote: On 2020-07-22 00:45, Dave Airlie wrote: On Tue, 21 Jul 2020 at 18:47,

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 10:05 AM Thomas Hellström (Intel) wrote: > > > On 2020-07-22 09:11, Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 8:45 AM Thomas Hellström (Intel) > > wrote: > >> > >> On 2020-07-22 00:45, Dave Airlie wrote: > >>> On Tue, 21 Jul 2020 at 18:47, Thomas Hellström (Intel)

Re: [PATCH v2] fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins.

2020-07-22 Thread Daniel Vetter
On Tue, Jul 21, 2020 at 6:08 PM Greg Kroah-Hartman wrote: > > On Thu, Jul 16, 2020 at 08:27:21PM +0900, Tetsuo Handa wrote: > > On 2020/07/16 19:00, Daniel Vetter wrote: > > > On Thu, Jul 16, 2020 at 12:29:00AM +0900, Tetsuo Handa wrote: > > >> On 2020/07/16 0:12, Dan Carpenter wrote: > > >>>

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Intel
On 2020-07-22 09:11, Daniel Vetter wrote: On Wed, Jul 22, 2020 at 8:45 AM Thomas Hellström (Intel) wrote: On 2020-07-22 00:45, Dave Airlie wrote: On Tue, 21 Jul 2020 at 18:47, Thomas Hellström (Intel) wrote: On 7/21/20 9:45 AM, Christian König wrote: Am 21.07.20 um 09:41 schrieb Daniel

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 9:19 AM Christian König wrote: > Am 22.07.20 um 02:22 schrieb Gurchetan Singh: >> Of the desktop GPU drivers, i915's shrinker certainly supports purging >> to swap. TTM is a bit hard to follow. I can't really tell if amdgpu >> or nouveau supports that. virtio-gpu is

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 9:19 AM Christian König wrote: > > Am 22.07.20 um 02:22 schrieb Gurchetan Singh: > > +Christian who added DMABUF_MOVE_NOTIFY which added the relevant blurb: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma-buf/Kconfig#n46 > >

[Bug 207383] [Regression] 5.7 amdgpu/polaris11 gpf: amdgpu_atomic_commit_tail

2020-07-22 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=207383 --- Comment #83 from Christian König (christian.koe...@amd.com) --- Instead of working around the bug I think we should concentrate on nailing the root cause. I suggest to insert an use after free check into just that structure. In other words

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Christian König
Am 22.07.20 um 09:19 schrieb Christian König: Am 22.07.20 um 02:22 schrieb Gurchetan Singh: +Christian who added DMABUF_MOVE_NOTIFY which added the relevant blurb: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma-buf/Kconfig#n46

Re: pages pinned for BO lifetime and security

2020-07-22 Thread Christian König
Am 22.07.20 um 02:22 schrieb Gurchetan Singh: +Christian who added DMABUF_MOVE_NOTIFY which added the relevant blurb: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/dma-buf/Kconfig#n46

Re: [Linaro-mm-sig] [PATCH 1/2] dma-buf.rst: Document why indefinite fences are a bad idea

2020-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2020 at 8:45 AM Thomas Hellström (Intel) wrote: > > > On 2020-07-22 00:45, Dave Airlie wrote: > > On Tue, 21 Jul 2020 at 18:47, Thomas Hellström (Intel) > > wrote: > >> > >> On 7/21/20 9:45 AM, Christian König wrote: > >>> Am 21.07.20 um 09:41 schrieb Daniel Vetter: > On

RE: [PATCH 02/11] drm/ttm: cleanup io_mem interface with nouveau

2020-07-22 Thread Chauhan, Madhav
[AMD Public Use] -Original Message- From: Christian König Sent: Tuesday, July 21, 2020 1:03 PM To: dri-devel@lists.freedesktop.org Cc: Chauhan, Madhav ; tzimmerm...@suse.de; michael.j.r...@intel.com Subject: [PATCH 02/11] drm/ttm: cleanup io_mem interface with nouveau Nouveau is the

[PULL] drm-misc-fixes

2020-07-22 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-fixes. There are only 2 fixes. The sun4i patch updates a bugfix that was merged via drm-misc-fixes a few weeks ago. Best regards Thomas drm-misc-fixes-2020-07-22: * sun4i: Fix inverted HPD result; fixes an earlier fix * lima: fix timeout

[PATCH -next] drm/amdgpu/vcn3.0: Remove set but not used variable 'direct_poll'

2020-07-22 Thread YueHaibing
drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c: In function vcn_v3_0_start_sriov: drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c:1235:3: warning: variable direct_poll set but not used [-Wunused-but-set-variable] It is never used, so can remove it. Signed-off-by: YueHaibing ---

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-22 Thread Patrick Volkerding
On 7/21/20 10:27 AM, Mika Westerberg wrote: > On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: >> Sure thing. Also, feel free to let me know if you'd like access to one of the >> systems we saw breaking with this patch - I'm fairly sure I've got one of >> them >> locally at my

Re: [PATCH v1] io-mapping: Indicate mapping failure

2020-07-22 Thread Andy Shevchenko
On Tue, Jul 21, 2020 at 11:34:26AM -0400, Michael J. Ruhl wrote: Thanks for an update, my comments below. > The !ATOMIC_IOMAP version of io_maping_init_wc will always return > success, even when the ioremap fails. > > Since the ATOMIC_IOMAP version returns NULL when the init fails, and >

Re: [PATCH] io-mapping: Indicate mapping failure

2020-07-22 Thread Andy Shevchenko
On Tue, Jul 21, 2020 at 10:16:41AM -0400, Michael J. Ruhl wrote: > Sometimes it is good to know when your mapping failed. Can you elaborate... > Fixes: cafaf14a5d8f ("io-mapping: Always create a struct to hold metadata > about the io-mapping" ...especially taking into account that Fixes

[PATCH] drm/panel: remove meaningless if(ret) check code.

2020-07-22 Thread Bernard Zhao
The function drm_panel_add always returns true. So if(ret) check code will never run into error branch. Remove these check make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/panel/panel-feixin-k101-im2ba02.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)

[PATCH -next] drm/nouveau/kms/nvd9-: Fix file release memory leak

2020-07-22 Thread Wei Yongjun
When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. Fixes: 12885ecbfe62 ("drm/nouveau/kms/nvd9-: Add CRC support") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/gpu/drm/nouveau/dispnv50/crc.c | 1 +

[PATCH] drm/panel: remove meaningless if(ret) check code.

2020-07-22 Thread Bernard Zhao
The function drm_panel_add always returns true. So if(ret) check code will never run into error branch. Remove these check will make the code a bit readable. Signed-off-by: Bernard Zhao --- drivers/gpu/drm/panel/panel-feiyang-fy07024di26a30d.c | 4 +--- 1 file changed, 1 insertion(+), 3

Re: [PATCH] io-mapping: Indicate mapping failure

2020-07-22 Thread Mike Rapoport
On Tue, Jul 21, 2020 at 03:00:41PM +, Ruhl, Michael J wrote: > >-Original Message- > >From: Andy Shevchenko > >Sent: Tuesday, July 21, 2020 10:47 AM > >To: Ruhl, Michael J > >Cc: dri-devel@lists.freedesktop.org; Andrew Morton >foundation.org>; Mike Rapoport ; Chris Wilson > >;

Re: [PATCH] drm/msm/dp: Add DP compliance tests on Snapdragon Chipsets

2020-07-22 Thread khsieh
On 2020-07-20 19:57, Rob Clark wrote: On Mon, Jul 20, 2020 at 4:32 PM Stephen Boyd wrote: Quoting khs...@codeaurora.org (2020-07-20 15:48:13) > On 2020-07-20 13:18, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2020-07-07 11:41:25) > >> drivers/gpu/drm/msm/dp/dp_power.c | 32 +- >

Re: io-mapping: Indicate mapping failure

2020-07-22 Thread Andy Shevchenko
On Tue, Jul 21, 2020 at 11:34:25AM -0400, Michael J. Ruhl wrote: > I found this when my system crashed long after the mapping failure. > The expected behavior should have been driver exit. > > Since this is almost exclusively used for drm, I am posting to > the dri mailing list. Should this go

[PATCH] drm/virtio: fix memory leak in virtio_gpu_cleanup_object()

2020-07-22 Thread Xin He
Before setting shmem->pages to NULL, kfree() should be called. Signed-off-by: Xin He Reviewed-by: Qi Liu --- drivers/gpu/drm/virtio/virtgpu_object.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/virtio/virtgpu_object.c b/drivers/gpu/drm/virtio/virtgpu_object.c index

Re: [PATCH v5 0/6] Add support for GPU DDR BW scaling

2020-07-22 Thread Viresh Kumar
On 21-07-20, 07:28, Rob Clark wrote: > With your ack, I can add the patch the dev_pm_opp_set_bw patch to my > tree and merge it via msm-next -> drm-next -> linus I wanted to send it via my tree, but its okay. Pick this patch from linux-next and add my Ack, I will drop it after that. a8351c12c6c7

[PATCH -next] gpu: drm: Fix spinlock vblank_time_lock use error.

2020-07-22 Thread Xu Qiang
The drm_handle_vblank function is in the interrupt context. Therefore, the spin lock vblank_time_lock is obtained from the interrupt context. Cc: Signed-off-by: Xu Qiang --- drivers/gpu/drm/drm_vblank.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git

Re: nouveau regression with 5.7 caused by "PCI/PM: Assume ports without DLL Link Active train links in 100 ms"

2020-07-22 Thread Mika Westerberg
On Tue, Jul 21, 2020 at 11:01:55AM -0400, Lyude Paul wrote: > Sure thing. Also, feel free to let me know if you'd like access to one of the > systems we saw breaking with this patch - I'm fairly sure I've got one of them > locally at my apartment and don't mind setting up AMT/KVM/SSH Probably no

[PATCH -next] backlight: cr_bllcd: Remove unused variable 'intensity'

2020-07-22 Thread Wei Yongjun
Gcc report unused-variable warning as follows: drivers/video/backlight/cr_bllcd.c:62:6: warning: unused variable 'intensity' [-Wunused-variable] 62 | int intensity = bd->props.brightness; | ^ After commit 24d34617c24f ("backlight: cr_bllcd: Introduce gpio-backlight

  1   2   >