Re: [PATCH v2 3/4] drm/plane: add drmm_universal_plane_alloc()

2020-08-27 Thread kernel test robot
Hi Philipp, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip linus/master v5.9-rc2 next-20200827] [cannot apply to drm/drm-next] [If your patch is applied to the wrong git tree, kindly drop us

Re: Printing bitfields in the kernel (Re: [PATCH] drm: Parse Colorimetry data block from EDID)

2020-08-27 Thread Joe Perches
On Thu, 2020-08-27 at 10:34 +0300, Pekka Paalanen wrote: > On Wed, 26 Aug 2020 22:23:28 +0800 > Algea Cao wrote: > > > CEA 861.3 spec adds colorimetry data block for HDMI. > > Parsing the block to get the colorimetry data from > > panel. If flags are int, I could imagine another %p extension

Re: [PATCH v2 1/4] drm: add drmm_encoder_alloc()

2020-08-27 Thread kernel test robot
Hi Philipp, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on drm-tip/drm-tip linus/master v5.9-rc2 next-20200827] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[git pull] drm fixes for 5.9-rc3

2020-08-27 Thread Dave Airlie
Hey Linus, As expected a bit of an rc3 uptick, amdgpu and msm are the main ones, one msm patch was from the merge window, but had dependencies and we dropped it until the other tree had landed. Otherwise it's a couple of fixes for core, and etnaviv, and single i915, exynos, omap fixes. I'm still

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Matthias Brugger 於 2020年8月27日 週四 下午10:28寫道: > > > > On 27/08/2020 15:41, Frank Wunderlich wrote: > > Hi Matthias, > > > > any opinions about the dts-changes? > > > > they look good to me. > > > maybe series except the tmds-Patch get merged...so i add it only to my own > > repo till

Re: [PATCH v5 5/7] drm/mediatek: dpi/dsi: change the getting possible_crtc way

2020-08-27 Thread Chun-Kuang Hu
Hi, Matthias Brugger 於 2020年8月20日 週四 上午1:14寫道: > > > > On 19/08/2020 10:17, Frank Wunderlich wrote: > > From: Jitao Shi > > > > For current mediatek dsi encoder, its possible crtc is fixed in crtc > > 0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In > > some SoC the possible

Re: [PATCH v5 2/7] drm/mediatek: add ddp routing for mt7623

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月19日 週三 下午4:18寫道: > > From: Frank Wunderlich > > on BPi-R2/mt7623 main-path have to be routed to DPI0 (hdmi) instead of DSI0 > using compatible "mt7623-mmsys" already defined in dts > For this patch, applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v5 1/7] dt-bindings: mediatek: add mt7623 display-nodes

2020-08-27 Thread Chun-Kuang Hu
Hi, Frank: Frank Wunderlich 於 2020年8月19日 週三 下午4:18寫道: > > From: Frank Wunderlich > > mt7623 uses mt2701/mt8173 for drm, but have own compatibles > For this patch, applied to mediatek-drm-next [1], thanks. [1]

Re: [PATCH v2 10/24] drm/panel: novatek-nt35510: Backlight update

2020-08-27 Thread Linus Walleij
On Sun, Aug 23, 2020 at 12:46 PM Sam Ravnborg wrote: > - Replace direct access to backlight_properties with > backlight_get_brightness(). > - Drop debug printout > - Use macro for initialization > > Signed-off-by: Sam Ravnborg > Cc: Linus Walleij > Cc: Thierry Reding > Cc: Sam Ravnborg

[Bug 209015] Clocks are no longer reported for R9 390 GPU

2020-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209015 --- Comment #5 from Alex Deucher (alexdeuc...@gmail.com) --- Fixed with this patch: https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next=177e38a48168f9e70faaec34df053d2f8134ede6 -- You are receiving this mail because: You are watching

[PATCH v12 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-27 Thread Tanmay Shah
From: Chandan Uddaraju Add the needed DP PLL specific files to support display port interface on msm targets. The DP driver calls the DP PLL driver registration. The DP driver sets the link and pixel clock sources. Changes in v2: -- Update copyright markings on all relevant files. -- Use

[PATCH v12 5/5] drm/msm/dp: Add Display Port HPD feature

2020-08-27 Thread Tanmay Shah
Configure HPD registers in DP controller and enable HPD interrupt. Add interrupt to handle HPD connect and disconnect events. Changes in v8: None Signed-off-by: Tanmay Shah --- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 18 drivers/gpu/drm/msm/dp/dp_catalog.c | 67 +--

[PATCH v12 4/5] drm/msm/dpu: add display port support in DPU

2020-08-27 Thread Tanmay Shah
From: Jeykumar Sankaran Add display port support in DPU by creating hooks for DP encoder enumeration and encoder mode initialization. changes in v2: - rebase on [2] (Sean Paul) - remove unwanted error checks and switch cases (Jordan Crouse) [1]

[PATCH v12 0/5] Add support for DisplayPort driver on SnapDragon

2020-08-27 Thread Tanmay Shah
These patches add Display-Port driver on SnapDragon/msm hardware. This series also contains device-tree bindings for msm DP driver. It also contains Makefile and Kconfig changes to compile msm DP driver. The block diagram of DP driver is shown below: +-+

[PATCH v12 1/5] drm: add constant N value in helper file

2020-08-27 Thread Tanmay Shah
From: Chandan Uddaraju The constant N value (0x8000) is used by i915 DP driver. Define this value in dp helper header file to use in multiple Display Port drivers. Change i915 driver accordingly. Change in v6: Change commit message Signed-off-by: Chandan Uddaraju Signed-off-by: Vara Reddy

[Bug 209015] Clocks are no longer reported for R9 390 GPU

2020-08-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=209015 --- Comment #4 from HenryJiM (henryjm11...@gmail.com) --- I just retested, clocks actually are reported correctly with the Radeon driver. this issue is specific to the AMDGPU driver AMDGPU was loading regardless of kernel cmdline before:

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread John Stultz
On Thu, Aug 27, 2020 at 10:17 AM Greg Kroah-Hartman wrote: > On Thu, Aug 27, 2020 at 10:31:41PM +0530, Amit Pundir wrote: > > I don't know what is the right thing to do here. I just want to > > highlight that AOSP's audio (codec2) HAL depends on the ION system > > heap and it will break AOSP for

[PATCH] drm/nouveau: remove redundant check

2020-08-27 Thread trix
From: Tom Rix clang static analysis flags this problem hw.c:271:12: warning: The left operand of '>=' is a garbage value if (pv.M1 >= pll_lim.vco1.min_m ... ~ ^ This is mostly not a problem because an early check in nouveau_hw_fix_bad_vpll() if

Re: [PATCH 13/18] iommu/tegra: Add IOMMU_DOMAIN_DMA support

2020-08-27 Thread Robin Murphy
On 2020-08-27 16:45, Thierry Reding wrote: On Thu, Aug 20, 2020 at 04:08:32PM +0100, Robin Murphy wrote: Now that arch/arm is wired up for default domains and iommu-dma, implement the corresponding driver-side support for DMA domains. Signed-off-by: Robin Murphy ---

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 10:31:41PM +0530, Amit Pundir wrote: > On Thu, 27 Aug 2020 at 21:34, Greg Kroah-Hartman > wrote: > > > > On Thu, Aug 27, 2020 at 09:31:27AM -0400, Laura Abbott wrote: > > > On 8/27/20 8:36 AM, Greg Kroah-Hartman wrote: > > > > The ION android code has long been marked to

Re: [Intel-gfx] [PATCH] drm/i915/vlv_dsi_pll: fix spelling mistake "Cant" -> "Can't"

2020-08-27 Thread Ville Syrjälä
On Mon, Aug 10, 2020 at 10:59:52AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a drm_err message. Fix it. Thanks. Applied to dinq. > > Signed-off-by: Colin Ian King > --- > drivers/gpu/drm/i915/display/vlv_dsi_pll.c | 2 +- > 1 file changed, 1

[PATCH v2 3/4] drm/plane: add drmm_universal_plane_alloc()

2020-08-27 Thread Philipp Zabel
Add an alternative to drm_universal_plane_init() that allocates and initializes a plane and registers drm_plane_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- Changes since v1: - add __printf annotation to __drm_universal_plane_init() and make it static ---

[PATCH v2 1/4] drm: add drmm_encoder_alloc()

2020-08-27 Thread Philipp Zabel
Add an alternative to drm_encoder_init() that allocates and initializes an encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- Changes since v1: - add __printf annotation to __drm_encoder_init() --- drivers/gpu/drm/drm_encoder.c | 105

[PATCH v2 4/4] drm/crtc: add drmm_crtc_alloc_with_planes()

2020-08-27 Thread Philipp Zabel
Add an alternative to drm_crtc_init_with_planes() that allocates and initializes a crtc and registers drm_crtc_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- Changes since v1: - fix drm_crtc_init_with_planes() to actually call __drm_crtc_init_with_planes()

[PATCH v2 2/4] drm/simple_kms_helper: add drmm_simple_encoder_alloc()

2020-08-27 Thread Philipp Zabel
Add an alternative to drm_simple_encoder_init() that allocates and initializes a simple encoder and registers drm_encoder_cleanup() with drmm_add_action_or_reset(). Signed-off-by: Philipp Zabel --- drivers/gpu/drm/drm_simple_kms_helper.c | 12 include/drm/drm_simple_kms_helper.h

Re: [PATCH] staging: ion: remove from the tree

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 09:31:27AM -0400, Laura Abbott wrote: > On 8/27/20 8:36 AM, Greg Kroah-Hartman wrote: > > The ION android code has long been marked to be removed, now that we > > dma-buf support merged into the real part of the kernel. > > > > It was thought that we could wait to remove

[PATCH][next] drm/amdgpu/swsmu: fix potential uint32_t multiplication overflow

2020-08-27 Thread Colin King
From: Colin Ian King The calculation of tmp64 is performed using a 32 bit multiply and then is stored in the uint64_t variable tmp64. This indicates that a 64 bit result may be expected, so cast crystal_clock_freq to a uint64_t to ensure a 64 bit multiplication is being performed to avoid any

Re: [PATCH 16/18] staging/media/tegra-vde: Clean up IOMMU workaround

2020-08-27 Thread Thierry Reding
On Thu, Aug 27, 2020 at 10:05:14AM +0300, Dmitry Osipenko wrote: > 24.08.2020 17:01, Robin Murphy пишет: > ... > >> Robin, thank you very much for the clarifications! > >> > >> In accordance to yours comments, this patch can't be applied until Tegra > >> SMMU will support IOMMU_DOMAIN_IDENTITY and

Re: [PATCH 13/18] iommu/tegra: Add IOMMU_DOMAIN_DMA support

2020-08-27 Thread Thierry Reding
On Thu, Aug 20, 2020 at 04:08:32PM +0100, Robin Murphy wrote: > Now that arch/arm is wired up for default domains and iommu-dma, > implement the corresponding driver-side support for DMA domains. > > Signed-off-by: Robin Murphy > --- > drivers/iommu/tegra-smmu.c | 37

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-27 Thread Simon Ser
On Thursday, August 20, 2020 10:15 AM, Ezequiel Garcia wrote: > > I'm rather interested on where this goes, as I was toying with using > > some sort of heap ID as a basis for a "device-local" constraint in the > > memory constraints proposals Simon and I will be discussing at XDC this > > year.

Re: Aw: Re: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Matthias Brugger
On 27/08/2020 15:41, Frank Wunderlich wrote: Hi Matthias, any opinions about the dts-changes? they look good to me. maybe series except the tmds-Patch get merged...so i add it only to my own repo till we find a better way? currently mainline does not support hdmi at all for the board.

Re: [PATCH v5 13/20] drm/i915/dp: Extract drm_dp_read_downstream_info()

2020-08-27 Thread Jani Nikula
On Wed, 26 Aug 2020, Lyude Paul wrote: > We're going to be doing the same probing process in nouveau for > determining downstream DP port capabilities, so let's deduplicate the > work by moving i915's code for handling this into a shared helper: > drm_dp_read_downstream_info(). > > Note that when

Re: [PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 27, 2020 at 7:18 AM Christian König wrote: > > Am 25.08.20 um 19:33 schrieb Kai-Heng Feng: > > Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") > > fixed screen flicker for HP Compaq nx9420 but breaks other laptops like > > Asus X50SL. > > >

Re: [PATCH v5 09/20] drm/i915/dp: Extract drm_dp_read_mst_cap()

2020-08-27 Thread Jani Nikula
On Wed, 26 Aug 2020, Lyude Paul wrote: > Just a tiny drive-by cleanup, we can consolidate i915's code for > checking for MST support into a helper to be shared across drivers. > > v5: > * Drop !!() > * Move drm_dp_has_mst() out of header > * Change name from drm_dp_has_mst() to

Re: [PATCH 1/1] AMDGPU : Fix bug in reporting voltage for CIK

2020-08-27 Thread Alex Deucher
Applied with some minor whitespace fixes. Thanks! Alex On Thu, Aug 27, 2020 at 9:13 AM Sandeep Raghuraman wrote: > > On my R9 390, the voltage was reported as a constant 1000 mV. This was due to > a bug in smu7_hwmgr.c, in the smu7_read_sensor() function, where some magic > constants were

Re: [PATCH 1/1] AMDGPU: Specify get_argument function for ci_smu_funcs

2020-08-27 Thread Alex Deucher
Applied. Thanks! Alex On Thu, Aug 27, 2020 at 7:37 AM Sandeep Raghuraman wrote: > > Starting in Linux 5.8, the graphics and memory clock frequency were not being > reported for CIK cards. This is a regression, since they were reported > correctly in Linux 5.7. This was due to changes in

[PATCH 1/1] AMDGPU : Fix bug in reporting voltage for CIK

2020-08-27 Thread Sandeep Raghuraman
On my R9 390, the voltage was reported as a constant 1000 mV. This was due to a bug in smu7_hwmgr.c, in the smu7_read_sensor() function, where some magic constants were used in a condition, to determine whether the voltage should be read from PLANE2_VID or PLANE1_VID. The VDDC mask was

Re: Aw: [PATCH 00/18] Convert arch/arm to use iommu-dma

2020-08-27 Thread Matthias Brugger
On 27/08/2020 14:31, Frank Wunderlich wrote: Tested full series on bananapi r2 (mt7623/mt2701, 5.9-rc1 + hdmi-patches), works so far fbcon+x without issues Tested-by: Frank Wunderlich Thanks for testing. Robin this is especially relevant for: [PATCH 09/18] iommu/mediatek-v1: Add

[PATCH] staging: ion: remove from the tree

2020-08-27 Thread Greg Kroah-Hartman
The ION android code has long been marked to be removed, now that we dma-buf support merged into the real part of the kernel. It was thought that we could wait to remove the ion kernel at a later time, but as the out-of-tree Android fork of the ion code has diverged quite a bit, and any Android

Re: [PATCH v4 0/2] staging: android: Remove BUG/BUG_ON from ion

2020-08-27 Thread Greg Kroah-Hartman
On Thu, Aug 27, 2020 at 08:16:54AM +0100, Christoph Hellwig wrote: > On Tue, Aug 25, 2020 at 08:52:29AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 25, 2020 at 07:47:29AM +0100, Christoph Hellwig wrote: > > > On Fri, Aug 21, 2020 at 06:27:04PM +0300, Tomer Samara wrote: > > > > Remove

Re: [00/23] ttm tt refactoring.

2020-08-27 Thread Christian König
A repeating style nit pick that {} can be dropped on single line if and empty line between declaration and code. Apart from that looks mostly good to me :) Patches #1-#4, #6, #10, #12-#15 are Reviewed-by: Christian König Patch #5, #8, #9, #11 are Acked-by: Christian König A few nits on

Re: [PATCH 17/23] drm/ttm: split populated/bound state flags.

2020-08-27 Thread Christian König
Am 26.08.20 um 03:44 schrieb Dave Airlie: From: Dave Airlie Get bound out is the next step. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c| 4 ++-- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 ++-- drivers/gpu/drm/radeon/radeon_mn.c | 2 +-

Re: [PATCH 07/23] drm/radeon/ttm: move to driver binding/destroy functions.

2020-08-27 Thread Christian König
Am 26.08.20 um 03:44 schrieb Dave Airlie: From: Dave Airlie Do agp decision in the driver, instead of special binding funcs Signed-off-by: Dave Airlie --- drivers/gpu/drm/radeon/radeon.h| 7 +- drivers/gpu/drm/radeon/radeon_cs.c | 2 +- drivers/gpu/drm/radeon/radeon_gem.c

Re: [v4,04/15] drm/bridge: tc358764: add drm_panel_bridge support

2020-08-27 Thread Marek Szyprowski
Hi Sam, On 26.07.2020 22:33, Sam Ravnborg wrote: > Prepare the tc358764 bridge driver for use in a chained setup by > replacing direct use of drm_panel with drm_panel_bridge support. > > The bridge panel will use the connector type reported by the panel, > where the connector for this driver

[PATCH 1/1] AMDGPU: Specify get_argument function for ci_smu_funcs

2020-08-27 Thread Sandeep Raghuraman
Starting in Linux 5.8, the graphics and memory clock frequency were not being reported for CIK cards. This is a regression, since they were reported correctly in Linux 5.7. This was due to changes in commit a0ec225633d9f681e393a1827f29f02c837deb84. After investigation, I discovered that the

Re: [PATCH] drm/radeon: Prefer lower feedback dividers

2020-08-27 Thread Christian König
Am 25.08.20 um 19:33 schrieb Kai-Heng Feng: Commit 2e26ccb119bd ("drm/radeon: prefer lower reference dividers") fixed screen flicker for HP Compaq nx9420 but breaks other laptops like Asus X50SL. Turns out we also need to favor lower feedback dividers. Mhm, let's hope that this works out for

Re: [PATCH] drm: Parse Colorimetry data block from EDID

2020-08-27 Thread Ville Syrjälä
On Wed, Aug 26, 2020 at 10:23:28PM +0800, Algea Cao wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. And what exactly do you want to do with that data? > > Signed-off-by: Algea Cao > --- > > drivers/gpu/drm/drm_edid.c

Re: [RFC] Experimental DMA-BUF Device Heaps

2020-08-27 Thread Simon Ser
On Tuesday, August 25, 2020 10:26 PM, Nicolas Dufresne wrote: > > I don't think we can do this in a system-agnostic way. What I'd like to > > see is an API for the kernel to expose opaque constraints for each > > Please, take into consideration that constraints can also come from > userspace.

Re: [PATCH 3/3] drm/vc4: hdmi: Add pixel bvb clock control

2020-08-27 Thread Stefan Wahren
Am 27.08.20 um 06:35 schrieb Hoegeun Kwon: > Hi Stefan, > > Thank you for your review. > > > On 8/26/20 7:04 PM, Stefan Wahren wrote: >> Hi Hoeguen, >> >> Am 21.08.20 um 09:10 schrieb Hoegeun Kwon: >>> There is a problem that the output does not work at a resolution >>> exceeding FHD. To solve

Re: [PATCH] drm/mgag200: fix spelling mistake "expeced" -> "expected"

2020-08-27 Thread Thomas Zimmermann
Hi Am 26.08.20 um 10:47 schrieb Colin King: > From: Colin Ian King > > There is a spelling mistake in a drm_warn message. Fix it. > > Signed-off-by: Colin Ian King Thanks! Applied to drm-misc-next. Best regards Thomas > --- > drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- > 1 file changed,

Re: [PATCH] drm/hisilicon: Removed the dependency on the mmu

2020-08-27 Thread Thomas Zimmermann
Hi Am 26.08.20 um 09:55 schrieb Tian Tao: > hibmc can only be used in ARM64 architectures, and mmu defaults to y > in arch/arm64/Kconfig, so there is no need to add a dependency on mmu > in hibmc's kconfig. > > Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann > --- >

Re: [PATCH] drm/bridge: tc358767: fix EDID memory leak

2020-08-27 Thread Tomi Valkeinen
On 27/08/2020 02:23, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Aug 26, 2020 at 04:40:17PM +0300, Tomi Valkeinen wrote: >> The current EDID allocated with drm_get_edid() is freed when the driver >> gets a new EDID, but it is not freed when the driver is removed,

Re: [PATCH v1 1/4] drm/ast: Only set format registers if primary plane's format changes

2020-08-27 Thread Thomas Zimmermann
Hi Am 26.08.20 um 15:54 schrieb Sasha Levin: > Hi > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag > fixing commit: 4961eb60f145 ("drm/ast: Enable atomic modesetting"). > > The bot has tested the following trees: v5.8.2, v5.7.16. > >

[PULL] drm-intel-fixes

2020-08-27 Thread Jani Nikula
Hi Dave & Daniel, just one fix for -rc3. BR, Jani. The following changes since commit d012a7190fc1fd72ed48911e77ca97ba4521bccd: Linux 5.9-rc2 (2020-08-23 14:08:43 -0700) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-intel tags/drm-intel-fixes-2020-08-27

Re: [PATCH 0/4] drm/panel: s6e63m0: Add DSI transport

2020-08-27 Thread Linus Walleij
On Tue, Aug 18, 2020 at 7:10 PM Sam Ravnborg wrote: > How does this patchset relate to the patchset posted by Paul? > https://lore.kernel.org/dri-devel/20200727164613.19744-1-p...@crapouillou.net/ Not much. S6E63M0 uses "spi" as it is right now and is not using the existing DBI code. So it

Re: Aw: [PATCH v5 3/7] drm/mediatek: disable tmds on mt2701

2020-08-27 Thread Matthias Brugger
On 21/08/2020 09:17, Frank Wunderlich wrote: diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c index 5223498502c4..edadb7a700f1 100644 --- a/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c +++ b/drivers/gpu/drm/mediatek/mtk_hdmi_phy.c @@ -184,6 +184,9 @@

Printing bitfields in the kernel (Re: [PATCH] drm: Parse Colorimetry data block from EDID)

2020-08-27 Thread Pekka Paalanen
On Wed, 26 Aug 2020 22:23:28 +0800 Algea Cao wrote: > CEA 861.3 spec adds colorimetry data block for HDMI. > Parsing the block to get the colorimetry data from > panel. > > Signed-off-by: Algea Cao > --- > > drivers/gpu/drm/drm_edid.c | 45 + >

[PATCH 1/2] drm/mcde: Fix handling of platform_get_irq() error

2020-08-27 Thread Krzysztof Kozlowski
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/mcde/mcde_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH 2/2] drm/tve200: Fix handling of platform_get_irq() error

2020-08-27 Thread Krzysztof Kozlowski
platform_get_irq() returns -ERRNO on error. In such case comparison to 0 would pass the check. Fixes: 179c02fe90a4 ("drm/tve200: Add new driver for TVE200") Signed-off-by: Krzysztof Kozlowski --- drivers/gpu/drm/tve200/tve200_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] block: convert tasklets to use new tasklet_setup() API

2020-08-27 Thread Allen
On Wed, Aug 26, 2020 at 8:43 PM Kees Cook wrote: > > On Wed, Aug 26, 2020 at 12:55:28PM +0300, Dan Carpenter wrote: > > On Wed, Aug 26, 2020 at 07:21:35AM +0530, Allen Pais wrote: > > > On Thu, Aug 20, 2020 at 3:09 AM James Bottomley > > > wrote: > > > > > > > > On Wed, 2020-08-19 at 21:54

Re: [PATCH] drm/i915/lspcon: Limits to 8 bpc for RGB/YCbCr444

2020-08-27 Thread Kai Heng Feng
Hi Ville, > On Aug 27, 2020, at 12:24 AM, Ville Syrjälä > wrote: > > On Wed, Aug 26, 2020 at 01:21:15PM +0800, Kai-Heng Feng wrote: >> LSPCON only supports 8 bpc for RGB/YCbCr444. >> >> Set the correct bpp otherwise it renders blank screen. > > Hmm. Does >

[PATCH] drm/amd/display: Fix memleak in amdgpu_dm_mode_config_init

2020-08-27 Thread Dinghao Liu
When amdgpu_display_modeset_create_props() fails, state and state->context should be freed to prevent memleak. It's the same when amdgpu_dm_audio_init() fails. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 -- 1 file changed, 8 insertions(+), 2

Re: [PATCH V2 1/2] i2c: i2c-qcom-geni: Store DMA mapping data in geni_i2c_dev struct

2020-08-27 Thread Akash Asthana
Hi Roja, On 8/20/2020 4:05 PM, Roja Rani Yarubandi wrote: Store DMA mapping data in geni_i2c_dev struct to enhance DMA mapping data scope. For example during shutdown callback to unmap DMA mapping, this stored DMA mapping data can be used to call geni_se_tx_dma_unprep and geni_se_rx_dma_unprep

[PATCH 0/4] dyndbg: POC use dynamic_debug_exec_queries in DRM

2020-08-27 Thread Jim Cromie
This patchset tests/demonstrates using dynamic_debug_exec_queries() to alter 2 drivers' pr_debugs without a user directly using >control. For drm.core, I copied drm.debug module parameter model, adding drm.debug2 as a POC user interface to control 2 pr_debug additions to

Re: [PATCH] docs: fb: Correcting the location of FRAMEBUFFER_CONSOLE option.

2020-08-27 Thread Bilal Wasim
Hi All, On Mon, 24 Aug 2020 19:51:55 +0500 Bilal Wasim wrote: > fbcon doc mentions FRAMEBUFFER_CONSOLE option to be under > Device Drivers->Graphics Support->Frame buffer Devices-> > Console display driver support->Framebuffer Console Support, > while its under Device Drivers->Graphics

[PATCH] drm/ingenic: Fix driver not probing when IPU port is missing

2020-08-27 Thread Paul Cercueil
Even if support for the IPU was compiled in, we may run on a device (e.g. the Qi LB60) where the IPU is not available, or simply with an old devicetree without the IPU node. In that case the ingenic-drm refused to probe. Fix the driver so that it will probe even if the IPU node is not present in

[RESEND PATCH v2 0/2] Convert mtk-dpi to drm_bridge API

2020-08-27 Thread Enric Balletbo i Serra
The mtk-dpi driver still uses the drm_encoder API which is now somewhat deprecated. We started to move all the Mediatek drivers to the drm_bridge API, like we did for the mtk-dsi driver [1], this is another small step to be able to fully convert the DRM Mediatek drivers to the drm_bridge API. A

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-27 Thread Nicolas Dufresne
Le mardi 25 août 2020 à 13:30 +0200, Mauro Carvalho Chehab a écrit : > Em Tue, 25 Aug 2020 05:29:29 +1000 > Dave Airlie escreveu: > > > On Thu, 20 Aug 2020 at 20:02, Laurent Pinchart > > wrote: > > > Hi Mauro, > > > > > > On Thu, Aug 20, 2020 at 09:03:26AM +0200, Mauro Carvalho Chehab wrote:

Re: [PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors

2020-08-27 Thread Bilal Wasim
On Wed, 26 Aug 2020 10:15:22 +0200 Enric Balletbo i Serra wrote: > In an eDP application, HPD is not required and on most bridge chips > useless. If HPD is not used, we need to set initial status as > connected, otherwise the connector created by the > drm_bridge_connector API remains in an

Re: [PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-27 Thread Bilal Wasim
On Wed, 26 Aug 2020 10:15:26 +0200 Enric Balletbo i Serra wrote: > The get_edid() callback can be triggered anytime by an ioctl, i.e > > drm_mode_getconnector (ioctl) > -> drm_helper_probe_single_connector_modes >-> drm_bridge_connector_get_modes > ->

Re: [PATCH RFC v6 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-08-27 Thread Kevin Tang
Sam Ravnborg 于2020年7月29日周三 上午4:27写道: > > Hi Kevin > > On Tue, Jul 28, 2020 at 06:07:54PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > The Unisoc DRM master device is a virtual device needed to list all > > DPU devices or other display interface nodes that comprise the > > graphics

Re: [PATCH 0/8] Convert the intel iommu driver to the dma-iommu api

2020-08-27 Thread Tom Murphy
That would be great! On Wed., Aug. 26, 2020, 2:14 p.m. Robin Murphy, wrote: > Hi Tom, > > On 2019-12-21 15:03, Tom Murphy wrote: > > This patchset converts the intel iommu driver to the dma-iommu api. > > > > While converting the driver I exposed a bug in the intel i915 driver > which causes a

[PATCH] drm/dp: For MST hub, Get max_link_rate_lane from extended rx capability field if EXTENDED_RECEIVER_CAPABILITY_FILED_PRESENT is set.

2020-08-27 Thread Koba Ko
Currently, DRM get the capability of the mst hub only from DP_DPCD_REV and get the slower speed even the mst hub can run in the faster speed. As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1, read the DP_DP13_DPCD_REV to get the

[PATCH] drm: virtio: fix kconfig dependency warning

2020-08-27 Thread Randy Dunlap
From: Randy Dunlap Fix kconfig dependency warning by using a different Kconfig symbol. WARNING: unmet direct dependencies detected for VIRTIO_DMA_SHARED_BUFFER Depends on [n]: VIRTIO_MENU [=n] && DMA_SHARED_BUFFER [=y] Selected by [y]: - DRM_VIRTIO_GPU [=y] && HAS_IOMEM [=y] && DRM [=y]

[PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-27 Thread Enric Balletbo i Serra
Bridge drivers that implement the new model only shall return an error from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag is not set. So make sure we return an error because only the new drm_bridge model is supported. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo

[PATCH v2 2/5] drm/bridge: ps8640: Get the EDID from eDP control

2020-08-27 Thread Enric Balletbo i Serra
The PS8640 DSI-to-eDP bridge can retrieve the EDID, so implement the .get_edid callback and set the flag to indicate the core to use it. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Included the patch `drm/bridge: ps8640: Get

Re: [PATCH v2 3/5] drm/bridge: ps8640: Return an error for incorrect attach flags

2020-08-27 Thread Bilal Wasim
On Wed, 26 Aug 2020 10:15:24 +0200 Enric Balletbo i Serra wrote: > Bridge drivers that implement the new model only shall return an error > from their attach() handler when the DRM_BRIDGE_ATTACH_NO_CONNECTOR > flag is not set. So make sure we return an error because only the new > drm_bridge

[PATCH 4/4] i915: POC use dynamic_debug_exec_queries to control pr_debugs in gvt

2020-08-27 Thread Jim Cromie
The gvt component of this driver has ~120 pr_debugs, in 9 "classes". Add a "knob", like drm.debug, to map bits to these classes. bash-5.0# echo 0x01 > /sys/module/i915/parameters/debug_dyn set_dyndbg: result:0x1 from 0x01 dyndbg: query 0: "format='^gvt: cmd: ' +p" dyndbg: entry,

Re: Is: virtio_gpu_object_shmem_init issues? Was:Re: upstream boot error: general protection fault in swiotlb_map

2020-08-27 Thread Thomas Tai
Hello, I had a similiar panic when booting an ARM VM with kernel v5.9-rc1. git bisect identified following bad commit. After reverting the bad commit, the VM boot ok. Maybe we should look into the following commit. d323bb44e4d23802eb25d13de1f93f2335bd60d0 is the first bad commit commit

Re: [PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-27 Thread Bilal Wasim
On Wed, 26 Aug 2020 10:15:25 +0200 Enric Balletbo i Serra wrote: > Print an error message inside ps8640_bridge_vdo_control() function > when it fails so we can simplify a bit the callers, they will only > need to check the error code. > > Reviewed-by: Sam Ravnborg > Signed-off-by: Enric

Re: [PATCH v4 0/7] Convert mtk-dsi to drm_bridge API and get EDID for ps8640 bridge

2020-08-27 Thread Enric Balletbo i Serra
Hi Bilal, On 24/8/20 21:01, Bilal Wasim wrote: > Hi Chun-Kuan, Enric, > > Is there any plan to merge the following commits in this series to the > mainline? > > drm/bridge: ps8640: Get the EDID from eDP control > drm/bridge_connector: Set default status connected for eDP connectors >

[PATCH] drm: Parse Colorimetry data block from EDID

2020-08-27 Thread Algea Cao
CEA 861.3 spec adds colorimetry data block for HDMI. Parsing the block to get the colorimetry data from panel. Signed-off-by: Algea Cao --- drivers/gpu/drm/drm_edid.c | 45 + include/drm/drm_connector.h | 3 +++ include/drm/drm_edid.h | 14

[PATCH] coccinelle: api: fix kobj_to_dev.cocci warnings

2020-08-27 Thread Julia Lawall
From: kernel test robot Use kobj_to_dev() instead of container_of() Generated by: scripts/coccinelle/api/kobj_to_dev.cocci Fixes: a2fc3718bc22 ("coccinelle: api: add kobj_to_dev.cocci script") CC: Denis Efremov Signed-off-by: kernel test robot Signed-off-by: Julia Lawall --- tree:

Re: [PATCH v5 0/7] make hdmi work on bananapi-r2

2020-08-27 Thread Frank Wunderlich
Just a gentle ping...any opinions? regards Frank ___ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH v2 0/5] drm/bridge: ps8640: Make sure all needed is powered to get the EDID

2020-08-27 Thread Enric Balletbo i Serra
The first patch was initially part of the series [1] but for some reason was not picked when the series were merged, so I included in this series because it is needed to make the others to work properly. The same happened for the second patch, was part of series [1] but not merged. The third

[PATCH 3/4] i915: add -DDYNAMIC_DEBUG_MODULE to i915/gvt/Makefile

2020-08-27 Thread Jim Cromie
This addition to cflags enables dyndbg in the gvt component of the i915 module, on a CONFIG_DYNAMIC_DEBUG_CORE build. So here are the message classifications that the gvt driver uses. cut -d= -f2 | cut -d\ -f2,3 | \ perl -ne 'chomp $_ && $h{$_}++; END{print "$_\" \tseen $h{$_}\n" for sort

[PATCH v2 4/5] drm/bridge: ps8640: Print an error if VDO control fails

2020-08-27 Thread Enric Balletbo i Serra
Print an error message inside ps8640_bridge_vdo_control() function when it fails so we can simplify a bit the callers, they will only need to check the error code. Reviewed-by: Sam Ravnborg Signed-off-by: Enric Balletbo i Serra --- Changes in v2: None drivers/gpu/drm/bridge/parade-ps8640.c |

[RESEND PATCH v2 2/2] drm/mediatek: mtk_dpi: Convert to bridge driver

2020-08-27 Thread Enric Balletbo i Serra
Convert mtk_dpi to a bridge driver with built-in encoder support for compatibility with existing component drivers. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra --- Changes in v2: - Maintain error message when attach to bridge fails. (Boris)

[PATCH v2 5/5] drm/bridge: ps8640: Rework power state handling

2020-08-27 Thread Enric Balletbo i Serra
The get_edid() callback can be triggered anytime by an ioctl, i.e drm_mode_getconnector (ioctl) -> drm_helper_probe_single_connector_modes -> drm_bridge_connector_get_modes -> ps8640_bridge_get_edid Actually if the bridge pre_enable() function was not called before

[PATCH 2/4] drm-printk: call pr_debug() from drm_dev_dbg, __drm_dbg

2020-08-27 Thread Jim Cromie
Put the pr_debug() after the vaf setup work, so as to use it. And move the if-category-disabled-return after both, so the pr_debug() runs unconditionally. This lets both debug-printers execute independently, according to their respective controls, allowing later comparison to each other. #>

[PATCH 1/4] drm-printk: POC caller of dynamic-debug-exec-queries

2020-08-27 Thread Jim Cromie
Export of dynamic-debug-exec-queries exists for users like drm. This commit is a 1st user-test; it adds a 2nd knob, __drm_debug2, similar in function to __drm_debug. module_param_cb wires it to a callback which maps the input value to one of: "module=drm* +/-p". The include is needed to see the

[RESEND PATCH v2 1/2] drm/mediatek: mtk_dpi: Rename bridge to next_bridge

2020-08-27 Thread Enric Balletbo i Serra
This is really a cosmetic change just to make a bit more readable the code after convert the driver to drm_bridge. The bridge variable name will be used by the encoder drm_bridge, and the chained bridge will be named next_bridge. Reviewed-by: Chun-Kuang Hu Signed-off-by: Enric Balletbo i Serra

Re: [PATCH 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings

2020-08-27 Thread mkrishn
On 2020-08-25 04:27, Rob Herring wrote: On Mon, Aug 10, 2020 at 07:08:02PM +0530, Krishna Manikandan wrote: MSM Mobile Display Subsytem (MDSS) encapsulates sub-blocks like DPU display controller, DSI etc. Add YAML schema for the device tree bindings for the same. Signed-off-by: Krishna

RE: [PATCH v6 2/3] drm: bridge: Add support for Cadence MHDP DPI/DP bridge

2020-08-27 Thread Yuti Suresh Amonkar
Hi Laurent, > -Original Message- > From: Laurent Pinchart > Sent: Tuesday, August 11, 2020 5:30 > To: Yuti Suresh Amonkar > Cc: linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; > devicet...@vger.kernel.org; robh...@kernel.org; max...@cerno.tech; > airl...@linux.ie;

[PATCH v2 1/5] drm/bridge_connector: Set default status connected for eDP connectors

2020-08-27 Thread Enric Balletbo i Serra
In an eDP application, HPD is not required and on most bridge chips useless. If HPD is not used, we need to set initial status as connected, otherwise the connector created by the drm_bridge_connector API remains in an unknown state. Reviewed-by: Laurent Pinchart Acked-by: Sam Ravnborg

[PATCH] drm/hisilicon: Removed the dependency on the mmu

2020-08-27 Thread Tian Tao
hibmc can only be used in ARM64 architectures, and mmu defaults to y in arch/arm64/Kconfig, so there is no need to add a dependency on mmu in hibmc's kconfig. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH V2 2/2] i2c: i2c-qcom-geni: Add shutdown callback for i2c

2020-08-27 Thread Akash Asthana
Hi Roja, On 8/20/2020 4:05 PM, Roja Rani Yarubandi wrote: If the hardware is still accessing memory after SMMU translation is disabled (as part of smmu shutdown callback), then the IOVAs (I/O virtual address) which it was using will go on the bus as the physical addresses which will result in