Re: [PATCH v3 2/7] drm/vc4: kms: Remove useless define

2020-11-18 Thread Thomas Zimmermann
Am 05.11.20 um 14:56 schrieb Maxime Ripard: NUM_OUTPUTS isn't used anymore, let's remove it. Reviewed-by: Hoegeun Kwon Tested-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/vc4/vc4_kms.c | 1 - 1 file changed, 1 deletion(-) diff

Re: [PATCH] drm/vram: fix incorrect flag variable usage.

2020-11-18 Thread Christian König
Am 19.11.20 um 02:14 schrieb Dave Airlie: From: Dave Airlie In 7053e0eab473119503f6565b4e398f9a73122481 drm/vram-helper: stop using TTM placement flags it appears the flags got mixed up. This should fix a regression on ast [ 64.782340] WARNING: CPU: 51 PID: 1964 at

RE: [PATCH v2 05/13] drm/dp_helper: Add support for link failure detection

2020-11-18 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 05/13]

Re: [PATCH] drm/vram: fix incorrect flag variable usage.

2020-11-18 Thread Thomas Zimmermann
Hi we already have b8f8dbf64958 ("drm/vram-helper: Fix use of top-down placement") in drm-tip. And it does exactly the same. I guess it went in through drm-misc-next instead of -misc-fixes. Am 19.11.20 um 02:14 schrieb Dave Airlie: From: Dave Airlie In

RE: [PATCH v2 04/13] drm/dp_helper: Add Helpers for FRL Link Training support for DP-HDMI2.1 PCON

2020-11-18 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 04/13]

Re: [PATCH 1/3] drm/ttm: rework ttm_tt page limit

2020-11-18 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on next-20201117] [cannot apply to linus/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH] drm/vram: fix incorrect flag variable usage.

2020-11-18 Thread kernel test robot
Hi Dave, I love your patch! Yet something to improve: [auto build test ERROR on tegra-drm/drm/tegra/for-next] [also build test ERROR on linus/master v5.10-rc4] [cannot apply to drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-tip/drm-tip drm/drm-next next-20201118] [If your patch

Re: [PATCH 2/3] drm/ttm: move memory accounting into vmwgfx

2020-11-18 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on next-20201117] [cannot apply to linus/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

RE: [PATCH v2 03/13] drm/edid: Parse DSC1.2 cap fields from HFVSDB block

2020-11-18 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 03/13]

RE: [PATCH v2 02/13] drm/edid: Parse MAX_FRL field from HFVSDB block

2020-11-18 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 02/13]

RE: [PATCH v2 01/13] drm/edid: Add additional HFVSDB fields for HDMI2.1

2020-11-18 Thread Shankar, Uma
> -Original Message- > From: Nautiyal, Ankit K > Sent: Sunday, November 1, 2020 3:37 PM > To: intel-...@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org; Shankar, Uma ; > Kulkarni, Vandita ; ville.syrj...@linux.intel.com; > Sharma, Swati2 > Subject: [PATCH v2 01/13]

[PATCH] drm/amd/display: change license of color_table.c

2020-11-18 Thread Jonathan Gray
Change the license of color_table.c to match color_table.h granting permission to modify and distribute. Signed-off-by: Jonathan Gray --- .../amd/display/modules/color/color_table.c | 26 +++ 1 file changed, 21 insertions(+), 5 deletions(-) diff --git

[PATCH] drm/komeda: Correct the sequence of hw_done() and flip_done()

2020-11-18 Thread James Qian Wang
From: "James Qian Wang (Arm Technology China)" Komeda HW has no special, program the update to HW is done first, then flip happens. So correct the sequence to hw_done() first then flip_done(). Reported-by: Daniel Vetter Signed-off-by: James Qian Wang ---

Re: Linux 5.10-rc4

2020-11-18 Thread Dave Airlie
On Thu, 19 Nov 2020 at 08:25, Dave Airlie wrote: > > On Thu, 19 Nov 2020 at 08:15, Daniel Vetter wrote: > > > > On Wed, Nov 18, 2020 at 11:01 PM David Laight > > wrote: > > > > > > From: Thomas Zimmermann > > > > Sent: 18 November 2020 19:37 > > > > > > > > Hi > > > > > > > > Am 18.11.20 um

[PATCH] drm/vram: fix incorrect flag variable usage.

2020-11-18 Thread Dave Airlie
From: Dave Airlie In 7053e0eab473119503f6565b4e398f9a73122481 drm/vram-helper: stop using TTM placement flags it appears the flags got mixed up. This should fix a regression on ast [ 64.782340] WARNING: CPU: 51 PID: 1964 at drivers/gpu/drm/drm_gem_vram_helper.c:284

[PATCH 4/5] drm/virtio: use fence_id when processing fences

2020-11-18 Thread Gurchetan Singh
Currently, the fence ID, which can be used to identify a virtgpu fence, is the same as the fence sequence number. Let's use the fence_id name to clearly signal this. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +- drivers/gpu/drm/virtio/virtgpu_fence.c | 6

[PATCH 5/5] drm/virtio: rename sync_seq and last_seq

2020-11-18 Thread Gurchetan Singh
To be clearer about our intentions to associate sequence numbers and fence IDs, let's rename these variables. Signed-off-by: Gurchetan Singh --- drivers/gpu/drm/virtio/virtgpu_debugfs.c | 4 ++-- drivers/gpu/drm/virtio/virtgpu_drv.h | 4 ++-- drivers/gpu/drm/virtio/virtgpu_fence.c | 9

[PATCH 3/5] virtio-gpu api: Add a comment on VIRTIO_GPU_SHM_ID_HOST_VISIBLE

2020-11-18 Thread Gurchetan Singh
From: Anthoine Bourgeois This provides a description of how the kernel driver uses the shmid to determine capabilities. Signed-off-by: Anthoine Bourgeois --- include/uapi/linux/virtio_gpu.h | 4 1 file changed, 4 insertions(+) diff --git a/include/uapi/linux/virtio_gpu.h

[PATCH 1/5] drm/virtio: suffix create blob call with _ioctl like any ioctl

2020-11-18 Thread Gurchetan Singh
From: Anthoine Bourgeois For coherency, all ioctls are suffixed Signed-off-by: Anthoine Bourgeois --- drivers/gpu/drm/virtio/virtgpu_ioctl.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c

[PATCH 2/5] drm/virtio: fix a file name comment reference

2020-11-18 Thread Gurchetan Singh
From: Anthoine Bourgeois Easier to find where declarations are implemented. Signed-off-by: Anthoine Bourgeois --- drivers/gpu/drm/virtio/virtgpu_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h

[Bug 210263] New: brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet"

2020-11-18 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=210263 Bug ID: 210263 Summary: brightness device returns ENXIO (?) on brightness restore at boot, with bootoption "quiet" Product: Drivers Version: 2.5 Kernel Version: 5.9.8

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-18 Thread Andrew Morton
On Wed, 18 Nov 2020 11:57:44 +0100 Christian König wrote: > Am 06.11.20 um 23:48 schrieb Andrew Morton: > > On Fri, 6 Nov 2020 12:48:05 +0100 "Christian König" > > wrote: > > > >> Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." > >> adds a workaround for a bug in mmap_region. > >> >

Re: Linux 5.10-rc4

2020-11-18 Thread Dave Airlie
On Thu, 19 Nov 2020 at 08:15, Daniel Vetter wrote: > > On Wed, Nov 18, 2020 at 11:01 PM David Laight wrote: > > > > From: Thomas Zimmermann > > > Sent: 18 November 2020 19:37 > > > > > > Hi > > > > > > Am 18.11.20 um 19:10 schrieb Linus Torvalds: > > > > On Wed, Nov 18, 2020 at 4:12 AM David

Re: Linux 5.10-rc4

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 11:01 PM David Laight wrote: > > From: Thomas Zimmermann > > Sent: 18 November 2020 19:37 > > > > Hi > > > > Am 18.11.20 um 19:10 schrieb Linus Torvalds: > > > On Wed, Nov 18, 2020 at 4:12 AM David Laight > > > wrote: > > >> > > >> I've got the 'splat' below during boot.

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 10:55:27AM -0500, Adam Jackson wrote: > On Tue, Nov 17, 2020 at 4:40 PM Daniel Vetter wrote: > > > > It's probably full of bugs ready for exploiting by userspace. And > > there's not going to be any userspace for this without any of the drm > > legacy drivers enabled too.

[pull] amdgpu drm-fixes-5.10

2020-11-18 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.10. The following changes since commit 8f598d15ee6577a56d6617d9e4151591db34d8fa: Merge branch 'linux-5.10' of git://github.com/skeggsb/linux into drm-fixes (2020-11-16 06:36:31 +1000) are available in the Git repository at:

Re: [PATCH] drm/via: fix assignment in if condition

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 03:40:19AM -0800, Bernard Zhao wrote: > Fix check_patch.pl warning: > ERROR: do not use assignment in if condition > + if ((HALCYON_HEADER2 == (cmd = *buf)) && > > ERROR: do not use assignment in if condition > + if

Re: [PATCH 1/4] drm/ttm/drivers: remove unecessary ttm_module.h include

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 01:49:51PM +0100, Christian König wrote: > Am 17.11.20 um 18:46 schrieb Daniel Vetter: > > On Tue, Nov 17, 2020 at 05:33:35PM +0100, Christian König wrote: > > > ttm_module.h deals with internals of TTM and should never > > > be include outside of it. > > > > > >

Re: [PATCH v3 01/11] dt-bindings: usb: convert usb-device.txt to YAML schema

2020-11-18 Thread Rob Herring
On Wed, 18 Nov 2020 16:21:16 +0800, Chunfeng Yun wrote: > Convert usb-device.txt to YAML schema usb-device.yaml > > Signed-off-by: Chunfeng Yun > --- > v3: > 1. remove $nodenmae and items key word for compatilbe; > 2. add additionalProperties; > > The followings are suggested by Rob: >

Re: [PATCH 1/9] dt-binding: soc: xilinx: ai-engine: Add AI engine binding

2020-11-18 Thread Rob Herring
On Wed, 18 Nov 2020 00:06:12 -0800, Wendy Liang wrote: > Xilinx AI engine array can be partitioned statically for different > applications. In the device tree, there will be device node for the AI > engine device, and device nodes for the statically configured AI engine > partitions. Each of the

Re: [PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 02:35:24PM +0100, Christian König wrote: > Am 17.11.20 um 18:19 schrieb Daniel Vetter: > > On Tue, Nov 17, 2020 at 03:06:15PM +0100, Christian König wrote: > > > Increase the ammount of system memory drivers can use to about 90% of > > > the total available. > > > > > >

Re: [PATCH 2/3] drm/ttm: move memory accounting into vmwgfx

2020-11-18 Thread kernel test robot
Hi "Christian, I love your patch! Yet something to improve: [auto build test ERROR on next-20201117] [cannot apply to linus/master v5.10-rc4 v5.10-rc3 v5.10-rc2 v5.10-rc4] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH RESEND 1/2] dma-fence: allow signaling drivers to set fence timestamp

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 9:28 PM wrote: > > On 2020-11-12 10:27, Veera Sundaram Sankaran wrote: > > Some drivers have hardware capability to get the precise timestamp of > > certain events based on which the fences are triggered. This allows it > > to set accurate timestamp factoring out any

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-18 Thread abhinavk
Hi Stephen On 2020-11-18 07:49, Rob Clark wrote: On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd wrote: Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > On 2020-11-17 09:26, Stephen Boyd wrote: > > I don't know what this debug print is for but it is super chatty, > > throwing 8 lines of

Re: Linux 5.10-rc4

2020-11-18 Thread Thomas Zimmermann
Hi Am 18.11.20 um 19:10 schrieb Linus Torvalds: On Wed, Nov 18, 2020 at 4:12 AM David Laight wrote: I've got the 'splat' below during boot. This is an 8-core C2758 Atom cpu using the on-board/cpu graphics. User space is Ubuntu 20.04. Additionally the X display has all the colours and

Re: Linux 5.10-rc4

2020-11-18 Thread Linus Torvalds
On Wed, Nov 18, 2020 at 4:12 AM David Laight wrote: > > I've got the 'splat' below during boot. > This is an 8-core C2758 Atom cpu using the on-board/cpu graphics. > User space is Ubuntu 20.04. > > Additionally the X display has all the colours and alignment slightly > messed up. > 5.9.0 was ok.

Re: [PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc

2020-11-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-18 16:36:01) > From: Tvrtko Ursulin > > There is this long standing nit of igt/tools/intel_error_decode asserting > when you feed it an error state from a GPU the local libdrm does not know > of. > > To fix this I need a tweak in drm_intel_decode_context_alloc to

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-18 Thread Rob Clark
On Tue, Nov 17, 2020 at 9:28 PM Viresh Kumar wrote: > > On 17-11-20, 09:02, Rob Clark wrote: > > With that on top of the previous patch, > > Don't you still have this ? Which fixed the lockdep in the remove path. > > https://lore.kernel.org/lkml/20201022080644.2ck4okrxygmkuatn@vireshk-i7/ > > To

[PATCH] intel: Do not assert on unknown chips in drm_intel_decode_context_alloc

2020-11-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is this long standing nit of igt/tools/intel_error_decode asserting when you feed it an error state from a GPU the local libdrm does not know of. To fix this I need a tweak in drm_intel_decode_context_alloc to make it not assert but just return NULL (which seems an

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-18 Thread Andrey Grodzovsky
On 11/18/20 7:01 AM, Christian König wrote: Am 18.11.20 um 08:39 schrieb Daniel Vetter: On Tue, Nov 17, 2020 at 9:07 PM Andrey Grodzovsky wrote: On 11/17/20 2:49 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: On 11/17/20 1:52 PM, Daniel Vetter

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Adam Jackson
On Tue, Nov 17, 2020 at 4:40 PM Daniel Vetter wrote: > > It's probably full of bugs ready for exploiting by userspace. And > there's not going to be any userspace for this without any of the drm > legacy drivers enabled too. So just couple it together. Not quite true. The only UMS driver using

Re: [Freedreno] [PATCH] drm/msm/dpu: Remove chatty vbif debug print

2020-11-18 Thread Rob Clark
On Tue, Nov 17, 2020 at 2:53 PM Stephen Boyd wrote: > > Quoting abhin...@codeaurora.org (2020-11-17 12:34:56) > > On 2020-11-17 09:26, Stephen Boyd wrote: > > > I don't know what this debug print is for but it is super chatty, > > > throwing 8 lines of debug prints in the logs every time we

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-18 Thread Luben Tuikov
On 2020-11-18 07:01, Christian König wrote: > Am 18.11.20 um 08:39 schrieb Daniel Vetter: >> On Tue, Nov 17, 2020 at 9:07 PM Andrey Grodzovsky >> wrote: >>> >>> On 11/17/20 2:49 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: > On 11/17/20 1:52

Re: [PATCH] drm: document drm_mode_get_connector

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 4:09 PM Simon Ser wrote: > > On Wednesday, November 18, 2020 4:03 PM, Daniel Vetter > wrote: > > > I think this causes warnings, because now we have kerneldoc for this, > > but not for all the members. Also the member-specific stuff should be > > documented as inline

Re: [PATCH] drm/vmwgfx: use min_t to replace min

2020-11-18 Thread kernel test robot
Hi Bernard, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.10-rc4 next-20201118] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH] drm: document drm_mode_get_connector

2020-11-18 Thread Simon Ser
On Wednesday, November 18, 2020 4:03 PM, Daniel Vetter wrote: > I think this causes warnings, because now we have kerneldoc for this, > but not for all the members. Also the member-specific stuff should be > documented as inline comment, see > >

Re: [PATCH] drm: document drm_mode_get_connector

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 11:52 AM Simon Ser wrote: > > Document how to perform a forced probe, and when should user-space do it. > > Signed-off-by: Simon Ser > Cc: Daniel Vetter > Cc: Pekka Paalanen > --- > include/uapi/drm/drm_mode.h | 13 + > 1 file changed, 13 insertions(+) > >

Re: [PATCH v2] drm/imx: depend on COMMON_CLK to fix compile tests

2020-11-18 Thread Philipp Zabel
Hi Krzysztof, On Tue, 2020-11-17 at 19:24 +0100, Krzysztof Kozlowski wrote: > The iMX DRM LVDS driver uses Common Clock Framework thus it cannot be > built on platforms without it (e.g. compile test on MIPS with RALINK and > SOC_RT305X): > > /usr/bin/mips-linux-gnu-ld:

Re: [PATCH 1/4] drm/ttm: add multihop infrastrucutre (v2)

2020-11-18 Thread Christian König
Am 10.11.20 um 18:11 schrieb Daniel Vetter: On Tue, Nov 10, 2020 at 4:48 PM Ville Syrjälä wrote: On Tue, Nov 10, 2020 at 03:24:32PM +1000, Dave Airlie wrote: On Tue, 10 Nov 2020 at 07:27, Ville Syrjälä wrote: On Mon, Nov 09, 2020 at 09:48:04PM +0100, Christian König wrote: Am 09.11.20 um

Re: [PATCH][next] drm/selftests/test-drm_dp_mst_helper: fix memory leak allocated to 'out'

2020-11-18 Thread Lee Jones
On Wed, 18 Nov 2020, Colin King wrote: > From: Colin Ian King > > Currently when txmsg fails to allocate then there is a leak on 'out'. Fix > this by setting result to false and exiting via the clean up exit path. > Note since txmsg is NULL at this point, the kfree of txmsg is a no-op. > >

[PATCH][next] drm/selftests/test-drm_dp_mst_helper: fix memory leak allocated to 'out'

2020-11-18 Thread Colin King
From: Colin Ian King Currently when txmsg fails to allocate then there is a leak on 'out'. Fix this by setting result to false and exiting via the clean up exit path. Note since txmsg is NULL at this point, the kfree of txmsg is a no-op. Addresses-Coverity: ("Resource leak") Fixes: 09234b88ef55

AW: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Jonas Mark (BT-FIR/ENG1-Grb)
Hi Thomas and Daniel, Thank you very much for your feedback. We appreciate it. > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > >>> index 9bf5ad6d18a2..2665040e11c7 100644 > >>> --- a/drivers/gpu/drm/imx/imx-drm-core.c > >>> +++

Re: [PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-18 Thread Christian König
Am 17.11.20 um 18:19 schrieb Daniel Vetter: On Tue, Nov 17, 2020 at 03:06:15PM +0100, Christian König wrote: Increase the ammount of system memory drivers can use to about 90% of the total available. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1

Re: [PATCH 1/3] drm/mipi-dbi: Add support for Type B

2020-11-18 Thread kernel test robot
Hi, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linux/master] [also build test WARNING on robh/for-next drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next linus/master v5.10-rc4 next-20201118] [cannot apply to drm/drm-next

Re: [PATCH 1/4] drm/ttm/drivers: remove unecessary ttm_module.h include

2020-11-18 Thread Christian König
Am 17.11.20 um 18:46 schrieb Daniel Vetter: On Tue, Nov 17, 2020 at 05:33:35PM +0100, Christian König wrote: ttm_module.h deals with internals of TTM and should never be include outside of it. Signed-off-by: Christian König Maybe also move it to drivers/gpu/drm/ttm/ttm_internal.h. We're

[PATCH] drm/i915/dsi: Use unconditional msleep for the panel_on_delay when there is no reset-deassert MIPI-sequence

2020-11-18 Thread Hans de Goede
Commit 25b4620ee822 ("drm/i915/dsi: Skip delays for v3 VBTs in vid-mode") added an intel_dsi_msleep() helper which skips sleeping if the MIPI-sequences have a version of 3 or newer and the panel is in vid-mode; and it moved a bunch of msleep-s over to this new helper. This was based on my reading

[PULL] drm-misc-next

2020-11-18 Thread Thomas Zimmermann
Hi Dave and Daniel, here's this week's PR for drm-misc-next. It's fairly large, but most of the patches fix kernel build warnings. The rest is the usual mixture of cleanups and small fixes. The panel code gained support for new devices. Best regards Thomas drm-misc-next-2020-11-18:

Re: [PATCH 3/3] drm/ttm: make up to 90% of system memory available

2020-11-18 Thread Christian König
Am 17.11.20 um 17:38 schrieb Michel Dänzer: On 2020-11-17 3:06 p.m., Christian König wrote: Increase the ammount of system memory drivers can use to about 90% of the total available. Signed-off-by: Christian König ---   drivers/gpu/drm/ttm/ttm_bo.c | 2 +-   1 file changed, 1 insertion(+), 1

[PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-18 Thread Dexuan Cui
x86 Hyper-V used to essentially always overwrite the effective cache type of guest memory accesses to WB. This was problematic in cases where there is a physical device assigned to the VM, since that often requires that the VM should have control over cache types. Thus, on newer Hyper-V since

RE: [PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-18 Thread Michael Kelley
From: Dexuan Cui Sent: Tuesday, November 17, 2020 4:03 PM > > x86 Hyper-V used to essentially always overwrite the effective cache type > of guest memory accesses to WB. This was problematic in cases where there > is a physical device assigned to the VM, since that often requires that > the VM

Re: [PATCH v2 8/8] drm/amdgpu: Prevent any job recoveries after device is unplugged.

2020-11-18 Thread Christian König
Am 18.11.20 um 08:39 schrieb Daniel Vetter: On Tue, Nov 17, 2020 at 9:07 PM Andrey Grodzovsky wrote: On 11/17/20 2:49 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 02:18:49PM -0500, Andrey Grodzovsky wrote: On 11/17/20 1:52 PM, Daniel Vetter wrote: On Tue, Nov 17, 2020 at 01:38:14PM

Re: [PATCH 1/2] mm: mmap: fix fput in error path v2

2020-11-18 Thread Christian König
Am 06.11.20 um 23:48 schrieb Andrew Morton: On Fri, 6 Nov 2020 12:48:05 +0100 "Christian König" wrote: Patch "495c10cc1c0c CHROMIUM: dma-buf: restore args..." adds a workaround for a bug in mmap_region. As the comment states ->mmap() callback can change vma->vm_file and so we might call

[PATCH] drm: document drm_mode_get_connector

2020-11-18 Thread Simon Ser
Document how to perform a forced probe, and when should user-space do it. Signed-off-by: Simon Ser Cc: Daniel Vetter Cc: Pekka Paalanen --- include/uapi/drm/drm_mode.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Christian König
Am 18.11.20 um 10:02 schrieb Thomas Zimmermann: Hi Am 18.11.20 um 09:53 schrieb Daniel Vetter: On Wed, Nov 18, 2020 at 9:24 AM Christian König wrote: Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: Hi Am 17.11.20 um 22:40 schrieb Daniel Vetter: It's probably full of bugs ready for

Re: [PATCH] drm/docs: Fix todo.rst

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 08:04:46AM +, Simon Ser wrote: > On Wednesday, November 18, 2020 8:36 AM, Daniel Vetter > wrote: > > > I didnt' format the thing correctly :-( > > > > Fixes: 39aead8373b3 ("fbcon: Disable accelerated scrolling") > > Reported-by: Stephen Rothwell s...@canb.auug.org.au

Re: [PATCH 04/40] drm/amd/amdgpu/amdgpu_drv: Move 'amdgpu_info_ioctl()'s prototype to shared header

2020-11-18 Thread Lee Jones
On Fri, 13 Nov 2020, Alex Deucher wrote: > On Fri, Nov 13, 2020 at 8:49 AM Lee Jones wrote: > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c:486:5: warning: no previous > > prototype for ‘amdgpu_info_ioctl’ [-Wmissing-prototypes] > > 486

Re: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 10:47 AM Jonas Mark (BT-FIR/ENG1-Grb) wrote: > > Hi Thomas and Daniel, > > Thank you very much for your feedback. We appreciate it. > > > >>> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c > > >>> b/drivers/gpu/drm/imx/imx-drm-core.c > > >>> index

Re: [PATCH] video: hyperv_fb: Fix the cache type when mapping the VRAM

2020-11-18 Thread Wei Liu
On Wed, Nov 18, 2020 at 12:20:11AM +, Michael Kelley wrote: > From: Dexuan Cui Sent: Tuesday, November 17, 2020 4:03 > PM > > > > x86 Hyper-V used to essentially always overwrite the effective cache type > > of guest memory accesses to WB. This was problematic in cases where there > > is a

Re: [PATCH] fbcon: Disable accelerated scrolling

2020-11-18 Thread Geert Uytterhoeven
Hi Daniel, Replying "early" (see below), as this was applied to drm-misc/for-linux-next. On Sat, Oct 31, 2020 at 3:17 PM Daniel Vetter wrote: > On Sat, Oct 31, 2020 at 11:28 AM Geert Uytterhoeven > wrote: > > On Thu, 29 Oct 2020, Daniel Vetter wrote: > > > So ever since syzbot discovered

Re: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Thomas Zimmermann
Hi Am 18.11.20 um 09:59 schrieb Daniel Vetter: On Wed, Nov 18, 2020 at 9:10 AM Thomas Zimmermann wrote: Hi Am 17.11.20 um 16:52 schrieb Mark Jonas: From: Leo Ruan The generic fbdev has to be setup before enabling output polling. Otherwise the fbdev client is not ready to handle delayed

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Thomas Zimmermann
Hi Am 18.11.20 um 09:53 schrieb Daniel Vetter: On Wed, Nov 18, 2020 at 9:24 AM Christian König wrote: Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: Hi Am 17.11.20 um 22:40 schrieb Daniel Vetter: It's probably full of bugs ready for exploiting by userspace. And there's not going to be

Re: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 9:10 AM Thomas Zimmermann wrote: > > Hi > > Am 17.11.20 um 16:52 schrieb Mark Jonas: > > From: Leo Ruan > > > > The generic fbdev has to be setup before enabling output polling. > > Otherwise the fbdev client is not ready to handle delayed events. > > > > Since f53705fd,

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Daniel Vetter
On Wed, Nov 18, 2020 at 9:24 AM Christian König wrote: > > Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: > > Hi > > > > Am 17.11.20 um 22:40 schrieb Daniel Vetter: > >> It's probably full of bugs ready for exploiting by userspace. And > >> there's not going to be any userspace for this without

Re: [PATCH 42/42] include/drm/drm_atomic: Make use of 'new_crtc_state'

2020-11-18 Thread Lee Jones
On Tue, 17 Nov 2020, Daniel Vetter wrote: > On Mon, Nov 16, 2020 at 05:41:12PM +, Lee Jones wrote: > > In the macro for_each_oldnew_crtc_in_state() 'crtc_state' is provided > > as a container for state->crtcs[i].new_state, but is not utilised in > > some use-cases, so we fake-use it instead.

Re: [PATCH v1 5/6] dt-bindings: vendor-prefixes: Add ys vendor prefix

2020-11-18 Thread Guido Günther
Hi, On Tue, Nov 17, 2020 at 09:42:33PM +0100, Linus Walleij wrote: > On Tue, Nov 17, 2020 at 6:49 PM Guido Günther wrote: > > > Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd. > > > > Signed-off-by: Guido Günther > > --- > >

[PATCH v2 6/6] dt-binding: display: mantix: Add compatible for panel from YS

2020-11-18 Thread Guido Günther
This panel from Shenzhen Yashi Changhua Intelligent Technology Co uses the same driver IC but a different LCD. Signed-off-by: Guido Günther Reviewed-by: Linus Walleij --- .../devicetree/bindings/display/panel/mantix,mlaf057we51-x.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 5/6] dt-bindings: vendor-prefixes: Add ys vendor prefix

2020-11-18 Thread Guido Günther
Add prefix for Shenzhen Yashi Changhua Intelligent Technology Co., Ltd. Signed-off-by: Guido Günther --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

[PATCH v2 2/6] drm/panel: mantix: Tweak init sequence

2020-11-18 Thread Guido Günther
We've seen some (non permanent) burn in and bad white balance on some of the panels. Adding this bit from a vendor supplied sequence fixes it. Fixes: 72967d5616d3 ("drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel") Signed-off-by: Guido Günther Reviewed-by: Linus Walleij ---

[PATCH v2 1/6] drm/panel: st7703: Use dev_err_probe

2020-11-18 Thread Guido Günther
Less code and easier probe deferral debugging. Signed-off-by: Guido Günther Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-sitronix-st7703.c | 24 +++ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7703.c

[PATCH v2 4/6] drm/panel: mantix: Support panel from Shenzhen Yashi Changhua Intelligent Technology Co

2020-11-18 Thread Guido Günther
The panel uses the same driver IC and has the same resolution but a slightly different default mode. It seems it can work with the same init sequence. Signed-off-by: Guido Günther Reviewed-by: Linus Walleij --- drivers/gpu/drm/panel/panel-mantix-mlaf057we51.c | 16 1 file

[PATCH v2 3/6] drm/panel: mantix: Allow to specify default mode for different panels

2020-11-18 Thread Guido Günther
This can be used to use different modes for differnt panels via OF device match. Signed-off-by: Guido Günther Reviewed-by: Linus Walleij --- .../gpu/drm/panel/panel-mantix-mlaf057we51.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git

[PATCH v2 0/6] drm/panel: mantix and st7703 fixes and additions

2020-11-18 Thread Guido Günther
This adds new panel type to the mantix driver as found on the Librem 5 and fixes a glitch in the init sequence (affecting both panels). The fix is at the start of the series to make backporting simpler. It also adds a patch to make st7703 use dev_err_probe(). changes from v1 - as per review

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Christian König
Am 18.11.20 um 09:02 schrieb Thomas Zimmermann: Hi Am 17.11.20 um 22:40 schrieb Daniel Vetter: It's probably full of bugs ready for exploiting by userspace. And there's not going to be any userspace for this without any of the drm legacy drivers enabled too. So just couple it together.

Re: [PATCH] amd/amdgpu: optimise CONFIG_X||CONFIG_X_MODULE to IS_ENABLED(X)

2020-11-18 Thread Christian König
Am 18.11.20 um 04:43 schrieb Bernard Zhao: Optimise CONFIG_ || CONFIG__MODULE to IS_ENABLED(). This change also fix check_patch.pl warning: WARNING: Prefer IS_ENABLED() to CONFIG_ || CONFIG__MODULE +#if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) || defined (CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)

Re: [PATCH] amd/amdgpu: use kmalloc_array to replace kmalloc with multiply

2020-11-18 Thread Christian König
Am 18.11.20 um 03:55 schrieb Bernard Zhao: Fix check_patch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply +bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL); WARNING: Prefer kmalloc_array over kmalloc with multiply +bps_bo = kmalloc(align_space *

Re: [PATCH] amdgpu/amdgpu_ids: fix kmalloc_array not uses number as first arg

2020-11-18 Thread Christian König
Am 18.11.20 um 03:42 schrieb Bernard Zhao: Fix check_patch.pl warning: kmalloc_array uses number as first arg, sizeof is generally wrong. +fences = kmalloc_array(sizeof(void *), id_mgr->num_ids, GFP_KERNEL); Signed-off-by: Bernard Zhao Reviewed-by: Christian König ---

Re: [PATCH] drm: imx: Move fbdev setup to before output polling

2020-11-18 Thread Thomas Zimmermann
Hi Am 17.11.20 um 16:52 schrieb Mark Jonas: > From: Leo Ruan > > The generic fbdev has to be setup before enabling output polling. > Otherwise the fbdev client is not ready to handle delayed events. > > Since f53705fd, the generic fbdev is setup after the output polling > init. During fbdev

Re: [PATCH] drm/docs: Fix todo.rst

2020-11-18 Thread Simon Ser
On Wednesday, November 18, 2020 8:36 AM, Daniel Vetter wrote: > I didnt' format the thing correctly :-( > > Fixes: 39aead8373b3 ("fbcon: Disable accelerated scrolling") > Reported-by: Stephen Rothwell s...@canb.auug.org.au > Cc: Stephen Rothwell s...@canb.auug.org.au > Signed-off-by: Daniel

Re: [PATCH v9 07/17] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree

2020-11-18 Thread Viresh Kumar
On 17-11-20, 17:17, Dmitry Osipenko wrote: > 17.11.2020 13:07, Viresh Kumar пишет: > > On 16-11-20, 00:29, Dmitry Osipenko wrote: > >> This patch moves ACTMON driver away from generating OPP table by itself, > >> transitioning it to use the table which comes from device-tree. This > >> change

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-18 Thread Viresh Kumar
On 17-11-20, 09:02, Rob Clark wrote: > With that on top of the previous patch, Don't you still have this ? Which fixed the lockdep in the remove path. https://lore.kernel.org/lkml/20201022080644.2ck4okrxygmkuatn@vireshk-i7/ To make it clear you need these patches to fix the OPP stuff: //From

Re: [PATCH] char/agp: Disable frontend without CONFIG_DRM_LEGACY

2020-11-18 Thread Thomas Zimmermann
Hi Am 17.11.20 um 22:40 schrieb Daniel Vetter: > It's probably full of bugs ready for exploiting by userspace. And > there's not going to be any userspace for this without any of the drm > legacy drivers enabled too. So just couple it together. > > Signed-off-by: Daniel Vetter > Cc: David

[PATCH v4 5/7] ARM: dts: rockchip: rk3066a: add #sound-dai-cells to hdmi node

2020-11-18 Thread Johan Jonker
'#sound-dai-cells' is required to properly interpret the list of DAI specified in the 'sound-dai' property, so add them to the 'hdmi' node for 'rk3066a.dtsi'. Signed-off-by: Johan Jonker --- arch/arm/boot/dts/rk3066a.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCHv8 4/8] drm/msm: rearrange the gpu_rmw() function

2020-11-18 Thread Sai Prakash Ranjan
From: Sharat Masetty The register read-modify-write construct is generic enough that it can be used by other subsystems as needed, create a more generic rmw() function and have the gpu_rmw() use this new function. Signed-off-by: Sharat Masetty Reviewed-by: Jordan Crouse Signed-off-by: Sai

Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-11-18 Thread Viresh Kumar
On Fri, 6 Nov 2020 at 12:46, Viresh Kumar wrote: > > On 05-11-20, 11:24, Rob Clark wrote: > > On Tue, Nov 3, 2020 at 7:04 PM Viresh Kumar wrote: > > > > > > On 03-11-20, 08:50, Rob Clark wrote: > > > > sorry, it didn't apply cleanly (which I guess is due to some other > > > > dependencies that

[PATCH v4 2/7] clk: rockchip: fix i2s gate bits on rk3066 and rk3188

2020-11-18 Thread Johan Jonker
The Rockchip PX2/RK3066 uses these bits in CRU_CLKGATE7_CON: hclk_i2s_8ch_gate_en bit 4 (dtsi: i2s0) hclk_i2s0_2ch_gate_en bit 2 (dtsi: i2s1) hclk_i2s1_2ch_gate_en bit 3 (dtsi: i2s2) The Rockchip PX3/RK3188 uses this bit in CRU_CLKGATE7_CON: hclk_i2s_2ch_gate_en bit 2 (dtsi: i2s0) The bits

[PATCH v2] drm/msm/dp: fix connect/disconnect handled at irq_hpd

2020-11-18 Thread Kuogee Hsieh
Some usb type-c dongle use irq_hpd request to perform device connection and disconnection. This patch add handling of both connection and disconnection are based on the state of hpd_state and sink_count. Changes in V2: -- add dp_display_handle_port_ststus_changed() -- fix kernel test robot

[PATCH v4 4/7] drm: rockchip: add sound support to rk3066 hdmi driver

2020-11-18 Thread Johan Jonker
From: Zheng Yang Add sound support to the rk3066 HDMI driver. The I2S input of the HDMI TX allows transmission of DVD-Audio and decoded Dolby Digital to A/V Receivers and high-end displays. The interface supports 2 to 8 channels audio up to 192 kHz. The HDMI TX supports variable word length of

[PATCHv8 2/8] iommu/arm-smmu: Add domain attribute for pagetable configuration

2020-11-18 Thread Sai Prakash Ranjan
Add iommu domain attribute for pagetable configuration which initially will be used to set quirks like for system cache aka last level cache to be used by client drivers like GPU to set right attributes for caching the hardware pagetables into the system cache and later can be extended to include

[PATCHv8 8/8] iommu: arm-smmu-impl: Add a space before open parenthesis

2020-11-18 Thread Sai Prakash Ranjan
Fix the checkpatch warning for space required before the open parenthesis. Signed-off-by: Sai Prakash Ranjan Acked-by: Will Deacon --- drivers/iommu/arm/arm-smmu/arm-smmu-impl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-impl.c

Re: [PATCH v9 01/17] memory: tegra30: Support interconnect framework

2020-11-18 Thread Dmitry Osipenko
17.11.2020 23:24, Georgi Djakov пишет: > Hi Dmitry, > > Thank you working on this! > > On 15.11.20 23:29, Dmitry Osipenko wrote: >> Now Internal and External memory controllers are memory interconnection >> providers. This allows us to use interconnect API for tuning of memory >> configuration.

  1   2   >