Re: [PATCH] drm/ttm: Remove pinned bos from LRU in ttm_bo_move_to_lru_tail()

2021-01-04 Thread Christian König
Am 05.01.21 um 00:13 schrieb Lyude Paul: Recently a regression was introduced which caused TTM's buffer eviction to attempt to evict already-pinned BOs, causing issues with buffer eviction under memory pressure along with suspend/resume: nouveau :1f:00.0: DRM: evicting buffers...

Re: [Linaro-mm-sig] [PATCH] dmabuf: fix use-after-free of dmabuf's file->f_inode

2021-01-04 Thread Sumit Semwal
Hi Charan, On Mon, 4 Jan 2021 at 17:22, Christian König wrote: > > Am 04.01.21 um 12:36 schrieb Charan Teja Reddy: > > It is observed 'use-after-free' on the dmabuf's file->f_inode with the > > race between closing the dmabuf file and reading the dmabuf's debug > > info. > > > > Consider the

Re: [PATCH v3 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-04 Thread Laurent Pinchart
On Tue, Jan 05, 2021 at 08:08:13AM +0200, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the IP

[PATCH v3 6/6] dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt

2021-01-04 Thread Laurent Pinchart
dw_hdmi.txt has been replaced with synopsys,dw-hdmi.yaml, and all references to the old file have been converted. Remove it. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring --- .../bindings/display/bridge/dw_hdmi.txt | 33 --- 1 file changed, 33 deletions(-) delete

[PATCH v3 4/6] dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML

2021-01-04 Thread Laurent Pinchart
Convert the Rockchip HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v2: - Use Mark's @gmail.com e-mail address as the @rock-chips.com address bounces Changes since v1: - Drop pinctrl-0 and pinctrl-1 - Use unevaluatedProperties instead of additionalProperties

[PATCH v3 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-04 Thread Laurent Pinchart
Convert the i.MX6 HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v1: - Only specify maxItems for clocks - Drop reg and interrupts as they're checked in the base schema - Rebase on top of OF graph schema, dropped redundant properties - Fix identation for enum

[PATCH v3 5/6] dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML schema

2021-01-04 Thread Laurent Pinchart
Replace the reference to the DWC HDMI text DT binding with a reference to the YAML equivalent. Signed-off-by: Laurent Pinchart Acked-by: Rob Herring Acked-by: Chen-Yu Tsai --- .../bindings/display/allwinner,sun8i-a83t-dw-hdmi.yaml| 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH v3 2/6] dt-bindings: display: bridge: renesas, dw-hdmi: Convert binding to YAML

2021-01-04 Thread Laurent Pinchart
Convert the Renesas R-Car DWC HDMI TX text binding to YAML. Signed-off-by: Laurent Pinchart --- Changes since v2: - Update MAINTAINERS Changes since v1: - Drop the part numbers in comments, only keep the SoC names - Use unevaluatedProperties instead of additionalProperties - Only specify

[PATCH v3 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-04 Thread Laurent Pinchart
Add a .yaml schema containing the common properties for the Synopsys DesignWare HDMI TX controller. This isn't a full device tree binding specification, but is meant to be referenced by platform-specific bindings for the IP core. Signed-off-by: Laurent Pinchart --- Changes since v1: - Add

[PATCH v3 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML

2021-01-04 Thread Laurent Pinchart
Hello, This patch series attempts a conversion of the DWC HDMI TX DT bindings to YAML. It's mostly identical to v2, with Mark Yao's e-mail address updated, tags picked, a small MAINTAINERS updated, and the series now sent to the devicet...@vger.kernel.org mailing list. The DWC HDMI TX is an HDMI

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-04 Thread Laurent Pinchart
Hi Philipp, On Mon, Jan 04, 2021 at 04:30:36PM +0100, Philipp Zabel wrote: > On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > > Convert the i.MX6 HDMI TX text binding to YAML. > > > > Signed-off-by: Laurent Pinchart > > --- > > Changes since v1: > > > > - Only specify maxItems for

[GIT PULL FOR v5.12] R-Car DU and misc other changes

2021-01-04 Thread Laurent Pinchart
Hi Dave and Daniel, The following changes since commit 5b2fc08c455bbf749489254a81baeffdf4c0a693: Merge tag 'amd-drm-fixes-5.11-2020-12-23' of git://people.freedesktop.org/~agd5f/linux into drm-next (2020-12-24 10:31:16 +1000) are available in the Git repository at:

Re: [PATCH 31/31] PM / devfreq: convert to devm_pm_opp_register_notifier and remove unused API

2021-01-04 Thread Chanwoo Choi
On Sun, Jan 3, 2021 at 12:59 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/devfreq.c | 66 +-- > include/linux/devfreq.h | 23 -- > 2 files changed, 1 insertion(+), 88

Re: [PATCH] dt-bindings: display: Use OF graph schema

2021-01-04 Thread Laurent Pinchart
Hi Rob, Thank you for the patch. On Mon, Jan 04, 2021 at 11:07:23AM -0700, Rob Herring wrote: > Now that we have a graph schema, rework the display related schemas to use > it. Mostly this is adding a reference to graph.yaml and dropping duplicate > parts from schemas. > > In panel-common.yaml,

Re: [PATCH 30/31] PM / devfreq: exynos: convert to use devm_pm_opp_* API

2021-01-04 Thread Chanwoo Choi
On Sun, Jan 3, 2021 at 12:59 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code, and remove opp_table > from exynos_bus. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/exynos-bus.c | 42 > 1 file changed, 9 insertions(+), 33 deletions(-)

Re: [PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API

2021-01-04 Thread Chanwoo Choi
On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/imx-bus.c | 14 +++--- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/devfreq/imx-bus.c

Re: [PATCH 28/31] PM / devfreq: imx8m-ddrc: convert to use devm_pm_opp_* API

2021-01-04 Thread Chanwoo Choi
On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/imx8m-ddrc.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) > > diff --git a/drivers/devfreq/imx8m-ddrc.c

Re: 5.11-rc1 TTM list corruption

2021-01-04 Thread Huang Rui
On Mon, Jan 04, 2021 at 06:58:02PM +0800, Borislav Petkov wrote: > On Fri, Jan 01, 2021 at 03:34:28PM +0100, Christian K?nig wrote: > > Going to double check the code, but can you reproduce this issue > > reliable? > > Lemme find a test box which can trigger it too - the splat happened > on my

Re: [PATCH 27/31] PM / devfreq: rk3399_dmc: convert to use devm_pm_opp_* API

2021-01-04 Thread Chanwoo Choi
Hi, Do you make this patch on latest source? When I apply this patch for test, it make the merge conflict error. On Sun, Jan 3, 2021 at 12:57 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code. Since devres release > can guarantee the order, let's remove >

Re: [PATCH 26/31] PM / devfreq: tegra30: convert to use devm_pm_opp_* API

2021-01-04 Thread Chanwoo Choi
Hi, On Sun, Jan 3, 2021 at 12:57 PM Yangtao Li wrote: > > Use devm_pm_opp_* API to simplify code, and remove opp_table > from tegra_devfreq. > > Signed-off-by: Yangtao Li > --- > drivers/devfreq/tegra30-devfreq.c | 21 +++-- > 1 file changed, 7 insertions(+), 14 deletions(-) >

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-04 Thread Deepak Rawat
On Mon, 2021-01-04 at 14:03 +0100, Thomas Zimmermann wrote: > Hi, > > I've been looking forward to this patchset. :) The code is really > nice > already. Thanks Thomas for the review. > >   > > +config DRM_HYPERV > > +   tristate "DRM Support for hyperv synthetic video device" > > +  

Re: [PATCH v6 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-04 Thread Nicolas Boichat
On Tue, Jan 5, 2021 at 8:34 AM Alyssa Rosenzweig wrote: > > > GPUs with more than a single regulator (e.g. G-57 on MT8183) will > > G72 Duh, sorry, yes. I will fix that in v7. ___ dri-devel mailing list dri-devel@lists.freedesktop.org

[PATCH v6 4/4] drm/panfrost: Add mt8183-mali compatible string

2021-01-04 Thread Nicolas Boichat
Add support for MT8183's G-57 Bifrost. Signed-off-by: Nicolas Boichat --- Changes in v6: - Context conflicts, reflow the code. - Use ARRAY_SIZE for power domains too. Changes in v5: - Change power domain name from 2d to core2. Changes in v4: - Add power domain names. Changes in v3: -

[PATCH v6 3/4] drm/panfrost: devfreq: Disable devfreq when num_supplies > 1

2021-01-04 Thread Nicolas Boichat
GPUs with more than a single regulator (e.g. G-57 on MT8183) will require platform-specific handling, disable devfreq for now. Signed-off-by: Nicolas Boichat --- Changes in v6: - New change drivers/gpu/drm/panfrost/panfrost_devfreq.c | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v6 1/4] dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183

2021-01-04 Thread Nicolas Boichat
Define a compatible string for the Mali Bifrost GPU found in Mediatek's MT8183 SoCs. Signed-off-by: Nicolas Boichat Reviewed-by: Alyssa Rosenzweig --- Changes in v6: - Rebased, actually tested with recent mesa driver. - No change Changes in v5: - Rename "2d" power domain to "core2"

[PATCH v6 0/4] drm/panfrost: Add support for mt8183 GPU

2021-01-04 Thread Nicolas Boichat
Hi! Follow-up on the v5 [1], things have gotten significantly better in the last 9 months, thanks to the efforts on Bifrost support by the Collabora team (and probably others I'm not aware of). I've been testing this series on a MT8183/kukui device, with a chromeos-5.10 kernel [2], and got basic

[PATCH] drm/ttm: Remove pinned bos from LRU in ttm_bo_move_to_lru_tail()

2021-01-04 Thread Lyude Paul
Recently a regression was introduced which caused TTM's buffer eviction to attempt to evict already-pinned BOs, causing issues with buffer eviction under memory pressure along with suspend/resume: nouveau :1f:00.0: DRM: evicting buffers... nouveau :1f:00.0: DRM: Moving pinned object

[PATCH] dt-bindings: Add missing array size constraints

2021-01-04 Thread Rob Herring
DT properties which can have multiple entries need to specify what the entries are and define how many entries there can be. In the case of only a single entry, just 'maxItems: 1' is sufficient. Add the missing entry constraints. These were found with a modified meta-schema. Unfortunately, there

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 Stuart Foster (smf-li...@virginmedia.com) changed: What|Removed |Added CC|

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Alex Williamson
On Mon, 4 Jan 2021 21:13:53 +0100 Christian König wrote: > Am 04.01.21 um 19:43 schrieb Alex Williamson: > > On Mon, 4 Jan 2021 18:39:33 +0100 > > Christian König wrote: > > > >> Am 04.01.21 um 17:45 schrieb Alex Williamson: > >>> On Mon, 4 Jan 2021 12:34:34 +0100 > >>> Christian König

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-8/10/11.

2021-01-04 Thread Alex Deucher
Applied the series. Thanks! Alex On Mon, Jan 4, 2021 at 4:17 PM Kazlauskas, Nicholas wrote: > > On 2020-12-28 1:50 p.m., Mario Kleiner wrote: > > The hw supports fp16, this is not only useful for HDR, > > but also for standard dynamic range displays, because > > it allows to get more precise

Re: [PATCH AUTOSEL 5.4 006/130] drm/amd/display: Do not silently accept DCC for multiplane formats.

2021-01-04 Thread Kazlauskas, Nicholas
On 2020-12-29 9:54 a.m., Deucher, Alexander wrote: [AMD Public Use] I don't know if these fixes related to modifiers make sense in the pre-modifier code base.  Bas, Nick? Alex Mesa should be the only userspace trying to make use of DCC and it doesn't do it for video formats. From the

Re: [PATCH 2/2] drm/amd/display: Enable fp16 also on DCE-8/10/11.

2021-01-04 Thread Kazlauskas, Nicholas
On 2020-12-28 1:50 p.m., Mario Kleiner wrote: The hw supports fp16, this is not only useful for HDR, but also for standard dynamic range displays, because it allows to get more precise color reproduction with about 11 - 12 bpc linear precision in the unorm range 0.0 - 1.0. Working fp16

Re: [PATCH 1/2] drm/amd/display: Check plane scaling against format specific hw plane caps.

2021-01-04 Thread Kazlauskas, Nicholas
On 2020-12-28 1:50 p.m., Mario Kleiner wrote: This takes hw constraints specific to pixel formats into account, e.g., the inability of older hw to scale fp16 format framebuffers. It should now allow safely to enable fp16 formats also on DCE-8, DCE-10, DCE-11.0 Signed-off-by: Mario Kleiner

Re: [PATCH] drm/msm: Only enable A6xx LLCC code on A6xx

2021-01-04 Thread Jordan Crouse
On Mon, Jan 04, 2021 at 08:30:41PM +0100, Konrad Dybcio wrote: > Using this code on A5xx (and probably older too) causes a > smmu bug. > > Fixes: 474dadb8b0d5 ("drm/msm/a6xx: Add support for using system cache(LLC)") > Signed-off-by: Konrad Dybcio > Tested-by: AngeloGioacchino Del Regno >

[PULL] drm-intel-next

2021-01-04 Thread Rodrigo Vivi
Hi Dave and Daniel, Happy New Year. Here goes the first pull request targeting 5.12. drm-intel-next-2021-01-04: - Display hotplug fix for gen2/gen3 (Chris) - Remove trailing semicolon (Tom) - Suppress display warnings for old ifwi presend on our CI (Chris) - OA/Perf related workaround (Lionel)

[PATCH v3 2/3] drm/amd/display: Add freesync video modes based on preferred modes

2021-01-04 Thread Aurabindo Pillai
[Why] If experimental freesync video mode module parameter is enabled, add few extra display modes into the driver's mode list corresponding to common video frame rates. When userspace sets these modes, no modeset will be performed (if current mode was one of freesync modes or the base freesync

[PATCH v3 3/3] drm/amd/display: Skip modeset for front porch change

2021-01-04 Thread Aurabindo Pillai
[Why] Inorder to enable freesync video mode, driver adds extra modes based on preferred modes for common freesync frame rates. When commiting these mode changes, a full modeset is not needed. If the change in only in the front porch timing value, skip full modeset and continue using the same

[PATCH v3 1/3] drm/amd/display: Add module parameter for freesync video mode

2021-01-04 Thread Aurabindo Pillai
[Why] Adds a module parameter to enable experimental freesync video mode modeset optimization. Enabling this mode allows the driver to skip a full modeset when freesync compatible modes are requested by the userspace. This paramters also adds some standard modes based on the connected monitor's

[PATCH v3 0/3] Experimental freesync video mode optimization

2021-01-04 Thread Aurabindo Pillai
Changes in V4 = 1) Add module parameter for freesync video mode * Change module parameter name to freesync_video 2) Add freesync video modes based on preferred modes: * Cosmetic fixes * Added comments about all modes being added by the driver. 3) Skip modeset for front porch

[PATCH CI 1/4] drm: Add function to convert rect in 16.16 fixed format to regular format

2021-01-04 Thread José Roberto de Souza
Much more clear to read one function call than four lines doing this conversion. v7: - function renamed - calculating width and height before truncate - inlined v10: - renamed parameters from source and destination to src and dst to match sister functions Cc: Ville Syrjälä Cc:

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Liu, Zhan
[AMD Official Use Only - Internal Distribution Only] + Ville On Sat, Jan 2, 2021 at 4:31 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 --- Comment #1 from Oleksandr Natalenko (oleksa...@natalenko.name) --- https://bugs.archlinux.org/task/69202 http://lkml.iu.edu/hypermail/linux/kernel/2101.0/01465.html -- You may reply to this email to add a comment. You are receiving this

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Christian König
Am 04.01.21 um 19:43 schrieb Alex Williamson: On Mon, 4 Jan 2021 18:39:33 +0100 Christian König wrote: Am 04.01.21 um 17:45 schrieb Alex Williamson: On Mon, 4 Jan 2021 12:34:34 +0100 Christian König wrote: [SNIP] That's a rather bad idea. See our GPUs for example return way more than

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Alex Williamson
On Mon, 4 Jan 2021 18:39:33 +0100 Christian König wrote: > Am 04.01.21 um 17:45 schrieb Alex Williamson: > > On Mon, 4 Jan 2021 12:34:34 +0100 > > Christian König wrote: > > > >> Hi Maxim, > >> > >> I can't help with the display related stuff. Probably best approach to > >> get this fixes

Re: [PATCH v2 0/6] dt-bindings: display: Convert DWC HDMI TX bindings to YAML

2021-01-04 Thread Rob Herring
On Sun, Dec 20, 2020 at 12:50 PM Laurent Pinchart wrote: > > Hello, > > This patch series attempts a conversion of the DWC HDMI TX DT bindings > to YAML. Please resend to DT list. Rob ___ dri-devel mailing list dri-devel@lists.freedesktop.org

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Bas Nieuwenhuizen
+ Ville On Sat, Jan 2, 2021 at 4:31 PM Mario Kleiner wrote: > > On Sat, Jan 2, 2021 at 3:02 PM Bas Nieuwenhuizen > wrote: > > > > With modifiers one can actually have different format_info structs > > for the same format, which now matters for AMDGPU since we convert > > implicit modifiers to

[PATCH] dt-bindings: display: Use OF graph schema

2021-01-04 Thread Rob Herring
Now that we have a graph schema, rework the display related schemas to use it. Mostly this is adding a reference to graph.yaml and dropping duplicate parts from schemas. In panel-common.yaml, 'ports' is dropped. Any binding using 'ports' should be one with more than 1 port node, and the binding

Re: [PATCH v3 1/2] drm/msm: Add speed-bin support to a618 gpu

2021-01-04 Thread Jordan Crouse
On Mon, Dec 07, 2020 at 04:12:07PM +0530, Akhil P Oommen wrote: > Some GPUs support different max frequencies depending on the platform. > To identify the correct variant, we should check the gpu speedbin > fuse value. Add support for this speedbin detection to a6xx family > along with the

Re: [PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Sun, Jan 03, 2021 at 03:54:15AM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra30-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) Reviewed-by: Krzysztof Kozlowski

Re: [PATCH 24/31] memory: tegra20: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:55:00PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/tegra/tegra20-emc.c | 29 + > 1 file changed, 9 insertions(+), 20 deletions(-) > Reviewed-by: Krzysztof

Re: [PATCH 23/31] memory: samsung: exynos5422-dmc: convert to use devm_pm_opp_* API

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:54:59PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code. > > Signed-off-by: Yangtao Li > --- > drivers/memory/samsung/exynos5422-dmc.c | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-) Reviewed-by: Krzysztof Kozlowski

Re: [PATCH 22/31] memory: samsung: exynos5422-dmc: fix return error in exynos5_init_freq_table

2021-01-04 Thread Krzysztof Kozlowski
On Fri, Jan 01, 2021 at 04:54:58PM +, Yangtao Li wrote: > We can't always return -EINVAL, let's fix it. > > Signed-off-by: Yangtao Li > --- > drivers/memory/samsung/exynos5422-dmc.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski I see

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Christian König
Am 04.01.21 um 17:45 schrieb Alex Williamson: On Mon, 4 Jan 2021 12:34:34 +0100 Christian König wrote: Hi Maxim, I can't help with the display related stuff. Probably best approach to get this fixes would be to open up a bug tracker for this on FDO. But I'm the one who implemented the

[Bug 211033] [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 Žilvinas Žaltiena (zal...@inbox.ru) changed: What|Removed |Added Regression|No |Yes -- You may

[Bug 211033] New: [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12

2021-01-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211033 Bug ID: 211033 Summary: [bisected][regression] amdgpu: *ERROR* Restoring old state failed with -12 Product: Drivers Version: 2.5 Kernel Version: 5.10.4 Hardware:

Re: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-04 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 4, 2021 at 7:58 AM Lin, Wayne wrote: > > [AMD Official Use Only - Internal Distribution Only] > > Thanks Arnd. > > Reviewed-by: Wayne Lin > > -Original Message- > From: Arnd Bergmann > Sent: Sunday, January 3, 2021 10:03 PM > To: Wentland, Harry ;

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Alex Deucher
On Sat, Jan 2, 2021 at 9:02 AM Bas Nieuwenhuizen wrote: > > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it

Re: [PATCH] drm/amd/display: fix comparison pointer to bool warning in dc.c

2021-01-04 Thread Alex Deucher
On Tue, Dec 29, 2020 at 4:42 AM Tian Tao wrote: > > Fixes coccicheck warning: > drivers/gpu/drm/amd/display/dc/core/dc.c:1543:12-19: WARNING: Comparison > to bool > drivers/gpu/drm/amd/display/dc/core/dc.c:1496:14-42: WARNING: Comparison > to bool >

Re: Enable fp16 display support for DCE8+, next try.

2021-01-04 Thread Alex Deucher
On Mon, Dec 28, 2020 at 1:51 PM Mario Kleiner wrote: > > Hi and happy post-christmas! > > I wrote a patch 1/1 that now checks plane scaling factors against > the pixel-format specific limits in the asic specific dc_plane_cap > structures during atomic check and other appropriate places. > > This

[GIT PULL] drm/imx: fixes and drm managed resources

2021-01-04 Thread Philipp Zabel
Hi Dave, Daniel, this PR includes the drmm encoder/plane/crtc allocation functions and converts the imx-drm driver to use them. The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at:

Re: [PATCH -next] gpu/drm/radeon: use DIV_ROUND_UP macro to do calculation

2021-01-04 Thread Alex Deucher
On Wed, Dec 23, 2020 at 2:06 AM Zheng Yongjun wrote: > > Don't open-code DIV_ROUND_UP() kernel macro. > > Signed-off-by: Zheng Yongjun Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH] drm/radeon:avoid null pointer dereference when dev is not bound

2021-01-04 Thread Alex Deucher
On Sun, Dec 27, 2020 at 3:56 PM Defang Bo wrote: > > [Why] > Similar to commit<0fa375e6>. If the set_state/can_switch code access the > drm_device when dev is not bound, > a null pointer dereference can happen. > > [How] > Add sanity checks to prevent it. > > Signed-off-by: Defang Bo Are you

Re: [PATCH] drm/amd/display: remove useless else if

2021-01-04 Thread Alex Deucher
On Mon, Dec 21, 2020 at 9:40 AM Tian Tao wrote: > > Fix the following coccinelle report: > drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c:1357:6-8: > WARNING: possible condition with no effect (if == else) > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- >

Re: [PATCH] drm/amd/display: remove unused including

2021-01-04 Thread Alex Deucher
On Thu, Dec 31, 2020 at 5:42 AM Tian Tao wrote: > > Remove including that don't need it. > > Signed-off-by: Tian Tao Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 1 - >

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Alex Williamson
On Mon, 4 Jan 2021 12:34:34 +0100 Christian König wrote: > Hi Maxim, > > I can't help with the display related stuff. Probably best approach to > get this fixes would be to open up a bug tracker for this on FDO. > > But I'm the one who implemented the resizeable BAR support and your >

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-04 Thread Ard Biesheuvel
On Mon, 4 Jan 2021 at 17:27, Alex Deucher wrote: > > On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel

Re: [PATCH v3 05/12] drm/ttm: Expose ttm_tt_unpopulate for driver use

2021-01-04 Thread Andrey Grodzovsky
Hey Daniel, back from vacation and going over our last long thread i think you didn't reply to my last question bellow (Or at least I can't find it). Andrey On 12/17/20 4:13 PM, Andrey Grodzovsky wrote: Ok, so I assumed that with vmap_local you were trying to solve the problem of quick

Re: [PATCH] drm/amd/display: Revert "add DCN support for aarch64"

2021-01-04 Thread Alex Deucher
On Tue, Dec 29, 2020 at 8:17 AM Ard Biesheuvel wrote: > > On Wed, 16 Dec 2020 at 23:26, Ard Biesheuvel wrote: > > > > On Wed, 16 Dec 2020 at 19:00, Alex Deucher wrote: > > > > > > On Mon, Dec 14, 2020 at 12:53 PM Ard Biesheuvel wrote: > > > > > > > > This reverts commit

Re: [PATCH v1 1/2] dt-bindings: Convert Arm Mali Valhall GPU to DT schema

2021-01-04 Thread Rob Herring
On Mon, Jan 4, 2021 at 12:11 AM Nick Fan wrote: > > Convert the Arm Valhall GPU binding to DT schema format. This is the 2nd v1 you've sent. Please address my comments on the 1st v1. > > Define a compatible string for the Mali Valhall GPU > for Mediatek's SoC platform. > > Signed-off-by: Nick

Re: [PATCH v2 1/6] dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI

2021-01-04 Thread Philipp Zabel
On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > Add a .yaml schema containing the common properties for the Synopsys > DesignWare HDMI TX controller. This isn't a full device tree binding > specification, but is meant to be referenced by platform-specific > bindings for the IP core. >

Re: [PATCH v2 3/6] dt-bindings: display: imx: hdmi: Convert binding to YAML

2021-01-04 Thread Philipp Zabel
On Sun, 2020-12-20 at 21:50 +0200, Laurent Pinchart wrote: > Convert the i.MX6 HDMI TX text binding to YAML. > > Signed-off-by: Laurent Pinchart > --- > Changes since v1: > > - Only specify maxItems for clocks > - Drop reg and interrupts as they're checked in the base schema > - Rebase on top

Re: [PATCH v1 2/2] drm/bridge: anx7625: add MIPI DPI input feature support

2021-01-04 Thread Dan Carpenter
On Fri, Dec 25, 2020 at 07:02:15PM +0800, Xin Ji wrote: > +static int anx7625_aux_dpcd_read(struct anx7625_data *ctx, > + u8 addrh, u8 addrm, u8 addrl, > + u8 len, u8 *buf) > +{ > + struct device *dev = >client->dev; > + int ret; >

Re: 5.11-rc1 TTM list corruption

2021-01-04 Thread Christian König
Am 04.01.21 um 11:58 schrieb Borislav Petkov: On Fri, Jan 01, 2021 at 03:34:28PM +0100, Christian König wrote: Going to double check the code, but can you reproduce this issue reliable? Lemme find a test box which can trigger it too - the splat happened on my workstation and I'd like to avoid

Re: [PATCH 14/31] spi: spi-qcom-qspi: convert to use devm_pm_opp_* API

2021-01-04 Thread Mark Brown
On Fri, Jan 01, 2021 at 04:54:50PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and remove opp_table > from qcom_qspi. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel mailing list

Re: [PATCH 13/31] spi: spi-qcom-qspi: fix potential mem leak in qcom_qspi_probe()

2021-01-04 Thread Mark Brown
On Fri, Jan 01, 2021 at 04:54:49PM +, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel

Re: [PATCH 09/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

2021-01-04 Thread Mark Brown
On Fri, Jan 01, 2021 at 04:54:45PM +, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and we don't need > to make opp_table glabal. Acked-by: Mark brown signature.asc Description: PGP signature ___ dri-devel mailing list

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-04 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] You might try enabling DC (the newer modesetting infrastructure). Append amdgpu.dc=1 to the kernel command line in grub. Alex From: Davide Corrado Sent: Saturday, January 2, 2021 1:50 PM To: Deucher,

Re: [PATCH 08/31] spi: spi-qcom-qspi: fix potential mem leak in spi_geni_probe()

2021-01-04 Thread Mark Brown
On Fri, Jan 01, 2021 at 04:54:44PM +, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. Acked-by: Mark Brown signature.asc Description: PGP signature ___ dri-devel

Re: discussion: re-structuring of the Amlogic Meson VPU DRM driver

2021-01-04 Thread Neil Armstrong
Hi, Sorry for the delay... On 31/12/2020 00:24, Martin Blumenstingl wrote: > Hi Neil and all interested people, > > in the past there were concerns about how some of the components are > coupled in our Meson DRM driver(s). > With this discussion I would like to achieve four things: > 1.

Re: [PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device

2021-01-04 Thread Thomas Zimmermann
Hi, I've been looking forward to this patchset. :) The code is really nice already. Am 02.01.21 um 07:03 schrieb Deepak Rawat: DRM driver for hyperv synthetic video device, based on hyperv_fb framebuffer driver. Also added config option "DRM_HYPERV" to enabled this driver. IIRC, this isn't

RE: [PATCH] drm/amd/display: Fix unused variable warning

2021-01-04 Thread Lin, Wayne
[AMD Official Use Only - Internal Distribution Only] Thanks Arnd. Reviewed-by: Wayne Lin -Original Message- From: Arnd Bergmann Sent: Sunday, January 3, 2021 10:03 PM To: Wentland, Harry ; Li, Sun peng (Leo) ; Deucher, Alexander ; Koenig, Christian ; David Airlie ; Daniel Vetter ;

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-04 Thread Christian König
Yes, absolutely. Do you only get a black screen? That would certainly be a rather big bug. Christian. Am 04.01.21 um 13:37 schrieb Davide Corrado: Btw, should the driver switch to the lower supported resolution then? Il Lun 4 Gen 2021, 13:04 Davide Corrado >

Re: [PATCH] drm/hisilicon: Use simple encoder

2021-01-04 Thread Thomas Zimmermann
Hi Am 28.12.20 um 08:35 schrieb Tian Tao: The hibmc driver uses empty implementations for its encoders. Replace the code with the generic simple encoder. Signed-off-by: Tian Tao Reviewed-by: Thomas Zimmermann Thanks for the patch. --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c |

Re: [Linaro-mm-sig] [PATCH] dmabuf: fix use-after-free of dmabuf's file->f_inode

2021-01-04 Thread Christian König
Am 04.01.21 um 12:36 schrieb Charan Teja Reddy: It is observed 'use-after-free' on the dmabuf's file->f_inode with the race between closing the dmabuf file and reading the dmabuf's debug info. Consider the below scenario where P1 is closing the dma_buf file and P2 is reading the dma_buf's debug

Re: Couple of issues with amdgpu on my WX4100

2021-01-04 Thread Christian König
Hi Maxim, I can't help with the display related stuff. Probably best approach to get this fixes would be to open up a bug tracker for this on FDO. But I'm the one who implemented the resizeable BAR support and your analysis of the problem sounds about correct to me. The reason why this

Re: amdgpu does not support 3840x2160@30Hz on kaveri apu

2021-01-04 Thread Christian König
Hi Davide, adding a few of our AMD display people. In general as already suggested by others opening a bug report to track this is the right thing to do. In the past we had a few bug reports like this because amdgpu is more strict in checking hardware limitations. For example it can be

Re: 5.11-rc1 TTM list corruption

2021-01-04 Thread Borislav Petkov
On Fri, Jan 01, 2021 at 03:34:28PM +0100, Christian König wrote: > Going to double check the code, but can you reproduce this issue > reliable? Lemme find a test box which can trigger it too - the splat happened on my workstation and I'd like to avoid debugging there for obvious reasons. Thx.

Re: [PATCH v2 -next] video: backlight: use DEFINE_MUTEX() for mutex lock

2021-01-04 Thread Daniel Thompson
On Thu, Dec 24, 2020 at 09:26:01PM +0800, Zheng Yongjun wrote: > mutex lock can be initialized automatically with DEFINE_MUTEX() > rather than explicitly calling mutex_init(). > > Signed-off-by: Zheng Yongjun > --- > drivers/video/backlight/backlight.c | 3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Christian König
Am 02.01.21 um 15:02 schrieb Bas Nieuwenhuizen: With modifiers one can actually have different format_info structs for the same format, which now matters for AMDGPU since we convert implicit modifiers to explicit modifiers with multiple planes. I checked other drivers and it doesn't look like

Re: [PATCH] drm: Check actual format for legacy pageflip.

2021-01-04 Thread Pierre-Eric Pelloux-Prayer
Hi Bas, On 02/01/2021 15:02, Bas Nieuwenhuizen wrote: > With modifiers one can actually have different format_info structs > for the same format, which now matters for AMDGPU since we convert > implicit modifiers to explicit modifiers with multiple planes. > > I checked other drivers and it

Re: [PATCH -next] video: backlight: use DEFINE_MUTEX (and mutex_init() had been too late)

2021-01-04 Thread Daniel Thompson
On Wed, Dec 23, 2020 at 10:10:35PM +0800, Zheng Yongjun wrote: > Signed-off-by: Zheng Yongjun Can you explain the Subject for this patch in more detail? If this patch is required to correct a bug then it looks to me like it is incomplete. Daniel. > --- > drivers/video/backlight/backlight.c

[PATCH 25/31] memory: tegra30: convert to use devm_pm_opp_* API

2021-01-04 Thread Yangtao Li
Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/memory/tegra/tegra30-emc.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/memory/tegra/tegra30-emc.c b/drivers/memory/tegra/tegra30-emc.c index

Re: [PATCH 07/31] serial: qcom_geni_serial: convert to use devm_pm_opp_* API

2021-01-04 Thread Viresh Kumar
On 01-01-21, 16:54, Yangtao Li wrote: > Use devm_pm_opp_* API to simplify code, and we don't need > to make opp_table glabal. > > Let's remove opp_table from geni_se later. > > Signed-off-by: Yangtao Li > --- > drivers/tty/serial/qcom_geni_serial.c | 23 +-- > 1 file

Re: [PATCH 18/31] drm/lima: remove unneeded devm_devfreq_remove_device()

2021-01-04 Thread Viresh Kumar
On 01-01-21, 16:54, Yangtao Li wrote: > There is no need to manually release devm related resources. > > Signed-off-by: Yangtao Li > --- > drivers/gpu/drm/lima/lima_devfreq.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/lima/lima_devfreq.c >

[PATCH 29/31] PM / devfreq: imx-bus: convert to use devm_pm_opp_* API

2021-01-04 Thread Yangtao Li
Use devm_pm_opp_* API to simplify code. Signed-off-by: Yangtao Li --- drivers/devfreq/imx-bus.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c index 4f38455ad742..ff26ef049b1b 100644 ---

Re: [PATCH v3, 1/8] soc: mediatek: mmsys: create mmsys folder

2021-01-04 Thread Yongqiang Niu
On Thu, 2020-12-31 at 09:21 +0800, Nicolas Boichat wrote: > On Mon, Dec 28, 2020 at 4:38 PM Yongqiang Niu > wrote: > > > > the mmsys will more and more complicated after support > > more and more SoCs, add an independent folder will be > > more clear > > > > Signed-off-by: Yongqiang Niu > > ---

Re: [PATCH 00/31] Introduce devm_pm_opp_* API

2021-01-04 Thread Viresh Kumar
On 01-01-21, 16:54, Yangtao Li wrote: > Hi, > > This patchset add devm_pm_opp_set_clkname, devm_pm_opp_put_clkname, > devm_pm_opp_set_regulators, devm_pm_opp_put_regulators, > devm_pm_opp_set_supported_hw, devm_pm_opp_of_add_table and > devm_pm_opp_register_notifier. Please also mention next

Re: [PATCH 06/31] serial: qcom_geni_serial: fix potential mem leak in qcom_geni_serial_probe()

2021-01-04 Thread Viresh Kumar
On 01-01-21, 16:54, Yangtao Li wrote: > We should use dev_pm_opp_put_clkname() to free opp table each time > dev_pm_opp_of_add_table() got error. > > Signed-off-by: Yangtao Li > --- > drivers/tty/serial/qcom_geni_serial.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > >

[PATCH] drm/msm: Fix MSM_INFO_GET_IOVA with carveout

2021-01-04 Thread Iskren Chernev
The msm_gem_get_iova should be guarded with gpu != NULL and not aspace != NULL, because aspace is NULL when using vram carveout. Fixes: 933415e24bd0d ("drm/msm: Add support for private address space instances") Signed-off-by: Iskren Chernev --- drivers/gpu/drm/msm/msm_drv.c | 3 ++- 1 file

  1   2   >