Re: [PATCH v11 3/9] drm/mediatek: add RDMA fifo size error handle

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:27 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > This patch add RDMA fifo size error handle > rdma fifo size will not always bigger than the calculated threshold > if that case happened, we need set fifo size as the threshold > > Signed-off-by:

Re: [RFC PATCH 0/3] add ttm trace event support

2021-01-27 Thread Christian König
Not a bad start, but that needs quite some more work. First of all please rebase on top of current drm-misc-next, a whole bunch of the stuff you want to trace here was already removed or is about to be removed. Then concentrate on the necessary trace points, for example

Re: [PATCH v11 8/9] soc: mediatek: add mtk mutex support for MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add mtk mutex support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/mediatek/mtk-mutex.c | 50 > 1 file

Re: [PATCH v11 7/9] drm/mediatek: enable dither function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Thu, 2021-01-28 at 15:28 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > for 5 or 6 bpc panel, we need enable dither function > to improve the display quality > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

Re: [PATCH v11 4/9] drm/mediatek: add mtk_dither_set_common() function

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 15:27 +0800, Hsin-Yi Wang wrote: > Current implementation of mtk_dither_set() cast dev data to > struct mtk_ddp_comp_dev. But other devices with different dev data > would also call this function. > > Separate necessary parameters out so other device components (dither, >

Re: [Linaro-mm-sig] [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-01-27 Thread Christian König
Am 27.01.21 um 23:00 schrieb Felix Kuehling: Am 2021-01-27 um 7:16 a.m. schrieb Christian König: Am 27.01.21 um 13:11 schrieb Maarten Lankhorst: Op 27-01-2021 om 01:22 schreef Felix Kuehling: Am 2021-01-21 um 2:40 p.m. schrieb Daniel Vetter: Recently there was a fairly long thread about

[RFC PATCH 2/3] drm/ttm: add ttm vm bo trace event support

2021-01-27 Thread Kevin Wang
add ttm bo VM related trace event support trace events: ttm:ttm_bo_mmap ttm:ttm_bo_vm_fault ttm:ttm_bo_vm_access Signed-off-by: Kevin Wang --- drivers/gpu/drm/ttm/ttm_bo_vm.c | 12 - drivers/gpu/drm/ttm/ttm_trace.h | 78 + 2 files changed, 88 insertions(+),

[RFC PATCH 3/3] drm/ttm: add ttm mem trace event support

2021-01-27 Thread Kevin Wang
add ttm memory related trace event support trace events: ttm:ttm_shrink ttm:ttm_mem_global_reserve ttm:ttm_mem_global_free Signed-off-by: Kevin Wang --- drivers/gpu/drm/ttm/ttm_memory.c | 7 drivers/gpu/drm/ttm/ttm_trace.h | 70 2 files changed, 77

[RFC PATCH 1/3] drm/ttm: add ttm bo trace event support

2021-01-27 Thread Kevin Wang
add ttm bo related trace event support trace events: ttm:ttm_bo_add_mem_to_lru ttm:ttm_bo_del_from_lru ttm:ttm_bo_move_mem ttm:ttm_bo_wait ttm:ttm_bo_evict ttm:ttm_bo_swapout ttm:ttm_bo_device_init ttm:ttm_bo_device_release ttm:ttm_bo_init_reserved ttm:ttm_bo_validate ttm:ttm_bo_release

[RFC PATCH 0/3] add ttm trace event support

2021-01-27 Thread Kevin Wang
the kernel ftrace can better help analyze the kernel running status. add some trace events to support TTM. add trace events list: ttm:ttm_bo_add_mem_to_lru ttm:ttm_bo_del_from_lru ttm:ttm_bo_move_mem ttm:ttm_bo_wait ttm:ttm_bo_evict ttm:ttm_bo_swapout ttm:ttm_bo_device_init

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 14:15 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 2:13 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > Modify the title's prefix to 'soc: mediatek:' > > > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > > From: Yongqiang Niu > > > > > > Add DDP support

[PATCH v3 3/3] dma-buf: system_heap: Add deferred freeing to the system heap

2021-01-27 Thread John Stultz
Utilize the deferred free helper library in the system heap. This provides a nice performance bump and puts the system heap performance on par with ION. Cc: Daniel Vetter Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren

[PATCH v3 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-01-27 Thread John Stultz
Reuse/abuse the pagepool code from the network code to speed up allocation performance. This is similar to the ION pagepool usage, but tries to utilize generic code instead of a custom implementation. Cc: Daniel Vetter Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott

[PATCH v3 1/3] dma-buf: heaps: Add deferred-free-helper library code

2021-01-27 Thread John Stultz
This patch provides infrastructure for deferring buffer frees. This is a feature ION provided which when used with some form of a page pool, provides a nice performance boost in an allocation microbenchmark. The reason it helps is it allows the page-zeroing to be done out of the normal

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 14:13 +0800, CK Hu wrote: > Hi, Hsin-Yi: > > Modify the title's prefix to 'soc: mediatek:' Modify more, the title should be 'soc: mediatek: add mtk mutex support for MT8183' > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > From: Yongqiang Niu > > > > Add

Re: [PATCH v10 9/9] drm/mediatek: add support for mediatek SOC MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > 1. add ovl private data > 2. add rdma private data > 3. add gamma privte data > 4. add main and external path module for crtc create Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu >

Re: [PATCH v10 8/9] drm/mediatek: add DDP support for MT8183

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: Modify the title's prefix to 'soc: mediatek:' On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Add DDP support for MT8183 SoC. > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- > drivers/soc/mediatek/mtk-mutex.c | 50

Re: [PATCH v10 7/9] drm/mediatek: enable dither function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > for 5 or 6 bpc panel, we need enable dither function > to improve the display quality > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #21 from bola...@163.com --- (In reply to Michel Dänzer from comment #14) > > If enable 64bit kernel support,I need to recompile everything on LFS10.0 in > > next weeks. > > You shouldn't. 32-bit user-space works fine with a 64-bit

Re: [PATCH v10 6/9] drm/mediatek: add has_dither private data for gamma

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > Not all SoC has dither function in gamma module. > Add private data to control this function setting. Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

Re: [PATCH v10 5/9] drm/mediatek: separate gamma module

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > From: Yongqiang Niu > > mt8183 gamma module will different with mt8173 > separate gamma for add private data Reviewed-by: CK Hu > > Signed-off-by: Yongqiang Niu > Signed-off-by: Hsin-Yi Wang > --- >

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-27 Thread CK Hu
On Thu, 2021-01-28 at 13:09 +0800, Hsin-Yi Wang wrote: > On Thu, Jan 28, 2021 at 12:39 PM CK Hu wrote: > > > > Hi, Hsin-Yi: > > > > On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > > > There may be data structure other than mtk_ddp_comp_dev that would call > > > mtk_dither_set(), so use

Re: [PATCH v2 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-01-27 Thread John Stultz
On Wed, Jan 27, 2021 at 12:21 PM Daniel Mentz wrote: > > On Fri, Jan 22, 2021 at 7:47 PM John Stultz wrote: > > +static int system_heap_clear_pages(struct page **pages, int num, pgprot_t > > pgprot) > > +{ > > + void *addr = vmap(pages, num, VM_MAP, pgprot); > > + > > + if (!addr) >

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 bola...@163.com changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #20 from bola...@163.com --- Everything is OK!I recompiled the 5.10.8 X64 kernel,AMDGPU is successful load !It seems the 32bit kernel is not supported now .I think the AMDGPU drivers need IOMMU and HSPA support,the 32bit kernel

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #19 from Alex Deucher (alexdeuc...@gmail.com) --- Please attach your xorg log and dmesg output. Note that if you want an fbdev interface for the console, you need to enable CONFIG_DRM_FBDEV_EMULATION=y in your config. -- You may

Re: [PATCH v10 4/9] drm/mediatek: generalize mtk_dither_set() function

2021-01-27 Thread CK Hu
Hi, Hsin-Yi: On Wed, 2021-01-27 at 12:54 +0800, Hsin-Yi Wang wrote: > There may be data structure other than mtk_ddp_comp_dev that would call > mtk_dither_set(), so use regs as parameter instead of device. You does not change the interface of mtk_dither_set(). You move the common part in

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #18 from bola...@163.com --- I have compiled x64 kernel for my LFS10.0.Booting with the X64 kernel,when load the amdgpu driver,screen frozen again. check the kern log ,everything seems OK but no amdgpudrmfb .I try to start X11,but

[PATCH 3/3 v2] drm/msm: Clean up GMU OOB set/clear handling.

2021-01-27 Thread Eric Anholt
Now that the bug is fixed in the minimal way for stable, go make the code table-driven. Signed-off-by: Eric Anholt --- Previous version hadn't been rebased off of a bit of debug code I had, so it wouldn't cleanly apply. drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 124 +-

[PATCH 3/3] drm/msm: Clean up GMU OOB set/clear handling.

2021-01-27 Thread Eric Anholt
Now that the bug is fixed in the minimal way for stable, go make the code table-driven. Signed-off-by: Eric Anholt --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 124 +- drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 55 2 files changed, 77 insertions(+), 102

[PATCH 2/3] drm/msm: Fix races managing the OOB state for timestamp vs timestamps.

2021-01-27 Thread Eric Anholt
Now that we're not racing with GPU setup, also fix races of timestamps against other timestamps. In CI, we were seeing this path trigger timeouts on setting the GMU bit, especially on the first set of tests right after boot (it's probably easier to lose the race than one might think, given that

[PATCH 1/3] drm/msm: Fix race of GPU init vs timestamp power management.

2021-01-27 Thread Eric Anholt
We were using the same force-poweron bit in the two codepaths, so they could race to have one of them lose GPU power early. Signed-off-by: Eric Anholt Cc: sta...@vger.kernel.org # v5.9 --- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 25 ++---

Re: [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-01-27 Thread Felix Kuehling
Am 2021-01-27 um 7:16 a.m. schrieb Christian König: > Am 27.01.21 um 13:11 schrieb Maarten Lankhorst: >> Op 27-01-2021 om 01:22 schreef Felix Kuehling: >>> Am 2021-01-21 um 2:40 p.m. schrieb Daniel Vetter: Recently there was a fairly long thread about recoreable hardware page faults, how

Re: [PATCH v5 00/21] Host1x/TegraDRM UAPI

2021-01-27 Thread Mikko Perttunen
On 1/27/21 11:26 PM, Dmitry Osipenko wrote: 26.01.2021 05:45, Mikko Perttunen пишет: 5. The hardware state of sync points should be reset when sync point is requested, not when host1x driver is initialized. This may be doable, but I don't think it is critical for this UAPI, so let's

Re: [PATCH v5 00/21] sync_file API is not very suitable for DRM

2021-01-27 Thread Mikko Perttunen
On 1/27/21 11:35 PM, Dmitry Osipenko wrote: 26.01.2021 05:45, Mikko Perttunen пишет: 4. Sync file shouldn't be needed for the part of DRM API which doesn't interact with external non-DRM devices.  We should use DRM syncobj for everything related to DRM, it's a superior API over sync file, it's

Re: [PULL] drm-intel-next

2021-01-27 Thread Ville Syrjälä
On Wed, Jan 27, 2021 at 09:08:22AM -0500, Rodrigo Vivi wrote: > Hi Dave and Daniel, > > Hopefully this is the last pull request towards 5.12. > > Please notice this contains a drm/framebuffer change needed for > supporting clear color support for TGL Render Decompression. > > Here goes

Re: [PATCH] drm/amdkfd: dqm fence memory corruption

2021-01-27 Thread Felix Kuehling
Am 2021-01-27 um 7:33 a.m. schrieb Qu Huang: > Amdgpu driver uses 4-byte data type as DQM fence memory, > and transmits GPU address of fence memory to microcode > through query status PM4 message. However, query status > PM4 message definition and microcode processing are all > processed according

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 Andreas (icedragon...@web.de) changed: What|Removed |Added Kernel Version|5.10.10 |5.10.11 -- You may

[Bug 211425] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211425 --- Comment #1 from Andreas (icedragon...@web.de) --- Kernel 5.10.11 (mainline) issues still persist: [ 181.977478] [drm:atom_op_jump] *ERROR* atombios stuck in loop for more than 20secs aborting [ 181.977546]

Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD

2021-01-27 Thread Doug Anderson
Hi, On Mon, Jan 25, 2021 at 12:28 PM Stephen Boyd wrote: > > > +/* > > + * Some panels simply don't always come up and need to be power cycled to > > + * work properly. We'll allow for a handful of retries. > > + */ > > +#define MAX_PANEL_PREPARE_TRIES5 > > Is this define used

Re: [Intel-gfx] linux-next: Tree for Jan 27 (drm/i915)

2021-01-27 Thread Chris Wilson
Quoting Randy Dunlap (2021-01-27 20:28:05) > On 1/27/21 11:30 AM, Randy Dunlap wrote: > > On 1/27/21 11:08 AM, Randy Dunlap wrote: > >> On 1/27/21 6:44 AM, Stephen Rothwell wrote: > >>> Hi all, > >>> > >>> Note: the patch file has failed to upload :-( > >>> > >>> Changes since 20210125: > >>> > >>

Re: [GIT PULL] ib-drm-gpio-pdx86-rtc-wdt-v5.12-1

2021-01-27 Thread Hans de Goede
Hi, On 1/26/21 9:54 PM, Andy Shevchenko wrote: > On Tue, Jan 26, 2021 at 8:33 PM Hans de Goede wrote: >> On 1/26/21 6:14 PM, Andy Shevchenko wrote: >>> On Tue, Jan 26, 2021 at 6:55 PM Patrik Jakobsson >>> wrote: On Tue, Jan 26, 2021 at 4:51 PM Andy Shevchenko wrote: > On Tue, Jan

[PATCH v2] drm/lima: add governor data with pre-defined thresholds

2021-01-27 Thread Christian Hewitt
This patch adapts the panfrost pre-defined thresholds change [0] to the lima driver to improve real-world performance. The upthreshold value has been set to ramp GPU frequency to max freq faster (compared to panfrost) to compensate for the lower overall performance of utgard devices. [0]

Re: [PATCH] drm/lima: add governor data with pre-defined thresholds

2021-01-27 Thread Christian Hewitt
> On 27 Jan 2021, at 3:11 pm, Lukasz Luba wrote: > > On 1/27/21 10:24 AM, Lukasz Luba wrote: >> Hi Christian, >> On 1/25/21 8:18 AM, Christian Hewitt wrote: >>> This patch adapts the panfrost pre-defined thresholds change [0] to the >>> lima driver to improve real-world performance. The

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
> Comments are the exception to the "no spaces at the start of a line" > rule. I was expecting that the kbuild-bot would send a Smatch warning > for inconsistent indenting, but comments are not counted there either. > > I'm sort of surprised that we don't have checkpatch rule about the > missing

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Joe Perches
On Wed, 2021-01-27 at 17:49 +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > Andy and Joe, there's something wrong here that is missing the fact that > > a line is being indented with spaces and not tabs in the patch > > at > >

Re: [PATCH] drm/komeda: Fix bit check to import to value of proper type

2021-01-27 Thread Steven Price
NIT: This is the second version of this patch so should have "[PATCH v2]" in the subject. On 27/01/2021 12:34, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Another issue found by KASAN. The bit finding is buried inside the dp_for_each_set_bit() macro (that passes on to

Re: [PATCH] drm/ttm: stop using GFP_TRANSHUGE_LIGHT

2021-01-27 Thread Michel Dänzer
On 2021-01-13 2:13 p.m., Christian König wrote: The only flag we really need is __GFP_NOMEMALLOC, highmem depends on dma32 and moveable/compound should never be set in the first place. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_pool.c | 11 ++- 1 file changed, 6

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #17 from bola...@163.com --- (In reply to Alex Deucher from comment #16) > (In reply to bolando from comment #15) > > (In reply to Michel Dänzer from comment #14) > > > > If enable 64bit kernel support,I need to recompile everything

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #16 from Alex Deucher (alexdeuc...@gmail.com) --- (In reply to bolando from comment #15) > (In reply to Michel Dänzer from comment #14) > > > If enable 64bit kernel support,I need to recompile everything on LFS10.0 > in > > > next

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 05:49:46PM +0300, Dan Carpenter wrote: > On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 15:13:05 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Jan 27, 2021 at 10:08:09PM

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Dan Carpenter
On Wed, Jan 27, 2021 at 03:25:20PM +0100, Greg KH wrote: > On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > > On Wed, 27 Jan 2021 15:13:05 +0100 > > Greg KH wrote: > > > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > > Greg

Re: [PATCH v4 01/14] drm/ttm: Remap all page faults to per process dummy page.

2021-01-27 Thread Andrey Grodzovsky
Hey Daniel, just a ping. Andrey On 1/25/21 10:28 AM, Andrey Grodzovsky wrote: On 1/19/21 8:56 AM, Daniel Vetter wrote: On Mon, Jan 18, 2021 at 04:01:10PM -0500, Andrey Grodzovsky wrote: On device removal reroute all CPU mappings to dummy page. v3: Remove loop to find DRM file and instead

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:17:08PM +0800, carlis wrote: > On Wed, 27 Jan 2021 15:13:05 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > > > On Wed, 27 Jan 2021 14:51:55 +0100 > > > Greg KH wrote: > > > > > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800,

Re: [PATCH v2] drm/omap: dsi: fix unreachable code in dsi_vc_send_short()

2021-01-27 Thread Tomi Valkeinen
On 27/01/2021 03:51, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The 'r' in dsi_vc_send_short() is of type 'unsigned int', so the > 'r < 0' can't be true. > > Fix this by introducing a 'err' of type 'int' insteaded. > > Fixes: 1ed6253856cb ("drm/omap: dsi: switch

Re: [PATCH v11] staging: fbtft: add tearing signal detect

2021-01-27 Thread Geert Uytterhoeven
Hi Carlis, On Wed, Jan 27, 2021 at 3:07 PM Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi > --- > v11: remove devm_gpio_put and change a

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:08:09PM +0800, carlis wrote: > On Wed, 27 Jan 2021 14:51:55 +0100 > Greg KH wrote: > > > On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > > > From: zhangxuezhi > > > > > > For st7789v ic,when we need continuous full screen refresh, it is > > > best to wait

[PULL] drm-intel-next

2021-01-27 Thread Rodrigo Vivi
Hi Dave and Daniel, Hopefully this is the last pull request towards 5.12. Please notice this contains a drm/framebuffer change needed for supporting clear color support for TGL Render Decompression. Here goes drm-intel-next-2021-01-27: - HDCP 2.2 and HDCP 1.4 Gen12 DP MST support (Anshuman) -

Re: [PATCH v11] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 10:02:29PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi Again, slow down, and wait for comments before

[Bug 211349] IB test failed on sdma0 ! AMDGPU driver for Raven APU (ryzen 2400G) hangs!

2021-01-27 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=211349 --- Comment #15 from bola...@163.com --- (In reply to Michel Dänzer from comment #14) > > If enable 64bit kernel support,I need to recompile everything on LFS10.0 in > > next weeks. > > You shouldn't. 32-bit user-space works fine with a 64-bit

[PATCH] drm/vboxvideo: Vmap/vunmap cursor BO in prepare_fb and cleanup_fb

2021-01-27 Thread Thomas Zimmermann
Functions in the atomic commit tail are not allowed to acquire the dmabuf's reservation lock. So we cannot legally call the GEM object's vmap functionality in atomic_update. Instead vmap the cursor BO in prepare_fb and vunmap it in cleanup_fb. The cursor plane state stores the mapping's address.

Re: [PATCH v10] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 09:42:52PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,when we need continuous full screen refresh, it is best to > wait for the TE signal arrive to avoid screen tearing > > Signed-off-by: zhangxuezhi Please slow down and wait at least a day between

Re: [PATCH 13/13] module: remove EXPORY_UNUSED_SYMBOL*

2021-01-27 Thread Jessica Yu
+++ Christoph Hellwig [21/01/21 08:49 +0100]: EXPORT_UNUSED_SYMBOL* is not actually used anywhere. Remove the unused functionality as we generally just remove unused code anyway. Signed-off-by: Christoph Hellwig --- arch/arm/configs/bcm2835_defconfig | 1 -

Re: [PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread Geert Uytterhoeven
Hi Carlis, On Wed, Jan 27, 2021 at 2:03 PM Carlis wrote: > From: zhangxuezhi > > For st7789v ic,add tearing signal detect to avoid screen tearing > > Signed-off-by: zhangxuezhi > --- > v9: change pr_* to dev_* Thanks for the update! > --- a/drivers/staging/fbtft/fb_st7789v.c > +++

Re: [PATCH 10/12] drm/ast: Fix cursor BO pinning and mapping

2021-01-27 Thread Thomas Zimmermann
Am 27.01.21 um 13:03 schrieb Thomas Zimmermann: GEM vmap operations are not allowed in commit tail. Therefore, we cannot map the cursor source BO in atomic_update. Instead do this in prepare_fb. There was no pin operation for the BO, so add this as well. Reviewing drm_gem_vram_vmap() I saw

Re: [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev

2021-01-27 Thread Thomas Zimmermann
Hi Am 27.01.21 um 13:52 schrieb Chris Wilson: Quoting Thomas Zimmermann (2021-01-27 12:41:31) diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c b/drivers/gpu/drm/i915/selftests/mock_gem_device.c index 0188f877cab2..2a07a008de2e 100644 ---

Re: [PATCH v9] staging: fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 08:57:37PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,add tearing signal detect to avoid screen tearing I need a much better changelog description here please. > > Signed-off-by: zhangxuezhi > --- > v9: change pr_* to dev_* > --- What changed in all

Re: [Intel-gfx] [PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev

2021-01-27 Thread Chris Wilson
Quoting Thomas Zimmermann (2021-01-27 12:41:34) > Using struct drm_device.pdev is deprecated. Don't assign it. Users > should upcast from struct drm_device.dev. > > Signed-off-by: Thomas Zimmermann > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > --- >

Re: [PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev

2021-01-27 Thread Chris Wilson
Quoting Thomas Zimmermann (2021-01-27 12:41:31) > diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > b/drivers/gpu/drm/i915/selftests/mock_gem_device.c > index 0188f877cab2..2a07a008de2e 100644 > --- a/drivers/gpu/drm/i915/selftests/mock_gem_device.c > +++

[PATCH v5 4/5] drm/i915: Don't assign to struct drm_device.pdev

2021-01-27 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Don't assign it. Users should upcast from struct drm_device.dev. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v5 3/5] drm/i915/gvt: Remove references to struct drm_device.pdev

2021-01-27 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/gvt/cfg_space.c | 5 +++-- drivers/gpu/drm/i915/gvt/firmware.c | 10

[PATCH v5 5/5] drm: Move struct drm_device.pdev to legacy section

2021-01-27 Thread Thomas Zimmermann
Struct drm_device.pdev is being moved to legacy status as only legacy DRM drivers use it. A possible follow-up patchset could remove pdev entirely. v4: * rebased Signed-off-by: Thomas Zimmermann Acked-by: Sam Ravnborg --- include/drm/drm_device.h | 6 +++--- 1 file changed, 3

[PATCH v5 2/5] drm/i915/gt: Remove references to struct drm_device.pdev

2021-01-27 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. Signed-off-by: Thomas Zimmermann Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_ggtt.c |

[PATCH v5 0/5] drm: Move struct drm_device.pdev to legacy

2021-01-27 Thread Thomas Zimmermann
For v5, I moved the non-assignment of pdev in i915 into a separate patch as suggested by Chris. Hopefully, this will help with merging the patches into the rsp i915 trees. The core and vmwgfx changes have been merged into drm-tip already. The pdev field in struct drm_device points to a PCI device

[PATCH v5 1/5] drm/i915: Remove references to struct drm_device.pdev

2021-01-27 Thread Thomas Zimmermann
Using struct drm_device.pdev is deprecated. Convert i915 to struct drm_device.dev. No functional changes. v5: * remove assignment in later patch (Chris) v3: * rebased v2: * move gt/ and gvt/ changes into separate patches Signed-off-by: Thomas Zimmermann Cc: Jani Nikula

Re: [PATCH] drm/komeda: Fix bit check to import to value of proper type

2021-01-27 Thread Carsten Haitzler
On 1/20/21 3:44 PM, Steven Price wrote: Sent a new patch to list with updates as discussed. On 18/01/2021 14:20, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Another issue found by KASAN. The bit finding is bueried inside the NIT: s/bueried/buried/ dp_for_each_set_bit()

[PATCH] drm/komeda: Fix bit check to import to value of proper type

2021-01-27 Thread carsten . haitzler
From: Carsten Haitzler Another issue found by KASAN. The bit finding is buried inside the dp_for_each_set_bit() macro (that passes on to for_each_set_bit() that calls the bit stuff. These bit functions want an unsigned long pointer as input and just dumbly casting leads to out-of-bounds

[PATCH] procfs/dmabuf: Add /proc//task//dmabuf_fds

2021-01-27 Thread Kalesh Singh
In order to measure how much memory a process actually consumes, it is necessary to include the DMA buffer sizes for that process in the memory accounting. Since the handle to DMA buffers are raw FDs, it is important to be able to identify which processes have FD references to a DMA buffer.

[PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-27 Thread Hridya Valsaraju
This patch allows statistics to be enabled for each DMA-BUF in sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. The following stats will be exposed by the interface: /sys/kernel/dmabuf/buffers//exporter_name /sys/kernel/dmabuf/buffers//size /sys/kernel/dmabuf/buffers//attachments//device

Re: [PATCH v8] fbtft: add tearing signal detect

2021-01-27 Thread Greg KH
On Wed, Jan 27, 2021 at 06:26:46PM +0800, Carlis wrote: > From: zhangxuezhi > > For st7789v ic,add tearing signal detect to avoid screen tearing > > Signed-off-by: zhangxuezhi > --- > v8: delete a log line > --- > drivers/staging/fbtft/fb_st7789v.c | 132 >

Re: [PATCH v1 2/2] mm: simplify free_highmem_page() and free_reserved_page()

2021-01-27 Thread David Hildenbrand
On 27.01.21 12:51, Oscar Salvador wrote: On Tue, Jan 26, 2021 at 07:21:13PM +0100, David Hildenbrand wrote: adjust_managed_page_count() as called by free_reserved_page() properly handles pages in a highmem zone, so we can reuse it for free_highmem_page(). We can now get rid of

Re: [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-01-27 Thread Christian König
Am 27.01.21 um 13:11 schrieb Maarten Lankhorst: Op 27-01-2021 om 01:22 schreef Felix Kuehling: Am 2021-01-21 um 2:40 p.m. schrieb Daniel Vetter: Recently there was a fairly long thread about recoreable hardware page faults, how they can deadlock, and what to do about that. While the

Re: [PATCH] RFC: dma-fence: Document recoverable page fault implications

2021-01-27 Thread Maarten Lankhorst
Op 27-01-2021 om 01:22 schreef Felix Kuehling: > Am 2021-01-21 um 2:40 p.m. schrieb Daniel Vetter: >> Recently there was a fairly long thread about recoreable hardware page >> faults, how they can deadlock, and what to do about that. >> >> While the discussion is still fresh I figured good time to

Re: [PATCH v4 04/13] drm/shmem-helper: Provide a vmap function for short-term mappings

2021-01-27 Thread Thomas Zimmermann
Hi Am 11.01.21 um 17:50 schrieb Daniel Vetter: On Fri, Jan 08, 2021 at 10:43:31AM +0100, Thomas Zimmermann wrote: Implementations of the vmap/vunmap GEM callbacks may perform pinning of the BO and may acquire the associated reservation object's lock. Callers that only require a mapping of the

Re: [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-27 Thread Greg KH
On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > This patch allows statistics to be enabled for each DMA-BUF in > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > The following stats will be exposed by the interface: > > /sys/kernel/dmabuf/buffers//exporter_name >

[PATCH 07/12] drm/ast: Store cursor BOs in cursor plane

2021-01-27 Thread Thomas Zimmermann
The cursor uses two BOs in video RAM to implement double buffering. Store both in struct ast_cursor_plane. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 11 ++- drivers/gpu/drm/ast/ast_mode.c | 27 +++ 2 files changed, 21 insertions(+), 17

[PATCH 12/12] drm/ast: Store each HW cursor offset after pinning the rsp BO

2021-01-27 Thread Thomas Zimmermann
As HW cursor BOs never move, we can store the offset in VRAM in the cursor-plane's HWC state. This removes the last possible source of runtime errors from atomic_update. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 1 + drivers/gpu/drm/ast/ast_mode.c | 19

[PATCH 06/12] drm/ast: Add cursor-plane data structure

2021-01-27 Thread Thomas Zimmermann
Cursor state is currently located throughout struct ast_private. Having struct ast_cursor_plane as dedicated data structure for cursors helps to organize the modesetting code. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_drv.h | 23 ++-

[PATCH 10/12] drm/ast: Fix cursor BO pinning and mapping

2021-01-27 Thread Thomas Zimmermann
GEM vmap operations are not allowed in commit tail. Therefore, we cannot map the cursor source BO in atomic_update. Instead do this in prepare_fb. There was no pin operation for the BO, so add this as well. Hence the cursor source BO is now mapped while it's being displayed. The change will allow

Re: [PATCH v3 4/5] amba: Make the remove callback return void

2021-01-27 Thread Greg Kroah-Hartman
On Tue, Jan 26, 2021 at 05:58:34PM +0100, Uwe Kleine-König wrote: > All amba drivers return 0 in their remove callback. Together with the > driver core ignoring the return value anyhow, it doesn't make sense to > return a value here. > > Change the remove prototype to return void, which makes it

[PATCH 01/12] drm/ast: Add constants for VGACRCB register bits

2021-01-27 Thread Thomas Zimmermann
Set the bits in VGACRCB with constants. Alo move the rsp code into a helper function. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 21 +++-- drivers/gpu/drm/ast/ast_drv.h| 3 +++ 2 files changed, 18 insertions(+), 6 deletions(-) diff --git

[PATCH 05/12] drm/ast: Inline ast cursor-update functions into modesetting code

2021-01-27 Thread Thomas Zimmermann
The logic for cursor updates is now located in the cursor plane's modesetting code. A number of helper functions remain to modify the rsp registers and image. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/Makefile | 3 +- drivers/gpu/drm/ast/ast_cursor.c | 237

[PATCH 08/12] drm/ast: Map HW cursor BOs permanently

2021-01-27 Thread Thomas Zimmermann
The BOs of the hardware cursor are now mapped permanently while the cursor plane is being used. This reduces the CPU overhead of the cursor plane's atomic_update function. The change also resolves a problem with the vmap call in the commit tail. The vmap implementation could acquire the DMA

[PATCH 02/12] drm/ast: Fix invalid usage of AST_MAX_HWC_WIDTH in cursor atomic_check

2021-01-27 Thread Thomas Zimmermann
Use AST_MAX_HWC_HEIGHT for setting offset_y in the cursor plane's atomic_check. The code used AST_MAX_HWC_WIDTH instead. This worked because both constants has the same value. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 03/12] drm/ast: Initialize planes in helper functions

2021-01-27 Thread Thomas Zimmermann
This change will help with inlining cursor functions into modesetting code. The primary plane's field used to be cleared with memset(). This has been dropped as the memory is always allocated with kzalloc(). Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 66

[PATCH 04/12] drm/ast: Allocate HW cursor BOs during cursor-plane initialization

2021-01-27 Thread Thomas Zimmermann
The BOs are eventually released by the cursor plane's destroy callback. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_cursor.c | 58 -- drivers/gpu/drm/ast/ast_drv.h| 1 - drivers/gpu/drm/ast/ast_mode.c | 62 3

[PATCH 11/12] drm/ast: Move all of the cursor-update functionality to atomic_update

2021-01-27 Thread Thomas Zimmermann
We used to update the cursor image in prepare_fb. Move all this code to atomic_update (were it belongs). Prepare_fb only prepares the source BO. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 56 +- 1 file changed, 28 insertions(+), 28

[PATCH 09/12] drm/ast: Introduce dedicated cursor-plane state

2021-01-27 Thread Thomas Zimmermann
The cursor-plane state struct ast_cursor_plane_state will store the involved cursor source BO's mapping into kernel address space. Signed-off-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 40 -- 1 file changed, 38 insertions(+), 2 deletions(-) diff

[PATCH 00/12] drm/ast: Move cursor vmap calls out of commit tail

2021-01-27 Thread Thomas Zimmermann
Ast has vmap calls in its cursor's atomic_update function. This is not supported as vmap might aquire the dma reservation lock. While at it, cleanup the whole cursor code: the patchset removes all possible runtime errors from the atomic_update function and reduces the overhead from vmap calls on

Re: [PATCH] procfs/dmabuf: Add /proc//task//dmabuf_fds

2021-01-27 Thread Christian König
Am 27.01.21 um 12:02 schrieb Michal Hocko: On Wed 27-01-21 11:53:55, Christian König wrote: [...] In general processes are currently not held accountable for memory they reference through their file descriptors. DMA-buf is just one special case. True In other words you can currently do

  1   2   >