[PATCH] drivers: gpu: drm: xen_drm_front_drm_info is declared twice

2021-03-24 Thread Wan Jiabing
struct xen_drm_front_drm_info has been declared. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/xen/xen_drm_front_conn.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/xen/xen_drm_front_conn.h b/drivers/gpu/drm/xen/xen_drm_front_conn.h index 3adacba9a2

RE: [PATCH 15/17] iommu: remove DOMAIN_ATTR_NESTING

2021-03-24 Thread Tian, Kevin
> From: Auger Eric > Sent: Monday, March 15, 2021 3:52 PM > To: Christoph Hellwig > Cc: k...@vger.kernel.org; Will Deacon ; linuxppc- > d...@lists.ozlabs.org; dri-devel@lists.freedesktop.org; Li Yang > ; io...@lists.linux-foundation.org; > > Hi Christoph, > > On 3/14/21 4:58 PM, Christoph Hellwi

[PATCH] drivers: gpu: drm: Remove repeated declaration

2021-03-24 Thread Wan Jiabing
struct drm_i915_private, struct intel_crtc_state and struct intel_crtc have been declared before. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/i915/display/intel_crt.h | 1 - drivers/gpu/drm/i915/display/intel_display.h | 1 - drivers/gpu/drm/i915/display/intel_vrr.h

[PATCH] drivers: gpu: drm: Remove duplicate declaration

2021-03-24 Thread Wan Jiabing
struct dss_device has been declared at 51st line. Remove the duplicate. Signed-off-by: Wan Jiabing --- drivers/gpu/drm/omapdrm/dss/omapdss.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/omapdrm/dss/omapdss.h index a40abeafd2e9..2658

Re: [PATCH v2] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-24 Thread Stephen Boyd
10.779212] [00000080] pgd=080123475003, p4d=080123475003, pud=080123475003, pmd= [ 10.790128] Internal error: Oops: 9606 [#1] PREEMPT SMP [ 10.795856] Modules linked in: ath10k_snoc qmi_helpers ath10k_core ath mac80211 cfg80211 r8152 mii joydev [

Re: [PATCH v2] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-24 Thread Rob Clark
On Wed, Mar 24, 2021 at 6:49 PM Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2021-03-18 13:05:44) > > if GPU components have failed to bind, shutdown callback would fail with > > the following backtrace. Add safeguard check to stop that oops from > > happening and allow the board to reboot. >

Re: [PATCH 2/2] drm/doc: Add RFC section

2021-03-24 Thread Jason Ekstrand
Acked-by: Jason Ekstrand On March 24, 2021 16:10:48 Daniel Vetter wrote: Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser Cc: Jani

[PATCH] include: linux: host1x: Remove duplicate declaration

2021-03-24 Thread Wan Jiabing
struct host1x is declared at 20th line. Remove the duplicate. Signed-off-by: Wan Jiabing --- include/linux/host1x.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/host1x.h b/include/linux/host1x.h index ce59a6a6a008..462f0bc7a703 100644 --- a/include/linux/host1x.h +++ b/includ

Re: [PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Liu Ying
On Wed, 2021-03-24 at 17:47 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > about out of bounds array access: > > drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': > drivers/gpu/drm/imx/imx-ldb

Re: [PATCH v2] gpu/drm/msm: fix shutdown hook in case GPU components failed to bind

2021-03-24 Thread Stephen Boyd
Quoting Dmitry Baryshkov (2021-03-18 13:05:44) > if GPU components have failed to bind, shutdown callback would fail with > the following backtrace. Add safeguard check to stop that oops from > happening and allow the board to reboot. [...] > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu

[PATCH 2/2] drm/msm: Add param for userspace to query suspend count

2021-03-24 Thread Rob Clark
From: Rob Clark Performance counts, and ALWAYS_ON counters used for capturing GPU timestamps, lose their state across suspend/resume cycles. Userspace tooling for performance monitoring needs to be aware of this. For example, after a suspend userspace needs to recalibrate it's offset between CP

[PATCH 1/2] drm/msm: Fix a5xx/a6xx timestamps

2021-03-24 Thread Rob Clark
From: Rob Clark They were reading a counter that was configured to ALWAYS_COUNT (ie. cycles that the GPU is doing something) rather than ALWAYS_ON. This isn't the thing that userspace is looking for. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- drivers/gpu/drm/

[PATCH 0/2] drm/msm: Fixes/updates for perfetto profiling

2021-03-24 Thread Rob Clark
From: Rob Clark A couple kernel side things I realized I needed in the process of implementing performance-counter and render-stage support for perfetto, the first patch fixes the MSM_PARAM_TIMESTAMP query which was just wrong on a5xx/a6xx (ALWAYS_COUNT vs ALWAYS_ON). The second adds a way for u

[Bug 212427] [AMDGPU] Multiple ttm_bo_release warnings

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212427 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

[PULL] nouveau-fixes 5.12

2021-03-24 Thread Ben Skeggs
Single regression fix. Thanks, Ben. The following changes since commit d27ce83fa4baa5cb908a42e9878564cad6ea0eb3: Merge tag 'du-fixes-20210316' of git://linuxtv.org/pinchartl/media into drm-fixes (2021-03-22 13:49:55 +1000) are available in the Git repository at: git://github.com/skeggsb/li

[Bug 212425] Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 Erhard F. (erhar...@mailbox.org) changed: What|Removed |Added CC||erhar...@mailbox.org -

Re: [PATCH V2] drm/radeon/r600_cs: Few typo fixes

2021-03-24 Thread Randy Dunlap
On 3/24/21 4:29 PM, Bhaskar Chowdhury wrote: > s/miror/mirror/ > s/needind/needing/ > s/informations/information/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap Thanks. > --- > Changes from V1: > Randy's finding incorporated ,i.e in one place,informations->information > Adjus

Re: [Nouveau] [PATCH] drm/nouveau/kms/nv04: use vzalloc for nv04_display

2021-03-24 Thread Ben Skeggs
On Mon, 8 Mar 2021 at 03:49, Ilia Mirkin wrote: > > The struct is giant, and triggers an order-7 allocation (512K). There is > no reason for this to be kmalloc-type memory, so switch to vmalloc. This > should help loading nouveau on low-memory and/or long-running systems. > > Reported-by: Nathan E

Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes

2021-03-24 Thread Bhaskar Chowdhury
On 14:48 Wed 24 Mar 2021, Randy Dunlap wrote: On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote: s/miror/mirror/ s/needind/needing/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r

[PATCH V2] drm/radeon/r600_cs: Few typo fixes

2021-03-24 Thread Bhaskar Chowdhury
s/miror/mirror/ s/needind/needing/ s/informations/information/ Signed-off-by: Bhaskar Chowdhury --- Changes from V1: Randy's finding incorporated ,i.e in one place,informations->information Adjusted the subject line accordingly drivers/gpu/drm/radeon/r600_cs.c | 6 +++--- 1 file changed, 3

Re: [PATCH] nouveau/nvkm/subdev/devinit/mcp89.c:Unneeded variable

2021-03-24 Thread Ben Skeggs
On Wed, 17 Mar 2021 at 19:51, ChunyouTang wrote: > > From: tangchunyou > > disable,delete disable and return 0 > > Signed-off-by: tangchunyou Thanks! > --- > drivers/gpu/drm/nouveau/nvkm/subdev/devinit/mcp89.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/g

Re: [PATCH v2] drm/nouveau/kms/nv50-: Correct size checks for cursors

2021-03-24 Thread Ben Skeggs
On Fri, 19 Mar 2021 at 09:04, Lyude Paul wrote: > > Found this while trying to make some changes to the kms_cursor_crc test. > curs507a_acquire checks that the width and height of the cursor framebuffer > are equal (asyw->image.{w,h}). This isn't entirely correct though, as the > height of the cur

Re: [Nouveau] [PATCH -next] drm/nouveau/core/client: Mark nvkm_uclient_sclass with static keyword

2021-03-24 Thread Ben Skeggs
On Tue, 23 Mar 2021 at 17:03, Zou Wei wrote: > > Fix the following sparse warning: > > drivers/gpu/drm/nouveau/nvkm/core/client.c:64:1: warning: symbol > 'nvkm_uclient_sclass' was not declared. Should it be static? > > Signed-off-by: Zou Wei Applied, thanks. > --- > drivers/gpu/drm/nouveau/nvk

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 09:07:53PM +0100, Thomas Hellström (Intel) wrote: > > On 3/24/21 7:31 PM, Christian König wrote: > > > > > > Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: > > > On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) > > > wrote: > > > > On 3/24/21 2:48 PM, Jas

[Bug 212427] [AMDGPU] Multiple ttm_bo_release warnings

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212427 Chris Rankin (ranki...@yahoo.com) changed: What|Removed |Added Regression|No |Yes --- Comment #1 fr

Re: [RFC PATCH 11/11] drm/bridge: ti-sn65dsi86: Support hotplug detection

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > When the SN65DSI86 is used in DisplayPort mode, its output is likely > routed to a DisplayPort connector, which can benefit from hotplug > detection. Support it in such cases, with polling mode only for now. > > The implementation is

Re: [RFC PATCH 10/11] drm/bridge: ti-sn65dsi86: Support DisplayPort (non-eDP) mode

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Despite the SN65DSI86 being an eDP bridge, on some systems its output is > routed to a DisplayPort connector. Enable DisplayPort mode when the next > component in the display pipeline is not a panel, and disable eDP > features in tha

Re: [RFC PATCH 08/11] drm/bridge: ti-sn65dsi86: Implement bridge connector operations

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Implement the bridge connector-related .get_edid() operation, and report > the related bridge capabilities and type. The .get_edid() operation is > implemented with the same backend as the EDID retrieval from the > connector .get_mod

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 23:36 +0100, Rasmus Villemoes wrote: > On 24/03/2021 23.18, Joe Perches wrote: > > There's no silly game here. %pe would either print a string or a value. > > A hashed value, that is, never the raw value. There is value in printing the raw value. As discussed, it can simpli

[Bug 212427] New: [AMDGPU] Multiple ttm_bo_release warnings

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212427 Bug ID: 212427 Summary: [AMDGPU] Multiple ttm_bo_release warnings Product: Drivers Version: 2.5 Kernel Version: 5.11.9 Hardware: x86-64 OS: Linux Tree: Mainli

Re: [RFC PATCH 07/11] drm/bridge: ti-sn65dsi86: Split connector creation to a function

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > To prepare for making connector creation option, move connector creation > out of ti_sn_bridge_attach to a separate function. > > No functional change intended. > > Signed-off-by: Laurent Pinchart > --- > drivers/gpu/drm/bridge/ti-

Re: [RFC PATCH 06/11] drm/bridge: ti-sn65dsi86: Group code in sections

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > Reorganize the functions in sections, related to connector operations, > bridge operations, AUX adapter, GPIO controller and probe & remove. > > This prepares for proper support of DRM_BRIDGE_ATTACH_NO_CONNECTOR that > will add more

Re: [RFC PATCH 05/11] drm/bridge: ti-sn65dsi86: Wrap panel with panel-bridge

2021-03-24 Thread Doug Anderson
Hi, On Sun, Mar 21, 2021 at 8:02 PM Laurent Pinchart wrote: > > To simplify interfacing with the panel, wrap it in a panel-bridge and > let the DRM bridge helpers handle chaining of operations. > > This also prepares for support of DRM_BRIDGE_ATTACH_NO_CONNECTOR, which > requires all components i

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 23.18, Joe Perches wrote: > On Wed, 2021-03-24 at 22:27 +0100, Rasmus Villemoes wrote: >> On 24/03/2021 20.24, Joe Perches wrote: >>> On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: On 24/03/2021 18.20, Joe Perches wrote: > > Maybe it's better to output no

linux-next: build warning after merge of the drm-intel-fixes tree

2021-03-24 Thread Stephen Rothwell
Hi all, After merging the drm-intel-fixes tree, today's linux-next build (htmldocs) produced this warning: Documentation/gpu/i915:22: /home/sfr/next/next/drivers/gpu/drm/i915/intel_runtime_pm.c:423: WARNING: Inline strong start-string without end-string. Introduced by commit 8840e3bd981f ("

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 22:27 +0100, Rasmus Villemoes wrote: > On 24/03/2021 20.24, Joe Perches wrote: > > On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: > > > On 24/03/2021 18.20, Joe Perches wrote: > > > > > > > > > > > Maybe it's better to output non PTR_ERR %pe uses as decimal so th

Re: [PATCH] drm/vkms: fix misuse of WARN_ON

2021-03-24 Thread Melissa Wen
On 03/20, Dmitry Vyukov wrote: > vkms_vblank_simulate() uses WARN_ON for timing-dependent condition > (timer overrun). This is a mis-use of WARN_ON, WARN_ON must be used > to denote kernel bugs. Use pr_warn() instead. > > Signed-off-by: Dmitry Vyukov > Reported-by: syzbot+4fc21a003c8332eb0...@syz

Re: [PATCH] drm/radeon/r600_cs: Couple of typo fixes

2021-03-24 Thread Randy Dunlap
On 3/24/21 6:50 AM, Bhaskar Chowdhury wrote: > > s/miror/mirror/ > s/needind/needing/ > > Signed-off-by: Bhaskar Chowdhury > --- > drivers/gpu/drm/radeon/r600_cs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/r600_cs.c > b/drivers/gpu/drm

Re: [PATCH] drm/nouveau/bios/init: A typo fix

2021-03-24 Thread Randy Dunlap
On 3/23/21 11:34 PM, Bhaskar Chowdhury wrote: > > s/conditon/condition/ > > Signed-off-by: Bhaskar Chowdhury Acked-by: Randy Dunlap > --- > drivers/gpu/drm/nouveau/nvkm/subdev/bios/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/nouveau/nvkm/s

[Bug 212077] AMD GPU discrete card memory at highest frequency even while not in use

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212077 --- Comment #13 from Alex Deucher (alexdeuc...@gmail.com) --- Created attachment 296035 --> https://bugzilla.kernel.org/attachment.cgi?id=296035&action=edit possible fix This patch should fix it. -- You may reply to this email to add a commen

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 20.24, Joe Perches wrote: > On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: >> On 24/03/2021 18.20, Joe Perches wrote: >> >>> >>> Maybe it's better to output non PTR_ERR %pe uses as decimal so this >>> sort of code would work. >> >> No, because that would leak the pointer v

[PATCH 2/2] drm/doc: Add RFC section

2021-03-24 Thread Daniel Vetter
Motivated by the pre-review process for i915 gem/gt features, but probably useful in general for complex stuff. v2: Add reminder to not forget userspace projects in the discussion (Simon, Jason) Cc: Simon Ser Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Jason Ekstrand Cc: Dave Ai

[PATCH 1/2] drm/i915: add gem/gt TODO

2021-03-24 Thread Daniel Vetter
We've discussed a bit how to get the gem/gt team better integrated and collaborate more with the wider community and agreed to the following: - all gem/gt patches are reviewed on dri-devel for now. That's overkill, but in the past there was definitely too little of that. - i915-gem folks are en

[pull] amdgpu drm-fixes-5.12

2021-03-24 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.12. The following changes since commit d27ce83fa4baa5cb908a42e9878564cad6ea0eb3: Merge tag 'du-fixes-20210316' of git://linuxtv.org/pinchartl/media into drm-fixes (2021-03-22 13:49:55 +1000) are available in the Git repository at: https://gitlab.freedesktop.or

[Bug 212397] Resume from suspend (S3) does not bring back video anymore

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212397 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Dave Hansen
On 3/24/21 1:22 PM, Thomas Hellström (Intel) wrote: >> We also have not been careful at *all* about how _PAGE_BIT_SOFTW* are >> used.  It's quite possible we can encode another use even in the >> existing bits. >> >> Personally, I'd just try: >> >> #define _PAGE_BIT_SOFTW5    57  /* availab

Re: [PATCH] drm/amd/display: Try YCbCr420 color when YCbCr444 fails

2021-03-24 Thread Alex Deucher
On Wed, Mar 17, 2021 at 11:25 AM Werner Sembach wrote: > > When encoder validation of a display mode fails, retry with less bandwidth > heavy YCbCr420 color mode, if available. This enables some HDMI 1.4 setups > to support 4k60Hz output, which previously failed silently. > > On some setups, whil

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 5:34 PM, Dave Hansen wrote: On 3/24/21 3:05 AM, Thomas Hellström (Intel) wrote: Yes, I agree. Seems like the special (SW1) is available also for huge page table entries on x86 AFAICT, although just not implemented. Otherwise the SW bits appear completely used up. Although the _PAGE_

Re: [PATCH 21/21] drm/msm/dpu: call hw_intr ops directly

2021-03-24 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.12-rc4 next-20210324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

[PATCH v2] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Mark Yacoub
From: Mark Yacoub On initializing the framebuffer, call drm_any_plane_has_format to do a check if the modifier is supported. drm_any_plane_has_format calls dm_plane_format_mod_supported which is extended to validate that the modifier is on the list of the plane's supported modifiers. The bug was

[Bug 212425] Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 Alex Deucher (alexdeuc...@gmail.com) changed: What|Removed |Added CC||alexdeuc...@gmail.c

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 7:31 PM, Christian König wrote: Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 2:48 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 02:35:38PM +0100, Thomas Hellström (Intel) wrote: In an ide

[PATCH 0/4] drm/i915: missing workarounds and refactors

2021-03-24 Thread Lucas De Marchi
Missing WAs and related refactors. Caz Yokoyama (2): drm/i915/gen12: Add recommended hardware tuning value drm/i915/icl: add Wa_22010271021 for all gen11 José Roberto de Souza (1): drm/i915: Move Wa_16011163337 to gen12_ctx_workarounds_init() Swathi Dhanavanthri (1): drm/i915: Add Wa_140

[PATCH 1/4] drm/i915/gen12: Add recommended hardware tuning value

2021-03-24 Thread Lucas De Marchi
From: Caz Yokoyama Follow Bspec 31870 to set recommended tuning values for certain GT register. These values aren't workarounds per-se, but it's best to handle them in the same general area of the driver, especially since there may be real workarounds that update other bits of the same registers

[PATCH 2/4] drm/i915/icl: add Wa_22010271021 for all gen11

2021-03-24 Thread Lucas De Marchi
From: Caz Yokoyama Wa_22010271021 does not apply only to EHL, but to all gen11 and other gen12 platforms. Gen12 is already covered in another code path, but we need to stop checking for EHL when handling gen11. Bspec: 33450, 52887 v2: Remove "gen11" suffix as it also applies to gen12 platforms

[PATCH 3/4] drm/i915: Move Wa_16011163337 to gen12_ctx_workarounds_init()

2021-03-24 Thread Lucas De Marchi
From: José Roberto de Souza This WA is needed in all gen12 platforms, moving it to gen12_ctx_workarounds_init() allow us to remove the duplicated implementation. Also allow us to remove the tgl_ctx_workarounds_init() that after the WA move above was empty. Signed-off-by: José Roberto de Souza R

[PATCH 4/4] drm/i915: Add Wa_14011060649

2021-03-24 Thread Lucas De Marchi
From: Swathi Dhanavanthri This is a permanent workaround for TGL,RKL,DG1 and ADLS. Signed-off-by: Swathi Dhanavanthri Reviewed-by: Lucas De Marchi --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 26 + drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed,

[Bug 212425] New: Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517

2021-03-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=212425 Bug ID: 212425 Summary: Kernel warning at drivers/gpu/drm/ttm/ttm_bo.c:517 Product: Drivers Version: 2.5 Kernel Version: 5.11.9 Hardware: x86-64 OS: Linux Tre

Re: [PATCH] dt-bindings: msm: Couple of spelling fixes

2021-03-24 Thread Rob Herring
On Sun, 21 Mar 2021 00:55:53 +0530, Bhaskar Chowdhury wrote: > > s/Subsytem/Subsystem/ > s/contoller/controller/ > > Signed-off-by: Bhaskar Chowdhury > --- > Documentation/devicetree/bindings/display/msm/dpu.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Applied, thanks! __

Re: [PATCH] dt-bindings: msm: Couple of spelling fixes

2021-03-24 Thread Rob Herring
On Sun, Mar 21, 2021 at 12:55:53AM +0530, Bhaskar Chowdhury wrote: > > s/Subsytem/Subsystem/ > s/contoller/controller/ Rather than worry about trivial fixes, please convert .txt bindings to DT schema instead. > > Signed-off-by: Bhaskar Chowdhury > --- > Documentation/devicetree/bindings/disp

Re: [PATCH] drm/ttm: switch back to static allocation limits for now

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 02:48:45PM +0100, Christian König wrote: > The shrinker based approach still has some flaws. Especially that we need > temporary pages to free up the pages allocated to the driver is problematic > in a shrinker. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/t

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 18:33 +0100, Rasmus Villemoes wrote: > On 24/03/2021 18.20, Joe Perches wrote: > > On Wed, 2021-03-24 at 09:52 -0700, Joe Perches wrote: > > > On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > > > > On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: > > > [] > > > > >

Re: [PATCH] drm/ttm: stop warning on TT shrinker failure

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 01:07:44PM +0100, Christian König wrote: > > > Am 24.03.21 um 13:01 schrieb Daniel Vetter: > > On Wed, Mar 24, 2021 at 01:00:28PM +0100, Christian König wrote: > > > Am 24.03.21 um 12:55 schrieb Daniel Vetter: > > > > On Wed, Mar 24, 2021 at 11:19:13AM +0100, Thomas Hellst

Re: [PATCH 3/3] mm: unexport follow_pfn

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 09:52:11AM -0300, Jason Gunthorpe wrote: > On Tue, Mar 16, 2021 at 04:33:03PM +0100, Daniel Vetter wrote: > > Both kvm (in bd2fae8da794 ("KVM: do not assume PTE is writable after > > follow_pfn")) and vfio (in 07956b6269d3 ("vfio/type1: Use > > follow_pte()")) have lost thei

[PATCH 1/2] drm/mediatek: Switch the hdmi bridge ops to the atomic versions

2021-03-24 Thread Dafna Hirschfeld
The bridge operation '.enable' and the audio cb '.get_eld' access hdmi->conn. In the future we will want to support the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR and then we will not have direct access to the connector. The atomic version '.atomic_enable' allows accessing the current connector from the s

[PATCH 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-24 Thread Dafna Hirschfeld
commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR while mtk_hdmi does not yet support this flag. Fix this by accepting DRM_BRIDGE_ATTACH_NO_CONNECTO

[PATCH 2/2] drm/mediatek: Don't support hdmi connector creation

2021-03-24 Thread Dafna Hirschfeld
commit f01195148967 ("drm/mediatek: mtk_dpi: Create connector for bridges") broke the display support for elm device since mtk_dpi calls drm_bridge_attach with the flag DRM_BRIDGE_ATTACH_NO_CONNECTOR while mtk_hdmi does not yet support this flag. These two patches fix that by adding support for DR

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Christian König
Am 24.03.21 um 17:38 schrieb Jason Gunthorpe: On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) wrote: On 3/24/21 2:48 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 02:35:38PM +0100, Thomas Hellström (Intel) wrote: In an ideal world the creation/destruction of page tab

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 06:16:44PM +0100, Daniel Vetter wrote: > On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > > We get a lockdep splat

Re: [PATCH 21/21] drm/msm/dpu: call hw_intr ops directly

2021-03-24 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.12-rc4 next-20210324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--bas

RE: [PATCH v2] video: hyperv_fb: Fix a double free in hvfb_probe

2021-03-24 Thread Michael Kelley
From: Lv Yunlong Sent: Wednesday, March 24, 2021 3:37 AM > > In function hvfb_probe in hyperv_fb.c, it calls hvfb_getmem(hdev, info) > and return err when info->apertures is freed. > > In the error1 label of hvfb_probe, info->apertures will be freed for the > second time in framebuffer_release(

[PATCH 00/25] Rid W=1 warnings from HID

2021-03-24 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. Lee Jones (25): HID: intel-ish-hid: Remove unused variable 'err' HID: ishtp-hid-client: Move variable to where it's actually used HID: intel-i

Re: [RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 18.20, Joe Perches wrote: > On Wed, 2021-03-24 at 09:52 -0700, Joe Perches wrote: >> On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: >>> On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: >> [] > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c >

Re: [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 05:30:24PM +0200, Jani Nikula wrote: > On Mon, 22 Mar 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc-11 warns about what appears to be an out-of-range array access: > > > > In function ‘snb_wm_latency_quirk’, > > inlined from ‘ilk_setup_wm_latency’ at

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Handle async cancellation in sentinel assert

2021-03-24 Thread Matthew Auld
On Wed, 24 Mar 2021 at 12:14, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > With the watchdog cancelling requests asynchronously to preempt-to-busy we > need to relax one assert making it apply only to requests not in error. > > v2: > * Check against the correct request! > > v3: > * Simpli

Re: [Intel-gfx] [PATCH v9 66/70] drm/i915: Add ww parameter to get_pages() callback

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:55PM +0100, Maarten Lankhorst wrote: > We will need this to support eviction with lmem, so > explicitly pass ww as a parameter. > > Signed-off-by: Maarten Lankhorst I'm leaving this and later patches out for now. Would be good to fast-track the bsw fix, but the othe

[RFC patch] vsprintf: Allow %pe to print non PTR_ERR %pe uses as decimal

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 09:52 -0700, Joe Perches wrote: > On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > > On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: > [] > > > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c > > > > b/drivers/gpu/drm/imx/imx-ldb.c > > > [] > > > > @@ -197,6 +197,12

Re: [Intel-gfx] [PATCH v9 70/70] drm/i915: Remove asynchronous vma binding

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:59PM +0100, Maarten Lankhorst wrote: > The current asynchronous work is done in a dma_fence_work, which > has signalling annotations, because dma_fence_work signals on completion. > > On braswell, we can call stop_machine inside fence_work, causing a splat > because m

Re: [Intel-gfx] [PATCH] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v2)

2021-03-24 Thread Jason Ekstrand
On Wed, Mar 24, 2021 at 6:36 AM Tvrtko Ursulin wrote: > > > On 24/03/2021 09:52, Daniel Vetter wrote: > > On Wed, Mar 24, 2021 at 09:28:58AM +, Tvrtko Ursulin wrote: > >> > >> On 23/03/2021 17:51, Jason Ekstrand wrote: > >>> This API is entirely unnecessary and I'd love to get rid of it. If >

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Daniel Vetter
On Wed, Mar 24, 2021 at 07:15:36PM +0200, Ville Syrjälä wrote: > On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > > We get a lockdep splat when the reset mutex is held, because it can be > > > taken from fence_

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Ville Syrjälä
On Wed, Mar 24, 2021 at 06:00:12PM +0100, Daniel Vetter wrote: > On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > > We get a lockdep splat when the reset mutex is held, because it can be > > taken from fence_wait. This conflicts with the mmu notifier we have, > > because we recu

Re: [Intel-gfx] [PATCH v9 65/70] drm/i915: Fix pin_map in scheduler selftests

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:54PM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst Fixes a commit I'll drop anyway, so didn't bother with this one. -Daniel > --- > drivers/gpu/drm/i915/selftests/i915_scheduler.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

Re: [Intel-gfx] [PATCH v9 64/70] drm/i915: Add missing -EDEADLK path in execbuffer ggtt pinning.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:53PM +0100, Maarten Lankhorst wrote: > In reloc_iomap we swallow the -EDEADLK error, but this needs to > be returned for -EDEADLK handling. Add the missing check to > make bsw pass again. > > Testcase: gem_exec_fence.basic-await > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH v9 63/70] drm/i915: Move gt_revoke() slightly

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:52PM +0100, Maarten Lankhorst wrote: > We get a lockdep splat when the reset mutex is held, because it can be > taken from fence_wait. This conflicts with the mmu notifier we have, > because we recurse between reset mutex and mmap lock -> mmu notifier. > > Remove this

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Joe Perches
On Wed, 2021-03-24 at 17:42 +0100, Arnd Bergmann wrote: > On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: [] > > > diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c > > [] > > > @@ -197,6 +197,12 @@ static void imx_ldb_encoder_enable(struct > > > drm_encoder *encoder)

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
24.03.2021 19:42, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 06:45:30PM +0300, Dmitry Osipenko wrote: >> 24.03.2021 18:02, Thierry Reding пишет: >>> On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: 23.03.2021 18:54, Thierry Reding пишет: > From: Thierry Reding > >

[PATCH] [v3] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Arnd Bergmann
From: Arnd Bergmann When CONFIG_OF is disabled, building with 'make W=1' produces warnings about out of bounds array access: drivers/gpu/drm/imx/imx-ldb.c: In function 'imx_ldb_set_clock.constprop': drivers/gpu/drm/imx/imx-ldb.c:186:8: error: array subscript -22 is below array bounds of 'struct

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread Arnd Bergmann
On Wed, Mar 24, 2021 at 3:20 PM Joe Perches wrote: > > On Wed, 2021-03-24 at 13:17 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When CONFIG_OF is disabled, building with 'make W=1' produces warnings > > about out of bounds array access: > > > > drivers/gpu/drm/imx/imx-ldb.c: In fun

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Thierry Reding
On Wed, Mar 24, 2021 at 06:45:30PM +0300, Dmitry Osipenko wrote: > 24.03.2021 18:02, Thierry Reding пишет: > > On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: > >> 23.03.2021 18:54, Thierry Reding пишет: > >>> From: Thierry Reding > >>> > >>> Clarify when a fixed IOV address can b

Re: [Intel-gfx] [PATCH v9 44/70] drm/i915/selftests: Prepare context tests for obj->mm.lock removal.

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:33PM +0100, Maarten Lankhorst wrote: > Straightforward conversion, just convert a bunch of calls to > unlocked versions. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström Another one where I just picked your old version: https://lore.kernel.org/

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Jason Gunthorpe
On Wed, Mar 24, 2021 at 04:50:14PM +0100, Thomas Hellström (Intel) wrote: > > On 3/24/21 2:48 PM, Jason Gunthorpe wrote: > > On Wed, Mar 24, 2021 at 02:35:38PM +0100, Thomas Hellström (Intel) wrote: > > > > > > In an ideal world the creation/destruction of page table levels would > > > > by dynam

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Dave Hansen
On 3/24/21 3:05 AM, Thomas Hellström (Intel) wrote: > Yes, I agree. Seems like the special (SW1) is available also for huge > page table entries on x86 AFAICT, although just not implemented. > Otherwise the SW bits appear completely used up. Although the _PAGE_BIT_SOFTW* bits are used up, there's

Re: [Intel-gfx] [PATCH v9 34/70] drm/i915: Add ww locking around vm_access()

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:23PM +0100, Maarten Lankhorst wrote: > i915_gem_object_pin_map potentially needs a ww context, so ensure we > have one we can revoke. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström We shouldn't hand-roll our own vm_access callback, generic_acc

Re: [Intel-gfx] [PATCH v9 31/70] drm/i915: Fix workarounds selftest, part 1

2021-03-24 Thread Daniel Vetter
On Tue, Mar 23, 2021 at 04:50:20PM +0100, Maarten Lankhorst wrote: > pin_map needs the ww lock, so ensure we pin both before submission. > > Signed-off-by: Maarten Lankhorst > Reviewed-by: Thomas Hellström Another one where I picked an older version: https://lore.kernel.org/intel-gfx/202101281

Re: [PATCH] [v2] drm/imx: imx-ldb: fix out of bounds array access warning

2021-03-24 Thread kernel test robot
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on shawnguo/for-next] [also build test WARNING on pza/reset/next drm-intel/for-linux-next drm-tip/drm-tip v5.12-rc4 next-20210324] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [RFC PATCH 1/2] mm,drm/ttm: Block fast GUP to TTM huge pages

2021-03-24 Thread Intel
On 3/24/21 2:48 PM, Jason Gunthorpe wrote: On Wed, Mar 24, 2021 at 02:35:38PM +0100, Thomas Hellström (Intel) wrote: In an ideal world the creation/destruction of page table levels would by dynamic at this point, like THP. Hmm, but I'm not sure what problem we're trying to solve by changing t

Re: [PATCH 6/9] drm/tegra: gem: Add a clarifying comment

2021-03-24 Thread Dmitry Osipenko
24.03.2021 18:02, Thierry Reding пишет: > On Wed, Mar 24, 2021 at 05:41:08PM +0300, Dmitry Osipenko wrote: >> 23.03.2021 18:54, Thierry Reding пишет: >>> From: Thierry Reding >>> >>> Clarify when a fixed IOV address can be used and when a buffer has to >>> be mapped before the IOVA can be used. >>

Re: [PATCH] drm/amdgpu: Ensure that the modifier requested is supported by plane.

2021-03-24 Thread Mark Yacoub
On Wed, Mar 24, 2021 at 11:25 AM Daniel Stone wrote: > > Hi Mark, > > On Wed, 24 Mar 2021 at 14:58, Mark Yacoub wrote: >> >> So you mean it would make more sense to be more explicit in handling >> DRM_FORMAT_MOD_INVALID as an incoming modifier (which will, just like >> DRM_FORMAT_MOD_LINEAR, will

Re: [PATCH 10/11] drm/i915: avoid stringop-overread warning on pri_latency

2021-03-24 Thread Jani Nikula
On Mon, 22 Mar 2021, Arnd Bergmann wrote: > From: Arnd Bergmann > > gcc-11 warns about what appears to be an out-of-range array access: > > In function ‘snb_wm_latency_quirk’, > inlined from ‘ilk_setup_wm_latency’ at > drivers/gpu/drm/i915/intel_pm.c:3108:3: > drivers/gpu/drm/i915/intel_pm.c

Re: [PATCH 3/7] drm/i915: Restrict sentinel requests further

2021-03-24 Thread Matthew Auld
On Wed, 24 Mar 2021 at 12:14, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Disallow sentinel requests follow previous sentinels to make request > cancellation work better when faced with a chain of requests which have > all been marked as in error. > > Because in cases where we end up with

  1   2   3   >