Re: Why we didn't use embedded gem object for virtio gpu when making ttm bo a gem bo subclass?

2021-08-15 Thread Gerd Hoffmann
On Sun, Aug 15, 2021 at 09:51:02PM -0700, lepton wrote: > Hi Gerd, > > Thanks for your reply. I was aware of that change, but need a fix for > 5.4 kernel as a temp solution for now. > If the reason is just that you will move away from ttm soon,then I > guess a CL like http://crrev.com/c/3092457

Re: Why we didn't use embedded gem object for virtio gpu when making ttm bo a gem bo subclass?

2021-08-15 Thread lepton
Hi Gerd, Thanks for your reply. I was aware of that change, but need a fix for 5.4 kernel as a temp solution for now. If the reason is just that you will move away from ttm soon,then I guess a CL like http://crrev.com/c/3092457 should work for 5.4, just hope I don't miss anything else. Thanks!

Re: Why we didn't use embedded gem object for virtio gpu when making ttm bo a gem bo subclass?

2021-08-15 Thread Gerd Hoffmann
On Fri, Aug 13, 2021 at 12:42:51PM -0700, lepton wrote: > Hi Gerd, > > We found a bug in 5.4 kernel and virtgpu_gem_prime_mmap doesn't work > because it references vma_node in gem_base object while ttm code > initialized vma_node in tbo.base object. I am wondering, in your > original serial: >

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-15 Thread Lazar, Lijo
On 8/13/2021 9:30 PM, Michel Dänzer wrote: On 2021-08-13 5:07 p.m., Lazar, Lijo wrote: On 8/13/2021 8:10 PM, Michel Dänzer wrote: On 2021-08-13 4:14 p.m., Lazar, Lijo wrote: On 8/13/2021 7:04 PM, Michel Dänzer wrote: On 2021-08-13 1:50 p.m., Lazar, Lijo wrote: On 8/13/2021 3:59 PM,

Re: [PATCH v2 08/14] soc: mediatek: add mtk-mmsys config API for mt8195 vdosys1

2021-08-15 Thread Nancy . Lin
Hi Matthias, Thanks for the review. On Fri, 2021-08-06 at 17:30 +0200, Matthias Brugger wrote: > > On 22/07/2021 11:45, Nancy.Lin wrote: > > Add mmsys config API. > > This patch is doing a lot of things, it adds a "config" and it adds > cmdq > support. Please explain better in the commit

Re: [PATCH v2 07/14] soc: mediatek: add mtk-mmsys support for mt8195 vdosys1

2021-08-15 Thread Nancy . Lin
Hi Matthias, Thanks for the review. On Fri, 2021-08-06 at 14:20 +0200, Matthias Brugger wrote: > > On 28/07/2021 07:34, Nancy.Lin wrote: > > Hi Enric, > > > > Thanks for your review. > > > > On Fri, 2021-07-23 at 13:05 +0200, Enric Balletbo Serra wrote: > > > Hi Nancy, > > > > > > Thank you

[GIT PULL] mediatek drm next for 5.15

2021-08-15 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. MT8133 AAL support, adjust rdma fifo threshold formula. 2. Implement mmap as GEM object function. 3. Add support for MT8167. 4. Test component initialization earlier in the function mtk_drm_crtc_create. 5. CMDQ refinement. Regards, Chun-Kuang. The

Re: [PATCH v6 02/13] mm: remove extra ZONE_DEVICE struct page refcount

2021-08-15 Thread John Hubbard
On 8/15/21 8:37 AM, Christoph Hellwig wrote: diff --git a/include/linux/mm.h b/include/linux/mm.h index 8ae31622deef..d48a1f0889d1 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1218,7 +1218,7 @@ __maybe_unused struct page *try_grab_compound_head(struct page *page, int refs,

[PATCH] drm/radeon: Add break to switch statement in radeonfb_create_pinned_object()

2021-08-15 Thread Nathan Chancellor
Clang + -Wimplicit-fallthrough warns: drivers/gpu/drm/radeon/radeon_fb.c:170:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ drivers/gpu/drm/radeon/radeon_fb.c:170:2: note: insert 'break;' to avoid fall-through default:

[Bug 205089] amdgpu : drm:amdgpu_cs_ioctl : Failed to initialize parser -125

2021-08-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=205089 ctjans...@protonmail.com changed: What|Removed |Added CC||ctjans...@protonmail.com ---

Re: [PATCH v2] drm: avoid races with modesetting rights

2021-08-15 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Desmond-Cheong-Zhi-Xi/drm-avoid-races-with-modesetting-rights/20210815-234145 base:4b358aabb93a2c654cd1dcab1a25a589f6e2b153 config: arc

Re: [PATCH v2] drm: avoid races with modesetting rights

2021-08-15 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Desmond-Cheong-Zhi-Xi/drm-avoid-races-with-modesetting-rights/20210815-234145 base:4b358aabb93a2c654cd1dcab1a25a589f6e2b153 config: i386-randconfig-a004

[PATCH v2] drm: avoid races with modesetting rights

2021-08-15 Thread Desmond Cheong Zhi Xi
In drm_client_modeset.c and drm_fb_helper.c, drm_master_internal_{acquire,release} are used to avoid races with DRM userspace. These functions hold onto drm_device.master_mutex while committing, and bail if there's already a master. However, there are other places where modesetting rights can

[PATCH v7 02/13] dt-bindings: mediatek: display: split each block to individual yaml

2021-08-15 Thread jason-jh . lin
1. Remove mediatek,dislpay.txt 2. Split each display function block to individual yaml file Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,aal.yaml| 75 ++ .../display/mediatek/mediatek,ccorr.yaml | 69 ++ .../display/mediatek/mediatek,color.yaml | 84

[PATCH v7 07/13] soc: mediatek: add mtk-mutex support for mt8195 vdosys0

2021-08-15 Thread jason-jh . lin
Add mtk-mutex support for mt8195 vdosys0. Signed-off-by: jason-jh.lin --- drivers/soc/mediatek/mtk-mutex.c | 93 ++-- 1 file changed, 90 insertions(+), 3 deletions(-) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index

[PATCH v7 01/13] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-08-15 Thread jason-jh . lin
1. There are 2 mmsys, namely vdosys0 and vdosys1 in mt8195. Each of them is bound to a display pipeline, so add their definition in mtk-mmsys documentation with 2 compatibles. 2. Add description for power-domain property. Signed-off-by: jason-jh.lin ---

[PATCH v7 04/13] dt-bindings: mediatek: display: add mt8195 SoC binding

2021-08-15 Thread jason-jh . lin
1. Add mt8195 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MERGE, MUTEX, OVL and RDMA yaml schema. 2. Add MERGE additional property description for mt8195 - async clock - fifo setting enable - reset controller Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,aal.yaml

[PATCH v7 06/13] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-08-15 Thread jason-jh . lin
Add mt8195 vdosys0 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: jason-jh.lin --- This patch is base on [1] [1] soc: mmsys: mediatek: add mask to mmsys routes - https://patchwork.kernel.org/project/linux-mediatek/patch/20210729070549.5514-1-li...@fw-web.de/

[PATCH v7 03/13] dt-bindings: mediatek: add mediatek, dsc.yaml for mt8195 SoC binding

2021-08-15 Thread jason-jh . lin
1. Add mediatek,dsc.yaml to describe DSC module in details. 2. Add mt8195 SoC binding to mediatek,dsc.yaml. Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,dsc.yaml| 69 +++ 1 file changed, 69 insertions(+) create mode 100644

[PATCH v7 10/13] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-08-15 Thread jason-jh . lin
Adjust to the alphabetic order for the define, function, struct and array in mediatek-drm driver Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 133 ++-- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 22 ++-- drivers/gpu/drm/mediatek/mtk_drm_drv.c

[PATCH v7 09/13] drm/mediatek: rename the define of register offset

2021-08-15 Thread jason-jh . lin
Add DISP_REG prefix for the define of register offset to make the difference from the define of register value. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 +++-- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git

[PATCH v7 12/13] drm/mediatek: add MERGE support for mediatek-drm

2021-08-15 Thread jason-jh . lin
Add MERGE engine file: MERGE module is used to merge two slice-per-line inputs into one side-by-side output. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + drivers/gpu/drm/mediatek/mtk_disp_merge.c |

[PATCH v7 13/13] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2021-08-15 Thread jason-jh . lin
Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: jason-jh.lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 2 files changed, 34 insertions(+) diff

[PATCH v7 05/13] arm64: dts: mt8195: add display node for vdosys0

2021-08-15 Thread jason-jh . lin
Add display node for vdosys0. Signed-off-by: jason-jh.lin --- --- This patch is based on [1][2][3] [1]arm64: dts: Add Mediatek SoC MT8195 and evaluation board dts and Makefile - https://patchwork.kernel.org/project/linux-mediatek/patch/20210601075350.31515-2-seiya.w...@mediatek.com/ [2]arm64:

[PATCH v7 00/13] Add Mediatek Soc DRM (vdosys0) support for mt8195

2021-08-15 Thread jason-jh . lin
Change in v7: - add dt=binding of mmsys and disp path into this series - separate th modidfication of alphabetic order, remove unused define and rename the define of register offset to individual patch - add comment for MERGE ultra and preultra setting Change in v6: - adjust alphabetic order

[PATCH v7 11/13] drm/mediatek: add DSC support for mediatek-drm

2021-08-15 Thread jason-jh . lin
DSC is designed for real-time systems with real-time compression, transmission, decompression and display. The DSC standard is a specification of the algorithms used for compressing and decompressing image display streams, including the specification of the syntax and semantics of the compressed

[PATCH v7 08/13] drm/mediatek: remove unused define in mtk_drm_ddp_comp.c

2021-08-15 Thread jason-jh . lin
Remove the unsed define in mtk_drm_ddp_comp.c Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index

Re: [PATCH v2 03/12] x86/sev: Add an x86 version of prot_guest_has()

2021-08-15 Thread Borislav Petkov
On Sun, Aug 15, 2021 at 08:53:31AM -0500, Tom Lendacky wrote: > It's not a cross-vendor thing as opposed to a KVM or other hypervisor > thing where the family doesn't have to be reported as AMD or HYGON. What would be the use case? A HV starts a guest which is supposed to be encrypted using the

Re: [PATCH v2 03/12] x86/sev: Add an x86 version of prot_guest_has()

2021-08-15 Thread Tom Lendacky
On 8/14/21 2:08 PM, Borislav Petkov wrote: On Fri, Aug 13, 2021 at 11:59:22AM -0500, Tom Lendacky wrote: diff --git a/arch/x86/include/asm/protected_guest.h b/arch/x86/include/asm/protected_guest.h new file mode 100644 index ..51e4eefd9542 --- /dev/null +++

[Bug 214071] amdgpu idle power draw too high at +75Hz

2021-08-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214071 --- Comment #1 from Paul Größel (p...@gmx.de) --- Hardware setup: Mainboard: MSI MPG B550I GAMING EDGE WIFI CPU: Ryzen 5950X GPU: Radeon RX 6900XT Kernel 5.13.10 mesa 21.1.4 X11 -- You may reply to this email to add a comment. You are

[Bug 214071] amdgpu idle power draw too high at +75Hz

2021-08-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214071 Paul Größel (p...@gmx.de) changed: What|Removed |Added Summary|amdgpu idle power draw to |amdgpu idle power draw too

Re: [PATCH 1/2] drm: avoid races with modesetting rights

2021-08-15 Thread Desmond Cheong Zhi Xi
On 13/8/21 11:49 pm, Daniel Vetter wrote: On Fri, Aug 13, 2021 at 04:54:49PM +0800, Desmond Cheong Zhi Xi wrote: In drm_client_modeset.c and drm_fb_helper.c, drm_master_internal_{acquire,release} are used to avoid races with DRM userspace. These functions hold onto drm_device.master_mutex while

[Bug 214071] New: amdgpu idle power draw to high at +75Hz

2021-08-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=214071 Bug ID: 214071 Summary: amdgpu idle power draw to high at +75Hz Product: Drivers Version: 2.5 Kernel Version: 5.13.10 Hardware: x86-64 OS: Linux Tree: