Re: [Intel-gfx] [PATCH v3 4/9] drm: fix potential null ptr dereferences in drm_{auth, ioctl}

2021-08-18 Thread Desmond Cheong Zhi Xi
On 19/8/21 12:33 am, Daniel Vetter wrote: On Wed, Aug 18, 2021 at 5:37 PM Desmond Cheong Zhi Xi wrote: On 18/8/21 6:11 pm, Daniel Vetter wrote: On Wed, Aug 18, 2021 at 03:38:19PM +0800, Desmond Cheong Zhi Xi wrote: There are three areas where we dereference struct drm_master without

Re: [PATCH v2 18/63] drm/amd/pm: Use struct_group() for memcpy() region

2021-08-18 Thread Lazar, Lijo
On 8/19/2021 5:29 AM, Kees Cook wrote: On Wed, Aug 18, 2021 at 05:12:28PM +0530, Lazar, Lijo wrote: On 8/18/2021 11:34 AM, Kees Cook wrote: In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memcpy(), memmove(), and memset(), avoid

RE: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Liu, Monk
[AMD Official Use Only] Hi Andrey and Daniel We worked for a really long time on this new feature to AMD that finally can pick up the bad job from all timedout ones, and the change in scheduler (get/put fence in drm_sched_job_timedout, and remove the bad job delete and put back) is the last

[PATCH v8 04/13] dt-bindings: mediatek: display: add mt8195 SoC binding

2021-08-18 Thread jason-jh . lin
1. Add mt8195 SoC binding to AAL, CCORR, COLOR, DITHER, GAMMA, MERGE, MUTEX, OVL and RDMA yaml schema. 2. Add MERGE additional property description for mt8195 - async clock - fifo setting enable - reset controller Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,aal.yaml

[PATCH v8 11/13] drm/mediatek: add DSC support for mediatek-drm

2021-08-18 Thread jason-jh . lin
DSC is designed for real-time systems with real-time compression, transmission, decompression and display. The DSC standard is a specification of the algorithms used for compressing and decompressing image display streams, including the specification of the syntax and semantics of the compressed

[PATCH v8 02/13] dt-bindings: mediatek: display: split each block to individual yaml

2021-08-18 Thread jason-jh . lin
1. Remove mediatek,dislpay.txt 2. Split each display function block to individual yaml file. Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,aal.yaml| 75 ++ .../display/mediatek/mediatek,ccorr.yaml | 69 ++ .../display/mediatek/mediatek,color.yaml |

[PATCH v8 12/13] drm/mediatek: add MERGE support for mediatek-drm

2021-08-18 Thread jason-jh . lin
Add MERGE engine file: MERGE module is used to merge two slice-per-line inputs into one side-by-side output. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/Makefile | 1 + drivers/gpu/drm/mediatek/mtk_disp_drv.h | 8 + drivers/gpu/drm/mediatek/mtk_disp_merge.c |

[PATCH v8 10/13] drm/mediatek: adjust to the alphabetic order for mediatek-drm

2021-08-18 Thread jason-jh . lin
Adjust to the alphabetic order for the define, function, struct and array in mediatek-drm driver Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 133 ++-- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 22 ++-- drivers/gpu/drm/mediatek/mtk_drm_drv.c

[PATCH v8 05/13] arm64: dts: mt8195: add display node for vdosys0

2021-08-18 Thread jason-jh . lin
Add display node for vdosys0. Signed-off-by: jason-jh.lin --- This patch is based on [1][2][3] [1]arm64: dts: Add Mediatek SoC MT8195 and evaluation board dts and Makefile - https://patchwork.kernel.org/project/linux-mediatek/patch/20210601075350.31515-2-seiya.w...@mediatek.com/ [2]arm64: dts:

[PATCH v8 09/13] drm/mediatek: rename the define of register offset

2021-08-18 Thread jason-jh . lin
Add DISP_REG prefix for the define of register offset to make the difference from the define of register value. Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 57 +++-- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git

[PATCH v8 06/13] soc: mediatek: add mtk-mmsys support for mt8195 vdosys0

2021-08-18 Thread jason-jh . lin
Add mt8195 vdosys0 clock driver name and routing table to the driver data of mtk-mmsys. Signed-off-by: jason-jh.lin --- This patch is base on [1][2] [1] soc: mediatek: mmsys: add MT8365 support -

[PATCH v8 13/13] drm/mediatek: add mediatek-drm of vdosys0 support for mt8195

2021-08-18 Thread jason-jh . lin
Add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver. Signed-off-by: jason-jh.lin Reviewed-by: Chun-Kuang Hu --- drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 + drivers/gpu/drm/mediatek/mtk_drm_drv.c | 28 2 files changed, 34 insertions(+) diff

[PATCH v8 00/13] Add Mediatek Soc DRM (vdosys0) support for mt8195

2021-08-18 Thread jason-jh . lin
Change in v8: - add DP_INTF0 mux into mmsys routing table - add DP_INTF0 mutex mod and enum into add/remove comp funtion - remove bypass DSC enum in mtk_ddp_comp_init Change in v7: - add dt=binding of mmsys and disp path into this series - separate th modidfication of alphabetic order, remove

[PATCH v8 08/13] drm/mediatek: remove unused define in mtk_drm_ddp_comp.c

2021-08-18 Thread jason-jh . lin
Remove the unsed define in mtk_drm_ddp_comp.c Signed-off-by: jason-jh.lin --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index

[PATCH v8 07/13] soc: mediatek: add mtk-mutex support for mt8195 vdosys0

2021-08-18 Thread jason-jh . lin
Add mtk-mutex support for mt8195 vdosys0. Signed-off-by: jason-jh.lin --- drivers/soc/mediatek/mtk-mutex.c | 98 +++- 1 file changed, 95 insertions(+), 3 deletions(-) diff --git a/drivers/soc/mediatek/mtk-mutex.c b/drivers/soc/mediatek/mtk-mutex.c index

[PATCH v8 01/13] dt-bindings: arm: mediatek: mmsys: add mt8195 SoC binding

2021-08-18 Thread jason-jh . lin
1. There are 2 mmsys, namely vdosys0 and vdosys1 in mt8195. Each of them is bound to a display pipeline, so add their definition in mtk-mmsys documentation with 2 compatibles. 2. Add description for power-domain property. Signed-off-by: jason-jh.lin --- this patch is base on [1][2] [1]

[PATCH v8 03/13] dt-bindings: mediatek: add mediatek, dsc.yaml for mt8195 SoC binding

2021-08-18 Thread jason-jh . lin
1. Add mediatek,dsc.yaml to describe DSC module in details. 2. Add mt8195 SoC binding to mediatek,dsc.yaml. Signed-off-by: jason-jh.lin --- .../display/mediatek/mediatek,dsc.yaml| 69 +++ 1 file changed, 69 insertions(+) create mode 100644

[GIT PULL] mediatek drm fixes for 5.14-2

2021-08-18 Thread Chun-Kuang Hu
Hi, Dave & Daniel: This includes: 1. Fix AAL output size setting. 2. Delete component in remove function. Regards, Chun-Kuang. The following changes since commit 1a64a7aff8da352c9419de3d5c34343682916411: drm/mediatek: Fix cursor plane no update (2021-07-22 22:57:52 +0800) are available in

Re: [PATCH v2 18/63] drm/amd/pm: Use struct_group() for memcpy() region

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 05:12:28PM +0530, Lazar, Lijo wrote: > > On 8/18/2021 11:34 AM, Kees Cook wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memcpy(), memmove(), and memset(), avoid > > intentionally writing across neighboring

Re: [PATCH v2 53/63] KVM: x86: Use struct_group() to zero decode cache

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 10:53:58PM +, Sean Christopherson wrote: > On Wed, Aug 18, 2021, Kees Cook wrote: > > On Wed, Aug 18, 2021 at 03:11:28PM +, Sean Christopherson wrote: > > > From dbdca1f4cd01fee418c252e54c360d518b2b1ad6 Mon Sep 17 00:00:00 2001 > > > From: Sean Christopherson > > >

[pull] amdgpu, amdkfd drm-fixes-5.14

2021-08-18 Thread Alex Deucher
Hi Dave, Daniel, Fixes for 5.14. The following changes since commit 7c60610d476766e128cc4284bb6349732cbd6606: Linux 5.14-rc6 (2021-08-15 13:40:53 -1000) are available in the Git repository at: https://gitlab.freedesktop.org/agd5f/linux.git tags/amd-drm-fixes-5.14-2021-08-18 for you to

Re: [PATCH v2 06/63] cxl/core: Replace unions with struct_group()

2021-08-18 Thread Dan Williams
On Tue, Aug 17, 2021 at 11:06 PM Kees Cook wrote: > > Use the newly introduced struct_group_typed() macro to clean up the > declaration of struct cxl_regs. > > Cc: Alison Schofield > Cc: Vishal Verma > Cc: Ira Weiny > Cc: Ben Widawsky > Cc: linux-...@vger.kernel.org > Suggested-by: Dan

Re: [PATCH v2 05/63] stddef: Introduce struct_group() helper macro

2021-08-18 Thread Dan Williams
On Tue, Aug 17, 2021 at 11:06 PM Kees Cook wrote: > > Kernel code has a regular need to describe groups of members within a > structure usually when they need to be copied or initialized separately > from the rest of the surrounding structure. The generally accepted design > pattern in C is to

Re: [PATCH v2 61/63] powerpc: Split memset() to avoid multi-field overflow

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 08:42:18AM +0200, Christophe Leroy wrote: > > > Le 18/08/2021 à 08:05, Kees Cook a écrit : > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memset(), avoid intentionally writing across > > neighboring fields. > > >

Re: [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

2021-08-18 Thread Lyude Paul
This looks great to me! Wasn't much to comment on here as most of this looks fine to me. For the whole series: Reviewed-by: Lyude Paul This will be quite interesting to try getting working for nouveau On Tue, 2021-08-17 at 23:51 +0200, Hans de Goede wrote: > Hi all, > > Here is a

Re: [PATCH] drm/amdgpu: Cancel delayed work when GFXOFF is disabled

2021-08-18 Thread Alex Deucher
Applied. Let's see how long this one lasts :) Alex On Tue, Aug 17, 2021 at 4:23 AM Michel Dänzer wrote: > > From: Michel Dänzer > > schedule_delayed_work does not push back the work if it was already > scheduled before, so amdgpu_device_delay_enable_gfx_off ran ~100 ms > after the first time

Re: [PATCH 2/5] drm: amdgpu: remove obsolete reference to config CHASH

2021-08-18 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Aug 18, 2021 at 8:41 AM Lukas Bulwahn wrote: > > Commit 04ed8459f334 ("drm/amdgpu: remove chash") removes the chash > architecture and its corresponding config CHASH. > > There is still a reference to CHASH in the config DRM_AMDGPU in > ./drivers/gpu/drm/Kconfig.

Re: [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

2021-08-18 Thread Lyude Paul
On Tue, 2021-08-17 at 23:51 +0200, Hans de Goede wrote: > Give connector sysfs devices there own device_type, this allows us to > check if a device passed to functions dealing with generic devices is > a drm_connector or not. > > A check like this is necessary in the

[PULL] drm-intel-fixes

2021-08-18 Thread Rodrigo Vivi
Hi Dave and Daniel, Here goes drm-intel-fixes-2021-08-18: - Expand a tweaked display workaround for all PCHs. (Anshuman) - Fix eDP MSO pipe sanity checks for ADL-P. (Jani) - Remove superfluous EXPORT_SYMBOL(). (Jani) Thanks, Rodrigo. The following changes since commit

Re: [PATCH v1 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:01) > MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI, EDP etc. Add required DPU > device tree bindings for SC7280. > > Signed-off-by: Krishna Manikandan > --- Please send a cover-letter next time. Do

Re: [PATCH v1 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:04) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index aadf55d..5be318e 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1412,7 +1412,7 @@ >

Re: [PATCH v1 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:03) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index fd7ff1c..aadf55d 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -1507,6 +1519,95 @@ >

Re: [PATCH v1 2/4] arm64: dts: qcom: sc7280: add display dt nodes

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:02) > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > index 53a21d0..fd7ff1c 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > @@ -5,6 +5,7 @@ > * Copyright

Re: [PATCH v1 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-08-18 Thread Stephen Boyd
Quoting Krishna Manikandan (2021-08-18 03:27:01) > diff --git a/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml > b/Documentation/devicetree/bindings/display/msm/dpu-sc7280.yaml > new file mode 100644 > index 000..3d256c0 > --- /dev/null > +++

Re: nouveau resume regression after 64f7c698bea9 ("drm/nouveau/fifo: add engine_id hook")

2021-08-18 Thread Karol Herbst
On Wed, Aug 18, 2021 at 8:52 PM Jarkko Nikula wrote: > > Hi > > My old Thinkpad T410i won't resume properly anymore after suspend or > hibernation after v5.12 including today's head 614cb2751d31 ("Merge tag > 'trace-v5.14-rc6' of >

Re: [PATCH] drm/mgag200: Initialize delta variable in PLL compute function

2021-08-18 Thread Thomas Zimmermann
Hi Am 17.08.21 um 21:50 schrieb Daniel Vetter: On Tue, Aug 17, 2021 at 8:16 PM Thomas Zimmermann wrote: Initialize delta variable in PLL compute function for G200SE, rev 00 to the maximum value. Fixes uninitialized usage. smatch warnings: drivers/gpu/drm/mgag200/mgag200_pll.c:142

Re: [Freedreno] [PATCH] drm/msm/dpu: add support for alpha blending properties

2021-08-18 Thread Dmitry Baryshkov
On 17/08/2021 20:48, abhin...@codeaurora.org wrote: On 2021-06-28 12:19, Dmitry Baryshkov wrote: Add support for alpha blending properties. Setup the plane blend state according to those properties. Signed-off-by: Dmitry Baryshkov I think this has already been picked up by Rob but just had

Re: [PATCH v6 02/13] mm: remove extra ZONE_DEVICE struct page refcount

2021-08-18 Thread Ralph Campbell
On 8/17/21 5:35 PM, Felix Kuehling wrote: Am 2021-08-17 um 8:01 p.m. schrieb Ralph Campbell: On 8/12/21 11:31 PM, Alex Sierra wrote: From: Ralph Campbell ZONE_DEVICE struct pages have an extra reference count that complicates the code for put_page() and several places in the kernel that need

[PULL] drm-misc-fixes

2021-08-18 Thread Thomas Zimmermann
Hi Dave and Daniel, here's the drm-misc-fixes PR for this week. The vblank fix is a UAPI change that unifies the behaviour of the regular and compat ioctl. Best regards Thomas drm-misc-fixes-2021-08-18: Short summary of fixes pull: * UAPI: Return results for failed drm_wait_vblank_ioctl() *

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Print error name on CTB (de)registration failure

2021-08-18 Thread Michal Wajdeczko
On 18.08.2021 18:35, Daniel Vetter wrote: > On Wed, Aug 18, 2021 at 5:11 PM Michal Wajdeczko > wrote: >> >> >> >> On 18.08.2021 16:20, Daniel Vetter wrote: >>> On Thu, Jul 01, 2021 at 05:55:11PM +0200, Michal Wajdeczko wrote: Instead of plain error value (%d) print more user friendly

Re: [PATCH v2 2/2] drm/bridge: anx7625: Propagate errors from sp_tx_edid_read()

2021-08-18 Thread Robert Foss
Thanks Sam! On Wed, 18 Aug 2021 at 19:40, Sam Ravnborg wrote: > > Hi Robert, > > On Wed, Aug 18, 2021 at 07:13:18PM +0200, Robert Foss wrote: > > During the sp_tx_edid_read() call the return value of sp_tx_edid_read() > > is ignored, which could cause potential errors to go unhandled. > > > >

Re: [PATCH 2/4] drm/dp_mst: Only create connector for connected end device

2021-08-18 Thread Lyude Paul
On Wed, 2021-08-11 at 09:49 +, Lin, Wayne wrote: > [Public] > > > -Original Message- > > From: Lyude Paul > > Sent: Wednesday, August 11, 2021 4:45 AM > > To: Lin, Wayne ; dri-devel@lists.freedesktop.org > > Cc: Kazlauskas, Nicholas ; Wentland, Harry < > > harry.wentl...@amd.com>;

nouveau resume regression after 64f7c698bea9 ("drm/nouveau/fifo: add engine_id hook")

2021-08-18 Thread Jarkko Nikula
Hi My old Thinkpad T410i won't resume properly anymore after suspend or hibernation after v5.12 including today's head 614cb2751d31 ("Merge tag 'trace-v5.14-rc6' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace"). I bisected regression to commit 64f7c698bea9

Re: [PATCH 3/3] dt-bindings: add vendor prefix for Vivax

2021-08-18 Thread Sam Ravnborg
Hi Nikola, On Wed, Aug 18, 2021 at 04:46:48PM +0200, Nikola Pavlica wrote: > Add vendor prefix for the Vivax brand by M SAN Grupa d.o.o. > > Source (in Croatian): https://www.vivax.com/hr/o-nama.aspx > > Signed-off-by: Nikola Pavlica One other note, bindings patches should also be copied to

Re: [PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel

2021-08-18 Thread Sam Ravnborg
Hi Nikola, On Wed, Aug 18, 2021 at 04:46:47PM +0200, Nikola Pavlica wrote: > This tablet display is unique and hence must be added to documentation. > Unfortunately, it's real make and number is not known due to obscure and > missing documentation and lack of writing on the display assembly >

Re: [PATCH 3/3] dt-bindings: add vendor prefix for Vivax

2021-08-18 Thread Sam Ravnborg
On Wed, Aug 18, 2021 at 04:46:48PM +0200, Nikola Pavlica wrote: > Add vendor prefix for the Vivax brand by M SAN Grupa d.o.o. > > Source (in Croatian): https://www.vivax.com/hr/o-nama.aspx > > Signed-off-by: Nikola Pavlica Reviewed-by: Sam Ravnborg I like this as the first in the series, as

Re: [PATCH 1/3] drm/panel-simple: Add Vivax TPC-9150 panel v4

2021-08-18 Thread Sam Ravnborg
Hi Nikola, On Wed, Aug 18, 2021 at 04:46:46PM +0200, Nikola Pavlica wrote: > The model and make of the LCD panel of the Vivax TPC-9150 is unknown, > hence the panel settings that were retrieved with a FEX dump are named > after the device NOT the actual panel. > > The LCD in question is a 50 pin

[PATCH 03/17] drm/dp: add LTTPR DP 2.0 DPCD addresses

2021-08-18 Thread Jani Nikula
DP 2.0 brings some new DPCD addresses for PHY repeaters. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Manasi Navare Signed-off-by: Jani Nikula --- include/drm/drm_dp_helper.h | 4 1 file changed, 4 insertions(+) diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h

[PATCH 04/17] drm/dp: add helper for extracting adjust 128b/132b TX FFE preset

2021-08-18 Thread Jani Nikula
The DP 2.0 128b/132b channel coding uses TX FFE presets instead of vswing and pre-emphasis. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_dp_helper.c | 14 ++ include/drm/drm_dp_helper.h | 2 ++ 2 files changed, 16 insertions(+) diff

[PATCH 02/17] drm/dp: use more of the extended receiver cap

2021-08-18 Thread Jani Nikula
Extend the use of extended receiver cap at 0x2200 to cover MAIN_LINK_CHANNEL_CODING_CAP in 0x2206, in case an implementation hides the DP 2.0 128b/132b channel encoding cap. Cc: dri-devel@lists.freedesktop.org Reviewed-by: Manasi Navare Signed-off-by: Jani Nikula ---

[PATCH 01/17] drm/dp: add DP 2.0 UHBR link rate and bw code conversions

2021-08-18 Thread Jani Nikula
The bw code equals link_rate / 0.27 Gbps only for 8b/10b link rates. Handle DP 2.0 UHBR rates as special cases, though this is not pretty. Cc: dri-devel@lists.freedesktop.org Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_dp_helper.c | 26 ++ 1 file changed, 22

[PATCH 3/3] drm/v3d: add multiple syncobjs support

2021-08-18 Thread Melissa Wen
Using the generic extension support set in the previous patch, this patch enables more than one in/out binary syncobj per job submission. Arrays of syncobjs are set in a specific extension type (multisync) that also cares of determining the stage for sync (bin/render) through a flag - when this is

[PATCH 2/3] drm/v3d: add generic ioctl extension

2021-08-18 Thread Melissa Wen
Add support to attach generic extensions on job submission. This patch is a second prep work to enable multiple syncobjs on job submission. With this work, when the job submission interface needs to be extended to accomodate a new feature, we will use a generic extension struct where an id

[PATCH 1/3] drm/v3d: decouple adding job dependencies steps from job init

2021-08-18 Thread Melissa Wen
Prep work to enable a job to wait for more than one syncobj before start. Also get rid of old checkpatch warnings in the v3d_gem file. No functional changes. Signed-off-by: Melissa Wen --- drivers/gpu/drm/v3d/v3d_gem.c | 28 ++-- 1 file changed, 18 insertions(+), 10

[PATCH 0/3] drm/v3d: add multiple in/out syncobjs support

2021-08-18 Thread Melissa Wen
Currently, v3d only supports single in/out syncobj per submission (in v3d_submit_cl, there are two in_sync, one for bin and another for render job); however, Vulkan queue submit operations expect multiples wait and signal semaphores. This series extends v3d interface and job dependency operations

RE: [PATCH] dma-buf: return -EINVAL if dmabuf object is NULL

2021-08-18 Thread Sa, Nuno
> From: Christian König > Sent: Wednesday, August 18, 2021 2:10 PM > To: Sa, Nuno ; linaro-mm-...@lists.linaro.org; > dri-devel@lists.freedesktop.org; linux-me...@vger.kernel.org > Cc: Rob Clark ; Sumit Semwal > > Subject: Re: [PATCH] dma-buf: return -EINVAL if dmabuf object is > NULL > >

[PATCH] drm/prime: fix a potential double put (release) bug

2021-08-18 Thread Wentao_Liang
In line 317 (#1), drm_gem_prime_import() is called, it will call drm_gem_prime_import_dev(). At the end of the function drm_gem_prime_import_dev() (line 956, #2), "dma_buf_put(dma_buf);" puts dma_buf->file and may cause it to be released. However, after drm_gem_prime_import() returning, the

RE: [Linaro-mm-sig] [PATCH] dma-buf: return -EINVAL if dmabuf object is NULL

2021-08-18 Thread Sa, Nuno
> From: Christian König > Sent: Wednesday, August 18, 2021 2:58 PM > To: Daniel Vetter > Cc: Sa, Nuno ; linaro-mm-...@lists.linaro.org; > dri-devel@lists.freedesktop.org; linux-me...@vger.kernel.org; Rob > Clark > Subject: Re: [Linaro-mm-sig] [PATCH] dma-buf: return -EINVAL if > dmabuf object

Re: [PATCH v2 25/63] compiler_types.h: Remove __compiletime_object_size()

2021-08-18 Thread Miguel Ojeda
On Wed, Aug 18, 2021 at 8:14 AM Kees Cook wrote: > > Since all compilers support __builtin_object_size(), and there is only > one user of __compiletime_object_size, remove it to avoid the needless > indirection. This lets Clang reason about check_copy_size() correctly. Sounds good to me, the

[PATCH] dma-buf: return -EINVAL if dmabuf object is NULL

2021-08-18 Thread Nuno Sá
On top of warning about a NULL object, we also want to return with a proper error code (as done in 'dma_buf_begin_cpu_access()'). Otherwise, we will get a NULL pointer dereference. Fixes: fc13020e086b ("dma-buf: add support for kernel cpu access") Signed-off-by: Nuno Sá ---

[PATCH] drm/i915/gem: Avoid NULL dereference in __i915_gem_object_lock()

2021-08-18 Thread Tim Gardner
Coverity warns of a possible NULL dereference: Both dma_resv_lock_interruptible() and dma_resv_lock() can return -EDEADLK. Protect against a NULL dereference by checking for NULL before saving the object pointer. This is consistent with previous checks for ww==NULL. Addresses-Coverity:

[PULL] nouveau-fixes 5.14

2021-08-18 Thread Ben Skeggs
Hey, Just a couple fixes for Ampere display issues, and a long-standing race in MM paths. Ben. The following changes since commit 7c60610d476766e128cc4284bb6349732cbd6606: Linux 5.14-rc6 (2021-08-15 13:40:53 -1000) are available in the Git repository at: git://github.com/skeggsb/linux

Re: [PATCH v2 2/2] drm/bridge: anx7625: Propagate errors from sp_tx_edid_read()

2021-08-18 Thread Sam Ravnborg
Hi Robert, On Wed, Aug 18, 2021 at 07:13:18PM +0200, Robert Foss wrote: > During the sp_tx_edid_read() call the return value of sp_tx_edid_read() > is ignored, which could cause potential errors to go unhandled. > > All errors which are returned by sp_tx_edid_read() are handled in >

Re: [PATCH v2 1/2] drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()

2021-08-18 Thread Sam Ravnborg
Hi Robert, On Wed, Aug 18, 2021 at 07:13:17PM +0200, Robert Foss wrote: > The return value of sp_tx_rst_aux() is not propagated, which means > both compiler warnings and potential errors not being handled. > > Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") > >

Re: [PATCH v8 11/34] gpu: host1x: Add runtime PM and OPP support

2021-08-18 Thread Dmitry Osipenko
18.08.2021 11:35, Ulf Hansson пишет: > Thanks for clarifying! As I said, feel free to ignore my comments then. > > For this and the other patches in the series, I assume you only need > to care about whether the driver is a cross SoC driver and used on > other platforms than Tegra then. Yes, and

Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

2021-08-18 Thread Dmitry Osipenko
18.08.2021 19:57, Dmitry Osipenko пишет: Also, I don't think the tegra- prefix is necessary here. The parent node is already identified as Tegra via the compatible string. In the case of CAR, I'd imagine something like: clocks { sclk {

[PATCH v2] drm/i915/dp: Use max params for panels < eDP 1.4

2021-08-18 Thread Kai-Heng Feng
Users reported that after commit 2bbd6dba84d4 ("drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure"), the screen starts to have wobbly effect. Commit a5c936add6a2 ("drm/i915/dp: Use slow and wide link training for everything") doesn't help either,

[PATCH v2 2/2] drm/bridge: anx7625: Propagate errors from sp_tx_edid_read()

2021-08-18 Thread Robert Foss
During the sp_tx_edid_read() call the return value of sp_tx_edid_read() is ignored, which could cause potential errors to go unhandled. All errors which are returned by sp_tx_edid_read() are handled in anx7625_get_edid(). Signed-off-by: Robert Foss --- drivers/gpu/drm/bridge/analogix/anx7625.c

[PATCH v2 1/2] drm/bridge: anx7625: Propagate errors from sp_tx_rst_aux()

2021-08-18 Thread Robert Foss
The return value of sp_tx_rst_aux() is not propagated, which means both compiler warnings and potential errors not being handled. Fixes: 8bdfc5dae4e3 ("drm/bridge: anx7625: Add anx7625 MIPI DSI/DPI to DP") Reported-by: kernel test robot Signed-off-by: Robert Foss --- Changes since v1: -

[PATCH] drm/i915/ttm: ensure we release the intel_memory_region

2021-08-18 Thread Matthew Auld
If the ttm_bo_init_reserved() call fails ensure we also release the region, otherwise we leak the reference, or worse hit some uaf, when we start using the objects.list. Also remove the make_unshrinkable call here, which doesn't do anything. Signed-off-by: Matthew Auld Cc: Thomas Hellström ---

Re: [PATCH v8 07/34] clk: tegra: Support runtime PM and power domain

2021-08-18 Thread Dmitry Osipenko
18.08.2021 19:42, Thierry Reding пишет: > On Wed, Aug 18, 2021 at 06:05:21PM +0300, Dmitry Osipenko wrote: >> 18.08.2021 17:07, Thierry Reding пишет: >>> On Tue, Aug 17, 2021 at 04:27:27AM +0300, Dmitry Osipenko wrote: >>> [...] +struct clk *tegra_clk_register(struct clk_hw *hw) +{

Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

2021-08-18 Thread Dmitry Osipenko
18.08.2021 19:39, Thierry Reding пишет: >> We don't have a platform device for CaR. I don't see how it's going to >> work. We need to create a platform device for each RPM-capable clock >> because that's how RPM works. The compatible string is required for >> instantiating OF-devices from a node,

Re: [Intel-gfx] [PATCH] drm/damage_helper: Fix handling of cursor dirty buffers

2021-08-18 Thread Souza, Jose
On Wed, 2021-08-18 at 11:54 +0200, Daniel Vetter wrote: > On Tue, Aug 17, 2021 at 04:26:04PM -0700, José Roberto de Souza wrote: > > Cursors don't have a framebuffer so the fb comparisson was always > > failing and atomic state was being committed without any plane state. > > > > So here checking

Re: [PATCH v8 07/34] clk: tegra: Support runtime PM and power domain

2021-08-18 Thread Thierry Reding
On Wed, Aug 18, 2021 at 06:05:21PM +0300, Dmitry Osipenko wrote: > 18.08.2021 17:07, Thierry Reding пишет: > > On Tue, Aug 17, 2021 at 04:27:27AM +0300, Dmitry Osipenko wrote: > > [...] > >> +struct clk *tegra_clk_register(struct clk_hw *hw) > >> +{ > >> + struct platform_device *pdev; > >> +

Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

2021-08-18 Thread Thierry Reding
On Wed, Aug 18, 2021 at 06:05:11PM +0300, Dmitry Osipenko wrote: > 18.08.2021 16:59, Thierry Reding пишет: > > On Tue, Aug 17, 2021 at 04:27:26AM +0300, Dmitry Osipenko wrote: > >> Document tegra-clocks sub-node which describes Tegra SoC clocks that > >> require a higher voltage of the core power

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Print error name on CTB (de)registration failure

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 5:11 PM Michal Wajdeczko wrote: > > > > On 18.08.2021 16:20, Daniel Vetter wrote: > > On Thu, Jul 01, 2021 at 05:55:11PM +0200, Michal Wajdeczko wrote: > >> Instead of plain error value (%d) print more user friendly error > >> name (%pe). > >> > >> Signed-off-by: Michal

Re: [PATCH v2 1/2] dt-bindings: add bindings for the Sharp LS060T1SX01 panel

2021-08-18 Thread Dmitry Baryshkov
Hi, On Tue, 17 Aug 2021 at 21:53, Rob Herring wrote: > > On Mon, Aug 09, 2021 at 09:47:11PM +0300, Dmitry Baryshkov wrote: > > Add devicetree bindings for the Sharp LS060T1SX01 6.0" FullHD panel > > using NT35695 driver. This panel can be found i.e. in the Dragonboard > > Display Adapter bundle.

Re: [PATCH v1 3/4] arm64: dts: qcom: sc7280: Add DSI display nodes

2021-08-18 Thread Matthias Kaehlcke
On Wed, Aug 18, 2021 at 03:57:03PM +0530, Krishna Manikandan wrote: > From: Rajeev Nandan > > Add DSI controller and PHY nodes for sc7280. > > Signed-off-by: Rajeev Nandan You should sign off patches you send, even if you aren't the original author. > --- >

Re: [Intel-gfx] [PATCH v3 4/9] drm: fix potential null ptr dereferences in drm_{auth, ioctl}

2021-08-18 Thread Daniel Vetter
On Wed, Aug 18, 2021 at 5:37 PM Desmond Cheong Zhi Xi wrote: > > On 18/8/21 6:11 pm, Daniel Vetter wrote: > > On Wed, Aug 18, 2021 at 03:38:19PM +0800, Desmond Cheong Zhi Xi wrote: > >> There are three areas where we dereference struct drm_master without > >> checking if the pointer is non-NULL.

Re: [PATCH v2 53/63] KVM: x86: Use struct_group() to zero decode cache

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 03:11:28PM +, Sean Christopherson wrote: > On Tue, Aug 17, 2021, Kees Cook wrote: > > arch/x86/kvm/emulate.c | 3 +-- > > arch/x86/kvm/kvm_emulate.h | 19 +++ > > 2 files changed, 12 insertions(+), 10 deletions(-) > > > > diff --git

Re: [PATCH v2 50/63] tracing: Use memset_startat() to zero struct trace_iterator

2021-08-18 Thread Kees Cook
On Wed, Aug 18, 2021 at 09:33:49AM -0400, Steven Rostedt wrote: > On Tue, 17 Aug 2021 23:05:20 -0700 > Kees Cook wrote: > > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > > field bounds checking for memset(), avoid intentionally writing across > > neighboring fields.

Re: [PATCH v1] drm/bridge: anx7625: Don't store unread return value

2021-08-18 Thread Robert Foss
Hey Sam, > > diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c > > b/drivers/gpu/drm/bridge/analogix/anx7625.c > > index 14d73fb1dd15b..3471785915c45 100644 > > --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > > +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > > @@ -771,7 +771,7 @@ static

Re: [PATCH v1 4/4] arm64: dts: qcom: sc7280: add edp display dt nodes

2021-08-18 Thread Matthias Kaehlcke
On Wed, Aug 18, 2021 at 03:57:04PM +0530, Krishna Manikandan wrote: > From: Sankeerth Billakanti > > Add edp controller and phy DT nodes for sc7280. > > Signed-off-by: Sankeerth Billakanti > --- > arch/arm64/boot/dts/qcom/sc7280.dtsi | 127 > ++- > 1 file

Re: [PATCH v1 1/4] dt-bindings: msm: add DT bindings for sc7280

2021-08-18 Thread Rob Herring
On Wed, 18 Aug 2021 15:57:01 +0530, Krishna Manikandan wrote: > MSM Mobile Display Subsystem (MDSS) encapsulates sub-blocks > like DPU display controller, DSI, EDP etc. Add required DPU > device tree bindings for SC7280. > > Signed-off-by: Krishna Manikandan > --- >

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Dmitry Osipenko
18.08.2021 12:41, Ulf Hansson пишет: > On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: >> >> On 18-08-21, 10:29, Ulf Hansson wrote: >>> Me and Dmitry discussed adding a new genpd callback for this. I agreed >>> that it seems like a reasonable thing to add, if he insists. Either way gives the

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Dmitry Osipenko
18.08.2021 18:43, Dmitry Osipenko пишет: > 18.08.2021 13:08, Ulf Hansson пишет: >> On Wed, 18 Aug 2021 at 11:50, Viresh Kumar wrote: >>> >>> On 18-08-21, 11:41, Ulf Hansson wrote: On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: > What we need here is just configure. So something like

Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper

2021-08-18 Thread Dmitry Osipenko
18.08.2021 13:08, Ulf Hansson пишет: > On Wed, 18 Aug 2021 at 11:50, Viresh Kumar wrote: >> >> On 18-08-21, 11:41, Ulf Hansson wrote: >>> On Wed, 18 Aug 2021 at 11:14, Viresh Kumar wrote: What we need here is just configure. So something like this then: -

Re: [PATCH v3 4/9] drm: fix potential null ptr dereferences in drm_{auth,ioctl}

2021-08-18 Thread Desmond Cheong Zhi Xi
On 18/8/21 6:11 pm, Daniel Vetter wrote: On Wed, Aug 18, 2021 at 03:38:19PM +0800, Desmond Cheong Zhi Xi wrote: There are three areas where we dereference struct drm_master without checking if the pointer is non-NULL. 1. drm_getmagic is called from the ioctl_handler. Since DRM_IOCTL_GET_MAGIC

Re: [PATCH v2 53/63] KVM: x86: Use struct_group() to zero decode cache

2021-08-18 Thread Sean Christopherson
On Tue, Aug 17, 2021, Kees Cook wrote: > arch/x86/kvm/emulate.c | 3 +-- > arch/x86/kvm/kvm_emulate.h | 19 +++ > 2 files changed, 12 insertions(+), 10 deletions(-) > > diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c > index 2837110e66ed..2608a047e769 100644 >

Re: [Intel-gfx] [PATCH 2/4] drm/i915/guc: Print error name on CTB (de)registration failure

2021-08-18 Thread Michal Wajdeczko
On 18.08.2021 16:20, Daniel Vetter wrote: > On Thu, Jul 01, 2021 at 05:55:11PM +0200, Michal Wajdeczko wrote: >> Instead of plain error value (%d) print more user friendly error >> name (%pe). >> >> Signed-off-by: Michal Wajdeczko >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8

Re: [PATCH v8 07/34] clk: tegra: Support runtime PM and power domain

2021-08-18 Thread Dmitry Osipenko
18.08.2021 17:07, Thierry Reding пишет: > On Tue, Aug 17, 2021 at 04:27:27AM +0300, Dmitry Osipenko wrote: > [...] >> +struct clk *tegra_clk_register(struct clk_hw *hw) >> +{ >> +struct platform_device *pdev; >> +struct device *dev = NULL; >> +struct device_node *np; >> +const char

Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

2021-08-18 Thread Dmitry Osipenko
18.08.2021 16:59, Thierry Reding пишет: > On Tue, Aug 17, 2021 at 04:27:26AM +0300, Dmitry Osipenko wrote: >> Document tegra-clocks sub-node which describes Tegra SoC clocks that >> require a higher voltage of the core power domain in order to operate >> properly on a higher clock rates. Each

Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node

2021-08-18 Thread Dmitry Osipenko
18.08.2021 16:52, Thierry Reding пишет: > On Wed, Aug 18, 2021 at 04:44:30AM +0300, Dmitry Osipenko wrote: >> 18.08.2021 04:15, Rob Herring пишет: + tegra-clocks: +description: child nodes are the output clocks from the CAR +type: object + +patternProperties:

[PATCH 2/2] drm/i915/debugfs: hook up ttm_resource_manager_debug

2021-08-18 Thread Matthew Auld
This should give a more complete view of the various bits of internal resource manager state, for device local-memory. Signed-off-by: Matthew Auld Cc: Thomas Hellström --- drivers/gpu/drm/i915/i915_debugfs.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2] drm/i915/buddy: add some pretty printing

2021-08-18 Thread Matthew Auld
Implement the debug hook for the buddy resource manager. For this we want to print out the status of the memory manager, including how much memory is still allocatable, what page sizes we have etc. This will be triggered when TTM is unable to fulfil an allocation request for device local-memory.

Re: [PATCH v2] Revert "drm/scheduler: Avoid accessing freed bad job."

2021-08-18 Thread Andrey Grodzovsky
On 2021-08-18 10:42 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:36:32AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:32 a.m., Daniel Vetter wrote: On Wed, Aug 18, 2021 at 10:26:25AM -0400, Andrey Grodzovsky wrote: On 2021-08-18 10:02 a.m., Alex Deucher wrote: + dri-devel

Re: [PATCH v3 2/9] drm: hold master_lookup_lock when releasing a drm_file's master

2021-08-18 Thread Desmond Cheong Zhi Xi
On 18/8/21 6:05 pm, Daniel Vetter wrote: On Wed, Aug 18, 2021 at 03:38:17PM +0800, Desmond Cheong Zhi Xi wrote: When drm_file.master changes value, the corresponding drm_device.master_lookup_lock should be held. In drm_master_release, a call to drm_master_put sets the file_priv->master to

[PATCH 3/3] dt-bindings: add vendor prefix for Vivax

2021-08-18 Thread Nikola Pavlica
Add vendor prefix for the Vivax brand by M SAN Grupa d.o.o. Source (in Croatian): https://www.vivax.com/hr/o-nama.aspx Signed-off-by: Nikola Pavlica --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 2/3] dt-bindings: display: simple: Add Vivax TPC-9150 panel

2021-08-18 Thread Nikola Pavlica
This tablet display is unique and hence must be added to documentation. Unfortunately, it's real make and number is not known due to obscure and missing documentation and lack of writing on the display assembly itself. So the natural alternative that came to mind is to name the panel after the

[PATCH 1/3] drm/panel-simple: Add Vivax TPC-9150 panel v4

2021-08-18 Thread Nikola Pavlica
The model and make of the LCD panel of the Vivax TPC-9150 is unknown, hence the panel settings that were retrieved with a FEX dump are named after the device NOT the actual panel. The LCD in question is a 50 pin MISO TFT LCD panel of the resolution 1024x600 used by the aforementioned device.

  1   2   3   >