Re: [PATCH v2] drm/edid: Support type 7 timings

2022-01-24 Thread Jani Nikula
On Sun, 23 Jan 2022, Yaroslav Bolyukin wrote: > Per VESA DisplayID Standard v2.0: Type VII Timing – Detailed Timing Data > > Definitions were already provided as type I, but not used > > Signed-off-by: Yaroslav Bolyukin Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/drm_edid.c | 12

Re: [PATCH v5 4/4] dt-bindings: drm/bridge: anx7625: Add aux-bus node

2022-01-24 Thread Hsin-Yi Wang
On Wed, Jan 19, 2022 at 11:36 PM Robert Foss wrote: > > Hey Hsin-Yi, > > While I can review this patch, I don't have the authority to merge it > since it is outside the scope of my maintainership. Rob Herring, > Daniel Vetter or David Airlie would have to Ack this patch. hi Rob, Can you help

Re: [RFC PATCH v3 1/3] drm: introduce fb_modifiers_not_supported flag in mode_config

2022-01-24 Thread Esaki Tomohito
Hello Laurent-san Thank you for your reviews and advices. I'll fix this patch series following your advice. Thanks, Esaki On 2022/01/24 7:50, Laurent Pinchart wrote: Hello Esaki-san, On Fri, Jan 14, 2022 at 07:17:51PM +0900, Tomohito Esaki wrote: If only linear modifier is advertised,

Re: [PATCH] drm/i915/overlay: Prevent divide by zero bugs in scaling

2022-01-24 Thread Ville Syrjälä
On Mon, Jan 24, 2022 at 03:24:09PM +0300, Dan Carpenter wrote: > Smatch detected a divide by zero bug in check_overlay_scaling(). > > drivers/gpu/drm/i915/display/intel_overlay.c:976 check_overlay_scaling() > error: potential divide by zero bug '/ rec->dst_height'. >

Re: [PATCH v8 04/10] vgaarb: Move framebuffer detection to ADD_DEVICE path

2022-01-24 Thread Huacai Chen
Hi, Bjorn, Why this series still missing in 5.17-rc1? :( Huacai On Fri, Jan 7, 2022 at 12:21 AM Bjorn Helgaas wrote: > > On Thu, Jan 06, 2022 at 02:44:42PM +0800, Huacai Chen wrote: > > On Thu, Jan 6, 2022 at 8:07 AM Bjorn Helgaas wrote: > > > Previously we selected a device that owns the

Re: [PATCH] drm/msm/a6xx: Add missing suspend_count increment

2022-01-24 Thread Dmitry Baryshkov
On 13/01/2022 19:32, Rob Clark wrote: From: Rob Clark Reported-by: Danylo Piliaiev Fixes: 3ab1c5cc3939 ("drm/msm: Add param for userspace to query suspend count") Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov --- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 ++ 1 file changed,

Re: [PATCH] drm/msm: Fix wrong size calculation

2022-01-24 Thread Dmitry Baryshkov
On 12/01/2022 15:33, Xianting Tian wrote: For example, memory-region in .dts as below, reg = <0x0 0x5000 0x0 0x2000> We can get below values, struct resource r; r.start = 0x5000; r.end = 0x6fff; So the size should be: size = r.end - r.start + 1 = 0x2000

Re: [PATCH] drm/msm/dsi: invalid parameter check in msm_dsi_phy_enable

2022-01-24 Thread Dmitry Baryshkov
On 16/01/2022 21:18, José Expósito wrote: The function performs a check on the "phy" input parameter, however, it is used before the check. Initialize the "dev" variable after the sanity check to avoid a possible NULL pointer dereference. Fixes: 5c8290284402b ("drm/msm/dsi: Split PHY drivers

Re: [v3 2/3] drm/msm/dsi: Add dsi phy tuning configuration support

2022-01-24 Thread Dmitry Baryshkov
On 18/01/2022 23:38, Rajeev Nandan wrote: Add support for MSM DSI PHY tuning configuration. Current design is to support drive strength and drive level/amplitude tuning for 10nm PHY version, but this can be extended to other PHY versions. Signed-off-by: Rajeev Nandan Reviewed-by: Dmitry

Re: [v3 3/3] drm/msm/dsi: Add 10nm dsi phy tuning configuration support

2022-01-24 Thread Dmitry Baryshkov
On 18/01/2022 23:38, Rajeev Nandan wrote: The clock and data lanes of the DSI PHY have a calibration circuitry feature. As per the MSM DSI PHY tuning guidelines, the drive strength tuning can be done by adjusting rescode offset for hstop/hsbot, and the drive level tuning can be done by adjusting

Re: [PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 14:44:52) > DP driver is a generic driver which supports both eDP and DP. > For debugging purpose it is required to have capabilities to > differentiate message are generated from eDP or DP. This patch > add connector type into debug messages for this purpose. > >

[PATCH v2] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector mode list as backup mode. This patch fixes test case 4.2.2.1. Changes in v2: -- add

[Bug 201957] amdgpu: ring gfx timeout

2022-01-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201957 --- Comment #57 from Spencer (s...@nandre.com) --- Created attachment 300315 --> https://bugzilla.kernel.org/attachment.cgi?id=300315=edit Kernel config OS: Gentoo Kernel: 5.15.16, config attached, built with make -j12 Launch options:

linux-next: manual merge of the drm-intel-gt tree with the drm-intel tree

2022-01-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel-gt tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commit: 2ef97818d3aa ("drm/i915: split out i915_gem_evict.h from i915_drv.h") from the drm-intel tree and commit: 7e00897be8bf ("drm/i915: Add object locking to

[Bug 215436] admgpu: suspend and resuming from suspend don't work

2022-01-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215436 --- Comment #28 from mario.limoncie...@amd.com --- As this is now in 5.17-rc1: https://github.com/torvalds/linux/commit/c4849f88164b13dd141885e28210f599741b304b this issue can be closed. -- You may reply to this email to add a comment. You are

[PATCH] drm/msm/dp: add connector type to enhance debug messages

2022-01-24 Thread Kuogee Hsieh
DP driver is a generic driver which supports both eDP and DP. For debugging purpose it is required to have capabilities to differentiate message are generated from eDP or DP. This patch add connector type into debug messages for this purpose. Signed-off-by: Kuogee Hsieh ---

Re: [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 11:37:03PM +0100, Helge Deller wrote: > On 1/24/22 23:19, Daniel Vetter wrote: > > On Mon, Jan 24, 2022 at 10:03:17PM +0100, Helge Deller wrote: > >> This series reverts two patches which disabled scrolling acceleration in > >> fbcon/fbdev. Those patches introduced a

linux-next: manual merge of the drm-intel tree with Linus' tree

2022-01-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_pm.c between commit: cca084692394 ("drm/i915: Use per device iommu check") from Linus' tree and commit: 8172375ea95a ("drm/i915: Remove zombie async flip vt-d w/a") from the drm-intel

Re: [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-24 Thread Helge Deller
On 1/24/22 23:19, Daniel Vetter wrote: > On Mon, Jan 24, 2022 at 10:03:17PM +0100, Helge Deller wrote: >> This series reverts two patches which disabled scrolling acceleration in >> fbcon/fbdev. Those patches introduced a regression for fbdev-supported >> graphic >> cards because of the

linux-next: manual merge of the drm-intel tree with Linus' tree

2022-01-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/i915_reg.h between commit: 77cdd054dd2c ("drm/i915/pmu: Connect engine busyness stats from GuC to pmu") from Linus' tree and commit: 202b1f4c1234 ("drm/i915/gt: Move engine registers to their

Re: [PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 10:03:17PM +0100, Helge Deller wrote: > This series reverts two patches which disabled scrolling acceleration in > fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic > cards because of the performance penalty by doing screen scrolling by software

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Alex Deucher
On Mon, Jan 24, 2022 at 5:16 PM Daniel Vetter wrote: > > Also add notes that for atomic drivers it's really somewhere else and > no longer in struct drm_crtc. > > Maybe we should put a bigger warning here that this is confusing, > since the pixel format is a plane property, but the GAMMA_LUT

[PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Daniel Vetter
Also add notes that for atomic drivers it's really somewhere else and no longer in struct drm_crtc. Maybe we should put a bigger warning here that this is confusing, since the pixel format is a plane property, but the GAMMA_LUT property is on the crtc. But I think we can fix this if/when someone

Re: [PATCH -next] drm/amd/display: don't use /** for non-kernel-doc comments

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 10:25 AM Harry Wentland wrote: > > On 2022-01-21 20:23, Randy Dunlap wrote: > > Change a static function's comment from "/**" (indicating kernel-doc > > notation) to "/*" (indicating a regular C language comment). > > This prevents multiple

Re: [PATCH] drm/radeon: remove redundant assignment to reg

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:21 PM Nick Desaulniers wrote: > > On Wed, Jan 19, 2022 at 2:46 PM Colin Ian King wrote: > > > > The pointer reg is being assigned a value that is not read, the > > exit path via label 'out' never accesses it. The assignment is > > redundant and

Re: [PATCH v2] drm/amd/pm: return -ENOTSUPP if there is no get_dpm_ultimate_freq function

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 3:18 PM wrote: > > From: Tom Rix > > clang static analysis reports this represenative problem > amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value > return clk_freq * 100; > ^ > > If there is

Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 13:24:25) > > On 1/24/2022 1:04 PM, Stephen Boyd wrote: > > Quoting Kuogee Hsieh (2022-01-24 12:46:10) > >> Some of DP link compliant test expects to return fail-safe mode > >> if prefer detailed timing mode can not be supported by mainlink's > >> lane and rate

Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
On 1/24/2022 1:04 PM, Stephen Boyd wrote: Quoting Kuogee Hsieh (2022-01-24 12:46:10) Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector

[PATCH 5.16 0299/1039] drm/tegra: vic: Fix DMA API misuse

2022-01-24 Thread Greg Kroah-Hartman
From: Robin Murphy [ Upstream commit 5566174cb10a5167d59b0793871cab7990b149b8 ] Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little

[PATCH v2 1/2] Revert "fbdev: Garbage collect fbdev scrolling acceleration, part 1 (from TODO list)"

2022-01-24 Thread Helge Deller
This reverts commit b3ec8cdf457e5e63d396fe1346cc788cf7c1b578. Revert the second (of 2) commits which disabled scrolling acceleration in fbcon/fbdev. It introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of

[PATCH v2 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Helge Deller
This reverts commit 39aead8373b3c20bb5965c024dfb51a94e526151. Revert the first (of 2) commits which disabled scrolling acceleration in fbcon/fbdev. It introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of

[PATCH v2 0/2] Fix regression introduced by disabling accelerated scrolling in fbcon

2022-01-24 Thread Helge Deller
This series reverts two patches which disabled scrolling acceleration in fbcon/fbdev. Those patches introduced a regression for fbdev-supported graphic cards because of the performance penalty by doing screen scrolling by software instead of using existing 2D hardware acceleration. This series

Re: [PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Stephen Boyd
Quoting Kuogee Hsieh (2022-01-24 12:46:10) > Some of DP link compliant test expects to return fail-safe mode > if prefer detailed timing mode can not be supported by mainlink's > lane and rate after link training. Therefore add fail-safe mode > into connector mode list as backup mode. This patch

[PATCH 5.16 0073/1039] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()

2022-01-24 Thread Greg Kroah-Hartman
From: Thomas Hellström commit 95d35838880fb040ccb9fe4a48816bd0c8b62df5 upstream. If a dma_fence_array is reported signaled by a call to dma_fence_is_signaled(), it may leak the PENDING_ERROR status. Fix this by clearing the PENDING_ERROR status if we return true in dma_fence_array_signaled().

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 9:41 PM Laurent Pinchart wrote: > > Hi Daniel, > > On Mon, Jan 24, 2022 at 09:28:09PM +0100, Daniel Vetter wrote: > > On Mon, Jan 24, 2022 at 9:24 PM Laurent Pinchart wrote: > > > On Mon, Jan 24, 2022 at 08:47:06PM +0100, Daniel Vetter wrote: > > > > Also add notes that

[PATCH] drm/msm/dp: always add fail-safe mode into connector mode list

2022-01-24 Thread Kuogee Hsieh
Some of DP link compliant test expects to return fail-safe mode if prefer detailed timing mode can not be supported by mainlink's lane and rate after link training. Therefore add fail-safe mode into connector mode list as backup mode. This patch fixes test case 4.2.2.1. Signed-off-by: Kuogee

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Laurent Pinchart
Hi Daniel, On Mon, Jan 24, 2022 at 09:28:09PM +0100, Daniel Vetter wrote: > On Mon, Jan 24, 2022 at 9:24 PM Laurent Pinchart wrote: > > On Mon, Jan 24, 2022 at 08:47:06PM +0100, Daniel Vetter wrote: > > > Also add notes that for atomic drivers it's really somewhere else and > > > no longer in

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 9:24 PM Laurent Pinchart wrote: > > Hi Daniel, > > Thank you for the patch. > > On Mon, Jan 24, 2022 at 08:47:06PM +0100, Daniel Vetter wrote: > > Also add notes that for atomic drivers it's really somewhere else and > > no longer in struct drm_crtc. > > > > Maybe we

Re: [PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Mon, Jan 24, 2022 at 08:47:06PM +0100, Daniel Vetter wrote: > Also add notes that for atomic drivers it's really somewhere else and > no longer in struct drm_crtc. > > Maybe we should put a bigger warning here that this is confusing, > since the pixel

[PATCH 5.15 257/846] drm/tegra: vic: Fix DMA API misuse

2022-01-24 Thread Greg Kroah-Hartman
From: Robin Murphy [ Upstream commit 5566174cb10a5167d59b0793871cab7990b149b8 ] Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little

Re: [Intel-gfx] [PATCH 06/11] dma-buf: warn about containers in dma_resv object

2022-01-24 Thread Christian König
Am 24.01.22 um 17:36 schrieb Thomas Hellström (Intel): On 1/24/22 14:03, Christian König wrote: Drivers should not add containers as shared fences to the dma_resv object, instead each fence should be added individually. Signed-off-by: Christian König Reviewed-by: Daniel Vetter

Re: [PATCH 01/11] drm/radeon: use ttm_resource_manager_debug

2022-01-24 Thread Christian König
Am 24.01.22 um 17:33 schrieb Thomas Hellström: On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote: Instead of calling the debug operation directly. Signed-off-by: Christian König Reviewed-by: Huang Rui The first two patches seem unrelated to the series. No idea what happened here,

[PATCH v2] drm/amd/pm: return -ENOTSUPP if there is no get_dpm_ultimate_freq function

2022-01-24 Thread trix
From: Tom Rix clang static analysis reports this represenative problem amdgpu_smu.c:144:18: warning: The left operand of '*' is a garbage value return clk_freq * 100; ^ If there is no get_dpm_ultimate_freq function, smu_get_dpm_freq_range returns success without

[PATCH 5.15 068/846] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()

2022-01-24 Thread Greg Kroah-Hartman
From: Thomas Hellström commit 95d35838880fb040ccb9fe4a48816bd0c8b62df5 upstream. If a dma_fence_array is reported signaled by a call to dma_fence_is_signaled(), it may leak the PENDING_ERROR status. Fix this by clearing the PENDING_ERROR status if we return true in dma_fence_array_signaled().

Re: [PATCH] drm/amd/display: Fix a NULL pointer dereference in amdgpu_dm_connector_add_common_modes()

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote: > > In amdgpu_dm_connector_add_common_modes(), amdgpu_dm_create_common_mode() > is assigned to mode and is passed to drm_mode_probed_add() directly after > that. drm_mode_probed_add() passes >head to list_add_tail(),

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 7:27 PM Geert Uytterhoeven wrote: > > Hi Daniel et al, > > On Wed, Jan 19, 2022 at 4:39 PM Daniel Vetter wrote: > > On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: > > > Helge Deller writes: > > > > I may have missed some discussions, but I'm objecting

[PATCH 5.10 171/563] drm/tegra: vic: Fix DMA API misuse

2022-01-24 Thread Greg Kroah-Hartman
From: Robin Murphy [ Upstream commit 5566174cb10a5167d59b0793871cab7990b149b8 ] Upon failure, dma_alloc_coherent() returns NULL. If that does happen, passing some uninitialised stack contents to dma_mapping_error() - which belongs to a different API in the first place - has precious little

[PATCH] drm/docs: Document where the C8 color lut is stored

2022-01-24 Thread Daniel Vetter
Also add notes that for atomic drivers it's really somewhere else and no longer in struct drm_crtc. Maybe we should put a bigger warning here that this is confusing, since the pixel format is a plane property, but the GAMMA_LUT property is on the crtc. But I think we can fix this if/when someone

[PATCH 5.10 035/563] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()

2022-01-24 Thread Greg Kroah-Hartman
From: Thomas Hellström commit 95d35838880fb040ccb9fe4a48816bd0c8b62df5 upstream. If a dma_fence_array is reported signaled by a call to dma_fence_is_signaled(), it may leak the PENDING_ERROR status. Fix this by clearing the PENDING_ERROR status if we return true in dma_fence_array_signaled().

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 7:51 PM Geert Uytterhoeven wrote: > > Hi Daniel, > > On Thu, Jan 20, 2022 at 1:33 PM Daniel Vetter wrote: > > But reading code is too hard I guess, safer to assume it's just > > broken and not supported. > > I confirm there's lots of documentation (and even more code ;-),

[PATCH 5.4 027/320] dma_fence_array: Fix PENDING_ERROR leak in dma_fence_array_signaled()

2022-01-24 Thread Greg Kroah-Hartman
From: Thomas Hellström commit 95d35838880fb040ccb9fe4a48816bd0c8b62df5 upstream. If a dma_fence_array is reported signaled by a call to dma_fence_is_signaled(), it may leak the PENDING_ERROR status. Fix this by clearing the PENDING_ERROR status if we return true in dma_fence_array_signaled().

Re: [PATCH] drm/amd/display/dc/calcs/dce_calcs: Fix a memleak in calculate_bandwidth()

2022-01-24 Thread Alex Deucher
Applied. Thanks! Alex On Mon, Jan 24, 2022 at 12:05 PM Zhou Qingyang wrote: > > In calculate_bandwidth(), the tag free_sclk and free_yclk are reversed, > which could lead to a memory leak of yclk. > > Fix this bug by changing the location of free_sclk and free_yclk. > > This bug was found by a

Re: [PATCH v1 2/2] drm/panel-edp: Add sharp panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:16 AM Sankeerth Billakanti wrote: > > Add eDP panel support for sc7280 CRD platform. > > Signed-off-by: Sankeerth Billakanti > --- > drivers/gpu/drm/panel/panel-edp.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-24 Thread Thomas Zimmermann
Hi Am 24.01.22 um 19:38 schrieb Geert Uytterhoeven: Hi Daniel, On Fri, Jan 21, 2022 at 9:55 AM Daniel Vetter wrote: Just to clarify, since we had lots of smaller and bigger misunderstandings in the thread thus far: DRM_FORMAT_RGB332 exists, so drm support that already. The fbdev emulation

Re: [PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-01-24 Thread Doug Anderson
Hi, On Mon, Jan 24, 2022 at 10:15 AM Sankeerth Billakanti wrote: > > Enable the eDP display panel support with backlight on sc7280 platform. > > Signed-off-by: Sankeerth Billakanti > --- > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127 > > 1 file changed, 127

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-24 Thread Geert Uytterhoeven
Hi Daniel, On Thu, Jan 20, 2022 at 1:33 PM Daniel Vetter wrote: > But reading code is too hard I guess, safer to assume it's just > broken and not supported. I confirm there's lots of documentation (and even more code ;-), which is always great! But both are intimidating to me, and most of the

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 7:39 PM Geert Uytterhoeven wrote: > > Hi Daniel, > > On Fri, Jan 21, 2022 at 9:55 AM Daniel Vetter wrote: > > Just to clarify, since we had lots of smaller and bigger > > misunderstandings in the thread thus far: DRM_FORMAT_RGB332 exists, so > > drm support that already.

Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer

2022-01-24 Thread Geert Uytterhoeven
Hi Daniel, On Fri, Jan 21, 2022 at 9:55 AM Daniel Vetter wrote: > Just to clarify, since we had lots of smaller and bigger > misunderstandings in the thread thus far: DRM_FORMAT_RGB332 exists, so > drm support that already. The fbdev emulation doesn't yet, but all > that's needed for that is

Re: fbdev: Garbage collect fbdev scrolling acceleration

2022-01-24 Thread Geert Uytterhoeven
Hi Daniel et al, On Wed, Jan 19, 2022 at 4:39 PM Daniel Vetter wrote: > On Thu, Jan 13, 2022 at 10:46:03PM +0100, Sven Schnelle wrote: > > Helge Deller writes: > > > I may have missed some discussions, but I'm objecting against this patch: > > > > > > b3ec8cdf457e5 ("fbdev: Garbage collect

Re: [PATCH V2 0/7] DRM kmap() fixes and kmap_local_page() conversions

2022-01-24 Thread Ira Weiny
On Mon, Jan 24, 2022 at 01:08:26PM +0100, Christian König wrote: > Am 24.01.22 um 02:54 schrieb ira.we...@intel.com: > > From: Ira Weiny > > > > Changes from V1: > > Use memcpy_to_page() where appropriate > > Rebased to latest > > > > The kmap() call may cause issues with work being

[PATCH v1 2/2] drm/panel-edp: Add sharp panel support for sc7280

2022-01-24 Thread Sankeerth Billakanti
Add eDP panel support for sc7280 CRD platform. Signed-off-by: Sankeerth Billakanti --- drivers/gpu/drm/panel/panel-edp.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c index 176ef0c..bb2e346 100644 ---

[PATCH v1 1/2] ARM64: dts: qcom: enable eDP panel support for sc7280

2022-01-24 Thread Sankeerth Billakanti
Enable the eDP display panel support with backlight on sc7280 platform. Signed-off-by: Sankeerth Billakanti --- arch/arm64/boot/dts/qcom/sc7280-crd.dts | 127 1 file changed, 127 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts

[PATCH v1 0/2] Add support for the eDP panel on sc7280 CRD

2022-01-24 Thread Sankeerth Billakanti
Add support for the eDP panel on sc7280 CRD platform. These changes are dependent on the following series: https://patchwork.kernel.org/project/linux-arm-msm/list/?series=586263=both=* https://patchwork.kernel.org/project/linux-arm-msm/list/?series=560587=%2A=both Sankeerth Billakanti (2):

Re: [PATCH 2/3] drm/arm/komeda : change driver to use drm_writeback_connector.base pointer

2022-01-24 Thread Carsten Haitzler
This makes sense given the other patches in your series, but it seems as yet no one has anything to say about this. I don't have anything specific to comment on other than it seems to make the correct changes to komeda given the rest. Reviewed-by: Carsten Haitzler On 1/11/22 10:18, Kandpal,

Re: [PATCH 02/60] drm/arm/hdlcd: Add support for the nomodeset kernel parameter

2022-01-24 Thread Carsten Haitzler
Seems fine. Reviewed-by: Carsten Haitzler On 12/15/21 00:59, Javier Martinez Canillas wrote: According to disable Documentation/admin-guide/kernel-parameters.txt, this parameter can be used to disable kernel modesetting. DRM drivers will not perform display-mode changes or accelerated

Re: [PATCH 01/60] drm/komeda: Add support for the nomodeset kernel parameter

2022-01-24 Thread Carsten Haitzler
Seems fine. Reviewed-by: Carsten Haitzler On 12/15/21 00:59, Javier Martinez Canillas wrote: According to disable Documentation/admin-guide/kernel-parameters.txt, this parameter can be used to disable kernel modesetting. DRM drivers will not perform display-mode changes or accelerated

Re: [PATCH 03/60] drm/malidp: Add support for the nomodeset kernel parameter

2022-01-24 Thread Carsten Haitzler
Seems fine to me. Reviewed-by: Carsten Haitzler On 12/15/21 00:59, Javier Martinez Canillas wrote: According to disable Documentation/admin-guide/kernel-parameters.txt, this parameter can be used to disable kernel modesetting. DRM drivers will not perform display-mode changes or accelerated

Re: [PATCH] drm/nouveau: fix off by one in BIOS boundry checking

2022-01-24 Thread Karol Herbst
On Sat, Jan 22, 2022 at 11:44 AM Nick Lopez wrote: > > Bounds checking when parsing init scripts embedded in the BIOS reject > access to the last byte. This causes driver initialization to fail on > Apple eMac's with GeForce 2 MX GPUs, leaving the system with no working > console. > > This is

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Noralf Trønnes
Den 24.01.2022 17.42, skrev Rob Herring: > On Mon, Jan 24, 2022 at 10:28 AM Noralf Trønnes wrote: >> >> >> >> Den 24.01.2022 17.08, skrev Rob Herring: >>> On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: Add binding for MIPI DBI compatible SPI panels. >>> >>> I'm sure we

[PATCH 6/6 v2] drm/vc4: dpi: Support DPI interface in mode3 for RGB565

2022-01-24 Thread Chris Morgan
From: Chris Morgan Add support for the VC4 DPI driver to utilize DPI mode 3. This is defined here as xxxRxxGGxxxB: https://www.raspberrypi.com/documentation/computers/raspberry-pi.html#parallel-display-interface-dpi This mode is required to use the Geekworm MZP280 DPI display.

[PATCH 4/6 v2] dt-bindings: display: simple: add Geekworm MZP280 Panel

2022-01-24 Thread Chris Morgan
From: Chris Morgan The Geekworm MZP280 panel is a 480x640 (portrait) panel with a capacitive touch interface and a 40 pin header meant to interface directly with the Raspberry Pi. The screen is 2.8 inches diagonally, and there appear to be at least 4 distinct versions all with the same panel

[PATCH 1/6 v2] dt-bindings: vendor-prefixes: Add Geekworm

2022-01-24 Thread Chris Morgan
From: Chris Morgan Add vendor prefix for Geekworm (https://geekworm.com). Signed-off-by: Chris Morgan --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml

[PATCH 5/6 v2] drm/panel: simple: add Geekworm MZP280 Panel

2022-01-24 Thread Chris Morgan
From: Chris Morgan Add support for the Geekworm MZP280 Panel Signed-off-by: Chris Morgan Acked-by: Maxime Ripard --- drivers/gpu/drm/panel/panel-simple.c | 29 1 file changed, 29 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c

[PATCH 3/6 v2] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-01-24 Thread Chris Morgan
From: Chris Morgan Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm MZP280 panel for the Raspberry Pi. Signed-off-by: Chris Morgan --- include/uapi/linux/media-bus-format.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 2/6 v2] media: uapi: Document format MEDIA_BUS_FMT_RGB565_1X24_CPADHI

2022-01-24 Thread Chris Morgan
From: Chris Morgan Add support for MEDIA_BUS_FMT_RGB565_1X24_CPADHI. This format is used by the Geekworm MZP280 panel which interfaces with the Raspberry Pi. Signed-off-by: Chris Morgan --- .../media/v4l/subdev-formats.rst | 37 +++ 1 file changed, 37

[PATCH 0/6 v2] Support Geekworm MZP280 Panel for Raspberry Pi

2022-01-24 Thread Chris Morgan
From: Chris Morgan This patch series is to add support for the MZP280 panel for the Raspberry Pi. This panel requires adding support for Mode 3 of the Raspberry Pi DPI connector, which necessitates a new media bus format. This patch series has been tested on my Raspberry Pi 4 with version 1 of

Re: [PATCH 08/11] dma-buf: add dma_fence_chain_contained helper

2022-01-24 Thread Thomas Hellström
On 1/24/22 14:03, Christian König wrote: It's a reoccurring pattern that we need to extract the fence from a dma_fence_chain object. Add a helper for this. Signed-off-by: Christian König Reviewed-by: Thomas Hellström --- drivers/dma-buf/dma-fence-chain.c | 6 ++

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Rob Herring
On Mon, Jan 24, 2022 at 10:28 AM Noralf Trønnes wrote: > > > > Den 24.01.2022 17.08, skrev Rob Herring: > > On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: > >> > >> Add binding for MIPI DBI compatible SPI panels. > > > > I'm sure we already have MIPI DBI panels. What's this for? > > > >

Re: [Intel-gfx] [PATCH 06/11] dma-buf: warn about containers in dma_resv object

2022-01-24 Thread Intel
On 1/24/22 14:03, Christian König wrote: Drivers should not add containers as shared fences to the dma_resv object, instead each fence should be added individually. Signed-off-by: Christian König Reviewed-by: Daniel Vetter Reviewed-by: Thomas Hellström Is there any indication that this

Re: [PATCH 01/11] drm/radeon: use ttm_resource_manager_debug

2022-01-24 Thread Thomas Hellström
On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote: > Instead of calling the debug operation directly. > > Signed-off-by: Christian König > Reviewed-by: Huang Rui The first two patches seem unrelated to the series. Also is there a chance of a series cover-letter? Thanks, Thomas > ---

Re: [PATCH 04/11] dma-buf: warn about dma_fence_array container rules v2

2022-01-24 Thread Thomas Hellström
On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote: > It's not allowed to nest another dma_fence container into a > dma_fence_array > or otherwise we can run into recursion. > > Warn about that when we create a dma_fence_array. > > v2: fix comment style and typo in the warning pointed out

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Noralf Trønnes
Den 24.01.2022 17.08, skrev Rob Herring: > On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: >> >> Add binding for MIPI DBI compatible SPI panels. > > I'm sure we already have MIPI DBI panels. What's this for? > It aims to use one driver to cover all MIPI DBI panels where the

Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

2022-01-24 Thread Carsten Haitzler
I sent an updated patch with the Fixes: On 1/24/22 16:13, Steven Price wrote: On 24/01/2022 15:13, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. Signed-off-by: Carsten Haitzler To add the context,

[PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

2022-01-24 Thread carsten . haitzler
From: Carsten Haitzler Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. Fixes: 09717af7d13d ("drm: Remove CONFIG_DRM_KMS_CMA_HELPER option") Signed-off-by: Carsten Haitzler --- drivers/gpu/drm/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] drm/arm: arm hdlcd select DRM_GEM_CMA_HELPER

2022-01-24 Thread Steven Price
On 24/01/2022 15:13, carsten.haitz...@foss.arm.com wrote: > From: Carsten Haitzler > > Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. > > Signed-off-by: Carsten Haitzler To add the context, DRM_HDLCD used to select DRM_KMS_CMA_HELPER but that was removed in commit

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Thomas Zimmermann
Hi Am 24.01.22 um 16:50 schrieb Geert Uytterhoeven: On Mon, Jan 24, 2022 at 12:33 PM Thomas Zimmermann wrote: With fbdev emulation, every DRM driver is an fbdev driver too. So Some are even without? drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: ret = register_framebuffer(info); Well, I counted

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Rob Herring
On Sun, Jan 23, 2022 at 11:25 AM Noralf Trønnes wrote: > > Add binding for MIPI DBI compatible SPI panels. I'm sure we already have MIPI DBI panels. What's this for? > > Signed-off-by: Noralf Trønnes > --- > .../display/panel/panel-mipi-dbi-spi.yaml | 69 +++ > 1 file

Re: [PATCH V2 3/7] drm/gma: Remove calls to kmap()

2022-01-24 Thread Daniel Vetter
On Sun, Jan 23, 2022 at 05:54:05PM -0800, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap() is being deprecated and these instances are easy to convert to > kmap_local_page(). > > Furthermore, in gma_crtc_cursor_set() use the memcpy_from_page() helper > instead of an open coded use of

Re: [PATCH 1/6] dt-bindings: input: touchscreen: add bindings for focaltech, fts

2022-01-24 Thread Rob Herring
On Sun, 23 Jan 2022 17:37:27 +, Caleb Connolly wrote: > Add devicetree bindings for the Focaltech FTS touchscreen drivers. > > Signed-off-by: Caleb Connolly > --- > .../input/touchscreen/focaltech,fts.yaml | 78 +++ > 1 file changed, 78 insertions(+) > create mode

Re: [PATCH 1/3] dt-bindings: display: add bindings for MIPI DBI compatible SPI panels

2022-01-24 Thread Rob Herring
On Sun, 23 Jan 2022 18:25:18 +0100, Noralf Trønnes wrote: > Add binding for MIPI DBI compatible SPI panels. > > Signed-off-by: Noralf Trønnes > --- > .../display/panel/panel-mipi-dbi-spi.yaml | 69 +++ > 1 file changed, 69 insertions(+) > create mode 100644 >

Re: [PATCH 2/5] drivers/firmware: Don't mark as busy the simple-framebuffer IO resource

2022-01-24 Thread Zack Rusin
On Mon, 2022-01-24 at 13:36 +0100, Thomas Zimmermann wrote: > From: Javier Martinez Canillas > > The sysfb_create_simplefb() function requests a IO memory resource for > the > simple-framebuffer platform device, but it also marks it as busy which > can > lead to drivers requesting the same

Re: [PATCH 1/5] fbdev: Hot-unplug firmware fb devices on forced removal

2022-01-24 Thread Zack Rusin
On Mon, 2022-01-24 at 13:36 +0100, Thomas Zimmermann wrote: > Hot-unplug all firmware-framebuffer devices as part of removing > them via remove_conflicting_framebuffers() et al. Releases all > memory regions to be acquired by native drivers. > > Firmware, such as EFI, install a framebuffer while

Re: [PATCH] drm/arm: Fix hdlcd selects to add DRM_GEM_CMA_HELPER for build

2022-01-24 Thread Carsten Haitzler
Sorry - I meant disregard THIS one - following patch is right. On 1/24/22 14:58, carsten.haitz...@foss.arm.com wrote: From: Carsten Haitzler Without DRM_GEM_CMA_HELPER HDLCD won't build. This needs to be there too. Signed-off-by: Carsten Haitzler --- drivers/gpu/drm/arm/Kconfig | 1 + 1

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Daniel Vetter
On Mon, Jan 24, 2022 at 04:29:34PM +0100, Helge Deller wrote: > On 1/24/22 12:50, Javier Martinez Canillas wrote: > > On 1/24/22 12:33, Thomas Zimmermann wrote: > > > > [snip] > > > >>> Thoughts? > >> > >> I can't say I approve keeping fbdev alive, but... > >> > >> With fbdev emulation, every DRM

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Geert Uytterhoeven
On Mon, Jan 24, 2022 at 12:33 PM Thomas Zimmermann wrote: > With fbdev emulation, every DRM driver is an fbdev driver too. So Some are even without? drivers/gpu/drm/vmwgfx/vmwgfx_fb.c: ret = register_framebuffer(info); Gr{oetje,eeting}s, Geert -- Geert

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Geert Uytterhoeven
Hi Helge, On Mon, Jan 24, 2022 at 4:30 PM Helge Deller wrote: > On 1/24/22 12:50, Javier Martinez Canillas wrote: > > On 1/24/22 12:33, Thomas Zimmermann wrote: > > > > [snip] > > > >>> Thoughts? > >> > >> I can't say I approve keeping fbdev alive, but... > >> > >> With fbdev emulation, every

Re: [Intel-gfx] [PATCH] drm/i915: Lock dpt_obj around set_cache_level.

2022-01-24 Thread Intel
On 1/24/22 14:02, Maarten Lankhorst wrote: set_cache_level may unbind the object, which will result in the below lockdep splat: <6> [184.578145] [IGT] kms_addfb_basic: starting subtest addfb25-framebuffer-vs-set-tiling <4> [184.578220] [ cut here ] <4> [184.578221]

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Thomas Zimmermann
Hi Am 24.01.22 um 16:29 schrieb Helge Deller: On 1/24/22 12:50, Javier Martinez Canillas wrote: On 1/24/22 12:33, Thomas Zimmermann wrote: [snip] Thoughts? I can't say I approve keeping fbdev alive, but... With fbdev emulation, every DRM driver is an fbdev driver too. So CONFIG_FB_DRIVER

Re: [PATCH 2/2] Revert "fbcon: Disable accelerated scrolling"

2022-01-24 Thread Helge Deller
On 1/24/22 12:50, Javier Martinez Canillas wrote: > On 1/24/22 12:33, Thomas Zimmermann wrote: > > [snip] > >>> Thoughts? >> >> I can't say I approve keeping fbdev alive, but... >> >> With fbdev emulation, every DRM driver is an fbdev driver too. So >> CONFIG_FB_DRIVER is somewhat misleading.

Re: [PATCH 11/11] drm/vmwgfx: remove vmw_wait_dma_fence

2022-01-24 Thread Zack Rusin
On Mon, 2022-01-24 at 14:03 +0100, Christian König wrote: > Decomposing fence containers don't seem to make any sense here. > > So just remove the function entirely and call dma_fence_wait() > directly. > > Signed-off-by: Christian König > Cc: VMware Graphics > Cc: Zack Rusin Looks good.

  1   2   >